--
v3: setupapi: Fix testing for a non-empty string in get_source_info().
setupapi/tests: Test installing an INF file with architecture-specific SourceDisks* sections.
setupapi: Use SetupGetSourceInfo() in get_source_info().
setupapi: Use SetupGetSourceFileLocation() in get_source_info().
https://gitlab.winehq.org/wine/wine/-/merge_requests/6089
On Wed Jul 17 17:12:01 2024 +0000, Tim Clem wrote:
> Filing a bug is probably the right thing to do. I don't know offhand who
> would know best - I'm not very familiar with that area myself. In
> ntdll/unix/virtual.c, the address space limit is hardcoded to
> 0x7fffffff0000 for x86_64, but on ARM it looks like we try to detect it
> (see `get_host_addr_space_limit`). For the bug, it would be interesting
> to attach a +virtual log, so we can see what `get_host_addr_space_limit` returned.
The issue I am having is when fully emulating x86_64 wine on arm64 using the likes of box64/fex/qemu. So the hardcode makes sense why the problem is happening. Thanks for the info, I'll look into using `get_host_addr_space_limit` for all architectures.
--
https://gitlab.winehq.org/wine/wine/-/merge_requests/3598#note_76437
On Wed Jul 17 17:12:01 2024 +0000, theofficialgman wrote:
> Thanks Tim. Should I file a bug for this then or are you aware of who
> might be more knowledgeable about the allocation system and why its
> attempting to allocate memory outside of address limit?
Filing a bug is probably the right thing to do. I don't know offhand who would know best - I'm not very familiar with that area myself. In ntdll/unix/virtual.c, the address space limit is hardcoded to 0x7fffffff0000 for x86_64, but on ARM it looks like we try to detect it (see `get_host_addr_space_limit`). For the bug, it would be interesting to attach a +virtual log, so we can see what `get_host_addr_space_limit` returned.
--
https://gitlab.winehq.org/wine/wine/-/merge_requests/3598#note_76436
Somehow the field is not present for sound capture devices, at least on my Win11.
Fixes Tom Clancy's Splinter Cell: Conviction not finding any sound devices and refusing to start.
--
v2: dxdiagn: Fill szHardwareId for sound render devices.
https://gitlab.winehq.org/wine/wine/-/merge_requests/6097
This is part XX1 of cmd engine rewrite.
It covers:
- tests & fixes for success/failure of changing current drive,
- tests & fixes for success/failure when using pipes,
- new implementation of CHOICE command.
Notes:
- CHOICE is not a builtin command in native cmd.exe,
but I kept it builtin for simplicity,
- CHOICE was (partially) implemented using syntax from
MS-DOS days; it has been moved to use Windows' syntax.
--
https://gitlab.winehq.org/wine/wine/-/merge_requests/6090