On Tue Jul 16 16:03:49 2024 +0000, Rémi Bernon wrote:
> Fwiw 65165cf8520f85ac327115536749cda1aabef77b causes some ddraw tests failures.
Yep, already addressed in 6080. Sorry, I don't know how this one slipped past me, I know I ran the tests...
--
https://gitlab.winehq.org/wine/wine/-/merge_requests/5946#note_76331
Except for nodes with custom properties, those still need more work on the infrastructure. jscript change is just minimum needed to allow objects with only builtin properties to preserve their current behavior, I have more tweaks for that area queued for "async" custom properties.
--
https://gitlab.winehq.org/wine/wine/-/merge_requests/6092
The function SQLBindParam was missed when binding all the available functions. Will implement the SQLBindParam in a future patchset.
The other is just a fix for when parameters are NULL when passed in (Same the the W version).
--
v7: odbc32: SQLError/W handle NULL handles
https://gitlab.winehq.org/wine/wine/-/merge_requests/6063
The function SQLBindParam was missed when binding all the available functions. Will implement the SQLBindParam in a future patchset.
The other is just a fix for when parameters are NULL when passed in (Same the the W version).
--
v6: odbc32: SQLError/W handle NULL handles
https://gitlab.winehq.org/wine/wine/-/merge_requests/6063
Fixes Bug 23029 (Devil May Cry® 3 Special Edition) (6550) Intro Video is covered by green, transparent square for a majority of it.
Before these patches, surface data for planar formats is not copied
correctly when the application uses a custom allocator-presenter and
allocates a surface of different size than the VMR9 source.
Patch 2/2 adds support for performing this copy correctly when the
source dimensions are less or equal than the rendering surface
dimensions.
---
I have some questions:
- Should I also make it work for when the dst is smaller than the src?
- If not, should the FIXME() in 1/2 be promoted to an error? Otherwise we might have segfaults, writing out of scope.
- Should I use copy_plane(), introduced in 2/2 also in the implementation of the other formats? Changing what needs to be changed to preserve behavior of course.
--
v3: quartz: Properly copy data to render surfaces of planar formats in VMR9.
https://gitlab.winehq.org/wine/wine/-/merge_requests/6069
This fixes various corner cases.
This is not motivated by any particular application. However, the server-side
code seems at least as simple as the existing client-side code, is more
accurate, and removes a potential source of complication from any future work
involving asyncs.
--
v3: server: Reimplement mailslots using server-side I/O.
server: Treat completion with error before async_handoff() as error.
kernel32/tests: Add more mailslot tests.
https://gitlab.winehq.org/wine/wine/-/merge_requests/6045