July 2024 - wine-gitlab

[PATCH 0/1] MR6054: Draft: mf/tests: Reduce the mute threshold for the transform tests.
by Rémi Bernon (＠rbernon) 11 Jul '24

11 Jul '24

It constantly fails on Gitlab because of output overflow. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6054

2 1

[PATCH v11 0/1] MR5968: cmd: Do not set enviroment variable when no input is provided by set /p command.
by Vijay Kiran Kamuju (＠infyquest) 11 Jul '24

11 Jul '24

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=55662 Tests are not provided as its interactive. -- v11: cmd: Do not set enviroment variable when no input is provided by set /p command. https://gitlab.winehq.org/wine/wine/-/merge_requests/5968

3 2

Re: [PATCH v2 0/1] MR6002: secur32: Implement the NameDisplay name format of the GetUserNameExW method
by Dmitry Timoshkov (＠dmitry) 11 Jul '24

11 Jul '24

On Thu Jul 11 10:43:10 2024 +0000, Egor Poleshko wrote: > I will. Also, take a look at this: > ![GetUserNameExW](/uploads/786f1b0d12cc9dffb024bb0a65e328ee/GetUserNameExW.mp4) Videos usually provide no technical information and lead to pure speculations. Actual code sounds more convincing: https://testbot.winehq.org/JobDetails.pl?Key=147012 -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6002#note_75897

1 0

[PATCH 0/9] MR6052: mshtml: Improve script global object handling and use new bindings for more objects.
by Jacek Caban (＠jacek) 11 Jul '24

11 Jul '24

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/6052

3 10

Re: [PATCH v5 0/4] MR5237: Use futexes on macOS for thread-ID alerts.
by Marc-Aurel Zent (＠mzent) 11 Jul '24

11 Jul '24

On Thu Jul 11 10:51:43 2024 +0000, Elizabeth Figura wrote: > Sorry for the late approval; I missed that I had been assigned. > As far as I can tell from the documentation this is correct and matches > the semantics we need. > There are a couple trailing whitespace errors in the last patch though. No worries, and thanks the review! -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5237#note_75894

1 0

Re: [PATCH v2 0/1] MR6002: secur32: Implement the NameDisplay name format of the GetUserNameExW method
by Egor Poleshko (＠somedevfox) 11 Jul '24

11 Jul '24

On Thu Jul 11 10:08:54 2024 +0000, Dmitry Timoshkov wrote: > I'd suggest to add a test. That test most likely will show that > GetUserNameEx(NameDisplay) returns an error ERROR_NONE_MAPPED on every > VM in the Testbot. That means that your assumptions about > GetUserNameEx() behaviour are incorrect, and the code in your plugin > software won't work on at least some (I'd guess on most) of the Windows > computers. Therefore your implementation is incorrect as well. I will. Also, take a look at this: ![GetUserNameExW](/uploads/786f1b0d12cc9dffb024bb0a65e328ee/GetUserNameExW.mp4) -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6002#note_75893

1 0

[PATCH 0/1] MR6044: crypt32: Make CertFindCertificateInStore(CERT_FIND_ISSUER_NAME) work.
by Dmitry Timoshkov (＠dmitry) 11 Jul '24

11 Jul '24

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/6044

4 3

Re: [PATCH v2 0/1] MR6002: secur32: Implement the NameDisplay name format of the GetUserNameExW method
by Dmitry Timoshkov (＠dmitry) 11 Jul '24

11 Jul '24

On Thu Jul 11 09:52:04 2024 +0000, Egor Poleshko wrote: > Nevermind, I apologise. I misunderstood how do the username values work > on local accounts. > From your and my observations, GetUserNameExW(3) performs several checks > before returning a result: > - If the user is connected to an Active Directory domain, return the > `displayName` value from the domain LDAP database. > - If the local user is linked to a Microsoft account, return the name > specified in it. > - Else, return `ERROR_NONE_MAPPED`. > The Microsoft Account part is tricky, because, as far as I know, Wine > doesn't provide a way to link the local user to a Microsoft account... > Maybe, my implementation will suffice? I'd suggest to add a test. That test most likely will show that GetUserNameEx(NameDisplay) returns an error ERROR_NONE_MAPPED on every VM in the Testbot. That means that your assumptions about GetUserNameEx() behaviour are incorrect, and the code in your plugin software won't work on at least some (I'd guess on most) of the Windows computers. Therefore your implementation is incorrect as well. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6002#note_75890

1 0

Re: [PATCH v2 0/1] MR6002: secur32: Implement the NameDisplay name format of the GetUserNameExW method
by Egor Poleshko (＠somedevfox) 11 Jul '24

11 Jul '24

On Thu Jul 11 09:01:15 2024 +0000, Dmitry Timoshkov wrote: > What do you mean? Nevermind, I apologise. I misunderstood how do the username values work on local accounts. From your and my observations, GetUserNameExW(3) performs several checks before returning a result: - If the user is connected to an Active Directory domain, return the `displayName` value from the domain LDAP database. - If the local user is linked to a Microsoft account, return the name specified in it. - Else, return `ERROR_NONE_MAPPED`. The Microsoft Account part is tricky, because, as far as I know, Wine doesn't provide a way to link the local user to a Microsoft account... Maybe, my implementation will suffice? -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6002#note_75889

1 0

[PATCH v10 0/1] MR5968: cmd: Do not set enviroment variable when no input is provided by set /p command.
by Vijay Kiran Kamuju (＠infyquest) 11 Jul '24

11 Jul '24

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=55662 Tests are not provided as its interactive. -- v10: cmd: Do not set enviroment variable when no input is provided by set /p command. https://gitlab.winehq.org/wine/wine/-/merge_requests/5968

3 3

2025

2024

2023

2022

wine-gitlab July 2024