July 2024 - wine-gitlab

[PATCH 0/1] MR5954: dinput: Call handle_foreground_lost() synchronously in cbt_hook_proc().
by Shaun Ren (＠shaunren) 04 Jul '24

04 Jul '24

mouse_unacquire() needs to be called on the same thread as mouse_acquire(), otherwise the cursor hidden by mouse_unacquire() will not be restored. Fixes an issue with [the cursor disappearing in the game IL-2: Cliffs of Dover Blitz Edition](https://github.com/ValveSoftware/Proton/issues/5007#issuecomment-2…. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5954

3 2

[PATCH 0/1] MR5929: winemac.drv: Remove the clear OpenGL views to black hack.
by Zhiyi Zhang (＠zhiyi) 04 Jul '24

04 Jul '24

Fix black screen issues for Active Trader Pro and Assetto Corsa. This reverts commit 4124478b. For Active Trader Pro, the hack ends up clearing a context that was previously drawn to to black, possibly because multiple OpenGL contexts are involved according to Henri's investigation. Assetto Corsa creates a D3D device for a window but doesn't actually do any rendering with it. After ceefcca7, having an OpenGL context for a window clears its OpenGL surface to black after its view becomes visible. The OpenGL surface is on top of other layers for the window so the window becomes black after that. The blackness is originally from glDrawBuffer(GL_FRONT_AND_BACK), which presumably prepares a zero-initialized OpenGL front draw buffer. This also suggests that 4124478b is no longer necessary. I could delay the clearToBlackIfNeeded() call so it uses the behavior before ceefcca7, but now that it seems the hack is no longer necessary and might cause more errors. CrossOver has disabled the hack for a while and it seems fine. I think it's time to remove the hack. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5929

3 3

[PATCH 0/1] MR5978: winegstreamer: Optimise copy to DXGI buffer.
by Brendan McGrath (＠redmcg) 04 Jul '24

04 Jul '24

Using IMF2DBuffer2_Lock2DSize with LockFlags_Write dramatically improves performance over IMFMediaBuffer_Lock when using a DXGI buffer. IMFMediaBuffer_Lock does not know that this buffer will not be read and therefore performs an unnecessary transfer of the texture from GPU to CPU before it is overwritten. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5978

4 5

Re: [PATCH v2 0/3] MR5988: winegstreamer: Output compressed samples from the media source.
by Rémi Bernon (＠rbernon) 04 Jul '24

04 Jul '24

On Thu Jul 4 10:45:58 2024 +0000, Chunhao Hung wrote: > After test on the actually game Rune Factory 5 it shown, and stock > there. no audio. > ``` > 079c:fixme:process:SetProcessShutdownParameters (000003ff, 00000000): > partial stub. > 0604:fixme:mmdevapi:control_UnregisterAudioSessionNotification > (00007FFFFF2DD810)->(0000488C0007D5A0) - stub > (wine:112100): GStreamer-CRITICAL **: 13:05:17.566: gst_query_set_uri: > assertion 'gst_uri_is_valid (uri)' failed > (wine:112100): GStreamer-CRITICAL **: 13:05:17.566: gst_query_set_uri: > assertion 'gst_uri_is_valid (uri)' failed > (wine:112100): GStreamer-CRITICAL **: 13:05:17.574: gst_query_set_uri: > assertion 'gst_uri_is_valid (uri)' failed > winegstreamer error: qtdemux0: Internal data stream error. > winegstreamer error: qtdemux0: ../gst/isomp4/qtdemux.c(6749): > gst_qtdemux_loop (): /GstBin:bin0/GstDecodeBin:decodebin0/GstQTDemux:qtdemux0: > streaming stopped, reason not-linked (-1) > (wine:112100): GStreamer-CRITICAL **: 13:05:19.495: gst_query_set_uri: > assertion 'gst_uri_is_valid (uri)' failed > (wine:112100): GStreamer-CRITICAL **: 13:05:19.495: gst_query_set_uri: > assertion 'gst_uri_is_valid (uri)' failed > (wine:112100): GStreamer-CRITICAL **: 13:05:19.499: gst_query_set_uri: > assertion 'gst_uri_is_valid (uri)' failed > winegstreamer error: qtdemux1: Internal data stream error. > winegstreamer error: qtdemux1: ../gst/isomp4/qtdemux.c(6749): > gst_qtdemux_loop (): /GstBin:bin1/GstDecodeBin:decodebin1/GstQTDemux:qtdemux1: > streaming stopped, reason not-linked (-1) > ``` > Without this patch, some of audio in video are normal, just no video is shown. > here is log with +mfplat > [stdout.xz](/uploads/db4cea226cffe3f8a582d3ac39539c39/stdout.xz) This fails because for some reason your GStreamer setup doesn't have h264parse. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5988#note_75116

1 0

[PATCH 0/7] MR5992: windows.web: Implement IJsonValueStatics::CreateStringValue().
by Mohamad Al-Jaf (＠maljaf) 04 Jul '24

04 Jul '24

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=56914 This is also needed by Adobe Premiere Pro 2024. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5992

3 11

[PATCH 0/7] MR5388: Draft: RFC: WGL_ARB_pixel_format logic in opengl32
by Alexandros Frantzis (＠afrantzis) 04 Jul '24

04 Jul '24

As mentioned in https://gitlab.winehq.org/wine/wine/-/merge_requests/5264, the next step for OpenGL in the Wayland driver is support for WGL_ARB_pixel_format. It seems possible, at least in theory, to move a large part of the logic involved in this extension outside the drivers for common use by all of them (or ones that want to opt-in). The goal of this RFC MR is, through experimentation and discussion/feedback, evaluate: 1. Whether making such functionality available outside the drivers (likely in an opt-in manner to begin with) is a productive way forward, or the complexity and platform specific decisions favor the current per-driver approach. 2. If we think that (1) is a worthy goal, what's the best mechanism to achieve it. Note that the focus of this MR is currently on being a proof-of-concept, rather providing ready-for-detailed-review code (although I have done my best to keep the code decent). This MR currently (roughly in commit order): * Introduces a new wgl driver callback to allow drivers to provide to opengl32/unix a list of formats and many details about them. * Uses the information in that list to implement wglGetPixelFormatAttrib*. * Uses the information in that list plus format sorting rules from WineX11 (effectively GLX rules plus tweaks) to implement wglChoosePixelFormatARB. * Implements the get_pixel_formats callback for the Wayland driver. * Hacks the get_pixel_formats callback for WineX11, and to allow me to run some experiments to compare the output of native WineX11 and get_pixel_formats-WineX11. In the admittedly not too many games I tried the sort order is the same, so at least that's encouraging. My thoughts and notes so far: * Using this approach for wglGetPixelFormatAttrib* works well, and we can also implement wglDescribePixelFormat in this way. * It's not at all clear what the "right" sorting rules are for wglChoosePixelFormatARB. * WineX11 uses GLX + tweaks (e.g., changes depth sorting). This means that larger formats tend to be preferred, at least according to the GLX spec. For example, asking for a r5, g6, b5 in the attributes is supposed to give back rgb888 (or even higher if available) as the top format in the list. Interestingly, and to confuse things even more, I haven't been able to make GLX return non-888(8) configs at all to actually test this more, so perhaps that's what saves it here? However, eglChooseConfig works similarly and there I was able to verify this behavior (e.g., got a nice surprise 10-bit format when asking for 5551 :)). * Winemac has its own custom logic. * Mesa's WGL implementation uses a different approach, closer to Wine's normal (wgl)ChoosePixelFormat, where proximity to the target format is strongly rewarded (so it seems asking for r5g6b5 is much more likely to actually get you that). * Of course, the "gold standard" here would be to try to infer and use the rules used by some windows driver. Looking forward to thoughts/feedback! -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5388

3 14

[PATCH 0/6] MR5993: Cmd engine rewrite (part XV)
by eric pouech (＠epo) 04 Jul '24

04 Jul '24

This is part XV of cmd engine rewrite. This MR deals with returning the proper success/failure return code for POPD and RMDIR. However, these commands never set ERRORLEVEL (all the commands we've handled so far always set ERRORLEVEL in case of failure, and some reset ERRORLEVEL in case of successs). So this MR on top of returning the expected success/failure return code for these two commands, also: - extend tests to show that ERRORLEVEL isn't set - tweak internal call path to better handle return code vs ERRORLEVEL. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5993

2 6

[PATCH 0/3] MR5990: mfreadwrite/reader: Fix seeking and playback loop when using decoders.
by Rémi Bernon (＠rbernon) 04 Jul '24

04 Jul '24

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/5990

2 4

[PATCH 0/3] MR5988: winegstreamer: Output compressed samples from the media source.
by Elizabeth Figura (＠zfigura) 04 Jul '24

04 Jul '24

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/5988

3 4

[PATCH v3 0/10] MR5055: winegstreamer: Support input video frame padding and cropping.
by Rémi Bernon (＠rbernon) 04 Jul '24

04 Jul '24

On the client side, frame aperture may be included or omitted. This can be used to include or drop the frame padding, and the VideoProcessor MFT supports it. On GStreamer side, we can only use the unpadded frame size in the caps, because this is how decoders work, and padding needs to be added as a property of the input/output video buffers. Then, frame size needs to be adjusted to be consistent between input and output, and any difference considered as extra padding to be added on one side or the other. -- v3: winegstreamer: Respect video format padding for input buffers too. winegstreamer: Exclude padding from wg_format video frame size. winegstreamer: Use video info stride in buffer meta rather than videoflip. winegstreamer: Use a new wg_video_buffer_pool class to add buffer meta. winegstreamer: Update the output_format when stream format changes. winegstreamer: Pass optional GstVideoInfo to read_transform_output_data. winegstreamer: Split read_transform_output_data in two helpers. winegstreamer: Introduce a new sample_needs_copy_buffer helper. winegstreamer: Introduce a new sample_set_flags_from_buffer helper. mf/tests: Add more video processor tests with aperture. https://gitlab.winehq.org/wine/wine/-/merge_requests/5055

4 15

2025

2024

2023

2022

wine-gitlab July 2024