On Thu Aug 29 07:47:26 2024 +0000, Rémi Bernon wrote:
> This is a huge amount of changes and it doesn't seem really justified? I
> think you can do everything you need with DEV_BROADCAST_HDR already and
> do not need any internal structs, or am I missing something?
I mean, DEV_BROADCAST_HANDLE has a dbch_nameoffset which you can use to put the device name in it, and use that for filtering?
--
https://gitlab.winehq.org/wine/wine/-/merge_requests/6315#note_80369
Rémi Bernon (@rbernon) commented about include/wine/dbt.h:
> + * but WITHOUT ANY WARRANTY; without even the implied warranty of
> + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
> + * Lesser General Public License for more details.
> + *
> + * You should have received a copy of the GNU Lesser General Public
> + * License along with this library; if not, write to the Free Software
> + * Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301, USA
> + */
> +
> +#ifndef __WINE_WINE_DBT_H_
> +#define __WINE_WINE_DBT_H_
> +
> +#include <wine/plugplay.h>
> +#include <wine/debug.h>
> +
> +struct device_notification_details
This is a huge amount of changes and it doesn't seem really justified? I think you can do everything you need with DEV_BROADCAST_HDR already and do not need any internal structs, or am I missing something?
--
https://gitlab.winehq.org/wine/wine/-/merge_requests/6315#note_80368
On Thu Aug 29 07:07:25 2024 +0000, Hans Leidekker wrote:
> Can you share a trace? I'd like to see how the app calls this function.
I'm not able to find a currently log with a call to this function.
All the logs to have show this function wasn't supported in the ODBC v2.0 driver.
0024:trace:odbc:load_function_table failed to load SQLBindParam
This could of been another application I was testing at the time but I'm cannot remember which one.
--
https://gitlab.winehq.org/wine/wine/-/merge_requests/6394#note_80366