On Mon Aug 12 13:09:54 2024 +0000, Zhiyi Zhang wrote:
> Not all of the comments are addressed.
> Also, please add an 's' at the end of "comctl32/test" so it becomes
> "comctl32/tests: Add rebar chevron visibility test.".
Fixed.
--
https://gitlab.winehq.org/wine/wine/-/merge_requests/6075#note_78519
On Tue Aug 13 07:07:08 2024 +0000, Ilia Docin wrote:
> changed this line in [version 6 of the diff](/wine/wine/-/merge_requests/6075/diffs?diff_id=126213&start_sha=606f2f040764d020301d07abaa1e02fb21049343#382007f113cc98a69ffe5bb3875a73e4727dad0c_1217_1217)
Fixed.
--
https://gitlab.winehq.org/wine/wine/-/merge_requests/6075#note_78518
SQLFreeSTMT doesn't use the generic function as it cause a crash when the FreeHandle was called (mysql).
--
v2: odbc32: Support Allocating SQL handles for ODBC v2 drivers.
odbc32: SQLSetEnvAttr isnt supported in ODBC v2.0
odbc32: Support freeing SQL handles for ODBC v2 drivers.
https://gitlab.winehq.org/wine/wine/-/merge_requests/6114
This fixes two regression with the latest ODBC32 updates.
- SQLAllocStmt is an ODBC v2 function, so use the SQLAllocHandle (odbc v3) by default.
- SQLBindCol call the actual driver function (appears to be a copy paste mistake).
--
https://gitlab.winehq.org/wine/wine/-/merge_requests/6247