August 2024 - wine-gitlab

[PATCH v4 0/1] MR6075: Add chevron visibility test to check the case of restoring band width to ideal value
by Ilia Docin (＠IDocin) 09 Aug '24

09 Aug '24

I prepared fix https://gitlab.winehq.org/wine/wine/-/commit/b45ad56, that I didn't provide test for, but now I find a way to check it. -- v4: comctl32/test: Add rebar chevron visibility test. https://gitlab.winehq.org/wine/wine/-/merge_requests/6075

3 6

[PATCH v3 0/1] MR6075: Add chevron visibility test to check the case of restoring band width to ideal value
by Ilia Docin (＠IDocin) 09 Aug '24

09 Aug '24

I prepared fix https://gitlab.winehq.org/wine/wine/-/commit/b45ad56, that I didn't provide test for, but now I find a way to check it. -- v3: comctl32/rebar: Add chevron test. https://gitlab.winehq.org/wine/wine/-/merge_requests/6075

3 2

[PATCH v11 0/2] MR5909: comctl32/listview: Do not return items count on getting next item for last one
by Ilia Docin (＠IDocin) 09 Aug '24

09 Aug '24

-- v11: comctl32/listview: Do not return items count on getting next item for last one. comctl32/listview: Add LVM_GETNEXTITEM test. https://gitlab.winehq.org/wine/wine/-/merge_requests/5909

2 3

[PATCH v10 0/2] MR5909: comctl32/listview: Do not return items count on getting next item for last one
by Ilia Docin (＠IDocin) 09 Aug '24

09 Aug '24

-- v10: comctl32/listview: Do not return items count on getting next item for last one. comctl32/listview: Add LVM_GETNEXTITEM test. https://gitlab.winehq.org/wine/wine/-/merge_requests/5909

2 4

[PATCH 0/1] MR6246: ntdll: Call the exception preparation callback on ARM64EC.
by Billy Laws (＠bylaws) 09 Aug '24

09 Aug '24

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/6246

3 2

[PATCH 0/1] MR6198: gdi32: Bounds check EMF handle tables.
by Esme Povirk (＠madewokherd) 09 Aug '24

09 Aug '24

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=45106 -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6198

4 4

[PATCH 0/1] MR6245: user32: Implement EVENT_OBJECT_STATECHANGE for BM_SETCHECK.
by Esme Povirk (＠madewokherd) 09 Aug '24

09 Aug '24

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/6245

2 1

[PATCH 0/1] MR6229: winegstreamer/quartz_parser: Handle 0 size in read_thread.
by Ziqing Hui (＠zhui) 09 Aug '24

09 Aug '24

Calling IAsyncReader_SyncRead() with 0 size may fails, but we should not return error with 0 size, so we handle it earlier. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6229

3 2

Re: [PATCH v3 0/4] MR6216: httpapi: Implement HttpResponseSendEntityBody
by Elizabeth Figura (＠zfigura) 09 Aug '24

09 Aug '24

Thanks for the patch! Other than a couple of style nitpicks it looks good. > I could have looped the `recv()` call to collect all of the response, but that felt more complicated than adding a minor delay. The tests were verified against Windows 11 Pro (build 22621.3880). I think it'd still be preferable, though. 100 ms isn't a lot, but those kinds of sleeps can build up, and we do want our tests to be as quick as possible. Perhaps more concerningly, if the timing is particularly bad, and 100 ms isn't enough, we'll get intermittent failures. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6216#note_78212

1 0

Re: [PATCH v3 0/4] MR6216: httpapi: Implement HttpResponseSendEntityBody
by Elizabeth Figura (＠zfigura) 09 Aug '24

09 Aug '24

Elizabeth Figura (@zfigura) commented about dlls/http.sys/http.c: > { > if (send(conn->socket, response->buffer, response->len, 0) >= 0) > { > - if (conn->content_len) > - { > - /* Discard whatever entity body is left. */ > - memmove(conn->buffer, conn->buffer + conn->content_len, conn->len - conn->content_len); > - conn->len -= conn->content_len; > + /* Clean up the connection if we are not sending more response data. */ > + if (response->response_flags != HTTP_SEND_RESPONSE_FLAG_MORE_DATA) { Brace on a new line, please, to match the existing style. There's another instance in 4/4. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6216#note_78211

1 0

2025

2024

2023

2022

wine-gitlab August 2024