August 2024 - wine-gitlab

[PATCH 0/1] MR6205: d3dx9/effect: Return creator string from GetDesc().
by Nikolay Sivov (＠nsivov) 08 Aug '24

08 Aug '24

Signed-off-by: Nikolay Sivov <nsivov(a)codeweavers.com> -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6205

4 3

[PATCH v3 0/9] MR6157: d3dx9: More miscellaneous fixes.
by Connor McAdams (＠cmcadams) 08 Aug '24

08 Aug '24

-- v3: d3dx9: Validate filter argument in texture from file functions. d3dx9: Validate filter argument in D3DXLoadSurfaceFrom{Surface,FileInMemory,Memory}(). d3dx9: Validate filter argument in D3DXLoadVolumeFrom{Volume,FileInMemory,Memory}(). d3dx9: Further validate filter argument passed to D3DXFilterTexture(). d3dx9: Introduce helper function for retrieving the mip filter value in texture from file functions. d3dx9/tests: Add d3dx filter argument value tests. d3dx9: Return failure from D3DXLoadSurfaceFromMemory() if d3dx_load_pixels_from_pixels() fails. d3dx9: Return success in D3DXLoadSurfaceFromMemory() for multisampled destination surfaces. d3dx9/tests: Add tests for D3DXLoadSurfaceFromMemory() with a multisampled surface. https://gitlab.winehq.org/wine/wine/-/merge_requests/6157

4 16

Re: [PATCH v4 0/2] MR6218: comctl32/treeview: Allow treeview parent to deny treeview expansion.
by Zhiyi Zhang (＠zhiyi) 08 Aug '24

08 Aug '24

Zhiyi Zhang (@zhiyi) commented about dlls/comctl32/treeview.c: > !(item->state & TVIS_EXPANDEDONCE)); > if (sendsNotifications) > { > - if (!TREEVIEW_SendExpanding(infoPtr, item, TVE_EXPAND)) > - { > - TRACE(" TVN_ITEMEXPANDING returned TRUE, exiting...\n"); > - return FALSE; > - } > + if (!TREEVIEW_SendExpanding(infoPtr, item, TVE_EXPAND)) Let's change TREEVIEW_SendExpanding to return the return value from TREEVIEW_SendTreeviewNotify() so we don't to need negate the return value twice and it's more intuitive this way. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6218#note_78098

1 0

Re: [PATCH v4 0/2] MR6218: comctl32/treeview: Allow treeview parent to deny treeview expansion.
by Zhiyi Zhang (＠zhiyi) 08 Aug '24

08 Aug '24

Zhiyi Zhang (@zhiyi) commented about dlls/comctl32/treeview.c: > !(item->state & TVIS_EXPANDEDONCE)); > if (sendsNotifications) > { > - if (!TREEVIEW_SendExpanding(infoPtr, item, TVE_EXPAND)) > - { > - TRACE(" TVN_ITEMEXPANDING returned TRUE, exiting...\n"); > - return FALSE; > - } > + if (!TREEVIEW_SendExpanding(infoPtr, item, TVE_EXPAND)) > + { > + TRACE(" TVN_ITEMEXPANDING returned TRUE, exiting...\n"); > + return TRUE; This is the only changed line. Please avoid whitespace changes for other lines. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6218#note_78097

1 0

Re: [PATCH v4 0/2] MR6218: comctl32/treeview: Allow treeview parent to deny treeview expansion.
by Zhiyi Zhang (＠zhiyi) 08 Aug '24

08 Aug '24

Zhiyi Zhang (@zhiyi) commented about dlls/comctl32/treeview.c: > return FALSE; > > if (bUser) > - TREEVIEW_SendExpanding(infoPtr, item, action); > + { > + if(!TREEVIEW_SendExpanding(infoPtr, item, action)) > + return TRUE; Let's use if (bUser && !TREEVIEW_SendExpanding(infoPtr, item, action)) -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6218#note_78096

1 0

Re: [PATCH v4 0/2] MR6218: comctl32/treeview: Allow treeview parent to deny treeview expansion.
by Zhiyi Zhang (＠zhiyi) 08 Aug '24

08 Aug '24

Zhiyi Zhang (@zhiyi) commented about dlls/comctl32/tests/treeview.c: > > DestroyWindow(hTree); > > + /* check that expansion can be denied by parent */ > + hTree = create_treeview_control(0); > + fill_tree(hTree); > + > + tvn_itemexpanding_ret = 1; > + memset(&item, 0, sizeof(item)); > + item.mask = TVIF_STATE; > + item.hItem = hRoot; > + *((HTREEITEM*)&rc) = item.hItem; Add a space between HTREEITEM and *. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6218#note_78095

1 0

Re: [PATCH v4 0/2] MR6218: comctl32/treeview: Allow treeview parent to deny treeview expansion.
by Zhiyi Zhang (＠zhiyi) 08 Aug '24

08 Aug '24

Zhiyi Zhang (@zhiyi) commented about dlls/comctl32/tests/treeview.c: > } > case TVN_ITEMEXPANDINGA: > { > - UINT newmask = pTreeView->itemNew.mask & ~TVIF_CHILDREN; > + UINT newmask; Let's add a new line after the variable declaration. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6218#note_78094

1 0

Re: [PATCH v4 0/2] MR6218: comctl32/treeview: Allow treeview parent to deny treeview expansion.
by Zhiyi Zhang (＠zhiyi) 08 Aug '24

08 Aug '24

Zhiyi Zhang (@zhiyi) commented about dlls/comctl32/tests/treeview.c: > } > case TVN_ITEMEXPANDINGA: > { > - UINT newmask = pTreeView->itemNew.mask & ~TVIF_CHILDREN; > + UINT newmask; > + if (tvn_itemexpanding_ret) > + { > + tvn_itemexpanding_ret = 0; Let's use a similar naming convention like other global variables, for example, g_reject_tvn_itemexpanding. And let parent_wnd_proc always return TRUE when g_reject_tvn_itemexpanding is TRUE and then reset the variable to zero in test_expandnotify() after your tests. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6218#note_78093

1 0

[PATCH v7 0/2] MR6186: comctl32/progress: Add states for progress bar.
by Jacob Czekalla (＠JacobCzekalla) 08 Aug '24

08 Aug '24

Comctl32 V6 adds three different states into the progress bar: Normal, Paused, and Error. These three states change the color of the bar based on the theme. Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=56352 -- v7: comctl32/progress: Add states for progress bar. comctl32/tests: Add tests for progress bar states. https://gitlab.winehq.org/wine/wine/-/merge_requests/6186

4 4

[PATCH v2 0/10] MR6230: mshtml: Support more node prototype objects.
by Jacek Caban (＠jacek) 08 Aug '24

08 Aug '24

-- v2: mshtml: Add support for text node prototype objects. https://gitlab.winehq.org/wine/wine/-/merge_requests/6230

2 10

2025

2024

2023

2022

wine-gitlab August 2024