September 2024 - wine-gitlab

Re: [PATCH v2 0/1] MR6470: ntdll: Do not call LDR notifications during process shutdown. - approved
by Alexandre Julliard (＠julliard) 11 Sep '24

11 Sep '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6470

1 0

Re: [PATCH v2 0/7] MR6472: mfsrcsnk: Stub more of the media source methods. - approved
by Alexandre Julliard (＠julliard) 11 Sep '24

11 Sep '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6472

1 0

Re: [PATCH v4 0/3] MR6379: wined3d: Fixes for Vulkan device extensions. - approved
by Alexandre Julliard (＠julliard) 11 Sep '24

11 Sep '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6379

1 0

[PATCH 0/2] MR6478: winevulkan: Handle multidimensional static arrays.
by Elizabeth Figura (＠zfigura) 11 Sep '24

11 Sep '24

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/6478

2 2

[PATCH 0/1] MR6477: user32: Implement listbox MSAA events on click.
by Esme Povirk (＠madewokherd) 11 Sep '24

11 Sep '24

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/6477

3 2

[PATCH v6 0/1] MR6300: Draft: wined3d: Don't reject blits coming from older CS thread.
by Aida Jonikienė (＠DodoGTA) 11 Sep '24

11 Sep '24

I'm not sure this is 100% safe (maybe limiting those blits to sysmem textures would be better like stated in the original change?) -- v6: wined3d: Don't reject blits coming from older command stream. https://gitlab.winehq.org/wine/wine/-/merge_requests/6300

3 2

Re: [PATCH v13 0/1] MR6453: emfdc: avoid memory leaks in get_bitmap_info
by Jacek Caban (＠jacek) 11 Sep '24

11 Sep '24

Jacek Caban (@jacek) commented about dlls/gdi32/emfdc.c: > { > blit_dc = *hdc; > blit_bitmap = *bitmap; > + > + if (!GetDIBits( blit_dc, blit_bitmap, 0, INT_MAX, NULL, info, DIB_RGB_COLORS )) > + goto err; You could just return 0 here, which would allow you to simplify the code some more. Then you don't need the assignment above. And without that assignment, we could remove `blit_dc != *hdc` check from error handling path. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6453#note_81916

1 0

[PATCH v3 0/5] MR6375: mshtml: Don't process tasks recursively.
by Gabriel Ivăncescu (＠insn) 11 Sep '24

11 Sep '24

I kept the first patch (`Remember if timer was blocked.`) to avoid SetTimer on timers that weren't killed, mostly because it would apply on every task (which is likely to execute way faster than the ms granularity), not sure if it would skew the timer in such case. The other patches are split, with tests now showing why they're needed. Some places where wine-gecko callbacks into us and in which we call into external code need to be treated the same as a recursive task since it can end up in a message loop. I haven't supplied all of them from the previous MR, mostly because I didn't find a way to test those (e.g. show context menu, and the gecko async navigation). -- v3: mshtml: Don't process tasks recursively from Gecko events. mshtml: Don't process tasks recursively from script runners. mshtml: Don't process tasks recursively. mshtml: Remember if timer was blocked. mshtml: Don't cast to int to bound the timer. https://gitlab.winehq.org/wine/wine/-/merge_requests/6375

2 6

[PATCH 0/1] MR6476: sc: Return error value rather than 1 on failure.
by Owen Rudge (＠orudge) 11 Sep '24

11 Sep '24

The Windows version of `sc.exe` returns the appropriate error value, which some applications rely on if programmatically executing it. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6476

2 1

[PATCH v2 0/5] MR6375: mshtml: Don't process tasks recursively.
by Gabriel Ivăncescu (＠insn) 11 Sep '24

11 Sep '24

I kept the first patch (`Remember if timer was blocked.`) to avoid SetTimer on timers that weren't killed, mostly because it would apply on every task (which is likely to execute way faster than the ms granularity), not sure if it would skew the timer in such case. The other patches are split, with tests now showing why they're needed. Some places where wine-gecko callbacks into us and in which we call into external code need to be treated the same as a recursive task since it can end up in a message loop. I haven't supplied all of them from the previous MR, mostly because I didn't find a way to test those (e.g. show context menu, and the gecko async navigation). -- v2: mshtml: Don't send the notification from SuperNavigate if we're in nested mshtml: Don't process tasks recursively from handle_load. mshtml: Don't process tasks recursively from run_end_load. mshtml: Don't process tasks recursively. mshtml: Remember if timer was blocked. https://gitlab.winehq.org/wine/wine/-/merge_requests/6375

3 9

2025

2024

2023

2022

wine-gitlab September 2024