September 2024 - wine-gitlab

Re: [PATCH v4 0/7] MR6519: win32u: Get rid of NtUserIsWindowRectFullScreen calls. - approved
by Alexandre Julliard (＠julliard) 19 Sep '24

19 Sep '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6519

1 0

Re: [PATCH v2 0/2] MR6525: Remove some pre-macOS 10.12 workarounds (clock_gettime and mach_continuous_time) - approved
by Alexandre Julliard (＠julliard) 19 Sep '24

19 Sep '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6525

1 0

Re: [PATCH v5 0/8] MR6467: winex11: Implement vulkan DPI scaling and child window rendering.
by Elizabeth Figura (＠zfigura) 19 Sep '24

19 Sep '24

I don't think this architecture is going to work. It probably isn't evident from games testing, but there is a synchronization problem here. We can't simply do vkQueuePresent() and then copy from the corresponding X11 drawable, because vkQueuePresent() won't guarantee that the bits have reached the X11 drawable yet. For GLX this approach is fine, assuming we have GLX_OML_sync_control. In that case waiting for SBC is exactly what we need. Vulkan doesn't have an equivalent extension. VK_KHR_present_wait isn't equivalent, because it signals the event on first pixel out, which is too soon. This means we probably need to virtualize the whole swapchain, unfortunately, and either create a Vulkan swapchain on the relevant top-level window, or use DRI3 to interop between Vulkan and X11 without a swapchain. In this case vkQueuePresent() would of course not present directly. We could also try to invent an extension that lets us do what GLX_OML_sync_control does, but I fear that Mesa and/or Khronos will push back on this, and basically tell us to fix it on our end, by virtualizing the swapchain... There may be reasons we can't virtualize the swapchain that I'm not thinking of. I also have zero knowledge of Wayland and don't know how to fit that into anything. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6467#note_82685

1 0

[PATCH v2 0/5] MR6524: tools: Replace sprintf with snprintf to avoid deprecation warnings on macOS.
by Brendan Shanks (＠bshanks) 19 Sep '24

19 Sep '24

Excluding winedump for now, since it has a lot of tricky sprintf calls to replace -- v2: wrc: Replace sprintf with snprintf to avoid deprecation warnings on macOS. wmc: Replace sprintf with snprintf to avoid deprecation warnings on macOS. winebuild: Replace sprintf with snprintf to avoid deprecation warnings on macOS. https://gitlab.winehq.org/wine/wine/-/merge_requests/6524

4 8

[PATCH 0/1] MR6447: winegstreamer/wm_reader: Use codec format only for compressed types.
by Ziqing Hui (＠zhui) 19 Sep '24

19 Sep '24

The intention of wg_parser_stream_get_codec_format is to return the codec for compressed stream. We shouldn't use it for uncompressed result. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6447

4 17

[PATCH 0/2] MR6521: win32u: Implement a ForceDpiAwareness registry option.
by Rémi Bernon (＠rbernon) 19 Sep '24

19 Sep '24

Under the HKCU\Software\Wine\X11 Driver global or application-specific HKCU\Software\Wine\AppDefaults\app.exe\X11 Driver registry keys. This option can be used to restore the old behavior with DPI awareness forced on every application, which some of them handled well enough even if not DPI aware otherwise. Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=57175 -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6521

4 6

[PATCH v3 0/1] MR6372: winewayland: Some init changes.
by Aida Jonikienė (＠DodoGTA) 19 Sep '24

19 Sep '24

-- v3: winewayland: Make the pointer protocols optional. https://gitlab.winehq.org/wine/wine/-/merge_requests/6372

4 7

[PATCH 0/1] MR6530: ntdll: Ensure Unix path strings are wrapped with debugstr_a in traces.
by Owen Rudge (＠orudge) 19 Sep '24

19 Sep '24

If a particularly long path is passed into these functions, it can cause a buffer overflow and cause unpredictable behaviour. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6530

2 1

[PATCH 0/10] MR6529: desk.cpl: Introduce new control panel applet.
by Rémi Bernon (＠rbernon) 19 Sep '24

19 Sep '24

To display and make changes to virtual desktop and monitors layout, which would be useful for virtual display settings or simply for the virtual desktop mode. The applet could eventually be improved to show other display devices information, such as how devices are enumerated with other APIs, etc... -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6529

2 10

[PATCH 0/1] MR6528: netapi32: Add a stub NetFreeAadJoinInformation function.
by Stefan Dösinger (＠stefan) 19 Sep '24

19 Sep '24

Chromium loads NetGetAadJoinInformation and NetFreeAadJoinInformation dynamically from netapi32. While it gracefully handles the absence of netapi32 or the getter, it has an assert that fails if the free function isn't there. It gracefully handles our ERROR_CALL_NOT_IMPLEMENTED from NetGetAadJoinInformation. --- chromium.googlesource.com/chromium/src/base/+/master/win/win_util.cc#189 has the relevant chromium source lines. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6528

1 0

2025

2024

2023

2022

wine-gitlab September 2024