January 2025 - wine-gitlab

Re: [PATCH v2 0/1] MR7159: ntdll: Don't wow64-offset NULL TEB. - approved
by Alexandre Julliard (＠julliard) 21 Jan '25

21 Jan '25

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7159

1 0

[PATCH v2 0/1] MR7161: dinput: Clamp FFB effect report value to the field range.
by Oleg Makarenko (＠JacKeTUs) 21 Jan '25

21 Jan '25

If application sends out-of-range values for FFB effects, they become -1, which is undesireable, when -1 is in the physical range of the field and being sent to the device. This patch fixes it, clamping values to the field range. Clamping was earlier implemented [here](https://gitlab.winehq.org/wine/wine/-/blob/wine-6.19/dlls/dinput/effe… in 6.19. Windows does this clamping silently, and doesn't fail `SetParameters` call when values is out of range. Affected application is Assetto Corsa EVO, which with default settings sends out ConstantForce magnitude under/over [documented](https://learn.microsoft.com/en-us/previous-versions/ms835644(v=… \[-10000, 10000\]. [Link to the discussion with some investigation on Steam](https://steamcommunity.com/app/3058630/discussions/0/756142145462617…. In this submission scaling and clamping were moved to the separate `scale_and_clamp_value` function, which is now called every time from `set_parameter_value`. To avoid regression with sending `-1` for the infinite duration effects, separate function `set_parameter_value_no_scaling` created. Gain values in `hid_joystick_send_device_gain` are also scaled and clamped. -- v2: dinput: Clamp FFB effect report value to the field range. https://gitlab.winehq.org/wine/wine/-/merge_requests/7161

5 6

[PATCH 0/1] MR7156: winex11: Keep track of whether the window has been moved offscreen by the WM.
by Rémi Bernon (＠rbernon) 21 Jan '25

21 Jan '25

Instead of relying on the current X window rect, which may be offscreen for other reasons. Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=57689 -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7156

2 2

[PATCH 0/1] MR7161: dinput: Clamp FFB effect report value to the field range.
by Oleg Makarenko (＠JacKeTUs) 21 Jan '25

21 Jan '25

If application sends out-of-range values for FFB effects, they become -1, which is undesireable, when -1 is in the physical range of the field and being sent to the device. This patch fixes it, clamping values to the field range. Clamping was earlier implemented [here](https://gitlab.winehq.org/wine/wine/-/blob/wine-6.19/dlls/dinput/effe… in 6.19. Windows does this clamping silently, and doesn't fail `SetParameters` call when values is out of range. Affected application is Assetto Corsa EVO, which with default settings sends out ConstantForce magnitude under/over [documented](https://learn.microsoft.com/en-us/previous-versions/ms835644(v=… \[-10000, 10000\]. [Link to the discussion with some investigation on Steam](https://steamcommunity.com/app/3058630/discussions/0/756142145462617…. In this submission scaling and clamping were moved to the separate `scale_and_clamp_value` function, which is now called every time from `set_parameter_value`. To avoid regression with sending `-1` for the infinite duration effects, separate function `set_parameter_value_no_scaling` created. Gain values in `hid_joystick_send_device_gain` are also scaled and clamped. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7161

3 2

[PATCH 0/1] MR7159: ntdll: Don't wow64-offset NULL TEB.
by Paul Gofman (＠gofman) 21 Jan '25

21 Jan '25

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=57690 Fixes a regression introduced by commit de23dfc5b1eac6e111cd66540ad9a97b61a3fe28. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7159

3 3

[PATCH v2 0/1] MR7158: wine.inf.in: Add UBR key
by Etaash Mathamsetty (＠etaash.mathamsetty) 20 Jan '25

20 Jan '25

Required by Logitech G Hub -- v2: wine.inf.in: Add UBR key. https://gitlab.winehq.org/wine/wine/-/merge_requests/7158

3 4

[PATCH v2 0/2] MR7151: server: Don't send WM_MOUSEMOVE for zero movement in queue_mouse_message().
by Paul Gofman (＠gofman) 20 Jan '25

20 Jan '25

-- v2: server: Don't send WM_MOUSEMOVE for zero movement in queue_mouse_message(). win32u: Generate mouse events in the server when releasing capture. https://gitlab.winehq.org/wine/wine/-/merge_requests/7151

4 8

[PATCH v2 0/1] MR7157: winex11: Only erase the desktop window pixels on expose events.
by Rémi Bernon (＠rbernon) 20 Jan '25

20 Jan '25

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=57665 --- The issue is that The Medium launcher uses a dialog window procedure, and implements its background by doing a StretchBlt call on WM_PAINT in the dialog procedure call, which happens before the window message loop. It then itself calls InvalidateRect(hwnd, NULL, 0), which queues a WM_PAINT as well but with only the RDW_INVALIDATE flag. Next, when the window message loop is executed, the WM_PAINT message is being processed as it should, but as we've invalidate the window with RDW_ERASE ourselves from the expose event, the WM_NCPAINT handler erases the entire window, clearing the pixels that the launcher has just painted. This regressed since the window surface clipping region logic changed, as the expose event handling was previously not calling `NtUserRedrawWindow` on windows with a surface and without a clipping region. The clipping region was also previously not always set, or set later, and we're setting it more consistently since 51b16963f6e0e8df43118deac63f640aee4698b7, even when it matches the window rect, for compatibility with some old wineandroid logic (where I believe it was used to clip window surfaces to their proper sizes). -- v2: winex11: Only erase the desktop window pixels on expose events. https://gitlab.winehq.org/wine/wine/-/merge_requests/7157

2 2

[PATCH 0/1] MR7157: winex11: Use RDW_ERASENOW flag in expose events.
by Rémi Bernon (＠rbernon) 20 Jan '25

20 Jan '25

This ensures that the induced non-client redraw are sent and executed right away, and before the WM_PAINT messages are sent. Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=57665 --- The issue is that The Medium launcher uses a dialog window procedure, and implements its background by doing a StretchBlt call on WM_PAINT in the dialog procedure call, which happens before the window message loop. It then itself calls InvalidateRect(hwnd, NULL, 0), which queues a WM_PAINT as well but with only the RDW_INVALIDATE flag. Next, when the window message loop is executed, the WM_PAINT message is being processed as it should, but as we've invalidate the window with RDW_ERASE ourselves from the expose event, the WM_NCPAINT handler erases the entire window, clearing the pixels that the launcher has just painted. Using RDW_ERASENOW we make sure that the erase happens right away on expose, and before the WM_PAINT message is being processed. This regressed since the window surface clipping region logic changed, as the expose event handling was previously not calling `NtUserRedrawWindow` on windows with a surface and without a clipping region. The clipping region was also previously not always set, or set later, and we're setting it more consistently since 51b16963f6e0e8df43118deac63f640aee4698b7, even when it matches the window rect, for compatibility with some old wineandroid logic (where I believe it was used to clip window surfaces to their proper sizes). -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7157

2 2

Re: [PATCH v4 0/0] MR7131: DIR command improvements: Make /o by itself behave equal to how it does in Windows
by Joe Souza (＠JoeS209) 20 Jan '25

20 Jan '25

Tests run via your command line fail to run for me, certainly due to lack of dependencies in my build. I'll work on addressing those, to see if I can get the tests to run. ./wine programs/winetest/x86_64-windows/winetest.exe -o - cmd.exe 0050:err:vulkan:vulkan_init_once Wine was built without Vulkan support. 00c4:err:ntoskrnl:ZwLoadDriver failed to create driver L"\\Registry\\Machine\\System\\CurrentControlSet\\Services\\winebth": c00000e5 003c:fixme:service:scmdatabase_autostart_services Auto-start service L"winebth" failed to start: 1359 wine: failed to open "programs/winetest/x86_64-windows/winetest.exe": c0000135 -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7131#note_92190

1 0

2025

2024

2023

2022

wine-gitlab January 2025