January 2025 - wine-gitlab

[PATCH 0/1] MR7126: winex11: Fixup monitor / display mode inconsistencies.
by Rémi Bernon (＠rbernon) 12 Jan '25

12 Jan '25

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=57610 This is a simple workaround to fix the regression. The issue seems to be residing in inconsistent values returned by XRandR, and arguably a host driver bug, but it probably could be better fixed by enumerating the XRandR tree only on startup and when it is updated, but this would be a much larger change. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7126

3 3

[PATCH 0/2] MR7110: Draft: win32u: Update current modes relative to the primary source.
by Rémi Bernon (＠rbernon) 12 Jan '25

12 Jan '25

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=57610 This attempt to fix a regression which is caused by XRandR enumerated output/crtc changing during the display device initial enumeration. The user setup uses an external display and somehow XRandR enumerates the first (non-primary) monitor and its mode without being able to find a primary output/crtc (and uses that first monitor position as primary as fallback). Then, when the second (primary) monitor and its modes are enumerated it actually finds it and uses its as it should. This results in both monitor modes being positioned at 0x0, which breaks various things later on. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7110

3 4

[PATCH 0/1] MR7135: gdiplus/tests: Fix use-after-free of a graphics object (ASan).
by Nikolay Sivov (＠nsivov) 12 Jan '25

12 Jan '25

Signed-off-by: Nikolay Sivov <nsivov(a)codeweavers.com> -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7135

2 2

[PATCH 0/1] MR7134: kernel32/tests: Avoid stack-buffer-overflow in get_com_dir_size. (ASan)
by Nikolay Sivov (＠nsivov) 12 Jan '25

12 Jan '25

Function gets called with Magic == 0xdead, which causes the test to use the 64-bit path, which results in this buffer overflow. Signed-off-by: Nikolay Sivov <nsivov(a)codeweavers.com> -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7134

2 1

[PATCH 0/2] MR7133: gdiplus: Fix some path functions not starting a new figure.
by Esme Povirk (＠madewokherd) 11 Jan '25

11 Jan '25

Found by Mono's System.Drawing tests. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7133

3 3

[PATCH 0/1] MR7132: gdiplus/tests: Trace locked bitmap data on failure.
by Esme Povirk (＠madewokherd) 11 Jan '25

11 Jan '25

For debugging test failures like this one: https://test.winehq.org/data/8331e7db0d540656a047f415184a30df5acbc3f9/linux… -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7132

2 1

[PATCH v2 0/1] MR7055: appwiz.cpl: Account for unicode characters in XDG_CACHE_HOME.
by Esme Povirk (＠madewokherd) 11 Jan '25

11 Jan '25

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=57338 -- v2: appwiz.cpl: Account for unicode characters in XDG_CACHE_HOME. https://gitlab.winehq.org/wine/wine/-/merge_requests/7055

2 2

Re: [PATCH v4 0/1] MR7091: windowscodecs: Make values returned from CanConvert consistent - approved
by Esme Povirk (＠madewokherd) 11 Jan '25

11 Jan '25

This merge request was approved by Esme Povirk. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7091

1 0

Re: [PATCH v2 0/0] MR7130: (INVALID) - closed
by Jinoh Kang (＠iamahuman) 11 Jan '25

11 Jan '25

This merge request was closed by Jinoh Kang. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7130

1 0

Re: [PATCH v2 0/7] MR6911: Draft: ntdll: Add WaitCompletionPacket.
by Jinoh Kang (＠iamahuman) 11 Jan '25

11 Jan '25

Jinoh Kang (@iamahuman) commented about server/thread.c: > + { > + struct wait_completion_packet *packet; > + > + LIST_FOR_EACH_ENTRY( packet, &obj->wait_completion_packet_queue, struct wait_completion_packet, entry ) > + { > + list_remove( &packet->entry ); > + release_object( packet->target ); > + packet->in_object_packet_queue = 0; > + packet->target = NULL; > + > + add_completion( packet->completion, packet->ckey, packet->cvalue, packet->status, > + packet->information, packet ); > + packet->in_completion_queue = 1; > + } > + } > + General advice: you should try not to leak implementation details of certain object (wait completion packet) into other types of objects. For example, if this piece of code is still to be preserved, you should move this into a helper completion.c, declare as extern in object.h (or file.h), and call that. That way, you don't have to define the entire `struct wait_completion_packet` in a shared header file. If this were factored into a helper, a simple forward declaration would have sufficed in the `file.h` side. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6911#note_91785

1 0

2025

2024

2023

2022

wine-gitlab January 2025