February 2025 - wine-gitlab

[PATCH v2 0/1] MR5890: winex11.drv: Fix a possible desktop window message queue hang.
by Zhiyi Zhang (＠zhiyi) 07 Nov '25

07 Nov '25

After an X11 event handler queues messages to another thread, TRUE should be returned and eventually propagated to X11DRV_ProcessEvents(). When FALSE is always returned in xrandr14_device_change_handler(), a possible hang can happen for the desktop message queue as follows: 1. The explorer.exe calls GetMessageW() -> NtUserGetMessage() -> wait_objects() -> wait_message(). 2. In wait_message(), user_driver->pProcessEvents() gets called in the desktop window thread to handle RRNotify events and calls xrandr14_device_change_handler() -> display_mode_changed(FALSE) -> send_message(get_desktop_window(), WM_DISPLAYCHANGE, ...) -> desktop_window_proc() -> send_message_timeout() -> send_client_message() -> process_message() -> broadcast_message() -> send_message_timeout() -> send_client_message() -> process_message() -> send_inter_thread_message() -> wait_message_reply() -> a server set_queue_mask() with skip_wait being 1 -> wake_mask and changed_mask are set to 0. 3. In wait_message(), user_driver->pProcessEvents() returns FALSE from xrandr14_device_change_handler(). So wait_message() continues to call NtWaitForMultipleObjects(). 4. Now NtWaitForMultipleObjects() hangs for INFINITE timeout because wake_mask and changed_mask for the message queue are set to 0 so the thread is not woke up. The hang is sensitive to message ordering and only happens in this specific case so it's hard to reproduce with tests. I believe some of the past test timeouts on TestBots can be attributed to this bug. -- v2: winex11.drv: Fix a possible desktop window message queue hang. https://gitlab.winehq.org/wine/wine/-/merge_requests/5890

2 2

[PATCH v2 0/2] MR6760: msi: Make MsiInstallProductW open msi readonly
by Fabian Maurer (＠DarkShadow44) 29 Oct '25

29 Oct '25

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=57343 This is what the Java JRE installer does: - It calls MsiInstallProductW - this opens the msi read/write - The msi runs installer.exe - installer.exe tries to open the msi readonly -- v2: msi: Make MsiInstallProductW open msi readonly msi/tests: Add test for MsiOpenDatabaseA during MsiInstallProductA https://gitlab.winehq.org/wine/wine/-/merge_requests/6760

5 11

[PATCH v2 0/4] MR6759: kernelbase: Make trailing slashes in CreateFileW set ERROR_PATH_NOT_FOUND
by Fabian Maurer (＠DarkShadow44) 29 Oct '25

29 Oct '25

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=57376 -- v2: kernelbase: Make trailing slashes in CreateFileW set ERROR_PATH_NOT_FOUND kernel32/tests: Add another CreateFile test kernel32/tests: Only skip volume tests when access is denied kernel32/tests: Only skip volume tests on windows https://gitlab.winehq.org/wine/wine/-/merge_requests/6759

5 12

[PATCH v2 0/1] MR7410: test-linux32: Disable broken tests that are already released broken
by Damien Zammit (＠zamaudio) 28 Oct '25

28 Oct '25

This should allow the CI to fully pass on this merge request. If it does, master branch could have CI tests enabled to ensure any actual broken test caused by a merge request is visible just by the CI status, and master can also reflect the passing status. Signed-off-by: Damien Zammit <damien(a)zamaudio.com> -- v2: test-linux32: Disable broken tests that are already released broken https://gitlab.winehq.org/wine/wine/-/merge_requests/7410

4 4

[PATCH 0/1] MR3228: Update heap.c removed return NULL at line 985. Prevents Wing Commander...
by James Carthew (＠dmjc) 28 Oct '25

28 Oct '25

Update heap.c removed return NULL at line 985. Prevents Wing Commander Prophecy and Secret Ops for loading/playing. Fixes WINE bug 55176. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3228

5 4

[PATCH v3 0/2] MR1321: Reject wic invalid formats
by Zhiyi Zhang (＠zhiyi) 21 Oct '25

21 Oct '25

These invalid formats are rejected when creating WIC render targets. Otherwise, Wine may create a WIC render target with an unsupported format and in turn, will make testing IsSupported() method difficult. -- v3: d2d1: Test creating WIC bitmap render targets. d2d1: Reject unsupported formats when creating WIC bitmap render targets. https://gitlab.winehq.org/wine/wine/-/merge_requests/1321

3 6

[PATCH 0/1] MR3880: ntdll: Only declare/set wow_teb on platforms using it
by Gerald Pfeifer (＠gerald) 17 Oct '25

17 Oct '25

Otherwise we see dlls/ntdll/unix/signal_x86_64.c:2351:14: warning: unused variable 'wow_teb' on FreeBSD. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3880

4 4

[PATCH 0/1] MR6140: ntdll: Exclude biggest envars to fit 32767 chars limit in get_initial_environment.
by Martino Fontana (＠tinozzo123) 11 Oct '25

11 Oct '25

Windows has a limit of 32767 characters in the environment block. https://superuser.com/questions/1070272/why-does-windows-have-a-limit-on-en… Wine doesn't attempt to respect that at all. Do some programs actually depend on this? Unfortunately yes. With this patch, during initialization, if the block size would exceed (or be close to) the limit, the biggest environment variables will be excluded. This is useful when a user has very long environment variables in their system for reasons unrelated to Wine. Do note that there's still nothing done to make sure that the limit isn't exceeded after initialization. Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=56941 Signed-off-by: Martino Fontana <tinozzo123(a)gmail.com> -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6140

7 12

[PATCH v2 0/1] MR5213: Fix Cyberpunk 2077 spawning only one dispatcher thread in FreeBSD
by Katharine Chui (＠katharinechui) 08 Oct '25

08 Oct '25

Normally Cyberpunk 2077 spawns #cpu_threads of dispatcher threads. However with Freebsd, since create_logical_proc_info was a stub, the game would instead spawn a single dispatcher thread, causing the game to just crawl. Working around the issue by adding a barebone implementation of create_logical_proc_info for FreeBSD so that the game would at least get a thread count through ntdll. -- v2: Fix Cyberpunk 2077 spawning only one dispatcher thread in FreeBSD https://gitlab.winehq.org/wine/wine/-/merge_requests/5213

4 6

[PATCH 0/2] MR5935: winemac.drv: Use ScreenCaptureKit for grabbing window snapshots
by Tim Clem (＠tclem) 06 Oct '25

06 Oct '25

The old method will trigger a permission prompt in Sequoia. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5935

5 13

2025

2024

2023

2022

wine-gitlab February 2025