March 2025 - wine-gitlab

Re: [PATCH v2 0/1] MR7617: wpcap: Implement pcap_set_immediate_mode - approved
by Alexandre Julliard (＠julliard) 20 Mar '25

20 Mar '25

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7617

1 0

[PATCH v2 0/5] MR7608: server: Avoid delegating console waits to other objects.
by Elizabeth Figura (＠zfigura) 20 Mar '25

20 Mar '25

Some console objects currently do several unique things: * Delegate waits onto the queue of another object. This is not really a problem for in-process waits, since we can just return the sync object for the delegate. However, it's also unnecessary, adds to the complexity of the server logic, and is one out of one places where this is done. * Make the wait state dependent on the process. This is difficult to emulate with ntsync and would require creating separate server objects for each process, hacking into duplicate_handle. * Fail a wait entirely in certain circumstances. This is pretty much impossible to emulate with in-process waits. Although ntsync has been in development for some time, I have regrettably failed to notice these problems until now. Fortunately, none of these behaviours happen on modern Windows. Although I/O on unbound handles delegates to the console of the current process, the signaled state does not. As the tests here show, the signaled state of a handle depends on the active console of the process in which the handle was created. If that console no longer exists, the signaled state is no longer updated [with one rather inexplicable exception]. Crucially, in current Windows waits never fail, and the state of an object is the same across all process which hold handles to it. Therefore this patch brings our behaviour to closer match current Windows. In theory these are fds and should use default_fd_signaled(). However, the points at which the handles are signaled are completely different, and I/O does not trigger console handles to become signaled when it normally would. Therefore for the time being I've kept the code using custom signaled ops. There is one other oddity related to consoles, which is the existence of console_add_queue(), which seeks to lazily create an input thread when a console is first waited on. This is one out of two places, after this patch, when the wait process is hijacked (the other being message queues). Fortunately this is easy to handle for in-process synchronization objects, by queueing the ioctl from the callback used to retrieve the in-process synchronization object itself. -- v2: server: Track unbound output signaled state based on its original console. server: Track unbound input signaled state based on its original console. server: Allow waiting on an orphaned screen buffer. server: Fail to create an unbound input/output when there is no console. kernel32/tests: Add more tests for orphaned console handles. https://gitlab.winehq.org/wine/wine/-/merge_requests/7608

3 11

[PATCH 0/5] MR7631: server: Clarify between effective thread priority and class/level.
by Rémi Bernon (＠rbernon) 20 Mar '25

20 Mar '25

Split from https://gitlab.winehq.org/wine/wine/-/merge_requests/7516, with some minor tweaks and putting the tests first. I'll send more adjustments for the rest after. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7631

2 6

[PATCH 0/1] MR7628: win32u: Return 0 from NtUserGetKeyNameText if there is no translation.
by Attila Fidan (＠atticf) 20 Mar '25

20 Mar '25

The Kirikiri Z [menu](https://github.com/krkrz/menu/blob/master/Main.cpp) plugin causes an exception to be raised (and the engine unloads the DLL) if GetKeyNameText returns a length of 1 with a null character. The affected applications later fail with script exception dialogs as menu.dll was unloaded. When using winex11 (and presumably winemac), the function returns the return value of the driver function for GetKeyNameText, and that returns 0 on an unsupported key which works. On winewayland (and the null driver), that isn't implemented, and instead the function continues and calls NtUserMapVirtualKeyEx with MAPVK_VK_TO_CHAR filling the buffer with one character which is 0 (no translation). The function then returns 1 for that null character and the applications don't seem to handle that well. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7628

3 2

[PATCH v13 0/3] MR7542: ws2_32: Implement WSALookupService for Bluetooth device discovery.
by Vibhav Pant (＠vibhavp) 20 Mar '25

20 Mar '25

This MR adds an initial implementation of the winsock `WSALookupsService*` methods for performing Bluetooth device discovery (`LUP_CONTAINERS`). Pending !7472, the code will also eventually support performing device inquiry scans. -- v13: ws2_32: Implement WSALookupServiceNext for Bluetooth device discovery. ws2_32: Implement WSALookupServiceBegin for Bluetooth device discovery. ws2_32/tests: Add tests for Bluetooth device discovery in WSALookupServiceBegin/Next. https://gitlab.winehq.org/wine/wine/-/merge_requests/7542

2 3

[PATCH 0/1] MR7534: ws2_32/tests: Add additional invalid parameter tests for WSALookupServiceBegin.
by Vibhav Pant (＠vibhavp) 20 Mar '25

20 Mar '25

WSALokkupServiceBegin fails with WSAEFAULT when provided with bad pointers to the query set or lookup handle parameters. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7534

2 2

[PATCH 0/5] MR7630: winebth.sys part 7: Introduce support for authentication/pairing.
by Vibhav Pant (＠vibhavp) 20 Mar '25

20 Mar '25

Introduce infrastructure necessary to support receiving, sending and replying (to) Bluetooth authentication/pairing requests: - During startup, the Bluetooth driver now creates a "pairing agent" and registers it with BlueZ. The pairing agent is a DBus object implementing the `org.bluez.Agent1` interface (documented [here](https://github.com/bluez/bluez/blob/master/doc/org.bluez.Agent.rst)), which receives authentication requests from BlueZ. The pairing agent then forwards the request data to the PE driver, in form of a `WINEBLUETOOTH_EVENT_AUTH_EVENT` event. The agent is unregistered during driver shutdown. - Right now, the agent only supports Numeric Comparison pairing requests. - Create a new auxiliary device, `\??\WINEBTHAUTH` during driver startup. This device handles authentication functionality that is independent of radio PDOs on the system, which allows the userspace APIs to not track individual Bluetooth radio objects to implement authentication. `WINEBTHAUTH` right now serves two purposes: - Serve as the device object for which `GUID_WINEBTH_AUTHENTICATION_REQUEST` PnP events are broadcasted. This event is sent whenever the Bluetooth event loop in (`bluetooth_event_loop_thread_proc`) receives `WINEBLUETOOTH_EVENT_AUTH_EVENT`. The event's buffer contains a `struct winebth_authentication_request` value, which contains data relevant to the incoming auth request. - Handle the `IOCTL_WINEBTH_AUTH_REGISTER` IOCTL. This simply calls the [`RequestDefaultAgent` BlueZ method](https://github.com/bluez/bluez/blob/master/doc/org.bluez.AgentManag… right now, which asks BlueZ to send all incoming Bluetooth authentication requests to Wine's pairing agent (described above). This is not always strictly necessary, but is useful if there already is a default pairing agent set. - `WINEBTHAUTH` will also ultimately be in charge of responding to authentication requests, which I'll be adding in the next-ish MR(s). - Implement `BluetoothRegisterForAuthenticationEx` and `BluetoothUnregisterAuthentication`. Registration is done by invoking `IOCTL_WINEBTH_AUTH_REGISTER`, and then listening for `GUID_WINEBTH_AUTHENTICATION_REQUEST` events on a `HANDLE` to `\??\WINEBTHAUTH` using the newly added `CM_Register_Notifications`. To keep the MR from getting any larger, I have not included support for `BluetoothSendAuthenticationResponseEx`. That will likely be introduced in the future. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7630

2 5

[PATCH v2 0/1] MR7181: winex11: Avoid creating windows with override-redirect flag set.
by Rémi Bernon (＠rbernon) 20 Mar '25

20 Mar '25

This confuses mutter and it manifests with spurious IconicState WM_STATE change when it decides to try managing the window, but it also makes it randomly lose focus or even fail to map the window back on screen. Adding the flag after the window has been created fixes the issue. -- v2: winex11: Avoid creating windows with override-redirect flag set. https://gitlab.winehq.org/wine/wine/-/merge_requests/7181

3 6

[PATCH v2 0/4] MR7577: d3dx9: Implement D3DXSaveVolumeToFile{A,W,InMemory}().
by Connor McAdams (＠cmcadams) 20 Mar '25

20 Mar '25

After this there is one more set of patches to finish up the file saving functions, I split it into two to hopefully make it easier to review. :) -- v2: d3dx9: Use D3DXSaveVolumeToFileInMemory() inside of D3DXSaveTextureToFileInMemory(). d3dx9: Implement D3DXSaveVolumeToFile{A,W,InMemory}(). d3dx9/tests: Add tests for D3DXSaveVolumeToFile{A,W,InMemory}(). d3dx9: Add stubs for D3DXSaveVolumeToFile{A,W,InMemory}(). https://gitlab.winehq.org/wine/wine/-/merge_requests/7577

3 16

[PATCH v3 0/2] MR7563: mf/tests: Tests timestamp values on output samples from the H.264 and WMV MFT decoders.
by Brendan McGrath (＠redmcg) 20 Mar '25

20 Mar '25

These tests serve to illustrate the output sample time and duration values from their respective native MFT video decoders with respect to the following circumstances: 1. When no frame rate nor input sample timestamps are provided; 2. When a frame rate is provided but there are no sample timestamps; and 3. When a frame rate is provided, but the input sample timestamps disagree with this value It also highlights the gap in our implementation. However, I don't believe this can be fixed without first confirming the correct output from our IMFMediaStream implementations. -- v3: mf/tests: Test timestamps in WMV decoder. mf/tests: Test timestamps in H264 decoder. https://gitlab.winehq.org/wine/wine/-/merge_requests/7563

3 3

2025

2024

2023

2022

wine-gitlab March 2025