March 2025 - wine-gitlab

[PATCH v6 0/15] MR7516: Server-side thread priorities implementation (Part 3)
by Marc-Aurel Zent (＠mzent) 08 Mar '25

08 Mar '25

This is the continuation of https://gitlab.winehq.org/wine/wine/-/merge_requests/7317. There are a lot of smaller commits (some even no-op renames), because there are some inconsistencies in the codebase currently of what an NT thread priority vs a base thread priority should be and I hope that this clears that up a bit. I tried making the commits as atomic as possible I hope this is fine... There are still a few tiny details missing like fixing up the `list_processes` request and `KeSetPriorityThread` and friends which are either stubs or not correctly working as well. There are also probably a few tests that can be written here (after thread priority boosting has been disabled, cause that makes the behavior on windows very flaky and dynamic). In fact on windows there is some thread priority boost decay going on after the message has been processed (and probably other boosting mechanisms), which this MR does not properly capture, but are also probably not reasonable to implement. This also reverts the commits of https://gitlab.winehq.org/wine/wine/-/merge_requests/1232, which are being effectively overwritten anyways. The `get_thread_priority_info` request was added, because the reply in `get_thread_info` would be otherwise larger than 64 bytes, so it had to be split. -- v6: ntdll/tests: Add tests for process and thread priority. server, ntdll: Fetch both process priority and base_priority. server: Add process base priority helper. kernelbase: Use ProcessPriorityClass info class in GetPriorityClass. kernelbase: Use correct priority in GetThreadPriority. server, ntdll: Fetch both thread priority and base_priority. server, ntdll: Move last thread information to get_thread_info flags. ntdll: Implement ThreadPriority class in NtSetInformationThread. server: Implement setting thread priority directly. server: Add set_thread_priority helper. server: Rename thread priority to base_priority. server: Rename base_priority to effective_priority in apply_thread_priority. https://gitlab.winehq.org/wine/wine/-/merge_requests/7516

2 17

Re: [PATCH v6 0/1] MR6938: Draft: winewayland.drv: Implement support for xdg-toplevel-icon.
by Alex Schwartz (＠alexschwartz01) 08 Mar '25

08 Mar '25

I just tested this on KDE Plasma 6.3 and it works perfectly This would be a great addition to the Wayland driver -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6938#note_97195

1 0

[PATCH 0/1] MR7290: Draft: kernelbase: Handle correctly paths with forward slashes in ReplaceFileW.
by Roman Pišl (＠rpisl) 08 Mar '25

08 Mar '25

PathRemoveFileSpecW keeps only the drive if the path contains all forward slashes as shown in tests. But then the temporary file is created in the root folder which fails for drive Z:. This fixes a corner case when using CMake in Wine. Another usage of PathRemoveFileSpecW is in PathRelativePathToW which should be also checked. I'm leaving this as a draft until getting some feedback and adding tests. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7290

3 5

[PATCH v3 0/1] MR7494: msxml3: IXMLDOMDocument3::preserveWhiteSpace fix for a non VARIANT_BOOL value.
by Alistair Leslie-Hughes (＠alesliehughes) 08 Mar '25

08 Mar '25

0024:trace:msxml:domdoc_put_preserveWhiteSpace (068F0520)->(1) Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=21940 -- v3: msxml3: IXMLDOMDocument3::preserveWhiteSpace fix for a non VARIANT_BOOL value. https://gitlab.winehq.org/wine/wine/-/merge_requests/7494

3 4

[PATCH 0/1] MR7532: winedump: fix grep warning
by Robert Lippmann (＠rlippmann) 08 Mar '25

08 Mar '25

grep gives a warning of: character class syntax is `[[:space:]]`, not `[:space:]` because the syntax is technically incorrect -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7532

2 1

Re: [PATCH v2 0/1] MR7531: winedump: fix grep warning - closed
by Robert Lippmann (＠rlippmann) 08 Mar '25

08 Mar '25

This merge request was closed by Robert Lippmann. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7531

1 0

[PATCH v5 0/15] MR7516: Server-side thread priorities implementation (Part 3)
by Marc-Aurel Zent (＠mzent) 07 Mar '25

07 Mar '25

This is the continuation of https://gitlab.winehq.org/wine/wine/-/merge_requests/7317. There are a lot of smaller commits (some even no-op renames), because there are some inconsistencies in the codebase currently of what an NT thread priority vs a base thread priority should be and I hope that this clears that up a bit. I tried making the commits as atomic as possible I hope this is fine... There are still a few tiny details missing like fixing up the `list_processes` request and `KeSetPriorityThread` and friends which are either stubs or not correctly working as well. There are also probably a few tests that can be written here (after thread priority boosting has been disabled, cause that makes the behavior on windows very flaky and dynamic). In fact on windows there is some thread priority boost decay going on after the message has been processed (and probably other boosting mechanisms), which this MR does not properly capture, but are also probably not reasonable to implement. This also reverts the commits of https://gitlab.winehq.org/wine/wine/-/merge_requests/1232, which are being effectively overwritten anyways. The `get_thread_priority_info` request was added, because the reply in `get_thread_info` would be otherwise larger than 64 bytes, so it had to be split. -- v5: ntdll/tests: Add tests for process and thread priority. https://gitlab.winehq.org/wine/wine/-/merge_requests/7516

2 17

Re: [PATCH v2 0/1] MR7526: weraphi.h: Add WerRegisterCustomMetadata(wstr wstr) - approved
by Alexandre Julliard (＠julliard) 07 Mar '25

07 Mar '25

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7526

1 0

Re: [PATCH v3 0/1] MR7184: vbscript: Correct resource text for VBSE_PARAMETER_NOT_OPTIONAL - approved
by Alexandre Julliard (＠julliard) 07 Mar '25

07 Mar '25

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7184

1 0

Re: [PATCH v3 0/2] MR7493: mp3dmod: Implement an IMFTransform interface. - approved
by Alexandre Julliard (＠julliard) 07 Mar '25

07 Mar '25

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7493

1 0

2025

2024

2023

2022

wine-gitlab March 2025