March 2025 - wine-gitlab

[PATCH v4 0/15] MR7516: Server-side thread priorities implementation (Part 3)
by Marc-Aurel Zent (＠mzent) 07 Mar '25

07 Mar '25

This is the continuation of https://gitlab.winehq.org/wine/wine/-/merge_requests/7317. There are a lot of smaller commits (some even no-op renames), because there are some inconsistencies in the codebase currently of what an NT thread priority vs a base thread priority should be and I hope that this clears that up a bit. I tried making the commits as atomic as possible I hope this is fine... There are still a few tiny details missing like fixing up the `list_processes` request and `KeSetPriorityThread` and friends which are either stubs or not correctly working as well. There are also probably a few tests that can be written here (after thread priority boosting has been disabled, cause that makes the behavior on windows very flaky and dynamic). In fact on windows there is some thread priority boost decay going on after the message has been processed (and probably other boosting mechanisms), which this MR does not properly capture, but are also probably not reasonable to implement. This also reverts the commits of https://gitlab.winehq.org/wine/wine/-/merge_requests/1232, which are being effectively overwritten anyways. The `get_thread_priority_info` request was added, because the reply in `get_thread_info` would be otherwise larger than 64 bytes, so it had to be split. -- v4: ntdll/tests: Add tests for process and thread priority. https://gitlab.winehq.org/wine/wine/-/merge_requests/7516

2 19

[PATCH v3 0/15] MR7516: Server-side thread priorities implementation (Part 3)
by Marc-Aurel Zent (＠mzent) 07 Mar '25

07 Mar '25

This is the continuation of https://gitlab.winehq.org/wine/wine/-/merge_requests/7317. There are a lot of smaller commits (some even no-op renames), because there are some inconsistencies in the codebase currently of what an NT thread priority vs a base thread priority should be and I hope that this clears that up a bit. I tried making the commits as atomic as possible I hope this is fine... There are still a few tiny details missing like fixing up the `list_processes` request and `KeSetPriorityThread` and friends which are either stubs or not correctly working as well. There are also probably a few tests that can be written here (after thread priority boosting has been disabled, cause that makes the behavior on windows very flaky and dynamic). In fact on windows there is some thread priority boost decay going on after the message has been processed (and probably other boosting mechanisms), which this MR does not properly capture, but are also probably not reasonable to implement. This also reverts the commits of https://gitlab.winehq.org/wine/wine/-/merge_requests/1232, which are being effectively overwritten anyways. The `get_thread_priority_info` request was added, because the reply in `get_thread_info` would be otherwise larger than 64 bytes, so it had to be split. -- v3: ntdll/tests: Add tests for process and thread priority. server, ntdll: Fetch both process priority and base_priority. server: Add process base priority helper. kernelbase: Use ProcessPriorityClass info class in GetPriorityClass. kernelbase: Use correct priority in GetThreadPriority. server, ntdll: Fetch both thread priority and base_priority. server, ntdll: Move last thread information to get_thread_info flags. ntdll: Implement ThreadPriority class in NtSetInformationThread. server: Implement setting thread priority directly. server: Add set_thread_priority helper. server: Rename thread priority to base_priority. server: Rename base_priority to effective_priority in apply_thread_priority. server: Infer process priority class in set_thread_priority. include: Use correct PROCESS_PRIORITY_CLASS_* names. include: Add thread priority constants. https://gitlab.winehq.org/wine/wine/-/merge_requests/7516

2 18

[PATCH 0/1] MR7529: msxml3: Correct looping of Document Element properties.
by Spencer Wallace (＠spencerwallace) 07 Mar '25

07 Mar '25

The attribute index is incorrectly incremented when the element contains properties, causing the wrong namespace to be fetched. https://testbot.winehq.org/JobDetails.pl?Key=151709 -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7529

2 1

[PATCH 0/1] MR7528: include: Add mpeg2data.idl.
by Biswapriyo Nath (＠Biswa96) 07 Mar '25

07 Mar '25

Required for https://code.videolan.org/videolan/vlc/-/commit/e68f089d5419c7832c625f535f9… Previous MR !7508 -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7528

2 1

[PATCH 0/1] MR7508: include: Add mpeg2data.idl.
by Biswapriyo Nath (＠Biswa96) 07 Mar '25

07 Mar '25

Required for https://code.videolan.org/videolan/vlc/-/commit/e68f089d5419c7832c625f535f9… -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7508

5 10

[PATCH v36 0/9] MR5769: Add support for large page backed file mapping objects on Linux.
by Vibhav Pant (＠vibhavp) 07 Mar '25

07 Mar '25

This MR adds support for creating file mapping objects backed by large pages on Linux, by making the following changes: ## wineserver * On Linux, `create_temp_file` will first attempt to use memfds as the backing fd. If it fails, it'll return to the current codepath, creating a temporary file in either the server or config directory. * The created memfd will be sealed against writes, if the caller requesting the appropriate page protection flags. * This removes the requirement that FDs be only created on filesystems/directories that aren't `noexec`. * In the server method `create_mapping` , if large pages have been requested by the caller, hold that the calling thread's token holds `SeLockMemoryPrivilege` . * Additionally, add `SeLockMemoryPrivilege` to the list of privileges enabled for the Administrator. ## `ntdll` * Add `virtual_get_min_large_page_size` and its exported wrapper `wine_unix_get_min_large_page_size`. * On Linux, the minimum page size is determined by going through `/sys/kernel/mm/hugepages`. If hugepage support was not detected, `STATUS_NOT_SUPPORTED` is returned instead. On other platforms, the older hard-coded value of 2\*1024\*1024 is returned instead. * `NtCreateSection` will validate certain parameters if large pages are requested. Specifically, it will return STATUS_INVALID_PARAMETER if the requested mapping is not anonymous/unnamed, or the size is not a multiple of the minimum supported page size. ## `kernelbase` * `GetLargePageMinimum` will use `wine_unix_get_min_large_page_size`. ## `kernel32/tests` * Add new test test_large_page_file_mapping, which validates privilege enforcements and parameter validation while creating large pages backed file mapping obejcts. The tests are skipped if `GetLargePageMinimum` returns 0. -- v36: advapi32: Fake the SeLockMemoryPrivilege right in LsaEnumerateAccountRights. psapi: Add tests for querying information for large pages. ntdll: Use PAGEMAP_SCAN ioctl to implement get_working_set_ex, if available. kernel32: Add tests for large pages support. ntdll: Support allocating virtual memory, creating and mapping files backed by large/huge pages. server: Use memfd to back anonymous mappings on Linux. kernelbase: Implement GetLargePageMinimum by returning the value of LargePageMinimum in _KUSER_SHARED_DATA. server: Set LargePageMinimum in _KUSER_SHARED_DATA on Linux. server: Require SeLockMemoryPrivilege to create large page mappings. https://gitlab.winehq.org/wine/wine/-/merge_requests/5769

3 11

[PATCH 0/2] MR7527: include: Introduce minwinbase.h and sysinfoapi.h header files.
by Jacek Caban (＠jacek) 07 Mar '25

07 Mar '25

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/7527

2 2

[PATCH 0/1] MR7526: weraphi.h: Add WerRegisterCustomMetadata(wstr wstr)
by Raphael Riemann (＠rariema) 07 Mar '25

07 Mar '25

Microsoft Flight Simulator 2024 needs this since SU1 https://github.com/ValveSoftware/Proton/issues/8255#issuecomment-2640144747 -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7526

2 1

[PATCH v2 0/2] MR7524: weraphi.h: Add WerRegisterCustomMetadata(wstr wstr)
by Raphael Riemann (＠rariema) 07 Mar '25

07 Mar '25

add stubs to weraphi.h for WerRegisterCustomMetadata(wstr wstr) WerUnregisterCustomMetadata(wstr) Microsoft Flight Simulator 2024 needs this sice SU1 https://github.com/ValveSoftware/Proton/issues/8255#issuecomment-2640144747 -- v2: weraphi.h: Add WerRegisterCustomMetadata(wstr wstr) https://gitlab.winehq.org/wine/wine/-/merge_requests/7524

2 3

[PATCH 0/1] MR7525: Draft: winewayland: Take into account requested xdg state when sending xdg requests.
by Alexandros Frantzis (＠afrantzis) 07 Mar '25

07 Mar '25

Track the xdg state we have requested from the compositor and take it into account when sending xdg state update requests. This fixes a race which would cause us to miss a state update if we haven't yet processed the compositor's configure reply to a previous state request. For example: 0. Initial state: win32 fullscreen, xdg fullscreen 1. Window becomes windowed, we send xdg unset_fullscreen request 2. Window becomes fullscreen, before compositor's xdg "not fullscreen" reply arrives, so we still consider the current xdg state to be fullscreen and thus do not request an xdg fullscreen state 3. Compositor xdg configure "not fullscreen" arrives -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7525

2 1

2025

2024

2023

2022

wine-gitlab March 2025