March 2025 - wine-gitlab

Re: [PATCH v4 0/1] MR7460: propsys/tests: Add broken for unexpected value in windows 7.
by Bernhard Übelacker (＠bernhardu) 04 Mar '25

04 Mar '25

On Tue Mar 4 12:15:46 2025 +0000, Rémi Bernon wrote: > This now causes a "Test succeeded inside todo block" test failure on linux. Sorry, this was not my intention. This line should make sure `check_PropVariantToBSTR2` is never called with anything else than `VT_R4`, but I have not considered this to be inside a `todo_wine` altogether. I created !7487 to fix this. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7460#note_96755

1 0

[PATCH 0/1] MR7487: propsys/tests: Fix check_PropVariantToBSTR2.
by Bernhard Übelacker (＠bernhardu) 04 Mar '25

04 Mar '25

Cannot use always succeeding ok statement, because check_PropVariantToBSTR2 is used inside a todo_wine block. Followup to a1637b167f. This was intended to make sure check_PropVariantToBSTR2 is just called with `VT_R4`, but makes now more problems than good. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7487

2 1

Re: [PATCH v7 0/8] MR7152: dxgi: Fix the frame latency waitable implementation.
by Giovanni Mascellani (＠giomasce) 04 Mar '25

04 Mar '25

On Tue Mar 4 11:59:46 2025 +0000, Rémi Bernon wrote: > Fwiw this broke the tests on windows, the pipeline was failing already here. Sorry, I didn't notice that. https://gitlab.winehq.org/wine/wine/-/merge_requests/7486 should fix it. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7152#note_96749

1 0

[PATCH 0/3] MR7416: wined3d: Interpret Y'CbCr values as being from the reduced range.
by Elizabeth Figura (＠zfigura) 04 Mar '25

04 Mar '25

This is an adjustment of 7324. d3d9:visual already has a test that's relatively close to what a simplified version of the tests in 7324 looked like, so I made the few changes to expand that test to match and then ported it to ddraw. Implementation-wise, this removes the SD/HD difference (which only exists on NVidia and is not necessary to improve the mentioned application). It also removes the clamping of YUV values, which as the tests show is not correct. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7416

6 8

[PATCH v10 0/1] MR7288: winegstreamer: Avoid large buffer pushes in wg_transform.
by Yuxuan Shui (＠yshui) 04 Mar '25

04 Mar '25

## Context This is a problem discovered when running "Max: The Curse of Brotherhood" under proton. This game writes 4MB a piece into `wg_transform`, which contains about 4 seconds of compressed video. `wg_transform` calls `gst_pad_push` in `transform_ProcessOutput`, which takes \~300ms (i.e. 20 frames @ 60fps) to decode this buffer of video. So the end result is the game hitches every 4 seconds while playing cut scene videos. Proton currently has a special case for this particular game, for which it breaks up the buffer into small chunks to avoid long blocks. This MR adopts that and applies it generally. One concern raised by @redmcg is: > The only issue I can think of is if there are any decoders which don't have a parser; then they might not know how to deal with an arbitrary 4096 byte buffer (the parser is generally responsible for taking arbitrary buffers and producing something the decoder can work with, for example: a full frame). So this MR only enables this strategy when there is a parser element. -- v10: winegstreamer: Avoid large buffer pushes in wg_transform. https://gitlab.winehq.org/wine/wine/-/merge_requests/7288

3 3

[PATCH 0/1] MR7478: user32: Use the correct DPI in AdjustWindowRect(Ex) when DPI virtualization is active.
by Brendan Shanks (＠bshanks) 04 Mar '25

04 Mar '25

`AdjustWindowRect(Ex)` were using the system DPI even in non-DPI-aware applications, leading to some bizarre behavior. An easy test for this is to remove the DPI awareness from `winemine`'s manifest, set the system DPI to 192, then run `winemine` and click the smiley face. Every click on the smiley face will move the window up by ~30 pixels. A copy of ioquake3 with DPI awareness removed would also constantly enlarge its window vertically. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7478

3 2

[PATCH 0/1] MR7485: advapi32: Add CreateProcessWithLogonW() semi-stub.
by Dmitry Timoshkov (＠dmitry) 04 Mar '25

04 Mar '25

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/7485

2 1

[PATCH 0/2] MR7484: wbemprox: Fix format string.
by Hans Leidekker (＠hans) 04 Mar '25

04 Mar '25

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/7484

2 2

[PATCH 0/3] MR7482: Include defines
by Alistair Leslie-Hughes (＠alesliehughes) 04 Mar '25

04 Mar '25

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/7482

3 4

[PATCH v6 0/1] MR7353: winewayland: Implement SetCursorPos via pointer lock.
by Attila Fidan (＠atticf) 04 Mar '25

04 Mar '25

There is no ([not yet?](https://gitlab.freedesktop.org/wayland/wayland-protocols/-/merge_requ…) dedicated protocol for requesting pointer warps, but it's possible to request one with `zwp_locked_pointer_v1.set_cursor_position_hint` which may be performed when the pointer is unlocked. The idea is to quickly lock/set position/unlock. This is used by SDL (in some cases: [SDL_MOUSE_EMULATE_WARP_WITH_RELATIVE](https://wiki.libsdl.org/SDL3/SDL_HINT…) and Xwayland. The limitation is/will be that the compositor will ignore requests to warp the pointer outside of surface bounds. What I'd like to have working is the auto cursor placement feature of some applications, where they just want to call SetCursorPos towards specific UI elements inside their single window, and usually they'll be unclipped and have a visible cursor while doing this. This patch also happens to allow mouselook to work in applications which use SetCursorPos for mouselook and aren't getting covered by the heuristics that turn on Wayland relative motion (for some reason the driver thinks the cursor is visible). Seems to affect Half-Life (GoldSrc) on my system. Though force enabling relative motion with an environment variable in a custom build or somehow improving the heuristics will also fix that. ~~A suface/pointer can only have one lock or confinement, and this implementation depends on the pointer lock. So if needed, I temporarily unlock/unconfine in order to do the warp then relock/reconfine. I modified `wayland_pointer_update_constraint` so I don't have to temporarily disable relative motion during this in case it's enabled. I think it's safe/a no-op to attempt pointer warps while using relative motion, as according to the protocol the warp will not generate a relative motion event, and while there will be a wl_pointer motion event, they're ignored while relative motion is being used.~~ -- v6: winewayland: Implement SetCursorPos via pointer lock. https://gitlab.winehq.org/wine/wine/-/merge_requests/7353

3 4

2025

2024

2023

2022

wine-gitlab March 2025