March 2025 - wine-gitlab

Re: [PATCH v6 0/2] MR7417: mfplat: Modify MFCreateWaveFormatExFromMFMediaType to allow all subtypes without MF_MT_USER_DATA.
by Brendan McGrath (＠redmcg) 01 Mar '25

01 Mar '25

On Sat Mar 1 10:14:45 2025 +0000, Nikolay Sivov wrote: > Sorry, I didn't check linux-32 results. I took a look at the linux-32 results, but I missed the mf failures (I thought they were all ddraw). Why would linux-32 fail but not linux-64? Anyway, it's the same test failing twice: ``` $ xmllint --xpath 'testsuites/testsuite/testcase[failure and @classname="mf:transform"]/@name' winetest.xml name="mf:transform transform.c:2587 Test failed: aacdec: "MF_MT_USER_DATA": SetInputType returned 0." name="mf:transform transform.c:2587 Test failed: aacdec: "MF_MT_USER_DATA": SetInputType returned 0." ``` The test checks that a call to `SetInputType` on the AAC decoder returns an error when `MF_MT_USER_DATA` is missing. It does so by relying on the return value of `MFCreateWaveFormatExFromMFMediaType`. So it's dependent on what was the broken behavior. I suspect it should also be checking `cbSize`. I'll add tests to confirm as much and then fix. Note, I have confirmed that we now have the correct behavior for `MFCreateWaveFormatExFromMFMediaType` by adding (locally) the following two tests: ``` @@ -5958,6 +5958,8 @@ static void test_MFCreateWaveFormatExFromMFMediaType(void) { &MFAudioFormat_Float, WAVE_FORMAT_IEEE_FLOAT, sizeof(WAVEFORMATEX), 0, }, { &MFAudioFormat_MP3, WAVE_FORMAT_MPEGLAYER3, sizeof(WAVEFORMATEX), 0, }, { &DUMMY_GUID3, WAVE_FORMAT_EXTENSIBLE, sizeof(WAVEFORMATEXTENSIBLE), 22, }, + { &MFAudioFormat_AAC, WAVE_FORMAT_MPEG_HEAAC, sizeof(WAVEFORMATEX), 0, }, + { &MFAudioFormat_RAW_AAC, WAVE_FORMAT_RAW_AAC1, sizeof(WAVEFORMATEX), 0, }, ``` Test bot passes: https://testbot.winehq.org/JobDetails.pl?Key=151559 Well Windows did, Debian crashed. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7417#note_96328

1 0

Re: [PATCH v26 0/1] MR6884: Iphlpapi.dll: Included SendARP
by Thi Garlet (＠garlett) 01 Mar '25

01 Mar '25

@huw could you help to merge this? Thanks -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6884#note_96325

1 0

[PATCH v7 0/1] MR7369: include/security.h: Add definition of NEGOSSP_NAME
by Vadim Kazakov (＠xipster) 01 Mar '25

01 Mar '25

`error: use of undeclared identifier 'NEGOSSP_NAME'` I encountered the following problem when trying to compile these programs with winegcc: - https://learn.microsoft.com/en-us/windows/win32/secauthn/using-sspi-with-a-… - https://learn.microsoft.com/en-us/windows/win32/secauthn/using-sspi-with-a-… So, adding this code helps to solve the problem -- v7: include/security.h: Add definition of NEGOSSP_NAME https://gitlab.winehq.org/wine/wine/-/merge_requests/7369

2 1

[PATCH 0/1] MR7455: wineusb.sys: Add support for URB_FUNCTION_VENDOR_ENDPOINT.
by Alexander Morozov (＠amorozov) 01 Mar '25

01 Mar '25

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/7455

2 1

[PATCH v2 0/4] MR7453: ole32: Improvements to property storage saving
by Piotr Caban (＠piotr) 01 Mar '25

01 Mar '25

-- v2: ole32: Reset output stream when wrting property storage. ole32: Remove end label from PropertyStorage_WriteToStream. https://gitlab.winehq.org/wine/wine/-/merge_requests/7453

2 5

[PATCH 0/3] MR7453: ole32: Improvements to property storage saving
by Piotr Caban (＠piotr) 01 Mar '25

01 Mar '25

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/7453

3 4

[PATCH 0/1] MR7454: msvcr120: Simplify feupdateenv implementation.
by Piotr Caban (＠piotr) 01 Mar '25

01 Mar '25

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/7454

2 1

[PATCH 0/1] MR7452: kernel32/tests: Fix thread handle leak in store_buffer_litmus_test
by Jinoh Kang (＠iamahuman) 01 Mar '25

01 Mar '25

Fixes: dd790850a01f1af26b2bbcd09088dcdf6b2ebb94 -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7452

2 1

[PATCH 0/1] MR7440: dwrite: Use Noto Sans as fallback for General and Supplemental Punctuation.
by Daniel Lehman (＠dlehman25) 01 Mar '25

01 Mar '25

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/7440

3 6

[PATCH 0/1] MR7451: dlls/shell32: Fix IUnknown::QueryInterface() to meet spec
by Edward OC (＠funfunctor) 01 Mar '25

01 Mar '25

The spec says if the passed pointer is NULL then return E_POINTER and not to just unconditionally deref then set NULL. Signed-off-by: Edward O'Callaghan <edward(a)antitrust.cc> -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7451

3 2

2025

2024

2023

2022

wine-gitlab March 2025