I'm dealing with a game that relies on this constant.
Tagging @rbernon since this is using a proton commit of his.
Tests should be run both with HKCU\\Software\\Wine\\MediaFoundation\\DisableGstByteStreamHandler enabled and disabled.
--
https://gitlab.winehq.org/wine/wine/-/merge_requests/8183
Always copying client class name to temporary buffer, to which version string also points to, in order to convert integral class names to string and unify the logic for versioning later on.
--
v2: user32: Always copy class names to a temporary buffer.
comctl32: Fix class name case in manifest.
user32: Move get_class_version out of get_class_info.
user32: Load class module in get_class_version.
user32: Move user32_module default out of get_class_info.
user32: Init class name outside of get_versioned_name.
https://gitlab.winehq.org/wine/wine/-/merge_requests/8358
77622615b657feedfb379f51346b4d05a2cbd0c4 still fails with:
```
cfgmgr32.c:561: Test succeeded inside todo block: got len 0
cfgmgr32.c:562: Test succeeded inside todo block: got objects 0000000000000000
cfgmgr32.c:566: Test succeeded inside todo block: got len 0
cfgmgr32.c:567: Test succeeded inside todo block: got objects 0000000000000000
```
--
https://gitlab.winehq.org/wine/wine/-/merge_requests/8438#note_108344
On Mon Jun 30 15:44:52 2025 +0000, Vibhav Pant wrote:
> Shouldn't this be `!bat->present`?
Hi Vibhav,
Fear it should, yes. Thank you for catching that.
Anything else you'd like to add before I edit the commit and rerun the pipeline? Thank you.
--
https://gitlab.winehq.org/wine/wine/-/merge_requests/8460#note_108343
On Mon Jun 30 10:40:44 2025 +0000, Rémi Bernon wrote:
> Are you an AI yourself? Has this been written with an AI?
Hi Rémi.
No on both accounts.
Just an unfortunate automatic suggestion made by github when LLMs were not really a _thing_ yet.
That being said, if somethings seems off about the code it's probably because I haven't dabbed in C since college. Any critiques or suggestions are much appreciated. Thanks.
--
https://gitlab.winehq.org/wine/wine/-/merge_requests/8460#note_108342