June 2025 - wine-gitlab

Re: [PATCH v2 0/6] MR8426: server: Use an event sync for console objects.
by Elizabeth Figura (＠zfigura) 25 Jun '25

25 Jun '25

If we're going to do that, we might as well use the fd. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/8426#note_107934

1 0

[PATCH v6 0/3] MR8258: comctl32/treeview: Return from TREEVIEW_LButtonDown when the treeview handle is invalid.
by Jacob Czekalla (＠JacobCzekalla) 25 Jun '25

25 Jun '25

comctl32/treeview: Return from TREEVIEW_LButtonDown when the treeview handle is invalid. LButtonDown should return when the treeview handle is invalid (e.g. destroyed) after NM_CLICK to prevent further message processing. Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=58211 -- v6: comctl32/treeview: Return from TREEVIEW_LButtonDown when the treeview handle is invalid. comctl32/treeview: Add a function for sending notifications that also checks for invalid treeview. comctl32/tests: Add a test for treeview deletion during NM_CLICK in LBUTTONDOWN. https://gitlab.winehq.org/wine/wine/-/merge_requests/8258

2 3

[PATCH v5 0/7] MR8402: mf/session: Use a dedicated state when source is shutdown.
by Rémi Bernon (＠rbernon) 25 Jun '25

25 Jun '25

This should fix some spurious test failure in `test_media_session_Close`, as sometimes the source shutdown happens quickly enough and changes the session state to SESSION_STATE_STOPPED, causing the later Close command to succeed when it consistently returns E_SHUTDOWN on Windows. -- v5: mf/session: Simplify the media session shutdown event handling. mf/session: Introduce a SESSION_FLAG_SOURCE_SHUTDOWN presentation flag. mf/session: Replace SESSION_FLAG_END_OF_PRESENTATION with dedicated states. mf/session: Replace SESSION_FLAG_FINALIZE_SINKS with dedicated states. mf/session: Remove unnecessary SESSION_FLAG_PENDING_COMMAND flag. mf/session: Move internal states to a separate command_state enum. mf/session: Clarify internal states from session states separation. https://gitlab.winehq.org/wine/wine/-/merge_requests/8402

2 8

[PATCH v2 0/3] MR8411: Draft: More fixes to CallWindowProc[AW] calls storing the return value in a 4-byte type.
by Bernhard Übelacker (＠bernhardu) 25 Jun '25

25 Jun '25

While preparing !8397 I wondered If there other uses of CallWindowProc[AW] which use a 4-byte sized type to store the return value, while at x86_64 LRESULT is 8 bytes. -- v2: winetest: Use LRESULT to return value from CallWindowProcA. https://gitlab.winehq.org/wine/wine/-/merge_requests/8411

4 6

[PATCH 0/1] MR8421: dxgi/tests: Fix out-of-bound in test_cursor_clipping.
by Yuxuan Shui (＠yshui) 25 Jun '25

25 Jun '25

Missing a bound check for "modes". -- https://gitlab.winehq.org/wine/wine/-/merge_requests/8421

3 3

[PATCH v4 0/7] MR8402: mf/session: Use a dedicated state when source is shutdown.
by Rémi Bernon (＠rbernon) 25 Jun '25

25 Jun '25

This should fix some spurious test failure in `test_media_session_Close`, as sometimes the source shutdown happens quickly enough and changes the session state to SESSION_STATE_STOPPED, causing the later Close command to succeed when it consistently returns E_SHUTDOWN on Windows. -- v4: mf/session: Simplify the media session shutdown event handling. mf/session: Introduce a SESSION_FLAG_SOURCE_SHUTDOWN presentation flag. mf/session: Replace SESSION_FLAG_END_OF_PRESENTATION with dedicated states. mf/session: Replace SESSION_FLAG_FINALIZE_SINKS with dedicated states. mf/session: Remove unnecessary SESSION_FLAG_PENDING_COMMAND flag. mf/session: Move internal states to a separate command_state enum. mf/session: Clarify internal states from session states separation. https://gitlab.winehq.org/wine/wine/-/merge_requests/8402

2 9

[PATCH 0/1] MR8419: ddraw: Fix use-after-free of the ddraw object.
by Yuxuan Shui (＠yshui) 25 Jun '25

25 Jun '25

ddraw surfaces also hold references to their ddraw objects, but that's not cleared in ddraw_destroy. * * * not sure if other uses of surface->ddraw need to be guarded too, let me know if i need to change them too. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/8419

3 6

[PATCH v2 0/2] MR7938: Draft: winemac: Use IOSurface to update native window layers instead of CGImage.
by Marc-Aurel Zent (＠mzent) 25 Jun '25

25 Jun '25

This consolidates the two separate `CGImage`s (`colorImage` and `shapeImage`) previously used in `WineContentView` into a single `IOSurface` that also holds the window mask information in its alpha channel now. The alpha channel is now being updated in `macdrv_surface_flush`, whenever the shape changes (and stores that change for the next update, to also keep the front buffer in sync). This reduces the delay from setting a `CGImage` to a layer from 50ms to about 1.5ms in the `IOSurface` case (also accounting for `vImageSelectChannels_ARGB8888` operation). Based on a patch by @bshanks. I am already putting it out for feedback, but I will so some more testing to see how the performance impact of this is and do more exhaustive testing with shaped windows. Ideally the double buffer solution can be avoided as well... Also the `HBITMAP` for the windows is currently backed by a `CGDataProviderRef` and could also become an `IOSurface` I believe. -- v2: winemac: Use IOSurface to update native window layers instead of CGImage. winemac: Also return alpha channel in macdrv_window_background_color. https://gitlab.winehq.org/wine/wine/-/merge_requests/7938

2 2

[PATCH v3 0/7] MR8402: mf/session: Use a dedicated state when source is shutdown.
by Rémi Bernon (＠rbernon) 25 Jun '25

25 Jun '25

This should fix some spurious test failure in `test_media_session_Close`, as sometimes the source shutdown happens quickly enough and changes the session state to SESSION_STATE_STOPPED, causing the later Close command to succeed when it consistently returns E_SHUTDOWN on Windows. -- v3: mf/session: Simplify the media session shutdown event handling. mf/session: Introduce a SESSION_FLAG_SOURCE_SHUTDOWN presentation flag. mf/session: Replace SESSION_FLAG_END_OF_PRESENTATION with dedicated states. mf/session: Replace SESSION_FLAG_FINALIZE_SINKS with dedicated states. mf/session: Remove unnecessary SESSION_FLAG_PENDING_COMMAND flag. mf/session: Move internal states to a separate command_state enum. mf/session: Clarify internal states from session states separation. https://gitlab.winehq.org/wine/wine/-/merge_requests/8402

3 10

[PATCH v7 0/2] MR4518: ntdll: Integrate with GDB using r_debug.
by Rémi Bernon (＠rbernon) 25 Jun '25

25 Jun '25

Effectively implementing the debugger interface as described in https://sourceware.org/git/?p=glibc.git;a=blob;f=elf/rtld-debugger-interfac… This is an actual attempt at having this upstream, split from https://gitlab.winehq.org/wine/wine/-/merge_requests/1074 which people have been finding useful for debugging Wine directly in GDB. This supports everything you would expect, from automatic symbol loading as well as cross-syscall backtraces with the new Python unwinder. -- v7: ntdll: Maintain a PE module link map and expose it to GDB. loader: Expose the standard debugging symbols for GDB. https://gitlab.winehq.org/wine/wine/-/merge_requests/4518

3 6

2025

2024

2023

2022

wine-gitlab June 2025