June 2025 - wine-gitlab

[PATCH v6 0/5] MR8174: winebth.sys part 12: Introduce support for Low Energy GATT services
by Vibhav Pant (＠vibhavp) 04 Jun '25

04 Jun '25

Generic ATTribute Profile (GATT) is a protocol used by BLE devices for data exchange. Broadly, every LE device contains one or more GATT services, with each service having multiple characteristics, which contain the actual piece of data to be exchanged. The Win32 BLE api is defined in [`bluetoothleapis.h`](https://learn.microsoft.com/en-us/windows/win32/api/bluetoothleapis/), and operates on `HANDLE`s to PDOs created by the driver to remote devices and services, using the `GUID_BLUETOOTHLE_DEVICE_INTERFACE` and `GUID_BLUETOOTH_GATT_SERVICE_DEVICE_INTERFACE` class interfaces respectively. This MR introduces initial support for accessing GATT services on LE devices: * Create PDOs for remote devices that we discover GATT services on, and enabling `GUID_BLUETOOTHLE_DEVICE_INTERFACE` for them. * Because the driver also creates PDOs for bluetooth radios, a tagged union is used to distinguish between device extension values to dispatch IOCTL and PnP IRPs appropriately. * Enumerate through all `org.bluez.GattService1` objects on BlueZ, and store them on the PE driver inside the associated devices. * Implement IOCTL_WINEBTH_LE_DEVICE_GET_GATT_SERVICES for device PDOs. * Use the newly added IOCTL to implement [`BluetoothGATTGetServices`](https://learn.microsoft.com/en-us/windows/win32/api/bluetoothleapis/nf-bluetoothleapis-bluetoothgattgetservices). -- v6: bluetoothapis/tests: Add tests for BluetoothGATTGetServices. bluetoothapis: Implement BluetoothGATTGetServices. winebth.sys: Implement IOCTL_WINEBTH_LE_DEVICE_GET_GATT_SERVICES. winebth.sys: Store a list of GATT services discovered on LE devices. winebth.sys: Create PDOs for remote Bluetooth devices. https://gitlab.winehq.org/wine/wine/-/merge_requests/8174

2 8

[PATCH v5 0/5] MR8174: winebth.sys part 12: Introduce support for Low Energy GATT services
by Vibhav Pant (＠vibhavp) 04 Jun '25

04 Jun '25

Generic ATTribute Profile (GATT) is a protocol used by BLE devices for data exchange. Broadly, every LE device contains one or more GATT services, with each service having multiple characteristics, which contain the actual piece of data to be exchanged. The Win32 BLE api is defined in [`bluetoothleapis.h`](https://learn.microsoft.com/en-us/windows/win32/api/bluetoothleapis/), and operates on `HANDLE`s to PDOs created by the driver to remote devices and services, using the `GUID_BLUETOOTHLE_DEVICE_INTERFACE` and `GUID_BLUETOOTH_GATT_SERVICE_DEVICE_INTERFACE` class interfaces respectively. This MR introduces initial support for accessing GATT services on LE devices: * Create PDOs for remote devices that we discover GATT services on, and enabling `GUID_BLUETOOTHLE_DEVICE_INTERFACE` for them. * Because the driver also creates PDOs for bluetooth radios, a tagged union is used to distinguish between device extension values to dispatch IOCTL and PnP IRPs appropriately. * Enumerate through all `org.bluez.GattService1` objects on BlueZ, and store them on the PE driver inside the associated devices. * Implement IOCTL_WINEBTH_LE_DEVICE_GET_GATT_SERVICES for device PDOs. * Use the newly added IOCTL to implement [`BluetoothGATTGetServices`](https://learn.microsoft.com/en-us/windows/win32/api/bluetoothleapis/nf-bluetoothleapis-bluetoothgattgetservices). -- v5: bluetoothapis/tests: Add tests for BluetoothGATTGetServices. bluetoothapis: Implement BluetoothGATTGetServices. winebth.sys: Implement IOCTL_WINEBTH_LE_DEVICE_GET_GATT_SERVICES. winebth.sys: Store a list of GATT services discovered on LE devices. winebth.sys: Create PDOs for remote Bluetooth devices. https://gitlab.winehq.org/wine/wine/-/merge_requests/8174

2 5

[PATCH 0/2] MR8170: libs/musl: Set EDOM in exp for NAN.
by Daniel Lehman (＠dlehman25) 04 Jun '25

04 Jun '25

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/8170

3 3

[PATCH v3 0/1] MR7837: shell32/tests: Avoid hang in test_rename.
by Bernhard Übelacker (＠bernhardu) 04 Jun '25

04 Jun '25

Followup of 0eab97ffa8. Usually version checks have to be avoided, but this modifies a pre-existing version check to skip that single test just with Windows 7. [Test pattern page.](https://test.winehq.org/data/patterns.html#shell32:shlfileop) [Testbot run with this patch included.](https://testbot.winehq.org/JobDetails.pl?Key=157955) CC: @zhui -- v3: shell32/tests: Avoid hang in test_rename. https://gitlab.winehq.org/wine/wine/-/merge_requests/7837

2 3

[PATCH 0/1] MR8180: crypt32: Fix use-after-free in CRYPT_ImportSystemRootCertsToReg.
by Yuxuan Shui (＠yshui) 04 Jun '25

04 Jun '25

CRYPT_ImportSystemRootCertsToReg calls sync_trusted_roots_from_known_locations which calls check_and_store_certs. check_and_store_certs creates a chain engine with `cached`. Here the problem is that the chain engine actually owns the store used to create it. And when later the chain engine is freed, the store is closed too. This means on the success path `cached` is already closed when sync_trusted_roots_from_known_locations returns to CRYPT_ImportSystemRootCertsToReg, but CRYPT_ImportSystemRootCertsToReg tries to close `cached` again. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/8180

3 12

[PATCH v2 0/1] MR7837: shell32/tests: Avoid hang in test_rename.
by Bernhard Übelacker (＠bernhardu) 04 Jun '25

04 Jun '25

Followup of 0eab97ffa8. Usually version checks have to be avoided, but this modifies a pre-existing version check to skip that single test just with Windows 7. [Test pattern page.](https://test.winehq.org/data/patterns.html#shell32:shlfileop) [Testbot run with this patch included.](https://testbot.winehq.org/JobDetails.pl?Key=157955) CC: @zhui -- v2: shell32/tests: Avoid hang in test_rename. https://gitlab.winehq.org/wine/wine/-/merge_requests/7837

2 1

[PATCH v2 0/3] MR8195: widl: Always use NdrClientCall2() for interpreted stubs.
by Nikolay Sivov (＠nsivov) 04 Jun '25

04 Jun '25

NdrClientCall() should only be used in 32-bit mode when Oi or Oic stub optimizations are used. Currently our interpreted mode targets Oicf mode and other levels are not supported. Signed-off-by: Nikolay Sivov <nsivov(a)codeweavers.com> -- v2: include: Add errlup.idl. widl: Do not write "const" modifiers for _PARAM_STRUCT fields. https://gitlab.winehq.org/wine/wine/-/merge_requests/8195

4 6

[PATCH 0/1] MR8202: win32u: Avoid closing NULL egl_handle on dlopen failure.
by Rémi Bernon (＠rbernon) 04 Jun '25

04 Jun '25

Wine-Bug: http://bugs.winehq.org/show_bug.cgi?id=58321 -- https://gitlab.winehq.org/wine/wine/-/merge_requests/8202

2 1

[PATCH v4 0/5] MR8061: win32u: Read window dpi_context from the shared memory.
by Rémi Bernon (＠rbernon) 04 Jun '25

04 Jun '25

-- v4: win32u: Read window dpi_context from the shared memory. win32u: Pass id and offset separately to find_shared_session_object. server: Move window dpi_context to the shared memory. server: Allocate shared memory objects for windows. server: Fix shared object offset when additional blocks are allocated. https://gitlab.winehq.org/wine/wine/-/merge_requests/8061

2 7

[PATCH 0/1] MR8200: cmd: COPY should output file names as they are copied.
by Joe Souza (＠JoeS209) 04 Jun '25

04 Jun '25

In native Windows, the COPY command will display the names of the files as they are copied. Wine should do the same. This change enables that. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/8200

3 2

2025

2024

2023

2022

wine-gitlab June 2025