--
v15: setupapi: Support in-built properties in SetupDiGetDevicePropertyW and CM_Get_DevNode_Property_ExW.
ntoskrnl.exe/tests: Add tests for built-in properties for PnP device instances.
setupapi/tests: Add tests for inbuilt device properties.
https://gitlab.winehq.org/wine/wine/-/merge_requests/8515
On Mon Jul 14 18:05:00 2025 +0000, Vibhav Pant wrote:
> On Clang, it results in this error for x86_64:
> ```
> ../dlls/setupapi/tests/devinst.c:1392:86: error: format specifies type
> 'unsigned long' but the argument has type 'unsigned long long' [-Werror,-Wformat]
> 1392 | ok(keys_len >= ARRAY_SIZE(expected_keys), "Expected %lu
> >= %lu\n", keys_len, ARRAY_SIZE(expected_keys));
> ```
> for i686:
> ```
> ../dlls/setupapi/tests/devinst.c:1392:86: error: format specifies type
> 'unsigned long' but the argument has type 'unsigned int' [-Werror,-Wformat]
> 1392 | ok(keys_len >= ARRAY_SIZE(expected_keys), "Expected %lu
> >= %lu\n", keys_len, ARRAY_SIZE(expected_keys));
> ```
That's capital I, not lowercase l. I cannot imagine what on earth possessed gitlab to use a sans-serif font by default.
--
https://gitlab.winehq.org/wine/wine/-/merge_requests/8515#note_109815
On Mon Jul 14 17:58:45 2025 +0000, Elizabeth Figura wrote:
> Personally I feel that writing a constant in an error message is
> redundant. You already know what the expected value is by looking at the
> test; it doesn't help to print it in the terminal.
Fair, I just wanted to keep the same test style as the rest of the code in `test_device_property`, which seems to use this format as well.
--
https://gitlab.winehq.org/wine/wine/-/merge_requests/8515#note_109813
On Mon Jul 14 17:59:28 2025 +0000, Elizabeth Figura wrote:
> You can use %Iu for sizeof.
On Clang, it results in this error for x86_64:
```
../dlls/setupapi/tests/devinst.c:1392:86: error: format specifies type 'unsigned long' but the argument has type 'unsigned long long' [-Werror,-Wformat]
1392 | ok(keys_len >= ARRAY_SIZE(expected_keys), "Expected %lu >= %lu\n", keys_len, ARRAY_SIZE(expected_keys));
```
for i686:
```
../dlls/setupapi/tests/devinst.c:1392:86: error: format specifies type 'unsigned long' but the argument has type 'unsigned int' [-Werror,-Wformat]
1392 | ok(keys_len >= ARRAY_SIZE(expected_keys), "Expected %lu >= %lu\n", keys_len, ARRAY_SIZE(expected_keys));
```
--
https://gitlab.winehq.org/wine/wine/-/merge_requests/8515#note_109812