- wine-gitlab - winehq.org

[PATCH 0/1] MR7932: mf: Restart transforms and sinks on seek.
by Brendan McGrath (＠redmcg) 04 May '25

04 May '25

This MR fixes seek in VRChat by copying the sequence of flushes/stop/starts that Windows does. The order on Windows is: 1. Stop sources; 2. Flush MFTs; 3. Start sources; 4. Request output down the chain of sink inputs; 6. Flush sinks; and 7. Start the clock This takes place whether we pause before we seek or seek without pause. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7932

3 3

[PATCH 0/1] MR7868: combase: Find correct apartment in ClientRpcChannelBuffer_SendReceive().
by Dmitry Timoshkov (＠dmitry) 04 May '25

04 May '25

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/7868

3 5

[PATCH v3 0/1] MR7926: dsound/tests: Allocate right amount of memory in test_secondary8 (ASan).
by Alex Henrie (＠alexhenrie) 04 May '25

04 May '25

The wave format is passed to DirectSoundDevice_CreateSoundBuffer, which duplicates it including the 1 byte of extra data after the end of the struct. -- v3: dsound/tests: Allocate right amount of memory in test_secondary8 (ASan). https://gitlab.winehq.org/wine/wine/-/merge_requests/7926

3 3

[PATCH 0/1] MR7962: ntdll: Also relocate entry point for builtin modules.
by Yuxuan Shui (＠yshui) 03 May '25

03 May '25

Discovered while I was working on ASan support. ASan shadow memory might be placed where the main image is normally loaded, forcing it to relocate. `virtual_map_module` handles this correctly but `virtual_map_builtin_module` doesn't. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7962

2 1

[PATCH 0/1] MR7960: win32u: Fix potential use of uninitialized variables.
by Yuxuan Shui (＠yshui) 03 May '25

03 May '25

If `KeUserModeCallback` fails, `ret_ptr` and `ret_len` might be left uninitialized. Since the returned status isn't checked in `dispatch_win_proc_params`, it can access uninitialized memory. * * * One way this could actually happen is if on x86_64 `KeUserModeCallback` returned `STATUS_STACK_OVERFLOW`. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7960

2 1

[PATCH 0/5] MR7959: d2d1: Fix a crash in ID2D1DeviceContext if no target is set.
by Akihiro Sagawa (＠sgwaki) 03 May '25

03 May '25

Fixes a specific game's crash on startup. `d2d_device_context_draw` doesn't accept `D2D_TARGET_UNKNOWN` because `render_target->target.bitmap->rtv` isn't reliably set when calling `ID3D11DeviceContext1_OMSetRenderTargets`. Therefore, we check for that condition and return early. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7959

2 5

[PATCH v2 0/1] MR7906: vwin32.vxd: Add support for VxDCall() 0x0010 and 0x002a services
by Pali Rohár (＠pali) 03 May '25

03 May '25

VxDCall vwin32 service id 0x0010 provides int21 dispatch functionality and VxDCall vwin32 service id 0x002a provides int41 dispatch functionality. All of these vwin32 services together with existing service id 0x0029 (for int31/dpmi functionality) have same API, first VxDCall() argument is value for EAX register and second argument is value for ECX register. VxDCall vwin32 service id 0x0010 is used by applications in Andrew Schulman's book Unauthorized Windows 95. For example by CHGDIR for getting PSP. -- v2: vwin32.vxd: Add support for VxDCall() 0x0010 and 0x002a services https://gitlab.winehq.org/wine/wine/-/merge_requests/7906

3 5

[PATCH 0/3] MR7909: include: Fix IMAGE_OS2_HEADER structure
by Pali Rohár (＠pali) 03 May '25

03 May '25

This merge request contains fixes for the Windows New Executable structure IMAGE_OS2_HEADER defined in include file winnt.h and used by wine. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7909

5 12

Re: [PATCH v4 0/6] MR7336: winewayland: Clipboard support through wlr-data-control-unstable-v1
by Neal Gompa (ニール・ゴンパ) (＠Conan_Kudo) 03 May '25

03 May '25

Note that wlr-data-control is going to be somewhat aggressively replaced with ext-data-control, it would be better to switch over to that. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7336#note_102460

1 0

[PATCH 0/1] MR7950: Draft: cmd: Handle cntl-c events correctly
by Jeff Latimer (＠greyghoster) 02 May '25

02 May '25

Process cntl-c so that commands terminate and the prompt steps to a new line. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7950

3 3

Re: [PATCH v5 0/1] MR7956: gdi32: Ensure null termination in logfont_AtoW. - approved
by Alexandre Julliard (＠julliard) 02 May '25

02 May '25

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7956

1 0

Re: [PATCH v4 0/1] MR7947: ntdll: Make sure NT flag is not set before iretq in wine_syscall_dispatcher_return on x64. - approved
by Alexandre Julliard (＠julliard) 02 May '25

02 May '25

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7947

1 0

Re: [PATCH v2 0/1] MR7900: d2d1: Compile shaders on device creation instead of device context creation. - approved
by Alexandre Julliard (＠julliard) 02 May '25

02 May '25

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7900

1 0

Re: [PATCH v2 0/3] MR7889: ntoskrnl.exe/tests: Add tests for some Io functions. - approved
by Alexandre Julliard (＠julliard) 02 May '25

02 May '25

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7889

1 0

Re: [PATCH v8 0/1] MR7676: winegstreamer: Make sure WMSyncReader never reads in the background. - approved
by Alexandre Julliard (＠julliard) 02 May '25

02 May '25

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7676

1 0

Re: [PATCH v3 0/1] MR7824: winegstreamer: Handle the Stream Group Done event. - approved
by Alexandre Julliard (＠julliard) 02 May '25

02 May '25

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7824

1 0

Re: [PATCH v2 0/1] MR7936: netapi32: Fix service names in NetStatisticsGet(). - approved
by Alexandre Julliard (＠julliard) 02 May '25

02 May '25

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7936

1 0

Re: [PATCH v2 0/1] MR7954: msvcrt: Add truncf to the import library. - approved
by Alexandre Julliard (＠julliard) 02 May '25

02 May '25

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7954

1 0

Re: [PATCH v2 0/4] MR7955: secur32/tests: Fix NTLM tests on Windows 11. - approved
by Alexandre Julliard (＠julliard) 02 May '25

02 May '25

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7955

1 0

Re: [PATCH v2 0/1] MR7952: msv1_0: Drop the ntlm_auth check. - approved
by Alexandre Julliard (＠julliard) 02 May '25

02 May '25

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7952

1 0

Re: [PATCH v2 0/6] MR7953: win32u: Add a generic wgl(Set|Get)SwapInterval implementation. - approved
by Alexandre Julliard (＠julliard) 02 May '25

02 May '25

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7953

1 0

Re: [PATCH v5 0/4] MR7934: mshtml: Validate builtin host functions in IE9+ using prototype_id rather than tid where possible. - approved
by Alexandre Julliard (＠julliard) 02 May '25

02 May '25

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7934

1 0

[PATCH v4 0/1] MR7956: gdi32: Ensure null termination in logfont_AtoW.
by Alex Henrie (＠alexhenrie) 02 May '25

02 May '25

Fixes: 1d3bfdc3abdaaa45075f0ec04228b911ab5ab8cf -- v4: gdi32: Ensure null termination in logfont_AtoW. https://gitlab.winehq.org/wine/wine/-/merge_requests/7956

2 1

[PATCH v3 0/1] MR7956: gdi32: Ensure null termination in logfont_AtoW.
by Alex Henrie (＠alexhenrie) 02 May '25

02 May '25

Fixes: 1d3bfdc3abdaaa45075f0ec04228b911ab5ab8cf -- v3: gdi32: Ensure null termination in logfont_AtoW. https://gitlab.winehq.org/wine/wine/-/merge_requests/7956

2 1

[PATCH v2 0/1] MR7956: gdi32: Copy the null terminator in logfont_AtoW.
by Alex Henrie (＠alexhenrie) 02 May '25

02 May '25

Fixes: 1d3bfdc3abdaaa45075f0ec04228b911ab5ab8cf -- v2: gdi32: Ensure null termination in logfont_AtoW. https://gitlab.winehq.org/wine/wine/-/merge_requests/7956

2 2

[PATCH 0/1] MR7956: gdi32: Copy the null terminator in logfont_AtoW.
by Alex Henrie (＠alexhenrie) 02 May '25

02 May '25

Fixes: 1d3bfdc3abdaaa45075f0ec04228b911ab5ab8cf -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7956

4 4

[PATCH 0/1] MR7900: d2d1: Compile shaders on device creation instead of device context creation.
by Francisco Casas (＠fcasas) 02 May '25

02 May '25

Some applications generate many device contexts each render frame. Thus, compling these shaders each time this happens might make them laggy. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7900

4 4

[PATCH v8 0/4] MR7885: winebth.sys part 11: Support initiating pairing requests with remote devices.
by Vibhav Pant (＠vibhavp) 02 May '25

02 May '25

Add `IOCTL_WINEBTH_RADIO_START_AUTH`, which gets used to implement `BluetoothAuthenticateDeviceEx`. -- v8: bluetoothapis/tests: Add tests for BluetoothAuthenticateDeviceEx. bluetoothapis: Use a wizard GUI to respond to pairing requests if an authentication callback is not registered. bluetoothapis: Implement BluetoothAuthenticateDeviceEx. https://gitlab.winehq.org/wine/wine/-/merge_requests/7885

3 6

[PATCH v3 0/1] MR7947: ntdll: Make sure NT flag is not set before iretq in wine_syscall_dispatcher_return on x64.
by Paul Gofman (＠gofman) 02 May '25

02 May '25

-- v3: ntdll: Make sure NT flag is not set before iretq in wine_syscall_dispatcher_return on x64. https://gitlab.winehq.org/wine/wine/-/merge_requests/7947

2 2

[PATCH 0/3] MR7889: ntoskrnl.exe/tests: Test that calling some Io functions does not result in...
by Alexander Morozov (＠amorozov) 02 May '25

02 May '25

This is a set of tests to prove the correctness of a fix for bug 57588 which i am going to send in a separate PR. Also a small fix for getting DevicePropertyEnumeratorName is included. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7889

3 4

[PATCH v7 0/1] MR7676: winegstreamer: Make sure WMSyncReader never reads in the background.
by Yuxuan Shui (＠yshui) 02 May '25

02 May '25

WMSyncReader starts a background read thread that reads from the IStream passed to IWMSyncReader::OpenStream. This means it could use the IStream in the background even when no IWMSyncReader methods are being called. For well-behaved applications, this is probably OK. However, AQUARIUM (Steam 2515070) frees the IStream it passes to WMSyncReader _before_ it calls IWMSyncReader::Close, which stops the read thread. This causes the read thread to access freed memory. This is improper, but not unreasonable, as IWMSyncReader is supposed to be a synchronous interface, so one might assume when they weren't calling into IWMSyncReader methods, the IStream won't be used. This commit adds a `wg_parser_dont_read` function, which can be used to stop wg_parser from issuing read requests. This is used by IWMSyncReader to make sure read requests are only issued when IWMSyncReader methods are being called. -- v7: winegstreamer: Make sure WMSyncReader never reads in the background. https://gitlab.winehq.org/wine/wine/-/merge_requests/7676

3 3

[PATCH v2 0/1] MR7824: winegstreamer: Handle the Stream Group Done event.
by Brendan McGrath (＠redmcg) 02 May '25

02 May '25

This event indicates that there will be no more data. Handling it like an EOS fixes a dead lock that occurs when a stream completes. -- v2: winegstreamer: Handle the Stream Group Done event. https://gitlab.winehq.org/wine/wine/-/merge_requests/7824

3 4

[PATCH 0/1] MR7936: netapi32: Fix service names in NetStatisticsGet().
by Paul Gofman (＠gofman) 02 May '25

02 May '25

This fixes Defiant not being able to connect to game servers in game. That regressed because of the apparently accidental change of the service names in commit 1904227cc363e0fed0fc69d038a0902010f9331b. The game depends on at least NetStatisticsGet("LanmanWorkstation") to succeed ("LanmanServer" may fail on Windows as well). -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7936

3 2

[PATCH v2 0/1] MR7947: ntdll: Make sure NT flag is not set before iretq in wine_syscall_dispatcher_return on x64.
by Paul Gofman (＠gofman) 02 May '25

02 May '25

-- v2: ntdll: Make sure NT flag is not set before iretq in wine_syscall_dispatcher_return on x64. https://gitlab.winehq.org/wine/wine/-/merge_requests/7947

3 10

[PATCH 0/1] MR7957: gdi32: Fix termination in destination string in logfont_AtoW.
by Bernhard Übelacker (＠bernhardu) 02 May '25

02 May '25

Followup of 1d3bfdc3ab. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7957

2 3

Re: [PATCH v4 0/1] MR7925: gdi32: Limit source string length in logfont_AtoW (ASan).
by Rémi Bernon (＠rbernon) 02 May '25

02 May '25

On Fri May 2 16:52:15 2025 +0000, Alex Henrie wrote: > I apologize for the stupid mistake. !7956 will fix it. Literally two > minutes after I sent it, Bernhard sent an alternative fix in !7957 which > would also be fine. > I recognize that this happened primarily due to human error on my part. > Nevertheless, another part of the problem is that the 32-bit tests > always fail, and somehow this mistake did not cause the 64-bit tests to > fail. That means that I need to spend some time helping with the > intermittent test failures because they're making it too easy for me to > overlook test failures that actually matter. Until the tests can be > expected to pass, I will have to remember to read through the entire > list of failures whenever I send a patch. The test-linux-64 test suite only run a few tests that are otherwise skipped in a old/new wow64 environment like the one used for test-linux-32. It's maybe a bit confusing but it otherwise would use another runner from >30min and it wasn't deemed useful to have a full test coverage run on every config. The test-linux-32 sadly fails often, spuriously, although there have been up and downs I think it's getting better now and hopefully we'll get back to some occasional failures only. Nevertheless, Gitlab now shows a short summary of failing tests (in the MRs "Test summary:" section, which can be expanded for a detailed list of failures) and I think we should be able to quickly check MR failures, and compare with other MRs or the testbot pattern page, to decide whether they are likely related or not. Usually there's only a handful of spurious failures, with some well known returning failures, and a large number of/unusual failures should already still stand out, if we're paying attention. Fwiw I'm not blaming you specifically here, it happens quite often (and I can be blamed for a fair amount the last few months). I'm mostly making sure it doesn't go unnoticed and try to raise awareness. At least as long as things get caught and fixed quickly it's probably fine. Fixing spurious failures would be nice too but that's much more difficult than it seems. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7925#note_102379

1 0

Re: [PATCH v4 0/1] MR7925: gdi32: Limit source string length in logfont_AtoW (ASan).
by Alex Henrie (＠alexhenrie) 02 May '25

02 May '25

On Fri May 2 16:52:15 2025 +0000, Rémi Bernon wrote: > This broke comctl32:status dwrite:font (win32/wow64) gdi32:font > user32:sysparams usp10:usp10 tests. I apologize for the stupid mistake. !7956 will fix it. Literally two minutes after I sent it, Bernhard sent an alternative fix in !7957 which would also be fine. I recognize that this happened primarily due to human error on my part. Nevertheless, another part of the problem is that the 32-bit tests always fail, and somehow this mistake did not cause the 64-bit tests to fail. That means that I need to spend some time helping with the intermittent test failures because they're making it too easy for me to overlook test failures that actually matter. Until the tests can be expected to pass, I will have to remember to read through the entire list of failures whenever I send a patch. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7925#note_102376

1 0

[PATCH v3 0/2] MR7780: win32u: Avoid uneeded (and sometimes harmful) RedrawWindow() calls in expose_window_surface().
by Paul Gofman (＠gofman) 02 May '25

02 May '25

-- v3: win32u: Don't inflate rect in expose_window_surface(). win32u: Don't redraw window in expose_window_surface() if window has surface. https://gitlab.winehq.org/wine/wine/-/merge_requests/7780

3 7

[PATCH 0/1] MR7954: msvcrt: Add truncf to the import library.
by Stefan Dösinger (＠stefan) 02 May '25

02 May '25

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=58191 -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7954

4 3

[PATCH v4 0/4] MR7934: mshtml: Validate builtin host functions in IE9+ using prototype_id rather than tid where possible.
by Gabriel Ivăncescu (＠insn) 02 May '25

02 May '25

-- v4: mshtml: Remove unused struct mutation_observer_ctor. mshtml: Use designated initializers for the Location dispex data. mshtml: Validate builtin host functions in IE9+ using prototype_id rather mshtml: Store the object_id of the last object in the prototype chain that https://gitlab.winehq.org/wine/wine/-/merge_requests/7934

3 5

[PATCH 0/4] MR7955: secur32/tests: Fix NTLM tests on Windows 11.
by Piotr Caban (＠piotr) 02 May '25

02 May '25

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/7955

2 4

[PATCH 0/1] MR7947: ntdll: Make sure NT flag is not set before iretq in wine_syscall_dispatcher_return on x64.
by Paul Gofman (＠gofman) 02 May '25

02 May '25

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/7947

3 4

[PATCH 0/1] MR7952: msv1_0: Drop the ntlm_auth check.
by Hans Leidekker (＠hans) 02 May '25

02 May '25

This means that the diagnostic message is no longer shown when secur32 is loaded. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7952

3 7

[PATCH 0/6] MR7953: win32u: Add a generic wgl(Set|Get)SwapInterval implementation.
by Rémi Bernon (＠rbernon) 02 May '25

02 May '25

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/7953

2 6

Re: [PATCH v4 0/1] MR7925: gdi32: Limit source string length in logfont_AtoW (ASan).
by Rémi Bernon (＠rbernon) 02 May '25

02 May '25

This broke comctl32:status dwrite:font (win32/wow64) gdi32:font user32:sysparams usp10:usp10 tests. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7925#note_102334

1 0

[PATCH 0/1] MR7951: Draft: test to see clean output
by Jeff Latimer (＠greyghoster) 02 May '25

02 May '25

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/7951

2 1

Re: [PATCH 0/0] MR7949: Draft: cmd:Fix handling of Cntl-C - closed
by Jeff Latimer (＠greyghoster) 02 May '25

02 May '25

This merge request was closed by Jeff Latimer. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7949

1 0

Re: [PATCH 0/0] MR7948: cmd: Handle cntl-c events correctly - closed
by Jeff Latimer (＠greyghoster) 02 May '25

02 May '25

This merge request was closed by Jeff Latimer. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7948

1 0

Re: [PATCH v2 0/1] MR7940: dmsynth: Don't report an underrun when current equals write position - approved
by Alexandre Julliard (＠julliard) 01 May '25

01 May '25

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7940

1 0

Re: [PATCH v2 0/1] MR7944: po: update Polish translation - approved
by Alexandre Julliard (＠julliard) 01 May '25

01 May '25

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7944

1 0

[PATCH v5 0/2] MR283: Draft: ntdll: Filter EFlags from user-supplied CONTEXT on x86 and x64.
by Jinoh Kang (＠iamahuman) 01 May '25

01 May '25

-- v5: ntdll: Filter EFlags from user-supplied CONTEXT on x86 and x64. ntdll/tests: Test for setting x86 / x64 EFLAGS register in context. https://gitlab.winehq.org/wine/wine/-/merge_requests/283

2 3

[PATCH v7 0/4] MR7885: winebth.sys part 11: Support initiating pairing requests with remote devices.
by Vibhav Pant (＠vibhavp) 01 May '25

01 May '25

Add `IOCTL_WINEBTH_RADIO_START_AUTH`, which gets used to implement `BluetoothAuthenticateDeviceEx`. -- v7: bluetoothapis/tests: Add tests for BluetoothAuthenticateDeviceEx. bluetoothapis: Use a wizard GUI to respond to pairing requests if an authentication callback is not registered. bluetoothapis: Implement BluetoothAuthenticateDeviceEx. winebth.sys: Implement IOCTL_WINEBTH_RADIO_START_AUTH. https://gitlab.winehq.org/wine/wine/-/merge_requests/7885

2 6

[PATCH 0/1] MR7940: dmsynth: Don't report an underrun when current equals write position
by Michael Stefaniuc (＠mstefani) 01 May '25

01 May '25

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=57575 -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7940

2 3

[PATCH v3 0/3] MR7934: mshtml: Validate builtin host functions in IE9+ using prototype_id rather than tid where possible.
by Gabriel Ivăncescu (＠insn) 01 May '25

01 May '25

-- v3: mshtml: Use designated initializers for the Location dispex data. mshtml: Validate builtin host functions in IE9+ using prototype_id rather mshtml: Store the object_id of the last object in the prototype chain that https://gitlab.winehq.org/wine/wine/-/merge_requests/7934

3 5

[PATCH 0/1] MR7586: cmd: Handle cntl-c events correctly
by Jeff Latimer (＠greyghoster) 01 May '25

01 May '25

https://bugs.winehq.org/show_bug.cgi?id=27605 describes how cntl-c is not handled well in cmd.exe, this patch allows the cntl-c to be returned in the buffer so that it can processed. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7586

3 9

[PATCH 0/5] MR7945: Draft: shell32: Rework FO_COPY operation.
by Ziqing Hui (＠zhui) 01 May '25

01 May '25

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/7945

2 5

[PATCH 0/1] MR7944: po: update Polish translation
by Adam Markowski (＠AMark) 01 May '25

01 May '25

Small update. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7944

2 1

[PATCH 0/2] MR7942: windowscodecs/tests: Add a test for 24bpp TIFF with separate sample planes.
by Nikolay Sivov (＠nsivov) 30 Apr '25

30 Apr '25

Signed-off-by: Nikolay Sivov <nsivov(a)codeweavers.com> -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7942

2 2

Re: [PATCH v2 0/5] MR7933: win32u: Add procedure loading to generic OpenGL code. - approved
by Alexandre Julliard (＠julliard) 30 Apr '25

30 Apr '25

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7933

1 0

Re: [PATCH v2 0/1] MR7905: krnl386: Set carry flag for unimplemented DPMI 0800h call (Physical Address Mapping) - approved
by Alexandre Julliard (＠julliard) 30 Apr '25

30 Apr '25

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7905

1 0

Re: [PATCH v2 0/4] MR7822: wined3d: Move FFP extra states away from STATE_RENDER, part 3/4. - approved
by Alexandre Julliard (＠julliard) 30 Apr '25

30 Apr '25

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7822

1 0

Re: [PATCH v2 0/4] MR7939: ntdll: Implement ProcessBasePriority class in NtSetInformationProcess. - approved
by Alexandre Julliard (＠julliard) 30 Apr '25

30 Apr '25

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7939

1 0

Re: [PATCH v4 0/1] MR7925: gdi32: Limit source string length in logfont_AtoW (ASan). - approved
by Alexandre Julliard (＠julliard) 30 Apr '25

30 Apr '25

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7925

1 0

Re: [PATCH v3 0/5] MR7910: windowscodecs/converter: Add 24bppBGR -> 128bppRGBAFloat conversion path. - approved
by Alexandre Julliard (＠julliard) 30 Apr '25

30 Apr '25

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7910

1 0

Re: [PATCH v2 0/1] MR7927: windowscodecs: Also initialize FlipRotator.bpp field. - approved
by Alexandre Julliard (＠julliard) 30 Apr '25

30 Apr '25

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7927

1 0

[PATCH 0/1] MR7824: winegstreamer: Handle the Stream Group Done event.
by Brendan McGrath (＠redmcg) 30 Apr '25

30 Apr '25

This event indicates that there will be no more data. Handling it like an EOS fixes a dead lock that occurs when a stream completes. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7824

3 6

[PATCH v2 0/2] MR7934: mshtml: Validate builtin host functions in IE9+ using prototype_id rather than tid where possible.
by Gabriel Ivăncescu (＠insn) 30 Apr '25

30 Apr '25

-- v2: mshtml: Validate builtin host functions in IE9+ using prototype_id rather mshtml: Store the object_id of the last object in the prototype chain that https://gitlab.winehq.org/wine/wine/-/merge_requests/7934

3 4

[PATCH 0/4] MR7822: wined3d: Move FFP extra states away from STATE_RENDER, part 3/4.
by Elizabeth Figura (＠zfigura) 30 Apr '25

30 Apr '25

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/7822

3 5

Re: [PATCH v25 0/6] MR7650: Add support for AF_UNIX sockets (followup)
by Ralf Habacker (＠rhabacker) 30 Apr '25

30 Apr '25

Ralf Habacker (@rhabacker) commented about server/sock.c: > + { > + sock->addr.un.sun_family = WS_AF_UNIX; > + memcpy(sock->addr.un.sun_path, params->addr.sa_data, sizeof(sock->addr.un.sun_path)); > + sock->addr_len = sizeof(sock->addr.un); > + } > + else > + sock->addr_len = sockaddr_from_unix( &bind_addr, &sock->addr.addr, sizeof(sock->addr) ); > } > > update_addr_usage( sock, &bind_addr, v6only ); > > if (get_reply_max_size() >= sock->addr_len) > set_reply_data( &sock->addr, sock->addr_len ); > + > + if (sock->family == WS_AF_UNIX && *params->addr.sa_data) > + fchdir(server_dir_fd); here also -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7650#note_102242

1 0

Re: [PATCH v25 0/6] MR7650: Add support for AF_UNIX sockets (followup)
by Ralf Habacker (＠rhabacker) 30 Apr '25

30 Apr '25

Ralf Habacker (@rhabacker) commented about server/sock.c: > if (errno == EADDRINUSE && sock->reuseaddr) > errno = EACCES; > > - set_error( sock_get_ntstatus( errno ) ); > - return; > + /* Windows' AF_UNIX implementation has an edge case allowing for a socket to bind to > + * an empty path. Linux doesn't, so it throws EINVAL. We check for this situation > + * here and avoid early-exiting if it's the case. */ > + if (!(errno == EINVAL && sock->family == WS_AF_UNIX && !*params->addr.sa_data)) > + { > + set_error( sock_get_ntstatus( errno ) ); > + if (sock->family == WS_AF_UNIX && *params->addr.sa_data) > + fchdir(server_dir_fd); This should be changed. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7650#note_102241

1 0

Re: [PATCH v25 0/6] MR7650: Add support for AF_UNIX sockets (followup)
by Ralf Habacker (＠rhabacker) 30 Apr '25

30 Apr '25

Ralf Habacker (@rhabacker) commented about server/sock.c: > + if (!(unix_path = mem_alloc( unix_path_len + 1 ))) > + return; > + > + memcpy( unix_path, (char *)(&params->addr) + sizeof(struct WS_sockaddr_un), unix_path_len ); > + unix_path[unix_path_len] = '\0'; > + > + base_name = strrchr(unix_path, '/'); > + if (base_name) > + { > + if (base_name != unix_path) > + (++base_name)[-1] = '\0'; > + } > + else > + base_name = unix_path; > + > + if (chdir( unix_path ) == -1) chdir() is also used here. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7650#note_102240

1 0

Re: [PATCH v25 0/6] MR7650: Add support for AF_UNIX sockets (followup)
by Ralf Habacker (＠rhabacker) 30 Apr '25

30 Apr '25

Ralf Habacker (@rhabacker) commented about server/sock.c: > return; > } > > + if (sock->family == WS_AF_UNIX && *addr->sa_data) > + fchdir(server_dir_fd); Here the working directory is also changed, which needs to be reviewed. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7650#note_102239

1 0

Re: [PATCH v25 0/6] MR7650: Add support for AF_UNIX sockets (followup)
by Ralf Habacker (＠rhabacker) 30 Apr '25

30 Apr '25

Ralf Habacker (@rhabacker) commented about server/sock.c: > + if (!(unix_path = mem_alloc( unix_path_len + 1 ))) > + return; > + > + memcpy( unix_path, (char *)(params + 1) + params->addr_len, unix_path_len ); > + unix_path[unix_path_len] = '\0'; > + > + base_name = strrchr(unix_path, '/'); > + if (base_name) > + { > + if (base_name != unix_path) > + (++base_name)[-1] = '\0'; > + } > + else > + base_name = unix_path; > + > + if (chdir( unix_path ) == -1) At https://gitlab.winehq.org/wine/wine/-/merge_requests/7519 it is pointed out that changing the working directory may not be a good idea, so it should be checked whether this can be avoided. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7650#note_102237

1 0

[PATCH v3 0/11] MR7869: Thread priority boosts (part 1)
by Marc-Aurel Zent (＠mzent) 30 Apr '25

30 Apr '25

This implements setting `ThreadPriorityBoost`, `ProcessPriorityBoost`, `ProcessBasePriority` and getting `ThreadPriorityBoost`, `ProcessPriorityBoost` NT info classes and adds tests where appropriate. The actual boosting mechanism will be in part 2 to keep the size of this MR manageable. -- v3: kernel32/tests: Add tests for GetProcessPriorityBoost/SetProcessPriorityBoost. kernelbase: Implement SetProcessPriorityBoost. kernelbase: Implement GetProcessPriorityBoost. ntdll: Implement ProcessPriorityBoost class in NtSetInformationProcess. ntdll: Implement ProcessPriorityBoost class in NtQueryInformationProcess. ntdll: Implement ThreadPriorityBoost class in NtSetInformationThread. ntdll: Properly implement ThreadPriorityBoost class in NtQueryInformationThread. ntdll/tests: Add tests for setting process base priority. ntdll: Implement ProcessBasePriority class in NtSetInformationProcess. https://gitlab.winehq.org/wine/wine/-/merge_requests/7869

3 14

[PATCH 0/4] MR7939: ntdll: Implement ProcessBasePriority class in NtSetInformationProcess.
by Marc-Aurel Zent (＠mzent) 30 Apr '25

30 Apr '25

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/7939

2 4

[PATCH 0/1] MR7937: Draft: winewayland: Don't clip cursor coordinates to vscreen boundaries.
by Alexandros Frantzis (＠afrantzis) 30 Apr '25

30 Apr '25

Since the positions of win32 windows and their corresponding Wayland surfaces are not synchronized, there are cases where parts of a window are outside the vscreen boundaries, and thus inaccessible to input events, but still visible and accessible from a user (i.e., Wayland compositor) standpoint. Try to remedy this issue by instructing the Wine server to not clip the Wayland mouse event coordinates to vscreen boundaries. -- Relevant discussions: * https://gitlab.winehq.org/wine/wine/-/merge_requests/4014#note_47581 * https://gitlab.winehq.org/wine/wine/-/merge_requests/7919 @julliard @rbernon Do you think such an approach (or something along these lines) would have any future in upstream as (a possibly opt-in) workaround for the Wayland input issues? -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7937

3 2

[PATCH 0/1] MR7919: winewayland.drv: Move windows to the top-left of the screen
by Julian Orth (＠mahkoh) 30 Apr '25

30 Apr '25

When opening the Cheat Engine [1] settings window, the window is spawned at around 400x400, making the right and bottom sides of the window inaccessible due to clipping. This commit moves the window to 0x0 to ensure that all window contents on the monitor are accessible. [1]: https://github.com/cheat-engine/cheat-engine Signed-off-by: Julian Orth <ju.orth(a)gmail.com> -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7919

3 6

[PATCH v2 0/2] MR7780: win32u: Avoid uneeded (and sometimes harmful) RedrawWindow() calls in expose_window_surface().
by Paul Gofman (＠gofman) 30 Apr '25

30 Apr '25

-- v2: win32u: Only inflate dirty rect when dpi conversion is performed in expose_window_surface(). win32u: Don't redraw window in expose_window_surface() if window has surface. https://gitlab.winehq.org/wine/wine/-/merge_requests/7780

3 4

[PATCH v4 0/5] MR7848: server: Use events as a sync for several objects.
by Rémi Bernon (＠rbernon) 30 Apr '25

30 Apr '25

Instead of https://gitlab.winehq.org/wine/wine/-/merge_requests/7815, for https://gitlab.winehq.org/wine/wine/-/merge_requests/7226, this only split the sync ops to a separate vtable and let objects delegate theirs to a separate object. This starts using a event-like interface for most objects, leaving the decision regarding if/how to split sync themselves / integrate inproc syncs for later. -- v4: server: Use an event sync for fd objects. server: Introduce a new event sync object. server: Redirect fd-based objects sync to the fd. server: Add an operation to retrieve an object sync. server: Move object grab/release out of (add|remove)_queue. https://gitlab.winehq.org/wine/wine/-/merge_requests/7848

2 6

[PATCH v6 0/5] MR5068: win32u: Fix rendering of the rotated and scaled text.
by Dmitry Timoshkov (＠dmitry) 30 Apr '25

30 Apr '25

These patches make a test case attached to the bug https://bugs.winehq.org/show_bug.cgi?id=33190 work. -- v6: win32u: NtGdiExtTextOutW() should translate x,y from logical to device units at the last step. win32u: Fix device<->world width/height converters. win32u: Use slightly more readable names for DP/LP converters. win32u: Use correct helper for converting width to device units. gdi32/tests: Add some tests for rotated font metrics. https://gitlab.winehq.org/wine/wine/-/merge_requests/5068

4 12

[PATCH v27 0/1] MR7843: cmd: Implement tab completion for command line entry.
by Joe Souza (＠JoeS209) 30 Apr '25

30 Apr '25

Over the past several weeks I've been working on and off on this. I didn't track the hours but I'm sure that I've spent 80+ hours on the feature. I've tested and retested all known scenarios and it seems to be working as expected. -- v27: cmd: Implement tab completion for command line entry. https://gitlab.winehq.org/wine/wine/-/merge_requests/7843

2 2

[PATCH v3 0/1] MR7925: gdi32: Limit source string length in logfont_AtoW (ASan).
by Alex Henrie (＠alexhenrie) 30 Apr '25

30 Apr '25

test_logfont in dlls/gdi32/tests/font.c calls CreateFontIndirectA with a non-null-terminated font name and expects it to not crash. -- v3: gdi32: Limit source string length in logfont_AtoW (ASan). https://gitlab.winehq.org/wine/wine/-/merge_requests/7925

2 1

[PATCH v2 0/1] MR7925: gdi32: Limit source string length in logfont_AtoW (ASan).
by Alex Henrie (＠alexhenrie) 30 Apr '25

30 Apr '25

test_logfont in dlls/gdi32/tests/font.c calls CreateFontIndirectA with a non-null-terminated font name and expects it to not crash. -- v2: gdi32: Limit source string length in logfont_AtoW (ASan). https://gitlab.winehq.org/wine/wine/-/merge_requests/7925

3 3

[PATCH 0/1] MR7935: ntdll: use wow64 limit better than limit_2g if the application permits .
by JiangYi Chen (＠meshine) 30 Apr '25

30 Apr '25

Signed-off-by: chenjiangyi <chenjiangyi(a)uniontech.com> peb was limited in limit_2g ,but after user_space_wow_limit was assigned a value in init_peb function , wow64_params can be allocated in limit_4g if application perfers. @julliard -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7935

2 1

[PATCH 0/1] MR4635: ntdll: Avoid abort process when internal string printing function used for debugging.
by 江仪陈 (＠meshine) 30 Apr '25

30 Apr '25

Description: The printing function (non-Windows application call) used by Wine developers is unnecessary to abort process when the string is super long. For example, the developer prints a long commandline of wwmapp.exe by MESSAGE. As a result, the process cannot be started, and the conference function cannot be used. Signed-off-by: chenjiangyi <chenjiangyi(a)uniontech.com> Change-Id: If06f0309f9745777f89b07dff8d302cb34b2a90e -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4635

3 2

[PATCH v2 0/5] MR7910: windowscodecs/converter: Add 24bppBGR -> 128bppRGBAFloat conversion path.
by Nikolay Sivov (＠nsivov) 30 Apr '25

30 Apr '25

Signed-off-by: Nikolay Sivov <nsivov(a)codeweavers.com> -- v2: windowscodecs/converter: Add 96bppRGBFloat -> 32bppBGRA conversion path. windowscodecs/converter: Add 96bppRGBFloat -> 128bppRGBFloat conversion path. windowscodecs/converter: Add 128bppRGBAFloat -> 32bppBGRA conversion path. windowscodecs/converter: Add 32bppBGRA - > 128bppRGBAFloat conversion path. https://gitlab.winehq.org/wine/wine/-/merge_requests/7910

3 7

[PATCH 0/1] MR7927: windowscodecs: Also initialize FlipRotator.bpp field.
by Dmitry Timoshkov (＠dmitry) 30 Apr '25

30 Apr '25

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/7927

3 2

Re: [PATCH v4 0/2] MR7908: Fix macOS winetest timeout in kernel32:virtual - approved
by Alexandre Julliard (＠julliard) 29 Apr '25

29 Apr '25

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7908

1 0

Re: [PATCH v2 0/3] MR7922: Conhost improvements. - approved
by Alexandre Julliard (＠julliard) 29 Apr '25

29 Apr '25

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7922

1 0

Re: [PATCH v2 0/1] MR7930: comctl32: Track initial taskdialog layout on a per-dialog basis. - approved
by Alexandre Julliard (＠julliard) 29 Apr '25

29 Apr '25

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7930

1 0

Re: [PATCH v2 0/2] MR7896: comctl32: Implement MSAA events for progress bars. - approved
by Alexandre Julliard (＠julliard) 29 Apr '25

29 Apr '25

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7896

1 0

Re: [PATCH v2 0/1] MR7931: po: Update Lithuanian translation. - approved
by Alexandre Julliard (＠julliard) 29 Apr '25

29 Apr '25

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7931

1 0

[PATCH v2 0/1] MR7897: kernel32/tests: Skip FreeConsole test at Windows 7.
by Bernhard Übelacker (＠bernhardu) 29 Apr '25

29 Apr '25

Followup of 13c77bc9e6. [Test pattern page](https://test.winehq.org/data/patterns.html#kernel32:console) [Testbot run with this patch](https://testbot.winehq.org/JobDetails.pl?Key=158074) -- v2: kernel32/tests: Skip FreeConsole test at Windows 7. https://gitlab.winehq.org/wine/wine/-/merge_requests/7897

4 5

[PATCH 0/2] MR7934: mshtml: Validate builtin host functions in IE9+ using prototype_id rather than tid where possible.
by Gabriel Ivăncescu (＠insn) 29 Apr '25

29 Apr '25

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/7934

2 2

[PATCH 0/1] MR7905: krnl386: Set carry flag for unimplemented DPMI 0800h call (Physical Address Mapping)
by Pali Rohár (＠pali) 29 Apr '25

29 Apr '25

According to the DPMI specification, when DPMI function 0800h (Physical Address Mapping) fails then the carry flag has to be set. For example if the application request for physical memory mapping via the DPMI 0800h call it is required to set carry flag to indicate failure. Otherwise application would be treated as successful operation in which case in BX:CX registers is stored linear address of the mapped memory to which application can access. Obviously on successful path if the BX:CX registers are not set then application would try to access random memory and crashes. SysToolsLib, WinIO or libpci are just few examples of 32-bit Windows libraries which issue this DPMI call via the kernel32.dll VxDCall() function and are expecting either the carry flag on the failure or the valid mapped address in BX:CX registers on success. As the wine does not implement this DPMI function, always sets the carry flag. Windows NTVDM DPMI host does not implement the DPMI function 0800h too and also always sets the carry flag. Tested and verified with a very simple gcc/djgpp application on Windows NT. So this also change aligns the wine behavior with the Windows NT. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7905

3 2

[PATCH v3 0/4] MR7797: ntdll: Wait for all pending operations to be cancelled in NtCancelIoFile[Ex]().
by Matteo Bruni (＠Mystral) 29 Apr '25

29 Apr '25

This fixes Trials Fusion often crashing when disconnecting a controller while there are more still connected. -- v3: hidclass: Set Status for pending IRPs of removed devices to STATUS_DEVICE_NOT_CONNECTED. ntdll/tests: Add more NtCancelIoFile[Ex]() tests. ntdll: Wait for all pending operations to be cancelled in NtCancelIoFile[Ex](). https://gitlab.winehq.org/wine/wine/-/merge_requests/7797

3 10

[PATCH v3 0/9] MR7848: server: Use events as a sync for several objects.
by Rémi Bernon (＠rbernon) 29 Apr '25

29 Apr '25

Instead of https://gitlab.winehq.org/wine/wine/-/merge_requests/7815, for https://gitlab.winehq.org/wine/wine/-/merge_requests/7226, this only split the sync ops to a separate vtable and let objects delegate theirs to a separate object. This starts using a event-like interface for most objects, leaving the decision regarding if/how to split sync themselves / integrate inproc syncs for later. -- v3: server: Use an event as debug event sync. server: Use an event as file lock sync. server: Use an event as process startup info sync. server: Use an event as thread context sync. server: Use an event as thread apc sync. server: Use an event as fd sync. server: Redirect fd-based objects sync to the fd. server: Move object grab/release out of (add|remove)_queue. server: Split object sync related vtable. https://gitlab.winehq.org/wine/wine/-/merge_requests/7848

3 13

[PATCH 0/5] MR7933: win32u: Add procedure loading to generic OpenGL code.
by Rémi Bernon (＠rbernon) 29 Apr '25

29 Apr '25

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/7933

2 5

[PATCH 0/3] MR7922: Conhost improvements.
by eric pouech (＠epo) 29 Apr '25

29 Apr '25

This MR serves as prerequistes for two open (in progress) MR: https://gitlab.winehq.org/wine/wine/-/merge_requests/7586 - we don't properly handle ctrl-c in ReadConsole with control block + this revisits ctrl-break (or ctrl-break from unix console) to map it unconditionnaly of console mode (as native does) to a windows ctrl event + and transfer to windows layers the management of ctrl-c (for a unix console when ENABLE_PROCESSED_INPUT isn't set) https://gitlab.winehq.org/wine/wine/-/merge_requests/7843 - add ASC in win32 edit mode to completely clear the current editi buffer -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7922

3 4

Re: [PATCH v4 0/4] MR7853: msvcr100/tests: Link to msvcr100.
by Piotr Caban (＠piotr) 29 Apr '25

29 Apr '25

On Tue Apr 29 09:51:17 2025 +0000, Rémi Bernon wrote: > I see, is this what needs to be installed: > https://learn.microsoft.com/en-us/cpp/windows/latest-supported-vc-redist?vi… > ? Yes, you need to install 2012 version for msvcr110, 2013 for msvcr120. Things are worse if you need msvcr70 or 71 since it's no longer available from official sources. You can install msvcr71 by installing BZEditW32_1.6.5 (see winetricks for details). -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7853#note_102136

1 0

2025

2024

2023

2022

wine-gitlab