- wine-gitlab - winehq.org

Re: [PATCH v2 0/2] MR5335: shell32: Create nonexistent destination directories in FO_MOVE. - approved
by Zebediah Figura (＠zfigura) 17 Mar '24

17 Mar '24

This merge request was approved by Zebediah Figura. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5335

1 0

[PATCH 0/1] MR5336: d3dcompiler_47: Stub D3DCreateLinker.
by Vijay Kiran Kamuju (＠infyquest) 17 Mar '24

17 Mar '24

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=52622 -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5336

2 1

[PATCH 0/2] MR5335: shell32: Create nonexistent destination directories in FO_MOVE.
by Zebediah Figura (＠zfigura) 17 Mar '24

17 Mar '24

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/5335

3 2

[PATCH 0/1] MR1269: wined3d: Disable CSMT when running on a single core.
by Anton Baskanov (＠baskanov) 17 Mar '24

17 Mar '24

- Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=45893 - Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=47767 - Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=44546 -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1269

6 11

[PATCH 0/1] MR5334: msxml6/tests: Add some tests for MXWriter60.
by Nikolay Sivov (＠nsivov) 17 Mar '24

17 Mar '24

Signed-off-by: Nikolay Sivov <nsivov(a)codeweavers.com> -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5334

3 2

Re: [PATCH v4 0/1] MR1060: include: Remove interfaces already define in msxml6.idl
by Alistair Leslie-Hughes (＠alesliehughes) 16 Mar '24

16 Mar '24

On Sat Mar 16 23:31:12 2024 +0000, Nikolay Sivov wrote: > So, no bigger plan other than fixing up idls basically? I currently don't have one. Through wine-staging patches for FreeThreadedXMLHTTP60 interface rely on this change. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1060#note_65058

1 0

Re: [PATCH v4 0/1] MR1060: include: Remove interfaces already define in msxml6.idl
by Nikolay Sivov (＠nsivov) 16 Mar '24

16 Mar '24

On Sat Mar 16 23:31:12 2024 +0000, Alistair Leslie-Hughes wrote: > First brings the headers inline with the SDK. > Second allows you to build against the wine headers without getting a > link time GUID duplicates. So, no bigger plan other than fixing up idls basically? -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1060#note_65057

1 0

Re: [PATCH v4 0/1] MR1060: include: Remove interfaces already define in msxml6.idl
by Alistair Leslie-Hughes (＠alesliehughes) 16 Mar '24

16 Mar '24

First brings the headers inline with the SDK. Second allows you to build against the wine headers without getting a link time GUID duplicates. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1060#note_65056

1 0

Re: [PATCH v12 0/3] MR414: fltmgr.sys: Implement FltBuildDefaultSecurityDescriptor
by Zebediah Figura (＠zfigura) 16 Mar '24

16 Mar '24

Zebediah Figura (@zfigura) commented about dlls/ntoskrnl.exe/tests/driver.c: > + PSID group = NULL, owner = NULL; > + BOOLEAN isdefault, present; > + PACL acl = NULL; > + PACCESS_ALLOWED_ACE ace; > + SID_IDENTIFIER_AUTHORITY auth = { SECURITY_NULL_SID_AUTHORITY }; > + SID_IDENTIFIER_AUTHORITY authwine7 = { SECURITY_NT_AUTHORITY }; > + PSID sid1, sid2, sidwin7; > + BOOL ret; > + > + status = FltBuildDefaultSecurityDescriptor(&sd, STANDARD_RIGHTS_ALL); > + ok(status == STATUS_SUCCESS, "got %#lx\n", status); > + if (status != STATUS_SUCCESS) > + { > + win_skip("Skipping FltBuildDefaultSecurityDescriptor tests\n"); > + return; > + } Do we need this? -- https://gitlab.winehq.org/wine/wine/-/merge_requests/414#note_65053

1 0

Re: [PATCH v12 0/3] MR414: fltmgr.sys: Implement FltBuildDefaultSecurityDescriptor
by Zebediah Figura (＠zfigura) 16 Mar '24

16 Mar '24

Zebediah Figura (@zfigura) commented about dlls/ntoskrnl.exe/tests/driver.c: > + } > + ok(sd != NULL, "Failed to return descriptor\n"); > + > + status = RtlGetGroupSecurityDescriptor(sd, &group, &isdefault); > + ok(status == STATUS_SUCCESS, "got %#lx\n", status); > + ok(group == NULL, "group isn't NULL\n"); > + > + status = RtlGetOwnerSecurityDescriptor(sd, &owner, &isdefault); > + ok(status == STATUS_SUCCESS, "got %#lx\n", status); > + ok(owner == NULL, "owner isn't NULL\n"); > + > + status = RtlGetDaclSecurityDescriptor(sd, &present, &acl, &isdefault); > + ok(status == STATUS_SUCCESS, "got %#lx\n", status); > + ok(acl != NULL, "acl is NULL\n"); > + ok(acl->AceCount == 2, "got %d\n", acl->AceCount); > + Should we test "isdefault" here as well? -- https://gitlab.winehq.org/wine/wine/-/merge_requests/414#note_65054

1 0

Re: [PATCH v12 0/3] MR414: fltmgr.sys: Implement FltBuildDefaultSecurityDescriptor
by Zebediah Figura (＠zfigura) 16 Mar '24

16 Mar '24

Zebediah Figura (@zfigura) commented about dlls/ntoskrnl.exe/tests/driver.c: > + *RtlSubAuthoritySid(sidwin7, 1) = DOMAIN_ALIAS_RID_ADMINS; > + > + sid2 = ExAllocatePool(NonPagedPool, RtlLengthRequiredSid(1)); > + RtlInitializeSid(sid2, &auth, 1); > + *RtlSubAuthoritySid(sid2, 0) = SECURITY_LOCAL_SYSTEM_RID; > + > + /* SECURITY_BUILTIN_DOMAIN_RID */ > + status = RtlGetAce(acl, 0, (void**)&ace); > + ok(status == STATUS_SUCCESS, "got %#lx\n", status); > + > + ok(ace->Header.AceType == ACCESS_ALLOWED_ACE_TYPE, "got %#x\n", ace->Header.AceType); > + ok(ace->Header.AceFlags == 0, "got %#x\n", ace->Header.AceFlags); > + ok(ace->Mask == STANDARD_RIGHTS_ALL, "got %#lx\n", ace->Mask); > + > + ret = RtlEqualSid(sid1, (PSID)&ace->SidStart) || RtlEqualSid(sidwin7, (PSID)&ace->SidStart); > + ok(ret, "SID not equal\n"); Maybe it'd be a bit simpler to test the SID elements individually rather than constructing a SID and using RtlEqualSid()? -- https://gitlab.winehq.org/wine/wine/-/merge_requests/414#note_65055

1 0

Re: [PATCH v12 0/3] MR414: fltmgr.sys: Implement FltBuildDefaultSecurityDescriptor
by Zebediah Figura (＠zfigura) 16 Mar '24

16 Mar '24

Zebediah Figura (@zfigura) commented about dlls/fltmgr.sys/main.c: > + goto done; > + RtlInitializeSid(sid, &auth, 2); > + sid->SubAuthority[1] = DOMAIN_GROUP_RID_ADMINS; > + sid->SubAuthority[0] = SECURITY_BUILTIN_DOMAIN_RID; > + > + sid_len = RtlLengthRequiredSid(1); > + sid_system = ExAllocatePool(PagedPool, sid_len); > + if (!sid_system) > + goto done; > + RtlInitializeSid(sid_system, &auth, 1); > + sid_system->SubAuthority[0] = SECURITY_LOCAL_SYSTEM_RID; > + > + sid_len = SECURITY_DESCRIPTOR_MIN_LENGTH + sizeof(ACL) + > + sizeof(ACCESS_ALLOWED_ACE) + RtlLengthSid(sid) + > + sizeof(ACCESS_ALLOWED_ACE) + RtlLengthSid(sid_system); > + Maybe rename "sid_len" to "len" if you're going to use it for other things? -- https://gitlab.winehq.org/wine/wine/-/merge_requests/414#note_65052

1 0

Re: [PATCH v12 0/3] MR414: fltmgr.sys: Implement FltBuildDefaultSecurityDescriptor
by Zebediah Figura (＠zfigura) 16 Mar '24

16 Mar '24

Zebediah Figura (@zfigura) commented about dlls/fltmgr.sys/main.c: > > return func; > } > + > +NTSTATUS WINAPI FltBuildDefaultSecurityDescriptor(PSECURITY_DESCRIPTOR *descriptor, ACCESS_MASK access) > +{ > + PACL dacl; > + NTSTATUS ret = STATUS_INSUFFICIENT_RESOURCES; This initialization isn't doing anything. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/414#note_65051

1 0

Re: [PATCH v4 0/1] MR1060: include: Remove interfaces already define in msxml6.idl
by Nikolay Sivov (＠nsivov) 16 Mar '24

16 Mar '24

@alesliehughes could you remind me what this was going to fix? -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1060#note_65050

1 0

[PATCH 0/1] MR1228: wined3d: support direct3d shader model 1,2,3
by Fan WenJie (＠fanwenjie) 16 Mar '24

16 Mar '24

vkd3d_shader_compile_info::source_type can not hard write to VKD3D_SHADER_SOURCE_DXBC_TPF, it is decided by magic number of shader source. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1228

4 5

[PATCH 0/1] MR5332: user32/tests: Accept WM_ACTIVATE in TrackPopupMenu.
by Esme Povirk (＠madewokherd) 16 Mar '24

16 Mar '24

https://test.winehq.org/data/552cc456d1889ab3ee0dd5ead6c7520c34d030c0/w1121… -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5332

2 1

[PATCH v3 0/2] MR5247: user32/msgbox: Support WM_COPY Message
by Alistair Leslie-Hughes (＠alesliehughes) 16 Mar '24

16 Mar '24

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=17205 -- v3: user32/msgbox: Use a windows hook to trap Ctrl+C user32/msgbox: Support WM_COPY Message https://gitlab.winehq.org/wine/wine/-/merge_requests/5247

4 9

[PATCH v24 0/8] MR3103: server: Create and use a desktop shared mapping for GetCursorPos.
by Rémi Bernon (＠rbernon) 16 Mar '24

16 Mar '24

First part of Proton shared memory series. The full branch can be seen at https://gitlab.winehq.org/rbernon/wine/-/commits/mr/shared-memories. -- v24: win32u: Use the desktop shared data for GetCursorPos. server: Move the last cursor time to the desktop session object. server: Move the cursor position to the desktop session object. win32u: Open desktop shared objects from session mapping. server: Allocate shared session object for desktops. win32u: Open the global session shared mapping. include: Add ReadNoFence64 inline helpers. server: Create a global session shared mapping. https://gitlab.winehq.org/wine/wine/-/merge_requests/3103

3 29

[PATCH v2 0/8] MR5319: winemac.drv keyboard layout/dead key fixes
by Marc-Aurel Zent (＠mzent) 16 Mar '24

16 Mar '24

This is a series of commits tackling dead key state handling and scan code to vkey mapping improvements (especially for French and German keyboards). * https://gitlab.winehq.org/mzent/wine/-/commit/6c5c90b746cc341049eec216e3bb9…: Simplifies the logic a bit there and also correctly null-terminates dead keys in ToUnicodeEx * https://gitlab.winehq.org/mzent/wine/-/commit/a05e2fc5068a22cae94bc800b4972…: Windows does not do it and some applications misbehave with this, fully fixed later in https://gitlab.winehq.org/mzent/wine/-/commit/7cf1f6a00f17b0626126448f77a1c… * https://gitlab.winehq.org/mzent/wine/-/commit/4bd96932139a22f2c3b1311e44c43…: MSDN states single keys are always uppercased there. * https://gitlab.winehq.org/mzent/wine/-/commit/bac8e97d7e6a7494672d76f5fc586…: There is a bug in `CFStringCompare` with the flags used there currently, resulting in the comparison of the identical buffers "ß" and "ß" to be false. In any case `UCCompareText` behaves correctly and is much faster there. * https://gitlab.winehq.org/mzent/wine/-/commit/bac5f485a09fbddd39efb8f2c0d87…: I think this was an accidental mistake there, going through all modifiers first per symbol almost always results in the wrong match being made. The logic is adjusted there now to be similar to the other iterations involving `char_matches_string`. * https://gitlab.winehq.org/mzent/wine/-/commit/ffde55df4ae3f6d53198839c58356… https://gitlab.winehq.org/mzent/wine/-/commit/a453d0d4c89c59c3e1ba6c24d2d0f…: Adds additional symbol vkey mappings (now completely maps a German Macintosh and PC keyboard correctly). There are still some minor defects with the French layout (around the ú region), however changing the symbol mapping there will cause issues with other layouts I think, since the wrong match happens very early there in the priority in these cases. With this change at least the number row is now behaving correctly. Additionally the French Macintosh keyboard layout is further complicated by the "=" key being next to right shift, which is in conflict with pretty much any other keyboard layout. To fix this properly would require a partial rewrite of the heuristic being used or a new approach, but most likely more of a long term project. * https://gitlab.winehq.org/mzent/wine/-/commit/7cf1f6a00f17b0626126448f77a1c…: Gives dead keys friendly names in `GetKeyNameFriendlyText`, just like Windows does. I tried to be as exhaustive as possible, but if there are any missing the mapping can be easily extended. All in all the incorrect scan code to vkey mapping is usually not that tragic, since an application would need to be aware of the layout and have its own mapping of scan codes of each (FFXIV does this though). The French layout corrections are now "good enough" to behave correctly for all the hotbar slots being assigned there with these changes now though. -- v2: winemac.drv: Give dead keys a friendly name in GetKeyNameText. winemac.drv: Add additional French symbol vkeys. winemac.drv: Add additional German symbol vkeys. winemac.drv: Resolve symbol vkeys first without modifiers. winemac.drv: Use UCCompareText in char_matches_string. winemac.drv: Uppercase single keys in GetKeyNameText. winemac.drv: Do not append " dead" to dead keycodes in GetKeyNameText. winemac.drv: Handle length of dead keycodes in ToUnicodeEx correctly. https://gitlab.winehq.org/wine/wine/-/merge_requests/5319

3 12

[PATCH 0/1] MR5330: server: Check for DELETE access in NtMakeTemporaryObject().
by Jinoh Kang (＠iamahuman) 16 Mar '24

16 Mar '24

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/5330

3 2

[PATCH 0/4] MR5329: ddraw: Support multiple devices per ddraw object.
by Paul Gofman (＠gofman) 16 Mar '24

16 Mar '24

Fixes Sim City 3000 Building Architect. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5329

3 5

Re: [PATCH v2 0/1] MR5327: user32/tests: Add another missing message for TrackPopupMenu. - approved
by Alexandre Julliard (＠julliard) 15 Mar '24

15 Mar '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5327

1 0

Re: [PATCH v2 0/1] MR5316: server: Ignore some ICMP-originated socket errors for connectionless sockets. - approved
by Alexandre Julliard (＠julliard) 15 Mar '24

15 Mar '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5316

1 0

Re: [PATCH v2 0/1] MR5325: wshom/network: Implement UserDomain property. - approved
by Alexandre Julliard (＠julliard) 15 Mar '24

15 Mar '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5325

1 0

Re: [PATCH v3 0/2] MR5323: win32u: Key auto-repeat improvements. - approved
by Alexandre Julliard (＠julliard) 15 Mar '24

15 Mar '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5323

1 0

Re: [PATCH v2 0/4] MR5321: Minidump slowdowns (Part III) - approved
by Alexandre Julliard (＠julliard) 15 Mar '24

15 Mar '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5321

1 0

Re: [PATCH v4 0/5] MR5294: mfplat: Implement better VIDEOINFOHEADER2 support. - approved
by Alexandre Julliard (＠julliard) 15 Mar '24

15 Mar '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5294

1 0

Re: [PATCH v2 0/1] MR5320: ntdll/tests: Fix a test failure. - approved
by Alexandre Julliard (＠julliard) 15 Mar '24

15 Mar '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5320

1 0

Re: [PATCH v2 0/1] MR5315: dbghelp: Fix PDB processing using the FPO stream instead of FPOEXT - approved
by Alexandre Julliard (＠julliard) 15 Mar '24

15 Mar '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5315

1 0

Re: [PATCH v2 0/1] MR5258: d3d9/tests: Skip desktop window tests if device creation fails. - approved
by Alexandre Julliard (＠julliard) 15 Mar '24

15 Mar '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5258

1 0

Re: [PATCH v2 0/1] MR5298: wined3d: Do not check the input signature element count for sm4+ shaders in shader_spirv_compile_arguments_init(). - approved
by Alexandre Julliard (＠julliard) 15 Mar '24

15 Mar '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5298

1 0

Re: [PATCH v2 0/3] MR5317: win32u: Fix a possible condition that makes EnumDisplayMonitors() not reporting any monitors. - approved
by Alexandre Julliard (＠julliard) 15 Mar '24

15 Mar '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5317

1 0

Re: [PATCH v2 0/1] MR5305: ddraw: Release only valid texture parents on ddraw_texture_init failure. - approved
by Alexandre Julliard (＠julliard) 15 Mar '24

15 Mar '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5305

1 0

Re: [PATCH v3 0/4] MR5279: wineserver crash resistance against permanent object deletion, part 1: Implement NtMakePermanentObject. - approved
by Alexandre Julliard (＠julliard) 15 Mar '24

15 Mar '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5279

1 0

[PATCH 0/3] MR5281: Preserve topology id of the original topology in the resolved topology when calling IMFTopoLoader::Load
by Santino Mazza (＠tati1454) 15 Mar '24

15 Mar '24

This merge request is related to MR !4443 -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5281

4 8

[PATCH 0/1] MR5327: user32/tests: Add another missing message for TrackPopupMenu.
by Esme Povirk (＠madewokherd) 15 Mar '24

15 Mar '24

Missed this in https://gitlab.winehq.org/wine/wine/-/merge_requests/5270, there may be more but I can't see them yet in the logs. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5327

2 1

[PATCH 0/1] MR5316: server: Ignore some ICMP-originated socket errors for connectionless sockets.
by Paul Gofman (＠gofman) 15 Mar '24

15 Mar '24

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/5316

3 4

[PATCH 0/1] MR5326: urlmon: Add stub for 414 function.
by Vijay Kiran Kamuju (＠infyquest) 15 Mar '24

15 Mar '24

Urlmon related functions and ordinal information can be found on Geoff Chappell's Blog: https://www.geoffchappell.com/studies/windows/ie/urlmon/api/index.htm Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=53635 Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=52352 Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=48085 -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5326

3 2

[PATCH 0/1] MR5325: wshom/network: Implement UserDomain property.
by Nikolay Sivov (＠nsivov) 15 Mar '24

15 Mar '24

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=56434 Signed-off-by: Nikolay Sivov <nsivov(a)codeweavers.com> -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5325

2 1

[PATCH v2 0/2] MR5323: win32u: Key auto-repeat improvements.
by Alexandros Frantzis (＠afrantzis) 15 Mar '24

15 Mar '24

A couple of win32u auto-repeat related improvements: 1. Cancel auto-repeat only if the repeat key is released (not other keys). 2. Cancel previous key auto-repeat when starting a new one for a different window (see commit message for more info). I have kept the changes minimal, which can lead to a few extraneous `kill_system_timer` calls. To improve on this would require more extensive tracking/clearing of `thread_info->key_repeat_msg`. -- v2: win32u: Cancel previous key auto-repeat when starting a new one. https://gitlab.winehq.org/wine/wine/-/merge_requests/5323

3 3

[PATCH v3 0/1] MR5188: Draft: winemac.drv: Hide app's dock icon when it wouldn't have a taskbar item on Windows.
by Tim Clem (＠tclem) 15 Mar '24

15 Mar '24

This is a change from the default behavior in macdrv for as long as it's existed, as far as I can tell. Previously, gaining a dock icon was a one-way path. However, that doesn't jive with the way taskbar entries work on Windows; if an app has no windows, it doesn't appear in the taskbar. This patch attempts to remedy cases where an app winds up with superfluous dock icons for exe's that no longer have windows (looking at you, basically every launcher and Steam). The major concern I can see with this is that if an app closes all of its windows but does not exit, there will be no indication that it is still running. Two thoughts on that: 1. That *should* be an anomalous case, such as the app hanging on exit. 2. Effectively the same behavior would happen on Windows. I would love to hear any other thoughts about this change. I'm open (though I would not prefer it) to defaulting the registry key to false if that would alleviate any concerns. -- v3: winemac.drv: Hide app's dock icon when it wouldn't have a taskbar item on Windows. https://gitlab.winehq.org/wine/wine/-/merge_requests/5188

4 5

[PATCH v5 0/2] MR714: vkd3d-shader/dxil: Implement DX intrinsic BufferUpdateCounter.
by Conor McCarthy (＠cmccarthy) 15 Mar '24

15 Mar '24

With no compiler support, there's no easy way to verify shader runner support for d3d11 UAV counters works, so I've left it out for now. -- v5: vkd3d-shader/dxil: Implement DX intrinsic BufferUpdateCounter. tests/hlsl: Add UAV counter tests. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/714

4 5

[PATCH 0/5] MR5322: server: Clear queue QS_RAWINPUT if get_rawinput_buffer got everything.
by Rémi Bernon (＠rbernon) 15 Mar '24

15 Mar '24

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/5322

2 6

[PATCH 0/7] MR724: vkd3d-shader/hlsl: Improve SM1 support for non-float operations, part 4.
by Francisco Casas (＠fcasas) 15 Mar '24

15 Mar '24

SM1 support for LOGIC_NOT, LOGIC_OR, and LOGIC_AND. -- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/724

4 12

[PATCH 0/4] MR5321: Minidump slowdowns (Part III)
by eric pouech (＠epo) 15 Mar '24

15 Mar '24

This is the last part for handling the minidump slow downs: - it removes the integration of RUNTIME_INFO chunks for x86_64 - adds fallback mechanism to read this unwind info from winedbg side. Some remarks: - it looks a bit awkward that SymFunctionTableAccess reads PE information from PE image on dbghelp side, while the unwind information reading is read (in this MR) from debugger side - some testings with native show that: + unwind info (inside StackWalk calls) is read through the read memory handler (so delegated to debugger) + there's no fallback from the read memory handler - so this looks like the minimal things to do - however, there could be additional fallback in dbghelp (like in dbghelp internal read memory handler); didn't spend time on these as they would only be helpful for non live targets, using the default read memory handler. - fixed winedbg to reload properly minidumps. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5321

2 4

[PATCH 0/1] MR723: vkd3d-shader/spirv: Implement MAD in two operations if flagged as precise.
by Conor McCarthy (＠cmccarthy) 15 Mar '24

15 Mar '24

This would eliminate the todo for the precise mad() test in !718. Maybe we need test results on nvidia and intel to decide if we actually want this. -- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/723

3 3

[PATCH v3 0/5] MR5294: mfplat: Implement better VIDEOINFOHEADER2 support.
by Rémi Bernon (＠rbernon) 15 Mar '24

15 Mar '24

This is the first set of patches aimed at improving the functions to convert between media types and various representations. Not everything ended up being necessary for what I wanted to do (MFVIDEOFORMAT seems to be the only format able to carry aperture information after all) but the tests and implementation are now there and will still be useful to convert media types from/to AM_MEDIA_TYPE formats. -- v3: mfplat/mediatype: Implement MFInitAMMediaTypeFromMFMediaType for FORMAT_VideoInfo2. mfplat/tests: Add tests for MFInitMediaTypeFromVideoInfoHeader2. mfplat/mediatype: Implement MFInitMediaTypeFromVideoInfoHeader2. mfplat/mediatype: Implement implicit MFInitMediaTypeFromVideoInfoHeader subtype. mfplat/tests: Test each VIDEOINFOHEADER field conversion separately. https://gitlab.winehq.org/wine/wine/-/merge_requests/5294

4 7

[PATCH v4 0/2] MR711: vkd3d-shader/ir: Introduce a better CFG structurizer, part 6.
by Giovanni Mascellani (＠giomasce) 15 Mar '24

15 Mar '24

~~This applies on top of !704, the last two commits belong here.~~ Here we finally emit the structured program, replacing the older simple structurizer. The advantage of the new structurizer is that the CFG if statically described in the generated program, without having to trace the value of a variable. Upcoming MRs will make the CFG even simpler, easier to read and hopefully to optimize for downstream compilers. -- v4: vkd3d-shader/ir: Emit multilevel jumps in the structured program. vkd3d-shader/ir: Emit the reconstructed structured program. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/711

3 6

[PATCH 0/1] MR5320: ntdll/tests: Fix a test failure.
by Hans Leidekker (＠hans) 15 Mar '24

15 Mar '24

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/5320

2 1

[PATCH 0/8] MR5319: winemac.drv keyboard layout/dead key fixes
by Marc-Aurel Zent (＠mzent) 15 Mar '24

15 Mar '24

This is a series of commits tackling dead key state handling and scan code to vkey mapping improvements (especially for French and German keyboards). * https://gitlab.winehq.org/mzent/wine/-/commit/6c5c90b746cc341049eec216e3bb9…: Simplifies the logic a bit there and also correctly null-terminates dead keys in ToUnicodeEx * https://gitlab.winehq.org/mzent/wine/-/commit/a05e2fc5068a22cae94bc800b4972…: Windows does not do it and some applications misbehave with this, fully fixed later in https://gitlab.winehq.org/mzent/wine/-/commit/7cf1f6a00f17b0626126448f77a1c… * https://gitlab.winehq.org/mzent/wine/-/commit/4bd96932139a22f2c3b1311e44c43…: MSDN states single keys are always uppercased there. * https://gitlab.winehq.org/mzent/wine/-/commit/bac8e97d7e6a7494672d76f5fc586…: There is a bug in `CFStringCompare` with the flags used there currently, resulting in the comparison of the identical buffers "ß" and "ß" to be false. In any case `UCCompareText` behaves correctly and is much faster there. * https://gitlab.winehq.org/mzent/wine/-/commit/bac5f485a09fbddd39efb8f2c0d87…: I think this was an accidental mistake there, going through all modifiers first per symbol almost always results in the wrong match being made. The logic is adjusted there now to be similar to the other iterations involving `char_matches_string`. * https://gitlab.winehq.org/mzent/wine/-/commit/ffde55df4ae3f6d53198839c58356… https://gitlab.winehq.org/mzent/wine/-/commit/a453d0d4c89c59c3e1ba6c24d2d0f…: Adds additional symbol vkey mappings (now completely maps a German Macintosh and PC keyboard correctly). There are still some minor defects with the French layout (around the ú region), however changing the symbol mapping there will cause issues with other layouts I think, since the wrong match happens very early there in the priority in these cases. With this change at least the number row is now behaving correctly. Additionally the French Macintosh keyboard layout is further complicated by the "=" key being next to right shift, which is in conflict with pretty much any other keyboard layout. To fix this properly would require a partial rewrite of the heuristic being used or a new approach, but most likely more of a long term project. * https://gitlab.winehq.org/mzent/wine/-/commit/7cf1f6a00f17b0626126448f77a1c…: Gives dead keys friendly names in `GetKeyNameFriendlyText`, just like Windows does. I tried to be as exhaustive as possible, but if there are any missing the mapping can be easily extended. All in all the incorrect scan code to vkey mapping is usually not that tragic, since an application would need to be aware of the layout and have its own mapping of scan codes of each (FFXIV does this though). The French layout corrections are now "good enough" to behave correctly for all the hotbar slots being assigned there with these changes now though. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5319

2 8

[PATCH 0/1] MR5315: dbghelp: Fix PDB processing using the FPO stream instead of FPOEXT
by Kyrylo Babikov (＠dank_meme) 15 Mar '24

15 Mar '24

Since wine 9.3 (particularly [this commit](https://gitlab.winehq.org/wine/wine/-/commit/552bc893e17a0e046c2f59…), `pdb_process_internal` mistakenly sets `fpoext_stream` to the FPO stream (`sub_streams[PDB_SIDX_FPO]`) instead of the FPOEXT stream (`sub_streams[PDB_SIDX_FPOEXT]`), causing the PDB file to be improperly processed. This merge request fixes that oversight. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5315

4 3

[PATCH v8 0/7] MR631: Draft: vkd3d: Implement UpdateTileMappings().
by Conor McCarthy (＠cmccarthy) 15 Mar '24

15 Mar '24

-- v8: tests: Trace more info on buffer creation failure. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/631

2 7

Re: [PATCH v2 0/5] MR5294: mfplat: Implement better VIDEOINFOHEADER2 support.
by Rémi Bernon (＠rbernon) 15 Mar '24

15 Mar '24

On Fri Mar 15 07:55:52 2024 +0000, Rémi Bernon wrote: > changed this line in [version 2 of the diff](/wine/wine/-/merge_requests/5294/diffs?diff_id=105317&start_sha=bda0dbe0b9086716616731c86c81b550162e8811#f44c614b47a01be8d6d29ad07f7a5616e1ae60ec_26_26) Indeed, fixed. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5294#note_64866

1 0

[PATCH 0/1] MR5258: d3d9/tests: Skip desktop window tests if device creation fails.
by Robin Kertels (＠K0bin) 15 Mar '24

15 Mar '24

DXVK fails to create a device for the desktop window which causes the test to crash. Instead of crashing, it should just skip the remaining desktop window tests if device creation fails. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5258

4 8

[PATCH 0/1] MR5298: wined3d: Do not check the input signature element count for sm4+ shaders in shader_spirv_compile_arguments_init().
by Henri Verbeet (＠hverbeet) 15 Mar '24

15 Mar '24

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/5298

5 4

[PATCH 0/3] MR5317: win32u: Fix a possible condition that makes EnumDisplayMonitors() not reporting any monitors.
by Zhiyi Zhang (＠zhiyi) 15 Mar '24

15 Mar '24

When there are two monitors and they are mirrored, both of them are considered primary. When the first primary monitor happens to be a clone, EnumDisplayMonitors() ends up not reporting any monitors because should_enumerate_monitor() returns FALSE and we break out the loop to enumerate primary monitors after that. This is a regression from b59619d and my review comments. My indent was to break out of the loop after finding the *master* primary monitor, not cloned primary monitors, to avoid unnecessary iterations. However, the primary monitor count is small and it's cleaner this way so let's break when should_enumerate_monitor() returns TRUE. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5317

3 4

[PATCH 0/1] MR5305: ddraw: Release only valid texture parents on ddraw_texture_init failure.
by Andrew Nguyen (＠arethusa) 15 Mar '24

15 Mar '24

When ddraw_texture_init needs to clean up on failure, it will call the wined3d_texture_get_sub_resource_parent function on draw_texture in order to retrieve its parent for a IDirectDrawSurface release call. However, if draw_texture is NULL, then the function call will crash due to a null pointer dereference. Therefore, on failure cleanup, the release operation on the texture parent should only be performed if draw_texture is not NULL. This fixes a crash in the Virtual Insanity game demo. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5305

5 5

[PATCH v7 0/7] MR631: Draft: vkd3d: Implement UpdateTileMappings().
by Conor McCarthy (＠cmccarthy) 15 Mar '24

15 Mar '24

-- v7: tests: Trace more info on buffer creation failure. vkd3d: Support aliased tile binding if available. vkd3d: Implement ID3D12CommandQueue::UpdateTileMappings() for textures. vkd3d: Implement ID3D12CommandQueue::UpdateTileMappings() for buffers. vkd3d: Pre-bind sparse texture mip tails. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/631

2 7

[PATCH v3 0/5] MR718: vkd3d-shader/dxil: Implement miscellaneous arithmetic DX intrinsics.
by Conor McCarthy (＠cmccarthy) 15 Mar '24

15 Mar '24

-- v3: vkd3d-shader/dxil: Implement DX intrinsic Saturate. vkd3d-shader/dxil: Implement DX intrinsic FAbs. vkd3d-shader/dxil: Implement DX intrinsics FMa, FMad, IMad and UMad. vkd3d-shader/spirv: Use dst register data type in spirv_compiler_emit_imad(). tests/hlsl: Add tests for mad() and fma(). https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/718

2 5

[PATCH 0/5] MR722: Draft: vkd3d-shader/ir: Synthesize selection constructs from conditional jumps.
by Giovanni Mascellani (＠giomasce) 14 Mar '24

14 Mar '24

This applies on top of !711, the last three commits belong here. This MR and the following ones will introduce a number of optimization passes on the structured representation of the shader, with the goal of fixing the idiosyncrasies of the code generated by the new structurizer. The general pattern is that we want to recognize when the combination of loops and jumps can be rather written with selection constructs. Ideally that should bring to removing all the synthesized loop intervals, but that cannot be guaranteed in general. We still want to do remove all the loops we can, first to make the generated code easier to read and to recompile, and second because having fewer loops also means that more multilevel jumps become ordinary single level jumps, which do not require overhead to be represented in SPIR-V. -- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/722

2 5

Re: [PATCH v2 0/4] MR719: [2/3] vkd3d-shader/ir: Pass a struct vsir_program to vkd3d_shader_normalise(). - approved
by Alexandre Julliard (＠julliard) 14 Mar '24

14 Mar '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/719

1 0

Re: [PATCH v2 0/2] MR720: vkd3d-shader/glsl: Generate comments for unhandled instructions. - approved
by Alexandre Julliard (＠julliard) 14 Mar '24

14 Mar '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/720

1 0

Re: [PATCH v4 0/6] MR706: vkd3d-shader/hlsl: Improve SM1 support for non-float operations, part 3. - approved
by Alexandre Julliard (＠julliard) 14 Mar '24

14 Mar '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/706

1 0

Re: [PATCH v6 0/3] MR704: vkd3d-shader/ir: Introduce a better CFG structurizer, part 5. - approved
by Alexandre Julliard (＠julliard) 14 Mar '24

14 Mar '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/704

1 0

Re: [PATCH v5 0/5] MR681: vkd3d-shader/dxil: TGSM part 1. - approved
by Alexandre Julliard (＠julliard) 14 Mar '24

14 Mar '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/681

1 0

Re: [PATCH v4 0/9] MR5274: winevulkan: Consistently remove wrapper handles mapping after object destruction. - approved
by Alexandre Julliard (＠julliard) 14 Mar '24

14 Mar '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5274

1 0

Re: [PATCH v2 0/7] MR5261: ntdll: Only allocate debug info in critical sections with RTL_CRITICAL_SECTION_FLAG_FORCE_DEBUG_INFO. - approved
by Alexandre Julliard (＠julliard) 14 Mar '24

14 Mar '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5261

1 0

Re: [PATCH v2 0/1] MR5308: win32u: Support HiDPI for the non-client close button in WS_EX_TOOLWINDOW windows. - approved
by Alexandre Julliard (＠julliard) 14 Mar '24

14 Mar '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5308

1 0

Re: [PATCH v2 0/2] MR5312: d3dx10/tests: Remove todo's from now passing tests. - approved
by Alexandre Julliard (＠julliard) 14 Mar '24

14 Mar '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5312

1 0

Re: [PATCH v3 0/4] MR5310: wshom/network: Implement ComputerName() property. - approved
by Alexandre Julliard (＠julliard) 14 Mar '24

14 Mar '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5310

1 0

Re: [PATCH v2 0/2] MR5311: comctl32: Implement IImageList2::Initialize(). - approved
by Alexandre Julliard (＠julliard) 14 Mar '24

14 Mar '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5311

1 0

Re: [PATCH v2 0/1] MR5313: win32u: Fix incorrect ascii key name in get_config_key. - approved
by Alexandre Julliard (＠julliard) 14 Mar '24

14 Mar '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5313

1 0

Re: [PATCH v2 0/1] MR5309: advapi32: Add todo_wine to tests that are currently failing. - approved
by Alexandre Julliard (＠julliard) 14 Mar '24

14 Mar '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5309

1 0

Re: [PATCH v2 0/1] MR5219: mfreadwrite/reader: Handle MF_E_TRANSFORM_STREAM_CHANGE results. - approved
by Alexandre Julliard (＠julliard) 14 Mar '24

14 Mar '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5219

1 0

Re: [PATCH v2 0/4] MR5307: Minidump slow downs (Part II) - approved
by Alexandre Julliard (＠julliard) 14 Mar '24

14 Mar '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5307

1 0

Re: [PATCH v6 0/7] MR5262: win32u: Refactor monitor cache to only store the necessary information. - approved
by Alexandre Julliard (＠julliard) 14 Mar '24

14 Mar '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5262

1 0

Re: [PATCH v3 0/5] MR5302: wined3d: Use bindless textures for GLSL shaders if possible. - approved
by Alexandre Julliard (＠julliard) 14 Mar '24

14 Mar '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5302

1 0

Re: [PATCH v2 0/2] MR5303: oleaut32: Return success from GetSizeMax if not dirty. - approved
by Alexandre Julliard (＠julliard) 14 Mar '24

14 Mar '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5303

1 0

Re: [PATCH v2 0/1] MR5304: shell32: Try appending .exe when looking up an App Paths key. - approved
by Alexandre Julliard (＠julliard) 14 Mar '24

14 Mar '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5304

1 0

Re: [PATCH v2 0/1] MR5300: oleaut32: Bump version resource to Windows 10. - approved
by Alexandre Julliard (＠julliard) 14 Mar '24

14 Mar '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5300

1 0

[PATCH 0/4] MR719: [2/3] vkd3d-shader/ir: Pass a struct vsir_program to vkd3d_shader_normalise().
by Henri Verbeet (＠hverbeet) 14 Mar '24

14 Mar '24

This was originally intended to be part 2/2, but the final patch in the original series has some conflicts with other MRs. -- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/719

3 5

[PATCH 0/2] MR720: vkd3d-shader/glsl: Generate comments for unhandled instructions.
by Henri Verbeet (＠hverbeet) 14 Mar '24

14 Mar '24

-- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/720

3 3

[PATCH 0/5] MR5294: mfplat: Implement better VIDEOINFOHEADER2 support.
by Rémi Bernon (＠rbernon) 14 Mar '24

14 Mar '24

This is the first set of patches aimed at improving the functions to convert between media types and various representations. Not everything ended up being necessary for what I wanted to do (MFVIDEOFORMAT seems to be the only format able to carry aperture information after all) but the tests and implementation are now there and will still be useful to convert media types from/to AM_MEDIA_TYPE formats. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5294

4 7

[PATCH v3 0/9] MR5274: winevulkan: Consistently remove wrapper handles mapping after object destruction.
by Rémi Bernon (＠rbernon) 14 Mar '24

14 Mar '24

-- v3: winevulkan: Get rid of the wine_vk_instance_free helper. winevulkan: Add handle mappings on creation success only. winevulkan: Simplify wine_vk_instance_free helper. winevulkan: Get rid of the wine_vk_device_free helper. winevulkan: Use a single allocation for instance and physical devices. winevulkan: Rename wine_vk_physical_device_alloc parameters and variables. winevulkan: Pass VkDeviceQueueCreateInfo to wine_vk_device_init_queues. winevulkan: Use a single allocation for device and queues. winevulkan: Use an rb_tree and allocate entries for handle mappings. https://gitlab.winehq.org/wine/wine/-/merge_requests/5274

4 13

[PATCH 0/7] MR5261: ntdll: Only allocate debug info in critical sections with RTL_CRITICAL_SECTION_FLAG_FORCE_DEBUG_INFO.
by Paul Gofman (＠gofman) 14 Mar '24

14 Mar '24

See https://gitlab.winehq.org/wine/wine/-/merge_requests/5071 -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5261

4 10

[PATCH 0/2] MR5314: Draft: windows.ui: Add stub implementations of uiviewsettings and inputpanestatics
by Vijay Kiran Kamuju (＠infyquest) 14 Mar '24

14 Mar '24

Stub Implementations of UIViewSettings and InputPaneStatics. This will reduce the FIXME clutter of missing UIViewSettings class implementation in .NET applications esp: Paint .Net -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5314

3 3

[PATCH v2 0/4] MR5310: wshom/network: Implement ComputerName() property.
by Nikolay Sivov (＠nsivov) 14 Mar '24

14 Mar '24

-- v2: wshom/network: Check pointer argument in get_UserName(). wshom/network: Implement ComputerName() property. https://gitlab.winehq.org/wine/wine/-/merge_requests/5310

3 5

[PATCH 0/2] MR5312: d3dx10/tests: Remove todo's from now passing tests.
by Nikolay Sivov (＠nsivov) 14 Mar '24

14 Mar '24

Signed-off-by: Nikolay Sivov <nsivov(a)codeweavers.com> -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5312

3 3

[PATCH v3 0/6] MR706: vkd3d-shader/hlsl: Improve SM1 support for non-float operations, part 3.
by Francisco Casas (＠fcasas) 14 Mar '24

14 Mar '24

Mainly the implementation of SM1 comparison operators, defined in terms of CMP and SLT instructions, and the capacity to transform SLT->CMP for pixel shaders and CMP->SLT for vertex shaders. -- v3: vkd3d-shader/hlsl: Lower CMP instructions for vertex shaders. vkd3d-shader/hlsl: Use hlsl_fixme() on missing SM1 matrix writemask lowering. vkd3d-shader/hlsl: Lower SLT instructions for pixel shaders. tests: Test equality between tiny and between large numbers on ps_2_0. vkd3d-shader/hlsl: Implement SM1 comparison operators. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/706

3 8

Re: [PATCH v5 0/3] MR704: vkd3d-shader/ir: Introduce a better CFG structurizer, part 5. - approved
by Henri Verbeet (＠hverbeet) 14 Mar '24

14 Mar '24

This merge request was approved by Henri Verbeet. -- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/704

1 0

[PATCH v4 0/5] MR681: vkd3d-shader/dxil: TGSM part 1.
by Conor McCarthy (＠cmccarthy) 14 Mar '24

14 Mar '24

-- v4: vkd3d-shader/dxil: Implement DX instruction Barrier. vkd3d-shader/spirv: Emit a trace message if TGSM alignment is ignored. vkd3d-shader/dxil: Implement structured groupshared address space global variables. vkd3d-shader/dxil: Implement raw groupshared address space global variables. vkd3d-shader/spirv: Support zero-initialisation for workgroup memory. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/681

3 6

[PATCH v2 0/10] MR5274: winevulkan: Consistently remove wrapper handles mapping after object destruction.
by Rémi Bernon (＠rbernon) 14 Mar '24

14 Mar '24

-- v2: winevulkan: Get rid of the wine_vk_instance_free helper. winevulkan: Add handle mappings on creation success only. winevulkan: Simplify wine_vk_instance_free helper. winevulkan: Get rid of the wine_vk_device_free helper. winevulkan: Allocate all host command buffers at once. winevulkan: Use a single allocation for instance and physical devices. winevulkan: Rename wine_vk_physical_device_alloc parameters and variables. winevulkan: Pass VkDeviceQueueCreateInfo to wine_vk_device_init_queues. winevulkan: Use a single allocation for device and queues. winevulkan: Use an rb_tree and allocate entries for handle mappings. https://gitlab.winehq.org/wine/wine/-/merge_requests/5274

4 18

[PATCH v2 0/4] MR718: vkd3d-shader/dxil: Implement miscellaneous arithmetic DX intrinsics.
by Conor McCarthy (＠cmccarthy) 14 Mar '24

14 Mar '24

-- v2: vkd3d-shader/dxil: Implement DX intrinsic Saturate. vkd3d-shader/dxil: Implement DX intrinsic FAbs. vkd3d-shader/dxil: Implement DX intrinsics FMa, FMad, IMad and UMad. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/718

3 6

[PATCH 0/1] MR5313: win32u: Fix incorrect ascii key name in get_config_key.
by Rémi Bernon (＠rbernon) 14 Mar '24

14 Mar '24

Fixes 6b8b35f9507f61e435d0b4582e31584c9244fa70 which incorrectly replaced it with string literal, leading to the default setting being used all the time. Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=56435 -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5313

3 2

[PATCH 0/4] MR718: vkd3d-shader/dxil: Implement miscellaneous arithmetic DX intrinsics.
by Conor McCarthy (＠cmccarthy) 14 Mar '24

14 Mar '24

-- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/718

3 9

Re: [PATCH v5 0/3] MR704: vkd3d-shader/ir: Introduce a better CFG structurizer, part 5. - approved
by Conor McCarthy (＠cmccarthy) 14 Mar '24

14 Mar '24

This merge request was approved by Conor McCarthy. -- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/704

1 0

[PATCH 0/1] MR5297: evr/mixer: Respect input media type MF_MT_MINIMUM_DISPLAY_APERTURE.
by Rémi Bernon (＠rbernon) 14 Mar '24

14 Mar '24

When present, the aperture indicates the area of the sample's buffers to display. The frame size instead includes some undesired padding. This is the case when color planes are aligned, such as with YUV output from a decoder MFT. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5297

4 4

[PATCH 0/2] MR5311: comctl32: Implement IImageList2::Initialize().
by Dmitry Timoshkov (＠dmitry) 14 Mar '24

14 Mar '24

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/5311

4 5

[PATCH 0/1] MR5219: mfreadwrite/reader: Handle MF_E_TRANSFORM_STREAM_CHANGE results.
by Rémi Bernon (＠rbernon) 14 Mar '24

14 Mar '24

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/5219

4 6

[PATCH v3 0/6] MR717: vkd3d-shader/fx: Add initial support for writing fx_2_0 parameters.
by Nikolay Sivov (＠nsivov) 14 Mar '24

14 Mar '24

Signed-off-by: Nikolay Sivov <nsivov(a)codeweavers.com> -- v3: vkd3d-shader/fx: Fail effect writing on unsupported annotations. vkd3d-shader/fx: Remove newlines from fixme messages. vkd3d-shader/fx: Add initial support for writing fx_2_0 parameters. vkd3d-shader/fx: Populate global variables list during context initialization. vkd3d-shader/fx: Fix an instruction block leak. vkd3d-shader/fx: Use type writing helper only for fx_4+. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/717

2 7

2025

2024

2023

2022

wine-gitlab