- wine-gitlab - winehq.org

Re: [PATCH v4 0/4] MR7853: msvcr100/tests: Link to msvcr100.
by Rémi Bernon (＠rbernon) 29 Apr '25

29 Apr '25

On Tue Apr 29 09:47:17 2025 +0000, Piotr Caban wrote: > Prior to these commits the tests were also skipped, test output looked > like this: > ``` > msvcr100.c:258: Tests skipped: msvcr100.dll not installed (got 126) > 1e24:msvcr100: 0 tests executed (0 marked as todo, 0 as flaky, 0 > failures), 1 skipped. > msvcr100:msvcr100:1e24 done (0) in 0s 157B > ``` > msvcr100 (and many other versions) are not part of Windows install, it > needs to be installed later. I see, is this what needs to be installed: https://learn.microsoft.com/en-us/cpp/windows/latest-supported-vc-redist?vi… ? -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7853#note_102135

1 0

Re: [PATCH v4 0/4] MR7853: msvcr100/tests: Link to msvcr100.
by Piotr Caban (＠piotr) 29 Apr '25

29 Apr '25

On Tue Apr 29 09:47:17 2025 +0000, Rémi Bernon wrote: > Fwiw this and !7875 !7876 !7877 !7878 now cause many tests to be skipped > on windows: https://test.winehq.org/data/patterns.html#msvcr100:msvcr100 Prior to these commits the tests were also skipped, test output looked like this: ``` msvcr100.c:258: Tests skipped: msvcr100.dll not installed (got 126) 1e24:msvcr100: 0 tests executed (0 marked as todo, 0 as flaky, 0 failures), 1 skipped. msvcr100:msvcr100:1e24 done (0) in 0s 157B ``` msvcr100 (and many other versions) are not part of Windows install, it needs to be installed later. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7853#note_102134

1 0

Re: [PATCH v24 0/6] MR7650: Add support for AF_UNIX sockets (followup)
by Ralf Habacker (＠rhabacker) 29 Apr '25

29 Apr '25

@julliard: Anything left to do ? -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7650#note_102133

1 0

Re: [PATCH v4 0/4] MR7853: msvcr100/tests: Link to msvcr100.
by Rémi Bernon (＠rbernon) 29 Apr '25

29 Apr '25

Fwiw this and !7875 !7876 !7877 !7878 now cause many tests to be skipped on windows: https://test.winehq.org/data/patterns.html#msvcr100:msvcr100 -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7853#note_102128

1 0

[PATCH 0/1] MR7930: comctl32: Track initial taskdialog layout on a per-dialog basis.
by Tim Clem (＠tclem) 29 Apr '25

29 Apr '25

Rather than in a global static. Fixes the second and subsequent dialogs not being centered on-screen. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7930

3 2

[PATCH 0/2] MR7896: comctl32: Implement MSAA events for progress bars.
by Esme Povirk (＠madewokherd) 29 Apr '25

29 Apr '25

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/7896

3 3

[PATCH v25 0/1] MR7843: cmd: Implement tab completion for command line entry.
by Joe Souza (＠JoeS209) 29 Apr '25

29 Apr '25

Over the past several weeks I've been working on and off on this. I didn't track the hours but I'm sure that I've spent 80+ hours on the feature. I've tested and retested all known scenarios and it seems to be working as expected. -- v25: cmd: Implement tab completion for command line entry. https://gitlab.winehq.org/wine/wine/-/merge_requests/7843

2 1

[PATCH 0/1] MR7931: po: Update Lithuanian translation.
by Aurimas Fišeras (＠AurimasF) 28 Apr '25

28 Apr '25

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/7931

2 1

Re: [PATCH v2 0/1] MR7929: include: Fix typos in exclusiveto attributes. - approved
by Alexandre Julliard (＠julliard) 28 Apr '25

28 Apr '25

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7929

1 0

Re: [PATCH v3 0/2] MR7864: windows.system.profile.systemid: Implement ISystemIdentificationInfo::get_Id(). - approved
by Alexandre Julliard (＠julliard) 28 Apr '25

28 Apr '25

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7864

1 0

Re: [PATCH v2 0/1] MR7866: windows.devices.enumeration: Guard against WindowsDuplicateString() failure. - approved
by Alexandre Julliard (＠julliard) 28 Apr '25

28 Apr '25

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7866

1 0

Re: [PATCH v2 0/1] MR7865: windows.media.mediacontrol: Fix a memory leak. - approved
by Alexandre Julliard (＠julliard) 28 Apr '25

28 Apr '25

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7865

1 0

Re: [PATCH v3 0/1] MR7857: winewayland: Don't update constraints without wl_pointer. - approved
by Alexandre Julliard (＠julliard) 28 Apr '25

28 Apr '25

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7857

1 0

Re: [PATCH v2 0/1] MR7912: appwiz.cpl: Report addon download failures. - approved
by Alexandre Julliard (＠julliard) 28 Apr '25

28 Apr '25

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7912

1 0

Re: [PATCH v2 0/2] MR7924: windowscodecs/tiff: Remove unnecessary image data byte-swaping. - approved
by Alexandre Julliard (＠julliard) 28 Apr '25

28 Apr '25

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7924

1 0

Re: [PATCH v2 0/1] MR7917: windowscodecs/png: Fix byte-swapping mode usage in the encoder. - approved
by Alexandre Julliard (＠julliard) 28 Apr '25

28 Apr '25

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7917

1 0

Re: [PATCH v3 0/1] MR7921: comdlg32/colordlg: Fix color picker cursor painting. - approved
by Alexandre Julliard (＠julliard) 28 Apr '25

28 Apr '25

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7921

1 0

Re: [PATCH v2 0/1] MR7913: uiautomationcore: Fix BSTR buffer overrun (ASan). - approved
by Alexandre Julliard (＠julliard) 28 Apr '25

28 Apr '25

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7913

1 0

Re: [PATCH v2 0/1] MR7918: windows.ui/tests: Remove tests for exact color values. - approved
by Alexandre Julliard (＠julliard) 28 Apr '25

28 Apr '25

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7918

1 0

Re: [PATCH v2 0/2] MR7915: shell32: Fix use-after-free at FolderItemVerbs creation (ASan). - approved
by Alexandre Julliard (＠julliard) 28 Apr '25

28 Apr '25

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7915

1 0

Re: [PATCH v2 0/1] MR7914: gdiplus: Don't trace old values in GdipSetMatrixElements. - approved
by Alexandre Julliard (＠julliard) 28 Apr '25

28 Apr '25

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7914

1 0

Re: [PATCH v3 0/1] MR7888: wbemprox: Implement Win32_CacheMemory table. - approved
by Alexandre Julliard (＠julliard) 28 Apr '25

28 Apr '25

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7888

1 0

Re: [PATCH v2 0/2] MR7884: odbc32: Fix some NULL pointer issues - approved
by Alexandre Julliard (＠julliard) 28 Apr '25

28 Apr '25

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7884

1 0

Re: [PATCH v2 0/1] MR7911: odbc32: Fix replicating unixODBC data sources. - approved
by Alexandre Julliard (＠julliard) 28 Apr '25

28 Apr '25

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7911

1 0

Re: [PATCH v3 0/2] MR7895: Revert "kernel32/tests: Don't use _ReadWriteBarrier on ARM platforms." - approved
by Alexandre Julliard (＠julliard) 28 Apr '25

28 Apr '25

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7895

1 0

Re: [PATCH v5 0/4] MR6885: cmd: Use the console output codepage to read batch files. - approved
by Alexandre Julliard (＠julliard) 28 Apr '25

28 Apr '25

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6885

1 0

Re: [PATCH v2 0/4] MR7899: windowscodecs/tests: Remove A->W test data conversion. - approved
by Alexandre Julliard (＠julliard) 28 Apr '25

28 Apr '25

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7899

1 0

Re: [PATCH v3 0/1] MR7898: gdiplus: Limit clip region calculation to device rectangle. - approved
by Alexandre Julliard (＠julliard) 28 Apr '25

28 Apr '25

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7898

1 0

[PATCH v6 0/4] MR7885: winebth.sys part 11: Support initiating pairing requests with remote devices.
by Vibhav Pant (＠vibhavp) 28 Apr '25

28 Apr '25

Add `IOCTL_WINEBTH_RADIO_START_AUTH`, which gets used to implement `BluetoothAuthenticateDeviceEx`. -- v6: bluetoothapis/tests: Add tests for BluetoothAuthenticateDeviceEx. bluetoothapis: Use a wizard GUI to respond to pairing requests if an authentication callback is not registered. bluetoothapis: Implement BluetoothAuthenticateDeviceEx. winebth.sys: Implement IOCTL_WINEBTH_RADIO_START_AUTH. https://gitlab.winehq.org/wine/wine/-/merge_requests/7885

3 5

[PATCH v2 0/1] MR7926: dsound/tests: Allocate right amount of memory in test_secondary8 (ASan).
by Alex Henrie (＠alexhenrie) 28 Apr '25

28 Apr '25

The wave format is passed to DirectSoundDevice_CreateSoundBuffer, which duplicates it including the 1 byte of extra data after the end of the struct. -- v2: dsound/tests: Allocate right amount of memory in test_secondary8 (ASan). https://gitlab.winehq.org/wine/wine/-/merge_requests/7926

3 2

[PATCH v5 0/5] MR5068: win32u: Fix rendering of the rotated and scaled text.
by Dmitry Timoshkov (＠dmitry) 28 Apr '25

28 Apr '25

These patches make a test case attached to the bug https://bugs.winehq.org/show_bug.cgi?id=33190 work. -- v5: win32u: NtGdiExtTextOutW() should translate x,y from logical to device units at the last step. win32u: Fix device<->world width/height converters. gdi32/tests: Add some tests for rotated font metrics. win32u: Use slightly more readable names for DP/LP converters. win32u: Use correct helper for converting width to device units. https://gitlab.winehq.org/wine/wine/-/merge_requests/5068

3 6

Re: [PATCH v2 0/5] MR7928: coremessaging: Partially implement CreateDispatcherQueueController().
by Jinoh Kang (＠iamahuman) 28 Apr '25

28 Apr '25

cc/ @zhiyi who has dealt with coremessaging before -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7928#note_102039

1 0

[PATCH v2 0/4] MR7797: ntdll: Wait for all pending operations to be cancelled in NtCancelIoFile[Ex]().
by Matteo Bruni (＠Mystral) 28 Apr '25

28 Apr '25

This fixes Trials Fusion often crashing when disconnecting a controller while there are more still connected. -- v2: hidclass: Set Status for pending IRPs of removed devices to STATUS_DEVICE_NOT_CONNECTED. ntdll/tests: Add more NtCancelIoFile[Ex]() tests. ntdll: Wait for all pending operations to be cancelled in NtCancelIoFile[Ex](). ntdll: Factor out a cancel_io() function. https://gitlab.winehq.org/wine/wine/-/merge_requests/7797

4 7

[PATCH 0/1] MR7929: include: Fix typos in exclusiveto attributes.
by Hans Leidekker (＠hans) 28 Apr '25

28 Apr '25

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/7929

2 1

[PATCH v2 0/2] MR7864: windows.system.profile.systemid: Implement ISystemIdentificationInfo::get_Id().
by Mohamad Al-Jaf (＠maljaf) 28 Apr '25

28 Apr '25

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=55759 -- v2: windows.system.profile.systemid: Implement ISystemIdentificationInfo::get_Id(). https://gitlab.winehq.org/wine/wine/-/merge_requests/7864

3 4

[PATCH 0/5] MR7928: coremessaging: Partially implement CreateDispatcherQueueController().
by Mohamad Al-Jaf (＠maljaf) 28 Apr '25

28 Apr '25

Needed by Paint.NET installer. Fortunately, it doesn't need a full implementation. **Tests** `0x80000005` is defined as `E_POINTER` in the Windows SDK wrapped with `#if defined(_WIN32) && !defined(_MAC)` In my Windows 10 22H2 VM the tests are always consistent and the refs for `IDispatcherQueue_Release` and `IDispatcherQueueController_Release` are 1 and 0, respectively. But the testbot VMs are flaky, specifically when creating a dispatcher queue on a dedicated thread. However, when checking the box `Report successful tests (WINETEST_REPORT_SUCCESS)` it seems to succeed more reliably: - https://testbot.winehq.org/JobDetails.pl?Key=158092 - https://testbot.winehq.org/JobDetails.pl?Key=158096 In the last testbot attempt, `IAsyncInfo_get_Status` failed and returned `Started`: - https://testbot.winehq.org/JobDetails.pl?Key=158098&f307=exe64.report#k307 Adding a `broken` tag to the ref tests or even removing them is an option, but I'm not sure what to do about the failing `IAsyncInfo_get_Status` test. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7928

2 5

[PATCH 0/2] MR7864: windows.system.profile.systemid: Implement ISystemIdentificationInfo::get_Id().
by Mohamad Al-Jaf (＠maljaf) 28 Apr '25

28 Apr '25

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=55759 -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7864

4 6

[PATCH 0/1] MR7866: windows.devices.enumeration: Guard against WindowsDuplicateString() failure.
by Mohamad Al-Jaf (＠maljaf) 28 Apr '25

28 Apr '25

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/7866

3 2

[PATCH 0/1] MR7865: windows.media.mediacontrol: Fix a memory leak.
by Mohamad Al-Jaf (＠maljaf) 28 Apr '25

28 Apr '25

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/7865

3 2

[PATCH v23 0/6] MR7650: Add support for AF_UNIX sockets (followup)
by Ralf Habacker (＠rhabacker) 28 Apr '25

28 Apr '25

Follow-up of !2786, which appears to have been abandoned. -- v23: ws2_32/tests: Add test for AF_UNIX sockets server: Fix getsockname() and accept() on AF_UNIX sockets. server: Introduce error when attempting to create a SOCK_DGRAM AF_UNIX socket. server: Allow for deletion of socket files. ws2_32: Add support for AF_UNIX sockets. ws2_32: Add afunix.h header. https://gitlab.winehq.org/wine/wine/-/merge_requests/7650

2 6

[PATCH v2 0/1] MR7857: winewayland: Don't update constraints without wl_pointer.
by Attila Fidan (＠atticf) 28 Apr '25

28 Apr '25

If ClipCursor is called while the seat doesn't have a pointer and the call qualifies for locking the pointer, it would have tried to lock a null wl_pointer. For example, I'm launching a fullscreen application (which causes ClipCursor calls on startup) in a headless compositor before I launch my virtual keyboard/pointer client. While the pointer is deinitialized and there cannot be a focused hwnd, the cursor wl_surface will not be set, making it qualify for pointer locking. -- v2: winewayland: Require wl_pointer for pointer constraints. https://gitlab.winehq.org/wine/wine/-/merge_requests/7857

3 3

[PATCH 0/2] MR7924: windowscodecs/tiff: Remove unnecessary image data byte-swaping.
by Nikolay Sivov (＠nsivov) 28 Apr '25

28 Apr '25

Signed-off-by: Nikolay Sivov <nsivov(a)codeweavers.com> -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7924

4 4

[PATCH 0/1] MR7926: dsound/tests: Allocate right amount of memory in test_secondary8 (ASan).
by Alex Henrie (＠alexhenrie) 28 Apr '25

28 Apr '25

The wave format is passed to DirectSoundDevice_CreateSoundBuffer, which duplicates it including the 1 byte of extra data after the end of the struct. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7926

2 1

[PATCH 0/1] MR7917: windowscodecs/png: Fix byte-swapping mode usage in the encoder.
by Nikolay Sivov (＠nsivov) 28 Apr '25

28 Apr '25

The png_set_swap() explicitly checks for 16 bit depth, and bit_depth field is set by png_write_info(). -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7917

3 2

[PATCH 0/5] MR7910: windowscodecs/converter: Add 24bppBGR -> 128bppRGBAFloat conversion path.
by Nikolay Sivov (＠nsivov) 28 Apr '25

28 Apr '25

Signed-off-by: Nikolay Sivov <nsivov(a)codeweavers.com> -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7910

3 6

[PATCH 0/1] MR7923: shell32: Change type of KNOWNFOLDERID FOLDERID_UserProgramFiles from...
by Louis Lenders (＠xe) 27 Apr '25

27 Apr '25

shell32: Change type of KNOWNFOLDERID FOLDERID_UserProgramFiles from CSIDL_Type_Disallowed to CSIDL_Type_User. Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=58169 -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7923

2 1

[PATCH 0/1] MR7916: kernel32: Fixed MulDiv's inconsistencies with Windows.
by Shavit Yosef (＠shavitush) 27 Apr '25

27 Apr '25

`MulDiv` doesn't match the correct Windows behavior for the function, which actually differs in some edge cases for 32-bit and 64-bit. Test case: ```c MulDiv(1, 0x80000000, 0x80000000); // WINE - both 32-bit and 64-bit: 0 // Windows (32-bit/kernel32.dll): 2 // Windows (64-bit/kernelbase.dll): -1 ``` On Windows 32-bit, this would return 2. On 64-bit, it'd return -1. However, on WINE, this call would return 0 for both 32-bit and 64-bit. This discrepancy was previously abused by threat actors to detect if the application runs under WINE. --- On Windows, `MulDiv` has a different implementation for 32-bit (from `kernel32.dll`) and 64-bit (leveraged to `kernelbase.dll` from `kernel32.dll`). After adjusting the 64-bit code to be an exact replica of the original code from `kernelbase.dll`, it'd still return the incorrect value due to Microsoft's code having undefined behavior with negation. It could be avoided with `-O0` but I opted into rewriting it with the undefined behavior to be, well.. defined. To clarify, the original code from Microsoft has a bug (logically, at least). But WINE is supposed to have matching behavior so we can run Windows programs as intended. The 32-bit version of `MulDiv` in Windows has a more complicated bug; I've documented it in the code. --- This is my first contribution to WINE - I cannot find any `CONTRIBUTING.md` or similar file with guidelines so I did my best to follow the convention of other merge requests. I've added unit testing for `MulDiv` to ensure there won't be a regression in the future. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7916

4 8

[PATCH v17 0/3] MR7542: ws2_32: Implement WSALookupService for Bluetooth device discovery.
by Vibhav Pant (＠vibhavp) 27 Apr '25

27 Apr '25

This MR adds an initial implementation of the winsock `WSALookupsService*` methods for performing Bluetooth device discovery (`LUP_CONTAINERS`). -- v17: ws2_32: Implement WSALookupServiceNext for Bluetooth device discovery. ws2_32: Implement WSALookupServiceBegin for Bluetooth device discovery. https://gitlab.winehq.org/wine/wine/-/merge_requests/7542

2 3

[PATCH v2 0/1] MR7921: comdlg32/colordlg: Fix color picker cursor painting.
by Nikolay Sivov (＠nsivov) 27 Apr '25

27 Apr '25

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=56107 Signed-off-by: Nikolay Sivov <nsivov(a)codeweavers.com> -- v2: comdlg32/colordlg: Fix color picker cursor painting. https://gitlab.winehq.org/wine/wine/-/merge_requests/7921

2 1

[PATCH v16 0/3] MR7542: ws2_32: Implement WSALookupService for Bluetooth device discovery.
by Vibhav Pant (＠vibhavp) 27 Apr '25

27 Apr '25

This MR adds an initial implementation of the winsock `WSALookupsService*` methods for performing Bluetooth device discovery (`LUP_CONTAINERS`). -- v16: ws2_32: Implement WSALookupServiceNext for Bluetooth device discovery. ws2_32: Implement WSALookupServiceBegin for Bluetooth device discovery. ws2_32/tests: Add tests for the Bluetooth namespace (NS_BTH) in WSALookupServiceBegin/Next. https://gitlab.winehq.org/wine/wine/-/merge_requests/7542

2 4

[PATCH 0/1] MR7921: comdlg32/colordlg: Fix color picker cursor painting.
by Nikolay Sivov (＠nsivov) 27 Apr '25

27 Apr '25

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=56107 Signed-off-by: Nikolay Sivov <nsivov(a)codeweavers.com> -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7921

2 1

[PATCH 0/1] MR7913: uiautomationcore: Fix BSTR buffer overrun (ASan).
by Nikolay Sivov (＠nsivov) 27 Apr '25

27 Apr '25

Length argument to SysAllocStringLen() should not exceed the length of the string argument. Signed-off-by: Nikolay Sivov <nsivov(a)codeweavers.com> -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7913

3 2

[PATCH v5 0/4] MR7885: winebth.sys part 11: Support initiating pairing requests with remote devices.
by Vibhav Pant (＠vibhavp) 27 Apr '25

27 Apr '25

Add `IOCTL_WINEBTH_RADIO_START_AUTH`, which gets used to implement `BluetoothAuthenticateDeviceEx`. -- v5: bluetoothapis/tests: Add tests for BluetoothAuthenticateDeviceEx. bluetoothapis: Use a wizard GUI to respond to pairing requests if an authentication callback is not registered. bluetoothapis: Implement BluetoothAuthenticateDeviceEx. winebth.sys: Implement IOCTL_WINEBTH_RADIO_START_AUTH. https://gitlab.winehq.org/wine/wine/-/merge_requests/7885

2 4

[PATCH v4 0/4] MR7885: winebth.sys part 11: Support initiating pairing requests with remote devices.
by Vibhav Pant (＠vibhavp) 27 Apr '25

27 Apr '25

Add `IOCTL_WINEBTH_RADIO_START_AUTH`, which gets used to implement `BluetoothAuthenticateDeviceEx`. -- v4: bluetoothapis/tests: Add tests for BluetoothAuthenticateDeviceEx. https://gitlab.winehq.org/wine/wine/-/merge_requests/7885

2 5

[PATCH 0/1] MR7664: ntdll: Add copies of two XDG env vars to the environment, and use those in...
by Louis Lenders (＠xe) 27 Apr '25

27 Apr '25

ntdll: Add copies of two XDG env vars to the environment, and use those in winemenubuilder and shell32. To solve https://bugs.winehq.org/show_bug.cgi?id=49987 and https://bugs.winehq.org/show_bug.cgi?id=58023 we have to remove these two XDG variables from the environment. This is a proposal that adds copies with a different name and after this they can be removed. If this is not the right way to go I guess I will hear something? -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7664

2 3

[PATCH v2 0/1] MR7652: ntdll: Treat XDG_DATA_DIRS as special env variable.
by Louis Lenders (＠xe) 27 Apr '25

27 Apr '25

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=49987 GTK apps seem to use this to find path to schemas, like Meld: https://download.gnome.org/binaries/win32/meld/3.22/Meld-3.22.2-mingw.msi which doesn't start at all without this patch. More info in https://bugs.winehq.org/show_bug.cgi?id=49987. -- v2: ntdll: Treat XDG_DATA_DIRS as special env variable. https://gitlab.winehq.org/wine/wine/-/merge_requests/7652

3 6

[PATCH 0/1] MR7918: windows.ui/tests: Remove tests for exact color values.
by Nikolay Sivov (＠nsivov) 26 Apr '25

26 Apr '25

The tests are failing on Windows 11. Signed-off-by: Nikolay Sivov <nsivov(a)codeweavers.com> -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7918

2 1

[PATCH 0/1] MR7906: vwin32.vxd: Add support for VxDCall() 0x0010 and 0x002a services
by Pali Rohár (＠pali) 26 Apr '25

26 Apr '25

VxDCall service id 0x0010 provides int24 dispatch functionality and VxDCall service id 0x002a provides int41 dispatch functionality. All of these services together with existing service id 0x0029 (for int31/dpmi functionality) have same API, first VxDCall() argument is value for EAX register and second argument is value for ECX register. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7906

3 2

[PATCH 0/2] MR7915: shell32: Fix use-after-free at FolderItemVerbs creation (ASan).
by Nikolay Sivov (＠nsivov) 26 Apr '25

26 Apr '25

Signed-off-by: Nikolay Sivov <nsivov(a)codeweavers.com> -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7915

2 2

[PATCH 0/1] MR7914: gdiplus: Don't trace old values in GdipSetMatrixElements.
by Esme Povirk (＠madewokherd) 26 Apr '25

26 Apr '25

These are about to be overwritten, so they're not really meaningful at all. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7914

2 1

Re: [PATCH v24 0/1] MR7843: cmd: Implement tab completion for command line entry.
by Joe Souza (＠JoeS209) 26 Apr '25

26 Apr '25

On Sat Apr 26 17:30:57 2025 +0000, Joe Souza wrote: > I wasn't aware of WCMD_parameter. That is a good suggestion if it works > for what's needed here. FindFirstFileEx is an optimization for remote/network file systems, such that a round trip across the network is not performed for unwanted directory entries. Since Wine seems to support only file systems that are mounted by the host operating system and does not appear to have any direct knowledge of remote-mounted file systems, I can skip using the Ex function here. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7843#note_101956

1 0

Re: [PATCH v24 0/1] MR7843: cmd: Implement tab completion for command line entry.
by Joe Souza (＠JoeS209) 26 Apr '25

26 Apr '25

On Sat Apr 26 17:30:01 2025 +0000, Joe Souza wrote: > In the latest changes I have already split out much code from > WCMD_ReadConsole into subfunctions. You're saying it's still too long? > I suppose that I could split out the code for the individual case > statements into separate handler functions, but the code to handle Tab > is the bulk of that function. I wasn't aware of WCMD_parameter. That is a good suggestion if it works for what's needed here. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7843#note_101955

1 0

Re: [PATCH v24 0/1] MR7843: cmd: Implement tab completion for command line entry.
by Joe Souza (＠JoeS209) 26 Apr '25

26 Apr '25

On Sat Apr 26 15:12:31 2025 +0000, eric pouech wrote: > thanks > a couple of high level comments: > * I don't think having a separate source file just for \~400 LoC is > worth it > * WCMD_ReadConsole is way too big as a function and need to be split in > smaller pieces. > * you should also be using the command line parsing functions instead of > rewriting them (eg WCMD_parameter to loop against the various parameters) > from quick testing: > * when looping around files sometimes filename is inserted in quotes, > while it shouldn't. Native seems to insert quotes only when filename > contains specific characters (spaces...), but to also remove them if > next file doesn't contain any... > * using "cd c:\\Program Files"\<tab\>\<backspace\>\\\<tab\> doesn't > behave as native... native circles in the directory content, current MR > only adds a double quote > * got a crash when playing with MR (perhaps one of the buffer overflow > stated above, perhaps not) > * when the width of the console is smaller than the full line input (eg > spread at least on two lines), circling gives some strange result > (cursor and display when from bottom of screen buffer back to top, will > previous content not shifted) > likely the current appoach of just having a handle to findfirst/findnext > will not fit all the (long term) goals. at some point, we want to > support shift-tab which circles backwards in the matching files. and I > fail to see what using FindFirstFileEx brings as value, as you filter > against directory when needed (I'm not asking for supporting shift-tab > right now, but rather to put in place a structure were it wil fit simply > when we implement it) > support for cd/rmdir/ and friends should be added in a second patch > I didn't go further in the review given the amount a remarks and > problems stated above. I'll restart when they are solved > (will look in // to the ESC issue raised) In the latest changes I have already split out much code from WCMD_ReadConsole into subfunctions. You're saying it's still too long? I suppose that I could split out the code for the individual case statements into separate handler functions, but the code to handle Tab is the bulk of that function. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7843#note_101954

1 0

Re: [PATCH v24 0/1] MR7843: cmd: Implement tab completion for command line entry.
by Joe Souza (＠JoeS209) 26 Apr '25

26 Apr '25

On Sat Apr 26 15:12:31 2025 +0000, eric pouech wrote: > that's not sufficient, you have also to compare that inputbuffer up to > current pos hasn't changed since previous call > (eg directory with za, za2 and zb zb2 files... circle twice from "za", > replace "za" by "zb" and circle with tab...) I missed that case. I tested C:\win<tab> and C:\pro<tab> but resulting paths are different lengths. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7843#note_101953

1 0

Re: [PATCH v24 0/1] MR7843: cmd: Implement tab completion for command line entry.
by Joe Souza (＠JoeS209) 26 Apr '25

26 Apr '25

On Sat Apr 26 15:12:31 2025 +0000, eric pouech wrote: > looks to be that curPos can be \> \*numRead, hence reading garbage in > that case Line 312 terminates the buffer at *numRead, line 314 sets len to *numRead, and loop at 320 stops when !(curPos < len). Worst case is if curPos == len then we are checking the null terminator. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7843#note_101952

1 0

[PATCH v2 0/1] MR7888: wbemprox: Implement Win32_CacheMemory table.
by Paul Gofman (＠gofman) 26 Apr '25

26 Apr '25

-- v2: wbemprox: Implement Win32_CacheMemory table. https://gitlab.winehq.org/wine/wine/-/merge_requests/7888

3 3

Re: [PATCH v24 0/1] MR7843: cmd: Implement tab completion for command line entry.
by Joe Souza (＠JoeS209) 26 Apr '25

26 Apr '25

On Sat Apr 26 17:10:07 2025 +0000, Joe Souza wrote: > Paths need to be quoted if they are long file names or they contain > spaces, hence the check for findData.cAlternateFileName. To do what you're asking here we would need to track whether each level in the path requires quotes, not just the current filename. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7843#note_101950

1 0

Re: [PATCH v24 0/1] MR7843: cmd: Implement tab completion for command line entry.
by Joe Souza (＠JoeS209) 26 Apr '25

26 Apr '25

On Sat Apr 26 15:12:32 2025 +0000, eric pouech wrote: > I think quote handling is not done as it should > from what I see on native: quotes are added when generated word does > contain characters that would need to be escaped (eg ' ', but didn't > check all the others) > need quote is an attribute of current filename (ie they are removed when > the new (partial) matching file no longer needs them) ; so quotes > shouldn't be part of the SEARCH_CONTEXT, but only used for display > (basically: go to beg of word; if needs quotes, print quote; print > (partial) word; print ending quotes (if needed) Paths need to be quoted if they are long file names or they contain spaces, hence the check for findData.cAlternateFileName. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7843#note_101949

1 0

[PATCH 0/2] MR7884: odbc32: Fix some NULL pointer issues
by Stefan Dösinger (＠stefan) 26 Apr '25

26 Apr '25

I ran into this trying to use the Mac-Native MS SQL Server ODBC driver -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7884

3 3

[PATCH 0/1] MR7912: appwiz.cpl: Report addon download failures.
by Esme Povirk (＠madewokherd) 26 Apr '25

26 Apr '25

This relates to https://bugs.winehq.org/show_bug.cgi?id=58160 but doesn't fix it, just reports the error instead of stalling. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7912

2 1

[PATCH 0/1] MR7911: odbc32: Fix replicating unixODBC data sources.
by Hans Leidekker (＠hans) 26 Apr '25

26 Apr '25

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=58140 -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7911

2 1

Re: [PATCH v21 0/1] MR7843: cmd: Implement tab completion for command line entry.
by eric pouech (＠epo) 26 Apr '25

26 Apr '25

didn't play a lot with resulting code, mostly reviewed it note: dir "c:\\Programs Files\\"\<tab\> should circle among the subdirectories... current code doesn't also dir c\<tab\> (with a first file displayed), then reduce size of console window to be shorter than input line, will display input on line after the prompt -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7843#note_101938

1 0

Re: [PATCH v21 0/1] MR7843: cmd: Implement tab completion for command line entry.
by eric pouech (＠epo) 26 Apr '25

26 Apr '25

eric pouech (@epo) commented about programs/cmd/lineedit.c: > + } > + lstrcatW(searchstr, L"*"); > + TRACE("New search: [%s]\n", wine_dbgstr_w(searchstr)); > + > + sc.isDirSearch = IsDirectoryOperation(inputBuffer, inputBufferLength); > + } > + > + FindNextMatchingDirectoryEntry(searchstr, &sc); > + > + if (sc.haveSearchResult) { > + /* If this is our first time through here for this search, we need to find the insert position > + * for the results. Note that this is very likely not the same location as the search position. > + */ > + if (!sc.insertPos) { > + /* If user entered a backslash after quotes, remove the quotes. */ > + if (curPos > 2 && inputBuffer[curPos-2] == L'\"' && inputBuffer[curPos-1] == L'\\') { I think quote handling is not done as it should from what I see on native: quotes are added when generated word does contain characters that would need to be escaped (eg ' ', but didn't check all the others) need quote is an attribute of current filename (ie they are removed when the new (partial) matching file no longer needs them) ; so quotes shouldn't be part of the SEARCH_CONTEXT, but only used for display (basically: go to beg of word; if needs quotes, print quote; print (partial) word; print ending quotes (if needed) -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7843#note_101937

1 0

Re: [PATCH v21 0/1] MR7843: cmd: Implement tab completion for command line entry.
by eric pouech (＠epo) 26 Apr '25

26 Apr '25

eric pouech (@epo) commented about programs/cmd/lineedit.c: > + } else { > + cc = len; > + while (cc > 0 && inputBuffer[cc] != L' ' && inputBuffer[cc] != L'\t') { > + cc--; > + } > + } > + } > + > + if (cc != sc->searchPos || inputBuffer[sc->searchPos] == L'\\') { > + cc++; > + } > + > + sc->insertPos = cc; > +} > + > +static void FindNextMatchingDirectoryEntry(const WCHAR *searchstr, PSEARCH_CONTEXT sc) a couple of comments here: * actually, this is not exactly how native (Win10) behaves: native captures the list of matching files at first tab usage, and doesn't update that list if eg. a file matching the pattern is added * the way done here is a bit more dynamic (as it would capture file creation/deletion), and I don't think it matters much from a user perspective the main thing I'm concerned about is that code to handle backwards shift-tab will be a bit more painful, and also the restart case (when the matched file is deleted) I think code would be simpler and more readable when storing the list of files, but I won't block on that. I let you pick up your favorite one. if you keep current logic, it seems to me that: * \-\>hadOneMatch is only used locally, and should rather be a local variable * \-\>hasSearchResult would make more sense be return value from this function -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7843#note_101936

1 0

Re: [PATCH v21 0/1] MR7843: cmd: Implement tab completion for command line entry.
by eric pouech (＠epo) 26 Apr '25

26 Apr '25

eric pouech (@epo) commented about programs/cmd/lineedit.c: > + int lastStartQuote; > + int searchPos; > + int insertPos; > +} SEARCH_CONTEXT, *PSEARCH_CONTEXT; > + > + > +static BOOL IsDirectoryOperation(const WCHAR *inputBuffer, const ULONG inputBufferLength) > +{ > + int cc = 0; > + BOOL ret = FALSE; > + > + while (cc < inputBufferLength && (inputBuffer[cc] == L' ' || inputBuffer[cc] == L'\t')) { > + cc++; > + } > + > + if ((cc + 2 < inputBufferLength && (inputBuffer[cc + 2] == L' ' || inputBuffer[cc + 2] == L'\t')) && questionning about finding the end of first word algorithm native behavior is very inconsistent `>cd\windows` (note that there's no space between "cd" and "\\"). is supported as command, but tab-completion on "windows" doesn't work **but** `>cd"\windows"` (idem no space, but with quotes). isn't supported as a command, but tab-completion does work since this relates to corner cases of user interaction, I'm not sure we want to mimic all these broken behaviors for consistency I'd rather suggest that you use `WCMD_parameter` to split the edit line into separate words you can then work upon this at least will provide consistency across all the code -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7843#note_101935

1 0

Re: [PATCH v21 0/1] MR7843: cmd: Implement tab completion for command line entry.
by eric pouech (＠epo) 26 Apr '25

26 Apr '25

eric pouech (@epo) commented about programs/cmd/lineedit.c: > + > + FindInsertPos(inputBuffer, curPos, &sc); > + } > + > + /* Copy search results to input buffer. */ > + UpdateInputBuffer(inputBuffer, inputBufferLength, &sc); > + > + /* Update cursor position to end of buffer. */ > + curPos = lstrlenW(inputBuffer); > + if (curPos > maxLen) { > + maxLen = curPos; > + } > + } > + break; > + > + case L'\x1B': /* ESC */ looks at that question, and you're right... ReadConsole needs to handle ESC. I'll send a patch later on, so can drop ESC handling from your patch -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7843#note_101934

1 0

Re: [PATCH v21 0/1] MR7843: cmd: Implement tab completion for command line entry.
by eric pouech (＠epo) 26 Apr '25

26 Apr '25

eric pouech (@epo) commented about programs/cmd/lineedit.c: > + } > + oldCurPos = curPos; > + curPos = 0; > + while (curPos < len && > + inputBuffer[curPos] != L'\t' && > + inputBuffer[curPos] != L'\x1B' > + ) { > + > + curPos++; > + } > + /* curPos is often numRead - 1, but not always, as in the case where history is retrieved > + * and then user backspaces to somewhere mid-string and then hits Tab. > + */ > + TRACE("numRead: %lu, curPos: %u\n", *numRead, curPos); > + > + switch (inputBuffer[curPos]) { looks to be that curPos can be \> \*numRead, hence reading garbage in that case -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7843#note_101933

1 0

Re: [PATCH v21 0/1] MR7843: cmd: Implement tab completion for command line entry.
by eric pouech (＠epo) 26 Apr '25

26 Apr '25

eric pouech (@epo) commented about programs/cmd/lineedit.c: > + /* curPos is often numRead - 1, but not always, as in the case where history is retrieved > + * and then user backspaces to somewhere mid-string and then hits Tab. > + */ > + TRACE("numRead: %lu, curPos: %u\n", *numRead, curPos); > + > + switch (inputBuffer[curPos]) { > + case L'\t': > + TRACE("TAB: [%s]\n", wine_dbgstr_w(inputBuffer)); > + inputBuffer[curPos] = L'\0'; > + len = curPos; > + sc.haveSearchResult = FALSE; > + > + /* See if we need to reset an existing search. */ > + if (sc.hSearch != INVALID_HANDLE_VALUE) { > + /* If tab key was hit at a different location than last time */ > + if (curPos != oldCurPos) { that's not sufficient, you have also to compare that inputbuffer up to current pos hasn't changed since previous call (eg directory with za, za2 and zb zb2 files... circle twice from "za", replace "za" by "zb" and circle with tab...) -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7843#note_101932

1 0

Re: [PATCH v21 0/1] MR7843: cmd: Implement tab completion for command line entry.
by eric pouech (＠epo) 26 Apr '25

26 Apr '25

eric pouech (@epo) commented about programs/cmd/lineedit.c: > + csbi.dwCursorPosition.X = 0; /* First column in the row. */ > + cCount -= chars; > + } > +} > + > +static void SetCursorVisible(const HANDLE hOutput, const BOOL visible) > +{ > + CONSOLE_CURSOR_INFO cursorInfo; > + > + if (GetConsoleCursorInfo(hOutput, &cursorInfo)) { > + cursorInfo.bVisible = visible; > + SetConsoleCursorInfo(hOutput, &cursorInfo); > + } > +} > + > +static void FindSearchPos(const WCHAR *inputBuffer, int len, PSEARCH_CONTEXT sc) same remark as above: please use WCMD_parameter to loop across words and determine which word contains current cursor positiion -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7843#note_101931

1 0

Re: [PATCH v21 0/1] MR7843: cmd: Implement tab completion for command line entry.
by eric pouech (＠epo) 26 Apr '25

26 Apr '25

eric pouech (@epo) commented about programs/cmd/lineedit.c: > + * > + * You should have received a copy of the GNU Lesser General Public > + * License along with this library; if not, write to the Free Software > + * Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301, USA > + */ > + > +#define WIN32_LEAN_AND_MEAN > + > +#include "wcmd.h" > +#include "wine/debug.h" > + > +WINE_DEFAULT_DEBUG_CHANNEL(cmd); > + > +typedef struct _SEARCH_CONTEXT > +{ > + HANDLE hSearch; in new code, we tend not to use camel case for function names or fields but rather snake case -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7843#note_101930

1 0

Re: [PATCH v21 0/1] MR7843: cmd: Implement tab completion for command line entry.
by eric pouech (＠epo) 26 Apr '25

26 Apr '25

eric pouech (@epo) commented about programs/cmd/lineedit.c: > + BOOL ignoreTrailingQuote; > + BOOL isDirSearch; > + BOOL haveSearchResult; > + BOOL hadOneMatch; > + int lastStartQuote; > + int searchPos; > + int insertPos; > +} SEARCH_CONTEXT, *PSEARCH_CONTEXT; > + > + > +static BOOL IsDirectoryOperation(const WCHAR *inputBuffer, const ULONG inputBufferLength) > +{ > + int cc = 0; > + BOOL ret = FALSE; > + > + while (cc < inputBufferLength && (inputBuffer[cc] == L' ' || inputBuffer[cc] == L'\t')) { you need to handle '@' as well -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7843#note_101929

1 0

Re: [PATCH v21 0/1] MR7843: cmd: Implement tab completion for command line entry.
by eric pouech (＠epo) 26 Apr '25

26 Apr '25

eric pouech (@epo) commented about programs/cmd/lineedit.c: > +/* I don't think it's worth it to create another source file for only \~400 LoC -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7843#note_101928

1 0

Re: [PATCH v21 0/1] MR7843: cmd: Implement tab completion for command line entry.
by eric pouech (＠epo) 26 Apr '25

26 Apr '25

eric pouech (@epo) commented about programs/cmd/lineedit.c: > +typedef struct _SEARCH_CONTEXT > +{ > + HANDLE hSearch; > + WIN32_FIND_DATAW findData; > + BOOL haveQuotes; > + BOOL ignoreTrailingQuote; > + BOOL isDirSearch; > + BOOL haveSearchResult; > + BOOL hadOneMatch; > + int lastStartQuote; > + int searchPos; > + int insertPos; > +} SEARCH_CONTEXT, *PSEARCH_CONTEXT; > + > + > +static BOOL IsDirectoryOperation(const WCHAR *inputBuffer, const ULONG inputBufferLength) I'd like to see the code for specific handling of first word in a separate commit (just for clarity and make review easier) -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7843#note_101927

1 0

Re: [PATCH v21 0/1] MR7843: cmd: Implement tab completion for command line entry.
by eric pouech (＠epo) 26 Apr '25

26 Apr '25

thanks a couple of high level comments: * I don't think having a separate source file just for \~400 LoC is worth it * WCMD_ReadConsole is way too big as a function and need to be split in smaller pieces. * you should also be using the command line parsing functions instead of rewriting them (eg WCMD_parameter to loop against the various parameters) from quick testing: * when looping around files sometimes filename is inserted in quotes, while it shouldn't. Native seems to insert quotes only when filename contains specific characters (spaces...), but to also remove them if next file doesn't contain any... * using "cd c:\\Program Files"\<tab\>\<backspace\>\\\<tab\> doesn't behave as native... native circles in the directory content, current MR only adds a double quote * got a crash when playing with MR (perhaps one of the buffer overflow stated above, perhaps not) * when the width of the console is smaller than the full line input (eg spread at least on two lines), circling gives some strange result (cursor and display when from bottom of screen buffer back to top, will previous content not shifted) likely the current appoach of just having a handle to findfirst/findnext will not fit all the (long term) goals. at some point, we want to support shift-tab which circles backwards in the matching files. and I fail to see what using FindFirstFileEx brings as value, as you filter against directory when needed (I'm not asking for supporting shift-tab right now, but rather to put in place a structure were it wil fit simply when we implement it) support for cd/rmdir/ and friends should be added in a second patch I didn't go further in the review given the amount a remarks and problems stated above. I'll restart when they are solved (will look in // to the ESC issue raised) -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7843#note_101926

1 0

[PATCH v3 0/2] MR7908: Fix macOS winetest timeout in kernel32:virtual
by Jinoh Kang (＠iamahuman) 26 Apr '25

26 Apr '25

Work around slow runtime of current FlushProcessWriteBuffers() implementation on macOS. The total iteration count becomes: ``` - positive half: 32768 * 1 (old) = 8192 * 4 (new) - negative half: 32768 * 1 (old) > 8192 * 1 (new) ``` -- v3: kernel32/tests: Shorten time for negative half of litmus test for FlushProcessWriteBuffers(). kernel32/tests: Run store_buffer_litmus_test() in a single-iteration loop. https://gitlab.winehq.org/wine/wine/-/merge_requests/7908

2 2

[PATCH v2 0/2] MR7908: Fix macOS winetest timeout in kernel32:virtual
by Jinoh Kang (＠iamahuman) 26 Apr '25

26 Apr '25

Work around slow runtime of current FlushProcessWriteBuffers() implementation on macOS. The total iteration count becomes: ``` - positive half: 32768 * 1 (old) = 8192 * 4 (new) - negative half: 32768 * 1 (old) > 8192 * 1 (new) ``` -- v2: kernel32/tests: Shorten time for negative half of litmus test for FlushProcessWriteBuffers(). https://gitlab.winehq.org/wine/wine/-/merge_requests/7908

2 2

[PATCH v2 0/2] MR7895: Revert "kernel32/tests: Don't use _ReadWriteBarrier on ARM platforms."
by Jinoh Kang (＠iamahuman) 26 Apr '25

26 Apr '25

This reverts commit 504a305a60849704f2d83b55e9aabb26d89edf11. The choice of weak barrier was by design. The stronger barrier broke the positive half of the litmus test for FlushProcessWriteBuffers(): > virtual.c:4568: Test failed: expected write-read reordering with compiler barrier > only (got 0 reorderings) FlushProcessWriteBuffers() is used in tandem with a compiler-only barrier to implement fast synchronization, where only one side is executed frequently and the other side only occassionally (e.g., garbage collection). Prominent applications include .NET and HotSpot JVM. Although _ReadWriteBarrier() is "marked deprecated," it is in fact used by Microsoft's own STL library (with explicit suppression of warning) to implement a compiler-only memory barrier[^1]. The deprecation notice suggests C++11 atomics as the (only?) alternative. [^1]: https://github.com/microsoft/STL/blob/b5df16a98934319e2e6864d6036cbe9cd9c74… -- v2: kernel32/tests: Don't use _ReadWriteBarrier() on clang. https://gitlab.winehq.org/wine/wine/-/merge_requests/7895

2 3

[PATCH 0/1] MR7895: Revert "kernel32/tests: Don't use _ReadWriteBarrier on ARM platforms."
by Jinoh Kang (＠iamahuman) 26 Apr '25

26 Apr '25

This reverts commit 504a305a60849704f2d83b55e9aabb26d89edf11. The choice of weak barrier was by design. The stronger barrier broke the positive half of the litmus test for FlushProcessWriteBuffers(): > virtual.c:4568: Test failed: expected write-read reordering with compiler barrier > only (got 0 reorderings) FlushProcessWriteBuffers() is used in tandem with a compiler-only barrier to implement fast synchronization, where only one side is executed frequently and the other side only occassionally (e.g., garbage collection). Prominent applications include .NET and HotSpot JVM. Although _ReadWriteBarrier() is "marked deprecated," it is in fact used by Microsoft's own STL library (with explicit suppression of warning) to implement a compiler-only memory barrier[^1]. The deprecation notice suggests C++11 atomics as the (only?) alternative. [^1]: https://github.com/microsoft/STL/blob/b5df16a98934319e2e6864d6036cbe9cd9c74… -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7895

4 4

[PATCH 0/3] MR7907: vwin32.vxd: Fix support for vwin32 IOCTLs
by Pali Rohár (＠pali) 26 Apr '25

26 Apr '25

* Remove cases for vwin32 IOCTLs 0x10 and 0x29 numbers as they are unsupported by Windows 9x * Fix functions accepted by IOCTLs VWIN32_DIOC_DOS_IOCTL and VWIN32_DIOC_DOS_DRIVEINFO * Add missing IOCTL VWIN32_DIOC_DOS_INT13 case for TRACE log -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7907

2 3

[PATCH 0/6] MR7861: krnl386: Fixes for DPMI functions
by Pali Rohár (＠pali) 26 Apr '25

26 Apr '25

* Set carry flag for every failed DPMI call * Fix return value for DPMI calls 0102h, 0202h and 0900h-0902h * Fix comments and FIXME -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7861

5 14

[PATCH v4 0/4] MR6885: Draft: cmd: Use the console output codepage to read batch files.
by Akihiro Sagawa (＠sgwaki) 26 Apr '25

26 Apr '25

To prevent performance degradation, we will cache the result of GetConsoleOutputCP() after executing every external command. -- v4: cmd: Use the console output code page to read batch files. programs/cmd: Factor out code_page when searching for a label. cmd/tests: Add updated code page test in batch file. cmd: Use the OEM code page if GetConsoleOutputCP fails. https://gitlab.winehq.org/wine/wine/-/merge_requests/6885

4 7

[PATCH 0/1] MR7904: krnl386: Fix return value for DPMI 0900h-0902h calls (Virtual Interrupt State)
by Pali Rohár (＠pali) 26 Apr '25

26 Apr '25

According to the DPMI specification, DPMI functions 0900h-0902h related to Virtual Interrupt State has to always return state in AL register. As wine does not support disabling virtual interrupt flag, report that interrupts are always enabled (AL=1). -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7904

2 1

[PATCH 0/1] MR7903: krnl386: Fix comments for DPMI 0202h/0203h calls (Processor Exception Handler Vector)
by Pali Rohár (＠pali) 26 Apr '25

26 Apr '25

DPMI functions 0202h and 0203h related to Processor Exception Handler Vector are not supported by wine. So update FIXME comments about this fact. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7903

2 1

[PATCH 0/1] MR7902: krnl386: Add FIXME case for every unimplemented DPMI 0.9 call
by Pali Rohár (＠pali) 26 Apr '25

26 Apr '25

Windows provides DPMI host according to DPMI version 0.9. Add cases for all missing DPMI 0.9 function calls into wine code, set Carry flag which indicates DPMI failure and mark them with appropriate FIXME comments. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7902

2 1

[PATCH 0/1] MR7901: ntdll: Treat XDG_DATA_DIRS as special env variable.
by Louis Lenders (＠xe) 26 Apr '25

26 Apr '25

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=49987 GTK apps seem to use this env var to find path to schemas, like Meld: https://download.gnome.org/binaries/win32/meld/3.22/Meld-3.22.2-mingw.msi which doesn't start at all without this patch. More info in https://bugs.winehq.org/show_bug.cgi?id=49987. v2: add WINEXDG_DATA_DIRS and use that in winemenubuilder. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7901

2 1

[PATCH 0/4] MR7899: windowscodecs/tests: Remove A->W test data conversion.
by Nikolay Sivov (＠nsivov) 26 Apr '25

26 Apr '25

Signed-off-by: Nikolay Sivov <nsivov(a)codeweavers.com> -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7899

3 5

Re: [PATCH v2 0/2] MR7871: ntdll: Use UFFD for tracking write watches when possible. - approved
by Alexandre Julliard (＠julliard) 25 Apr '25

25 Apr '25

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7871

1 0

Re: [PATCH v3 0/1] MR7669: ntdll/server: Make robust to spurious short writes - approved
by Alexandre Julliard (＠julliard) 25 Apr '25

25 Apr '25

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7669

1 0

Re: [PATCH v9 0/5] MR7779: mshtml: Misc constructor and prototype improvements. - approved
by Alexandre Julliard (＠julliard) 25 Apr '25

25 Apr '25

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7779

1 0

[PATCH v2 0/1] MR7898: gdiplus: Limit clip region calculation to device rectangle.
by Esme Povirk (＠madewokherd) 25 Apr '25

25 Apr '25

-- v2: gdiplus: Limit clip region calculation to device rectangle. https://gitlab.winehq.org/wine/wine/-/merge_requests/7898

2 1

2025

2024

2023

2022

wine-gitlab