- wine-gitlab - winehq.org

[PATCH 0/2] MR5105: msvcrt: Use string sort for strncoll/wcsncoll.
by Daniel Lehman (＠dlehman25) 19 Feb '24

19 Feb '24

will submit a separate request for strcoll/wcscoll -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5105

3 3

[PATCH 0/1] MR5098: wined3d: Use CRT allocation functions.
by Alex Henrie (＠alexhenrie) 19 Feb '24

19 Feb '24

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/5098

3 2

[PATCH 0/3] MR658: tests/shader_runner: Unify the checking and reporting of runner capabilities.
by Henri Verbeet (＠hverbeet) 19 Feb '24

19 Feb '24

-- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/658

3 5

[PATCH 0/1] MR657: vkd3d-shader/hlsl: Support SV_PrimitiveID in pixel shaders.
by Henri Verbeet (＠hverbeet) 19 Feb '24

19 Feb '24

-- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/657

3 3

[PATCH 0/5] MR5107: winegstreamer: Complete H264 current output type reported attributes.
by Rémi Bernon (＠rbernon) 19 Feb '24

19 Feb '24

Needed for the mfreadwrite pipelines. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5107

3 7

[PATCH v5 0/1] MR364: kernel32/tests: Test module refcounting with forwarded exports.
by Jinoh Kang (＠iamahuman) 19 Feb '24

19 Feb '24

Test module references created by resolving forwarded exports. The following diagram explains what happens in bug #52094 under the hood: ```mermaid graph TB subgraph state_00["Initial"] direction LR s00_ida[ida64.dll] ~~~ s00_idapy[idapython64.dll] -. "(import)" .-> s00_py3[python3.dll] -. "(forwards to)" .-> s00_py311[python311.dll] end state_00 -. "1. <code>LoadLibrary("</code>configured Python version (e.g., python311.dll)<code>")</code>" .-> state_01 subgraph state_01["python311.dll loaded"] direction LR s01_ida[ida64.dll] ~~~ s01_idapy[idapython64.dll] -. "(import)" .-> s01_py3[python3.dll] -. "(forwards to)" .-> s01_py311[python311.dll] s01_ida -- "dynamic ref" --> s01_py311 end state_01 -. "2. <code>LoadLibrary("</code>idapython64.dll<code>")</code>" .-> state_02 subgraph state_02["idapython64.dll loaded"] direction LR s02_ida[ida64.dll] -- "dynamic ref" --> s02_idapy[idapython64.dll] -- "static ref" --> s02_py3[python3.dll] -. "(forwards to)" .-> s02_py311[python311.dll] s02_ida -- "dynamic ref" --> s02_py311 s02_idapy -- "static forwarded ref" --> s02_py311 end state_02 -. "3. <code>FreeLibrary("</code>configured Python version (e.g., python311.dll)<code>")</code>" .-> state_03 subgraph state_03["python311.dll reference removed"] direction LR style s03_py311 color:#f00,stroke:#f00 s03_ida[ida64.dll] -- "dynamic ref" --> s03_idapy[idapython64.dll] -- "static ref" --> s03_py3[python3.dll] -. "(forwards to)" .-> s03_py311[python311.dll] s03_ida -. "<del>dynamic ref (deleted)</del>" .-> s03_py311 s03_idapy -- "static forwarded ref" --> s03_py311 end ``` On Windows, the static forwarded ref keeps `python311.dll` from being unloaded; however, Wine is missing this behavior, causing it to be unloaded and segfault immediately (since further initialization happens just after step 3 FreeLibrary). The tests aim to reproduce this condition. --- ### Alternative options 1. Find existing DLLs satisfying this scenario: I haven't found any in wine tree. Let me know if I missed anything. 2. Construct PE for the DLLs on-the-fly: This sounds more complicated than a handful of test DLLs. -- v5: kernel32/tests: Test module refcounting with forwarded exports. https://gitlab.winehq.org/wine/wine/-/merge_requests/364

5 9

Re: [PATCH v2 0/1] MR652: vkd3d-shader/hlsl: Parse rasteriser-ordered view types.
by Zebediah Figura (＠zfigura) 19 Feb '24

19 Feb '24

> How about the [attached](https://gitlab.winehq.org/wine/vkd3d/uploads/d104ebd37a462b4fd375… series? I turns out that it's a bit awkward to make the "rasteriser_ordered" flag specific to UAVs due to the way "resource_format" is currently used, but making it a resource flag seems close enough to me. The series has a minor conflict with 569. That also looks good to me. -- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/652#note_61921

1 0

[PATCH v3 0/4] MR5111: kernelbase: Replace FileAllInformation with FileStatInformation in GetFileInformationByHandle().
by Jinoh Kang (＠iamahuman) 19 Feb '24

19 Feb '24

This patchset aims to fix #46070 without supplying unix\_name for all server files. -- v3: kernelbase: Replace FileAllInformation with FileStatInformation in GetFileInformationByHandle(). ntdll: Implement NtQueryInformationFile FileStatInformation. https://gitlab.winehq.org/wine/wine/-/merge_requests/5111

3 6

[PATCH v2 0/2] MR5112: DBI substreams in PDB files.
by eric pouech (＠epo) 19 Feb '24

19 Feb '24

We used to expect a fixed number of DBI substreams (the expected number depended on the DBI header version). Recent MSVC generate a different number as we expected. Implement a more flexible scheme where we allow any number of streams. This lets these recent PDB files to be properly displayed by winedump, and loaded/parsed by dbghelp. -- v2: dbghelp: Don't expected a fixed number of substreams in DBI header (PDB). winedump: Don't expect a fixed number of substreams in DBI header (PDB). https://gitlab.winehq.org/wine/wine/-/merge_requests/5112

2 3

Re: [PATCH v2 0/1] MR652: vkd3d-shader/hlsl: Parse rasteriser-ordered view types.
by Henri Verbeet (＠hverbeet) 19 Feb '24

19 Feb '24

How about the [attached](/uploads/d104ebd37a462b4fd375640b9e97eb93/patches.mbox.xz) series? I turns out that it's a bit awkward to make the "rasteriser_ordered" flag specific to UAVs due to the way "resource_format" is currently used, but making it a resource flag seems close enough to me. The series has a minor conflict with 569. -- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/652#note_61911

1 0

[PATCH 0/4] MR656: vkd3d-shader/ir: Introduce a better CFG structurizer, part 1.
by Giovanni Mascellani (＠giomasce) 19 Feb '24

19 Feb '24

This first MR create an internal structured representation of the CFG and computes the domination relationship. Over a few other MRs I will implement an algorithm inspired to [this article](https://medium.com/leaningtech/solving-the-structured-control-flow… to compute a better structure than the one we already have, but for the moment the computed data is immediately wasted. -- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/656

3 5

[PATCH 0/1] MR5114: winedbg: Use share attributes for opening command file.
by eric pouech (＠epo) 19 Feb '24

19 Feb '24

(this fixes --command option when winedbg is relaunched in wow64 case). Signed-off-by: Eric Pouech <epouech(a)codeweavers.com> -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5114

2 1

[PATCH 0/4] MR5111: kernelbase: Replace FileAllInformation with FileStatInformation in GetFileInformationByHandle().
by Jinoh Kang (＠iamahuman) 19 Feb '24

19 Feb '24

This patchset aims to fix #46070 without supplying unix\_name for all server files. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5111

2 5

[PATCH 0/1] MR5113: dbghelp: Implement SymFromIndex().
by eric pouech (＠epo) 19 Feb '24

19 Feb '24

Signed-off-by: Eric Pouech <epouech(a)codeweavers.com> -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5113

2 1

[PATCH 0/2] MR5112: DBI substreams in PDB files.
by eric pouech (＠epo) 19 Feb '24

19 Feb '24

We used to expect a fixed number of DBI substreams (the expected number depended on the DBI header version). Recent MSVC generate a different number as we expected. Implement a more flexible scheme where we allow any number of streams. This lets these recent PDB files to be properly displayed by winedump, and loaded/parsed by dbghelp. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5112

2 2

[PATCH v2 0/6] MR5110: Parametrize macdrv retina scaling functions.
by Marc-Aurel Zent (＠mzent) 19 Feb '24

19 Feb '24

Also removes the unused `cgsize_win_from_mac()`. -- v2: winemac.drv: Remove dead cgsize_win_from_mac() function. winemac.drv: Parametrize retina in cgpoint_win_from_mac(). winemac.drv: Parametrize retina in cgpoint_mac_from_win(). winemac.drv: Parametrize retina in cgsize_mac_from_win(). winemac.drv: Parametrize retina in cgrect_win_from_mac(). winemac.drv: Parametrize retina in cgrect_mac_from_win(). https://gitlab.winehq.org/wine/wine/-/merge_requests/5110

2 6

[PATCH 0/1] MR655: vkd3d-shader/hlsl: Emit fixme on non-direct resource stores.
by Francisco Casas (＠fcasas) 19 Feb '24

19 Feb '24

Co-authored-by: Giovanni Mascellani <gmascellani(a)codeweavers.com> These may happen when storing to structured buffers, and we are not handling them properly yet. The included test reaches unreacheable code before this patch. Storing to buffers is complicated since we need to split the index chain in two paths: - The path within the variable where the resource is. - The subpath to the part of the resource element that is being stored to. For now, we will emit a fixme when the index chain in the lhs is not a direct resource access. -- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/655

5 5

[PATCH v7 0/4] MR636: vkd3d-shader/fx: Add initial support for writing buffers descriptions.
by Nikolay Sivov (＠nsivov) 19 Feb '24

19 Feb '24

-- v7: vkd3d-shader/fx: Do not align structured data section. vkd3d-shader/fx: Add initial support for writing buffers descriptions. vkd3d-shader/fx: Do not align strings for fx_4/fx_5 profiles. vkd3d-shader/fx: Use variable pointer in write_group(). https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/636

4 7

Re: [PATCH v11 0/6] MR569: tests/shader_runer: Support SRV buffers. - approved
by Henri Verbeet (＠hverbeet) 19 Feb '24

19 Feb '24

This merge request was approved by Henri Verbeet. -- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/569

1 0

Re: [PATCH v12 0/2] MR364: vkd3d-shader/hlsl: Implement inverse trigonometry.
by Henri Verbeet (＠hverbeet) 19 Feb '24

19 Feb '24

> ``` > Tests have already been implemented in 92044d5e; this commit loosens > some of the todos (because now they're implemented!). > ``` I get what you're saying here, but I think the use of "loosens" here is slightly odd; you're narrowing the scope of the todo's, not broadening it. > ```diff > + const char *fn_name = asin_mode > + ? fn_name_asin > + : fn_name_acos; > ``` Continuations get double indentation, like template[] above this code, and the hlsl_sprintf_alloc() call below this code. This could of course also simply go on a single line. > ```diff > + static const char* atan2_name = "atan2"; > + static const char* atan_name = "atan"; > ``` We'll want ```c static const char atan2_name[] = "atan2"; static const char atan_name[] = "atan"; ``` here. That applies to "atan2_header_template" and "atan_header_template" as well. > ```diff > + if (!(buf = hlsl_get_string_buffer(ctx))) { > + return false; > + } > + > + if (atan2_mode) { > + ok = vkd3d_string_buffer_printf(buf, atan2_header_template, > + type->name, type->name, type->name, type->name); > + } else { > + ok = vkd3d_string_buffer_printf(buf, atan_header_template, > + type->name, type->name, type->name); > + } > + if (ok < 0) > + return false; > + > + ok = vkd3d_string_buffer_printf(buf, body_template, type->name); > + if (ok < 0) > + return false; > + > + func = hlsl_compile_internal_function(ctx, > + atan2_mode ? atan2_name : atan_name, buf->buffer); > ``` Couple of issues here: - "{" and "}" would go on their own line, but could also simply be omitted here. - Continuations get double indentation. - You're leaking "buf" on the error paths. - "ok" is an unusual name for the return code, it's more commonly called either "ret" or "rc". - There's a trailing space on the line containing the hlsl_compile_internal_function() call. -- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/364#note_61887

1 0

[PATCH v4 0/6] MR642: vkd3d-shader/dxil: Implement DX intrinsics BufferStore and RawBufferStore.
by Conor McCarthy (＠cmccarthy) 19 Feb '24

19 Feb '24

-- v4: vkd3d-shader/dxil: Implement DX intrinsic RawBufferStore. vkd3d-shader/dxil: Handle raw and structured buffers in sm6_parser_emit_dx_buffer_store(). vkd3d-shader/dxil: Implement DX intrinsic BufferStore. tests/shader-runner: Add a test for a signed int structured buffer UAV. tests/shader-runner: Add a test for a signed int typed buffer UAV. tests/shader-runner: Support structured buffer UAVs. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/642

2 6

[PATCH v3 0/6] MR642: vkd3d-shader/dxil: Implement DX intrinsics BufferStore and RawBufferStore.
by Conor McCarthy (＠cmccarthy) 19 Feb '24

19 Feb '24

-- v3: vkd3d-shader/dxil: Implement DX intrinsic RawBufferStore. vkd3d-shader/dxil: Handle raw and structured buffers in sm6_parser_emit_dx_buffer_store(). vkd3d-shader/dxil: Implement DX intrinsic BufferStore. tests/shader-runner: Add a test for a signed int structured buffer UAV. tests/shader-runner: Add a test for a signed int typed buffer UAV. tests/shader-runner: Support structured buffer UAVs. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/642

3 9

[PATCH 0/6] MR5004: winevulkan: Wrap swapchain handles and factor surface capabilities fixups.
by Rémi Bernon (＠rbernon) 19 Feb '24

19 Feb '24

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/5004

3 15

[PATCH 0/6] MR5093: wininet: Improve proxy configuration reading and writing (part 3).
by Piotr Caban (＠piotr) 19 Feb '24

19 Feb '24

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/5093

3 7

[PATCH v18 0/6] MR3103: server: Create and use a desktop shared mapping for GetCursorPos.
by Rémi Bernon (＠rbernon) 19 Feb '24

19 Feb '24

First part of Proton shared memory series. The full branch can be seen at https://gitlab.winehq.org/rbernon/wine/-/commits/mr/shared-memories. -- v18: user32: Use the desktop shared data for GetCursorPos(). include: Add ReadNoFence64 inline helpers. server: Expose the desktop shared mapping to clients. server: Add a sequence number to the shared data. server: Move the cursor position and last change time to the shared data. server: Create a desktop shared mapping. https://gitlab.winehq.org/wine/wine/-/merge_requests/3103

5 16

[PATCH 0/6] MR5110: Parametrize macdrv retina scaling functions.
by Marc-Aurel Zent (＠mzent) 19 Feb '24

19 Feb '24

Also removes the unused `cgsize_win_from_mac()`. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5110

2 6

Re: [PATCH v12 0/2] MR364: vkd3d-shader/hlsl: Implement inverse trigonometry.
by Giovanni Mascellani (＠giomasce) 19 Feb '24

19 Feb '24

Good work, green light from me at last! :-) -- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/364#note_61865

1 0

Re: [PATCH v12 0/2] MR364: vkd3d-shader/hlsl: Implement inverse trigonometry. - approved
by Giovanni Mascellani (＠giomasce) 19 Feb '24

19 Feb '24

This merge request was approved by Giovanni Mascellani. -- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/364

1 0

Re: [PATCH v12 0/2] MR364: vkd3d-shader/hlsl: Implement inverse trigonometry.
by Giovanni Mascellani (＠giomasce) 19 Feb '24

19 Feb '24

On Thu Feb 15 19:21:06 2024 +0000, Petrichor Park wrote: > Aha I think I get it. The todo indicate it's not yet implemented, but > I'm implementing it? Yes, precisely. -- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/364#note_61864

1 0

[PATCH v4 0/1] MR364: kernel32/tests: Test module refcounting with forwarded exports.
by Jinoh Kang (＠iamahuman) 19 Feb '24

19 Feb '24

Test module references created by resolving forwarded exports. The following diagram explains what happens in bug #52094 under the hood: ```mermaid graph TB subgraph state_00["Initial"] direction LR s00_ida[ida64.dll] ~~~ s00_idapy[idapython64.dll] ~~~ s00_py3[python3.dll] -. "(forwards to)" .-> s00_py311[python311.dll] end state_00 -. "1. <code>LoadLibrary("</code>configured Python version (e.g., python311.dll)<code>")</code>" .-> state_01 subgraph state_01["python311.dll loaded"] direction LR s01_ida[ida64.dll] ~~~ s01_idapy[idapython64.dll] ~~~ s01_py3[python3.dll] -. "(forwards to)" .-> s01_py311[python311.dll] s01_ida -- "dynamic ref" --> s01_py311 end state_01 -. "2. <code>LoadLibrary("</code>idapython64.dll<code>")</code>" .-> state_02 subgraph state_02["idapython64.dll loaded"] direction LR s02_ida[ida64.dll] -- "dynamic ref" --> s02_idapy[idapython64.dll] -- "static ref" --> s02_py3[python3.dll] -. "(forwards to)" .-> s02_py311[python311.dll] s02_ida -- "dynamic ref" --> s02_py311 s02_idapy -- "static forwarded ref" --> s02_py311 end state_02 -. "3. <code>FreeLibrary("</code>configured Python version (e.g., python311.dll)<code>")</code>" .-> state_03 subgraph state_03["python311.dll reference removed"] direction LR style s03_py311 color:#f00,stroke:#f00 s03_ida[ida64.dll] -- "dynamic ref" --> s03_idapy[idapython64.dll] -- "static ref" --> s03_py3[python3.dll] -. "(forwards to)" .-> s03_py311[python311.dll] s03_ida -. "<del>dynamic ref (deleted)</del>" .-> s03_py311 s03_idapy -- "static forwarded ref" --> s03_py311 end ``` On Windows, the static forwarded ref keeps `python3.dll` from being unloaded; however, Wine is missing this behavior, causing it to be unloaded and cause segfault immediately (since further initialization happens just after FreeLibrary). The tests aim to reproduce this condition. -- v4: kernel32/tests: Test module refcounting with forwarded exports. https://gitlab.winehq.org/wine/wine/-/merge_requests/364

4 10

[PATCH v6 0/3] MR3876: Zero-width character handling in GetTextExtentExPoint[AWI]
by Torge Matthies (＠tmatthies) 19 Feb '24

19 Feb '24

Certain characters are considered by GetTextExtentExPointA/W/I to have no width, even if they have a non-zero width and a shape in the font. This MR attempts to bring Wine's implementation of these functions closer to native behavior. One remaining difference is caused by GetGlyphIndicesA/W returning 0 instead of 0xffff for some characters, for some reason. This also affects the handling by GetTextExtentExPointA/W/I of affected characters. I have compared this with both Uniscribe and DWrite behavior and neither of them match this behavior, so it seems to be a peculiarity of these older functions. Remaining differences are probably caused by differences in the fallback fonts used when a character is missing from the selected font. Notably, on my system there doesn't seem to be a fallback font for `\t`/`\n`/`\r` that marks those characters as zero-width, and since applications are likely to depend on the metrics of those characters (I know of at least one), I have opted to explicitly make them zero-width in this MR, even though that is technically not what Windows does. -- v6: win32u: Handle glyphs that are marked by the font as zero-width in GetTextExtentExPoint[AWI]. win32u: Use maximum of (A, A+C, A+C+B) width for character fit test in GetTextExtentExPoint[AWI]. gdi32/tests: Add test for width of carriage return and line feed. https://gitlab.winehq.org/wine/wine/-/merge_requests/3876

3 4

Re: [PATCH v12 0/5] MR3572: mf: Make session_get_node_object() more robust.
by Zhiyi Zhang (＠zhiyi) 19 Feb '24

19 Feb '24

On Mon Feb 19 09:21:14 2024 +0000, Rémi Bernon wrote: > Fwiw this, and more specifically the test in > 6b853a9354dfe62df838b255b4af33b423e74642, triggers an assertion in > threadpool. It somehow doesn't make the test report a failure but I > think it can cause some spurious failures like in > https://gitlab.winehq.org/rbernon/wine/-/jobs/56730#L1220 which doesn't > seem related to the H264 decoder changes from the corresponding MR. I will take a look. Thanks. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3572#note_61850

1 0

Re: [PATCH v12 0/5] MR3572: mf: Make session_get_node_object() more robust.
by Rémi Bernon (＠rbernon) 19 Feb '24

19 Feb '24

Fwiw this, and more specifically the test in 6b853a9354dfe62df838b255b4af33b423e74642, triggers an assertion in threadpool. It somehow doesn't make the test report a failure but I think it can cause some spurious failures like in https://gitlab.winehq.org/rbernon/wine/-/jobs/56730#L1220 which doesn't seem related to the H264 decoder changes from the corresponding MR. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3572#note_61846

1 0

Re: [PATCH v2 0/2] MR5080: oleaut32: Use scientific notation only for larger numbers in VarBstrFromR[48].
by Rémi Bernon (＠rbernon) 19 Feb '24

19 Feb '24

Fwiw, this broke the tests on Linux (the pipeline was already failing here). -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5080#note_61845

1 0

[PATCH 0/1] MR5109: include: Annotate NdrGetBuffer with __WINE_(ALLOC_SIZE|MALLOC).
by Alex Henrie (＠alexhenrie) 19 Feb '24

19 Feb '24

It would be nice to annotate it with __WINE_DEALLOC(NdrFreeBuffer) too, but that causes a bunch of spurious -Wfree-nonheap-object warnings. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5109

2 1

[PATCH 0/5] MR5108: win32u: Don't assume that the primary adapter is always first.
by Rémi Bernon (＠rbernon) 19 Feb '24

19 Feb '24

In preparation for some virtual desktop refactor for display mode emulation (https://gitlab.winehq.org/wine/wine/-/merge_requests/5057) -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5108

2 5

[PATCH v14 0/191] MR648: Draft: vkd3d-shader: [Test] SM 6.
by Conor McCarthy (＠cmccarthy) 19 Feb '24

19 Feb '24

-- v14: vkd3d-shader/dxil: Bitcast the result of image atomic ops if necessary. vkd3d-shader/dxil: Emit an error for mesh, amplification and library shaders. vkd3d-shader/dxil: Support SV_ShadingRate. vkd3d-shader/dxil: Support the barycentrics register type. This merge request has too many patches to be relayed via email. Please visit the URL below to see the contents of the merge request. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/648

1 0

[PATCH v13 0/187] MR648: Draft: vkd3d-shader: [Test] SM 6.
by Conor McCarthy (＠cmccarthy) 19 Feb '24

19 Feb '24

-- v13: vkd3d-shader/spirv: Support 64-bit UAV atomics. vkd3d-shader/dxil: Implement DX intrinsic WaveQuadReadLaneAt. vkd3d-shader/dxil: Implement DX intrinsic WavePrefixOp. This merge request has too many patches to be relayed via email. Please visit the URL below to see the contents of the merge request. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/648

1 0

[PATCH v12 0/184] MR648: Draft: vkd3d-shader: [Test] SM 6.
by Conor McCarthy (＠cmccarthy) 19 Feb '24

19 Feb '24

-- v12: vkd3d-shader/dxil: Ignore "llvm.lifetime.*" intrinsics. vkd3d-shader/dxil: Implement DX intrinsic AnnotateHandle. vkd3d-shader/dxil: Implement DX intrinsic CreateHandleFromBinding. This merge request has too many patches to be relayed via email. Please visit the URL below to see the contents of the merge request. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/648

1 0

[PATCH v7 0/1] MR3096: ntdll: Add NtGetNextProcess stub.
by Alex Henrie (＠alexhenrie) 18 Feb '24

18 Feb '24

The stub is enough for TokenViewer.exe to start up and display its user interface. Based on a patch by Nikolay Sivov. Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=45119 -- v7: ntdll: Add NtGetNextProcess stub. https://gitlab.winehq.org/wine/wine/-/merge_requests/3096

2 1

[PATCH 0/1] MR5083: server: Try to retrieve the unix name on handles created from file descriptors.
by Gabriel Ivăncescu (＠insn) 18 Feb '24

18 Feb '24

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/5083

5 38

Re: [PATCH v2 0/2] MR5103: taskschd: Implement EndBoundary for IDailyTrigger
by Vijay Kiran Kamuju (＠infyquest) 18 Feb '24

18 Feb '24

I have implemented it as per the below commits, https://source.winehq.org/git/wine.git/commit/adad0705b0a68f47150527c9d7c33… https://source.winehq.org/git/wine.git/commitdiff/179d1ed75b55d6a71ba8a8c0c… I am checking where they are used. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5103#note_61822

1 0

Re: [PATCH v2 0/2] MR5103: taskschd: Implement EndBoundary for IDailyTrigger
by Zebediah Figura (＠zfigura) 18 Feb '24

18 Feb '24

> The same as StartBoundary. It is used later. When? -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5103#note_61821

1 0

Re: [PATCH v2 0/2] MR5103: taskschd: Implement EndBoundary for IDailyTrigger
by Vijay Kiran Kamuju (＠infyquest) 18 Feb '24

18 Feb '24

The same as StartBoundary. It is used later. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5103#note_61820

1 0

[PATCH v3 0/5] MR5099: shell32: Properly implement context menu verbs.
by Zebediah Figura (＠zfigura) 18 Feb '24

18 Feb '24

-- v3: shell32: Properly implement context menu verbs. https://gitlab.winehq.org/wine/wine/-/merge_requests/5099

2 6

Re: [PATCH v2 0/2] MR5103: taskschd: Implement EndBoundary for IDailyTrigger
by Zebediah Figura (＠zfigura) 18 Feb '24

18 Feb '24

Is this really "implemented"? The information is never used. Shouldn't we at least retain a FIXME in that case? -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5103#note_61813

1 0

Re: [PATCH v25 0/4] MR4661: gdiplus: Implement Gdiplus effects
by Vijay Kiran Kamuju (＠infyquest) 18 Feb '24

18 Feb '24

On Fri Jan 26 19:32:18 2024 +0000, Esme Povirk wrote: > I would expect this to crash. I will remove these tests -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4661#note_61808

1 0

[PATCH v2 0/3] MR5104: include: Add missing Task Scheduler Trigger definitions
by Vijay Kiran Kamuju (＠infyquest) 18 Feb '24

18 Feb '24

This is a prerequisite for stub implementation of IRegistrationTrigger interface, which is needed for https://bugs.winehq.org/show_bug.cgi?id=46773 -- v2: include: Added IEventTrigger declaration. https://gitlab.winehq.org/wine/wine/-/merge_requests/5104

2 3

[PATCH 0/3] MR5104: include: Add missing Task Scheduler Trigger definitions
by Vijay Kiran Kamuju (＠infyquest) 18 Feb '24

18 Feb '24

This is a prerequisite for stub implementation of IRegistrationTrigger interface, which is needed for https://bugs.winehq.org/show_bug.cgi?id=46773 -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5104

3 4

[PATCH 0/2] MR5103: taskschd: Implement EndBoundary for IDailyTrigger
by Vijay Kiran Kamuju (＠infyquest) 18 Feb '24

18 Feb '24

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/5103

2 2

[PATCH 0/2] MR5102: include: Move CPTABLEINFO and NLSTABLEINFO from winternl.h to ntnls.h.
by Alex Henrie (＠alexhenrie) 18 Feb '24

18 Feb '24

This is a relatively small step towards cleaning up the dumping ground that Wine's winternl.h has become. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5102

2 2

[PATCH v6 0/1] MR3096: ntdll: Add NtGetNextProcess stub.
by Alex Henrie (＠alexhenrie) 18 Feb '24

18 Feb '24

The stub is enough for TokenViewer.exe to start up and display its user interface. Based on a patch by Nikolay Sivov. Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=45119 -- v6: ntdll: Add NtGetNextProcess stub. https://gitlab.winehq.org/wine/wine/-/merge_requests/3096

3 2

Re: [PATCH v4 0/1] MR4461: include: Introduce debugstr_reftime and wine_dbgstr_reftime.
by Alex Henrie (＠alexhenrie) 18 Feb '24

18 Feb '24

At Nikolay's suggestion, I have pushed a new version that puts `debugstr_time` in wine/strmbase.h and does not rename it. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4461#note_61797

1 0

[PATCH 0/5] MR5099: shell32: Properly implement context menu verbs.
by Zebediah Figura (＠zfigura) 18 Feb '24

18 Feb '24

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/5099

3 6

[PATCH 0/1] MR5100: advapi32/tests: Use CRT allocation functions.
by Alex Henrie (＠alexhenrie) 18 Feb '24

18 Feb '24

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/5100

2 1

[PATCH 0/1] MR5097: po: Update Dutch translation.
by Floris Renaud (＠jkfloris) 17 Feb '24

17 Feb '24

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/5097

2 1

[PATCH v11 0/1] MR4672: include: Add msdelta.h header file.
by Vijay Kiran Kamuju (＠infyquest) 17 Feb '24

17 Feb '24

Add the header file needed for implementation. Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=56007 -- v11: include: Add msdelta header file. https://gitlab.winehq.org/wine/wine/-/merge_requests/4672

2 1

[PATCH 0/1] MR5091: server: Try to send asyncs to threads in APC wait.
by Paul Gofman (＠gofman) 17 Feb '24

17 Feb '24

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/5091

3 15

[PATCH v10 0/1] MR5020: kernelbase/file: implement CopyFile2
by Kartavya Vashishtha (＠kvashis) 17 Feb '24

17 Feb '24

copy implementation of CopyFileExW into CopyFile2, then implement CopyFileExW in terms of CopyFile2 should fix https://bugs.winehq.org/show_bug.cgi?id=55897, as Python does not use any new functionality nor the callback parameter from CopyFile2. I have not written extensive documentation since the original function didn't seem to have any; I can do that if recommended. I originally intended to implement the callback functionality in this MR as well, but realized that would be better as a follow-up. -- v10: kernelbase: Implement CopyFile2() https://gitlab.winehq.org/wine/wine/-/merge_requests/5020

4 4

[PATCH 0/3] MR5094: ntdll: Support generic xstate (part 2).
by Paul Gofman (＠gofman) 17 Feb '24

17 Feb '24

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/5094

3 4

Re: [PATCH v9 0/1] MR3368: where: Implement search with default options. - approved
by Alexandre Julliard (＠julliard) 16 Feb '24

16 Feb '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3368

1 0

Re: [PATCH v2 0/1] MR4865: include: Add some msvcrt declarations. - approved
by Alexandre Julliard (＠julliard) 16 Feb '24

16 Feb '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4865

1 0

Re: [PATCH v4 0/1] MR5088: powershell: Read input command from stdin. - approved
by Alexandre Julliard (＠julliard) 16 Feb '24

16 Feb '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5088

1 0

Re: [PATCH v2 0/5] MR5059: mfreadwrite/reader: Repeat pushing / pulling samples while it succeeds. - approved
by Alexandre Julliard (＠julliard) 16 Feb '24

16 Feb '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5059

1 0

Re: [PATCH v5 0/3] MR4987: ntdll: Support generic xstate (part 1). - approved
by Alexandre Julliard (＠julliard) 16 Feb '24

16 Feb '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4987

1 0

Re: [PATCH v2 0/5] MR5078: wined3d: Dynamic pipeline state, part 1. - approved
by Alexandre Julliard (＠julliard) 16 Feb '24

16 Feb '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5078

1 0

Re: [PATCH v4 0/6] MR5053: wined3d: FFP refactoring. - approved
by Alexandre Julliard (＠julliard) 16 Feb '24

16 Feb '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5053

1 0

Re: [PATCH v2 0/1] MR5087: kernel32/tests: Check if thread is suspended in debugger attachment tests. - approved
by Alexandre Julliard (＠julliard) 16 Feb '24

16 Feb '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5087

1 0

Re: [PATCH v2 0/1] MR5092: dinput/tests: Return void from test_winmm_joystick(). - approved
by Alexandre Julliard (＠julliard) 16 Feb '24

16 Feb '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5092

1 0

Re: [PATCH v2 0/5] MR5089: Explicitly request debug info in critical sections. - approved
by Alexandre Julliard (＠julliard) 16 Feb '24

16 Feb '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5089

1 0

[PATCH v9 0/1] MR5020: kernelbase/file: implement CopyFile2
by Kartavya Vashishtha (＠kvashis) 16 Feb '24

16 Feb '24

copy implementation of CopyFileExW into CopyFile2, then implement CopyFileExW in terms of CopyFile2 should fix https://bugs.winehq.org/show_bug.cgi?id=55897, as Python does not use any new functionality nor the callback parameter from CopyFile2. I have not written extensive documentation since the original function didn't seem to have any; I can do that if recommended. I originally intended to implement the callback functionality in this MR as well, but realized that would be better as a follow-up. -- v9: implement CopyFile2 https://gitlab.winehq.org/wine/wine/-/merge_requests/5020

3 4

[PATCH v3 0/13] MR626: vkd3d-utils: Constant buffer reflection without vkd3d-shader.
by Zebediah Figura (＠zfigura) 16 Feb '24

16 Feb '24

As per discussion in 606, plumbing constant buffer reflection through vkd3d-shader requires interface design and API documentation for an interface which is inherently quite specific to one format. Instead of wasting time on this interface, just implement RDEF parsing in vkd3d-utils itself. If we change our mind about this, we can always move the implementation to vkd3d-shader anyway. This does not copy the existing implementation from Wine, because: * Wine does not validate offsets; adding this changes the parsing code significantly; * Wine incorrectly handles types, deduplicating them into an rbtree; * Wine skips several fields which I have been able to find the purpose of. The implementation is not that complex to begin with, so reimplementing it from scratch is not much work. -- v3: tests: Add more tests for resource and struct RDEF contents. tests: Test constant and resource reflection via D3DReflect(). vkd3d-shader/tpf: Set the user-packed flag for sm5.0 resources as well. vkd3d-shader/tpf: Write the component count as the column count for structs. vkd3d-shader/tpf: Explicitly write the class and base type for non-numeric types. vkd3d-shader/tpf: Do not write structs with no numeric fields into the RDEF. vkd3d-shader/tpf: Do not write non-numeric struct fields into the RDEF. vkd3d-shader/hlsl: Allocate register reservations for structs as well. vkd3d-utils: Implement ID3D12ShaderReflectionType::GetMemberTypeByIndex(). vkd3d-utils: Implement ID3D12ShaderReflectionVariable::GetType(). vkd3d-utils: Implement ID3D12ShaderReflectionConstantBuffer::GetVariableByIndex(). vkd3d-utils: Parse the RD11 section. vkd3d-utils: Implement ID3D12ShaderReflection::GetConstantBufferByIndex(). https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/626

3 14

[PATCH v2 0/9] MR5055: winegstreamer: Support input video frame padding and cropping.
by Rémi Bernon (＠rbernon) 16 Feb '24

16 Feb '24

On the client side, frame aperture may be included or omitted. This can be used to include or drop the frame padding, and the VideoProcessor MFT supports it. On GStreamer side, we can only use the unpadded frame size in the caps, because this is how decoders work, and padding needs to be added as a property of the input/output video buffers. Then, frame size needs to be adjusted to be consistent between input and output, and any difference considered as extra padding to be added on one side or the other. -- v2: winegstreamer: Respect video format padding for input buffers too. winegstreamer: Exclude padding from wg_format video frame size. winegstreamer: Use video info stride in buffer meta rather than videoflip. winegstreamer: Use a new wg_video_buffer_pool class to add buffer meta. winegstreamer: Update the output_format when stream format changes. winegstreamer: Pass optional GstVideoInfo to read_transform_output_data. winegstreamer: Split read_transform_output_data in two helpers. winegstreamer: Introduce a new sample_needs_copy_buffer helper. winegstreamer: Introduce a new sample_set_flags_from_buffer helper. https://gitlab.winehq.org/wine/wine/-/merge_requests/5055

3 14

Re: [PATCH v9 0/1] MR4672: include: Add msdelta.h header file.
by Alexandre Julliard (＠julliard) 16 Feb '24

16 Feb '24

Alexandre Julliard (@julliard) commented about include/msdelta.h: > +#define DELTA_FILE_TYPE_CLI_I386 (DELTA_FILE_TYPE)0x00000010 > +#define DELTA_FILE_TYPE_CLI_AMD64 (DELTA_FILE_TYPE)0x00000020 > +#define DELTA_FILE_TYPE_CLI_ARM (DELTA_FILE_TYPE)0x00000040 > +#define DELTA_FILE_TYPE_CLI_ARM64 (DELTA_FILE_TYPE)0x00000080 > + > +#define DELTA_FILE_TYPE_SET_RAW_ONLY DELTA_FILE_TYPE_RAW > +#define DELTA_FILE_TYPE_SET_EXECUTABLES_1 DELTA_FILE_TYPE_RAW|DELTA_FILE_TYPE_I386| \ > + DELTA_FILE_TYPE_IA64|DELTA_FILE_TYPE_AMD64 > +#define DELTA_FILE_TYPE_SET_EXECUTABLES DELTA_FILE_TYPE_SET_EXECUTABLES_1 > +#define DELTA_FILE_TYPE_SET_EXECUTABLES_2 DELTA_FILE_TYPE_RAW|DELTA_FILE_TYPE_CLI_I386| \ > + DELTA_FILE_TYPE_IA64|DELTA_FILE_TYPE_CLI_AMD64| \ > + DELTA_FILE_TYPE_CLI_ARM > +#define DELTA_FILE_TYPE_SET_EXECUTABLES_3 DELTA_FILE_TYPE_RAW|DELTA_FILE_TYPE_CLI_I386| \ > + DELTA_FILE_TYPE_IA64|DELTA_FILE_TYPE_CLI_AMD64| \ > + DELTA_FILE_TYPE_CLI_ARM|DELTA_FILE_TYPE_CLI_ARM64 > +#define DELTA_FILE_TYPE_SET_EXECUTABLES_LATEST DELTA_FILE_TYPE_SET_EXECUTABLES_3 Most of these macros will need an extra pair of parentheses. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4672#note_61516

1 0

[PATCH 0/5] MR5059: mfreadwrite/reader: Repeat pushing / pulling samples while it succeeds.
by Rémi Bernon (＠rbernon) 16 Feb '24

16 Feb '24

First part of some refactor to implement the source reader pipeline. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5059

3 6

[PATCH v15 0/3] MR5081: dmime: Read through a MIDI file
by Yuxuan Shui (＠yshui) 16 Feb '24

16 Feb '24

Add a dummy track parser, that reads through MIDI tracks and events. To make sure we understand the file structure correctly, no actual tracks or events are generated. Also add test cases to make sure we read through a MIDI file correctly. This is skeleton of the actual MIDI parser. Pending on the merge of !4982 -- v15: dmime/tests: Improve error reporting from expect_track. dmime: Read through a MIDI file. dmime: Don't skip chunk for MIDI files. https://gitlab.winehq.org/wine/wine/-/merge_requests/5081

3 11

Re: [PATCH v11 0/6] MR569: tests/shader_runer: Support SRV buffers. - approved
by Zebediah Figura (＠zfigura) 16 Feb '24

16 Feb '24

This merge request was approved by Zebediah Figura. -- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/569

1 0

[PATCH v4 0/3] MR4987: ntdll: Support generic xstate (part 1).
by Paul Gofman (＠gofman) 16 Feb '24

16 Feb '24

This is a preparation for supporting more xstate features in the contexts. The remaining parts are: - support arbitrary xstate in usr1_handler(); - support arbitrary xstate in the server contexts (probably transferring only the present part); - support arbitrary xstate in context manipulation functions; - enabling more xstates in system.c and in user shared data. -- v4: ntdll: Don't hardcode xstate size in exception stack layout. ntdll: Don't hardcode xstate size in syscall frame. ntdll: Don't hardcode xstate feature mask. https://gitlab.winehq.org/wine/wine/-/merge_requests/4987

2 4

[PATCH v3 0/3] MR4987: ntdll: Support generic xstate (part 1).
by Paul Gofman (＠gofman) 16 Feb '24

16 Feb '24

This is a preparation for supporting more xstate features in the contexts. The remaining parts are: - support arbitrary xstate in usr1_handler(); - support arbitrary xstate in the server contexts (probably transferring only the present part); - support arbitrary xstate in context manipulation functions; - enabling more xstates in system.c and in user shared data. -- v3: ntdll: Don't hardcode xstate size in exception stack layout. ntdll: Don't hardcode xstate size in syscall frame. ntdll: Don't hardcode xstate feature mask. https://gitlab.winehq.org/wine/wine/-/merge_requests/4987

4 6

[PATCH v10 0/6] MR569: tests/shader_runer: Support SRV buffers.
by Francisco Casas (＠fcasas) 16 Feb '24

16 Feb '24

This allows to declare SRV buffers in the shader tests using `[buffer srv n]` blocks, and passing them to the different backends. Also, 1/2 includes a missing bit required to parse `Buffer<>` types in the HLSL compiler. This is a step towards supporting StructuredBuffer types in further patches. -- v10: vkd3d-shader/hlsl: Parse Buffer types. tests/shader-runner: Change probe directive syntax on shader_test files. tests/shader-runner: Change resource declaration syntax on shader_test files. tests/shader-runner: Support SRV buffers. tests/shader-runner: Separate resource_type into type and dimension. vkd3d-shader/hlsl: Record valid methods in object_methods[]. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/569

2 6

[PATCH v11 0/3] MR741: ntdll: Implement NtFlushProcessWriteBuffers.
by Torge Matthies (＠tmatthies) 16 Feb '24

16 Feb '24

Based on [a patch](https://www.winehq.org/mailman3/hyperkitty/list/wine-devel@winehq.or… by Jinoh Kang (@iamahuman) from February 2022. I removed the need for the event object and implemented fast paths for Linux. On macOS 10.14+ `thread_get_register_pointer_values` is called on every thread of the process. On Linux 4.14+ `membarrier(MEMBARRIER_CMD_GLOBAL_EXPEDITED, ...)` is used. On x86 Linux <= 4.13 and on other platforms `madvise(..., MADV_DONTNEED)` is used, which sends IPIs to all cores causing them to do a memory barrier. -- v11: ntdll: Add thread_get_register_pointer_values-based implementation of NtFlushProcessWriteBuffers. ntdll: Add sys_membarrier-based implementation of NtFlushProcessWriteBuffers. ntdll: Add MADV_DONTNEED-based implementation of NtFlushProcessWriteBuffers. https://gitlab.winehq.org/wine/wine/-/merge_requests/741

3 10

[PATCH v4 0/3] MR629: vkd3d-shader/dxil: Implement DX intrinsic GetDimensions.
by Conor McCarthy (＠cmccarthy) 16 Feb '24

16 Feb '24

-- v4: vkd3d-shader/dxil: Implement DX intrinsic GetDimensions. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/629

2 3

[PATCH 0/5] MR5078: wined3d: Dynamic pipeline state, part 1.
by Zebediah Figura (＠zfigura) 16 Feb '24

16 Feb '24

This includes viewport and scissor rect (core in 1.0), and depth/stencil state (comprised entirely of elements in EXT_extended_dynamic_state). Further patches add other dynamic state extensions and make other parts of the pipeline state dynamic. Theoretically dynamic state should be an improvement, giving greater freedom to the driver and hardware to optimize, and (perhaps more importantly) reducing the time needed to look up and compile new pipeline states. In practice I haven't observed a clear and measureable difference in either performance or stutter; however, my testing has been extremely scarce. Note: This patch series in particular introduces a new validation warning which prints on almost every draw. The warning is described at [1]. Similar warnings are triggered by future patches making other parts of the pipeline state dynamic. An unfortunately internal Khronos discussion has determined that the warning is undesirable, and there is currently motion to adjust the specification accordingly; however, the validation layers have not yet been adjusted. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5078

4 7

Re: [PATCH v5 0/2] MR583: vkd3d-shader/dxil: SRV/UAV support part 2.
by Giovanni Mascellani (＠giomasce) 16 Feb '24

16 Feb '24

Giovanni Mascellani (@giomasce) commented about libs/vkd3d-shader/dxil.c: > [DX_LEGACY_F32TOF16 ] = {"i", "f", sm6_parser_emit_dx_unary}, > [DX_LOAD_INPUT ] = {"o", "ii8i", sm6_parser_emit_dx_load_input}, > [DX_LOG ] = {"g", "R", sm6_parser_emit_dx_unary}, > + [DX_RAW_BUFFER_LOAD ] = {"o", "Hii8i", sm6_parser_emit_dx_raw_buffer_load}, I just realized that the last parameter is never read. Is that intended? What is supposed to be there? Maybe you could add a comment in the code to explain this? Apparently something similar happens for `DX_LOAD_INPUT` too and maybe other DX opcodes. -- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/583#note_61454

1 0

[PATCH v3 0/6] MR5053: wined3d: FFP refactoring.
by Zebediah Figura (＠zfigura) 16 Feb '24

16 Feb '24

The state table, as may have been described elsewhere, is not very friendly to modern CPUs (due to its indirect calls). Additionally, interdependencies between states are often more obscure (or at least harder to account for) than they might be with a linear function. Hence, we'd like to transform the table into a linear function, with "dirty" state guarding explicitly spelled out. For the FFP tables, the approach I've taken to achieve this is to gradually move states out of the table and into the existing vp_enable() and fp_enable() functions, eventually making those functions the aforementioned single linear functions. -- v3: wined3d/arb: Move fragment program compilation from fragment_prog_arbfp() to arbfp_apply_draw_state(). wined3d: Pass a non-const wined3d_context pointer to the FFP *_apply_draw_state() methods. wined3d: Pass a wined3d_state pointer to the vp_enable() and fp_enable() methods. wined3d: Introduce a separate fp_disable() method. wined3d: Introduce a separate vp_disable() method. wined3d: Merge shader_load_constants() into shader_select(). https://gitlab.winehq.org/wine/wine/-/merge_requests/5053

3 7

[PATCH v4 0/6] MR5066: server: Implement input desktop and fix rawinput message dispatch.
by Rémi Bernon (＠rbernon) 16 Feb '24

16 Feb '24

-- v4: server: Enumerate desktop processes for rawinput messages. server: Keep a list of threads connected to each desktop. server: Send hardware input to the visible input desktop. server: Keep track of the winstation input desktop. win32u: Introduce new NtUserSwitchDesktop syscall stub. user32/tests: Run in-desktop tests from a new thread. https://gitlab.winehq.org/wine/wine/-/merge_requests/5066

3 8

[PATCH v3 0/3] MR629: vkd3d-shader/dxil: Implement DX intrinsic GetDimensions.
by Conor McCarthy (＠cmccarthy) 16 Feb '24

16 Feb '24

-- v3: vkd3d-shader/dxil: Implement DX intrinsic GetDimensions. vkd3d-shader/dxil: Move the resource kind helper functions up. vkd3d-shader/spirv: Introduce a sample info flag value for a scalar uint dst parameter. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/629

3 5

[PATCH 0/5] MR5089: Explicitly request debug info in critical sections.
by Paul Gofman (＠gofman) 16 Feb '24

16 Feb '24

See https://gitlab.winehq.org/wine/wine/-/merge_requests/5071 . -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5089

3 6

[PATCH 0/1] MR5092: dinput/tests: Return void from test_winmm_joystick().
by Zebediah Figura (＠zfigura) 16 Feb '24

16 Feb '24

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/5092

3 2

[PATCH v2 0/3] MR629: vkd3d-shader/dxil: Implement DX intrinsic GetDimensions.
by Conor McCarthy (＠cmccarthy) 16 Feb '24

16 Feb '24

-- v2: vkd3d-shader/dxil: Implement DX intrinsic GetDimensions. vkd3d-shader/dxil: Move the resource kind helper functions up. vkd3d-shader/spirv: Introduce a sample info flag value for a scalar uint dst parameter. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/629

3 11

[PATCH 0/5] MR5055: winegstreamer: Support input video frame padding and cropping.
by Rémi Bernon (＠rbernon) 16 Feb '24

16 Feb '24

On the client side, frame aperture may be included or omitted. This can be used to include or drop the frame padding, and the VideoProcessor MFT supports it. On GStreamer side, we can only use the unpadded frame size in the caps, because this is how decoders work, and padding needs to be added as a property of the input/output video buffers. Then, frame size needs to be adjusted to be consistent between input and output, and any difference considered as extra padding to be added on one side or the other. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5055

3 7

[PATCH v11 0/183] MR648: Draft: vkd3d-shader: [Test] SM 6.
by Conor McCarthy (＠cmccarthy) 16 Feb '24

16 Feb '24

-- v11: vkd3d-shader/dxil: Implement DX intrinsic AnnotateHandle. vkd3d-shader/dxil: Implement DX intrinsic CreateHandleFromBinding. This merge request has too many patches to be relayed via email. Please visit the URL below to see the contents of the merge request. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/648

1 0

[PATCH v10 0/181] MR648: Draft: vkd3d-shader: [Test] SM 6.
by Conor McCarthy (＠cmccarthy) 16 Feb '24

16 Feb '24

-- v10: vkd3d-shader/dxil: Also set the result type for cast to minimum-precision. vkd3d-shader/dxil: Emit a minimum 4-byte stride for minimum-precision TGSMs. vkd3d-shader/dxil: Handle resource descriptor additional tag/value pairs. This merge request has too many patches to be relayed via email. Please visit the URL below to see the contents of the merge request. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/648

1 0

[PATCH v3 0/6] MR5066: server: Implement input desktop and fix rawinput message dispatch.
by Rémi Bernon (＠rbernon) 16 Feb '24

16 Feb '24

-- v3: server: Enumerate desktop processes for rawinput messages. server: Keep a list of threads connected to each desktop. server: Send hardware input to the visible input desktop. server: Keep track of the winstation input desktop. win32u: Introduce new NtUserSwitchDesktop syscall stub. user32/tests: Run in-desktop tests from a new thread. https://gitlab.winehq.org/wine/wine/-/merge_requests/5066

3 8

[PATCH v9 0/6] MR569: tests/shader_runer: Support SRV buffers.
by Francisco Casas (＠fcasas) 16 Feb '24

16 Feb '24

This allows to declare SRV buffers in the shader tests using `[buffer srv n]` blocks, and passing them to the different backends. Also, 1/2 includes a missing bit required to parse `Buffer<>` types in the HLSL compiler. This is a step towards supporting StructuredBuffer types in further patches. -- v9: vkd3d-shader/hlsl: Parse Buffer types. tests/shader-runner: Change probe directive syntax on shader_test files. tests/shader-runner: Change resource declaration syntax on shader_test files. tests/shader-runner: Support SRV buffers. tests/shader-runner: Separate resource_type into type and dimension. vkd3d-shader/hlsl: Record valid methods in object_methods[]. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/569

3 12

Re: [PATCH v2 0/1] MR653: tests: Disable buffering of stdout. - approved
by Alexandre Julliard (＠julliard) 15 Feb '24

15 Feb '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/653

1 0

Re: [PATCH v2 0/1] MR652: vkd3d-shader/hlsl: Parse rasteriser-ordered view types. - approved
by Alexandre Julliard (＠julliard) 15 Feb '24

15 Feb '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/652

1 0

Re: [PATCH v5 0/3] MR608: vkd3d-shader/hlsl: Lower casts from/to ints for SM1. - approved
by Alexandre Julliard (＠julliard) 15 Feb '24

15 Feb '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/608

1 0

Re: [PATCH v7 0/4] MR627: vkd3d: Implement ID3D12Resource2. - approved
by Alexandre Julliard (＠julliard) 15 Feb '24

15 Feb '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/627

1 0

Re: [PATCH v5 0/6] MR5074: wininet: Improve proxy configuration reading and writing (part 2). - approved
by Alexandre Julliard (＠julliard) 15 Feb '24

15 Feb '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5074

1 0

2025

2024

2023

2022

wine-gitlab