- wine-gitlab - winehq.org

Re: [PATCH v2 0/2] MR4988: msvcrt/tests: Add sprintf tests. - approved
by Alexandre Julliard (＠julliard) 01 Feb '24

01 Feb '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4988

1 0

Re: [PATCH v2 0/1] MR4995: jsproxy: Don't ignore hostname and url length in InternetGetProxyInfo. - approved
by Alexandre Julliard (＠julliard) 01 Feb '24

01 Feb '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4995

1 0

Re: [PATCH v25 0/2] MR4822: ntdll: Fix: Use pagesize alignment if MEM_REPLACE_PLACEHOLDER is set in flags of NtMapViewOfSection(Ex) - approved
by Alexandre Julliard (＠julliard) 01 Feb '24

01 Feb '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4822

1 0

Re: [PATCH v3 0/2] MR4966: winebuild: On macOS, search for tools un-prefixed as a last resort. - approved
by Alexandre Julliard (＠julliard) 01 Feb '24

01 Feb '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4966

1 0

Re: [PATCH v2 0/6] MR4990: winevulkan: Return VK_ERROR_SURFACE_LOST_KHR for invalid windows. - approved
by Alexandre Julliard (＠julliard) 01 Feb '24

01 Feb '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4990

1 0

Re: [PATCH v2 0/2] MR4989: oleaut32/tests: Add tests for VarBstrFromR4. - approved
by Alexandre Julliard (＠julliard) 01 Feb '24

01 Feb '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4989

1 0

[PATCH 0/1] MR4991: d3d10/effect: Clarify constant buffer flags field meaning.
by Nikolay Sivov (＠nsivov) 01 Feb '24

01 Feb '24

It makes more sense to have it matching fx_5_0 format, which uses the same flag for TBUFFER case, and also keeps 'single' modifier in there. This modifier is ignored on fx_4_x, so it's only needed to be implemented in the compiler. Signed-off-by: Nikolay Sivov <nsivov(a)codeweavers.com> -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4991

3 4

[PATCH 0/1] MR4993: wbemprox: Reimplement LIKE.
by Arek Hiler (＠ivyl) 01 Feb '24

01 Feb '24

Current implementation handles correctly % only at the end of the string. Nothing else matches. The new implementation while naïve and recursive handles both _ and * correctly. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4993

3 5

[PATCH 0/1] MR5003: shcore: Add stub for RegisterScaleChangeNotifications.
by Louis Lenders (＠xe) 01 Feb '24

01 Feb '24

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=56244 -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5003

2 1

[PATCH 0/5] MR4981: Playback of wave tracks with loops.
by eric pouech (＠epo) 01 Feb '24

01 Feb '24

This serie mainly tackles the playback of wave tracks with loops. Current code had to be improved as: - loop playback doesn't require setting the loop start/end points: leaving them at 0 mean playing the whole segment, - moreover, the length (at least for wave tracks) of the segment is not used. Instead, the duration of stamped/posted tracks is used instead. - even forcing a length on segment isn't taken into account (tested locally, but not included in the current tests). - implemented it by creating the graph internal to segment state and gathering relevant information on the fly. There's no indication it's done this exact way on native, but at least tests for time of track playback are identical. Notes: - only changed the track waves, future work will require equivalent testings at least on MIDI sequences. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4981

3 6

[PATCH v3 0/2] MR4985: windows.globalization: Add IIterable_HSTRING impl to IVectorView_HSTRING.
by Helix Graziani (＠TornadoCookie) 01 Feb '24

01 Feb '24

Fixes https://bugs.winehq.org/show_bug.cgi?id=55167. -- v3: windows.globalization: Add IIterable_HSTRING impl from windows.media to IVectorView_HSTRING. https://gitlab.winehq.org/wine/wine/-/merge_requests/4985

3 3

[PATCH 0/1] MR4998: ntdll/tests: Fix test_user_shared_data() for a more generic set of present features.
by Paul Gofman (＠gofman) 01 Feb '24

01 Feb '24

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/4998

2 1

[PATCH 0/1] MR4996: ntdll: Assume process-private futexes are always present on Linux.
by Brendan Shanks (＠bshanks) 01 Feb '24

01 Feb '24

This bumps the minimum Linux kernel requirement to 2.6.22 (released in July 2007). -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4996

2 1

[PATCH 0/2] MR4988: msvcrt/tests: Add sprintf tests.
by Daniel Lehman (＠dlehman25) 01 Feb '24

01 Feb '24

VarBstrFrom* calls into msvcrt but oleaut32's string representation differs slightly these tests show that msvcrt behaves as expected and the difference is in oleaut32 -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4988

3 3

[PATCH 0/1] MR4995: jsproxy: Don't ignore hostname and url length in InternetGetProxyInfo.
by Piotr Caban (＠piotr) 01 Feb '24

01 Feb '24

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/4995

2 1

[PATCH 0/4] MR4994: Extend supported file formats in SymSrvGetFileIndexInfo().
by eric pouech (＠epo) 01 Feb '24

01 Feb '24

This serie mainly tests and implement support for SymSrvGetFileIndexInfo() on a few more file formats. - .dbg: with test and implementation, - .pdb (JG format): This format has been replaced by the DS format for more than 25 years, so I didn't bother writting tests for generating such files (implementation has been tested manually against some existing samples). -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4994

2 4

[PATCH v11 0/1] MR4940: bug #56065 - add stub for GetAnycastIpAddressTable()
by Rastislav Stanik (＠rastos) 01 Feb '24

01 Feb '24

for details see https://bugs.winehq.org/show_bug.cgi?id=56065 This change adds an implementation of Win32 API function GetAnycastIpAddressTable() that is used by Adoptium OpenJDK 21 and later to initialize Secure Random Generator. This implementation does not return real information, it just says "no entries found". -- v11: iphlpapi: Add stub for GetAnycastIpAddressTable(). https://gitlab.winehq.org/wine/wine/-/merge_requests/4940

2 2

[PATCH v2 0/4] MR616: tests: Improvements for SM1 testing.
by Francisco Casas (＠fcasas) 01 Feb '24

01 Feb '24

This is the first part of !608, which I decided to separate to ease review. It consists of improvements to SM1 testing, mainly: - Correctly passing int and bool uniforms as IEEE 754 floats to SM1 profiles. - The introduction of the "only" qualifier to avoid abusing `[require]` blocks in case tests retrieve different results for different shader models. - Allowing some of the tests we already have for SM4/SM6 to run in SM1 after those improvements. -- v2: tests: Remove [require] directives for tests that use int and bool uniforms. tests/shader-runner: Introduce "if" qualifier. tests: Don't ignore SM1 on a non-const-indexing.shader_test test. tests/vkd3d-shader: Set uninitialized uniforms to zero. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/616

3 9

[PATCH v5 0/6] MR607: vkd3d-shader/ir: Introduce a simple CFG structurizer.
by Giovanni Mascellani (＠giomasce) 01 Feb '24

01 Feb '24

This goes atop !598 and !603. -- v5: vkd3d-shader/ir: Introduce a simple control flow graph structurizer. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/607

2 7

[PATCH 0/1] MR624: vkd3d: Introduce a debug helper for CPU descriptor handles.
by Henri Verbeet (＠hverbeet) 01 Feb '24

01 Feb '24

-- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/624

3 2

[PATCH 0/8] MR623: vkd3d: Avoid (U)LONGs in state.c and vkd3d_main.c.
by Henri Verbeet (＠hverbeet) 01 Feb '24

01 Feb '24

-- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/623

3 9

[PATCH v4 0/6] MR607: vkd3d-shader/ir: Introduce a simple CFG structurizer.
by Giovanni Mascellani (＠giomasce) 01 Feb '24

01 Feb '24

This goes atop !598 and !603. -- v4: vkd3d-shader/ir: Introduce a simple control flow graph structurizer. vkd3d-shader/ir: Handle PHI nodes when materializing SSA registers. vkd3d-shader/ir: Materialize SSA registers to temporaries. vkd3d-shader/spirv: Support bool TEMP registers. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/607

3 8

[PATCH v2 0/1] MR621: vkd3d: Use uint64_t for the size in vkd3d_gpu_va_allocator_allocate.
by Jacek Caban (＠jacek) 01 Feb '24

01 Feb '24

Avoids value truncation in 32-bit builds and fixes clang warning: ``` ../libs/vkd3d/libs/vkd3d/device.c:2157:14: warning: result of comparison of constant 4294967296 with expression of type 'size_t' (aka 'unsigned int') is always true [-Wtautological-constant-out-of-range-compare] if (size <= VKD3D_VA_SLAB_SIZE && allocator->free_slab) ~~~~ ^ ~~~~~~~~~~~~~~~~~~ ``` -- v2: vkd3d: Use uint64_t for the size in vkd3d_gpu_va_allocator_allocate. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/621

3 2

[PATCH v2 0/6] MR617: vkd3d: More device interface versions and GetResourceAllocationInfo1().
by Conor McCarthy (＠cmccarthy) 01 Feb '24

01 Feb '24

Mainly to implement `GetResourceAllocationInfo1()`, but we can introduce `Device7` without much risk of apps failing on unimplemented methods, and doing that separately would conflict with `GetResourceAllocationInfo1()`. -- v2: vkd3d: Implement GetResourceAllocationInfo1(). tests/d3d12: Add tests for GetResourceAllocationInfo1(). vkd3d: Support multiple descriptions in GetResourceAllocationInfo(). tests/d3d12: Test multiple descriptions in test_resource_allocation_info(). vkd3d: Add ID3D12Device7 interface stubs. vkd3d: Add ID3D12Device6 interface stub. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/617

3 7

[PATCH v5 0/2] MR601: vkd3d-shader/dxil: Implement DX intrinsic TextureLoad.
by Conor McCarthy (＠cmccarthy) 01 Feb '24

01 Feb '24

-- v5: vkd3d-shader/spirv: Emit a vector bitcast if necessary in spirv_compiler_emit_load_ssa_reg(). vkd3d-shader/dxil: Implement DX intrinsic TextureLoad. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/601

3 4

[PATCH v6 0/3] MR589: vkd3d-shader/dxil: Implement DX intrinsic SplitDouble.
by Conor McCarthy (＠cmccarthy) 01 Feb '24

01 Feb '24

-- v6: vkd3d-shader/dxil: Implement DX intrinsic SplitDouble. tests/shader-runner: Add an asuint() test to the 64-bit cast tests. tests/shader-runner: Support testing for integer pixel data. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/589

4 4

[PATCH 0/1] MR4992: Correctly derive the target from CC if it's set to an absolute path.
by Vibhav “vibhavp” Pant (＠vibhavp) 01 Feb '24

01 Feb '24

Use `basename` to ensure that the target string does not contain any directory components. Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=56279 -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4992

2 1

[PATCH v7 0/10] MR4946: user32: Rewrite the rawinput buffer tests with keyboard input, and fix GetRawInputBuffer.
by Rémi Bernon (＠rbernon) 01 Feb '24

01 Feb '24

-- v7: win32u: Get rid of the rawinput thread data and buffer. server: Fix rawinput buffer sizes and alignment on WoW64. server: Move rawinput message conversion from win32u. server: Stop using hardware_msg_data in rawinput_message. server: Combine HID usage page and usage together. server: Stop using union rawinput in hw_input_t. dinput/tests: Add more tests for HID rawinput buffer. dinput/tests: Add a helper to wait on HID input reads. user32/tests: Rewrite the rawinput buffer test with keyboard input. user32/tests: Run rawinput device tests in the separate desktop. https://gitlab.winehq.org/wine/wine/-/merge_requests/4946

3 12

[PATCH v6 0/10] MR4946: user32: Rewrite the rawinput buffer tests with keyboard input, and fix GetRawInputBuffer.
by Rémi Bernon (＠rbernon) 01 Feb '24

01 Feb '24

-- v6: win32u: Get rid of the rawinput thread data and buffer. server: Fix rawinput buffer sizes and alignment on WoW64. server: Move rawinput message conversion from win32u. server: Stop using hardware_msg_data in rawinput_message. server: Combine HID usage page and usage together. server: Stop using union rawinput in hw_input_t. dinput/tests: Add more tests for HID rawinput buffer. dinput/tests: Add a helper to wait on HID input reads. user32/tests: Rewrite the rawinput buffer test with keyboard input. user32/tests: Run rawinput device tests in the separate desktop. https://gitlab.winehq.org/wine/wine/-/merge_requests/4946

3 11

[PATCH 0/6] MR4990: winevulkan: Return VK_ERROR_SURFACE_LOST_KHR for invalid windows.
by Rémi Bernon (＠rbernon) 01 Feb '24

01 Feb '24

And get rid of then unnecessary user driver entries. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4990

2 7

[PATCH v5 0/10] MR4946: user32: Rewrite the rawinput buffer tests with keyboard input, and fix GetRawInputBuffer.
by Rémi Bernon (＠rbernon) 01 Feb '24

01 Feb '24

-- v5: win32u: Get rid of the rawinput thread data and buffer. server: Fix rawinput buffer sizes and alignment on WoW64. server: Move rawinput message conversion from win32u. server: Stop using hardware_msg_data in rawinput_message. server: Combine HID usage page and usage together. server: Stop using union rawinput in hw_input_t. dinput/tests: Add more tests for HID rawinput buffer. dinput/tests: Add a helper to wait on HID input reads. user32/tests: Rewrite the rawinput buffer test with keyboard input. user32/tests: Run rawinput device tests in the separate desktop. https://gitlab.winehq.org/wine/wine/-/merge_requests/4946

3 12

[PATCH v2 0/5] MR611: Draft: vkd3d-shader/dxil: Implement DX intrinsic TextureStore.
by Conor McCarthy (＠cmccarthy) 01 Feb '24

01 Feb '24

Goes atop !601. The last three commits belong to this MR. -- v2: vkd3d-shader/dxil: Implement DX intrinsic TextureStore. tests/shader-runner: Add shader model 6 texture UAV tests. tests/shader-runner: Emit descriptor ranges for consecutive resources. vkd3d-shader/spirv: Emit a vector bitcast if necessary in spirv_compiler_emit_load_ssa_reg(). vkd3d-shader/dxil: Implement DX intrinsic TextureLoad. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/611

2 5

[PATCH 0/2] MR4989: oleaut32/tests: Add tests for VarBstrFromR4.
by Daniel Lehman (＠dlehman25) 01 Feb '24

01 Feb '24

part of a larger series that will remove the todos VarBstrFrom* calls into msvcrt but oleaut32's string representation differs slightly -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4989

2 2

Re: [PATCH v2 0/1] MR620: vkd3d: Use debugstr_hresult() in d3d12_device_mark_as_removed(). - approved
by Alexandre Julliard (＠julliard) 31 Jan '24

31 Jan '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/620

1 0

Re: [PATCH v2 0/12] MR619: vkd3d: Avoid (U)LONGs in resource.c. - approved
by Alexandre Julliard (＠julliard) 31 Jan '24

31 Jan '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/619

1 0

Re: [PATCH v3 0/3] MR615: vkd3d-shader: Fix a couple of memory leaks. - approved
by Alexandre Julliard (＠julliard) 31 Jan '24

31 Jan '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/615

1 0

Re: [PATCH v2 0/2] MR614: vkd3d-shader/ir: Pass a struct vsir_program to shader_parser_get_src_params() and shader_parser_get_dst_params(). - approved
by Alexandre Julliard (＠julliard) 31 Jan '24

31 Jan '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/614

1 0

Re: [PATCH v2 0/1] MR613: vkd3d-shader: Use vkd3d_atomic_increment_u32() in vkd3d_shader_dump_blob(). - approved
by Alexandre Julliard (＠julliard) 31 Jan '24

31 Jan '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/613

1 0

Re: [PATCH v2 0/1] MR4980: win32u: Only queue a single IME update during ImeProcessKey. - approved
by Alexandre Julliard (＠julliard) 31 Jan '24

31 Jan '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4980

1 0

Re: [PATCH v2 0/2] MR4979: imm32/tests: Fix some spurious failures with Windows ko_KR IME. - approved
by Alexandre Julliard (＠julliard) 31 Jan '24

31 Jan '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4979

1 0

[PATCH v4 0/6] MR4906: mf,mfplat: Clang warning fixes.
by Jacek Caban (＠jacek) 31 Jan '24

31 Jan '24

-- v4: mfmediaengine: Avoid implicit casts in IMFAttributes_GetUINT32 calls. mfmediaengine/tests: Use MF_MEDIA_ENGINE_CANPLAY type in IMFMediaEngine_CanPlayType call. mfplat: Introduce media_type_get_uint32 helper. mfplat/tests: Use MF_ATTRIBUTE_TYPE type in IMFMediaType_GetItemType call. mfplat: Avoid implicit cast in IMFAttributes_GetUINT32 call. mf: Avoid implicit enum to int pointer casts. https://gitlab.winehq.org/wine/wine/-/merge_requests/4906

3 7

Re: [PATCH v2 0/2] MR4970: advapi32/tests: Add some more EventLog tests. - approved
by Alexandre Julliard (＠julliard) 31 Jan '24

31 Jan '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4970

1 0

Re: [PATCH v3 0/5] MR4978: vulkan-1/tests: Fix tests and add more with windows in various states. - approved
by Alexandre Julliard (＠julliard) 31 Jan '24

31 Jan '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4978

1 0

Re: [PATCH v4 0/1] MR4932: sapi: Create a new engine only when needed in ISpVoice. - approved
by Alexandre Julliard (＠julliard) 31 Jan '24

31 Jan '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4932

1 0

Re: [PATCH v5 0/1] MR4973: ntdll: Add stub for RtlGetDeviceFamilyInfoEnum. - approved
by Alexandre Julliard (＠julliard) 31 Jan '24

31 Jan '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4973

1 0

[PATCH v6 0/6] MR553: Draft: vkd3d-shader/d3d-asm: Dump the input and output signatures.
by Giovanni Mascellani (＠giomasce) 31 Jan '24

31 Jan '24

At some point I would like to have an assembler for TPF, so that it's easier to write and modify tests. This is a first step in that direction, fixing some kind of format for serializing signatures in the comment at the beginning of the assembler code. I'm not decided yet on all details, so take this as an RFC for the moment. -- v6: tests: Test emitting the signature. vkd3d-compiler: Add an option to emit the signature when disassembling. vkd3d-shader/d3d-asm: Support emitting the shader signature. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/553

2 6

[PATCH v5 0/6] MR553: Draft: vkd3d-shader/d3d-asm: Dump the input and output signatures.
by Giovanni Mascellani (＠giomasce) 31 Jan '24

31 Jan '24

At some point I would like to have an assembler for TPF, so that it's easier to write and modify tests. This is a first step in that direction, fixing some kind of format for serializing signatures in the comment at the beginning of the assembler code. I'm not decided yet on all details, so take this as an RFC for the moment. -- v5: tests: Test emitting the signature. vkd3d-compiler: Add an option to emit the signature when disassembling. vkd3d-shader/d3d-asm: Support emitting the shader signature. vkd3d-shader/d3d-asm: Refactor dumping a write mask to a dedicated function. vkd3d-shader/d3d-asm: Describe the ASM dialect with a bunch of flags instead of a plain enum. vkd3d-shader/d3d-asm: Do not make a copy of the buffer before returning it. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/553

2 6

[PATCH v24 0/2] MR4822: ntdll: Fix: Use pagesize alignment if MEM_REPLACE_PLACEHOLDER is set in flags of NtMapViewOfSection(Ex)
by Felix Münchhalfen (＠jfmu) 31 Jan '24

31 Jan '24

I had a bugreport here: https://bugs.winehq.org/show_bug.cgi?id=56161 This pull req fixes the bug that programs that do VirtualAlloc(placeholder)/VirtualFree(keep placeholder)/MapViewOfFile3(replace placeholder), do not run. Like the dotnet pe loader in .net 7 for example. It was not clear to me at first, because i didnt notice it on msdn, but the way that Dmitry Timoshkov "hacked" it in https://bugs.winehq.org/show_bug.cgi?id=56122 is actually (nearly) how it is supposed to happen according to msdn. From here: https://learn.microsoft.com/en-us/windows/win32/api/memoryapi/nf-memoryapi-… ![image](/uploads/58614927d38c15d4c23517aa5dc09d77/image.png) So thanks to Dmitry Timoshkov. If you are interested you could also look into the thing i mentioned in the bug report, that MapViewOfFile3 doesn't round down to 64k, but, i don't think this is a serious problem yet. Edit: I found out that under windows, the alignment constraint is not fully lifted but, it is only required to be pagesize aligned if MEM_REPLACE_PLACEHOLDER is present in the flags. To clarify why i want this in wine. The PE Loader of .net (see here https://github.com/dotnet/runtime/blob/f21dc6c3dceb6ea76bef73e2a026c770aaed…) does align with page size. Not with 64k. This breaks a .net 7 app during load up, that will execute otherwise just execute fine. -- v24: kernelbase: Added a test for MapViewOfFile3 with MEM_REPLACE_PLACEHOLDER https://gitlab.winehq.org/wine/wine/-/merge_requests/4822

2 2

[PATCH v22 0/2] MR4822: ntdll: Fix: Use pagesize alignment if MEM_REPLACE_PLACEHOLDER is set in flags of NtMapViewOfSection(Ex)
by Felix Münchhalfen (＠jfmu) 31 Jan '24

31 Jan '24

I had a bugreport here: https://bugs.winehq.org/show_bug.cgi?id=56161 This pull req fixes the bug that programs that do VirtualAlloc(placeholder)/VirtualFree(keep placeholder)/MapViewOfFile3(replace placeholder), do not run. Like the dotnet pe loader in .net 7 for example. It was not clear to me at first, because i didnt notice it on msdn, but the way that Dmitry Timoshkov "hacked" it in https://bugs.winehq.org/show_bug.cgi?id=56122 is actually (nearly) how it is supposed to happen according to msdn. From here: https://learn.microsoft.com/en-us/windows/win32/api/memoryapi/nf-memoryapi-… ![image](/uploads/58614927d38c15d4c23517aa5dc09d77/image.png) So thanks to Dmitry Timoshkov. If you are interested you could also look into the thing i mentioned in the bug report, that MapViewOfFile3 doesn't round down to 64k, but, i don't think this is a serious problem yet. Edit: I found out that under windows, the alignment constraint is not fully lifted but, it is only required to be pagesize aligned if MEM_REPLACE_PLACEHOLDER is present in the flags. To clarify why i want this in wine. The PE Loader of .net (see here https://github.com/dotnet/runtime/blob/f21dc6c3dceb6ea76bef73e2a026c770aaed…) does align with page size. Not with 64k. This breaks a .net 7 app during load up, that will execute otherwise just execute fine. -- v22: kernelbase: Added a test for MapViewOfFile3 with MEM_REPLACE_PLACEHOLDER https://gitlab.winehq.org/wine/wine/-/merge_requests/4822

2 3

[PATCH 0/1] MR621: vkd3d: Use uint64_t for the size in vkd3d_gpu_va_allocator_allocate.
by Jacek Caban (＠jacek) 31 Jan '24

31 Jan '24

Avoids value truncation in 32-bit builds and fixes clang warning: ``` ../libs/vkd3d/libs/vkd3d/device.c:2157:14: warning: result of comparison of constant 4294967296 with expression of type 'size_t' (aka 'unsigned int') is always true [-Wtautological-constant-out-of-range-compare] if (size <= VKD3D_VA_SLAB_SIZE && allocator->free_slab) ~~~~ ^ ~~~~~~~~~~~~~~~~~~ ``` -- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/621

2 1

[PATCH 0/4] MR4983: mfreadwrite/tests: Test source reader transforms with video processing attributes.
by Rémi Bernon (＠rbernon) 31 Jan '24

31 Jan '24

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/4983

3 6

Re: [PATCH v2 0/1] MR4985: windows.globalization: Add IIterable_HSTRING impl to IVectorView_HSTRING.
by Helix Graziani (＠TornadoCookie) 31 Jan '24

31 Jan '24

On Wed Jan 31 20:20:40 2024 +0000, Rémi Bernon wrote: > Fwiw there is already an implementation of this in > `dlls/windows.media.speech/vector.c`, you should probably copy the > relevant parts of the file there. Will do, had no idea that existed. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4985#note_59718

1 0

[PATCH v6 0/11] MR4982: Draft: Load and play MIDI
by Yuxuan Shui (＠yshui) 31 Jan '24

31 Jan '24

There are still some issues I need to fix, mainly around timing conversion between MIDI and dmusic. Right now MIDI files seem to be cut off before the end is reached. Please have a look at the general approach in the meantime, I need to know if this is the right way to do this or not. -- v6: debug dmusic: Don't stop instrument downloading early on failure. dmime: Create a band track for MIDI segments. dmband: Move band.c to dmusic dmband: Implement getting/setting GUID_BandParam on band tracks. https://gitlab.winehq.org/wine/wine/-/merge_requests/4982

3 14

[PATCH v3 0/6] MR2298: winewinrt: Introduce new WinRT common module.
by Rémi Bernon (＠rbernon) 31 Jan '24

31 Jan '24

The idea I have is to use this module to declare class stubs until there is a good reason to split them to dedicated modules. WinRT modules aren't usually loaded directly, and instead the registry is queried to figure which module to load for which class. This would help avoiding unnecessary proliferation of stub WinRT modules, while at the same time allowing to factor WinRT foundation code (such as vector / async, etc...) between the modules that seem to deserve to be implemented separately. The relevant classes could then be split out to dedicated modules on a as-needed basis, when they get fleshed out. -- v3: winewinrt: Factor IAsyncOperation<boolean> implementations. winewinrt: Factor IAsyncInfo implementations. winewinrt: Move Vector<HSTRING> from windows.media.speech. widl: Write C type names for function parameters. winewinrt: Factor Vector<IInspectable> implementations. winewinrt: Introduce new static library. https://gitlab.winehq.org/wine/wine/-/merge_requests/2298

5 12

[PATCH v5 0/10] MR4982: Draft: Load and play MIDI
by Yuxuan Shui (＠yshui) 31 Jan '24

31 Jan '24

There are still some issues I need to fix, mainly around timing conversion between MIDI and dmusic. Right now MIDI files seem to be cut off before the end is reached. Please have a look at the general approach in the meantime, I need to know if this is the right way to do this or not. -- v5: dmusic: Don't stop instrument downloading early on failure. dmime: Create a band track for MIDI segments. dmband: Move band.c to dmusic dmband: Implement getting/setting GUID_BandParam on band tracks. https://gitlab.winehq.org/wine/wine/-/merge_requests/4982

3 11

Re: [PATCH v2 0/1] MR4985: windows.globalization: Add IIterable_HSTRING impl to IVectorView_HSTRING.
by Rémi Bernon (＠rbernon) 31 Jan '24

31 Jan '24

Fwiw there is already an implementation of this in `dlls/windows.media.speech/vector.c`, you should probably copy the relevant parts of the file there. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4985#note_59714

1 0

[PATCH v4 0/10] MR4982: Draft: Load and play MIDI
by Yuxuan Shui (＠yshui) 31 Jan '24

31 Jan '24

There are still some issues I need to fix, mainly around timing conversion between MIDI and dmusic. Right now MIDI files seem to be cut off before the end is reached. Please have a look at the general approach in the meantime, I need to know if this is the right way to do this or not. -- v4: dmusic: Don't stop instrument downloading early on failure. dmime: Create a band track for MIDI segments. dmband: Move band.c to dmusic dmband: Implement setting GUID_BandParam on band tracks. dmime/test: Add test for getting band track from midi file. dmime: Implement IDirectMusicTrack_Play for MIDI tracks. dmime: Implement getting/setting TempoParam for MIDI tracks. dmime: Parse MIDI files. dmime: Add stubs for MIDI tracks https://gitlab.winehq.org/wine/wine/-/merge_requests/4982

3 11

[PATCH v3 0/9] MR4982: Draft: Load and play MIDI
by Yuxuan Shui (＠yshui) 31 Jan '24

31 Jan '24

There are still some issues I need to fix, mainly around timing conversion between MIDI and dmusic. Right now MIDI files seem to be cut off before the end is reached. Please have a look at the general approach in the meantime, I need to know if this is the right way to do this or not. -- v3: dmime: Create a band track for MIDI segments. dmband: Move band.c to dmusic dmband: Implement setting GUID_BandParam on band tracks. dmime/test: Add test for getting band track from midi file. dmime: Implement IDirectMusicTrack_Play for MIDI tracks. dmime: Implement getting/setting TempoParam for MIDI tracks. dmime: Parse MIDI files. dmime: Add stubs for MIDI tracks dmime/test: add MIDI loading test https://gitlab.winehq.org/wine/wine/-/merge_requests/4982

3 11

[PATCH 0/1] MR4976: tools: Implement strmake() using asprintf().
by Brendan Shanks (＠bshanks) 31 Jan '24

31 Jan '24

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/4976

2 2

[PATCH 0/5] MR616: tests: Improvements for SM1 testing.
by Francisco Casas (＠fcasas) 31 Jan '24

31 Jan '24

This is the first part of !608, which I decided to separate to ease review. It consists of improvements to SM1 testing, mainly: - Correctly passing int and bool uniforms as IEEE 754 floats to SM1 profiles. - The introduction of the "only" qualifier to avoid abusing `[require]` blocks in case tests retrieve different results for different shader models. - Allowing some of the tests we already have for SM4/SM6 to run in SM1 after those improvements. -- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/616

5 10

[PATCH 0/7] MR4986: mshtml: MessageEvent improvements and misc.
by Gabriel Ivăncescu (＠insn) 31 Jan '24

31 Jan '24

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/4986

3 8

[PATCH v10 0/5] MR3572: mf: Make session_get_node_object() more robust.
by Zhiyi Zhang (＠zhiyi) 31 Jan '24

31 Jan '24

It's possible that a state object pointer not in the topology node collection gets passed to session_get_node_object(). Instead of returning the last node when the object is not found, we should return a NULL so that the state of the last node is not changed by mistake. -- v10: mf/tests: Test IMFMediaSession::Start(). mf: Support seeking while a session is started. https://gitlab.winehq.org/wine/wine/-/merge_requests/3572

4 9

[PATCH v13 0/5] MR3103: server: Create and use a desktop shared mapping for GetCursorPos.
by Rémi Bernon (＠rbernon) 31 Jan '24

31 Jan '24

First part of Proton shared memory series. The full branch can be seen at https://gitlab.winehq.org/rbernon/wine/-/commits/mr/shared-memories. -- v13: user32: Use the desktop shared data for GetCursorPos(). server: Expose the desktop shared mapping to clients. server: Add a sequence number to the shared data. server: Move the cursor position and last change time to the shared data. server: Create a desktop shared mapping. https://gitlab.winehq.org/wine/wine/-/merge_requests/3103

3 17

[PATCH v2 0/7] MR4982: Draft: Load and play MIDI
by Yuxuan Shui (＠yshui) 31 Jan '24

31 Jan '24

There are still some issues I need to fix, mainly around timing conversion between MIDI and dmusic. Right now MIDI files seem to be cut off before the end is reached. Please have a look at the general approach in the meantime, I need to know if this is the right way to do this or not. -- v2: dmime: Synthesize a band track for MIDI segments. dmband: Implement setting GUID_BandParam on band tracks. dmime/test: Add test for getting band track from midi file. dmime/test: add MIDI loading test dmime: Implement getting tempo param for MIDI tracks. dmime: Parse MIDI files. dmime: Add stubs for MIDI tracks https://gitlab.winehq.org/wine/wine/-/merge_requests/4982

3 26

[PATCH 0/1] MR4985: windows.globalization: Add IIterable_HSTRING impl to IVectorView_HSTRING.
by Helix Graziani (＠TornadoCookie) 31 Jan '24

31 Jan '24

Fixes https://bugs.winehq.org/show_bug.cgi?id=55167. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4985

2 1

[PATCH v4 0/2] MR601: Draft: vkd3d-shader/dxil: Implement DX intrinsic TextureLoad.
by Conor McCarthy (＠cmccarthy) 31 Jan '24

31 Jan '24

Goes atop !583. The last two commits belong to this MR. -- v4: vkd3d-shader/spirv: Emit a vector bitcast if necessary in spirv_compiler_emit_load_ssa_reg(). vkd3d-shader/dxil: Implement DX intrinsic TextureLoad. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/601

3 4

[PATCH 0/7] MR4982: Draft: Load and play MIDI
by Yuxuan Shui (＠yshui) 31 Jan '24

31 Jan '24

There are still some issues I need to fix, mainly around timing conversion between MIDI and dmusic. Right now MIDI files seem to be cut off before the end is reached. Please have a look at the general approach in the meantime, I need to know if this is the right way to do this or not. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4982

3 9

[PATCH v3 0/6] MR4906: mf,mfplat: Clang warning fixes.
by Jacek Caban (＠jacek) 31 Jan '24

31 Jan '24

-- v3: mfmediaengine: Avoid implicit casts in IMFAttributes_GetUINT32 calls. mfmediaengine/tests: Use MF_MEDIA_ENGINE_CANPLAY type in IMFMediaEngine_CanPlayType call. mfplat: Introduce media_type_get_uint32 helper. mfplat/tests: Use MF_ATTRIBUTE_TYPE type in IMFMediaType_GetItemType call. mfplat: Avoid implicit cast in IMFAttributes_GetUINT32 call. mf: Avoid implicit enum to int pointer casts. https://gitlab.winehq.org/wine/wine/-/merge_requests/4906

3 10

[PATCH 0/1] MR4984: wineandroid.drv: fix incorrent path of device and init device in ANDROID_CreateDesktop
by Fan WenJie (＠fanwenjie) 31 Jan '24

31 Jan '24

Signed-off-by: Fan WenJie <fanwj(a)mail.ustc.edu.cn> -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4984

2 1

[PATCH v3 0/1] MR3460: ntdll: hook mmap and munmap on wow64 mode
by Fan WenJie (＠fanwenjie) 31 Jan '24

31 Jan '24

Signed-off-by: Fan WenJie <fanwj(a)mail.ustc.edu.cn> Hook mmap and munmap seem to be the only solution for drivers such as OpenGL to allocate over 32-bit address. For example, Fairy and Sword 4 has some render problems on master branch of wine. The patch can solve the problems. -- v3: wineandroid.drv: fix incorrent path of device and init device in ANDROID_CreateDesktop https://gitlab.winehq.org/wine/wine/-/merge_requests/3460

2 2

[PATCH v3 0/6] MR607: vkd3d-shader/ir: Introduce a simple CFG structurizer.
by Giovanni Mascellani (＠giomasce) 31 Jan '24

31 Jan '24

This goes atop !598 and !603. -- v3: vkd3d-shader/ir: Introduce a simple control flow graph structurizer. vkd3d-shader/ir: Handle PHI nodes when materializing SSA registers. vkd3d-shader/ir: Materialize SSA registers to temporaries. vkd3d-shader/spirv: Support bool TEMP registers. vkd3d-shader/spirv: Move bool casting helpers above register loading helpers. vkd3d-shader/dxil: Set the register before calling src_param_init_scalar(). https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/607

3 10

[PATCH 0/12] MR619: vkd3d: Avoid (U)LONGs in resource.c.
by Henri Verbeet (＠hverbeet) 31 Jan '24

31 Jan '24

-- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/619

3 13

[PATCH 0/1] MR620: vkd3d: Use debugstr_hresult() in d3d12_device_mark_as_removed().
by Henri Verbeet (＠hverbeet) 31 Jan '24

31 Jan '24

-- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/620

3 2

[PATCH 0/2] MR4979: imm32/tests: Fix some spurious failures with Windows ko_KR IME.
by Rémi Bernon (＠rbernon) 31 Jan '24

31 Jan '24

Still fails spuriously from time to time as the IME sometimes doesn't kick in, but hopefully less often. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4979

3 3

[PATCH 0/1] MR4980: win32u: Only queue a single IME update during ImeProcessKey.
by Rémi Bernon (＠rbernon) 31 Jan '24

31 Jan '24

If there's more than one IME update posted during ImeProcessKey we were queuing them all, although the IME will later only call ImeToAsciiEx once with the processed vkey / scan and leave other updates queued. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4980

2 1

[PATCH v2 0/3] MR615: vkd3d-shader: Fix a couple of memory leaks.
by Giovanni Mascellani (＠giomasce) 31 Jan '24

31 Jan '24

-- v2: vkd3d-shader/spirv: Free binary SPIR-V code (Valgrind). vkd3d-compiler: Free compilation options (Valgrind). https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/615

5 12

[PATCH 0/2] MR614: vkd3d-shader/ir: Pass a struct vsir_program to shader_parser_get_src_params() and shader_parser_get_dst_params().
by Henri Verbeet (＠hverbeet) 31 Jan '24

31 Jan '24

-- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/614

3 4

[PATCH 0/1] MR613: vkd3d-shader: Use vkd3d_atomic_increment_u32() in vkd3d_shader_dump_blob().
by Henri Verbeet (＠hverbeet) 31 Jan '24

31 Jan '24

-- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/613

3 3

[PATCH 0/6] MR617: vkd3d: More device interface versions and GetResourceAllocationInfo1().
by Conor McCarthy (＠cmccarthy) 31 Jan '24

31 Jan '24

Mainly to implement `GetResourceAllocationInfo1()`, but we can introduce `Device7` without much risk of apps failing on unimplemented methods, and doing that separately would conflict with `GetResourceAllocationInfo1()`. -- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/617

3 7

[PATCH v3 0/4] MR612: vkd3d-shader: Emit more debug info.
by Conor McCarthy (＠cmccarthy) 31 Jan '24

31 Jan '24

-- v3: vkd3d-shader/spirv: Emit line numbers if debugging info is not stripped. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/612

3 5

[PATCH v2 0/4] MR602: Draft: vkd3d-shader/dxil: Inverse trigonometry
by Conor McCarthy (＠cmccarthy) 31 Jan '24

31 Jan '24

With tests from !364, separated out from the HLSL changes there and updated. This MR can wait until 364 is upstream though. It is apparently unnecessary to match the SM4/5 implementation, since the AMD Windows results differ. The RADV results are a bit wrong, but Proton uses the SPIR-V GLSL extension instructions too, and no workarounds have been implemented there. -- v2: vkd3d-shader/spirv: Handle the ACOS, ASIN and ATAN instructions in spirv_compiler_emit_ext_glsl_instruction(). vkd3d-shader/dxil: Handle inverse trigonometric functions in sm6_parser_emit_dx_unary(). tests/shader-runner: Add tests for atan and atan2 trig intrinsics. tests/shader-runner: Add tests for acos and asin trig intrinsics. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/602

4 6

[PATCH v4 0/5] MR569: tests/shader_runer: Support SRV buffers.
by Francisco Casas (＠fcasas) 31 Jan '24

31 Jan '24

This allows to declare SRV buffers in the shader tests using `[buffer srv n]` blocks, and passing them to the different backends. Also, 1/2 includes a missing bit required to parse `Buffer<>` types in the HLSL compiler. This is a step towards supporting StructuredBuffer types in further patches. -- v4: tests/shader-runner: Change probe directive syntax on shader_test files. tests/shader-runner: Change resource declaration syntax on shader_test files. tests/shader_runner: Support SRV buffers. tests/shader-runner: Separate resource_type into type and dimension. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/569

3 8

[PATCH 0/1] MR4968: setupapi: Add stub for CM_Get_Device_Interface_PropertyW.
by Olivier F. R. Dierick (＠olivierfrdierick) 31 Jan '24

31 Jan '24

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=56265 -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4968

3 3

[PATCH v10 0/1] MR4940: bug #56065 - add stub for GetAnycastIpAddressTable()
by Rastislav Stanik (＠rastos) 31 Jan '24

31 Jan '24

for details see https://bugs.winehq.org/show_bug.cgi?id=56065 This change adds an implementation of Win32 API function GetAnycastIpAddressTable() that is used by Adoptium OpenJDK 21 and later to initialize Secure Random Generator. This implementation does not return real information, it just says "no entries found". -- v10: iphlpapi: Add stub for GetAnycastIpAddressTable(). https://gitlab.winehq.org/wine/wine/-/merge_requests/4940

3 3

[PATCH v3 0/1] MR4932: sapi: Create a new engine only when needed in ISpVoice.
by Shaun Ren (＠shaunren) 31 Jan '24

31 Jan '24

Instead of creating the TTS voice engine directly in SetVoice, we save the specified voice token, and only create them in speak_proc when necessary. -- v3: sapi: Create a new engine only when needed in ISpVoice. https://gitlab.winehq.org/wine/wine/-/merge_requests/4932

3 2

[PATCH 0/5] MR4978: vulkan-1/tests: Fix tests and add more with windows in various states.
by Rémi Bernon (＠rbernon) 31 Jan '24

31 Jan '24

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/4978

3 6

[PATCH v2 0/5] MR4978: vulkan-1/tests: Fix tests and add more with windows in various states.
by Rémi Bernon (＠rbernon) 31 Jan '24

31 Jan '24

-- v2: vulkan-1/tests: Test VK_KHR_win32_surface WSI with swapchain functions. vulkan-1/tests: Add more VK_KHR_win32_surface surface formats tests. vulkan-1/tests: Test VK_KHR_win32_surface with windows in various states. vulkan-1/tests: Create surface and device before calling test_null_hwnd. vulkan-1/tests: Enable VK_VERSION_1_1 as requested by validation layers. https://gitlab.winehq.org/wine/wine/-/merge_requests/4978

2 6

[PATCH v2 0/4] MR612: vkd3d-shader: Emit more debug info.
by Conor McCarthy (＠cmccarthy) 31 Jan '24

31 Jan '24

-- v2: vkd3d-shader/spirv: Emit line numbers if debugging info is not stripped. vkd3d-compiler: Add a command line option for instruction numbering. vkd3d-shader/d3d-asm: Enable instruction numbering for trace output. vkd3d-shader/d3d-asm: Add a formatting compile option for instruction numbering. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/612

2 4

[PATCH 0/2] MR618: vkd3d-shader/dxil: Hyperbolic trigonometry.
by Conor McCarthy (＠cmccarthy) 31 Jan '24

31 Jan '24

-- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/618

2 2

[PATCH v9 0/2] MR364: vkd3d-shader/hlsl: Implement inverse trigonometry.
by Petrichor Park (＠petrathekat) 31 Jan '24

31 Jan '24

Implements asin, acos, atan, and atan2. Also includes some tests in a new test file. One possible problem here is that I'm not sure how to test what Microsoft's atan and atan2 outputs are in boundary cases like atan2(1, 0). I've made the test suites adhere with the calculator program I've been using (Qalculate, which I assume is using libc's atan2). Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=55154 -- v9: vkd3d-shader/hlsl: Implement atan and atan2. vkd3d-shader/hlsl: Implement acos and asin trig intrinsics. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/364

2 2

[PATCH 0/1] MR4943: mfreadwrite: Replace presentation clock with clock state sink for writer.
by Ziqing Hui (＠zhui) 31 Jan '24

31 Jan '24

There is no need to store a presentation clock object. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4943

3 12

[PATCH v20 0/2] MR4822: ntdll: Fix: Use pagesize alignment if MEM_REPLACE_PLACEHOLDER is set in flags of NtMapViewOfSection(Ex)
by Felix Münchhalfen (＠jfmu) 31 Jan '24

31 Jan '24

I had a bugreport here: https://bugs.winehq.org/show_bug.cgi?id=56161 This pull req fixes the bug that programs that do VirtualAlloc(placeholder)/VirtualFree(keep placeholder)/MapViewOfFile3(replace placeholder), do not run. Like the dotnet pe loader in .net 7 for example. It was not clear to me at first, because i didnt notice it on msdn, but the way that Dmitry Timoshkov "hacked" it in https://bugs.winehq.org/show_bug.cgi?id=56122 is actually (nearly) how it is supposed to happen according to msdn. From here: https://learn.microsoft.com/en-us/windows/win32/api/memoryapi/nf-memoryapi-… ![image](/uploads/58614927d38c15d4c23517aa5dc09d77/image.png) So thanks to Dmitry Timoshkov. If you are interested you could also look into the thing i mentioned in the bug report, that MapViewOfFile3 doesn't round down to 64k, but, i don't think this is a serious problem yet. Edit: I found out that under windows, the alignment constraint is not fully lifted but, it is only required to be pagesize aligned if MEM_REPLACE_PLACEHOLDER is present in the flags. To clarify why i want this in wine. The PE Loader of .net (see here https://github.com/dotnet/runtime/blob/f21dc6c3dceb6ea76bef73e2a026c770aaed…) does align with page size. Not with 64k. This breaks a .net 7 app during load up, that will execute otherwise just execute fine. -- v20: kernelbase: Added a test for MapViewOfFile3 with MEM_REPLACE_PLACEHOLDER https://gitlab.winehq.org/wine/wine/-/merge_requests/4822

3 3

Re: [PATCH v19 0/2] MR4822: ntdll: Fix: Use pagesize alignment if MEM_REPLACE_PLACEHOLDER is set in flags of NtMapViewOfSection(Ex)
by Felix Münchhalfen (＠jfmu) 31 Jan '24

31 Jan '24

On Wed Jan 31 00:51:30 2024 +0000, Alexandre Julliard wrote: > The tests fail on 64-bit: > ``` > ../wine/tools/runtest -q -P wine -T . -M kernelbase.dll -p > dlls/kernelbase/tests/x86_64-windows/kernelbase_test.exe process && > touch dlls/kernelbase/tests/x86_64-windows/process.ok > process.c:156: Test failed: VirtualFree failed to split the placeholder 487 > process.c:160: Test failed: MapViewOfFile3 did not map the file mapping 87 > process.c:163: Test failed: UnmapViewOfFile failed 487 > process.c:185: Test failed: VirtualFree of remaining region failed > make: *** [Makefile:91467: > dlls/kernelbase/tests/x86_64-windows/process.ok] Error 4 > ``` Oh! To my shame i must admit i tested this with wine-staging patches applied. There is one patch in there that modifies how views are handled. But anyways, i fixed the tests now, and i believe using VirtualFree in that way is more correct. I was just curious before, if it would be possible to split a big placeholder allocation into two, with a hole in the middle. But when i think about it, i dont think that this is how it's supposed to work. You would rather have to start chewing off a big placeholder from the start to the end. Please test again now. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4822#note_59565

1 0

Re: [PATCH v5 0/2] MR4964: winebus.sys: Fix Unity crashing with certain input devices connected. - approved
by Alexandre Julliard (＠julliard) 30 Jan '24

30 Jan '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4964

1 0

Re: [PATCH v2 0/3] MR4969: glu32: Return GL_OUT_OF_MEMORY from gluScaleImage if no context. - approved
by Alexandre Julliard (＠julliard) 30 Jan '24

30 Jan '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4969

1 0

Re: [PATCH v3 0/1] MR4933: winegstreamer: Ask GStreamer to stop messing with signal handlers. - approved
by Alexandre Julliard (＠julliard) 30 Jan '24

30 Jan '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4933

1 0

Re: [PATCH v2 0/1] MR4975: winedump: Sync demangling code with msvcrt. - approved
by Alexandre Julliard (＠julliard) 30 Jan '24

30 Jan '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4975

1 0

Re: [PATCH v2 0/1] MR4974: winex11.drv: Translate whole_rect to x11 root coordinates in set_size_hints(). - approved
by Alexandre Julliard (＠julliard) 30 Jan '24

30 Jan '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4974

1 0

Re: [PATCH v4 0/1] MR4965: cfgmgr32: Add CM_Get_Device_Interface_PropertyW stub. - approved
by Alexandre Julliard (＠julliard) 30 Jan '24

30 Jan '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4965

1 0

Re: [PATCH v2 0/1] MR4972: mfplat/tests: Skip tests that require d3d9 support. - approved
by Alexandre Julliard (＠julliard) 30 Jan '24

30 Jan '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4972

1 0

2025

2024

2023

2022

wine-gitlab