- wine-gitlab - winehq.org

[PATCH v3 0/1] MR7870: kernelbase: fix racing condition in GlobalMemoryStatusEx()
by Rastislav Stanik (＠rastos) 21 Apr '25

21 Apr '25

use a critical section to guard access to local static variable with cached information Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=58082 -- v3: kernelbase: fix racing condition in GlobalMemoryStatusEx() https://gitlab.winehq.org/wine/wine/-/merge_requests/7870

3 3

[PATCH v2 0/1] MR7870: kernelbase: fix racing condition in GlobalMemoryStatusEx()
by Rastislav Stanik (＠rastos) 21 Apr '25

21 Apr '25

use a critical section to guard access to local static variable with cached information Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=58082 -- v2: kernelbase: fix racing condition in GlobalMemoryStatusEx() https://gitlab.winehq.org/wine/wine/-/merge_requests/7870

2 1

Re: [PATCH v27 0/1] MR6938: winewayland.drv: Implement support for xdg-toplevel-icon.
by Alex Schwartz (＠alexschwartz01) 21 Apr '25

21 Apr '25

Thank you! Tested this in Wine 10.6 and it works perfectly -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6938#note_101564

1 0

[PATCH 0/1] MR7870: kernelbase: fix racing condition in GlobalMemoryStatusEx()
by Rastislav Stanik (＠rastos) 21 Apr '25

21 Apr '25

use a critical section to guard access to local static variable with cached information Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=58082 -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7870

2 1

[PATCH 0/2] MR7855: comctl32/tests: Add a column width test for LVSCW_AUTOSIZE with a state imagelist.
by Nikolay Sivov (＠nsivov) 21 Apr '25

21 Apr '25

Signed-off-by: Nikolay Sivov <nsivov(a)codeweavers.com> -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7855

3 3

[PATCH v2 0/1] MR7867: include: Add newer winhttp option constants.
by Nikolay Sivov (＠nsivov) 21 Apr '25

21 Apr '25

Signed-off-by: Nikolay Sivov <nsivov(a)codeweavers.com> -- v2: include: Add newer winhttp option constants. https://gitlab.winehq.org/wine/wine/-/merge_requests/7867

3 2

[PATCH 0/11] MR7869: Thread priority boosts (part 1)
by Marc-Aurel Zent (＠mzent) 21 Apr '25

21 Apr '25

This implements setting `ThreadPriorityBoost`, `ProcessPriorityBoost`, `ProcessBasePriority` and getting `ThreadPriorityBoost`, `ProcessPriorityBoost` NT info classes and adds tests where appropriate. The actual boosting mechanism will be in part 2 to keep the size of this MR manageable. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7869

2 11

[PATCH 0/1] MR7867: include: Add newer winhttp option constants.
by Nikolay Sivov (＠nsivov) 21 Apr '25

21 Apr '25

Signed-off-by: Nikolay Sivov <nsivov(a)codeweavers.com> -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7867

3 2

[PATCH v19 0/6] MR7650: Add support for AF_UNIX sockets (followup)
by Ralf Habacker (＠rhabacker) 21 Apr '25

21 Apr '25

Follow-up of !2786, which appears to have been abandoned. -- v19: ws2_32/tests: Add test for AF_UNIX sockets server: Fix getsockname() and accept() on AF_UNIX sockets. server: Introduce error when attempting to create a SOCK_DGRAM AF_UNIX socket. server: Allow for deletion of socket files. ws2_32: Add support for AF_UNIX sockets. ws2_32: Add afunix.h header. https://gitlab.winehq.org/wine/wine/-/merge_requests/7650

2 6

Re: [PATCH v2 0/2] MR7856: gdiplus: Simplify region code. - approved
by Alexandre Julliard (＠julliard) 20 Apr '25

20 Apr '25

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7856

1 0

Re: [PATCH v4 0/1] MR7801: combase: Add a stub for SetRestrictedErrorInfo(). - approved
by Alexandre Julliard (＠julliard) 20 Apr '25

20 Apr '25

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7801

1 0

Re: [PATCH v2 0/3] MR7831: comctl32: Implement MSAA events for listview controls. - approved
by Alexandre Julliard (＠julliard) 20 Apr '25

20 Apr '25

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7831

1 0

Re: [PATCH v2 0/3] MR7854: ws2_32: Allow using duplicated socket handles in WS2_sendto(). - approved
by Alexandre Julliard (＠julliard) 20 Apr '25

20 Apr '25

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7854

1 0

Re: [PATCH v2 0/6] MR7852: mshtml: Improve constructors - approved
by Alexandre Julliard (＠julliard) 20 Apr '25

20 Apr '25

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7852

1 0

Re: [PATCH v2 0/5] MR7849: PDB rewrite #10. - approved
by Alexandre Julliard (＠julliard) 20 Apr '25

20 Apr '25

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7849

1 0

Re: [PATCH v3 0/4] MR7826: ntdll: Fix some more Valgrind warnings. - approved
by Alexandre Julliard (＠julliard) 20 Apr '25

20 Apr '25

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7826

1 0

Re: [PATCH v4 0/4] MR7853: msvcr100/tests: Link to msvcr100. - approved
by Alexandre Julliard (＠julliard) 20 Apr '25

20 Apr '25

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7853

1 0

Re: [PATCH v12 0/1] MR7806: winewayland: Implement relative motion accumulator - approved
by Alexandre Julliard (＠julliard) 20 Apr '25

20 Apr '25

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7806

1 0

Re: [PATCH v3 0/2] MR7825: windowscodecs/metadata: Add a stub for bKGD writer. - approved
by Alexandre Julliard (＠julliard) 20 Apr '25

20 Apr '25

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7825

1 0

[PATCH v2 0/2] MR7851: win32u: Fix return value of ScrollWindowEx() for invisible windows.
by Dmitry Timoshkov (＠dmitry) 20 Apr '25

20 Apr '25

-- v2: win32u: Fix return value of ScrollWindowEx() for invisible windows. user32/tests: Add more ScrollWindowEx() tests. https://gitlab.winehq.org/wine/wine/-/merge_requests/7851

2 3

[PATCH 0/1] MR7863: win87em: Fix __FPMATH symbol name
by Pali Rohár (＠pali) 20 Apr '25

20 Apr '25

Windows 3.0, Windows 3.1 and Windows 95 have library WIN87EM.DLL with symbol name __FPMATH, not with _FPMATH. So fix the __FPMATH symbol name. This change fixes running Windows 3.0 CALC.EXE application, which imports WIN87EM.DLL symbols by name. Without this change the CALC.EXE fails on: "No implementation for WIN87EM.__FPMATH, setting to 0xdeadbeef" Other Windows application, including Windows 3.1+ CALC.EXE application, import WIN87EM.DLL symbols by ordinals, so are not affected by this issue. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7863

2 1

[PATCH v5 0/1] MR7843: cmd: Implement tab completion for command line entry.
by Joe Souza (＠JoeS209) 20 Apr '25

20 Apr '25

Over the past several weeks I've been working on and off on this. I didn't track the hours but I'm sure that I've spent 80+ hours on the feature. I've tested and retested all known scenarios and it seems to be working as expected. -- v5: cmd: Implement tab completion for command line entry. https://gitlab.winehq.org/wine/wine/-/merge_requests/7843

3 16

[PATCH 0/1] MR7862: ntdll: Allow mem{cpy,move} optimisation now -fno-builtins is used.
by Billy Laws (＠bylaws) 20 Apr '25

20 Apr '25

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/7862

2 1

[PATCH 0/1] MR7860: ntdll: Check arm64ec TEB frames are valid before popping them.
by Billy Laws (＠bylaws) 20 Apr '25

20 Apr '25

This was done for all other architectures but missed for arm64ec -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7860

2 1

[PATCH 0/1] MR7858: ntoskrnl.exe/tests: Remove unused function pointers.
by Bernhard Übelacker (＠bernhardu) 20 Apr '25

20 Apr '25

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/7858

2 1

[PATCH v3 0/3] MR6885: Draft: cmd: Use the console output codepage to read batch files.
by Akihiro Sagawa (＠sgwaki) 20 Apr '25

20 Apr '25

To prevent performance degradation, we will cache the result of GetConsoleOutputCP() after executing every external command. -- v3: cmd: Use the console output code page to read batch files. programs/cmd: Factor out code_page when searching for a label. cmd/tests: Add updated code page test in batch file. https://gitlab.winehq.org/wine/wine/-/merge_requests/6885

3 3

[PATCH v2 0/2] MR6885: cmd: Use the console output codepage to read batch files.
by Akihiro Sagawa (＠sgwaki) 20 Apr '25

20 Apr '25

To prevent performance degradation, we will cache the result of GetConsoleOutputCP() after executing every external command. -- v2: cmd: Use the console output codepage to read batch files. cmd/tests: Add updated code page test in batch file. https://gitlab.winehq.org/wine/wine/-/merge_requests/6885

3 4

[PATCH v3 0/1] MR5013: msi: Properly select first feature
by Fabian Maurer (＠DarkShadow44) 19 Apr '25

19 Apr '25

We need to select the first feature when all controls are created, otherwise they are not properly updated Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=56290 -- v3: msi: Properly select first feature. https://gitlab.winehq.org/wine/wine/-/merge_requests/5013

2 4

Re: [PATCH v4 0/1] MR7843: cmd: Implement tab completion for command line entry.
by Joe Souza (＠JoeS209) 19 Apr '25

19 Apr '25

On Sat Apr 19 16:23:57 2025 +0000, eric pouech wrote: > forgot to say that executable files must be in considered directory > (eg if a.exe and e.bat exist in current directory, then 'a\<tab\>' shall > circle around both files); PATH is not used My code already does this. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7843#note_101459

1 0

Re: [PATCH v4 0/1] MR7843: cmd: Implement tab completion for command line entry.
by Joe Souza (＠JoeS209) 19 Apr '25

19 Apr '25

On Sat Apr 19 16:20:43 2025 +0000, eric pouech wrote: > maybe. i could also be something that cmd implements in > CONSOLE_READCONSOLE_CONTROL (using 0x1B in control mask). That's how I'm handling it in current changes (not yet pushed). But I shouldn't need to, based on ReadConsole behaviour that I see on Windows. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7843#note_101458

1 0

[PATCH 0/2] MR7856: gdiplus: Simplify region code.
by Esme Povirk (＠madewokherd) 19 Apr '25

19 Apr '25

Just some cleanups from the recent changes. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7856

2 2

Re: [PATCH v4 0/1] MR7843: cmd: Implement tab completion for command line entry.
by eric pouech (＠epo) 19 Apr '25

19 Apr '25

On Sat Apr 19 16:23:57 2025 +0000, Joe Souza wrote: > Testing on Windows 11 this morning, I find that Windows does not filter > on .EXE or anything in PATHEXT if tab key is hit for first word on > command line. forgot to say that executable files must be in considered directory (eg if a.exe and e.bat exist in current directory, then 'a\<tab\>' shall circle around both files); PATH is not used -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7843#note_101456

1 0

Re: [PATCH v4 0/1] MR7843: cmd: Implement tab completion for command line entry.
by eric pouech (＠epo) 19 Apr '25

19 Apr '25

On Sat Apr 19 15:01:13 2025 +0000, Joe Souza wrote: > A bug in Wine's ReadConsole implementation that I found while making > these changes is that Wine does not handle ESC key correctly. On > Windows, ESC key clears the text on the screen and clears the buffer. > Wine emits the control character for the ESC key. I'll handle this in > my changes and add a FIXME comment. maybe. i could also be something that cmd implements in CONSOLE_READCONSOLE_CONTROL (using 0x1B in control mask). -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7843#note_101455

1 0

[PATCH v3 0/1] MR7801: combase: Add a stub for SetRestrictedErrorInfo().
by Nikolay Sivov (＠nsivov) 19 Apr '25

19 Apr '25

Foobar 2000 crashes without it. Signed-off-by: Nikolay Sivov <nsivov(a)codeweavers.com> -- v3: combase: Add a stub for SetRestrictedErrorInfo(). https://gitlab.winehq.org/wine/wine/-/merge_requests/7801

3 2

Re: [PATCH v4 0/1] MR7843: cmd: Implement tab completion for command line entry.
by Joe Souza (＠JoeS209) 19 Apr '25

19 Apr '25

On Fri Apr 18 16:37:52 2025 +0000, Joe Souza wrote: > OK, using ReadConsole/CONSOLE_READCONSOLE_CONTROL on Windows gives me > the behaviour that I need; i.e. pre-filled text is preserved and can be > further edited. Caller must output the text first, but seems to work as expected. > I'll start making the changes to my code soon, within the coming days. A bug in Wine's ReadConsole implementation that I found while making these changes is that Wine does not handle ESC key correctly. On Windows, ESC key clears the text on the screen and clears the buffer. Wine emits the control character for the ESC key. I'll handle this in my changes and add a FIXME comment. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7843#note_101451

1 0

Re: [PATCH v4 0/1] MR7843: cmd: Implement tab completion for command line entry.
by Joe Souza (＠JoeS209) 19 Apr '25

19 Apr '25

On Sat Apr 19 14:56:08 2025 +0000, Joe Souza wrote: > Will definitely handle .exe filtering as a subsequent patch. Testing on Windows 11 this morning, I find that Windows does not filter on .EXE or anything in PATHEXT if tab key is hit for first word on command line. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7843#note_101450

1 0

[PATCH v2 0/1] MR7801: combase: Add a stub for SetRestrictedErrorInfo().
by Nikolay Sivov (＠nsivov) 19 Apr '25

19 Apr '25

Foobar 2000 crashes without it. Signed-off-by: Nikolay Sivov <nsivov(a)codeweavers.com> -- v2: combase: Add a stub for SetRestrictedErrorInfo(). https://gitlab.winehq.org/wine/wine/-/merge_requests/7801

3 3

[PATCH 0/1] MR7798: spoolss: Avoid buffer-overflow when setting numentries. (ASan)
by Bernhard Übelacker (＠bernhardu) 19 Apr '25

19 Apr '25

BuildOtherNamesFromMachineName writes sizeof(LPVOID) bytes but the test reserved just sizeof(DWORD), which makes a difference at amd64 and gets detected by ASan. <details> <summary>ASan output</summary> ``` ================================================================= ==spoolss_test.exe==700==ERROR: AddressSanitizer: stack-buffer-overflow on address 0x7ffffe1ffba0 at pc 0x6ffffdc53e38 bp 0x7ffffe1ffa40 sp 0x7ffffe1ffa88 WRITE of size 8 at 0x7ffffe1ffba0 thread T0 #0 0x6ffffdc53e37 in BuildOtherNamesFromMachineName .../wine/dlls/spoolss/spoolss_main.c:99:11 #1 0x00014000170e in test_BuildOtherNamesFromMachineName .../wine/dlls/spoolss/tests/spoolss.c:131:11 #2 0x000140001030 in func_spoolss .../wine/dlls/spoolss/tests/spoolss.c:218:5 #3 0x000140003ede in run_test .../wine/include/wine/test.h:765:5 #4 0x000140003a8e in main .../wine/include/wine/test.h #5 0x000140004963 in mainCRTStartup .../wine/dlls/msvcrt/crt_main.c:58:11 #6 0x6fffffc3565e in BaseThreadInitThunk .../wine/dlls/kernel32/thread.c:61:24 #7 0x6fffffdbbcc2 in RtlUserThreadStart (C:\windows\system32\ntdll.dll+0x17004bcc2) Address 0x7ffffe1ffba0 is located in stack of thread T0 at offset 64 in frame #0 0x00014000164f in test_BuildOtherNamesFromMachineName .../wine/dlls/spoolss/tests/spoolss.c:122 This frame has 2 object(s): [32, 40) 'buffers' (line 123) [64, 68) 'numentries' (line 124) <== Memory access at offset 64 partially overflows this variable HINT: this may be a false positive if your program uses some custom stack unwind mechanism, swapcontext or vfork (longjmp, SEH and C++ exceptions *are* supported) SUMMARY: AddressSanitizer: stack-buffer-overflow .../wine/dlls/spoolss/spoolss_main.c:99:11 in BuildOtherNamesFromMachineName Shadow bytes around the buggy address: 0x7ffffe1ff900: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 0x7ffffe1ff980: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 0x7ffffe1ffa00: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 0x7ffffe1ffa80: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 0x7ffffe1ffb00: 00 00 00 00 00 00 00 00 00 00 00 00 f1 f1 f1 f1 =>0x7ffffe1ffb80: 00 f2 f2 f2[04]f3 f3 f3 00 00 00 00 00 00 00 00 0x7ffffe1ffc00: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 0x7ffffe1ffc80: 00 00 00 00 00 00 00 00 f1 f1 f1 f1 f8 f8 f8 f8 0x7ffffe1ffd00: f8 f8 f8 f8 f3 f3 f3 f3 00 00 00 00 00 00 00 00 0x7ffffe1ffd80: 00 00 00 00 00 00 00 00 f1 f1 f1 f1 00 00 00 00 0x7ffffe1ffe00: 00 00 00 00 00 00 00 00 00 00 00 00 f2 f2 f2 f2 Shadow byte legend (one shadow byte represents 8 application bytes): Addressable: 00 Partially addressable: 01 02 03 04 05 06 07 Heap left redzone: fa Freed heap region: fd Stack left redzone: f1 Stack mid redzone: f2 Stack right redzone: f3 Stack after return: f5 Stack use after scope: f8 Global redzone: f9 Global init order: f6 Poisoned by user: f7 Container overflow: fc Array cookie: ac Intra object redzone: bb ASan internal: fe Left alloca redzone: ca Right alloca redzone: cb ==spoolss_test.exe==700==ABORTING ``` </details> -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7798

3 3

[PATCH 0/1] MR7801: combase: Add a stub for SetRestrictedErrorInfo().
by Nikolay Sivov (＠nsivov) 19 Apr '25

19 Apr '25

Foobar 2000 crashes without it. Signed-off-by: Nikolay Sivov <nsivov(a)codeweavers.com> -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7801

3 2

[PATCH v3 0/1] MR7838: mfplat/tests: Don't assume video processor MFT can provide samples.
by Charlotte Pabst (＠CharlottePabst) 19 Apr '25

19 Apr '25

This fixes a test failure/crash on Windows 8.1 introduced by dd1d82728811c15716eefa0917eb3ecac4b9a85a. -- v3: mfplat/tests: Don't assume video processor MFT can provide samples. https://gitlab.winehq.org/wine/wine/-/merge_requests/7838

3 2

[PATCH 0/3] MR7831: comctl32: Implement MSAA events for listview controls.
by Esme Povirk (＠madewokherd) 19 Apr '25

19 Apr '25

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/7831

4 8

[PATCH 0/4] MR7797: ntdll: Wait for all pending operations to be cancelled in NtCancelIoFile[Ex]().
by Matteo Bruni (＠Mystral) 19 Apr '25

19 Apr '25

This fixes Trials Fusion often crashing when disconnecting a controller while there are more still connected. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7797

4 12

Re: [PATCH v2 0/1] MR7833: mf: Update state and start clock for both paused and stopped.
by Nikolay Sivov (＠nsivov) 19 Apr '25

19 Apr '25

I think what's missing is an audio client Reset(). We currently do Stop+Reset when the clock is stopped, and just Stop when the clock is paused. We don't Reset on pause so we don't lose pending data. But when we restart from at a different timestamp I think we should. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7833#note_101438

1 0

Re: [PATCH v2 0/1] MR7833: mf: Update state and start clock for both paused and stopped.
by Nikolay Sivov (＠nsivov) 19 Apr '25

19 Apr '25

On Thu Apr 17 21:23:59 2025 +0000, Brendan McGrath wrote: > I couldn't get this to build unfortunately. But if you can seek in this > program, then you should be able to recreate the issue with pause, seek > and then play. You can seek with it, but it's not implemented on our side yet. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7833#note_101437

1 0

Re: [PATCH v2 0/1] MR7833: mf: Update state and start clock for both paused and stopped.
by Nikolay Sivov (＠nsivov) 19 Apr '25

19 Apr '25

On Sat Apr 19 12:53:51 2025 +0000, Brendan McGrath wrote: > Specifically I'm using: > - `IMFMediaEngine::Pause` > - `IMFMediaEngine::SetCurrentTime` > - `IMFMediaEngine::Play` Thanks, makes sense. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7833#note_101436

1 0

[PATCH v8 0/3] MR7064: ntdll: Check for invalid GS base in the 64-bit segv_handler.
by William Horvath (＠whrvth) 19 Apr '25

19 Apr '25

Adapted from [check_invalid_gs](https://gitlab.winehq.org/wine/wine/-/blob/d7a7cae2e2d1ad… in signal_i386.c. This prevents crashing when the %gs register is manipulated, such as in 32-bit code on "new-style" WoW64. "Exertus: Darkness Approaches" is a 32-bit game that triggers this crash (on WoW64), which can be downloaded from the Bugzilla page's attachments. For another example, [test.c](https://bugs.winehq.org/attachment.cgi?id=77444) can reproduce it, courtesy of Fabian Maurer from the Bugzilla comments. This will crash whether it's compiled as 32-bit or 64-bit, while it works fine on Windows. Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=57444 Also, excuse me if submitting this is against some sort of code-freeze etiquette, it wasn't my intention try to have it merged immediately. -- v8: ntdll/tests: Re-enable a previously crashing test. ntdll: Check for invalid gs_base in the 64-bit segv_handler. ntdll/tests: Add an exception test for accessing a modified %gs on x86_64. https://gitlab.winehq.org/wine/wine/-/merge_requests/7064

6 16

[PATCH 0/3] MR7854: ws2_32: Allow using duplicated socket handles in WS2_sendto().
by Elizabeth Figura (＠zfigura) 18 Apr '25

18 Apr '25

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/7854

2 3

Re: [PATCH v4 0/1] MR7843: cmd: Implement tab completion for command line entry.
by Joe Souza (＠JoeS209) 18 Apr '25

18 Apr '25

On Fri Apr 18 17:25:10 2025 +0000, eric pouech wrote: > also note that for the first word of command line, when using tab, > native cmd.exe filters on directories and files that can be executed > (likely using PATHEXT list of extensions, didn't test that though) > i'd suggest handling in two seperate patches the rd/md part, and the > first parameter one... > that should boil down to adding filters to the files gotten out of find > files (directories and/or extensions) depending on context Will definitely handle .exe, etc. filtering as a subsequent patch. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7843#note_101422

1 0

[PATCH v6 0/5] MR7715: Implement dynamic formats in directdraw media stream.
by Santino Mazza (＠tati) 18 Apr '25

18 Apr '25

-- v6: amstream: Implement dynamic formats in ddraw stream. amstream/tests: Test for dynamic formats in ddraw stream. amstream: Implement custom allocator for ddraw stream. amstream/tests: Test for custom allocator in ddraw stream. https://gitlab.winehq.org/wine/wine/-/merge_requests/7715

2 6

[PATCH 0/6] MR7852: mshtml: Improve constructors
by Jacek Caban (＠jacek) 18 Apr '25

18 Apr '25

Split from !7779. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7852

4 8

[PATCH v5 0/10] MR7779: mshtml: Misc prototype fixes.
by Gabriel Ivăncescu (＠insn) 18 Apr '25

18 Apr '25

-- v5: mshtml: Validate builtin host functions in IE9+ using prototype_id rather mshtml: Store the prototype_id of the last member that contains the needed mshtml: Define "create" from XMLHttpRequest constructor as a jscript prop mshtml: Consolidate the functional constructors into a common struct mshtml: Rename struct constructor to stub_constructor. mshtml: Use get_constructor in window's get_XMLHttpRequest. mshtml: Move Option constructor to the window rather than the prototype. mshtml: Move Image constructor to the window rather than the prototype. mshtml: Don't expose "create" from Option constructor in IE9+ modes. mshtml: Don't expose "create" from Image constructor in IE9+ modes. https://gitlab.winehq.org/wine/wine/-/merge_requests/7779

3 12

[PATCH 0/1] MR7843: cmd: Implement tab completion for command line entry.
by Joe Souza (＠JoeS209) 18 Apr '25

18 Apr '25

Over the past several weeks I've been working on and off on this. I didn't track the hours but I'm sure that I've spent 80+ hours on the feature. I've tested and retested all known scenarios and it seems to be working as expected. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7843

4 14

[PATCH v11 0/1] MR7806: winewayland: Implement relative motion accumulator
by Etaash Mathamsetty (＠etaash.mathamsetty) 18 Apr '25

18 Apr '25

Gets rid of the dead mouse issue when you move the mouse slowly -- v11: winewayland: Implement relative motion accumulator https://gitlab.winehq.org/wine/wine/-/merge_requests/7806

3 6

[PATCH v3 0/4] MR7853: msvcr100/tests: Link to msvcr100.
by Piotr Caban (＠piotr) 18 Apr '25

18 Apr '25

-- v3: msvcr100/tests: Link to msvcr100. https://gitlab.winehq.org/wine/wine/-/merge_requests/7853

2 4

[PATCH v2 0/4] MR7853: msvcr100/tests: Link to msvcr100.
by Piotr Caban (＠piotr) 18 Apr '25

18 Apr '25

-- v2: msvcr100/tests: Link to msvcr100. https://gitlab.winehq.org/wine/wine/-/merge_requests/7853

2 4

[PATCH 0/4] MR7853: msvcr100/tests: Link to msvcr100.
by Piotr Caban (＠piotr) 18 Apr '25

18 Apr '25

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/7853

2 4

[PATCH v2 0/4] MR7826: ntdll: Fix some more Valgrind warnings.
by Sven Baars (＠sbaars) 18 Apr '25

18 Apr '25

-- v2: ntdll: Avoid evaluating a possibly uninitialized variable in RtlExpandEnvironmentStrings(). (Valgrind). ntdll/tests: Fix some uninitialized variable warnings (Valgrind). ntdll/tests: Don't trace invalid pointers (Valgrind). ntdll/tests: Fix some string leaks (Valgrind). https://gitlab.winehq.org/wine/wine/-/merge_requests/7826

2 5

[PATCH v2 0/8] MR7848: Draft: server: Use events as a sync for several objects.
by Rémi Bernon (＠rbernon) 18 Apr '25

18 Apr '25

Instead of https://gitlab.winehq.org/wine/wine/-/merge_requests/7815, for https://gitlab.winehq.org/wine/wine/-/merge_requests/7226, this only split the sync ops to a separate vtable and let objects delegate theirs to a separate object. This starts using a event-like interface for most objects, leaving the decision regarding if/how to split sync themselves / integrate inproc syncs for later. -- v2: server: Use an event as debug event sync. server: Use an event as file lock sync. server: Use an event as process startup info sync. server: Use an event as thread context sync. server: Use an event as thread apc sync. server: Use an event as fd sync. https://gitlab.winehq.org/wine/wine/-/merge_requests/7848

2 10

[PATCH 0/2] MR7851: win32u: Fix return value of ScrollWindowEx() for invisible windows.
by Dmitry Timoshkov (＠dmitry) 18 Apr '25

18 Apr '25

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/7851

2 2

Re: [PATCH v10 0/1] MR7806: winewayland: Implement relative motion accumulator
by Alexandros Frantzis (＠afrantzis) 18 Apr '25

18 Apr '25

One more improvement suggestion, but otherwise looks good to me! -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7806#note_101384

1 0

Re: [PATCH v10 0/1] MR7806: winewayland: Implement relative motion accumulator
by Alexandros Frantzis (＠afrantzis) 18 Apr '25

18 Apr '25

Alexandros Frantzis (@afrantzis) commented about dlls/winewayland.drv/wayland_pointer.c: > } > else if (!needs_relative && pointer->zwp_relative_pointer_v1) > { > + pointer->accum_x = pointer->accum_y = 0; I was thinking... if we perform the initialization/zeroing just before enabling relative motion in the if clause above, we reduce (although we do not completely eliminate) the window for the data race mentioned in a previous comment (i.e., some handler running concurrently). This also takes care of the lack of explicit initialization of the accum_x/accum_y members during wayland_pointer init. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7806#note_101383

1 0

[PATCH 0/5] MR7849: PDB rewrite #10.
by eric pouech (＠epo) 18 Apr '25

18 Apr '25

This serie finishes the migration of the remaining types from TPI stream (function signature, struct/class/union, enum) to new PDB backend. And it removes dual allocation of symt_* in old PDB backed. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7849

2 5

[PATCH 0/8] MR7848: server: Use events as a sync for several objects.
by Rémi Bernon (＠rbernon) 18 Apr '25

18 Apr '25

Instead of https://gitlab.winehq.org/wine/wine/-/merge_requests/7815, for https://gitlab.winehq.org/wine/wine/-/merge_requests/7226, this only split the sync ops to a separate vtable and let objects delegate theirs to a separate object. This starts using a event-like interface for most objects, leaving the decision regarding if/how to split sync themselves / integrate inproc syncs for later. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7848

3 10

[PATCH 0/1] MR7028: ntdll: Remove manifest name filtering.
by Dmitry Timoshkov (＠dmitry) 18 Apr '25

18 Apr '25

Componenets installed by winetricks have "deadbeef.manifest" trailer in their manifests, so it's not clear that filtering logic works. On the other hand when manifests for versions 1.2.3.4 and 1.2.3.10 are installed and application exe needs version 1.2.0.0 and later uses LoadLibrary() to load a plugin.dll that needs 1.2.3.7, version 1.2.3.4 gets loaded with an .exe (because manifest for version 1.2.3.10 is ignored) and version 1.2.3.10 gets loaded with a plugin.dll, and this leads to crashes. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7028

3 6

[PATCH 0/6] MR7815: server: Split event object to a dedicated sync.
by Rémi Bernon (＠rbernon) 18 Apr '25

18 Apr '25

For https://gitlab.winehq.org/wine/wine/-/merge_requests/7226 This MR introduces a new wineserver "sync" entity, to be used by objects to implement the signal/wait operations. Later, the server sync implementations will be reduced as much as possible to event/mutex/semaphore/queue[^1]. I think it will then make the integration of ntsync cleaner, with inproc syncs being a separate flavor from the traditional server-side syncs. Unlike how the fd struct have been implemented, I chose not to derive these syncs from the object base, because it seemed inconvenient to have to declare all the unused ops. Still they are refcounted, to allow us to share a sync between multiple objects, which will later benefit the console objects use cases, maybe others. This makes me thing that the fd struct could also benefit from being lightweight entities as well, as it doesn't seem they really use most of the object vtable ops, and arguably we could have a common "light" refcounted/dumpable base for all fds, syncs and objects, but I didn't want to jump into that rabbit hole and it could be implemented later. [^1]: And server-only async/completion waits, which maybe can be changed to use events too, but I'm not familiar enough. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7815

3 9

[PATCH 0/1] MR7845: ws2_32: Remove local socket cache check from send().
by Dmitry Timoshkov (＠dmitry) 18 Apr '25

18 Apr '25

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/7845

3 7

[PATCH v2 0/1] MR7847: win32u: Don't distinguish WGL_SWAP_EXCHANGE_ARB and WGL_SWAP_UNDEFINED_ARB when filtering in wglChoosePixelFormatARB().
by Paul Gofman (＠gofman) 18 Apr '25

18 Apr '25

-- v2: opengl32: Don't distinguish WGL_SWAP_EXCHANGE_ARB and WGL_SWAP_UNDEFINED_ARB when filtering in wglChoosePixelFormatARB(). https://gitlab.winehq.org/wine/wine/-/merge_requests/7847

2 1

[PATCH 0/1] MR7847: win32u: Don't distinguish WGL_SWAP_EXCHANGE_ARB and WGL_SWAP_UNDEFINED_ARB when filtering in wglChoosePixelFormatARB().
by Paul Gofman (＠gofman) 18 Apr '25

18 Apr '25

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/7847

2 2

[PATCH v2 0/2] MR7825: windowscodecs/metadata: Add a stub for bKGD writer.
by Nikolay Sivov (＠nsivov) 18 Apr '25

18 Apr '25

Signed-off-by: Nikolay Sivov <nsivov(a)codeweavers.com> -- v2: windowscodecs/metadata: Add a stub for tIME writer. https://gitlab.winehq.org/wine/wine/-/merge_requests/7825

3 4

[PATCH v7 0/2] MR7623: winegstreamer: Use provided PTS and duration in video_decoder.
by Brendan McGrath (＠redmcg) 17 Apr '25

17 Apr '25

This MR modifies winegstreamer to match Windows behaviour in that: 1. the video decoders will output the PTS and duration of the input sample (if provided); and 2. the WMV decoder will set any value not provided to zero It also adds support for supplying a DTS value to the MFTs. I've marked this as draft as it fixes the tests in MR !7563 (in addition to fixing some existing `test_wmv_decoder` tests). Also, as demonstrated in MR !7569, our demuxers output different timestamps to Windows. This change will result in those different timestamps being forwarded from the decoder. So we may also want to address that difference prior to accepting this MR. -- v7: winegstreamer: Use provided PTS and duration in video_decoder. https://gitlab.winehq.org/wine/wine/-/merge_requests/7623

2 2

[PATCH v6 0/2] MR7623: winegstreamer: Use provided PTS and duration in video_decoder.
by Brendan McGrath (＠redmcg) 17 Apr '25

17 Apr '25

This MR modifies winegstreamer to match Windows behaviour in that: 1. the video decoders will output the PTS and duration of the input sample (if provided); and 2. the WMV decoder will set any value not provided to zero It also adds support for supplying a DTS value to the MFTs. I've marked this as draft as it fixes the tests in MR !7563 (in addition to fixing some existing `test_wmv_decoder` tests). Also, as demonstrated in MR !7569, our demuxers output different timestamps to Windows. This change will result in those different timestamps being forwarded from the decoder. So we may also want to address that difference prior to accepting this MR. -- v6: winegstreamer: Use provided PTS and duration in video_decoder. mf/tests: Add negative timestamp tests for h264. https://gitlab.winehq.org/wine/wine/-/merge_requests/7623

2 6

Re: [PATCH v5 0/1] MR7769: ntdll: correctly detect the NUL device under macOS - approved
by Alexandre Julliard (＠julliard) 17 Apr '25

17 Apr '25

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7769

1 0

Re: [PATCH v3 0/9] MR7835: win32u: Implement generic OpenGL context functions. - approved
by Alexandre Julliard (＠julliard) 17 Apr '25

17 Apr '25

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7835

1 0

Re: [PATCH v2 0/1] MR7846: ntdll: Add some specifics for NtQueryInformationProcess( ProcessDebugObjectHandle ) parameters handling. - approved
by Alexandre Julliard (＠julliard) 17 Apr '25

17 Apr '25

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7846

1 0

Re: [PATCH v2 0/6] MR7844: PDB rewrite #9. - approved
by Alexandre Julliard (＠julliard) 17 Apr '25

17 Apr '25

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7844

1 0

Re: [PATCH v3 0/1] MR7841: ntdll/tests: Make single step test succeed for 32-bit systems. - approved
by Alexandre Julliard (＠julliard) 17 Apr '25

17 Apr '25

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7841

1 0

Re: [PATCH v4 0/7] MR7836: bcrypt: Partial BCryptKeyDerivation implementation (PBKDF2). - approved
by Alexandre Julliard (＠julliard) 17 Apr '25

17 Apr '25

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7836

1 0

Re: [PATCH v6 0/5] MR7812: win32u: Add more CompAttr, CompClause implementation using cursor_begin, cursor_end concept. - approved
by Alexandre Julliard (＠julliard) 17 Apr '25

17 Apr '25

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7812

1 0

Re: [PATCH v4 0/2] MR7827: imm32: Fix the WM_IME_COMPOSITION messages to be between the WM_IME_{START|END}COMPOSITION message. - approved
by Alexandre Julliard (＠julliard) 17 Apr '25

17 Apr '25

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7827

1 0

Re: [PATCH v4 0/5] MR7817: winebth.sys part 10: Add support for removing and disconnecting devices. - approved
by Alexandre Julliard (＠julliard) 17 Apr '25

17 Apr '25

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7817

1 0

Re: [PATCH v2 0/1] MR7833: mf: Update state and start clock for both paused and stopped.
by Brendan McGrath (＠redmcg) 17 Apr '25

17 Apr '25

On Thu Apr 17 21:21:27 2025 +0000, Brendan McGrath wrote: > `OnClockRestart` is only used if you call `IMFPresentationClock::Start` > with `PRESENTATION_CURRENT_POSITION` > So my test is pause -> seek -> play. Specifically I'm using: - `IMFMediaEngine::Pause` - `IMFMediaEngine::SetCurrentTime` - `IMFMediaEngine::Play` -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7833#note_101314

1 0

Re: [PATCH v2 0/1] MR7833: mf: Update state and start clock for both paused and stopped.
by Brendan McGrath (＠redmcg) 17 Apr '25

17 Apr '25

On Thu Apr 17 21:22:09 2025 +0000, Nikolay Sivov wrote: > I'm using this demo player based on mfplay > https://github.com/microsoft/Windows-classic-samples/tree/main/Samples/Win7…, > and start->pause->restart works fine there for the audio. I couldn't get this to build unfortunately. But if you can seek in this program, then you should be able to recreate the issue with pause, seek and then play. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7833#note_101313

1 0

Re: [PATCH v2 0/1] MR7833: mf: Update state and start clock for both paused and stopped.
by Brendan McGrath (＠redmcg) 17 Apr '25

17 Apr '25

On Thu Apr 17 21:21:27 2025 +0000, Nikolay Sivov wrote: > This is already working using OnClockRestart(). How does it break in > your testing? `OnClockRestart` is only used if you call `IMFPresentationClock::Start` with `PRESENTATION_CURRENT_POSITION` So my test is pause -> seek -> play. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7833#note_101312

1 0

[PATCH v4 0/7] MR7779: mshtml: Misc prototype fixes.
by Gabriel Ivăncescu (＠insn) 17 Apr '25

17 Apr '25

-- v4: mshtml: Move Option constructor to the window rather than the prototype. mshtml: Move Image constructor to the window rather than the prototype. mshtml: Validate builtin host functions in IE9+ using prototype_id rather mshtml: Store the prototype_id of the last member that contains the needed mshtml: Define "create" from XMLHttpRequest constructor as a jscript prop mshtml: Don't expose "create" from Option constructor in IE9+ modes. mshtml: Don't expose "create" from Image constructor in IE9+ modes. https://gitlab.winehq.org/wine/wine/-/merge_requests/7779

3 13

[PATCH v18 0/6] MR7650: Add support for AF_UNIX sockets (followup)
by Ralf Habacker (＠rhabacker) 17 Apr '25

17 Apr '25

Follow-up of !2786, which appears to have been abandoned. -- v18: ws2_32/tests: Add test for AF_UNIX sockets. server: Fix getsockname() and accept() on AF_UNIX sockets. server: Introduce error when attempting to create a SOCK_DGRAM AF_UNIX socket. server: Allow for deletion of socket files. ws2_32: Add support for AF_UNIX sockets. ws2_32: Add afunix.h header. https://gitlab.winehq.org/wine/wine/-/merge_requests/7650

2 6

[PATCH 0/1] MR7846: ntdll: Add some specifics for NtQueryInformationProcess( ProcessDebugObjectHandle ) parameters handling.
by Paul Gofman (＠gofman) 17 Apr '25

17 Apr '25

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/7846

2 2

[PATCH v9 0/1] MR7806: winewayland: Implement relative motion accumulator
by Etaash Mathamsetty (＠etaash.mathamsetty) 17 Apr '25

17 Apr '25

Gets rid of the dead mouse issue when you move the mouse slowly -- v9: winewayland: Implement relative motion accumulator https://gitlab.winehq.org/wine/wine/-/merge_requests/7806

2 1

[PATCH v8 0/1] MR7806: winewayland: Implement relative motion accumulator
by Etaash Mathamsetty (＠etaash.mathamsetty) 17 Apr '25

17 Apr '25

Gets rid of the dead mouse issue when you move the mouse slowly -- v8: winewayland: Implement relative motion accumulator https://gitlab.winehq.org/wine/wine/-/merge_requests/7806

2 1

Re: [PATCH v7 0/1] MR7806: winewayland: Implement relative motion accumulator
by Etaash Mathamsetty (＠etaash.mathamsetty) 17 Apr '25

17 Apr '25

v3: fixed remaining suggestions -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7806#note_101294

1 0

[PATCH v6 0/1] MR7806: winewayland: Implement relative motion accumulator
by Etaash Mathamsetty (＠etaash.mathamsetty) 17 Apr '25

17 Apr '25

Gets rid of the dead mouse issue when you move the mouse slowly -- v6: winewayland: Implement relative motion accumulator https://gitlab.winehq.org/wine/wine/-/merge_requests/7806

2 1

[PATCH v5 0/1] MR7806: winewayland: Implement relative motion accumulator
by Etaash Mathamsetty (＠etaash.mathamsetty) 17 Apr '25

17 Apr '25

Gets rid of the dead mouse issue when you move the mouse slowly -- v5: winewayland: Implement relative motion accumulator https://gitlab.winehq.org/wine/wine/-/merge_requests/7806

3 6

[PATCH v7 0/2] MR7032: Add embeddedbrowserwebview aka. WebView2 DLL stub.
by Bernhard Kölbl (＠besentv) 17 Apr '25

17 Apr '25

(For after the code freeze.) I think we want to have this DLL living in Wine for easier development, and probably dynamically load our custom Chromium fork from here. (just like MSHTML and wine-Gecko) The code for that fork could then be created in its own repo. -- v7: embeddedbrowserwebview: Create CreateWebViewEnvironmentWithOptionsInternal stub. embeddedbrowserwebview: Add stub dll. https://gitlab.winehq.org/wine/wine/-/merge_requests/7032

6 7

[PATCH 0/6] MR7844: PDB rewrite #9.
by eric pouech (＠epo) 17 Apr '25

17 Apr '25

This serie implements the migration of some type into the new PDB reader. During the migration phase (this serie and next one), the types (A) will: - always be loaded by old PDB reader, - be migrated accoring to the type's tag (UDT, pointer, enum...), one commit for each tag by: + storing in new PDB reader an offset to that type inside the PDB file, + requesting type details directly from the file. (A) typedef:s are handled differently than the other types, so they'll be taken care of later on. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7844

2 6

Re: [PATCH v4 0/1] MR7806: winewayland: Implement relative motion accumulator
by Alexandros Frantzis (＠afrantzis) 17 Apr '25

17 Apr '25

Alexandros Frantzis (@afrantzis) commented about dlls/winewayland.drv/wayland_pointer.c: > > if (!(hwnd = wayland_pointer_get_focused_hwnd())) return; > if (!(data = wayland_win_data_get(hwnd))) return; > + if (!private) return; > > - wayland_surface_coords_to_window(data->wayland_surface, > + wayland_motion_delta_to_window(data->wayland_surface, > wl_fixed_to_double(dx), > wl_fixed_to_double(dy), > - (int *)&screen.x, (int *)&screen.y); > - > + &screen.x, &screen.y); > wayland_win_data_release(data); > > + d_accum->x += screen.x; > + d_accum->y += screen.y; The accum x and y are accessed in two contexts: in `wayland_pointer_update_constraint` for the zeroing, and also updated here in relative motion handler. These may be running concurrently in different threads, and since access to doubles may not be atomic we ideally need to protect the variables. Especially with the suggestion below to place them in wayland_pointer instead, it's straightforward to guard these in the relative motion handler with the wayland_pointer mutex. Note that even with the lock, there are some Wayland event races left that are harder to resolve (e.g., Thread1: relative motion handler starts running, Thread2: zero accum and destroy relative motion, Thread1: handler updates accum), but at least we won't end up with some half-updated `double` value, and the worst case is then only a very small glitch. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7806#note_101267

1 0

Re: [PATCH v4 0/1] MR7806: winewayland: Implement relative motion accumulator
by Alexandros Frantzis (＠afrantzis) 17 Apr '25

17 Apr '25

Alexandros Frantzis (@afrantzis) commented about dlls/winewayland.drv/wayland_pointer.c: > process_wayland.zwp_relative_pointer_manager_v1, > pointer->wl_pointer); > zwp_relative_pointer_v1_add_listener(pointer->zwp_relative_pointer_v1, > - &relative_pointer_v1_listener, NULL); > + &relative_pointer_v1_listener, &accum); > TRACE("Enabling relative motion\n"); > } > else if (!needs_relative && pointer->zwp_relative_pointer_v1) > { > + memset(&accum, 0, sizeof(accum)); I would recommend setting the doubles explicitly with `= 0.0`, as memset(0) of double variables is undefined behavior (from a C standard perspective, although you'd be hard-pressed to find a system where this causes a problem). -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7806#note_101266

1 0

Re: [PATCH v4 0/1] MR7806: winewayland: Implement relative motion accumulator
by Alexandros Frantzis (＠afrantzis) 17 Apr '25

17 Apr '25

Alexandros Frantzis (@afrantzis) commented about dlls/winewayland.drv/waylanddrv.h: > pthread_mutex_t mutex; > }; > > +struct wayland_point > +{ > + double x; > + double y; > +}; With the move of accumulated x and y to `wayland_pointer` I don't think there is much benefit in a `struct wayland_point` anymore. A plain `double accum_x, accum_y;` or similar is enough. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7806#note_101265

1 0

Re: [PATCH v4 0/1] MR7806: winewayland: Implement relative motion accumulator
by Alexandros Frantzis (＠afrantzis) 17 Apr '25

17 Apr '25

Alexandros Frantzis (@afrantzis) commented about dlls/winewayland.drv/wayland_pointer.c: > { > INPUT input = {0}; > HWND hwnd; > - POINT screen; > + struct wayland_point screen = {0.0}, *d_accum = private; > struct wayland_win_data *data; > > if (!(hwnd = wayland_pointer_get_focused_hwnd())) return; > if (!(data = wayland_win_data_get(hwnd))) return; > + if (!private) return; > > - wayland_surface_coords_to_window(data->wayland_surface, > + wayland_motion_delta_to_window(data->wayland_surface, > wl_fixed_to_double(dx), Nit: realign to arguments above -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7806#note_101264

1 0

Re: [PATCH v4 0/1] MR7806: winewayland: Implement relative motion accumulator
by Alexandros Frantzis (＠afrantzis) 17 Apr '25

17 Apr '25

Alexandros Frantzis (@afrantzis) commented about dlls/winewayland.drv/wayland_pointer.c: > process_wayland.zwp_relative_pointer_manager_v1, > pointer->wl_pointer); > zwp_relative_pointer_v1_add_listener(pointer->zwp_relative_pointer_v1, > - &relative_pointer_v1_listener, NULL); > + &relative_pointer_v1_listener, &accum); Let's place the accumulated x and y values in wayland_pointer, since it's really a per-pointer state (currently per-process since we have a single pointer). -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7806#note_101263

1 0

Re: [PATCH v4 0/1] MR7806: winewayland: Implement relative motion accumulator
by Alexandros Frantzis (＠afrantzis) 17 Apr '25

17 Apr '25

Alexandros Frantzis (@afrantzis) commented about dlls/winewayland.drv/wayland_pointer.c: > pointer_handle_axis_discrete > }; > > +/********************************************************************** > + * wayland_motion_delta_to_window > + * > + * Converts the surface-local delta to window (logical) coordinate delta. > + */ > +static void wayland_motion_delta_to_window(struct wayland_surface *surface, > + double surface_x, double surface_y, > + double *window_x, double *window_y) Nit: Align with parameters above -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7806#note_101262

1 0

Re: [PATCH v2 0/1] MR7833: mf: Update state and start clock for both paused and stopped.
by Nikolay Sivov (＠nsivov) 17 Apr '25

17 Apr '25

I'm using this demo player based on mfplay https://github.com/microsoft/Windows-classic-samples/tree/main/Samples/Win7…, and start->pause->restart works fine there for the audio. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7833#note_101261

1 0

2025

2024

2023

2022

wine-gitlab