- wine-gitlab - winehq.org

Re: [PATCH v2 0/2] MR4745: Finnish translation - approved
by Alexandre Julliard (＠julliard) 27 Dec '23

27 Dec '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4745

1 0

Re: [PATCH v2 0/1] MR4744: server: Fix compile error on FreeBSD/NetBSD. - approved
by Alexandre Julliard (＠julliard) 27 Dec '23

27 Dec '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4744

1 0

Re: [PATCH v2 0/1] MR4743: include: Assert that the debug channel name will be null-terminated and is not too long. - approved
by Alexandre Julliard (＠julliard) 27 Dec '23

27 Dec '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4743

1 0

Re: [PATCH v2 0/1] MR4736: wineandroid: fix incorrect checking reason. - approved
by Alexandre Julliard (＠julliard) 27 Dec '23

27 Dec '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4736

1 0

[PATCH 0/1] MR4750: Fix comctl32/Combo : When a letter is typed while list is dropped down, combo shall move to the associated letter without closing the drop down list
by Kyle Katarn (＠KRosUser) 27 Dec '23

27 Dec '23

Fix comctl32/Combo : When a letter is typed while list is dropped down, combo shall move to the associated letter without closing the drop down list eg, on WM_CHAR, if CBF_DROPPED is set (list dropped) it shall not close (CBF_NOROLLUP to be set) -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4750

2 2

[PATCH 0/1] MR4749: Fix comctl32/IPAddress component background when disabled
by Kyle Katarn (＠KRosUser) 27 Dec '23

27 Dec '23

comctl32/IPAddress component background is incorrectly painted when disabled ![image](/uploads/8a93f62828359e4b2b80242347e6ee48/image.png) This is due to an incorrect Brush being used Fixed : ![image](/uploads/914c71829e43534a4154a1ca0f6b5488/image.png) -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4749

3 3

[PATCH 0/1] MR4752: Fix comctl32/propsheet - should react to CTRL+TAB and CTRL+SHIFT+TAB
by Kyle Katarn (＠KRosUser) 27 Dec '23

27 Dec '23

Fix comctl32/propsheet - should react to CTRL+TAB and CTRL+SHIFT+TAB Currently not working as calling IsDialogMessageW instead of PROPSHEET_IsDialogMessage which is correctly implementing TAB key management -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4752

2 2

[PATCH 0/1] MR4751: Comdlg32/Color : Implement ClipCursor logic
by Kyle Katarn (＠KRosUser) 27 Dec '23

27 Dec '23

Comdlg32/Color : Fix ClipCursor ClipCursor ("cursor caging in 2D spectrum") is not implemented (FIXME). -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4751

2 2

Re: [PATCH v2 0/1] MR4747: Fix Comdlg32/Color : color picker does not use "limited" value, leading to out of bound - closed
by Kyle Katarn (＠KRosUser) 27 Dec '23

27 Dec '23

This merge request was closed by Kyle Katarn. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4747

1 0

Re: [PATCH v2 0/1] MR4747: Fix Comdlg32/Color : color picker does not use "limited" value, leading to out of bound
by Nikolay Sivov (＠nsivov) 27 Dec '23

27 Dec '23

Could you explain how to reproduce this, without mspaint? P.S. note that commit message needs to be meaningful, that's what going to get in the git history. It also need to use your real name. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4747#note_56444

1 0

[PATCH 0/2] MR4748: Don't test function directly when reporting GetLastError()
by André Zwing (＠AndreRH) 27 Dec '23

27 Dec '23

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/4748

5 5

Re: [PATCH v3 0/4] MR4746: ComDlg32 / Color picker does not use "limited" value, leading to out of bound - closed
by Kyle Katarn (＠KRosUser) 27 Dec '23

27 Dec '23

This merge request was closed by Kyle Katarn. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4746

1 0

[PATCH v2 0/2] MR4746: ComDlg32 / Color picker does not use "limited" value, leading to out of bound
by Kyle Katarn (＠KRosUser) 27 Dec '23

27 Dec '23

ComDlg32 / Color picker does not use "limited" value, leading to out of bound This cause the lum bar to get crazy ![image](/uploads/ed7511b46d1aa89e2828ddcb10f8816c/image.png) ![image](/uploads/c4d8b78416bf24929aca9a308baebd94/image.png) -- v2: Update ipaddress.c https://gitlab.winehq.org/wine/wine/-/merge_requests/4746

2 2

[PATCH 0/1] MR4746: ComDlg32 / Color picker does not use "limited" value, leading to out of bound
by Kyle Katarn (＠KRosUser) 27 Dec '23

27 Dec '23

ComDlg32 / Color picker does not use "limited" value, leading to out of bound This cause the lum bar to get crazy ![image](/uploads/ed7511b46d1aa89e2828ddcb10f8816c/image.png) ![image](/uploads/c4d8b78416bf24929aca9a308baebd94/image.png) -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4746

2 1

[PATCH 0/2] MR4745: Finnish translation
by Lauri Kenttä (＠lauri.kentta) 27 Dec '23

27 Dec '23

None -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4745

2 2

Re: [PATCH v2 0/1] MR4655: ntdll: loader_init() invoke breakpoint before loading dlls
by Dāvis Mosāns (davispuh) (＠davispuh) 27 Dec '23

27 Dec '23

On Wed Dec 27 01:54:00 2023 +0000, Jinoh Kang wrote: > You're correct that debuggers can be sensitive to the timing of the > initial breakpoint. > Adding a conformance test would let us confirm your observation, and > ensure such regression won't happen in the future. For reference, see 2b40969c58a099f958c58909b666915991a42979. > I'm still approving since the existing tests did not fail and I cannot > find a particular reason `process_breakpoint();` must be placed exactly > there in the commit history. I'm not really sure how to write test case for this, seems quite complicated since basically need to load DLL with `int3` - if it's triggered after system breakpoint then it's a pass. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4655#note_56427

1 0

[PATCH 0/1] MR4744: server: Fix compile error on FreeBSD/NetBSD.
by Brendan Shanks (＠bshanks) 26 Dec '23

26 Dec '23

`F_GETPATH` is currently only implemented on macOS, although NetBSD 10 (not yet released) is also adding it. Note that `libinotify` needs to be installed for this codepath to be active. Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=56047 -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4744

2 1

[PATCH v9 0/10] MR531: Draft: vkd3d: Assorted fixes for MoltenVK.
by Giovanni Mascellani (＠giomasce) 26 Dec '23

26 Dec '23

-- v9: tests: Mark loading from stencil as buggy on MoltenVK. tests: Mark resource arrays as buggy on MoltenVK. tests: Mark unbounded ranges as buggy on MoltenVK. tests: Mark predicated rendering as buggy on MoltenVK. tests: Mark streaming output as buggy on MoltenVK. tests: Mark some sampling tests as buggy on MoltenVK. vkd3d-shader/spirv: Specify behavior for bit field instructions. tests: Use a uint target for rendering uint data. vkd3d: Specify the aspect when creating NULL UAVs. ci: Dumps the d3d12 summary line in the CI log. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/531

2 10

[PATCH 0/1] MR4743: include: Assert that the debug channel name will be null-terminated and is not too long.
by Brendan Shanks (＠bshanks) 26 Dec '23

26 Dec '23

Currently, a 15 character debug channel name (e.g. `WINE_DEFAULT_DEBUG_CHANNEL(mediacontroller)`) results in no null-terminator at the end of the debug channel name array (`char name[15]`), and no compiler warning. A 16+ character name does throw an excess-initializers warning. Arguably, the debug channel name should be treated as a fixed-length string and not null-terminated, but this would require changes in a number of places (`winedbg`, `taskmgr`, `ntdll`, `winecrt0`). Also, overly-long channel names would still only result in truncation and a compiler warning rather than an error. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4743

2 1

[PATCH v8 0/8] MR531: Draft: vkd3d: Assorted fixes for MoltenVK.
by Giovanni Mascellani (＠giomasce) 26 Dec '23

26 Dec '23

-- v8: tests: Mark resource arrays as buggy on MoltenVK. tests: Mark unbounded ranges as buggy on MoltenVK. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/531

2 8

[PATCH v7 0/6] MR531: Draft: vkd3d: Assorted fixes for MoltenVK.
by Giovanni Mascellani (＠giomasce) 26 Dec '23

26 Dec '23

-- v7: tests: Mark predicated rendering as buggy on MoltenVK. tests: Mark streaming output as buggy on MoltenVK. tests: Mark some sampling tests as buggy on MoltenVK. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/531

2 6

[PATCH v6 0/5] MR531: Draft: vkd3d: Assorted fixes for MoltenVK.
by Giovanni Mascellani (＠giomasce) 26 Dec '23

26 Dec '23

-- v6: tests: Mark streaming output as buggy on MoltenVK. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/531

2 5

[PATCH v5 0/4] MR531: Draft: vkd3d: Assorted fixes for MoltenVK.
by Giovanni Mascellani (＠giomasce) 26 Dec '23

26 Dec '23

-- v5: tests: Mark some sampling tests as buggy on MoltenVK. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/531

2 4

[PATCH v4 0/3] MR531: Draft: vkd3d: Assorted fixes for MoltenVK.
by Giovanni Mascellani (＠giomasce) 26 Dec '23

26 Dec '23

-- v4: vkd3d-shader/spirv: Specify behavior for bit field instructions. tests: Use a uint target for rendering uint data. vkd3d: Specify the aspect when creating NULL UAVs. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/531

2 3

[PATCH v3 0/3] MR531: Draft: vkd3d: Assorted fixes for MoltenVK.
by Giovanni Mascellani (＠giomasce) 26 Dec '23

26 Dec '23

-- v3: vkd3d-shader/spirv: Specify behavior for bit field instructions. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/531

2 3

[PATCH v2 0/2] MR531: Draft: vkd3d: Assorted fixes for MoltenVK.
by Giovanni Mascellani (＠giomasce) 26 Dec '23

26 Dec '23

-- v2: tests: Use a uint target for rendering uint data. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/531

2 2

[PATCH 0/1] MR531: Draft: vkd3d: Assorted fixes for MoltenVK.
by Giovanni Mascellani (＠giomasce) 26 Dec '23

26 Dec '23

-- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/531

2 1

[PATCH 0/1] MR4742: server: Allow PROCESS_QUERY_INFORMATION on LIMITED handle.
by Bernhard Übelacker (＠bernhardu) 26 Dec '23

26 Dec '23

A handle created with just PROCESS_QUERY_LIMITED_INFORMATION should be returned when queried with PROCESS_QUERY_INFORMATION. Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=56093 -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4742

3 2

[PATCH 0/1] MR4736: wineandroid: fix incorrect checking reason.
by Fan WenJie (＠fanwenjie) 25 Dec '23

25 Dec '23

Signed-off-by: Fan WenJie <fanwj(a)mail.ustc.edu.cn> -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4736

3 2

Re: [PATCH v2 0/1] MR4655: ntdll: loader_init() invoke breakpoint before loading dlls - approved
by Jinoh Kang (＠iamahuman) 25 Dec '23

25 Dec '23

This merge request was approved by Jinoh Kang. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4655

1 0

Re: [PATCH v2 0/1] MR4655: ntdll: loader_init() invoke breakpoint before loading dlls
by Jinoh Kang (＠iamahuman) 25 Dec '23

25 Dec '23

You're correct that debuggers can be sensitive to the timing of the initial breakpoint. Adding a conformance test would let us confirm your observation, and ensure such regression won't happen in the future. For reference, see 2b40969c58a099f958c58909b666915991a42979. I'm still approving since the existing tests did not fail and I cannot find a particular reason `process_breakpoint();` must be placed exactly there in the commit history. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4655#note_56412

1 0

[PATCH v2 0/1] MR4703: dmime: Fix handling of curve PMSG.
by Yuxuan Shui (＠yshui) 24 Dec '23

24 Dec '23

DMUS_PMSG::dwType is the type of the message, but we are comparing it to curve types. We should be using DMUS_CURVE_PMSG::bType instead. * * * (I tried to write some test cases for this. I created a IDirectMusicPort implementation that checks the generated midi commands, but instead I cannot get Windows to generate any midi commands for CCCURVEs. ) -- v2: dmime: Fix handling of curve PMSG. https://gitlab.winehq.org/wine/wine/-/merge_requests/4703

4 5

[PATCH 0/1] MR4739: ntdll: Don't hardcode page size
by Fabian Maurer (＠DarkShadow44) 24 Dec '23

24 Dec '23

While this is not needed for 16k pages to work, it does seem sensible. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4739

2 1

[PATCH 0/1] MR4734: gdiplus: Avoid use of temporary variable
by David Kahurani (＠kahurani) 23 Dec '23

23 Dec '23

A temporary variable is used here to assist with assignment but this does not conform to the coding style in the rest of gdiplus and introduces an unnecessary variable. Signed-off-by: David Kahurani <k.kahurani(a)gmail.com> -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4734

3 3

[PATCH v3 0/2] MR4735: advapi32/tests: Don't run wow64 tests on 32-bit Windows
by Sven Baars (＠sbaars) 23 Dec '23

23 Dec '23

This should fix some test failures in other components. Wine-Bug: https://bugs.winehq.org//show_bug.cgi?id=54613 -- v3: advapi32/tests: Skip WoW64 tests on 32-bit in test_reg_create_key. https://gitlab.winehq.org/wine/wine/-/merge_requests/4735

2 2

[PATCH v2 0/2] MR4735: advapi32/tests: Don't run wow64 tests on 32-bit Windows
by Sven Baars (＠sbaars) 23 Dec '23

23 Dec '23

This should fix some test failures in other components. Wine-Bug: https://bugs.winehq.org//show_bug.cgi?id=54613 -- v2: advapi32/tests: Use has_wow64() in the test_reg_create_key test. advapi32/tests: Introduce a new has_wow64 helper. https://gitlab.winehq.org/wine/wine/-/merge_requests/4735

3 3

[PATCH 0/2] MR4735: advapi32/tests: Don't run wow64 tests on 32-bit Windows
by Sven Baars (＠sbaars) 23 Dec '23

23 Dec '23

This should fix some test failures in other components. Wine-Bug: https://bugs.winehq.org//show_bug.cgi?id=54613 -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4735

3 3

[PATCH v2 0/1] MR4720: Implement test_continue() for amd64
by Dāvis Mosāns (davispuh) (＠davispuh) 23 Dec '23

23 Dec '23

Currently there is `NtContinue()` test only for `aarch64` so implement it for amd64 aswell. This implementation is very similar to `aarch64` and it's very basic test. It doesn't change/test `ContextFlags` so it won't catch https://bugs.winehq.org/show_bug.cgi?id=56050 but that can be implemented later on top of this. -- v2: ntdll/tests: Implement test_continue() for amd64 https://gitlab.winehq.org/wine/wine/-/merge_requests/4720

4 10

Re: [PATCH v2 0/1] MR4733: dxdiagn: Check ICreateDevEnum_CreateClassEnumerator result for S_OK. - approved
by Alexandre Julliard (＠julliard) 22 Dec '23

22 Dec '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4733

1 0

Re: [PATCH v2 0/1] MR4732: winedbg: Fix main module detection in 'info share' command. - approved
by Alexandre Julliard (＠julliard) 22 Dec '23

22 Dec '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4732

1 0

Re: [PATCH v3 0/5] MR4702: dmime/tests: Multiple fixes for various Windows test failures. - approved
by Alexandre Julliard (＠julliard) 22 Dec '23

22 Dec '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4702

1 0

Re: [PATCH v2 0/1] MR4731: include: Fix boolean return value definition in IIterator<T> methods. - approved
by Alexandre Julliard (＠julliard) 22 Dec '23

22 Dec '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4731

1 0

[PATCH v17 0/7] MR450: vkd3d-shader/ir: Flatten structured control flow instructions.
by Conor McCarthy (＠cmccarthy) 22 Dec '23

22 Dec '23

-- v17: vkd3d-shader/ir: Store code block names in struct vkd3d_shader_desc. vkd3d-shader/ir: Flatten SWITCH/CASE/DEFAULT/ENDSWITCH control flow instructions. vkd3d-shader/ir: Flatten LOOP/BREAK/CONTINUE/ENDLOOP control flow instructions. vkd3d-shader/ir: Flatten IF/ELSE/ENDIF control flow instructions. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/450

3 10

[PATCH 0/1] MR4733: dxdiagn: Check ICreateDevEnum_CreateClassEnumerator result for S_OK.
by Paul Gofman (＠gofman) 22 Dec '23

22 Dec '23

CreateClassEnumerator() can return S_FALSE and NULL moniker if the specified category is empty or doesn't exist (and devenum implementation can do that), build_directshowfilters_tree() will crash in that case. That's not new and AFAIU should not be normally hit as the category should not be empty, but I managed to hit that on some prefix (maybe with messed up direct show registration) and the change looks simple and sure enough probably (currently it will always crash if gets S_FALSE). -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4733

2 1

[PATCH 0/1] MR4731: include: Fix boolean return value definition in IIterator<T> methods.
by Paul Gofman (＠gofman) 22 Dec '23

22 Dec '23

The practical effect of the change is that boolean is 1 byte while BOOL is 4 bytes, so we are wrongly filling more bytes in those methods and wrongly expect full 4 byte BOOL value to be filled from apps IIterator implemenation (and thus depend on uninitialized data in implementation). That fixes a hang on new game start in Phasmophobia (when it is configured to use windows.media.speech). That was originally attributed as a regression from commit 62173699c38453777c7d5638ed2e779790506b75 ("include: Don't align the stack for PE builds.") while before that commit it worked by chance only of course, the commit only changed stack data a bit so we were a bit more lucky in getting high bytes of BOOL as 0 in windows.media.speech/vector.c:vector_hstring_create_copy(). -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4731

5 4

[PATCH 0/1] MR4732: winedbg: Fix main module detection in 'info share' command.
by eric pouech (＠epo) 22 Dec '23

22 Dec '23

Signed-off-by: Eric Pouech <epouech(a)codeweavers.com> -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4732

3 2

[PATCH v6 0/5] MR530: Draft: Add a few validation checks.
by Giovanni Mascellani (＠giomasce) 22 Dec '23

22 Dec '23

-- v6: https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/530

2 5

Re: [PATCH v2 0/1] MR4730: dbghelp/tests: Wait for child window to be up before testing. - approved
by Alexandre Julliard (＠julliard) 21 Dec '23

21 Dec '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4730

1 0

Re: [PATCH v4 0/2] MR4676: server: Only update the global cursor if the pointer is inside the thread's windows. - approved
by Alexandre Julliard (＠julliard) 21 Dec '23

21 Dec '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4676

1 0

Re: [PATCH v4 0/1] MR4726: server: Always release internal hardware messages - approved
by Alexandre Julliard (＠julliard) 21 Dec '23

21 Dec '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4726

1 0

Re: [PATCH v2 0/2] MR4729: dnsapi: Update the array ptr in the insufficient buffer case. - approved
by Alexandre Julliard (＠julliard) 21 Dec '23

21 Dec '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4729

1 0

Re: [PATCH v2 0/1] MR4728: winmm: Fill in pIOProc field in MMIOINFO. - approved
by Alexandre Julliard (＠julliard) 21 Dec '23

21 Dec '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4728

1 0

[PATCH v4 0/4] MR530: Draft: Add a few validation checks.
by Giovanni Mascellani (＠giomasce) 21 Dec '23

21 Dec '23

-- v4: vkd3d-shader/ir: Validate destination write masks depending on the dimension. vkd3d-shader/ir: Validate source swizzles depending on the dimension. vkd3d-shader/ir: Validate SSA registers. vkd3d-shader/dxil: Create constant buffer registers with dimension vec4. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/530

2 4

[PATCH v3 0/3] MR530: Draft: Add a few validation checks.
by Giovanni Mascellani (＠giomasce) 21 Dec '23

21 Dec '23

-- v3: vkd3d-shader/ir: Validate destination write masks depending on the dimension. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/530

2 3

[PATCH v2 0/3] MR530: Draft: Add a few validation checks.
by Giovanni Mascellani (＠giomasce) 21 Dec '23

21 Dec '23

-- v2: vkd3d-shader/ir: Validate destination write masks depending on the dimension. vkd3d-shader/ir: Validate source swizzles depending on the dimension. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/530

2 3

[PATCH 0/1] MR511: vkd3d-shader/ir: Do not merge signature elements which have different interpolation modes.
by Conor McCarthy (＠cmccarthy) 21 Dec '23

21 Dec '23

Regression in signature normalisation, however the old code was not correct either because it would apply the interpolation mode to all components. Found in an Assassin's Creed: Valhalla shader. -- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/511

4 5

[PATCH 0/1] MR4730: dbghelp/tests: Wait for child window to be up before testing.
by eric pouech (＠epo) 21 Dec '23

21 Dec '23

Signed-off-by: Eric Pouech <epouech(a)codeweavers.com> -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4730

2 2

[PATCH 0/3] MR530: Draft: Add a few validation checks.
by Giovanni Mascellani (＠giomasce) 21 Dec '23

21 Dec '23

-- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/530

2 3

[PATCH 0/2] MR4729: dnsapi: Update the array ptr in the insufficient buffer case.
by Huw Davies (＠huw) 21 Dec '23

21 Dec '23

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/4729

3 3

[PATCH 0/1] MR4728: winmm: Fill in pIOProc field in MMIOINFO.
by eric pouech (＠epo) 21 Dec '23

21 Dec '23

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=55942 Signed-off-by: Eric Pouech <epouech(a)codeweavers.com> -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4728

3 2

[PATCH v3 0/2] MR4676: server: Only update the global cursor if the pointer is inside the thread's windows.
by Rémi Bernon (＠rbernon) 21 Dec '23

21 Dec '23

We are preferring the thread input cursor over the global desktop cursor, but if the thread input has no cursor yet, for instance when thread is attached to another thread without a message queue yet, it will end up being invisible. Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=55961 -- v3: server: Change desktop cursor only when inside the thread's windows. server: Introduce a new get_desktop_cursor_thread_input helper. https://gitlab.winehq.org/wine/wine/-/merge_requests/4676

2 3

[PATCH v3 0/1] MR4726: server: Always release internal hardware messages
by Brendan McGrath (＠redmcg) 21 Dec '23

21 Dec '23

This fixes an issue seen in Outlook 365 where the password prompt appears to lock up. Technically this fixes a regression introduced in 25906eedd8679fdb474976563f4a05a92e11bbd6, but I think Outlook had other issues that would have masked this one at the time. -- v3: server: Always release internal hardware messages https://gitlab.winehq.org/wine/wine/-/merge_requests/4726

3 3

Re: [PATCH v2 0/2] MR4726: server: Always release internal hardware messages
by Rémi Bernon (＠rbernon) 21 Dec '23

21 Dec '23

I'm not sure we need a test for that btw. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4726#note_56344

1 0

Re: [PATCH v2 0/2] MR4726: server: Always release internal hardware messages
by Rémi Bernon (＠rbernon) 21 Dec '23

21 Dec '23

Rémi Bernon (@rbernon) commented about server/queue.c: > > data->hw_id = msg->unique_id; > set_reply_data( msg->data, msg->data_size ); > - if (get_hardware_msg_bit( msg->msg ) == QS_RAWINPUT && (flags & PM_REMOVE)) > + if (get_hardware_msg_bit( msg->msg ) == QS_RAWINPUT && > + ((flags & PM_REMOVE) || is_internal_hardware_message( msg->msg ))) ```suggestion:-1+0 if ((get_hardware_msg_bit( msg->msg ) == QS_RAWINPUT && (flags & PM_REMOVE)) || is_internal_hardware_message( msg->msg ))) ``` -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4726#note_56343

1 0

Re: [PATCH v2 0/2] MR4726: server: Always release internal hardware messages
by Rémi Bernon (＠rbernon) 21 Dec '23

21 Dec '23

Rémi Bernon (@rbernon) commented about server/queue.c: > } > } > > +/* is this message an internal driver notification message */ > +static inline BOOL is_internal_hardware_message( unsigned int message ) > +{ > + return (message >= WM_WINE_CLIPCURSOR && message <= WM_WINE_LAST_DRIVER_MSG); I'd use the same range that's used for peeking the messages: ```suggestion:-0+0 return (message >= WM_WINE_FIRST_DRIVER_MSG && message <= WM_WINE_LAST_DRIVER_MSG); ``` -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4726#note_56342

1 0

[PATCH 0/1] MR4727: advapi32: Add TreeSetNamedSecurityInfoW stub.
by Alex Henrie (＠alexhenrie) 21 Dec '23

21 Dec '23

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=56055 -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4727

2 1

[PATCH 0/2] MR4726: server: Always release internal hardware messages
by Brendan McGrath (＠redmcg) 21 Dec '23

21 Dec '23

This fixes an issue seen in Outlook 365 where the password prompt appears to lock up. Technically this fixes a regression introduced in 25906eedd8679fdb474976563f4a05a92e11bbd6, but I think Outlook had other issues that would have masked this one at the time. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4726

3 3

[PATCH v5 0/3] MR514: tests: Use the vulkan runner to run SM1 compilation tests.
by Francisco Casas (＠fcasas) 21 Dec '23

21 Dec '23

Recap: My previous proposals to extend the shader_runner to SM1 were focusing on separating compilation tests ([shader] directives) from execution tests ([test] directives), and let the generic shader_runner.c:compile_shader() in charge of the former. However, Henri was more inclined to aim for making the parser agnostic to the language of the tests so we can potentially extend the shader_runner tests to other languages such as d3d-asm. This means, removing the burden of compilation from the parser altogether, and moving it to the runners, probably through a runner->compile function pointer (even if most of them end up doing the same thing, compiling with vkd3d-shader or the native compiler, depending on availability). Agreeing with going in this general direction, this MR contains patches to do SM1 compilation calling run_shader_tests() for SM1 profiles from the Vulkan runner (skipping execution for now), and some improvements to the qualifiers syntax. Despite this, there are parallel discussions on: - Whether to name the shader models individually in the [require] directives or expressing the range of shader models where the test should pass. In the latter case, whether to run for all shader models, only the lowest one in the SM1, SM4, and SM6 groups, or to allow the runner to select a shader model within the range (I feel strongly against this now, I think the runner should just retrieve a boolean in runner->check_requirements). - Where to do the iteration across different shader models, if in run_shader_tests() or expect each runner to call run_shader_tests() several times as we do now. But there is no need to settle on something for these yet. --- Now, what may be the most noisy part of this MR is that even though we are calling run_shader_tests() through the Vulkan runner, this will result in calling shader_runner.c:compile_shader() instead of shader_runner_vulkan.c:compile_shader(), but if we follow the "making the parser agnostic" plan, we eventually should get rid of shader_runner.c:compile_shader() and introduce the runner->compile pointer instead. -- v5: tests: Use the vulkan runner to run SM1 compilation tests. tests/shader-runner: Call each runner only once. tests/shader-runner: Support reading multiple model range args for qualifiers. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/514

2 5

Re: [PATCH v3 0/1] MR4725: qcap/audiorecord: Do not leak the sample when pausing or stopping. - approved
by Alexandre Julliard (＠julliard) 20 Dec '23

20 Dec '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4725

1 0

Re: [PATCH v5 0/2] MR4699: wined3d: Store the resource heap memory pointer directly. - approved
by Alexandre Julliard (＠julliard) 20 Dec '23

20 Dec '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4699

1 0

Re: [PATCH v5 0/1] MR4674: comctl32/listview: Ignore the lParam to WM_PRINTCLIENT and add tests. - approved
by Alexandre Julliard (＠julliard) 20 Dec '23

20 Dec '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4674

1 0

Re: [PATCH v2 0/1] MR4722: msdasql/tests: Add missing carriage returns - approved
by Alexandre Julliard (＠julliard) 20 Dec '23

20 Dec '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4722

1 0

[PATCH 0/1] MR4724: evr/dshow: Handle YUY2 sample copy.
by Nikolay Sivov (＠nsivov) 20 Dec '23

20 Dec '23

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=53810 This bug is marked as a regression, however I don't see it crashing on my system, with current wine. I do however get a black screen instead of the intro video. This fix helps. I think it's fine to wait for 9.0 without this MR, but also might be nice to get it working. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4724

3 4

[PATCH v15 0/7] MR443: tests: Add some tests for effects groups syntax.
by Nikolay Sivov (＠nsivov) 20 Dec '23

20 Dec '23

Signed-off-by: Nikolay Sivov <nsivov(a)codeweavers.com> -- v15: vkd3d-shader/tpf: Add initial support for writing fx_4_0/fx_4_1 binaries. vkd3d-shader: Add separate binary target type for effects. vkd3d-shader/hlsl: Handle effect group statement. vkd3d-shader/hlsl: Add variables for techniques. vkd3d-shader/hlsl: Rename rule for top-level techniques. vkd3d-shader/hlsl: Add 'fxgroup' token. tests: Add some tests for effects groups syntax. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/443

2 7

[PATCH v4 0/2] MR4699: wined3d: Store the resource heap memory pointer directly.
by Rémi Bernon (＠rbernon) 20 Dec '23

20 Dec '23

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=55773 -- v4: wined3d: Store the resource heap memory pointer separately. wined3d: Add more padding to resource memory allocations. https://gitlab.winehq.org/wine/wine/-/merge_requests/4699

3 4

[PATCH v14 0/7] MR443: tests: Add some tests for effects groups syntax.
by Nikolay Sivov (＠nsivov) 20 Dec '23

20 Dec '23

Signed-off-by: Nikolay Sivov <nsivov(a)codeweavers.com> -- v14: vkd3d-shader/tpf: Add initial support for writing fx_4_0/fx_4_1 binaries. vkd3d-shader: Add separate binary target type for effects. vkd3d-shader/hlsl: Handle effect group statement. vkd3d-shader/hlsl: Add variables for techniques. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/443

4 15

[PATCH 0/1] MR4725: qcap/audiorecord: Do not leak the sample when pausing or stopping.
by Zebediah Figura (＠zfigura) 20 Dec '23

20 Dec '23

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/4725

2 1

[PATCH 0/2] MR4720: Implement test_continue() for amd64
by Dāvis Mosāns (davispuh) (＠davispuh) 20 Dec '23

20 Dec '23

Currently there is `NtContinue()` test only for `aarch64` so implement it for amd64 aswell. This implementation is very similar to `aarch64` and it's very basic test. It doesn't change/test `ContextFlags` so it won't catch https://bugs.winehq.org/show_bug.cgi?id=56050 but that can be implemented later on top of this. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4720

3 3

[PATCH v13 0/7] MR443: tests: Add some tests for effects groups syntax.
by Nikolay Sivov (＠nsivov) 20 Dec '23

20 Dec '23

Signed-off-by: Nikolay Sivov <nsivov(a)codeweavers.com> -- v13: vkd3d-shader/tpf: Add initial support for writing fx_4_0/fx_4_1 binaries. vkd3d-shader: Add separate binary target type for effects. vkd3d-shader/hlsl: Handle effect group statement. vkd3d-shader/hlsl: Add variables for techniques. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/443

3 11

[PATCH v4 0/1] MR4674: comctl32/listview: Ignore the lParam to WM_PRINTCLIENT and add tests.
by Alex Henrie (＠alexhenrie) 20 Dec '23

20 Dec '23

Based on simliar patch for comctl32/treeview: 231199bc46 WM_PRINTCLIENT paints the items of a listview, including the item backgrounds, but never the listview background. Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=54878 Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=55005 Co-authored-by: Bernhard Übelacker <bernhardu(a)mailbox.org> -- v4: comctl32/listview: Ignore the lParam to WM_PRINTCLIENT and add tests. https://gitlab.winehq.org/wine/wine/-/merge_requests/4674

4 3

[PATCH v2 0/1] MR4676: server: Use the desktop cursor as the default thread input cursor.
by Rémi Bernon (＠rbernon) 20 Dec '23

20 Dec '23

We are preferring the thread input cursor over the global desktop cursor, but if the thread input has no cursor yet, for instance when thread is attached to another thread without a message queue yet, it will end up being invisible. Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=55961 -- v2: server: Use the desktop cursor as the default thread input cursor. https://gitlab.winehq.org/wine/wine/-/merge_requests/4676

3 4

[PATCH v3 0/2] MR4022: wined3d: Expose the image view usage to the Vulkan driver.
by Giovanni Mascellani (＠giomasce) 20 Dec '23

20 Dec '23

Some driver, e.g. MoltenVK, fail in some cases if the image view usage is too broad or unknown. -- v3: wined3d: Expose the image view usage for non-default views. wined3d: Expose the image view usage for null views. https://gitlab.winehq.org/wine/wine/-/merge_requests/4022

3 5

[PATCH v2 0/3] MR4022: wined3d: Expose the image view usage to the Vulkan driver.
by Giovanni Mascellani (＠giomasce) 20 Dec '23

20 Dec '23

Some driver, e.g. MoltenVK, fail in some cases if the image view usage is too broad or unknown. -- v2: wined3d: Expose the image view usage for non-default views. wined3d: Expose the image view usage for null views. wined3d: Mark an extension as supported if it is core for the Vulkan version in use. https://gitlab.winehq.org/wine/wine/-/merge_requests/4022

2 3

[PATCH 0/1] MR4723: tbs: Add GetDeviceIDString stub.
by Alex Henrie (＠alexhenrie) 20 Dec '23

20 Dec '23

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=56054 -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4723

2 1

[PATCH v4 0/1] MR4698: winewayland.drv: Add unaccelerated pointer support
by Grigory Vasilyev (＠h0tc0d3) 20 Dec '23

20 Dec '23

Adds an env variable WINE_WAYLAND_UNACCELERATED_POINTER which allows raw input. This makes it easier to calculate the same sensitivity in different games, use sensitivity calculators, and easily change values when changing DPI and do not depend on the compositor or OS. For example, you want to set the sensitivity to half as much, and sensitivity curves in libinput are more difficult to calculate than in the games themselves. -- v4: winewayland.drv: Add unaccelerated pointer support https://gitlab.winehq.org/wine/wine/-/merge_requests/4698

4 5

[PATCH 0/1] MR4721: wow64: Set WOW32Reserved to wow64 gate in process_init().
by Paul Gofman (＠gofman) 19 Dec '23

19 Dec '23

Fixes a regression introduced by cbcfaab5191838f8738989fcad7fcb2c490fbe98 Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=56053 -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4721

2 3

Re: [PATCH v3 0/1] MR4708: winedbg: Retrieve module architecture before sorting. - approved
by Alexandre Julliard (＠julliard) 19 Dec '23

19 Dec '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4708

1 0

Re: [PATCH v2 0/1] MR4719: imm32/tests: Fix HKL comparison when cleaning up preload list. - approved
by Alexandre Julliard (＠julliard) 19 Dec '23

19 Dec '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4719

1 0

Re: [PATCH v2 0/2] MR4717: user32/tests: Add more display DC tests. - approved
by Alexandre Julliard (＠julliard) 19 Dec '23

19 Dec '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4717

1 0

Re: [PATCH v3 0/1] MR4664: wineps: Don't leak memory in error case (Coverity) - approved
by Alexandre Julliard (＠julliard) 19 Dec '23

19 Dec '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4664

1 0

Re: [PATCH v2 0/1] MR4718: po: Update Catalan translation. - approved
by Alexandre Julliard (＠julliard) 19 Dec '23

19 Dec '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4718

1 0

[PATCH 0/1] MR4722: msdasql/tests: Add missing carriage returns
by Alistair Leslie-Hughes (＠alesliehughes) 19 Dec '23

19 Dec '23

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/4722

2 1

[PATCH 0/1] MR4719: imm32/tests: Fix HKL comparison when cleaning up preload list.
by Rémi Bernon (＠rbernon) 19 Dec '23

19 Dec '23

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/4719

3 2

[PATCH 0/2] MR4717: user32/tests: Add more display DC tests.
by Zhiyi Zhang (＠zhiyi) 19 Dec '23

19 Dec '23

Test that passing the bitmap object from display DCs to GetDIBits() should succeed. Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=54381 -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4717

3 3

[PATCH v2 0/1] MR4664: wineps: Don't leak memory in error case (Coverity)
by Fabian Maurer (＠DarkShadow44) 19 Dec '23

19 Dec '23

-- v2: wineps: Don't leak memory in error case (Coverity) https://gitlab.winehq.org/wine/wine/-/merge_requests/4664

3 2

[PATCH 0/1] MR4718: po: Update Catalan translation.
by Alex Henrie (＠alexhenrie) 19 Dec '23

19 Dec '23

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/4718

2 1

[PATCH 0/1] MR4685: readme.md: Added a markdown readme with text formatting.
by Zachary Petzinger (＠zepetzi) 19 Dec '23

19 Dec '23

Convert README to Markdown and apply formatting enhancements -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4685

2 2

Re: [PATCH v4 0/6] MR4522: winewayland.drv: part 10.3: Vulkan swapchain presentation
by Vixea (＠Vixea) 19 Dec '23

19 Dec '23

On Mon Dec 18 12:14:13 2023 +0000, beh 591 wrote: > @afrantzis just a quick question > ```plaintext > 00d8:err:d3d:wined3d_caps_gl_ctx_create Failed to find a suitable pixel format. > 00d8:err:d3d:wined3d_adapter_gl_init Failed to get a GL context for > adapter 00007F53BC3F2D50. > ``` > is this a bug that has to do with that opengl support you are talking about > well genshin impact works but its launcher doesn't so yeah just woundering > maybe this is already a known bug or something > * it works in the x11 side thats because opengl support isn't in the upstream winewayland driver so of course something that uses opengl won't work -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4522#note_56256

1 0

Re: [PATCH v4 0/6] MR4522: winewayland.drv: part 10.3: Vulkan swapchain presentation
by Vixea (＠Vixea) 19 Dec '23

19 Dec '23

On Tue Dec 19 00:06:57 2023 +0000, Shmerl wrote: > https://gitlab.winehq.org/wine/wine/-/merge_requests/4593 oh so Cyberpunk isn't affected by the Roblox issue and it was just before the mouselock patch of course it would be broken I thought you were talking about after that was upstreamed -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4522#note_56255

1 0

Re: [PATCH v4 0/6] MR4522: winewayland.drv: part 10.3: Vulkan swapchain presentation
by Shmerl (＠shmerl) 19 Dec '23

19 Dec '23

On Tue Dec 19 00:07:21 2023 +0000, Vixea wrote: > what commit might have been a different issue? > anyway there was a bug in the original patch which that link was(just > updated to work with the newer commits) here's one that's updated and > has a bug fixed. > https://cdn.discordapp.com/attachments/1099853933712773193/1186432765906923… https://gitlab.winehq.org/wine/wine/-/merge_requests/4593 -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4522#note_56253

1 0

2025

2024

2023

2022

wine-gitlab