- wine-gitlab - winehq.org

[PATCH 0/1] MR521: tests: Test assigning multisampled textures with different sample counts.
by Giovanni Mascellani (＠giomasce) 13 Dec '23

13 Dec '23

-- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/521

3 2

Re: [PATCH v5 0/5] MR519: vkd3d-shader/dxil: Support minimum precision.
by Henri Verbeet (＠hverbeet) 13 Dec '23

13 Dec '23

> ```diff > -#if defined(SONAME_LIBDXCOMPILER) && !defined(VKD3D_CROSSTEST) > +#if defined(SONAME_LIBDXCOMPILER) || defined(VKD3D_CROSSTEST) > ``` Should that just be "#if defined(SONAME_LIBDXCOMPILER)"? We could perhaps consider defining SONAME_LIBDXCOMPILER to "dxcompiler.dll" if it isn't already defined and we have VKD3D_CROSSTEST, but in principle I don't think VKD3D_CROSSTEST needs special handling here. -- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/519#note_55909

1 0

[PATCH v6 0/4] MR292: vkd3d: Write Vulkan descriptors in a worker thread.
by Conor McCarthy (＠cmccarthy) 13 Dec '23

13 Dec '23

-- v6: vkd3d: Co-locate all descriptor-related members. vkd3d: Rename the device mutex to pipeline_cache_mutex. vkd3d: Write Vulkan descriptors in a worker thread. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/292

3 5

[PATCH v4 0/5] MR519: vkd3d-shader/dxil: Support minimum precision.
by Conor McCarthy (＠cmccarthy) 13 Dec '23

13 Dec '23

-- v4: vkd3d-shader/dxil: Support 16-bit types. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/519

2 5

[PATCH v2 0/1] MR4679: winewayland.drv: Release all keys on keyboard focus loss.
by Alexandros Frantzis (＠afrantzis) 13 Dec '23

13 Dec '23

The Wayland specification states about the keyboard leave event: After this event client must assume that all keys, including modifiers, are lifted and also it must stop key repeating if there's some going on. Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=56001 --- To replicate a manifestation of the problem: 1. Open notepad 2. Hold down a key, wait for repetition to begin 3. While keeping key pressed, change focus to some other window (e.g. click away) 4. Key keeps repeating in notepad forever (lifting the key has no effect now, since the keyboard focus has been lost) -- v2: winewayland.drv: Release all keys on keyboard focus loss. https://gitlab.winehq.org/wine/wine/-/merge_requests/4679

2 2

[PATCH 0/1] MR4688: explorer: Handle WM_CLOSE for docked icons for when they lose embedding.
by Rémi Bernon (＠rbernon) 13 Dec '23

13 Dec '23

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=56015 This is roughly what the winex11 code was doing before 48e6bf3cf1aabdd2ac640f572416b9169e324f21. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4688

2 1

[PATCH 0/1] MR4687: dnsapi/tests: Don't test extra records returned for CNAME query.
by Hans Leidekker (＠hans) 13 Dec '23

13 Dec '23

It depends on DNS configuration. Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=54847 -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4687

2 1

[PATCH 0/1] MR4674: comctl32/listview: Ignore the lParam to WM_PRINTCLIENT and add tests.
by Alex Henrie (＠alexhenrie) 13 Dec '23

13 Dec '23

Based on simliar patch for comctl32/treeview: 231199bc46 WM_PRINTCLIENT paints the items of a listview, including the item backgrounds, but never the listview background. Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=54878 Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=55005 Co-authored-by: Alex Henrie <alexhenrie24(a)gmail.com> -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4674

3 5

[PATCH 0/2] MR4683: ntdll: Restore fs32_sel only if pthread TEB was not set already in init_handler.
by Rémi Bernon (＠rbernon) 13 Dec '23

13 Dec '23

Fixes spurious crashes in Steam when downloading games. The download causes a huge amount of SIGUSR1 signals, and it becomes very likely that one signal will be received while being inside the syscall or unix call dispatchers. When this happens, it can be received within the small range of instructions where %fs has been restored but we have not yet switched to the syscall stack, or the other way around in the return path. The signal handler then was restoring the 32bit %fs while returning to the syscall dispatcher, then we are entering a syscall with %fs set to the wrong value. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4683

3 5

[PATCH v2 0/1] MR4677: server: Peek wine internal driver messages regardless of filter.
by Rémi Bernon (＠rbernon) 13 Dec '23

13 Dec '23

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=55774 -- v2: server: Peek wine internal driver messages regardless of filter. https://gitlab.winehq.org/wine/wine/-/merge_requests/4677

2 2

[PATCH v2 0/5] MR519: vkd3d-shader/dxil: Support minimum precision.
by Conor McCarthy (＠cmccarthy) 13 Dec '23

13 Dec '23

-- v2: vkd3d-shader/dxil: Support 16-bit types. vkd3d-shader/spirv: Introduce HALF and UINT16 types for minimum precision. vkd3d-shader/spirv: Introduce a data_type_is_floating_point() helper function. tests/shader-runner: Add tests for minimum-precision constants. tests/shader-runner: Run Shader Model 6 tests in the crossbuild. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/519

2 5

[PATCH 0/5] MR519: vkd3d-shader/dxil: Support minimum precision.
by Conor McCarthy (＠cmccarthy) 13 Dec '23

13 Dec '23

-- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/519

2 6

[PATCH v6 0/3] MR3369: mf/tests: Test sample processing for MPEG4 media sink.
by Ziqing Hui (＠zhui) 13 Dec '23

13 Dec '23

-- v6: mf/tests: Test IMFClockStateSink in shutdown state. mf/tests: Add initial tests for MPEG4 media sink sample processing. mf/tests: Use IMFMediaEventGenerator interface in event wait helper. https://gitlab.winehq.org/wine/wine/-/merge_requests/3369

3 8

[PATCH v13 0/4] MR3554: mmdevapi: fixes for Yousician
by David McFarland (＠corngood) 13 Dec '23

13 Dec '23

Since Yousician's last update, it was throwing an error when initialising audio output. Unfortunately I don't have access to the old version, but they seem to have dropped win<10 support, and are using only IAudioClient3_InitializeSharedAudioStream. They also use IDeviceTopology to get the type of the first output connector. This is the bare minimum I needed to get it working. -- v13: mmdevapi: add stub for IDeviceTopology mmdevapi/tests: add test for IDeviceTopology mmdevapi: implement IAudioClient3_InitializeSharedAudioStream mmdevapi/tests: add test for AudioClient3_InitializeSharedAudioStream https://gitlab.winehq.org/wine/wine/-/merge_requests/3554

3 5

Re: [PATCH v3 0/1] MR4675: mf/tests: Workaround broken Win7 test_h264_decoder_concat_streams result. - approved
by Alexandre Julliard (＠julliard) 12 Dec '23

12 Dec '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4675

1 0

Re: [PATCH v2 0/1] MR4681: comctl32/tests: Store old DPI awareness context. - approved
by Alexandre Julliard (＠julliard) 12 Dec '23

12 Dec '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4681

1 0

Re: [PATCH v2 0/1] MR4651: winewayland.drv: Avoid transient deactivation of foreground thread. - approved
by Alexandre Julliard (＠julliard) 12 Dec '23

12 Dec '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4651

1 0

Re: [PATCH v2 0/1] MR4660: gdiplus: Fix invalid pointer returned when failing to create font - approved
by Alexandre Julliard (＠julliard) 12 Dec '23

12 Dec '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4660

1 0

Re: [PATCH v2 0/1] MR4678: winebus: Return backend init status from bus_main_thread_start. - approved
by Alexandre Julliard (＠julliard) 12 Dec '23

12 Dec '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4678

1 0

Re: [PATCH v4 0/5] MR502: vkd3d-shader/d3d-asm: Add an "internal" mode for the ASM dumper. - approved
by Alexandre Julliard (＠julliard) 12 Dec '23

12 Dec '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/502

1 0

Re: [PATCH v11 0/7] MR489: vkd3d-shader: Prepare for 64-bit integer support. - approved
by Alexandre Julliard (＠julliard) 12 Dec '23

12 Dec '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/489

1 0

[PATCH v6 0/3] MR504: ci: Validate the SPIR-V code.
by Giovanni Mascellani (＠giomasce) 12 Dec '23

12 Dec '23

In order to validate SPIR-V code we have to fix a little bug that causes us to emit invalid SPIR-V code in some cases. That's technically a bug, so it should be good to fix it in 1.10; unfortunately the way the bug is fixed right now is not ideal, because in some cases it causes many push constants to be wasted, potentially reaching the Vulkan implementation limit, so some application that used to work might stop working. Eventually we should implement a better allocator for push constants, and include an alternative path if the Vulkan implementation doesn't offer enough push constants. -- v6: ci: Build vkd3d with SPIRV-Tools. vkd3d-shader/spirv: Honor force_validation after emitting SPIR-V code. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/504

2 4

[PATCH v5 0/3] MR504: ci: Validate the SPIR-V code.
by Giovanni Mascellani (＠giomasce) 12 Dec '23

12 Dec '23

In order to validate SPIR-V code we have to fix a little bug that causes us to emit invalid SPIR-V code in some cases. That's technically a bug, so it should be good to fix it in 1.10; unfortunately the way the bug is fixed right now is not ideal, because in some cases it causes many push constants to be wasted, potentially reaching the Vulkan implementation limit, so some application that used to work might stop working. Eventually we should implement a better allocator for push constants, and include an alternative path if the Vulkan implementation doesn't offer enough push constants. -- v5: ci: Build vkd3d with SPIRV-Tools. vkd3d-shader/spirv: Honor force_validation after emitting SPIR-V code. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/504

4 6

[PATCH v7 0/2] MR4545: mf: Fix restarting a paused media session.
by Yuxuan Shui (＠yshui) 12 Dec '23

12 Dec '23

-- v7: mf: Only preroll when starting from stopped state. mf/tests: Add test cases for evr events. https://gitlab.winehq.org/wine/wine/-/merge_requests/4545

3 10

[PATCH 0/4] MR473: tests/shader-runner: Run SM1 compilation in the shader runner, part 1.
by Francisco Casas (＠fcasas) 12 Dec '23

12 Dec '23

Like the previous MRs, this has the objective of: * Preparing the way for SM1-specific tests. * Running SM1 compilation tests, even if we don't have a runner available to execute them (yet). * Allowing different runners to run through the shader_test file several times, targeting different shader model ranges. The current plan is: * We won't separate compilation tests from execution tests as in !418. * Instead of naming individual shader models in the shader_test files as in !434, we will keep working with the shader model ranges provided in the [require] directives. * We will test SM1 compilation going through the shader_test file twice with the vulkan runner, one for SM1 models and other for SM4 models, and for now we will just give a "todo" for execution tests until they are implemented (@zfigura patches). This first part only includes facilities to properly mark SM1-specific tests (as required by !458) and some refactoring to better work with the idea of intersecting shader model ranges. -- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/473

5 21

[PATCH v11 0/5] MR4661: Draft: gdiplus: Implement Gdiplus effects
by Vijay Kiran Kamuju (＠infyquest) 12 Dec '23

12 Dec '23

Implement effect related functions in Gdiplus. This currently a WIP. -- v11: gdiplus: Add GdipGetEffectParameters implementation. gdiplus: Add GdipSetEffectsParameters implementation. gdiplus: Add GdipGetEffectParameterSize implementation. gdiplus: Add GdipCreateEffect implementation. https://gitlab.winehq.org/wine/wine/-/merge_requests/4661

3 8

[PATCH v3 0/5] MR502: vkd3d-shader/d3d-asm: Add an "internal" mode for the ASM dumper.
by Giovanni Mascellani (＠giomasce) 12 Dec '23

12 Dec '23

-- v3: vkd3d-shader/d3d-asm: Add an "internal" mode for the ASM dumper. vkd3d-shader/d3d-asm: Dump unknown types as "<unknown>". vkd3d-shader/d3d-asm: Dump recently added types. vkd3d-shader/d3d-asm: Write a single type in shader_dump_data_type(). vkd3d-shader/d3d-asm: Indent on IFC. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/502

3 8

[PATCH v10 0/7] MR489: vkd3d-shader: Prepare for 64-bit integer support.
by Conor McCarthy (＠cmccarthy) 12 Dec '23

12 Dec '23

-- v10: vkd3d-shader/spirv: Introduce a compiler feature flag for int64 capability. tests/shader-runner: Add 64-bit bitwise tests. tests/shader-runner: Add 64-bit arithmetic tests. tests/shader-runner: Introduce a 'float64' requirement directive. tests/shader-runner: Introduce an 'int64' requirement directive. vkd3d-shader/spirv: Emit an error if 64-bit integers are used. vkd3d-shader: Introduce an instruction flag to suppress masking of bitwise shift counts. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/489

4 10

[PATCH v5 0/2] MR3405: server: Use the capture window as cursor window if it is set.
by Rémi Bernon (＠rbernon) 12 Dec '23

12 Dec '23

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=55306 -- v5: server: Use the capture window as cursor window if it is set. server: Update the desktop cursor position / window on click. https://gitlab.winehq.org/wine/wine/-/merge_requests/3405

2 3

Re: [PATCH v3 0/2] MR3405: server: Use the capture window as cursor window if it is set.
by Rémi Bernon (＠rbernon) 12 Dec '23

12 Dec '23

On Tue Dec 12 18:22:51 2023 +0000, Vladimir Panteleev wrote: > Thank you again for working on this fix. The CI failure looks unrelated, > perhaps rebase on `master` and it will go away? Oh right, I thought I did that. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3405#note_55829

1 0

Re: [PATCH v3 0/2] MR3405: server: Use the capture window as cursor window if it is set.
by Vladimir Panteleev (＠CyberShadow) 12 Dec '23

12 Dec '23

On Tue Dec 12 18:22:51 2023 +0000, Rémi Bernon wrote: > This was meant to fix a regression, anything wrong with it? Thank you again for working on this fix. The CI failure looks unrelated, perhaps rebase on `master` and it will go away? -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3405#note_55826

1 0

[PATCH v2 0/2] MR4640: jscript: Make the garbage collector thread-wide rather than per-ctx.
by Gabriel Ivăncescu (＠insn) 12 Dec '23

12 Dec '23

-- v2: jscript: Allow garbage collection between different jscript contexts. jscript: Make the garbage collector thread-wide rather than per-ctx. https://gitlab.winehq.org/wine/wine/-/merge_requests/4640

3 5

[PATCH v10 0/5] MR4661: Draft: gdiplus: Implement Gdiplus effects
by Vijay Kiran Kamuju (＠infyquest) 12 Dec '23

12 Dec '23

Implement effect related functions in Gdiplus. This currently a WIP. -- v10: gdiplus: Add GdipGetEffectParameters implementation. gdiplus: Add GdipSetEffectsParameters implementation. gdiplus: Add GdipGetEffectParameterSize implementation. https://gitlab.winehq.org/wine/wine/-/merge_requests/4661

3 7

[PATCH v9 0/7] MR489: vkd3d-shader: Prepare for 64-bit integer support.
by Conor McCarthy (＠cmccarthy) 12 Dec '23

12 Dec '23

-- v9: vkd3d-shader/spirv: Introduce a compiler feature flag for int64 capability. tests/shader-runner: Add 64-bit bitwise tests. tests/shader-runner: Add 64-bit arithmetic tests. tests/shader-runner: Introduce a 'float64' requirement directive. tests/shader-runner: Introduce an 'int64' requirement directive. vkd3d-shader/spirv: Emit an error if 64-bit integers are used. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/489

2 7

[PATCH 0/1] MR4681: comctl32/tests: Store old DPI awareness context.
by Akihiro Sagawa (＠sgwaki) 12 Dec '23

12 Dec '23

Otherwise, the context will not be saved in `test_themed_background()`. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4681

3 2

[PATCH 0/1] MR4680: Draft: winewayland.drv: Consider implicit fullscreen clip for pointer locking.
by Alexandros Frantzis (＠afrantzis) 12 Dec '23

12 Dec '23

If the foreground window is fullscreen on the whole virtual screen, allow the pointer to be locked (if the cursor is hidden), even if we don't have an explicit fullscreen clip. Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=55995 -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4680

2 1

[PATCH 0/1] MR4679: Draft: winewayland.drv: Release all keys on keyboard focus loss.
by Alexandros Frantzis (＠afrantzis) 12 Dec '23

12 Dec '23

The Wayland specification states about the keyboard leave event: After this event client must assume that all keys, including modifiers, are lifted and also it must stop key repeating if there's some going on. Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=56001 --- To replicate a manifestation of the problem: 1. Open notepad 2. Hold down a key, wait for repetition to begin 3. While keeping key pressed, change focus to some other window (e.g. click away) 4. Key keeps repeating in notepad forever (lifting the key has no effect now, since the keyboard focus has been lost) -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4679

2 1

[PATCH v2 0/1] MR4675: mf/tests: Workaround broken Win7 test_h264_decoder_concat_streams result.
by Rémi Bernon (＠rbernon) 12 Dec '23

12 Dec '23

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=55638 -- v2: mf/tests: Workaround broken Win7 test_h264_decoder_concat_streams result. https://gitlab.winehq.org/wine/wine/-/merge_requests/4675

2 1

[PATCH 0/1] MR4675: mf/tests: Workaround broken Win7 test_h264_decoder_concat_streams result.
by Rémi Bernon (＠rbernon) 12 Dec '23

12 Dec '23

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=55638 -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4675

3 2

[PATCH 0/1] MR4678: winebus: Return backend init status from bus_main_thread_start.
by Rémi Bernon (＠rbernon) 12 Dec '23

12 Dec '23

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=54361 -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4678

2 1

Re: [PATCH v3 0/2] MR3405: server: Use the capture window as cursor window if it is set.
by Rémi Bernon (＠rbernon) 12 Dec '23

12 Dec '23

This was meant to fix a regression, anything wrong with it? -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3405#note_55801

1 0

[PATCH 0/1] MR4677: server: Peek wine internal driver messages regardless of filter.
by Rémi Bernon (＠rbernon) 12 Dec '23

12 Dec '23

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=55774 -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4677

2 1

[PATCH 0/3] MR514: tests: Use the vulkan runner to run SM1 compilation tests.
by Francisco Casas (＠fcasas) 12 Dec '23

12 Dec '23

Recap: My previous proposals to extend the shader_runner to SM1 were focusing on separating compilation tests ([shader] directives) from execution tests ([test] directives), and let the generic shader_runner.c:compile_shader() in charge of the former. However, Henri was more inclined to aim for making the parser agnostic to the language of the tests so we can potentially extend the shader_runner tests to other languages such as d3d-asm. This means, removing the burden of compilation from the parser altogether, and moving it to the runners, probably through a runner->compile function pointer (even if most of them end up doing the same thing, compiling with vkd3d-shader or the native compiler, depending on availability). Agreeing with going in this general direction, this MR contains patches to do SM1 compilation calling run_shader_tests() for SM1 profiles from the Vulkan runner (skipping execution for now), and some improvements to the qualifiers syntax. Despite this, there are a parallel discussion on: - Whether to name the shader models individually in the [require] directives or expressing the range of shader models where the test should pass. In the latter case, whether to run for all shader models, only the lowest one in the SM1, SM4, and SM6 groups, or to allow the runner to select a shader model within the range (I feel strongly against this now, I think the runner should just retrieve a boolean in runner->check_requirements). - Where to do the iteration across different shader models, if in run_shader_tests() or expect each runner to call run_shader_tests() several times as we do now. But there is no need to settle on something yet. --- Now, what may be the most noisy part of this MR is that even though we are calling run_shader_tests() through the Vulkan runner, this will result in calling shader_runner.c:compile_shader() instead of shader_runner_vulkan.c:compile_shader(), but if we follow the "making the parser agnostic" plan, we eventually should get rid of shader_runner.c:compile_shader() and introduce the runner->compile pointer instead. -- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/514

4 7

[PATCH 0/1] MR3338: wined3d: Identity AMD as valid gl vendor string.
by Etaash Mathamsetty (＠etaash.mathamsetty) 12 Dec '23

12 Dec '23

Is it just me, or am I getting déjà vu from this (a third time ?) -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3338

4 16

[PATCH v2 0/2] MR4672: Draft: msdelta: Add ApplyDelta stub.
by Vijay Kiran Kamuju (＠infyquest) 12 Dec '23

12 Dec '23

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=56007 -- v2: msdelta: Add ApplyDelta stub. include: Add msdelta header file. https://gitlab.winehq.org/wine/wine/-/merge_requests/4672

3 3

Re: [PATCH v5 0/1] MR4666: gdiplus: Prevent uninitializd memory access (Coverity)
by Fabian Maurer (＠DarkShadow44) 12 Dec '23

12 Dec '23

On Tue Dec 12 00:19:53 2023 +0000, Nikolay Sivov wrote: > No, sorry for confusion. Uninitialized access issue seems to be about > that one record. It is documented in EMF+ specification. According to the spec a previous location of 0 is assumed. For me, this implies that the first element should not always be `0`, but be `0 + points[0]` IMHO, EmfPlusRecordTypeDrawImagePoints look correct and this wrong. A test could clear this up, but I'm not exactly sure on how to write one. Any tips? -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4666#note_55782

1 0

[PATCH v7 0/5] MR4661: Draft: gdiplus: Implement Gdiplus effects
by Vijay Kiran Kamuju (＠infyquest) 12 Dec '23

12 Dec '23

Implement effect related functions in Gdiplus. This currently a WIP. -- v7: gdiplus: Add GdipGetEffectParameters implementation. gdiplus: Add GdipSetEffectsParameters implementation. gdiplus: Add GdipGetEffectParameterSize implementation. gdiplus: Add GdipCreateEffect implementation. https://gitlab.winehq.org/wine/wine/-/merge_requests/4661

2 5

Re: [PATCH v5 0/1] MR4666: gdiplus: Prevent uninitializd memory access (Coverity)
by Nikolay Sivov (＠nsivov) 12 Dec '23

12 Dec '23

On Tue Dec 12 00:02:25 2023 +0000, Fabian Maurer wrote: > This MR is about playback for EmfPlusRecordTypeFillClosedCurve, or is > there something else I missed? > Regarding EmfPlusRecordTypeDrawImagePoints, is that 'P' flag documented > somehwere? Because we don't seem to have a test for that either. No, sorry for confusion. Uninitialized access issue seems to be about that one record. It is documented in EMF+ specification. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4666#note_55775

1 0

Re: [PATCH v5 0/1] MR4666: gdiplus: Prevent uninitializd memory access (Coverity)
by Fabian Maurer (＠DarkShadow44) 12 Dec '23

12 Dec '23

On Tue Dec 12 00:02:25 2023 +0000, Nikolay Sivov wrote: > Playback for EmfPlusRecordTypeFillClosedCurve has the same issue, and > EmfPlusRecordTypeDrawImagePoints was already broken because it starts > from first delta point instead of a zero origin. This MR is about playback for EmfPlusRecordTypeFillClosedCurve, or is there something else I missed? Regarding EmfPlusRecordTypeDrawImagePoints, is that 'P' flag documented somehwere? Because we don't seem to have a test for that either. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4666#note_55774

1 0

Re: [PATCH v2 0/2] MR4669: Fix PDB reading. - approved
by Alexandre Julliard (＠julliard) 11 Dec '23

11 Dec '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4669

1 0

Re: [PATCH v2 0/2] MR4670: Don't fail on extraneous COFF stream indexes. - approved
by Alexandre Julliard (＠julliard) 11 Dec '23

11 Dec '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4670

1 0

Re: [PATCH v5 0/1] MR4666: gdiplus: Prevent uninitializd memory access (Coverity) - approved
by Alexandre Julliard (＠julliard) 11 Dec '23

11 Dec '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4666

1 0

Re: [PATCH v3 0/1] MR4663: winex11: Do window search if IDropTarget::DragOver() returns DROPEFFECT_NONE. - approved
by Alexandre Julliard (＠julliard) 11 Dec '23

11 Dec '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4663

1 0

Re: [PATCH v2 0/1] MR4671: ntdll: Declare seh debug channel in signal_arm64ec.c. - approved
by Alexandre Julliard (＠julliard) 11 Dec '23

11 Dec '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4671

1 0

Re: [PATCH v2 0/2] MR4628: configure: Enable -Wenum-conversion warnings. - approved
by Alexandre Julliard (＠julliard) 11 Dec '23

11 Dec '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4628

1 0

Re: [PATCH v2 0/1] MR4668: winewayland.drv: Avoid deadlock when determining whether a window is managed. - approved
by Alexandre Julliard (＠julliard) 11 Dec '23

11 Dec '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4668

1 0

Re: [PATCH v2 0/1] MR4673: po: Update Dutch translation. - approved
by Alexandre Julliard (＠julliard) 11 Dec '23

11 Dec '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4673

1 0

Re: [PATCH v4 0/1] MR4659: po: Update Polish translation. - approved
by Alexandre Julliard (＠julliard) 11 Dec '23

11 Dec '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4659

1 0

Re: [PATCH v2 0/1] MR4657: po: Update Lithuanian translation. - approved
by Alexandre Julliard (＠julliard) 11 Dec '23

11 Dec '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4657

1 0

Re: [PATCH v2 0/1] MR517: vkd3d-shader/dxil: Check null pointer before it is dereferenced (Coverity) - approved
by Alexandre Julliard (＠julliard) 11 Dec '23

11 Dec '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/517

1 0

Re: [PATCH v8 0/5] MR498: vkd3d-shader/dxil: Implement the DXIL ALLOCA and STORE instructions. - approved
by Alexandre Julliard (＠julliard) 11 Dec '23

11 Dec '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/498

1 0

Re: [PATCH v4 0/5] MR464: vkd3d-shader/spirv: Declare I/O registers from the signature. - approved
by Alexandre Julliard (＠julliard) 11 Dec '23

11 Dec '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/464

1 0

[PATCH 0/1] MR4673: po: Update Dutch translation.
by Floris Renaud (＠jkfloris) 11 Dec '23

11 Dec '23

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/4673

2 1

[PATCH v6 0/5] MR4661: Draft: gdiplus: Implement Gdiplus effects
by Vijay Kiran Kamuju (＠infyquest) 11 Dec '23

11 Dec '23

Implement effect related functions in Gdiplus. This currently a WIP. -- v6: gdiplus: Add GdipGetEffectParameters implementation. gdiplus: Add GdipSetEffectsParameters implementation. gdiplus: Add GdipGetEffectParameterSize implementation. gdiplus: Add GdipCreateEffect implementation. include: Add gdiplus effect parameter structs. https://gitlab.winehq.org/wine/wine/-/merge_requests/4661

4 19

[PATCH v8 0/6] MR489: vkd3d-shader: Prepare for 64-bit integer support.
by Conor McCarthy (＠cmccarthy) 11 Dec '23

11 Dec '23

-- v8: vkd3d-shader/spirv: Introduce a compiler feature flag for int64 capability. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/489

3 7

[PATCH v12 0/3] MR450: vkd3d-shader/ir: Flatten structured control flow instructions.
by Conor McCarthy (＠cmccarthy) 11 Dec '23

11 Dec '23

-- v12: vkd3d-shader/ir: Store code block names in struct vkd3d_shader_desc. vkd3d-shader/ir: Flatten structured control flow instructions. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/450

3 4

[PATCH v5 0/4] MR292: vkd3d: Write Vulkan descriptors in a worker thread.
by Conor McCarthy (＠cmccarthy) 11 Dec '23

11 Dec '23

-- v5: vkd3d: Co-locate all descriptor-related members. vkd3d: Rename the device mutex to pipeline_cache_mutex. vkd3d: Write Vulkan descriptors in a worker thread. vkd3d: Update the descriptor `next` index before getting a reference for writing. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/292

3 6

[PATCH v5 0/2] MR4658: gidplus: Add GdipGetEffectParameterSize stub, fix GdipDeleteEffect and update test.
by Bartosz Kosiorek (＠gang65) 11 Dec '23

11 Dec '23

-- v5: gdiplus/test: Add GdipGetEffectParameterSize test. https://gitlab.winehq.org/wine/wine/-/merge_requests/4658

3 3

[PATCH 0/1] MR517: vkd3d-shader/dxil: Check null pointer before it is dereferenced (Coverity)
by Fabian Maurer (＠DarkShadow44) 11 Dec '23

11 Dec '23

-- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/517

5 4

[PATCH v7 0/5] MR498: vkd3d-shader/dxil: Implement the DXIL ALLOCA and STORE instructions.
by Conor McCarthy (＠cmccarthy) 11 Dec '23

11 Dec '23

-- v7: tests/shader-runner: Add a non-const-indexing test for asfloat() result storage. vkd3d-shader/spirv: Bitcast if necessary in the spirv_compiler_emit_mov() general implementation. vkd3d-shader/dxil: Implement the DXIL STORE instruction. vkd3d-shader/dxil: Implement the DXIL ALLOCA instruction. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/498

3 6

[PATCH v3 0/5] MR464: vkd3d-shader/spirv: Declare I/O registers from the signature.
by Zebediah Figura (＠zfigura) 11 Dec '23

11 Dec '23

-- v3: vkd3d-shader/dxil: No longer synthesize DCL instructions. vkd3d-shader/spirv: Declare I/O registers from the signature. vkd3d-shader/dxil: Map SEMANTIC_KIND_TARGET to VKD3D_SHADER_SV_TARGET. vkd3d-shader/tpf: Do not uninvert used masks for domain shader patch constants. vkd3d-shader/spirv: Do not use the output_info array for patch constants. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/464

3 7

[PATCH v4 0/3] MR504: ci: Validate the SPIR-V code.
by Giovanni Mascellani (＠giomasce) 11 Dec '23

11 Dec '23

In order to validate SPIR-V code we have to fix a little bug that causes us to emit invalid SPIR-V code in some cases. That's technically a bug, so it should be good to fix it in 1.10; unfortunately the way the bug is fixed right now is not ideal, because in some cases it causes many push constants to be wasted, potentially reaching the Vulkan implementation limit, so some application that used to work might stop working. Eventually we should implement a better allocator for push constants, and include an alternative path if the Vulkan implementation doesn't offer enough push constants. -- v4: ci: Build vkd3d with SPIRV-Tools. vkd3d-shader/spirv: Honor force_validation after emitting SPIR-V code. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/504

3 4

[PATCH 0/2] MR4672: Draft: msdelta: Add ApplyDelta stub.
by Vijay Kiran Kamuju (＠infyquest) 11 Dec '23

11 Dec '23

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=56007 -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4672

3 3

[PATCH v4 0/2] MR4658: gidplus: Add GdipGetEffectParameterSize stub, fix GdipDeleteEffect and update test.
by Bartosz Kosiorek (＠gang65) 11 Dec '23

11 Dec '23

-- v4: gdiplus/test: Add GdipGetEffectParameterSize test. https://gitlab.winehq.org/wine/wine/-/merge_requests/4658

3 3

[PATCH v4 0/1] MR4666: gdiplus: Prevent uninitializd memory access (Coverity)
by Fabian Maurer (＠DarkShadow44) 11 Dec '23

11 Dec '23

-- v4: gdiplus: Prevent uninitializd memory access (Coverity) https://gitlab.winehq.org/wine/wine/-/merge_requests/4666

4 4

[PATCH v3 0/11] MR4637: bcrypt DH improvements
by Hans Leidekker (＠hans) 11 Dec '23

11 Dec '23

Support for generating keys from known DH parameters is not included unfortunately because even the latest stable GnuTLS release doesn't have the necessary support. I have a patch that implements it using _gnutls_dh_generate_key() but that requires a special GnuTLS 3.8.2 build (--enable-fips140-mode). With that patch all included tests pass here. Paul, can you take a look? I included your tests so please approve this MR if you think it's okay. -- v3: bcrypt/tests: Add DH tests. bcrypt: Set dh_params in key_import_dh/_public(). bcrypt: Assume we have a public key in key_export_dh_public(). bcrypt: Make sure key_asymmetric_derive_key() returns correct size. bcrypt: Add support for generating DH keys from known parameters. bcrypt: Reject DH keys smaller than 512 bits. bcrypt: Make DH blob size validation more strict in key_import_pair(). bcrypt: Add helpers to create a public/private key pair. bcrypt: Allow or disallow some operations based on whether keys are finalized. bcrypt: Add support for retrieving DH parameters. bcrypt: Add support for setting DH parameters. https://gitlab.winehq.org/wine/wine/-/merge_requests/4637

3 13

[PATCH v2 0/1] MR4663: winex11: Do window search if IDropTarget::DragOver() returns DROPEFFECT_NONE.
by Akihiro Sagawa (＠sgwaki) 11 Dec '23

11 Dec '23

Fixes a regression from 1d337249f16ed61163315019f5dbbe4db3386390. Prior to the commit, we were solving this case in a different way. If `IDropTarget::DragOver()` returned `DROPEFFECT_NONE`, `X11DRV_XDND_DROPEFFECTToXdndAction()` would convert it to `XdndActionCopy`. Wine-Bugs: https://bugs.winehq.org/show_bug.cgi?id=55179 -- v2: winex11: Do window search if IDropTarget::DragOver() returns DROPEFFECT_NONE. https://gitlab.winehq.org/wine/wine/-/merge_requests/4663

3 3

[PATCH v6 0/5] MR498: vkd3d-shader/dxil: Implement the DXIL ALLOCA and STORE instructions.
by Conor McCarthy (＠cmccarthy) 11 Dec '23

11 Dec '23

-- v6: tests/shader-runner: Add a non-const-indexing test for asfloat() result storage. vkd3d-shader/spirv: Bitcast if necessary in the spirv_compiler_emit_mov() general implementation. vkd3d-shader/dxil: Implement the DXIL STORE instruction. vkd3d-shader/dxil: Implement the DXIL ALLOCA instruction. tests/shader-runner: Test an uninitialised indexable temp. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/498

3 7

[PATCH v3 0/6] MR4082: gdiplus: Implement font linking in GdipDrawString.
by Santino Mazza (＠tati1454) 11 Dec '23

11 Dec '23

-- v3: gdiplus: Implement font linking for gdiplus. gdiplus/tests: Add interactive test for font linking. mlang: Fix bug with codepage priority in GetStrCodePages. mlang/tests: Test codepages priority bug in GetStrCodepages. mlang: Implement GetGlobalFontLinkObject. mlang/tests: Test for GetGlobalFontLinkObject. https://gitlab.winehq.org/wine/wine/-/merge_requests/4082

3 7

[PATCH 0/1] MR4671: ntdll: Declare seh debug channel in signal_arm64ec.c.
by Jacek Caban (＠jacek) 11 Dec '23

11 Dec '23

Fixes the build. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4671

2 1

[PATCH v3 0/4] MR504: ci: Validate the SPIR-V code.
by Giovanni Mascellani (＠giomasce) 11 Dec '23

11 Dec '23

In order to validate SPIR-V code we have to fix a little bug that causes us to emit invalid SPIR-V code in some cases. That's technically a bug, so it should be good to fix it in 1.10; unfortunately the way the bug is fixed right now is not ideal, because in some cases it causes many push constants to be wasted, potentially reaching the Vulkan implementation limit, so some application that used to work might stop working. Eventually we should implement a better allocator for push constants, and include an alternative path if the Vulkan implementation doesn't offer enough push constants. -- v3: vkd3d-shader/spirv: Honor force_validation after emitting SPIR-V code. ci: Build vkd3d with SPIRV-Tools. vkd3d-shader/spirv: Move the SPIR-V dumper and validator below struct spirv_compiler. vkd3d: Pad push constant ranges to 16 bytes. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/504

2 4

[PATCH 0/2] MR4670: Don't fail on extraneous COFF stream indexes.
by eric pouech (＠epo) 11 Dec '23

11 Dec '23

Latests MS compiler seem to emit an extra COFF entry. Current code is too strict into accepting only predefined set of references. Just relax constraint for now. Will require a proper fix after code freeze. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4670

2 2

[PATCH 0/1] MR4663: winex11: Do window search if IDropTarget::DragOver() returns DROPEFFECT_NONE.
by Akihiro Sagawa (＠sgwaki) 11 Dec '23

11 Dec '23

Fixes a regression from 1d337249f16ed61163315019f5dbbe4db3386390. Prior to the commit, we were solving this case in a different way. If `IDropTarget::DragOver()` returned `DROPEFFECT_NONE`, `X11DRV_XDND_DROPEFFECTToXdndAction()` would convert it to `XdndActionCopy`. Wine-Bugs: https://bugs.winehq.org/show_bug.cgi?id=55179 -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4663

3 2

[PATCH 0/2] MR4669: Fix PDB reading.
by eric pouech (＠epo) 11 Dec '23

11 Dec '23

Seen with PDB generated with "latest" MS compiler. The data here is likely to be in the same form of other hash structures we already handle. (eg has a first vector to describe present entries, and a second one to describe deleteid entries; we were incorrectly expecting an empty deleted vector... so just skip for now the deleted vector in winedump and dbghelp... this will probably end up with a more generic code for reloading such hash structures, but after code freeze). -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4669

2 2

[PATCH v3 0/1] MR4659: po: Update Polish translation.
by Bartosz Kosiorek (＠gang65) 11 Dec '23

11 Dec '23

-- v3: po: Update Polish translation. https://gitlab.winehq.org/wine/wine/-/merge_requests/4659

2 1

[PATCH v11 0/3] MR450: vkd3d-shader/ir: Flatten structured control flow instructions.
by Conor McCarthy (＠cmccarthy) 11 Dec '23

11 Dec '23

-- v11: vkd3d-shader/ir: Store code block names in struct vkd3d_shader_desc. vkd3d-shader/ir: Flatten structured control flow instructions. vkd3d-shader/spirv: Emit descriptor offset loads in the function entry block. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/450

3 5

[PATCH v7 0/6] MR489: vkd3d-shader: Prepare for 64-bit integer support.
by Conor McCarthy (＠cmccarthy) 11 Dec '23

11 Dec '23

-- v7: vkd3d-shader/spirv: Introduce a compiler feature flag for int64 capability. tests/shader-runner: Add 64-bit bitwise tests. tests/shader-runner: Add 64-bit arithmetic tests. tests/shader-runner: Introduce an 'int64' requirement directive. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/489

3 8

[PATCH v2 0/1] MR4659: po: Update Polish translation.
by Bartosz Kosiorek (＠gang65) 11 Dec '23

11 Dec '23

-- v2: po: Update Polish translation. https://gitlab.winehq.org/wine/wine/-/merge_requests/4659

3 2

[PATCH v2 0/1] MR516: tests: Print the failing line numbers when a test fails.
by Petrichor Park (＠petrathekat) 11 Dec '23

11 Dec '23

Currently, if a probe fails, it will print the line number of the [test] block the probe is in, not the line number of the probe itself. This makes it somewhat difficult to debug. This commit makes it print the line number that a test fails at. This code was actually written by @hverbeet for my first attempt at fixing this, !499. CC @zfigura -- v2: tests: Print the failing line numbers when a test fails. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/516

3 2

[PATCH v2 0/9] MR4637: bcrypt DH improvements
by Hans Leidekker (＠hans) 11 Dec '23

11 Dec '23

Support for generating keys from known DH parameters is not included unfortunately because even the latest stable GnuTLS release doesn't have the necessary support. I have a patch that implements it using _gnutls_dh_generate_key() but that requires a special GnuTLS 3.8.2 build (--enable-fips140-mode). With that patch all included tests pass here. Paul, can you take a look? I included your tests so please approve this MR if you think it's okay. -- v2: bcrypt/tests: Add DH tests. bcrypt: Make sure key_asymmetric_derive_key() returns correct size. bcrypt: Add support for generating DH keys from known parameters. bcrypt: Reject DH keys smaller than 512 bits. bcrypt: Make DH blob size validation more strict in key_import_pair(). bcrypt: Add helpers to create a public/private key pair. bcrypt: Allow or disallow some operations based on whether keys are finalized. bcrypt: Add support for retrieving DH parameters. bcrypt: Add support for setting DH parameters. https://gitlab.winehq.org/wine/wine/-/merge_requests/4637

3 15

[PATCH 0/1] MR4668: winewayland.drv: Avoid deadlock when determining whether a window is managed.
by Alexandros Frantzis (＠afrantzis) 11 Dec '23

11 Dec '23

The is_window_managed function may acquire the (non-recursive) win_data lock internally (is_window_managed->has_owned_popups->is_managed), so do not call it with the win_data lock held. Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=55995 --- Note: WineX11 also calls `is_window_managed` with win_data locked, but its win_data mutex is recursive. I haven't found a compelling reason to use a recursive win_data mutex in the Wayland driver yet, hence this fix. --- A simple way to reproduce the deadlock is: 1. Run winecfg 2. Go to the "Desktop Integration" tab 3. Click on OK -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4668

2 1

[PATCH 0/4] MR504: ci: Validate the SPIR-V code.
by Giovanni Mascellani (＠giomasce) 11 Dec '23

11 Dec '23

In order to validate SPIR-V code we have to fix a little bug that causes us to emit invalid SPIR-V code in some cases. That's technically a bug, so it should be good to fix it in 1.10; unfortunately the way the bug is fixed right now is not ideal, because in some cases it causes many push constants to be wasted, potentially reaching the Vulkan implementation limit, so some application that used to work might stop working. Eventually we should implement a better allocator for push constants, and include an alternative path if the Vulkan implementation doesn't offer enough push constants. -- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/504

4 7

[PATCH 0/1] MR4660: gdiplus: Fix invalid pointer returned when failing to create font
by Hans Lehnert (＠hanslehnert) 11 Dec '23

11 Dec '23

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/4660

4 4

[PATCH v2 0/1] MR4666: gdiplus: Prevent uninitializd memory access (Coverity)
by Fabian Maurer (＠DarkShadow44) 11 Dec '23

11 Dec '23

-- v2: gdiplus: Prevent uninitializd memory access (Coverity) https://gitlab.winehq.org/wine/wine/-/merge_requests/4666

3 3

[PATCH v3 0/1] MR4666: gdiplus: Prevent uninitializd memory access (Coverity)
by Fabian Maurer (＠DarkShadow44) 11 Dec '23

11 Dec '23

-- v3: gdiplus: Prevent uninitializd memory access (Coverity) https://gitlab.winehq.org/wine/wine/-/merge_requests/4666

3 2

[PATCH v2 0/1] MR4665: winegstreamer: In error case don't dereference null pointer (Coverity)
by Fabian Maurer (＠DarkShadow44) 10 Dec '23

10 Dec '23

-- v2: winegstreamer: In error case don't dereference null pointer (Coverity) https://gitlab.winehq.org/wine/wine/-/merge_requests/4665

2 2

[PATCH 0/1] MR4665: winegstreamer: In error case don't dereference null pointer (Coverity)
by Fabian Maurer (＠DarkShadow44) 10 Dec '23

10 Dec '23

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/4665

3 5

[PATCH v3 0/2] MR4658: gidplus: Add GdipGetEffectParameterSize stub, fix GdipDeleteEffect and update test.
by Bartosz Kosiorek (＠gang65) 10 Dec '23

10 Dec '23

-- v3: gdiplus/test: Add GdipGetEffectParameterSize test. gdiplus: Add GdipGetEffectParameterSize stub and fix GdipDeleteEffect https://gitlab.winehq.org/wine/wine/-/merge_requests/4658

2 4

[PATCH 0/2] MR4628: configure: Enable -Wenum-conversion warnings.
by Jacek Caban (＠jacek) 10 Dec '23

10 Dec '23

Clang enables -Wenum-conversion by default. GCC does not, so this makes both configurations more similar. The extra dwrite is for Clang -Wenum-float-conversion warning, which is not enabled by default, but it's enabled when -Wenum-conversion is specified. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4628

3 3

[PATCH 0/1] MR4667: bcrypt: Initialize variable in all cases (Coverity)
by Fabian Maurer (＠DarkShadow44) 10 Dec '23

10 Dec '23

If both branches are false we would never initialize it. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4667

3 2

2025

2024

2023

2022

wine-gitlab