- wine-gitlab - winehq.org

[PATCH 0/1] MR4666: gdiplus: Prevent uninitializd memory access (Coverity)
by Fabian Maurer (＠DarkShadow44) 10 Dec '23

10 Dec '23

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/4666

2 1

[PATCH 0/2] MR4640: jscript: Make the garbage collector thread-wide rather than per-ctx.
by Gabriel Ivăncescu (＠insn) 10 Dec '23

10 Dec '23

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/4640

3 4

[PATCH v10 0/7] MR443: tests: Add some tests for effects groups syntax.
by Nikolay Sivov (＠nsivov) 09 Dec '23

09 Dec '23

Signed-off-by: Nikolay Sivov <nsivov(a)codeweavers.com> -- v10: vkd3d-shader/tpf: Initial support for writing fx_4_0/fx_4_1 binaries. vkd3d-shader: Add separate binary target type for effects. vkd3d-shader/hlsl: Handle effect group statement. vkd3d-shader/hlsl: Add variables for techniques. vkd3d-shader/hlsl: Rename rule for top-level techniques. vkd3d-shader/hlsl: Add 'fxgroup' token. tests: Add some tests for effects groups syntax. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/443

2 7

[PATCH v5 0/5] MR4661: Draft: gdiplus: Implement Gdiplus effects
by Vijay Kiran Kamuju (＠infyquest) 09 Dec '23

09 Dec '23

Implement effect related functions in Gdiplus. This currently a WIP. -- v5: gdiplus: Add GdipGetEffectParameters implementation. gdiplus: Add GdipSetEffectsParameters implementation. gdiplus: Add GdipGetEffectParameterSize implementation. https://gitlab.winehq.org/wine/wine/-/merge_requests/4661

3 6

[PATCH 0/1] MR4651: winewayland.drv: Avoid transient deactivation of foreground thread.
by Alexandros Frantzis (＠afrantzis) 09 Dec '23

09 Dec '23

When updating the foreground window, even if both the old and new active window belong to the same non-current thread, the win32u code currently explicitly deactivates the old window. This will cause the transient deactivation of the foreground thread which can lead to undesirable side-effects (e.g., some apps may minimize when they become inactive). Until this is fixed in Wine core, use an internal driver message to ensure that we call NtUserSetForegroundWindow from the context of the new foreground window thread, to avoid the problematic behavior. --- Assuming that the aforementioned NtUserSetForegroundWindow behavior is indeed incorrect, this should ideally be addressed in win32u, perhaps along the lines of https://gitlab.winehq.org/wine/wine/-/merge_requests/4593/diffs?commit_id=f…. However, given the time of year (freeze etc), the proposed mitigation is possibly a safer choice at this point for Wine. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4651

4 3

[PATCH v4 0/5] MR4661: Draft: gdiplus: Implement Gdiplus effects
by Vijay Kiran Kamuju (＠infyquest) 09 Dec '23

09 Dec '23

Implement effect related functions in Gdiplus. This currently a WIP. -- v4: gdiplus: Add GdipGetEffectParameters implementation. gdiplus: Add GdipSetEffectsParameters implementation. gdiplus: Add GdipGetEffectParameterSize implementation. https://gitlab.winehq.org/wine/wine/-/merge_requests/4661

3 6

[PATCH v3 0/5] MR4661: Draft: gdiplus: Implement Gdiplus effects
by Vijay Kiran Kamuju (＠infyquest) 09 Dec '23

09 Dec '23

Implement effect related functions in Gdiplus. This currently a WIP. -- v3: gdiplus: Add GdipGetEffectParameters implementation. gdiplus: Add GdipSetEffectsParameters implementation. https://gitlab.winehq.org/wine/wine/-/merge_requests/4661

4 8

[PATCH 0/2] MR4658: gidplus: Add GdipGetEffectParameterSize stub, fix GdipDeleteEffect and update test.
by Bartosz Kosiorek (＠gang65) 09 Dec '23

09 Dec '23

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/4658

5 7

[PATCH v4 0/2] MR4638: gdiplus: Partially implement GdipDrawImageFX.
by Jinoh Kang (＠iamahuman) 09 Dec '23

09 Dec '23

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=55945 Based on https://gitlab.winehq.org/gang65/wine/-/merge_requests/12. cc/ @gang65 -- v4: gdiplus: Partially implement GdipDrawImageFX. https://gitlab.winehq.org/wine/wine/-/merge_requests/4638

3 4

[PATCH v2 0/4] MR4661: Draft: gdiplus: Implement Gdiplus effects
by Vijay Kiran Kamuju (＠infyquest) 09 Dec '23

09 Dec '23

Implement effect related functions in Gdiplus. This currently a WIP. -- v2: gdiplus: Add GdipSetEffectsParameters implementation. https://gitlab.winehq.org/wine/wine/-/merge_requests/4661

3 5

[PATCH 0/5] MR4661: Draft: gdiplus: Implement Gdiplus effects
by Vijay Kiran Kamuju (＠infyquest) 09 Dec '23

09 Dec '23

Implement effect related functions in Gdiplus. This currently a WIP. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4661

3 6

[PATCH v5 0/1] MR4633: win32u: Fix key state not updating before WH_KEYBOARD hook
by Hans Lehnert (＠hanslehnert) 09 Dec '23

09 Dec '23

If a message is removed from the queue with PeekMessage/GetMessage, the key state should get updated before calling the WH_KEYBOARD hooks. -- v5: win32u: Fix key state not updating before WH_KEYBOARD hook https://gitlab.winehq.org/wine/wine/-/merge_requests/4633

3 2

[PATCH v3 0/2] MR4638: gdiplus: Partially implement GdipDrawImageFX.
by Jinoh Kang (＠iamahuman) 09 Dec '23

09 Dec '23

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=55945 Based on https://gitlab.winehq.org/gang65/wine/-/merge_requests/12. cc/ @gang65 -- v3: gdiplus: Partially implement GdipDrawImageFX. gdiplus/tests: Add GdipDrawImageFX tests except effects or attributes. https://gitlab.winehq.org/wine/wine/-/merge_requests/4638

2 5

[PATCH 0/1] MR4659: po: Update Polish translation.
by Bartosz Kosiorek (＠gang65) 09 Dec '23

09 Dec '23

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/4659

3 2

[PATCH 0/1] MR4657: po: Update Lithuanian translation.
by Aurimas Fišeras (＠AurimasF) 08 Dec '23

08 Dec '23

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/4657

3 2

Re: [PATCH v2 0/1] MR4630: explorer: Add an "Exit desktop" button to the Start menu. - approved
by Alexandre Julliard (＠julliard) 08 Dec '23

08 Dec '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4630

1 0

Re: [PATCH v4 0/1] MR4620: kernel32: Implement GetProcessInformation(ProcessMachineTypeInfo). - approved
by Alexandre Julliard (＠julliard) 08 Dec '23

08 Dec '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4620

1 0

Re: [PATCH v2 0/1] MR4641: winewayland.drv: Apply surface configuration during Vulkan presentation. - approved
by Alexandre Julliard (＠julliard) 08 Dec '23

08 Dec '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4641

1 0

Re: [PATCH v10 0/6] MR4484: comctl32: Use selected font to determine default min tab width - approved
by Alexandre Julliard (＠julliard) 08 Dec '23

08 Dec '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4484

1 0

Re: [PATCH v2 0/2] MR4649: user32/tests: Add tests for word breaks before punctuation - approved
by Alexandre Julliard (＠julliard) 08 Dec '23

08 Dec '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4649

1 0

Re: [PATCH v3 0/6] MR4625: wined3d: Reduce command stream CPU usage, part 2 - approved
by Alexandre Julliard (＠julliard) 08 Dec '23

08 Dec '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4625

1 0

Re: [PATCH v3 0/1] MR4648: po: Update Lithuanian translation. - approved
by Alexandre Julliard (＠julliard) 08 Dec '23

08 Dec '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4648

1 0

[PATCH 0/5] MR4656: quartz: Implement VMR7 renderless mode.
by Zebediah Figura (＠zfigura) 08 Dec '23

08 Dec '23

This isn't all of what Rewrite needs, but it's the large and risky part that would be inappropriate for code freeze. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4656

2 5

[PATCH 0/1] MR4655: ntdll: loader_init() invoke breakpoint before loading dlls
by Dāvis Mosāns (davispuh) (＠davispuh) 08 Dec '23

08 Dec '23

While using [x64dbg](https://x64dbg.com/) I was experiencing incredibly strange issue - `int3` was swallowed and `KiUserExceptionDispatcher` was never invoked. Turns out that x64dbg ([TitanEngine](https://github.com/x64dbg/TitanEngine/blob/x64dbg/TitanEngine/…) expects system breakpoint to be first breakpoint that will be triggered and it always swallows it (it's hardcoded no setting to change it's behavior). That means if you have a DLL with `int3` for example ```c LONG ExceptionHandler(EXCEPTION_POINTERS *ExceptionInfo) { ExceptionInfo->ContextRecord->Rip++; return EXCEPTION_CONTINUE_EXECUTION; } BOOL WINAPI DllMain(HINSTANCE hinstDLL, DWORD fdwReason, LPVOID lpvReserved) { if (fdwReason == DLL_PROCESS_ATTACH) { AddVectoredExceptionHandler(1, ExceptionHandler); asm("int $0x03; nop; nop;"); } return TRUE; } ``` That `int3` would be swallowed and `ExceptionHandler` never invoked when running under x64dbg. Now with this MR applied it works correctly and as expected (same as on Windows). Another interesting thing is that without this MR it wouldn't just swallow `int3` but even skip first `nop` aswell and RIP would end up on 2nd `nop`. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4655

2 1

[PATCH v3 0/1] MR4620: kernel32: Implement GetProcessInformation(ProcessMachineTypeInfo).
by Nikolay Sivov (＠nsivov) 08 Dec '23

08 Dec '23

Marking as a draft for now, until !4605 is merged first. -- v3: kernel32: Implement GetProcessInformation(ProcessMachineTypeInfo). https://gitlab.winehq.org/wine/wine/-/merge_requests/4620

3 3

[PATCH 0/1] MR4630: explorer: Add an "Exit desktop" button to the Start menu.
by Alex Henrie (＠alexhenrie) 08 Dec '23

08 Dec '23

When running `wine explorer.exe /desktop=shell` as a full-screen app, there is no obvious way to close it and return to the Linux desktop. Remedy that problem by adding an "Exit desktop" button to the Start menu in the same place as the "Shut Down" button on Windows. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4630

3 2

[PATCH v9 0/6] MR4484: comctl32: Use selected font to determine default min tab width
by Brendan McGrath (＠redmcg) 08 Dec '23

08 Dec '23

This fixes the layout of the tabcontrol when a font other than the system font is used. -- v9: comctl32/tests: Modify test_width to try different fonts comctl32/tests: Check size initially and after changing padding only comctl32/tests: Fix tabcontrol tests to work with different fonts comctl32: Use selected font to determine default min tab width https://gitlab.winehq.org/wine/wine/-/merge_requests/4484

3 8

Re: [PATCH v4 0/1] MR4393: gdiplus: Boost performance of GdipDrawImagePointsRect. - closed
by Esme Povirk (＠madewokherd) 08 Dec '23

08 Dec '23

This merge request was closed by Esme Povirk. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4393

1 0

Re: [PATCH v4 0/1] MR4393: gdiplus: Boost performance of GdipDrawImagePointsRect.
by Esme Povirk (＠madewokherd) 08 Dec '23

08 Dec '23

I agree, there's no reason to essentially inline floorf here. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4393#note_55554

1 0

[PATCH v2 0/2] MR4638: gdiplus: Partially implement GdipDrawImageFX.
by Jinoh Kang (＠iamahuman) 08 Dec '23

08 Dec '23

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=55945 Based on https://gitlab.winehq.org/gang65/wine/-/merge_requests/12. cc/ @gang65 -- v2: gdiplus: Partially implement GdipDrawImageFX. https://gitlab.winehq.org/wine/wine/-/merge_requests/4638

3 7

[PATCH v4 0/4] MR292: vkd3d: Write Vulkan descriptors in a worker thread.
by Conor McCarthy (＠cmccarthy) 08 Dec '23

08 Dec '23

-- v4: vkd3d: Co-locate all descriptor-related members. vkd3d: Rename the device mutex to pipeline_cache_mutex. vkd3d: Write Vulkan descriptors in a worker thread. vkd3d: Update the descriptor `next` index before getting a reference for writing. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/292

2 6

[PATCH v3 0/3] MR2343: Collection of small fixes for Fusion 360
by novenary * (＠novenary) 08 Dec '23

08 Dec '23

This fixes various problems I've run into while trying to use Fusion 360 in wine. - stacking issues in unmanaged mode - I also attempted to apply the same fix for managed mode, but it looks difficult to do this in a way that plays well with window managers; I think it's best left up to them to keep override_redirect windows at the top of the stack) - when the window manager sets our state to withdrawn, tell the window that it's been minimized, since the semantics are very similar - the last one is a hack because I don't really know what to do about it, when clicking on the floating popups, they gain focus, which causes wine to incorrectly make them managed and that breaks everything -- v3: winex11: don't let captionless popups be managed winex11: pass ICCCM withdrawn state as minimized winex11: restack a window's owned popups above it https://gitlab.winehq.org/wine/wine/-/merge_requests/2343

4 6

Re: [PATCH v6 0/5] MR4593: winewayland.drv: part 11: Mouselook support
by Alexandros Frantzis (＠afrantzis) 08 Dec '23

08 Dec '23

On Thu Dec 7 18:47:06 2023 +0000, Rémi Bernon wrote: > Well, code freeze is tomorrow so I don't intend to do anything soon. > You can submit it in a separate MR if you think it's critical for the > well behaving of the driver, and then @julliard will decide what to do > with it, but I would personally wait until we try to fix these > activation issues. Thanks. As a possibly more freeze-safe alternative, I proposed a mitigation in the driver itself https://gitlab.winehq.org/wine/wine/-/merge_requests/4651 . -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4593#note_55533

1 0

[PATCH v2 0/6] MR4625: wined3d: Reduce command stream CPU usage, part 2
by Matteo Bruni (＠Mystral) 08 Dec '23

08 Dec '23

These are all the patches in this area that I think make sense at this point in the release cycle (i.e. a couple of days before code freeze...) I originally had many more. A few are not really suitable at this time; a couple turned out to not really make a difference or generally not feeling like it would be an improvement overall. Many ended up in the way (or not in the spirit) of what we probably want to do at some point, which is grouping the whole draw state setup data together with the draw itself. Not that I could find the time to explore that yet... -- v2: wined3d: Add a bunch of d3d_perf traces. wined3d: Add a frametime debug channel. wined3d: Increase WINED3D_CS_QUERY_POLL_INTERVAL to 100. wined3d: Sleep when waiting for the CS thread. wined3d: Do a blocking wait for CS commands even when there are active queries. https://gitlab.winehq.org/wine/wine/-/merge_requests/4625

5 10

Re: [PATCH v6 0/5] MR4593: winewayland.drv: part 11: Mouselook support
by Vlad Zahorodnii (＠zzag) 08 Dec '23

08 Dec '23

> I have also seen this with KDE, and my current inclination is to say that this is a compositor problem. Looking at the logs it seems the driver is issuing the proper requests, but the cursor remains visible. Yeah, the wayland log looks okay. ``` [ 858989.759] -> wl_pointer(a)15.set_cursor(172832, nil, 0, 0) [ 858989.762] -> zwp_relative_pointer_manager_v1(a)10.get_relative_pointer(new id zwp_relative_pointer_v1@59, wl_pointer@15) [ 858990.080] -> wl_compositor(a)4.create_region(new id wl_region@57) [ 858990.083] -> wl_region(a)57.add(1280, 720, 0, 0) [ 858990.086] -> zwp_pointer_constraints_v1(a)9.confine_pointer(new id zwp_confined_pointer_v1@49, wl_surface@3, wl_pointer@15, wl_region@57, 2) ``` this should work, there's only one pointer enter event and no leave event before. Will check why kwin refuses to hide the cursor. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4593#note_55526

1 0

[PATCH v4 0/1] MR4633: winu32: Fix key state not updating before WH_KEYBOARD hook
by Hans Lehnert (＠hanslehnert) 08 Dec '23

08 Dec '23

If a message is removed from the queue with PeekMessage/GetMessage, the key state should get updated before calling the WH_KEYBOARD hooks. -- v4: winu32: Fix key state not updating before WH_KEYBOARD hook https://gitlab.winehq.org/wine/wine/-/merge_requests/4633

3 2

[PATCH v3 0/1] MR4566: ntdll/unix: Add an option to inherit the Unix console handle.
by Aida Jonikienė (＠DodoGTA) 08 Dec '23

08 Dec '23

I know this breaks Windows behavior but having apps print out special debug messages to the terminal provides a good look into the applications' development (for example I know that NFS Underground has some "done" messages likely used for debugging). I also don't want to keep another revert in my Wine tree just for this one feature either so that's why I'm MR'ing this. I considered adding a registry/winecfg entry for this behavior but it would make this change much larger (and there's no good place in winecfg to put this behavior in). To enable this behavior, you can set WINEDEBUG=+unixcon variable before launching an application. Xkcd-Entry: https://xkcd.com/1172/ Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=55435 -- v3: ntdll/unix: Add an option to inherit the Unix console handle. https://gitlab.winehq.org/wine/wine/-/merge_requests/4566

2 3

[PATCH v3 0/15] MR895: msxml3/tests: Filter attributes tests by version.
by Daniel Lehman (＠dlehman25) 08 Dec '23

08 Dec '23

Based on patch from Damjan Jovanovic <damjan.jov(a)gmail.com> https://bugs.winehq.org/show_bug.cgi?id=53531 -- v3: msxml3: Handle default namespace in get_namespaceURI. msxml3: Handle default namespace in get_prefix. msxml3: Handle default namespace in get_nodeName. msxml3: Handle default namespace in get_baseName. msxml3: Handle null prefix in get_item. msxml6/tests: Add tests for default namespace. msxml4/tests: Add tests for default namespace. msxml3/tests: Add tests for default namespace. msxml6/tests: Copy create namespace tests. msxml4/tests: Copy create namespace tests. msxml6/tests: Copy namespaces as attributes tests. msxml4/tests: Copy namespaces as attributes tests. msmxl3/tests: Add tests for get_xml. msxml3/tests: Remove msxml6 tests. msxml3/tests: Fix failure messages. https://gitlab.winehq.org/wine/wine/-/merge_requests/895

2 18

[PATCH 0/7] MR4637: bcrypt DH improvements
by Hans Leidekker (＠hans) 08 Dec '23

08 Dec '23

Support for generating keys from known DH parameters is not included unfortunately because even the latest stable GnuTLS release doesn't have the necessary support. I have a patch that implements it using _gnutls_dh_generate_key() but that requires a special GnuTLS 3.8.2 build (--enable-fips140-mode). With that patch all included tests pass here. Paul, can you take a look? I included your tests so please approve this MR if you think it's okay. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4637

3 14

Re: [PATCH v4 0/1] MR4393: gdiplus: Boost performance of GdipDrawImagePointsRect.
by Fabian Maurer (＠DarkShadow44) 08 Dec '23

08 Dec '23

Now that https://gitlab.winehq.org/wine/wine/-/commit/4b458775bb8c9492ac859cfd167c5f… is merged, is this still needed? IMHO this MR doesn't add any more performance now that the stack issue is solved. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4393#note_55509

1 0

[PATCH v3 0/13] MR490: Draft: vkd3d-shader: Int64 support.
by Conor McCarthy (＠cmccarthy) 08 Dec '23

08 Dec '23

Goes atop !489. The last 7 commits belong to this MR. Many of these patches are small, but the series can be split further if necessary. -- v3: vkd3d-shader/spirv: Handle ITOI and UTOU in spirv_compiler_map_alu_instruction(). vkd3d-shader/spirv: Support UINT64 source in spirv_compiler_emit_bool_cast(). vkd3d-shader/spirv: Support 64-bit sources in spirv_compiler_emit_int_div(). vkd3d-shader/spirv: Introduce a UINT64 component type. vkd3d-shader/spirv: Introduce a data_type_is_64_bit() helper function. vkd3d-shader/spirv: Use data_type_is_integer() in spirv_compiler_emit_neg(). vkd3d: Pass int64 capability info to vkd3d-shader. vkd3d-shader/spirv: Introduce a compiler feature flag for int64 capability. tests/shader-runner: Add 64-bit bitwise tests. tests/shader-runner: Add 64-bit arithmetic tests. tests/shader-runner: Introduce an 'int64' requirement directive. vkd3d-shader/spirv: Emit an error if 64-bit integers are used. vkd3d-shader: Introduce an instruction flag to suppress masking of bitwise shift counts. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/490

2 13

[PATCH v6 0/6] MR489: vkd3d-shader: Prepare for 64-bit integer support.
by Conor McCarthy (＠cmccarthy) 08 Dec '23

08 Dec '23

-- v6: vkd3d-shader/spirv: Introduce a compiler feature flag for int64 capability. tests/shader-runner: Add 64-bit bitwise tests. tests/shader-runner: Add 64-bit arithmetic tests. tests/shader-runner: Introduce a 'shader int64' requirement directive. vkd3d-shader/spirv: Emit an error if 64-bit integers are used. vkd3d-shader: Introduce an instruction flag to suppress masking of bitwise shift counts. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/489

2 6

[PATCH v5 0/6] MR489: vkd3d-shader: Prepare for 64-bit integer support.
by Conor McCarthy (＠cmccarthy) 08 Dec '23

08 Dec '23

This is ready for review, but may not go upstream until after the release. -- v5: vkd3d-shader/spirv: Introduce a compiler feature flag for int64 capability. tests/shader-runner: Add 64-bit bitwise tests. tests/shader-runner: Add 64-bit arithmetic tests. tests/shader-runner: Introduce a 'shader int64' requirement directive. vkd3d-shader/spirv: Emit an error if 64-bit integers are used. vkd3d-shader/dxil: Introduce an instruction flag to suppress masking of bitwise shift counts. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/489

2 6

Re: [PATCH 0/15] MR4650: Translation - closed
by joan-lucì Labòrda (＠joanluc) 07 Dec '23

07 Dec '23

This merge request was closed by joan-lucì Labòrda. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4650

1 0

Re: [PATCH 0/15] MR4650: Translation
by joan-lucì Labòrda (＠joanluc) 07 Dec '23

07 Dec '23

Update oc.po -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4650#note_55498

1 0

[PATCH 0/2] MR4649: user32/tests: Add tests for word breaks before punctuation
by Brendan McGrath (＠redmcg) 07 Dec '23

07 Dec '23

Whilst uniscribe won't break on the space here (see LB13 of the Unicode line breaking algorith), DrawText does -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4649

2 2

[PATCH 0/1] MR4648: po: Update Lithuanian translation.
by Aurimas Fišeras (＠AurimasF) 07 Dec '23

07 Dec '23

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/4648

3 2

[PATCH v3 0/4] MR4645: quartz: Partially implement the VMR7 presenter.
by Zebediah Figura (＠zfigura) 07 Dec '23

07 Dec '23

-- v3: quartz: Implement sample allocation in the VMR7 presenter. https://gitlab.winehq.org/wine/wine/-/merge_requests/4645

3 6

[PATCH 0/1] MR4646: kernel32: Export RtlIsEcCode().
by Billy Laws (＠bylaws) 07 Dec '23

07 Dec '23

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/4646

3 2

[PATCH 0/1] MR4642: configure: Use Wine includes for cross compiler checks.
by Jacek Caban (＠jacek) 07 Dec '23

07 Dec '23

C99 checks depend on stddef.h and stdarg.h. Those headers are usually shipped with compilers (and another copy of them as part of mingw-w64 for targets that use it), but some providers skip them. We use our own version during the build anyway, so we may use them for configure checks as well. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4642

3 2

Re: [PATCH v4 0/1] MR4577: user32: remove unneeded spec entry - closed
by Vijay Kiran Kamuju (＠infyquest) 07 Dec '23

07 Dec '23

This merge request was closed by Vijay Kiran Kamuju. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4577

1 0

Re: [PATCH v3 0/3] MR4609: winegstreamer: Some tiny fixes - approved
by Alexandre Julliard (＠julliard) 07 Dec '23

07 Dec '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4609

1 0

Re: [PATCH v2 0/1] MR4600: winegstreamer: Set streamheader field for h264 caps. - approved
by Alexandre Julliard (＠julliard) 07 Dec '23

07 Dec '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4600

1 0

Re: [PATCH v4 0/4] MR4645: quartz: Partially implement the VMR7 presenter. - approved
by Alexandre Julliard (＠julliard) 07 Dec '23

07 Dec '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4645

1 0

Re: [PATCH v2 0/1] MR4646: kernel32: Export RtlIsEcCode(). - approved
by Alexandre Julliard (＠julliard) 07 Dec '23

07 Dec '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4646

1 0

Re: [PATCH v4 0/1] MR4643: winevulkan: Update to VK spec version 1.3.272. - approved
by Alexandre Julliard (＠julliard) 07 Dec '23

07 Dec '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4643

1 0

Re: [PATCH v4 0/1] MR4618: dsound: Set position past the end of the buffer is invalid. - approved
by Alexandre Julliard (＠julliard) 07 Dec '23

07 Dec '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4618

1 0

Re: [PATCH v2 0/1] MR4644: winedump: Sync demangling code with msvcrt. - approved
by Alexandre Julliard (＠julliard) 07 Dec '23

07 Dec '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4644

1 0

Re: [PATCH v5 0/1] MR4615: vbscript: For for loop coerce right bound string to real. - approved
by Alexandre Julliard (＠julliard) 07 Dec '23

07 Dec '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4615

1 0

Re: [PATCH v2 0/1] MR4632: winecoreaudio: Use UID as device string. - approved
by Alexandre Julliard (＠julliard) 07 Dec '23

07 Dec '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4632

1 0

Re: [PATCH v3 0/3] MR4639: wineps: Pattern brush improvements - approved
by Alexandre Julliard (＠julliard) 07 Dec '23

07 Dec '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4639

1 0

Re: [PATCH v6 0/5] MR4593: winewayland.drv: part 11: Mouselook support - approved
by Alexandre Julliard (＠julliard) 07 Dec '23

07 Dec '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4593

1 0

Re: [PATCH v2 0/1] MR4631: msxml3: Handle default namespace in get_namespaceURI. - approved
by Alexandre Julliard (＠julliard) 07 Dec '23

07 Dec '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4631

1 0

Re: [PATCH v5 0/2] MR4629: user32: Correct capitalization of SetDeskWallpaper. - approved
by Alexandre Julliard (＠julliard) 07 Dec '23

07 Dec '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4629

1 0

Re: [PATCH v4 0/1] MR4300: net: Accept yes/no switches - approved
by Alexandre Julliard (＠julliard) 07 Dec '23

07 Dec '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4300

1 0

Re: [PATCH v3 0/1] MR4562: dwmapi: Implement DwmGetWindowAttribute(DWMWA_EXTENDED_FRAME_BOUNDS). - approved
by Alexandre Julliard (＠julliard) 07 Dec '23

07 Dec '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4562

1 0

Re: [PATCH v3 0/1] MR4030: configure: Use -mpreferred-stack-boundary=2 on i386. - approved
by Alexandre Julliard (＠julliard) 07 Dec '23

07 Dec '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4030

1 0

Re: [PATCH v4 0/5] MR4619: mshtml: EventObj improvements. - approved
by Alexandre Julliard (＠julliard) 07 Dec '23

07 Dec '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4619

1 0

Re: [PATCH v2 0/1] MR4627: ntdll: Remove unused valgrind_make_readable function. - approved
by Alexandre Julliard (＠julliard) 07 Dec '23

07 Dec '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4627

1 0

Re: [PATCH v2 0/1] MR515: vkd3d-shader/ir: Pass a local copy of location to control_point_normaliser_emit_hs_input(). - approved
by Alexandre Julliard (＠julliard) 07 Dec '23

07 Dec '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/515

1 0

Re: [PATCH v2 0/4] MR507: Various tests for creating identical objects - approved
by Alexandre Julliard (＠julliard) 07 Dec '23

07 Dec '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/507

1 0

Re: [PATCH v2 0/8] MR506: configure: Enable -Wshadow. - approved
by Alexandre Julliard (＠julliard) 07 Dec '23

07 Dec '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/506

1 0

Re: [PATCH v2 0/1] MR501: vkd3d-shader/dxil: Set the result register data type for nop casts. - approved
by Alexandre Julliard (＠julliard) 07 Dec '23

07 Dec '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/501

1 0

Re: [PATCH v8 0/2] MR497: vkd3d-shader/dxil: Implement DX intrinsic Unary. - approved
by Alexandre Julliard (＠julliard) 07 Dec '23

07 Dec '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/497

1 0

Re: [PATCH v7 0/6] MR477: vkd3d-shader: Finish global variable and GEP support. - approved
by Alexandre Julliard (＠julliard) 07 Dec '23

07 Dec '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/477

1 0

[PATCH 0/8] MR4647: (WIP) Win32u SNI systray internal
by Cherser-s (＠Cherser-s) 07 Dec '23

07 Dec '23

Doesn't add new driver interface enums for tray management. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4647

2 9

[PATCH 0/4] MR4645: quartz: Partially implement the VMR7 presenter.
by Zebediah Figura (＠zfigura) 07 Dec '23

07 Dec '23

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/4645

3 5

[PATCH v2 0/3] MR4609: winegstreamer: Some tiny fixes
by Alfred Agrell (＠Alcaro) 07 Dec '23

07 Dec '23

Just some tiny fixes I found while creating !4449. No functional changes intended. Wine's code review process, and commit history, is a lot more comprehensive than anything else I've seen. This means I can't just write code, submit patch, and call it a day; but it also means the codebase is clean and easy to work with, so fixing bugs and missing pieces is relatively straightforward. While this does increase the total time needed on my side (especially splitting commits), it's easy (though somewhat boring) work, so in total, it's a win. And splitting makes it easier for the maintainers - you have more to do than me, so if it saves your time at the expense of mine, I have no right to complain. Thank you for your patience with my prior MRs. 8.2/10 would contribute again (I've seen a few other games with broken videos that I suspect have still-unfixed causes) -- v2: winegstreamer: Delete duplicate WMT_ON check. winegstreamer: Fix a memory leak in stream_props_GetMediaType. https://gitlab.winehq.org/wine/wine/-/merge_requests/4609

3 5

[PATCH 0/1] MR4600: winegstreamer: Set streamheader field for h264 caps.
by Ziqing Hui (＠zhui) 07 Dec '23

07 Dec '23

For h264 byte-stream format, we should set "streamheader". "codec_data" is for avc. We also set timestamp of the buffer to 0 because mp4mux will be error if the PTS is none. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4600

4 8

[PATCH v3 0/1] MR4643: winevulkan: Update to VK spec version 1.3.272.
by Georg Lehmann (＠DadSchoorse) 07 Dec '23

07 Dec '23

-- v3: winevulkan: Update to VK spec version 1.3.272. https://gitlab.winehq.org/wine/wine/-/merge_requests/4643

3 3

[PATCH 0/5] MR4624: wined3d: More old-GL fixes.
by Matteo Bruni (＠Mystral) 07 Dec '23

07 Dec '23

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/4624

4 12

[PATCH v2 0/1] MR4643: winevulkan: Update to VK spec version 1.3.272.
by Georg Lehmann (＠DadSchoorse) 07 Dec '23

07 Dec '23

-- v2: winevulkan: Update to VK spec version 1.3.272. https://gitlab.winehq.org/wine/wine/-/merge_requests/4643

3 3

[PATCH v3 0/1] MR4618: dsound: Set position past the end of the buffer is invalid.
by Yuxuan Shui (＠yshui) 07 Dec '23

07 Dec '23

-- v3: dsound: Set position past the end of the buffer is invalid. https://gitlab.winehq.org/wine/wine/-/merge_requests/4618

3 2

[PATCH 0/1] MR4643: winevulkan: Update to VK spec version 1.3.272.
by Georg Lehmann (＠DadSchoorse) 07 Dec '23

07 Dec '23

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/4643

3 3

[PATCH 0/1] MR4644: winedump: Sync demangling code with msvcrt.
by Piotr Caban (＠piotr) 07 Dec '23

07 Dec '23

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/4644

2 1

[PATCH 0/1] MR515: vkd3d-shader/ir: Pass a local copy of location to control_point_normaliser_emit_hs_input().
by Conor McCarthy (＠cmccarthy) 07 Dec '23

07 Dec '23

Fixes invalid reads in valgrind. -- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/515

3 2

[PATCH 0/4] MR507: Various tests for creating identical objects
by Stefan Dösinger (＠stefan) 07 Dec '23

07 Dec '23

These tests are a side product of my shader cache work. We don't need them right now, but we want them as documentation at some point. -- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/507

3 5

[PATCH 0/8] MR506: configure: Enable -Wshadow.
by Zebediah Figura (＠zfigura) 07 Dec '23

07 Dec '23

This may be a matter of taste. I personally prefer to give variables a restricted scope, as I find this aids clarity, and -Wshadow can help prevent mistakes from this. -- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/506

4 14

[PATCH 0/1] MR501: vkd3d-shader/dxil: Set the result register data type for nop casts.
by Conor McCarthy (＠cmccarthy) 07 Dec '23

07 Dec '23

Casts from minimum precision types are emitted as nop, but the result value type must be set to the cast result type. -- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/501

4 6

[PATCH v7 0/2] MR497: vkd3d-shader/dxil: Implement DX intrinsic Unary.
by Conor McCarthy (＠cmccarthy) 07 Dec '23

07 Dec '23

-- v7: vkd3d-shader/dxil: Apply metadata attachments to instructions. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/497

4 7

[PATCH v6 0/6] MR477: vkd3d-shader: Finish global variable and GEP support.
by Conor McCarthy (＠cmccarthy) 07 Dec '23

07 Dec '23

-- v6: vkd3d-shader/dxil: Emit constant global arrays as immediate constant buffers. vkd3d-shader: Add a register index to struct vkd3d_shader_immediate_constant_buffer. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/477

3 8

[PATCH v2 0/5] MR464: vkd3d-shader/spirv: Declare I/O registers from the signature.
by Zebediah Figura (＠zfigura) 07 Dec '23

07 Dec '23

-- v2: vkd3d-shader/dxil: No longer synthesize DCL instructions. vkd3d-shader/spirv: Declare I/O registers from the signature. vkd3d-shader/dxil: Map SEMANTIC_KIND_TARGET to VKD3D_SHADER_SV_TARGET. vkd3d-shader/tpf: Do not uninvert used masks for domain shader patch constants. vkd3d-shader/spirv: Do not use the output_info array for patch constants. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/464

3 6

[PATCH v8 0/10] MR458: vkd3d-shader/hlsl: Handle register(cX) reservations.
by Francisco Casas (＠fcasas) 07 Dec '23

07 Dec '23

Currently we are not properly handling register(cX) reservations for SM1, this is one of the things required for the SNK shaders (CW Bug Bug 18092). register(cX) reservations also change the offset in the $Globals buffer in SM4, so support for this is also included. --- Patch 1/4 is required to specify: ``` [require] shader model < 4.0 ``` so that the tests that follow do not get run with the vulkan backend on SM4. I think nobody disagreed with that patch. -- v8: vkd3d-shader/hlsl: Turn register(cX) reservations into buffer offset for SM4. vkd3d-shader/hlsl: Make register(cX) reservations work for SM1. tests: Test register(cX) reservations. tests: Rename register-reservations.shader_test to register-reservations-resources.shader_test. tests/shader-runner: Run compilation tests with SM1 when SM1 models are selected. tests/shader-runner: Allow passing (sm<4) and (sm>=4) to "fail" and "todo" qualifiers. tests/shader-runner: Discern between the minimum_shader_model and the selected_shader_model. tests/shader-runner: Add missing requirement checks for backends. ci: Execute the shader runner on the correct test data on Windows. ci: Deduplicate the CI configuration for Windows. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/458

6 15

[PATCH v10 0/4] MR450: vkd3d-shader/ir: Flatten structured control flow instructions.
by Conor McCarthy (＠cmccarthy) 07 Dec '23

07 Dec '23

-- v10: vkd3d-shader/ir: Store code block names in struct vkd3d_shader_desc. vkd3d-shader/ir: Flatten structured control flow instructions. vkd3d-shader: Rename shader_instruction_array_add_icb() to shader_instruction_array_add_opaque_param(). vkd3d-shader/spirv: Emit descriptor offset loads in the function entry block. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/450

3 5

[PATCH v4 0/1] MR4615: vbscript: For for loop coerce right bound string to real.
by Robert Wilhelm (＠sloper42) 07 Dec '23

07 Dec '23

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=55052 -- v4: vbscript: For for loop bounds coerce string to real. https://gitlab.winehq.org/wine/wine/-/merge_requests/4615

3 3

[PATCH 0/1] MR4632: winecoreaudio: Use UID as device string.
by Brendan Shanks (＠bshanks) 07 Dec '23

07 Dec '23

`winecoreaudio` currently uses the `AudioDeviceID` as the device string (stored in the registry and used to correlate between Core Audio devices and generated GUIDs passed to Windows applications), but an `AudioDeviceID` may change between boots or even when a device is connected/disconnected. Use the UID instead, which is persistent across boots and connects/disconnects. These are strings like `BuiltInSpeakerDevice` or `AppleUSBAudioEngine:Apple Inc.:Studio Display:00008030-000128469718180E:6,7`. This only seems to be documented in the header files, from `AudioHardwareBase.h`: "`kAudioDevicePropertyDeviceUID`: A CFString that contains a persistent identifier for the AudioDevice. An AudioDevice's UID is persistent across boots. The content of the UID string is a black box and may contain information that is unique to a particular instance of an AudioDevice's hardware or unique to the CPU. Therefore they are not suitable for passing between CPUs or for identifying similar models of hardware." -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4632

3 2

[PATCH v2 0/3] MR4639: wineps: Pattern brush improvements
by Piotr Caban (＠piotr) 07 Dec '23

07 Dec '23

-- v2: wineps: Fix color handling in PSDRV_WriteDIBPatternDict. https://gitlab.winehq.org/wine/wine/-/merge_requests/4639

4 5

[PATCH v5 0/5] MR4593: winewayland.drv: part 11: Mouselook support
by Alexandros Frantzis (＠afrantzis) 07 Dec '23

07 Dec '23

This MR implements mouselook, which requires support for ClipCursor and relative motion events. The latter we can implement directly without using `SetCursorPos` for which no Wayland protocol exists at the moment. 1. Implement setting the foreground window, as this is required for clipping to work properly (i.e., for the ClipCursor driver callback to be called in the proper process/thread, see commit (2)). We can't unconditionally set the foreground window on keyboard focus, since compositors are eager to give the focus and some windows strongly dislike that (see https://gitlab.winehq.org/wine/wine/-/merge_requests/4102#note_51733). This MR borrows the "managed" window concept from WineX11 to detect windows that we shouldn't allow the compositor to manage, and avoids setting such windows as the foreground on keyboard focus. 2. Implement cursor clipping using the pointer-constraints protocol. 3. Switch to emitting relative motion events using the relative-pointer protocol when the cursor is not visible. --- 4. Finally, a potential fix for an issue I have been seeing where apps may transiently lose the active status (see commit message for more) as a result of the foreground state changes in this MR, which has undesirable side-effects. I have included this here for MR completeness/correctness, but it can be moved to a subsequent MR if preferred. Note: the velocity of relative motion events when scaling is involved is somewhat inconsistent among Wayland compositors. Thanks! -- v5: https://gitlab.winehq.org/wine/wine/-/merge_requests/4593

3 9

[PATCH v3 0/1] MR4615: vbscript: For for loop coerce right bound string to real.
by Robert Wilhelm (＠sloper42) 07 Dec '23

07 Dec '23

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=55052 -- v3: vbscript: For for loop bounds coerce string to real. https://gitlab.winehq.org/wine/wine/-/merge_requests/4615

3 3

[PATCH v8 0/2] MR3106: coml2: Move remaining storage functions from ole32
by Fabian Maurer (＠DarkShadow44) 07 Dec '23

07 Dec '23

-- v8: coml2: Move storage functions from ole32 coml2: Add tests for propertytovariant and varianttoproperty ordinals https://gitlab.winehq.org/wine/wine/-/merge_requests/3106

2 3

2025

2024

2023

2022

wine-gitlab