- wine-gitlab - winehq.org

[PATCH v2 0/1] MR4545: mf: tests: Add test cases for evr events.
by Yuxuan Shui (＠yshui) 29 Nov '23

29 Nov '23

-- v2: mf: tests: Add test cases for evr events. https://gitlab.winehq.org/wine/wine/-/merge_requests/4545

2 3

[PATCH 0/1] MR4545: mf: tests: Add test cases for evr events.
by Yuxuan Shui (＠yshui) 29 Nov '23

29 Nov '23

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/4545

3 3

[PATCH 0/3] MR4441: Adding tests for CreateProcess and std handles.
by eric pouech (＠epo) 29 Nov '23

29 Nov '23

Various new tests for CreateProcess showing a couple of issues in current implementation. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4441

5 12

[PATCH 0/1] MR4544: shell32: Add stub for SHSetTemporaryPropertyForItem.
by Louis Lenders (＠xe) 29 Nov '23

29 Nov '23

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=55536 -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4544

2 1

[PATCH 0/1] MR4542: winedump: Fix EMR_EXTTEXTOUTW record dumping when ETO_PDY flag is specified.
by Piotr Caban (＠piotr) 29 Nov '23

29 Nov '23

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/4542

3 2

[PATCH v2 0/1] MR4541: msvcrt: Fix string size passed to CompareString in _mbsnbcoll_l.
by Piotr Caban (＠piotr) 29 Nov '23

29 Nov '23

-- v2: msvcrt: Fix string size passed to CompareString in _mbsnbcoll_l. https://gitlab.winehq.org/wine/wine/-/merge_requests/4541

2 1

[PATCH 0/1] MR4541: msvcrt: Fix string size passed to CompareString in _mbsnbcoll_l.
by Piotr Caban (＠piotr) 29 Nov '23

29 Nov '23

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/4541

2 1

[PATCH v2 0/1] MR499: tests: Print the line number of the probe when a test fails.
by Petrichor Park (＠petrathekat) 29 Nov '23

29 Nov '23

Currently, if a probe fails, it will print the line number of the [test] block the probe is in, not the line number of the probe itself. This makes it somewhat difficult to debug. This commit makes it print the line number of the probe as well. CC @zfigura -- v2: tests: Print the line number of the probe when a test fails. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/499

4 4

[PATCH 0/8] MR4540: explorer: Support dockable systray icons through a new NtUser interface.
by Rémi Bernon (＠rbernon) 29 Nov '23

29 Nov '23

Moving most systray code out of winex11, and removing the need for a custom export in winemac. Maybe winemac could use that new interface as well but I didn't want to mess with it too much. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4540

3 9

[PATCH v3 0/4] MR4504: cmd: fix for bug 55401
by Dmitry Sokolov (＠DmitrySokolov) 29 Nov '23

29 Nov '23

Visual Studio's native tool command prompt uses rare for loop variables: %%1, %%2. This test covers this case. Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=55401 -- v3: cmd: added support of FOR loop's rare var names (%%1), fixed expansion of outer var loop name inside inner loop https://gitlab.winehq.org/wine/wine/-/merge_requests/4504

3 6

[PATCH v2 0/6] MR4522: winewayland.drv: part 10.3: Vulkan swapchain presentation
by Alexandros Frantzis (＠afrantzis) 29 Nov '23

29 Nov '23

This is the third (and last) part of the Wayland driver Vulkan subseries: 1. Implement `vkQueuePresentKHR` and support reporting `VK_ERROR_OUT_OF_DATE_KHR` and `VK_ERROR_SURFACE_LOST_KHR`. 2. Misc. enhancements/fixes to ensure the subsurface containing the vulkan rendering is displayed properly. 3. Implement a couple of remaining Vulkan functions. With this MR you can start enjoying some of your games with the Wayland driver (either directly with Vulkan or with a D3D->Vulkan translation). Please note, however, that we don't currently support what's needed for mouselook (you will currently get erratic view movement), so most first-person 3D games are not playable yet. Thanks! -- v2: winewayland.drv: Implement vkGetPhysicalDevicePresentRectanglesKHR. winewayland.drv: Implement vkGetDeviceGroupSurfacePresentModesKHR. winewayland.drv: Apply client subsurface position on creation. winewayland.drv: Ensure Vulkan parent surface is mapped with proper size. winewayland.drv: Detect and report vkQueuePresentKHR errors. https://gitlab.winehq.org/wine/wine/-/merge_requests/4522

5 15

[PATCH v2 0/1] MR4534: oleaut32: Fix VarR8Round for negative numbers.
by Robert Wilhelm (＠sloper42) 29 Nov '23

29 Nov '23

Floats with fractional part 0.5000 should be rounded to next even number. Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=55185 -- v2: oleaut32: Fix VarR8Round for negative numbers. https://gitlab.winehq.org/wine/wine/-/merge_requests/4534

2 2

Re: [PATCH v2 0/1] MR4415: msvcrt: Pass INT_MAX as the length in implementations of the _mbscoll family.
by Haoyang Chen (＠chenhaoyang) 29 Nov '23

29 Nov '23

On Tue Nov 28 11:16:55 2023 +0000, Piotr Caban wrote: > I don't understand the comment. Please create a bug so we can move the > discussion there. Hi, I submitted a Bug on https://bugs.winehq.org/show_bug.cgi?id=55959. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4415#note_54204

1 0

[PATCH 0/1] MR4538: include: Update d3d12sdklayers.idl from vkd3d.
by Biswapriyo Nath (＠Biswa96) 29 Nov '23

29 Nov '23

This corresponds to vkd3d as of a52604da8cae8ce5639eeb20ef263c12bf70e1df commit. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4538

2 1

Re: [PATCH v2 0/1] MR4415: msvcrt: Pass INT_MAX as the length in implementations of the _mbscoll family.
by Haoyang Chen (＠chenhaoyang) 29 Nov '23

29 Nov '23

On Tue Nov 28 11:16:55 2023 +0000, Piotr Caban wrote: > I don't understand the comment. Please create a bug so we can move the > discussion there. Ok, this is the bug link. https://bugs.winehq.org/show_bug.cgi?id=55959 -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4415#note_54196

1 0

[PATCH 0/1] MR4537: ntdll: Print a warning when LdrGetProcedureAddress() fails.
by Zebediah Figura (＠zfigura) 29 Nov '23

29 Nov '23

This aids debugging greatly. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4537

2 1

[PATCH v6 0/2] MR497: vkd3d-shader/dxil: Implement DX intrinsic Unary.
by Conor McCarthy (＠cmccarthy) 29 Nov '23

29 Nov '23

-- v6: vkd3d-shader/dxil: Apply metadata attachments to instructions. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/497

2 2

[PATCH 0/1] MR4468: ntdll: Use posix_spawn() to start the server.
by Brendan Shanks (＠bshanks) 29 Nov '23

29 Nov '23

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/4468

4 4

[PATCH 0/1] MR4536: ntdll: Implement pNtQueryInformationThread( ThreadIsTerminated ).
by Paul Gofman (＠gofman) 28 Nov '23

28 Nov '23

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/4536

2 1

[PATCH v11 0/3] MR4452: d2d1: Acquire lock before attempt to draw to device context
by Brendan McGrath (＠redmcg) 28 Nov '23

28 Nov '23

Fixes periodic crashes in PowerPoint 365 -- v11: d2d1: Acquire lock before attempt to draw to device context d2d1: Add test for singlethreaded draw d2d1: Add test for multithreaded draw https://gitlab.winehq.org/wine/wine/-/merge_requests/4452

3 5

[PATCH v6 0/1] MR4466: win32u/winex11: Add the GPU device physical memory registry
by arilou (＠arilou) 28 Nov '23

28 Nov '23

Starcraft Remastered is looking up for the GPU physical memory size to check for minimum requirements to enable RealTime Lighting. This patch should solve the bug: https://bugs.winehq.org/show_bug.cgi?id=46624 Signed-off-by: Jon Doron <arilou(a)gmail.com> -- v6: win32u: Add registry data for GPU memory size. https://gitlab.winehq.org/wine/wine/-/merge_requests/4466

4 3

Re: [PATCH v2 0/1] MR4528: d3dx9_36/tests: Use CRT allocation functions. - approved
by Alexandre Julliard (＠julliard) 28 Nov '23

28 Nov '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4528

1 0

Re: [PATCH v2 0/1] MR4529: comdlg32/tests: Use CRT allocation functions. - approved
by Alexandre Julliard (＠julliard) 28 Nov '23

28 Nov '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4529

1 0

[PATCH v5 0/3] MR4357: ntdll/unix: Try harder to initialize locale from Mac setting.
by Jactry Zeng (＠jactry) 28 Nov '23

28 Nov '23

This allows initializing locale from Mac locale identifiers like 'zh-Hans-US'. The current implementation recognizes it as 'zh-US' which isn't a valid locale identifier for Windows. This patch will try again with the 'lang-script' identifier after get_win_locale() fails with the 'lang-region' identifier. -- v5: ntdll: Try harder to fallback to neutral locales. ntdll: Initialize locale from Mac language identifiers with script name. ntdll: Use different variable names for Mac locales. https://gitlab.winehq.org/wine/wine/-/merge_requests/4357

3 4

Re: [PATCH v4 0/1] MR4023: server: Add cross-platform get_path_from_fd function. - approved
by Alexandre Julliard (＠julliard) 28 Nov '23

28 Nov '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4023

1 0

Re: [PATCH v11 0/1] MR4409: wineboot: Compute and write the TSC frequency to registry ~Mhz. - approved
by Alexandre Julliard (＠julliard) 28 Nov '23

28 Nov '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4409

1 0

Re: [PATCH v2 0/1] MR4514: shell32: Add stub for SHCreateItemWithParent. - approved
by Alexandre Julliard (＠julliard) 28 Nov '23

28 Nov '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4514

1 0

Re: [PATCH v4 0/1] MR4523: ntdll: RtlFindExportedRoutine returns NULL on forwarded function. - approved
by Alexandre Julliard (＠julliard) 28 Nov '23

28 Nov '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4523

1 0

Re: [PATCH v4 0/2] MR4520: Don't let GUI's app write to console. - approved
by Alexandre Julliard (＠julliard) 28 Nov '23

28 Nov '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4520

1 0

Re: [PATCH v4 0/1] MR4521: msiexec: : No longer use console/file output APIs. - approved
by Alexandre Julliard (＠julliard) 28 Nov '23

28 Nov '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4521

1 0

Re: [PATCH v5 0/10] MR3171: explorer: Implement standalone systray window mode. - approved
by Alexandre Julliard (＠julliard) 28 Nov '23

28 Nov '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3171

1 0

Re: [PATCH v2 0/1] MR500: vkd3d-shader/dxil: Declare IO registers as VEC4. - approved
by Alexandre Julliard (＠julliard) 28 Nov '23

28 Nov '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/500

1 0

Re: [PATCH v2 0/1] MR495: include: Add ID3D12InfoQueue1 definition in vkd3d_d3d12sdklayers.idl. - approved
by Alexandre Julliard (＠julliard) 28 Nov '23

28 Nov '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/495

1 0

[PATCH 0/1] MR4534: oleaut32: Fix VarR8Round for negative numbers.
by Robert Wilhelm (＠sloper42) 28 Nov '23

28 Nov '23

Floats with fractional part 0.5000 should be rounded to next even number. Wine-Bug: https://bugs.winehq.org/show_bug.cgi?55185 -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4534

3 2

[PATCH 0/1] MR4528: d3dx9_36/tests: Use CRT allocation functions.
by Alex Henrie (＠alexhenrie) 28 Nov '23

28 Nov '23

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/4528

3 2

[PATCH 0/1] MR4530: d3drm: Set image->palette only once in d3drm_image_palettise (GCC).
by Alex Henrie (＠alexhenrie) 28 Nov '23

28 Nov '23

GCC 13 thinks that there is a use-after-free here and warns about it. We actually don't need to check the return value of realloc here at all because shrinking an allocation is guaranteed to succeed. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4530

4 6

[PATCH 0/1] MR4414: server: Fully initialize pe mapping struct to avoid uninitialized memory when...
by Fabian Maurer (＠DarkShadow44) 28 Nov '23

28 Nov '23

When running wineserver under valgrind there is a bunch of uninitialised bytes warnings when sending the req_get_mapping_info reply. This warning can easily be reproduced by running `valgrind wineserver -f` and then `winecfg`. Tested using self compiled wine. Reason is the `pe_image_info_t` struct having bitfields: ``` unsigned char contains_code : 1; unsigned char wine_builtin : 1; unsigned char wine_fakedll : 1; ``` The last 5 bits are never initialized. This MR fixes this by zeroing the entire struct before it is filled. I hope "issues" like this are allowed to be fixed so valgrind has less false positives. Valgrind message for reference: ``` ==628662== 716 errors in context 3 of 3: ==628662== Syscall param writev(vector[1]) points to uninitialised byte(s) ==628662== at 0x49C3A87: writev (writev.c:26) ==628662== by 0x14C2F3: send_reply (request.c:268) ==628662== by 0x14C50F: call_req_handler (request.c:316) ==628662== by 0x14C5D2: read_request (request.c:339) ==628662== by 0x158F52: thread_poll_event (thread.c:388) ==628662== by 0x120FC9: fd_poll_event (fd.c:505) ==628662== by 0x1212A6: main_loop_epoll (fd.c:599) ==628662== by 0x121882: main_loop (fd.c:955) ==628662== by 0x12CBE0: main (main.c:238) ==628662== Address 0x53ec56e is 62 bytes inside a block of size 88 alloc'd ==628662== at 0x48416D4: malloc (vg_replace_malloc.c:431) ==628662== by 0x1348D0: mem_alloc (object.c:119) ==628662== by 0x14BEB9: set_reply_data_size (request.c:160) ==628662== by 0x1301C1: req_get_mapping_info (mapping.c:1291) ==628662== by 0x14C494: call_req_handler (request.c:305) ==628662== by 0x14C5D2: read_request (request.c:339) ==628662== by 0x158F52: thread_poll_event (thread.c:388) ==628662== by 0x120FC9: fd_poll_event (fd.c:505) ==628662== by 0x1212A6: main_loop_epoll (fd.c:599) ==628662== by 0x121882: main_loop (fd.c:955) ==628662== by 0x12CBE0: main (main.c:238) ==628662== Uninitialised value was created by a client request ==628662== at 0x134873: mark_block_uninitialized (object.c:110) ==628662== by 0x1348EA: mem_alloc (object.c:120) ==628662== by 0x134B87: alloc_object (object.c:199) ==628662== by 0x134F92: create_named_object (object.c:337) ==628662== by 0x12F12B: create_mapping (mapping.c:939) ==628662== by 0x12FFE9: req_create_mapping (mapping.c:1250) ==628662== by 0x14C494: call_req_handler (request.c:305) ==628662== by 0x14C5D2: read_request (request.c:339) ==628662== by 0x158F52: thread_poll_event (thread.c:388) ==628662== by 0x120FC9: fd_poll_event (fd.c:505) ==628662== by 0x1212A6: main_loop_epoll (fd.c:599) ==628662== by 0x121882: main_loop (fd.c:955) ``` -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4414

3 4

[PATCH v2 0/3] MR4504: cmd: fix for bug 55401
by Dmitry Sokolov (＠DmitrySokolov) 28 Nov '23

28 Nov '23

Visual Studio's native tool command prompt uses rare for loop variables: %%1, %%2. This test covers this case. Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=55401 -- v2: * cmd: added support of FOR loop's rare var names (%%1), fixed expansion of outer var loop name inside inner loop cmd: added support of for loop's rare var names (%%1), fixed expansion of outer var loop name inside inner loop cmd: added test for rare for loop vars https://gitlab.winehq.org/wine/wine/-/merge_requests/4504

3 8

[PATCH v3 0/1] MR4523: ntdll: RtlFindExportedRoutine returns NULL on forwarded function.
by eric pouech (＠epo) 28 Nov '23

28 Nov '23

Signed-off-by: Eric Pouech <epouech(a)codeweavers.com> -- v3: ntdll: RtlFindExportedRoutine returns NULL on forwarded entries. https://gitlab.winehq.org/wine/wine/-/merge_requests/4523

3 3

[PATCH v3 0/2] MR4520: Don't let GUI's app write to console.
by eric pouech (＠epo) 28 Nov '23

28 Nov '23

-- v3: uninstall: No longer use console/file output APIs. winecfg: Output with MESSAGE. https://gitlab.winehq.org/wine/wine/-/merge_requests/4520

2 3

[PATCH v2 0/2] MR4520: Don't let GUI's app write to console.
by eric pouech (＠epo) 28 Nov '23

28 Nov '23

-- v2: uninstall: No longer use console/file output APIs. winecfg: Output with MESSAGE. https://gitlab.winehq.org/wine/wine/-/merge_requests/4520

2 2

[PATCH 0/1] MR4529: comdlg32/tests: Use CRT allocation functions.
by Alex Henrie (＠alexhenrie) 28 Nov '23

28 Nov '23

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/4529

3 2

[PATCH v5 0/2] MR497: vkd3d-shader/dxil: Implement DX intrinsic Unary.
by Conor McCarthy (＠cmccarthy) 28 Nov '23

28 Nov '23

-- v5: vkd3d-shader/dxil: Apply metadata attachments to instructions. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/497

2 2

[PATCH v4 0/2] MR497: vkd3d-shader/dxil: Implement DX intrinsic Unary.
by Conor McCarthy (＠cmccarthy) 28 Nov '23

28 Nov '23

-- v4: vkd3d-shader/dxil: Apply metadata attachments to instructions. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/497

2 3

Re: [PATCH v2 0/9] MR4533: winex11: Detach / attach vulkan window surfaces as needed.
by Rémi Bernon (＠rbernon) 28 Nov '23

28 Nov '23

v2: Added the change to put detached surfaces offscreen with XComposite. Call `detach_client_window` directly in `attach_client_window` if client window needs to be swapped. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4533#note_54102

1 0

[PATCH v3 0/2] MR497: vkd3d-shader/dxil: Implement DX intrinsic Unary.
by Conor McCarthy (＠cmccarthy) 28 Nov '23

28 Nov '23

-- v3: vkd3d-shader/dxil: Apply metadata attachments to instructions. vkd3d-shader/dxil: Implement DX intrinsic Unary. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/497

2 2

Re: [PATCH v4 0/8] MR4380: mshtml: Keep inner window's link to the outer window until it's destroyed.
by Gabriel Ivăncescu (＠insn) 28 Nov '23

28 Nov '23

On Mon Nov 27 20:57:03 2023 +0000, Jacek Caban wrote: > My guess is that you wouldn't be able to reproduce that with JS. If > that's the case, then web pages can't depend on that (otherwise we'd > have a way to crash web browser from JS). Do you mean crash on native? I mean it's known to be full of bugs and security exploits, to the point of becoming a meme. I could test it if I can use it from JS (actually, can't event handlers still be called after navigation on the old doc/window?), because it would be a silent "failure" or event not firing which would be insanely hard to debug otherwise, especially since you can see event handlers are registered and all. And "if it works on Windows it must be correct" that devs usually think of. I wouldn't mind trying to test this out, even if it doesn't end up as proper wine tests, I just don't want it to be a waste of time, like it feels right now, even though I was expecting matching native behavior (and fixing potential memory hazards) to be a goal. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4380#note_54096

1 0

Re: [PATCH v4 0/8] MR4380: mshtml: Keep inner window's link to the outer window until it's destroyed.
by Gabriel Ivăncescu (＠insn) 28 Nov '23

28 Nov '23

On Tue Nov 28 14:17:15 2023 +0000, Jacek Caban wrote: > > As for the "hide problems in the future", I actually think the exact > opposite. Right now, we use the document's outer_window in same way, > except it's completely broken and can access invalid memory if the outer > window happens to die, which would be very hard to debug (especially > considering most apps using mshtml are bloated and slow with millions of frameworks). > Yes, it would be nice to fix that. One fix for that is to simply reset > the pointer to NULL. My understanding is that the actual reason we can't > do that is iframe navigation test and we already know that the test > works because on native, the document interface doesn't change. So what > you do is essentially working around that problem, not fixing it. Resetting the point to NULL is the same as using the `doc->window->base.outer_window`, which has potential for a lot more regressions (I don't mean the test). How is that better?!? I don't know why you think this is so risky; as mentioned in the MR's message, those are the only things that would be affected, and they're all either fixed or handled (handled means same behavior as before). I spent time carefully reviewing them, I'd like that not to be a waste and just dismissed like that. Sure I might have missed some, but it's pretty unlikely. I also tested real world apps and it seemed fine. I was hoping a review to "double check" it would provide the extra eyes on it, instead of being dismissed, even though it's correct. Also another argument for it is that, since I suspect it will have to be fixed properly at some point, the sooner we do it, the easier it will be to review, which is now. The more complicated mshtml becomes (necessarily, to implement new features), the harder it will be to revamp this. Why not do it now? It just seems to me that you dismiss it because of potential regressions without actually analyzing what could cause them at all, since my goal with this patch and the MR message was definitely to keep same behavior as before *except* in places where I fixed it (and mentioned in the message). *If* that's not the case everywhere I'd like to know, too, but I did carefully review it. Would you please reconsider? -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4380#note_54095

1 0

[PATCH 0/1] MR500: vkd3d-shader/dxil: Declare IO registers as VEC4.
by Giovanni Mascellani (＠giomasce) 28 Nov '23

28 Nov '23

Otherwise, for instance, their write masks and swizzles are not written in the D3D ASM dump. -- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/500

3 2

[PATCH 0/1] MR495: include: Add ID3D12InfoQueue1 definition in vkd3d_d3d12sdklayers.idl.
by Biswapriyo Nath (＠Biswa96) 28 Nov '23

28 Nov '23

-- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/495

4 3

[PATCH v10 0/3] MR4452: d2d1: Acquire lock before attempt to draw to device context
by Brendan McGrath (＠redmcg) 28 Nov '23

28 Nov '23

Fixes periodic crashes in PowerPoint 365 -- v10: d2d1: Acquire lock before attempt to draw to device context https://gitlab.winehq.org/wine/wine/-/merge_requests/4452

3 9

[PATCH 0/8] MR4533: winex11: Detach / attach vulkan window surfaces as needed.
by Rémi Bernon (＠rbernon) 28 Nov '23

28 Nov '23

This is some preparatory work for vulkan child window and other features which currently live in Proton. I think this could be upstream already, and it will make rebasing patches on top of it simpler. To get vulkan child window upstream we'd probably still need to rework it a bit and maybe try to move the wait and blit to `vkQueuePresent` somehow. The idea here is also that although Vulkan spec does not allow multiple active swapchains for the same window, Windows tends to allow it especially with D3D, and we also need to support the case where multiple APIs are use to draw onto the same window surface (as we implement D3D on top of GL/Vk for instance). -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4533

2 8

[PATCH v2 0/2] MR497: vkd3d-shader/dxil: Implement DX intrinsic Unary.
by Conor McCarthy (＠cmccarthy) 28 Nov '23

28 Nov '23

-- v2: vkd3d-shader/dxil: Apply metadata attachments to instructions. vkd3d-shader/dxil: Implement DX intrinsic Unary. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/497

3 6

Re: [PATCH v2 0/1] MR4415: msvcrt: Pass INT_MAX as the length in implementations of the _mbscoll family.
by Piotr Caban (＠piotr) 28 Nov '23

28 Nov '23

On Tue Nov 28 11:16:55 2023 +0000, Haoyang Chen wrote: > Hi,this patch introduces new problems in locales where UNICODE is used. > Because str single byte \0 does not necessarily terminate the string, > and thus a stack overflow occurs. And I am using a chinese local set. > I still found it to be -1 in Windows. I don't understand the comment. Please create a bug so we can move the discussion there. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4415#note_54074

1 0

[PATCH v3 0/1] MR4521: msiexec: : No longer use console/file output APIs.
by eric pouech (＠epo) 28 Nov '23

28 Nov '23

Regular GUI apps don't. Signed-off-by: Eric Pouech <epouech(a)codeweavers.com> -- v3: msiexec: : No longer use console/file output APIs. https://gitlab.winehq.org/wine/wine/-/merge_requests/4521

3 2

Re: [PATCH v2 0/1] MR4415: msvcrt: Pass INT_MAX as the length in implementations of the _mbscoll family.
by Haoyang Chen (＠chenhaoyang) 28 Nov '23

28 Nov '23

Hi,this patch introduces new problems in locales where UNICODE is used. Because str single byte \0 does not necessarily terminate the string, and thus a stack overflow occurs. And I am using a chinese local set. I still found it to be -1 in Windows. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4415#note_54069

1 0

[PATCH 0/2] MR4520: Don't let GUI's app write to console.
by eric pouech (＠epo) 28 Nov '23

28 Nov '23

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/4520

3 7

[PATCH v4 0/3] MR4357: ntdll/unix: Try harder to initialize locale from Mac setting.
by Jactry Zeng (＠jactry) 28 Nov '23

28 Nov '23

This allows initializing locale from Mac locale identifiers like 'zh-Hans-US'. The current implementation recognizes it as 'zh-US' which isn't a valid locale identifier for Windows. This patch will try again with the 'lang-script' identifier after get_win_locale() fails with the 'lang-region' identifier. -- v4: ntdll/unix: Try harder to fallback to neutral locales. ntdll/unix: Support to initialize locale from Mac language identifiers with script name. ntdll/unix: Use different variable names for Mac locales. https://gitlab.winehq.org/wine/wine/-/merge_requests/4357

2 3

[PATCH v2 0/5] MR4436: wined3d: Set d3d 1-9 textures in the state as SRVs.
by Zebediah Figura (＠zfigura) 28 Nov '23

28 Nov '23

-- v2: wined3d: Set d3d 1-9 textures in the state as SRVs. d3d9: Use wined3d_texture_acquire_identity_srv(). wined3d: Introduce an API for creating an identity SRV on a texture. wined3d: Release the view's resource after destroying the view. wined3d: Explicitly bind 0 for a NULL SRV. https://gitlab.winehq.org/wine/wine/-/merge_requests/4436

4 6

[PATCH v2 0/1] MR4517: cabarc: Use CRT allocation functions.
by Alex Henrie (＠alexhenrie) 28 Nov '23

28 Nov '23

-- v2: cabarc: Use CRT allocation functions. https://gitlab.winehq.org/wine/wine/-/merge_requests/4517

3 3

[PATCH 0/1] MR3295: ntdll: Handle calling convention mismatch.
by eric pouech (＠epo) 28 Nov '23

28 Nov '23

That's obviously kinda hacky. Alternatively, we could have a proper wrapper for the entry point. Didn't consider the i386 case as the thread entry point never returns. Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=55014 Signed-off-by: Eric Pouech <epouech(a)codeweavers.com> -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3295

4 5

Re: [PATCH v2 0/1] MR4524: dmime: Add Release() on some codepath. - approved
by Alexandre Julliard (＠julliard) 27 Nov '23

27 Nov '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4524

1 0

Re: [PATCH v2 0/3] MR4498: winex11.drv, winemac.drv, wineandroid.drv: Set PFD_SUPPORT_COMPOSITION for hardware-accelerated pixel formats. - approved
by Alexandre Julliard (＠julliard) 27 Nov '23

27 Nov '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4498

1 0

Re: [PATCH v2 0/2] MR4508: user32: Add stub for GetThreadDpiHostingBehavior - approved
by Alexandre Julliard (＠julliard) 27 Nov '23

27 Nov '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4508

1 0

Re: [PATCH v4 0/3] MR4479: winegstreamer: Implement wg_muxer_finalize. - approved
by Alexandre Julliard (＠julliard) 27 Nov '23

27 Nov '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4479

1 0

Re: [PATCH v2 0/3] MR4525: winegstreamer, amstream: Fix issues when more than one stream is present. - approved
by Alexandre Julliard (＠julliard) 27 Nov '23

27 Nov '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4525

1 0

Re: [PATCH v2 0/1] MR4527: tools: Print the correct option in error messages. - approved
by Alexandre Julliard (＠julliard) 27 Nov '23

27 Nov '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4527

1 0

Re: [PATCH v2 0/1] MR4494: d3dx9/tests: Fix a crash when d3d9 object can't be created. - approved
by Alexandre Julliard (＠julliard) 27 Nov '23

27 Nov '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4494

1 0

Re: [PATCH v2 0/2] MR4526: win32u: Initialize sysparams before winstation. - approved
by Alexandre Julliard (＠julliard) 27 Nov '23

27 Nov '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4526

1 0

Re: [PATCH v2 0/1] MR4502: wbemprox: Fix a memory leak (Coverity). - approved
by Alexandre Julliard (＠julliard) 27 Nov '23

27 Nov '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4502

1 0

Re: [PATCH v3 0/1] MR4516: ntdll: Fix an out-of-bounds read (Coverity). - approved
by Alexandre Julliard (＠julliard) 27 Nov '23

27 Nov '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4516

1 0

Re: [PATCH v2 0/2] MR4515: oleaut32: VarMod() fixes - approved
by Alexandre Julliard (＠julliard) 27 Nov '23

27 Nov '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4515

1 0

Re: [PATCH v2 0/1] MR4499: wined3d: Fix a use after free (Coverity). - approved
by Alexandre Julliard (＠julliard) 27 Nov '23

27 Nov '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4499

1 0

Re: [PATCH v2 0/1] MR4501: ntdll: Fix a memory leak (Coverity). - approved
by Alexandre Julliard (＠julliard) 27 Nov '23

27 Nov '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4501

1 0

Re: [PATCH v2 0/1] MR4503: ntdll: Fix an out-of-bounds write (Coverity). - approved
by Alexandre Julliard (＠julliard) 27 Nov '23

27 Nov '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4503

1 0

Re: [PATCH v2 0/1] MR4505: oledb32: Fix a memory leak (Coverity). - approved
by Alexandre Julliard (＠julliard) 27 Nov '23

27 Nov '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4505

1 0

Re: [PATCH v2 0/1] MR4500: dplayx: Fix a memory leak (Coverity). - approved
by Alexandre Julliard (＠julliard) 27 Nov '23

27 Nov '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4500

1 0

Re: [PATCH v6 0/2] MR4475: gdiplus: Avoid computation overflow and underflow by using hypotf - approved
by Alexandre Julliard (＠julliard) 27 Nov '23

27 Nov '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4475

1 0

Re: [PATCH v4 0/2] MR4362: gitlab: Add windows tests to MR pipeline. - approved
by Alexandre Julliard (＠julliard) 27 Nov '23

27 Nov '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4362

1 0

Re: [PATCH v2 0/2] MR4493: user32/tests: Add a simpler test for SetParent's internal message. - approved
by Alexandre Julliard (＠julliard) 27 Nov '23

27 Nov '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4493

1 0

[PATCH v3 0/3] MR4492: configure: Use --no-default-config option on clang when available.
by Jacek Caban (＠jacek) 27 Nov '23

27 Nov '23

Some distros arbitrary flags into clang config files without guarding it for applicable targets, which breaks cross compilation. -- v3: winegcc: Support --no-default-config argument. configure: Use --no-default-config option on clang when available. configure: Fix action-if-no handling in WINE_TRY_PE_CFLAGS macro. https://gitlab.winehq.org/wine/wine/-/merge_requests/4492

3 4

Re: [PATCH v2 0/2] MR4496: ws2_32: Compilation fixes for NetBSD. - approved
by Alexandre Julliard (＠julliard) 27 Nov '23

27 Nov '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4496

1 0

Re: [PATCH v4 0/1] MR496: vkd3d-shader: Handle 'linear centroid' modifier. - approved
by Alexandre Julliard (＠julliard) 27 Nov '23

27 Nov '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/496

1 0

Re: [PATCH v2 0/3] MR494: Remove some unnecessary local variables. - approved
by Alexandre Julliard (＠julliard) 27 Nov '23

27 Nov '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/494

1 0

Re: [PATCH v3 0/5] MR493: vkd3d: Clang warning fixes - approved
by Alexandre Julliard (＠julliard) 27 Nov '23

27 Nov '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/493

1 0

Re: [PATCH v3 0/1] MR492: include: D3D12_RT_FORMAT_ARRAY remove typedef to make header compatible with windows - approved
by Alexandre Julliard (＠julliard) 27 Nov '23

27 Nov '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/492

1 0

Re: [PATCH v3 0/2] MR488: vkd3d: Improve the EnqueueMakeResident stub - approved
by Alexandre Julliard (＠julliard) 27 Nov '23

27 Nov '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/488

1 0

[PATCH 0/1] MR499: tests: Print the line number of the probe when a test fails.
by Petrichor Park (＠petrathekat) 27 Nov '23

27 Nov '23

Currently, if a probe fails, it will print the line number of the [test] block the probe is in, not the line number of the probe itself. This makes it somewhat difficult to debug. This commit makes it print the line number of the probe as well. CC @zfigura -- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/499

2 1

[PATCH v3 0/6] MR4507: Add coml2 and start migrating a few functions from ole32
by Fabian Maurer (＠DarkShadow44) 27 Nov '23

27 Nov '23

Split off from https://gitlab.winehq.org/wine/wine/-/merge_requests/3106 -- v3: coml2: Move WriteClassStg from ole32 coml2: Move WriteClassStm from ole32 coml2: Move ReadClassStg from ole32 coml2: Move ReadClassStm from ole32 coml2: Move GetConvertStg from ole32 https://gitlab.winehq.org/wine/wine/-/merge_requests/4507

6 15

[PATCH 0/1] MR4524: dmime: Add Release() on some codepath.
by eric pouech (＠epo) 27 Nov '23

27 Nov '23

Signed-off-by: Eric Pouech <epouech(a)codeweavers.com> -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4524

3 4

Re: [PATCH v4 0/8] MR4380: mshtml: Keep inner window's link to the outer window until it's destroyed.
by Jacek Caban (＠jacek) 27 Nov '23

27 Nov '23

On Mon Nov 27 20:35:08 2023 +0000, Gabriel Ivăncescu wrote: > Yeah. As I said below, I can easily just get rid of the tests and do the > right thing with a comment. Silently dropping events sounds like a bad > idea to me, it will make it hard to debug if something broken ever > depends on it. And it's not like it's more code, either, so better make > it correct. My guess is that you wouldn't be able to reproduce that with JS. If that's the case, then web pages can't depend on that (otherwise we'd have a way to crash web browser from JS). -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4380#note_53978

1 0

Re: [PATCH v4 0/8] MR4380: mshtml: Keep inner window's link to the outer window until it's destroyed.
by Jacek Caban (＠jacek) 27 Nov '23

27 Nov '23

> As for the "hide problems in the future", I actually think the exact opposite. Right now, we use the document's outer_window in same way, except it's completely broken and can access invalid memory if the outer window happens to die, which would be very hard to debug (especially considering most apps using mshtml are bloated and slow with millions of frameworks). Yes, it would be nice to fix that. One fix for that is to simply reset the pointer to NULL. My understanding is that the actual reason we can't do that is iframe navigation test and we already know that the test works because on native, the document interface doesn't change. So what you do is essentially working around that problem, not fixing it. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4380#note_53977

1 0

Re: [PATCH v4 0/8] MR4380: mshtml: Keep inner window's link to the outer window until it's destroyed.
by Gabriel Ivăncescu (＠insn) 27 Nov '23

27 Nov '23

On Mon Nov 27 17:34:03 2023 +0000, Jacek Caban wrote: > This should really use `!iface_cmp()` to make sure it's not one more > instance of wrappers that native uses in similar places. However, trying > to do that crashes on native, which is just one more reason to believe > that detached documents are broken there and trying too hard to mimic it > does not make sense. I think that you're misinterpreting some quirks > that are not really interested in the first place. I suggest to drop > those tests and just do the right thing: don't send any events on > detached document, maybe even fail early on an attempt to use such storage. Yeah. As I said below, I can easily just get rid of the tests and do the right thing with a comment. Silently dropping events sounds like a bad idea to me, it will make it hard to debug if something broken ever depends on it. And it's not like it's more code, either, so better make it correct. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4380#note_53976

1 0

Re: [PATCH v4 0/8] MR4380: mshtml: Keep inner window's link to the outer window until it's destroyed.
by Gabriel Ivăncescu (＠insn) 27 Nov '23

27 Nov '23

And of course the gitlab subscription reply doesn't work via email… Well that's why I wanted it before code freeze, so any possible regressions are detected now. Isn't that the point? For storage events, yeah I can easily get rid of the test and just keep the current "correct" behavior with a comment. I'd rather keep that than silently drop events (or even if it's logged, it's not that obvious), because that's 1) incorrect and 2) it's extremely hard to debug if something broken ever depends on it. Plus, it's not like sending the events is extra code than silently dropping them, most of the patch is in the tests. As for the "hide problems in the future", I actually think the exact opposite. Right now, we use the document's outer_window in same way, except it's completely broken and can access invalid memory if the outer window happens to die, which would be very hard to debug (especially considering most apps using mshtml are bloated and slow with millions of frameworks). What problem would this hide? The things that *are* different than before (e.g. parentWindow), are tested so they're fixed and correct, with the others being same as before, except not randomly crashing in some cases. Maybe it's not by itself a strong argument, but outer_window on document is now just simply broken and I'd like to fix that before the code freeze. Another reason is that such things would also be very hard to figure out if something even depends on (lack of events especially if it's corner case like this). Considering it also fixes a broken reference from outer_window that's completely arbitrary right now, I think that's reasonable enough. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4380#note_53975

1 0

[PATCH v3 0/1] MR496: vkd3d-shader: Handle 'linear centroid' modifier.
by Nikolay Sivov (＠nsivov) 27 Nov '23

27 Nov '23

-- v3: vkd3d-shader/hlsl: Handle 'linear centroid' modifier. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/496

2 1

[PATCH v3 0/3] MR4479: winegstreamer: Implement wg_muxer_finalize.
by Ziqing Hui (＠zhui) 27 Nov '23

27 Nov '23

-- v3: winegstreamer: Implement wg_muxer_finalize. winestreamer: Implement {Begin,End}Finalize for media sink. winegstreamer: Avoid media sink command leaking. https://gitlab.winehq.org/wine/wine/-/merge_requests/4479

4 5

[PATCH 0/3] MR4525: winegstreamer, amstream: Fix issues when more than one stream is present.
by Anton Baskanov (＠baskanov) 27 Nov '23

27 Nov '23

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/4525

3 4

[PATCH v2 0/1] MR496: vkd3d-shader: Handle 'linear centroid' modifier.
by Nikolay Sivov (＠nsivov) 27 Nov '23

27 Nov '23

-- v2: vkd3d-shader/hlsl: Handle 'linear centroid' modifier. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/496

3 2

[PATCH 0/1] MR4527: tools: Print the correct option in error messages.
by Matteo Bruni (＠Mystral) 27 Nov '23

27 Nov '23

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/4527

2 1

[PATCH 0/1] MR4461: include: Introduce debugstr_time and wine_dbgstr_time.
by Alex Henrie (＠alexhenrie) 27 Nov '23

27 Nov '23

This replaces Wine's 10 copies of the function. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4461

5 6

2025

2024

2023

2022

wine-gitlab