- wine-gitlab - winehq.org

Re: [PATCH v2 0/1] MR7833: mf: Update state and start clock for both paused and stopped.
by Nikolay Sivov (＠nsivov) 17 Apr '25

17 Apr '25

This is already working using OnClockRestart(). How does it break in your testing? -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7833#note_101260

1 0

[PATCH 0/4] MR7826: ntdll: Fix some more Valgrind warnings.
by Sven Baars (＠sbaars) 17 Apr '25

17 Apr '25

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/7826

3 5

[PATCH v3 0/7] MR7836: bcrypt: Partial BCryptKeyDerivation implementation (PBKDF2).
by Piotr Caban (＠piotr) 17 Apr '25

17 Apr '25

-- v3: bcrypt: Add BCryptKeyDerivation partial implementation (PBKDF2 algorithm). https://gitlab.winehq.org/wine/wine/-/merge_requests/7836

2 8

[PATCH v2 0/7] MR7836: bcrypt: Partial BCryptKeyDerivation implementation (PBKDF2).
by Piotr Caban (＠piotr) 17 Apr '25

17 Apr '25

-- v2: bcrypt: Add BCryptKeyDerivation partial implementation (PBKDF2 algorithm). bcrypt: Reorganize hash_handle_from_desc helper so it can be reused. bcrypt: Handle PBKDF2 in BCryptGenerateSymmetricKey. bcrypt: Handle PBKDF2 in BCryptGetProperty. bcrypt: Add PBKDF2 algorithm provider. bcrypt: Fix BcryptDeriveKeyPBKDF2 with NULL salt. include: Add some PBKDF2 related definitions. https://gitlab.winehq.org/wine/wine/-/merge_requests/7836

3 9

[PATCH 0/7] MR7836: bcrypt: Partial BCryptKeyDerivation implementation (PBKDF2).
by Piotr Caban (＠piotr) 17 Apr '25

17 Apr '25

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/7836

3 9

Re: [PATCH v5 0/2] MR7623: winegstreamer: Use provided PTS and duration in video_decoder.
by Brendan McGrath (＠redmcg) 17 Apr '25

17 Apr '25

On Thu Apr 17 07:54:50 2025 +0000, Rémi Bernon wrote: > Have you tried GstVideoTimeCodeMeta / do you know what it does? No, I didn't look at that. But taking a look now, it looks like it might be good for Video PTS/DTS, but wouldn't work for audio. I'm not sure for duration either. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7623#note_101244

1 0

Re: [PATCH v5 0/2] MR7623: winegstreamer: Use provided PTS and duration in video_decoder.
by Rémi Bernon (＠rbernon) 17 Apr '25

17 Apr '25

On Wed Apr 16 08:20:27 2025 +0000, Brendan McGrath wrote: > Oops (again). I just tried using the `preserve_timestamps` boolean and > it doesn't work. The `timestamp/x-wg-transform` is a flag that lets > `video_decoder.c` know that an input timestamp has been provided (and > that it should use it). It will otherwise fall back to the behavior > defined by `provide_timestamps`. > But if we want to get rid of the need for the GUID, I guess we could > move the existing logic in `video_decoder.c` (for generating our own > timestamp) in to `wg_transform.c`. Hmm, I'm not sure that moving timestamp generation to the unix side is better. Can't we simply fill the sample timestamps from the input provided timestamps instead of the GStreamer-generated timestamps we don't really care about? -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7623#note_101242

1 0

Re: [PATCH v5 0/2] MR7623: winegstreamer: Use provided PTS and duration in video_decoder.
by Rémi Bernon (＠rbernon) 17 Apr '25

17 Apr '25

On Wed Apr 16 01:09:24 2025 +0000, Brendan McGrath wrote: > On well formed media, that `dts < 0` should only ever be true once (as > after adding ts_offset, we should never get a value below 0 again). It's > mainly there in case we get media with malformed timestamps (and dts > goes backwards). IMO the offset should only be updated once, and there should be a check and warning/fixme message if that assumption is broken. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7623#note_101241

1 0

Re: [PATCH v5 0/2] MR7623: winegstreamer: Use provided PTS and duration in video_decoder.
by Rémi Bernon (＠rbernon) 17 Apr '25

17 Apr '25

Rémi Bernon (@rbernon) commented about dlls/winegstreamer/wg_transform.c: > - GST_BUFFER_PTS(buffer) = sample->pts * 100; > + { > + pts = sample->pts += transform->ts_offset; > + if (pts < 0) > + { > + transform->ts_offset -= pts; > + pts = 0; > + } > + GST_BUFFER_PTS(buffer) = pts * 100; > + > + if (transform->attrs.preserve_timestamps) > + { > + transform_timestamp = gst_caps_new_empty_simple("timestamp/x-wg-transform"); > + gst_buffer_add_reference_timestamp_meta(buffer, transform_timestamp, pts * 100, > + sample->flags & WG_SAMPLE_FLAG_HAS_DURATION ? sample->duration * 100 : GST_CLOCK_TIME_NONE); > + gst_caps_unref(transform_timestamp); Have you tried GstVideoTimeCodeMeta / do you know what it does? -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7623#note_101240

1 0

Re: [PATCH v5 0/2] MR7623: winegstreamer: Use provided PTS and duration in video_decoder.
by Brendan McGrath (＠redmcg) 17 Apr '25

17 Apr '25

On Wed Apr 16 01:06:36 2025 +0000, Brendan McGrath wrote: > Good question. Unfortunately I must admit to not being an expert on > that. Obviously it seems to decode fine without it, so it may be more > useful for muxing than decoding. Although, the only codec with B-Frames > that I've tested is H.264; maybe there's another codec that's more > dependent on it. But I'll experiment and see if I can discern any > difference between its inclusion vs. exclusion. Testing H.264 decoding, I've been unable to discern any difference. I only tested with a small sample of videos, but it seems to work both with and without and with no notable difference in performance. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7623#note_101239

1 0

[PATCH v5 0/5] MR7812: win32u: Add more CompAttr, CompClause implementation using cursor_begin, cursor_end concept.
by Byeongsik Jeon (＠bsjeon) 17 Apr '25

17 Apr '25

If CompAttr and CompClause are properly configured, Japanese input will be more comfortable. Inspired by cursor_begin and cursor_end from Wayland zwp_text_input_v3:: preedit_string, I extended the cursor_pos concept as follows: cursor_pos = MAKELONG( cursor_begin, cursor_end ); ime_to_tascii_ex() uses this to construct CompAttr, CompClause. MS Windows native CompAttr, CompClause is a bit more complicated than this, but the concept is useful enough. It requires additional implementation in the Wine ime_ui_window proc and richedit control. However, it is useful for applications that inline ime composition string. This can be tested with MS Office Word, Excel. LANG=ja_JP.UTF-8 wine EXCEL.EXE Test key sequences: - “n-i-h-o-n-g-o-n-o-m-o-j-i-d-e-s-u-.-SPACE”. - And, RIGHT, LEFT, Shift+LEFT, Shift+RIGHT, ESC, SPACE, etc. -- v5: winex11: Update only when caret pos changed in xic_preedit_caret. winex11: Extend cursor_pos using cursor_begin, cursor_end. winemac: Extend cursor_pos using cursor_begin, cursor_end. winewayland: Extend cursor_pos using cursor_begin, cursor_end. win32u: Add more CompAttr, CompClause implementation using cursor_begin, cursor_end concept. https://gitlab.winehq.org/wine/wine/-/merge_requests/7812

3 7

[PATCH v3 0/2] MR7827: imm32: Fix the WM_IME_COMPOSITION messages to be between the WM_IME_{START|END}COMPOSITION message.
by Byeongsik Jeon (＠bsjeon) 17 Apr '25

17 Apr '25

This patch fixes a Japanese input issue in MS Office Visual Basic and Mery text editor ime inline mode. The following was considered: 1. Japanese ime: the result string message is always placed between WM_IME_STARTCOMPOSITION and WM_IME_ENDCOMPOSITION. Currently in Wine, the result string message follows WM_IME_ENDCOMPOSITION. dlls/imm32/tests/imm32.c::test_nihongo_no(). 2. Chinese ime: same as Japanese ime. 3. Korean ime: mostly the same, but there are some cases where it is not (e.g. CPS_COMPLETE, 'r-k-RETURN'). However, I haven't found any problem even if it behave like Japanese ime message order. 3. zero-length preedit string: as in MR !3115 commit d1f9aae, the message followed by WM_IME_ENDCOMPOSITION. Currently in Wine, it is associated with WM_IME_STARTCOMPOSITION. 4. zero-length result string: ignore. -- v3: winewayland: Use an empty string to clear the composition string. imm32: Fix the WM_IME_COMPOSITION messages to be between the WM_IME_{START|END}COMPOSITION message. https://gitlab.winehq.org/wine/wine/-/merge_requests/7827

3 4

[PATCH v3 0/5] MR7817: winebth.sys part 10: Add support for removing and disconnecting devices.
by Vibhav Pant (＠vibhavp) 17 Apr '25

17 Apr '25

-- v3: bluetoothapis/tests: Add tests for BluetoothRemoveDevice. bluetoothapis: Implement BluetoothRemoveDevice. bluetoothapis: Add stub for BluetoothRemoveDevice. winebth.sys: Implement IOCTL_WINEBTH_RADIO_REMOVE_DEVICE. winebth.sys: Implement IOCTL_BTH_DISCONNECT_DEVICE. https://gitlab.winehq.org/wine/wine/-/merge_requests/7817

2 6

Re: [PATCH v8 0/1] MR7706: powrprof.dll: Partially implement PowerGetActiveScheme for SteamVR
by Robert Lippmann (＠rlippmann) 17 Apr '25

17 Apr '25

Fixed GUID and added a comment -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7706#note_101230

1 0

Re: [PATCH v8 0/1] MR7706: powrprof.dll: Partially implement PowerGetActiveScheme for SteamVR
by Robert Lippmann (＠rlippmann) 17 Apr '25

17 Apr '25

On Thu Apr 17 03:21:46 2025 +0000, Robert Lippmann wrote: > Ugh. I don't know how that happened. > It does make SteamVR happy, though. Ok, fixed. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7706#note_101228

1 0

Re: [PATCH v2 0/1] MR7842: ntoskrnl.exe/tests: Fix a test failure on 32-bit Windows 7. - approved
by Alexandre Julliard (＠julliard) 16 Apr '25

16 Apr '25

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7842

1 0

Re: [PATCH v2 0/1] MR7840: gdiplus: Limit path rasterization to region bounding box. - approved
by Alexandre Julliard (＠julliard) 16 Apr '25

16 Apr '25

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7840

1 0

Re: [PATCH v2 0/5] MR7839: amstream: Implement dynamic formats in directdraw media stream. - approved
by Alexandre Julliard (＠julliard) 16 Apr '25

16 Apr '25

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7839

1 0

Re: [PATCH v3 0/1] MR7762: winegstreamer: Push flush event when flushing. - approved
by Alexandre Julliard (＠julliard) 16 Apr '25

16 Apr '25

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7762

1 0

[PATCH v2 0/5] MR7817: winebth.sys part 10: Add support for removing/disconnecting devices.
by Vibhav Pant (＠vibhavp) 16 Apr '25

16 Apr '25

-- v2: bluetoothapis/tests: Add tests for BluetoothRemoveDevice. https://gitlab.winehq.org/wine/wine/-/merge_requests/7817

4 7

[PATCH v2 0/1] MR7841: ntdll/tests: Make single step test succeed for 32-bit systems.
by Bernhard Übelacker (＠bernhardu) 16 Apr '25

16 Apr '25

Followup to 2c7b47ee5d and 50481d06d2. [Test pattern page](https://test.winehq.org/data/patterns.html#ntdll:exception) [Testbot run with this patch.](https://testbot.winehq.org/JobDetails.pl?Key=157964) This makes 32-bit systems also take the upper branch of the if. CC: @gofman, I hope this matches the purpose of the test? -- v2: ntdll/tests: Make single step test succeed for 32-bit systems. https://gitlab.winehq.org/wine/wine/-/merge_requests/7841

2 2

[PATCH 0/1] MR7842: ntoskrnl.exe/tests: Fix a test failure on 32-bit Windows 7.
by Alexander Morozov (＠amorozov) 16 Apr '25

16 Apr '25

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/7842

2 1

[PATCH 0/1] MR7841: ntdll/tests: Make single step test succeed for 32-bit systems.
by Bernhard Übelacker (＠bernhardu) 16 Apr '25

16 Apr '25

Followup to 2c7b47ee5d and 50481d06d2. [Test pattern page](https://test.winehq.org/data/patterns.html#ntdll:exception) [Testbot run with this patch.](https://testbot.winehq.org/JobDetails.pl?Key=157964) This makes 32-bit systems also take the upper branch of the if. CC: @gofman, I hope this matches the purpose of the test? -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7841

2 1

[PATCH 0/1] MR7840: gdiplus: Limit path rasterization to region bounding box.
by Esme Povirk (＠madewokherd) 16 Apr '25

16 Apr '25

I wasn't able to find the bug report, but this is needed to fix a hang in an application that draws an absurdly large ellipse. I was able to replicate that situation with a test program, and I verified that this fixes it. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7840

2 3

[PATCH 0/5] MR7839: amstream: Implement dynamic formats in directdraw media stream.
by Elizabeth Figura (＠zfigura) 16 Apr '25

16 Apr '25

A resend of 7715 with some trivial formatting tweaks. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7839

2 6

Re: [PATCH v9 0/2] MR7796: winegstreamer: Allow caller to allocate samples in MF_XVP_PLAYBACK_MODE.
by Charlotte Pabst (＠CharlottePabst) 16 Apr '25

16 Apr '25

the failures/crashes are fixed by !7838 -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7796#note_101182

1 0

[PATCH 0/1] MR7838: mfplat/tests: Don't assume video processor MFT can provide samples.
by Charlotte Pabst (＠CharlottePabst) 16 Apr '25

16 Apr '25

This fixes a test failure/crash on Windows 8.1 introduced by dd1d82728811c15716eefa0917eb3ecac4b9a85a. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7838

2 1

Re: [PATCH v2 0/1] MR7762: winegstreamer: Push flush event when flushing. - approved
by Elizabeth Figura (＠zfigura) 16 Apr '25

16 Apr '25

This merge request was approved by Elizabeth Figura. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7762

1 0

Re: [PATCH v9 0/2] MR7796: winegstreamer: Allow caller to allocate samples in MF_XVP_PLAYBACK_MODE.
by Rémi Bernon (＠rbernon) 16 Apr '25

16 Apr '25

You can submit patches and executables to https://testbot.winehq.org/ to test changes on various windows versions. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7796#note_101172

1 0

Re: [PATCH v9 0/2] MR7796: winegstreamer: Allow caller to allocate samples in MF_XVP_PLAYBACK_MODE.
by Charlotte Pabst (＠CharlottePabst) 16 Apr '25

16 Apr '25

my main problem right now is testing my fix (I don't have access to a bare metal win 8.1 installation), @rbernon, could you please see if https://gitlab.winehq.org/CharlottePabst/wine/-/commit/3adc1d687a33a9a782d1… fixes the problem? -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7796#note_101170

1 0

Re: [PATCH v9 0/2] MR7796: winegstreamer: Allow caller to allocate samples in MF_XVP_PLAYBACK_MODE.
by Charlotte Pabst (＠CharlottePabst) 16 Apr '25

16 Apr '25

already looking into it, yes -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7796#note_101165

1 0

Re: [PATCH v9 0/2] MR7796: winegstreamer: Allow caller to allocate samples in MF_XVP_PLAYBACK_MODE.
by Nikolay Sivov (＠nsivov) 16 Apr '25

16 Apr '25

@CharlottePabst could you please check what we could do about this ^ -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7796#note_101164

1 0

[PATCH v2 0/1] MR7827: imm32: Fix the WM_IME_COMPOSITION messages to be between the WM_IME_{START|END}COMPOSITION message.
by Byeongsik Jeon (＠bsjeon) 16 Apr '25

16 Apr '25

This patch fixes a Japanese input issue in MS Office Visual Basic and Mery text editor ime inline mode. The following was considered: 1. Japanese ime: the result string message is always placed between WM_IME_STARTCOMPOSITION and WM_IME_ENDCOMPOSITION. Currently in Wine, the result string message follows WM_IME_ENDCOMPOSITION. dlls/imm32/tests/imm32.c::test_nihongo_no(). 2. Chinese ime: same as Japanese ime. 3. Korean ime: mostly the same, but there are some cases where it is not (e.g. CPS_COMPLETE, 'r-k-RETURN'). However, I haven't found any problem even if it behave like Japanese ime message order. 3. zero-length preedit string: as in MR !3115 commit d1f9aae, the message followed by WM_IME_ENDCOMPOSITION. Currently in Wine, it is associated with WM_IME_STARTCOMPOSITION. 4. zero-length result string: ignore. -- v2: imm32: Fix the WM_IME_COMPOSITION messages to be between the WM_IME_{START|END}COMPOSITION message. https://gitlab.winehq.org/wine/wine/-/merge_requests/7827

3 7

Re: [PATCH v3 0/149] MR7462: Release 9.0.1. - approved
by Alexandre Julliard (＠julliard) 16 Apr '25

16 Apr '25

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7462

1 0

[PATCH v4 0/5] MR7812: win32u: Add more CompAttr, CompClause implementation using cursor_begin, cursor_end concept.
by Byeongsik Jeon (＠bsjeon) 16 Apr '25

16 Apr '25

If CompAttr and CompClause are properly configured, Japanese input will be more comfortable. Inspired by cursor_begin and cursor_end from Wayland zwp_text_input_v3:: preedit_string, I extended the cursor_pos concept as follows: cursor_pos = MAKELONG( cursor_begin, cursor_end ); ime_to_tascii_ex() uses this to construct CompAttr, CompClause. MS Windows native CompAttr, CompClause is a bit more complicated than this, but the concept is useful enough. It requires additional implementation in the Wine ime_ui_window proc and richedit control. However, it is useful for applications that inline ime composition string. This can be tested with MS Office Word, Excel. LANG=ja_JP.UTF-8 wine EXCEL.EXE Test key sequences: - “n-i-h-o-n-g-o-n-o-m-o-j-i-d-e-s-u-.-SPACE”. - And, RIGHT, LEFT, Shift+LEFT, Shift+RIGHT, ESC, SPACE, etc. -- v4: winex11: Update only when caret pos changed in xic_preedit_caret. winex11: Extend cursor_pos using cursor_begin, cursor_end. winemac: Extend cursor_pos using cursor_begin, cursor_end. winewayland: Extend cursor_pos using cursor_begin, cursor_end. win32u: Add more CompAttr, CompClause implementation using cursor_begin, cursor_end concept. https://gitlab.winehq.org/wine/wine/-/merge_requests/7812

3 16

[PATCH 0/9] MR7835: win32u: Implement generic OpenGL context functions.
by Rémi Bernon (＠rbernon) 16 Apr '25

16 Apr '25

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/7835

3 11

[PATCH 0/1] MR7827: imm32: Fix the WM_IME_COMPOSITION messages to be between the WM_IME_{START|END}COMPOSITION message.
by Byeongsik Jeon (＠bsjeon) 16 Apr '25

16 Apr '25

This patch fixes a Japanese input issue in MS Office Visual Basic and Mery text editor ime inline mode. The following was considered: 1. Japanese ime: the result string message is always placed between WM_IME_STARTCOMPOSITION and WM_IME_ENDCOMPOSITION. Currently in Wine, the result string message follows WM_IME_ENDCOMPOSITION. dlls/imm32/tests/imm32.c::test_nihongo_no(). 2. Chinese ime: same as Japanese ime. 3. Korean ime: mostly the same, but there are some cases where it is not (e.g. CPS_COMPLETE, 'r-k-RETURN'). However, I haven't found any problem even if it behave like Japanese ime message order. 3. zero-length preedit string: as in MR !3115 commit d1f9aae, the message followed by WM_IME_ENDCOMPOSITION. Currently in Wine, it is associated with WM_IME_STARTCOMPOSITION. 4. zero-length result string: ignore. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7827

3 5

Re: [PATCH v5 0/2] MR7623: winegstreamer: Use provided PTS and duration in video_decoder.
by Brendan McGrath (＠redmcg) 16 Apr '25

16 Apr '25

On Wed Apr 16 01:25:38 2025 +0000, Brendan McGrath wrote: > Oops - sorry. I got the GUID mixed up with `timestamp/x-wg-transform`. > The GUID might not be necessary actually. I might be able to use the > `preserve_timestamps` boolean instead. I think the only difference would > be that if GStreamer lost the `timestamp/x-wg-transform` state, we would > fall back to using the gstreamer values. Which is possibly better. Oops (again). I just tried using the `preserve_timestamps` boolean and it doesn't work. The `timestamp/x-wg-transform` is a flag that lets `video_decoder.c` know that an input timestamp has been provided (and that it should use it). It will otherwise fall back to the behavior defined by `provide_timestamps`. But if we want to get rid of the need for the GUID, I guess we could move the existing logic in `video_decoder.c` (for generating our own timestamp) in to `wg_transform.c`. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7623#note_101018

1 0

Re: [PATCH v9 0/2] MR7796: winegstreamer: Allow caller to allocate samples in MF_XVP_PLAYBACK_MODE.
by Rémi Bernon (＠rbernon) 16 Apr '25

16 Apr '25

The test is causing failures and crashes on Win8.1/early Win10 versions, see: https://test.winehq.org/data/patterns.html#mfplat:mfplat -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7796#note_101013

1 0

[PATCH v5 0/6] MR7715: Implement dynamic formats in directdraw media stream.
by Santino Mazza (＠tati) 16 Apr '25

16 Apr '25

-- v5: amstream: Implement dynamic formats in ddraw stream. amstream/tests: Test for dynamic formats in ddraw stream. amstream: Implement custom allocator for ddraw stream. amstream/tests: Test for custom allocator in ddraw stream. amstream: Release allocator when Disconnect is called in ddraw stream. amstream: Implement IMemAllocator stub for ddraw stream. https://gitlab.winehq.org/wine/wine/-/merge_requests/7715

4 9

[PATCH 0/2] MR7825: windowscodecs/metadata: Add a stub for bKGD writer.
by Nikolay Sivov (＠nsivov) 16 Apr '25

16 Apr '25

Signed-off-by: Nikolay Sivov <nsivov(a)codeweavers.com> -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7825

3 4

Re: [PATCH v5 0/2] MR7623: winegstreamer: Use provided PTS and duration in video_decoder.
by Brendan McGrath (＠redmcg) 16 Apr '25

16 Apr '25

On Wed Apr 16 00:56:58 2025 +0000, Brendan McGrath wrote: > I'll just add, that the state I'm referring to is the sample PTS. On > Windows, the application can provide any arbitrary value and when the > decoder produces the output, it needs to preserve the provided value. Oops - sorry. I got the GUID mixed up with `timestamp/x-wg-transform`. The GUID might not be necessary actually. I might be able to use the `preserve_timestamps` boolean instead. I think the only difference would be that if GStreamer lost the `timestamp/x-wg-transform` state, we would fall back to using the gstreamer values. Which is possibly better. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7623#note_100994

1 0

Re: [PATCH v5 0/2] MR7623: winegstreamer: Use provided PTS and duration in video_decoder.
by Brendan McGrath (＠redmcg) 16 Apr '25

16 Apr '25

On Tue Apr 15 22:44:37 2025 +0000, Rémi Bernon wrote: > Updating the offset continuously feels weird, though I've only skimmed > over the code for now. On well formed media, that `dts < 0` should only ever be true once (as after adding ts_offset, we should never get a value below 0 again). It's mainly there in case we get media with malformed timestamps (and dts goes backwards). -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7623#note_100993

1 0

Re: [PATCH v5 0/2] MR7623: winegstreamer: Use provided PTS and duration in video_decoder.
by Brendan McGrath (＠redmcg) 16 Apr '25

16 Apr '25

On Tue Apr 15 22:44:37 2025 +0000, Rémi Bernon wrote: > How useful are DTS? Do we really need to pass them through? Good question. Unfortunately I must admit to not being an expert on that. Obviously it seems to decode fine without it, so it may be more useful for muxing than decoding. Although, the only codec with B-Frames that I've tested is H.264; maybe there's another codec that's more dependent on it. But I'll experiment and see if I can discern any difference between its inclusion vs. exclusion. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7623#note_100992

1 0

Re: [PATCH v5 0/2] MR7623: winegstreamer: Use provided PTS and duration in video_decoder.
by Brendan McGrath (＠redmcg) 16 Apr '25

16 Apr '25

On Wed Apr 16 00:55:35 2025 +0000, Brendan McGrath wrote: > Because we can receive samples in a different order to what was sent > (for example, on B-Frames), I was thinking only GStreamer can preserve > state from input to output. But please correct me if I'm wrong. I'll just add, that the state I'm referring to is the sample PTS. On Windows, the application can provide any arbitrary value and when the decoder produces the output, it needs to preserve the provided value. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7623#note_100991

1 0

Re: [PATCH v5 0/2] MR7623: winegstreamer: Use provided PTS and duration in video_decoder.
by Brendan McGrath (＠redmcg) 16 Apr '25

16 Apr '25

On Tue Apr 15 22:44:37 2025 +0000, Rémi Bernon wrote: > Do we really need this custom GUID? Can't the fixups be confined on the > unix side only? Because we can receive samples in a different order to what was sent (for example, on B-Frames), I was thinking only GStreamer can preserve state from input to output. But please correct me if I'm wrong. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7623#note_100990

1 0

Re: [PATCH v5 0/1] MR7706: powrprof.dll: Partially implement PowerGetActiveScheme for SteamVR
by Robert Lippmann (＠rlippmann) 15 Apr '25

15 Apr '25

On Tue Apr 15 22:51:55 2025 +0000, Alfred Agrell wrote: > No, it's not. The first three bytes (in text form) are the same, but the > other 13 bytes don't look like anything. Ugh. I don't know how that happened. It does make SteamVR happy, though. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7706#note_100986

1 0

Re: [PATCH v5 0/1] MR7706: powrprof.dll: Partially implement PowerGetActiveScheme for SteamVR
by Alfred Agrell (＠Alcaro) 15 Apr '25

15 Apr '25

On Tue Apr 15 22:51:55 2025 +0000, Robert Lippmann wrote: > It is defined in winnt.h as GUID_MIN_POWER_SAVINGS. > Unfortunately, if I put those DEFINE_GUID statements into winnt.h, it > breaks compilation of other modules. > ``` > // > // ========================================= > // Define GUIDs which represent well-known power schemes > // ========================================= > // > // > // Maximum Power Savings - indicates that very aggressive power savings > measures will be used to help > // stretch battery life. > // > // {a1841308-3541-4fab-bc81-f71556f20b4a} > // > DEFINE_GUID( GUID_MAX_POWER_SAVINGS, 0xA1841308, 0x3541, 0x4FAB, 0xBC, > 0x81, 0xF7, 0x15, 0x56, 0xF2, 0x0B, 0x4A ); > // > // No Power Savings - indicates that almost no power savings measures > will be used. > // > // {8c5e7fda-e8bf-4a96-9a85-a6e23a8c635c} > // > DEFINE_GUID( GUID_MIN_POWER_SAVINGS, 0x8C5E7FDA, 0xE8BF, 0x4A96, 0x9A, > 0x85, 0xA6, 0xE2, 0x3A, 0x8C, 0x63, 0x5C ); > // > // Typical Power Savings - indicates that fairly aggressive power > savings measures will be used. > // > // {381b4222-f694-41f0-9685-ff5bb260df2e} > // > DEFINE_GUID( GUID_TYPICAL_POWER_SAVINGS, 0x381B4222, 0xF694, 0x41F0, > 0x96, 0x85, 0xFF, 0x5B, 0xB2, 0x60, 0xDF, 0x2E ); > ``` No, it's not. The first three bytes (in text form) are the same, but the other 13 bytes don't look like anything. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7706#note_100985

1 0

Re: [PATCH v5 0/2] MR7623: winegstreamer: Use provided PTS and duration in video_decoder.
by Rémi Bernon (＠rbernon) 15 Apr '25

15 Apr '25

Rémi Bernon (@rbernon) commented about dlls/winegstreamer/wg_transform.c: > buffer_add_video_meta(buffer, &video_info); > } > > + /* we perform DTS first as it should never be later than PTS, so any required timestamp offset should be the maximum here */ > + if (sample->flags & WG_SAMPLE_FLAG_HAS_DTS) > + { > + dts = sample->dts += transform->ts_offset; > + if (dts < 0) > + { > + transform->ts_offset -= dts; Updating the offset continuously feels weird, though I've only skimmed over the code for now. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7623#note_100983

1 0

Re: [PATCH v5 0/2] MR7623: winegstreamer: Use provided PTS and duration in video_decoder.
by Rémi Bernon (＠rbernon) 15 Apr '25

15 Apr '25

Rémi Bernon (@rbernon) commented about dlls/winegstreamer/unixlib.h: > WG_SAMPLE_FLAG_HAS_DURATION = 4, > WG_SAMPLE_FLAG_SYNC_POINT = 8, > WG_SAMPLE_FLAG_DISCONTINUITY = 0x10, > + WG_SAMPLE_FLAG_HAS_DTS = 0x20, > + WG_SAMPLE_FLAG_WG_TIMESTAMP = 0x40, > }; > > struct wg_sample > { > /* timestamp and duration are in 100-nanosecond units. */ > - UINT64 pts; > - UINT64 duration; > + INT64 pts; > + INT64 duration; > + INT64 dts; How useful are DTS? Do we really need to pass them through? -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7623#note_100982

1 0

Re: [PATCH v5 0/2] MR7623: winegstreamer: Use provided PTS and duration in video_decoder.
by Rémi Bernon (＠rbernon) 15 Apr '25

15 Apr '25

Rémi Bernon (@rbernon) commented about dlls/winegstreamer/gst_guids.h: > DEFINE_GUID(CLSID_decodebin_parser, 0xf9d8d64e, 0xa144, 0x47dc, 0x8e, 0xe0, 0xf5, 0x34, 0x98, 0x37, 0x2c, 0x29); > DEFINE_GUID(CLSID_mpeg_layer3_decoder, 0x38be3000, 0xdbf4, 0x11d0, 0x86, 0x0e, 0x00, 0xa0, 0x24, 0xcf, 0xef, 0x6d); > DEFINE_GUID(WINESUBTYPE_Gstreamer, 0xffffffff, 0x128f, 0x4dd1, 0xad, 0x22, 0xbe, 0xcf, 0xa6, 0x6c, 0xe7, 0xaa); > +DEFINE_GUID(MFSampleExtension_WG_Timestamp, 0x42554ce2, 0xed8c, 0x43ee, 0x8a, 0x04, 0xd6, 0xa1, 0x68, 0xf1, 0x8f, 0xee); Do we really need this custom GUID? Can't the fixups be confined on the unix side only? -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7623#note_100981

1 0

Re: [PATCH v5 0/1] MR7706: powrprof.dll: Partially implement PowerGetActiveScheme for SteamVR
by Robert Lippmann (＠rlippmann) 15 Apr '25

15 Apr '25

It is defined in winnt.h as GUID_MIN_POWER_SAVINGS. Unfortunately, if I put those DEFINE_GUID statements into winnt.h, it breaks compilation of other modules. ``` // // ========================================= // Define GUIDs which represent well-known power schemes // ========================================= // // // Maximum Power Savings - indicates that very aggressive power savings measures will be used to help // stretch battery life. // // {a1841308-3541-4fab-bc81-f71556f20b4a} // DEFINE_GUID( GUID_MAX_POWER_SAVINGS, 0xA1841308, 0x3541, 0x4FAB, 0xBC, 0x81, 0xF7, 0x15, 0x56, 0xF2, 0x0B, 0x4A ); // // No Power Savings - indicates that almost no power savings measures will be used. // // {8c5e7fda-e8bf-4a96-9a85-a6e23a8c635c} // DEFINE_GUID( GUID_MIN_POWER_SAVINGS, 0x8C5E7FDA, 0xE8BF, 0x4A96, 0x9A, 0x85, 0xA6, 0xE2, 0x3A, 0x8C, 0x63, 0x5C ); // // Typical Power Savings - indicates that fairly aggressive power savings measures will be used. // // {381b4222-f694-41f0-9685-ff5bb260df2e} // DEFINE_GUID( GUID_TYPICAL_POWER_SAVINGS, 0x381B4222, 0xF694, 0x41F0, 0x96, 0x85, 0xFF, 0x5B, 0xB2, 0x60, 0xDF, 0x2E ); ``` -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7706#note_100980

1 0

Re: [PATCH v3 0/6] MR7775: shell32: Test and rework rename operation. - approved
by Alexandre Julliard (＠julliard) 15 Apr '25

15 Apr '25

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7775

1 0

Re: [PATCH v6 0/8] MR7758: win32u: Introduce a generic pbuffer implementation. - approved
by Alexandre Julliard (＠julliard) 15 Apr '25

15 Apr '25

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7758

1 0

Re: [PATCH v2 0/1] MR7830: dbghelp/tests: Remove now succeeding todo_wine. - approved
by Alexandre Julliard (＠julliard) 15 Apr '25

15 Apr '25

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7830

1 0

Re: [PATCH v2 0/1] MR7832: advapi32/tests: Avoid crash in test_LsaLookupNames2 by setting len to zero. - approved
by Alexandre Julliard (＠julliard) 15 Apr '25

15 Apr '25

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7832

1 0

Re: [PATCH v2 0/1] MR7828: setupapi/tests: Add broken to test_SetupDiOpenDeviceInterface. - approved
by Alexandre Julliard (＠julliard) 15 Apr '25

15 Apr '25

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7828

1 0

Re: [PATCH v2 0/1] MR7821: winhttp/tests: Add broken to test_redirect. - approved
by Alexandre Julliard (＠julliard) 15 Apr '25

15 Apr '25

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7821

1 0

Re: [PATCH v9 0/2] MR7796: winegstreamer: Allow caller to allocate samples in MF_XVP_PLAYBACK_MODE. - approved
by Alexandre Julliard (＠julliard) 15 Apr '25

15 Apr '25

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7796

1 0

Re: [PATCH v5 0/1] MR7810: cryptext: Implement CryptExtOpenCER. - approved
by Alexandre Julliard (＠julliard) 15 Apr '25

15 Apr '25

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7810

1 0

Re: [PATCH v5 0/1] MR7706: powrprof.dll: Partially implement PowerGetActiveScheme for SteamVR
by Alexandre Julliard (＠julliard) 15 Apr '25

15 Apr '25

Where does that GUID value come from? -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7706#note_100958

1 0

[PATCH 0/1] MR7832: advapi32/tests: Avoid crash in test_LsaLookupNames2 by setting len to zero.
by Bernhard Übelacker (＠bernhardu) 15 Apr '25

15 Apr '25

Followup of 662e8a0200. [See test pattern page.](https://test.winehq.org/data/patterns.html#advapi32:lsa) [This is a testbot run with this patch.](https://testbot.winehq.org/JobDetails.pl?Key=157925) -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7832

2 1

[PATCH 0/1] MR7830: dbghelp/tests: Remove now succeeding todo_wine.
by Rémi Bernon (＠rbernon) 15 Apr '25

15 Apr '25

Same as 993bd81d1928c24b992a240c2f87603df781182b but for a different WOW flavor that I missed, happens on Gitlab all the time. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7830

2 1

[PATCH 0/1] MR7829: d3d9/tests: Skip some d3d12 tests instead of crashing.
by Rémi Bernon (＠rbernon) 15 Apr '25

15 Apr '25

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/7829

2 1

[PATCH v2 0/149] MR7462: Release 9.0.1.
by Michael Stefaniuc (＠mstefani) 15 Apr '25

15 Apr '25

-- v2: Release 9.0.1. wbemprox: Use separate critical sections for tables and table list. kernel32/tests: Add tests for critical section debug info presence. This merge request has too many patches to be relayed via email. Please visit the URL below to see the contents of the merge request. https://gitlab.winehq.org/wine/wine/-/merge_requests/7462

10 14

[PATCH 0/1] MR7828: setupapi/tests: Add broken to test_SetupDiOpenDeviceInterface.
by Bernhard Übelacker (＠bernhardu) 15 Apr '25

15 Apr '25

Followup of d4f2921794. [This is a testbot run with this patch.](https://testbot.winehq.org/JobDetails.pl?Key=157915) -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7828

2 1

[PATCH v2 0/6] MR7711: d3dx9: Rework color key handling.
by Connor McAdams (＠cmcadams) 15 Apr '25

15 Apr '25

-- v2: d3dx9: Don't color key compressed pixel formats on 32-bit d3dx9. d3dx9: Fixup color key value in d3dx_load_pixels_from_pixels() if necessary. d3dx9: Set all color channels to zero when color keying. d3dx9/tests: Add some color key tests. d3dx9: Move code for format conversion of a single pixel into a common helper function. d3dx9: Make functions for pixel copying/conversion/filtering static. https://gitlab.winehq.org/wine/wine/-/merge_requests/7711

3 15

[PATCH v3 0/4] MR7779: mshtml: Misc prototype fixes.
by Gabriel Ivăncescu (＠insn) 15 Apr '25

15 Apr '25

-- v3: mshtml: Move Option constructor to the window rather than the prototype. mshtml: Move Image constructor to the window rather than the prototype. mshtml: Validate builtin host functions in IE9+ using prototype_id rather mshtml: Store the prototype_id of the last member that contains the needed https://gitlab.winehq.org/wine/wine/-/merge_requests/7779

3 14

[PATCH v5 0/8] MR7758: win32u: Introduce a generic pbuffer implementation.
by Rémi Bernon (＠rbernon) 15 Apr '25

15 Apr '25

-- v5: win32u: Add a nulldrv pbuffer stub implementation. winemac: Use the generic pbuffer implementation. winewayland: Use the generic pbuffer implementation. win32u: Introduce a generic pbuffer implementation from winex11. opengl32/tests: Add more WGL_ARB_render_texture tests. opengl32/tests: Add more WGL_ARB_pbuffer tests. opengl32/tests: Avoid leaking contexts. win32u: Handle some pixel format initialization. https://gitlab.winehq.org/wine/wine/-/merge_requests/7758

2 9

[PATCH v4 0/8] MR7758: win32u: Introduce a generic pbuffer implementation.
by Rémi Bernon (＠rbernon) 15 Apr '25

15 Apr '25

-- v4: win32u: Add a nulldrv pbuffer stub implementation. winemac: Use the generic pbuffer implementation. winewayland: Use the generic pbuffer implementation. win32u: Introduce a generic pbuffer implementation from winex11. opengl32/tests: Add more WGL_ARB_render_texture tests. opengl32/tests: Add more WGL_ARB_pbuffer tests. opengl32/tests: Avoid leaking contexts. win32u: Handle some pixel format initialization. https://gitlab.winehq.org/wine/wine/-/merge_requests/7758

2 9

Re: [PATCH v8 0/2] MR7796: winegstreamer: Allow caller to allocate samples in MF_XVP_PLAYBACK_MODE. - approved
by Nikolay Sivov (＠nsivov) 15 Apr '25

15 Apr '25

This merge request was approved by Nikolay Sivov. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7796

1 0

[PATCH v7 0/2] MR7796: winegstreamer: Allow caller to allocate samples in MF_XVP_PLAYBACK_MODE.
by Charlotte Pabst (＠CharlottePabst) 15 Apr '25

15 Apr '25

This fixes a misbehaving proton game that sets MF_XVP_PLAYBACK_MODE. MF_XVP_PLAYBACK_MODE isn't mentioned in microsoft docs, but it's explained and used in the MIT-licensed [Windows-classic-samples](https://github.com/microsoft/Windows-classic-sampl… Not sure if mfplat is the right place to add the tests for this since the code is in winegstreamer, but it's very similar to the existing mfplat tests and the test does not interface with winegstreamer directly. It should be noted that on windows, ProcessOutput errors out if we provide a pSample with MF_XVP_PLAYBACK_MODE unset, wine simply ignores it. -- v7: winegstreamer: Allow caller to allocate samples in MF_XVP_PLAYBACK_MODE. mfplat/tests: Add test for MF_XVP_PLAYBACK_MODE. https://gitlab.winehq.org/wine/wine/-/merge_requests/7796

2 4

[PATCH v4 0/1] MR7810: cryptext: Implement CryptExtOpenCER.
by Dmitry Timoshkov (＠dmitry) 15 Apr '25

15 Apr '25

-- v4: cryptext: Implement CryptExtOpenCER. https://gitlab.winehq.org/wine/wine/-/merge_requests/7810

3 3

[PATCH v6 0/2] MR7796: winegstreamer: Allow caller to allocate samples in MF_XVP_PLAYBACK_MODE.
by Charlotte Pabst (＠CharlottePabst) 15 Apr '25

15 Apr '25

This fixes a misbehaving proton game that sets MF_XVP_PLAYBACK_MODE. MF_XVP_PLAYBACK_MODE isn't mentioned in microsoft docs, but it's explained and used in the MIT-licensed [Windows-classic-samples](https://github.com/microsoft/Windows-classic-sampl… Not sure if mfplat is the right place to add the tests for this since the code is in winegstreamer, but it's very similar to the existing mfplat tests and the test does not interface with winegstreamer directly. It should be noted that on windows, ProcessOutput errors out if we provide a pSample with MF_XVP_PLAYBACK_MODE unset, wine simply ignores it. -- v6: winegstreamer: Allow caller to allocate samples in MF_XVP_PLAYBACK_MODE. mfplat/tests: Add test for MF_XVP_PLAYBACK_MODE. https://gitlab.winehq.org/wine/wine/-/merge_requests/7796

3 4

[PATCH v3 0/5] MR7812: win32u: Add more CompStrAttr, CompStrClause implementation using cursor_begin, cursor_end concept.
by Byeongsik Jeon (＠bsjeon) 15 Apr '25

15 Apr '25

If CompStrAttr and CompStrClause are properly configured, Japanese input will be more comfortable. Inspired by cursor_begin and cursor_end from Wayland zwp_text_input_v3 preedit_string, I extended the cursor_pos concept as follows: cursor_pos = MAKELONG( cursor_begin, cursor_end ); ime_to_tascii_ex() uses this to construct CompStrAttr, CompStrClause. MS Windows native CompStrAttr, CompStrClause is a bit more complicated than this, but the concept is useful enough. It requires additional implementation in the Wine ime_ui_window proc and richedit control. However, it is useful for applications that inline ime composition string. This can be tested with MS Office Word, Excel. LANG=ja_JP.UTF-8 wine EXCEL.EXE Test key sequences: - “n-i-h-o-n-g-o-n-o-m-o-j-i-d-e-s-u-.-SPACE”. - And, RIGHT, LEFT, Shift+LEFT, Shift+RIGHT, SPACE, UP, DOWN, ESC, etc. -- v3: winex11: Update only when caret pos changed in xic_preedit_caret. winex11: Extend cursor_pos using cursor_begin, cursor_end. winemac: Extend cursor_pos using cursor_begin, cursor_end. winewayland: Extend cursor_pos using cursor_begin, cursor_end. win32u: Add more CompAttr, CompClause implementation using cursor_begin, cursor_end concept. https://gitlab.winehq.org/wine/wine/-/merge_requests/7812

2 6

[PATCH v17 0/6] MR7650: Add support for AF_UNIX sockets (followup)
by Ralf Habacker (＠rhabacker) 15 Apr '25

15 Apr '25

Follow-up of !2786, which appears to have been abandoned. -- v17: ws2_32/tests: Add test for AF_UNIX sockets. server: Fix getsockname() and accept() on AF_UNIX sockets. server: Introduce error when attempting to create a SOCK_DGRAM AF_UNIX socket. server: Allow for deletion of socket files. https://gitlab.winehq.org/wine/wine/-/merge_requests/7650

2 6

[PATCH v16 0/7] MR7650: Add support for AF_UNIX sockets (followup)
by Ralf Habacker (＠rhabacker) 15 Apr '25

15 Apr '25

Follow-up of !2786, which appears to have been abandoned. -- v16: server: Fixup for deleting socket files https://gitlab.winehq.org/wine/wine/-/merge_requests/7650

3 10

Re: [PATCH v15 0/6] MR7650: Add support for AF_UNIX sockets (followup)
by Ralf Habacker (＠rhabacker) 15 Apr '25

15 Apr '25

Ralf Habacker (@rhabacker) commented about server/fd.c: > set_error( STATUS_OBJECT_NAME_COLLISION ); > goto error; > } > ftruncate( fd->unix_fd, 0 ); Here is a direct usage of the `unix_fd`, which may be a problem. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7650#note_100892

1 0

Re: [PATCH v15 0/6] MR7650: Add support for AF_UNIX sockets (followup)
by Ralf Habacker (＠rhabacker) 15 Apr '25

15 Apr '25

On Tue Apr 15 07:51:04 2025 +0000, Ralf Habacker wrote: > and added to the opened inode list. This is normal behavior and not fd_unix related. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7650#note_100890

1 0

Re: [PATCH v15 0/6] MR7650: Add support for AF_UNIX sockets (followup)
by Ralf Habacker (＠rhabacker) 15 Apr '25

15 Apr '25

On Tue Apr 15 07:50:43 2025 +0000, Ralf Habacker wrote: > and is set as the `fd->closed` Here is no fd_unix related issue. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7650#note_100888

1 0

Re: [PATCH v15 0/6] MR7650: Add support for AF_UNIX sockets (followup)
by Ralf Habacker (＠rhabacker) 15 Apr '25

15 Apr '25

On Tue Apr 15 07:50:06 2025 +0000, Ralf Habacker wrote: > Here the `unix_fd` is saved for closing the file, which is -1 in the > case of sockets. `unix_fd` is used in `inode_close_pending()`, `inode_destroy()`, `inode_add_closed_fd()`, `fd_destroy()` and `unmount_fd()` to close the file. In any of the mentioned location the call to close() is guarded with `if (fd->unix_fd != -1)`, so these function are already save the socket case. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7650#note_100886

1 0

Re: [PATCH v15 0/6] MR7650: Add support for AF_UNIX sockets (followup)
by Ralf Habacker (＠rhabacker) 15 Apr '25

15 Apr '25

Ralf Habacker (@rhabacker) commented about server/fd.c: > fd->inode = inode; > fd->closed = closed_fd; > fd->cacheable = !inode->device->removable; > list_add_head( &inode->open, &fd->inode_entry ); and added to the opened inode list. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7650#note_100884

1 0

Re: [PATCH v15 0/6] MR7650: Add support for AF_UNIX sockets (followup)
by Ralf Habacker (＠rhabacker) 15 Apr '25

15 Apr '25

Ralf Habacker (@rhabacker) commented about server/fd.c: > closed_fd->unix_name = fd->unix_name; > closed_fd->disp_flags = 0; > fd->inode = inode; > fd->closed = closed_fd; and is set as the `fd->closed` -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7650#note_100883

1 0

Re: [PATCH v15 0/6] MR7650: Add support for AF_UNIX sockets (followup)
by Ralf Habacker (＠rhabacker) 15 Apr '25

15 Apr '25

Ralf Habacker (@rhabacker) commented about server/fd.c: > free( path ); > } > > closed_fd->unix_fd = fd->unix_fd; Here the `unix_fd` is saved for closing the file, which is -1 in the case of sockets. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7650#note_100882

1 0

[PATCH 0/1] MR7821: winhttp/tests: Add broken to test_redirect.
by Bernhard Übelacker (＠bernhardu) 15 Apr '25

15 Apr '25

Followup of d2e03e5b43. [This is a testbot run.](https://testbot.winehq.org/JobDetails.pl?Key=157865) -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7821

3 2

[PATCH v6 0/1] MR7642: server: Use dlsym() to check for epoll_pwait2 at run-time.
by William Horvath (＠whrvt) 15 Apr '25

15 Apr '25

This fixes a real problem and improves behavior at the same time. - ~~Fixes: hanging when trying to run Wine built with epoll_pwait2 headers available but epoll_pwait2 is missing in the run-time kernel (i.e. build 5.11->run 5.10)~~ (already fixed.) - Improvement: bring the improved timeout resolution to Wine builds which didn't have epoll_pwait2 at compile time, if the run-time kernel supports it (i.e. build 5.10->run 6.14) This last point is especially important in my opinion, as it applies to official Proton builds. Proton is (currently) built in Debian 11 with kernel 5.10, but SteamOS is a moving target with a much newer kernel version being used to run these Wine builds. These builds use the lower resolution timeouts if epoll_pwait2 is only checked for at compile-time, when it can cheaply and easily be done at run-time instead. ~~Fixes: 87ca5db40e2c1b37423bdc25101a5c5e39e67e6f~~ ~~An alternative to !7640 that kills two birds with one stone.~~ -- v6: server: Use dlsym() to check for epoll_pwait2 at run-time. https://gitlab.winehq.org/wine/wine/-/merge_requests/7642

2 5

[PATCH v2 0/6] MR7775: shell32: Test and rework rename operation.
by Ziqing Hui (＠zhui) 15 Apr '25

15 Apr '25

-- v2: shell32: Rework rename_files. shell32: Don't parse wildcard for rename operation. shell32: Rework add_file_entry, add more parameters. shell32/tests: Avoid showing UI when testing. shell32/tests: Test NULL and empty file name for SHFileOperation. shell32/tests: Add more tests to test_rename. https://gitlab.winehq.org/wine/wine/-/merge_requests/7775

2 7

[PATCH v2 0/4] MR7570: mfreadwrite: Implement encoder creation. (Part 1)
by Ziqing Hui (＠zhui) 15 Apr '25

15 Apr '25

I split the implementations into 2 parts to make it looks easier to review. So plz first review this MR and make sure it's good so that we don't have to rebase. The follwing patches is in !7571. -- v2: mfreadwrite: Implement sink_writer_SetInputMediaType. mfreadwrite: Implement IMFSinkWriterEx. mfreadwrite: Add converter transform to stream. mfreadwrite: Add attributes member to writer struct. https://gitlab.winehq.org/wine/wine/-/merge_requests/7570

3 9

[PATCH v3 0/1] MR7806: winewayland: Implement relative motion accumulator
by Etaash Mathamsetty (＠etaash.mathamsetty) 14 Apr '25

14 Apr '25

Gets rid of the dead mouse issue when you move the mouse slowly -- v3: winewayland: Implement relative motion accumulator https://gitlab.winehq.org/wine/wine/-/merge_requests/7806

2 2

[PATCH v5 0/7] MR7466: mf: Fix some issues with seeking.
by Conor McCarthy (＠cmccarthy) 14 Apr '25

14 Apr '25

This fixes failure to play the prologue video in Planet of the Apes: Last Frontier, which unpauses by calling Start() with a location. The exact state leading to this issue does not occur in the Start() tests, and it's not clear how to reproduce it reliably. -- v5: mf: Reset transform nodes when seeking. mf: Initialise the grabber sample count when setting state after a seek. mf: Reset transform node outputs when seeking. mf: Flush nodes before restarting a paused source at a specific position. mf: Drop transform node input events when unpausing at a specific position. mf: Reset transforms before restarting a paused source instead of after. https://gitlab.winehq.org/wine/wine/-/merge_requests/7466

3 8

Re: [PATCH v2 0/5] MR7811: PDB rewrite #8. - approved
by Alexandre Julliard (＠julliard) 14 Apr '25

14 Apr '25

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7811

1 0

Re: [PATCH v2 0/2] MR7820: Cleanup a couple of d3dx* tests - approved
by Alexandre Julliard (＠julliard) 14 Apr '25

14 Apr '25

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7820

1 0

Re: [PATCH v2 0/1] MR7819: ws2_32/tests: Allow socket() for Bluetooth RFCOMM sockets to fail with WSAEPROTONOSUPPORT. - approved
by Alexandre Julliard (＠julliard) 14 Apr '25

14 Apr '25

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7819

1 0

Re: [PATCH v3 0/1] MR7809: server: Do not call setpriority() if it cannot be used safely. - approved
by Alexandre Julliard (＠julliard) 14 Apr '25

14 Apr '25

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7809

1 0

Re: [PATCH v2 0/3] MR7816: bcrypt/tests: Add support for exporting/importing AES wrapped blob with different key sizes. - approved
by Alexandre Julliard (＠julliard) 14 Apr '25

14 Apr '25

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7816

1 0

Re: [PATCH v2 0/1] MR7818: psapi/tests: Add broken to test_GetModuleFileNameEx. - approved
by Alexandre Julliard (＠julliard) 14 Apr '25

14 Apr '25

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7818

1 0

Re: [PATCH v2 0/1] MR7808: propsys/tests: Add broken to test_PropVariantChangeType_R8. - approved
by Alexandre Julliard (＠julliard) 14 Apr '25

14 Apr '25

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7808

1 0

Re: [PATCH v2 0/1] MR7805: ws2_32/tests: Add broken to test_WSAAddressToString. - approved
by Alexandre Julliard (＠julliard) 14 Apr '25

14 Apr '25

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7805

1 0

Re: [PATCH v2 0/1] MR7799: winemaker: Account for FreeBSD - approved
by Alexandre Julliard (＠julliard) 14 Apr '25

14 Apr '25

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7799

1 0

Re: [PATCH v2 0/1] MR7800: dwrite: Implement GetFontSet() for collections. - approved
by Alexandre Julliard (＠julliard) 14 Apr '25

14 Apr '25

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7800

1 0

2025

2024

2023

2022

wine-gitlab