- wine-gitlab - winehq.org

Re: [PATCH v2 0/1] MR4524: dmime: Add Release() on some codepath. - approved
by Alexandre Julliard (＠julliard) 27 Nov '23

27 Nov '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4524

1 0

Re: [PATCH v2 0/3] MR4498: winex11.drv, winemac.drv, wineandroid.drv: Set PFD_SUPPORT_COMPOSITION for hardware-accelerated pixel formats. - approved
by Alexandre Julliard (＠julliard) 27 Nov '23

27 Nov '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4498

1 0

Re: [PATCH v2 0/2] MR4508: user32: Add stub for GetThreadDpiHostingBehavior - approved
by Alexandre Julliard (＠julliard) 27 Nov '23

27 Nov '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4508

1 0

Re: [PATCH v4 0/3] MR4479: winegstreamer: Implement wg_muxer_finalize. - approved
by Alexandre Julliard (＠julliard) 27 Nov '23

27 Nov '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4479

1 0

Re: [PATCH v2 0/3] MR4525: winegstreamer, amstream: Fix issues when more than one stream is present. - approved
by Alexandre Julliard (＠julliard) 27 Nov '23

27 Nov '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4525

1 0

Re: [PATCH v2 0/1] MR4527: tools: Print the correct option in error messages. - approved
by Alexandre Julliard (＠julliard) 27 Nov '23

27 Nov '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4527

1 0

Re: [PATCH v2 0/1] MR4494: d3dx9/tests: Fix a crash when d3d9 object can't be created. - approved
by Alexandre Julliard (＠julliard) 27 Nov '23

27 Nov '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4494

1 0

Re: [PATCH v2 0/2] MR4526: win32u: Initialize sysparams before winstation. - approved
by Alexandre Julliard (＠julliard) 27 Nov '23

27 Nov '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4526

1 0

Re: [PATCH v2 0/1] MR4502: wbemprox: Fix a memory leak (Coverity). - approved
by Alexandre Julliard (＠julliard) 27 Nov '23

27 Nov '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4502

1 0

Re: [PATCH v3 0/1] MR4516: ntdll: Fix an out-of-bounds read (Coverity). - approved
by Alexandre Julliard (＠julliard) 27 Nov '23

27 Nov '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4516

1 0

Re: [PATCH v2 0/2] MR4515: oleaut32: VarMod() fixes - approved
by Alexandre Julliard (＠julliard) 27 Nov '23

27 Nov '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4515

1 0

Re: [PATCH v2 0/1] MR4499: wined3d: Fix a use after free (Coverity). - approved
by Alexandre Julliard (＠julliard) 27 Nov '23

27 Nov '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4499

1 0

Re: [PATCH v2 0/1] MR4501: ntdll: Fix a memory leak (Coverity). - approved
by Alexandre Julliard (＠julliard) 27 Nov '23

27 Nov '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4501

1 0

Re: [PATCH v2 0/1] MR4503: ntdll: Fix an out-of-bounds write (Coverity). - approved
by Alexandre Julliard (＠julliard) 27 Nov '23

27 Nov '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4503

1 0

Re: [PATCH v2 0/1] MR4505: oledb32: Fix a memory leak (Coverity). - approved
by Alexandre Julliard (＠julliard) 27 Nov '23

27 Nov '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4505

1 0

Re: [PATCH v2 0/1] MR4500: dplayx: Fix a memory leak (Coverity). - approved
by Alexandre Julliard (＠julliard) 27 Nov '23

27 Nov '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4500

1 0

Re: [PATCH v6 0/2] MR4475: gdiplus: Avoid computation overflow and underflow by using hypotf - approved
by Alexandre Julliard (＠julliard) 27 Nov '23

27 Nov '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4475

1 0

Re: [PATCH v4 0/2] MR4362: gitlab: Add windows tests to MR pipeline. - approved
by Alexandre Julliard (＠julliard) 27 Nov '23

27 Nov '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4362

1 0

Re: [PATCH v2 0/2] MR4493: user32/tests: Add a simpler test for SetParent's internal message. - approved
by Alexandre Julliard (＠julliard) 27 Nov '23

27 Nov '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4493

1 0

[PATCH v3 0/3] MR4492: configure: Use --no-default-config option on clang when available.
by Jacek Caban (＠jacek) 27 Nov '23

27 Nov '23

Some distros arbitrary flags into clang config files without guarding it for applicable targets, which breaks cross compilation. -- v3: winegcc: Support --no-default-config argument. configure: Use --no-default-config option on clang when available. configure: Fix action-if-no handling in WINE_TRY_PE_CFLAGS macro. https://gitlab.winehq.org/wine/wine/-/merge_requests/4492

3 4

Re: [PATCH v2 0/2] MR4496: ws2_32: Compilation fixes for NetBSD. - approved
by Alexandre Julliard (＠julliard) 27 Nov '23

27 Nov '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4496

1 0

Re: [PATCH v4 0/1] MR496: vkd3d-shader: Handle 'linear centroid' modifier. - approved
by Alexandre Julliard (＠julliard) 27 Nov '23

27 Nov '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/496

1 0

Re: [PATCH v2 0/3] MR494: Remove some unnecessary local variables. - approved
by Alexandre Julliard (＠julliard) 27 Nov '23

27 Nov '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/494

1 0

Re: [PATCH v3 0/5] MR493: vkd3d: Clang warning fixes - approved
by Alexandre Julliard (＠julliard) 27 Nov '23

27 Nov '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/493

1 0

Re: [PATCH v3 0/1] MR492: include: D3D12_RT_FORMAT_ARRAY remove typedef to make header compatible with windows - approved
by Alexandre Julliard (＠julliard) 27 Nov '23

27 Nov '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/492

1 0

Re: [PATCH v3 0/2] MR488: vkd3d: Improve the EnqueueMakeResident stub - approved
by Alexandre Julliard (＠julliard) 27 Nov '23

27 Nov '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/488

1 0

[PATCH 0/1] MR499: tests: Print the line number of the probe when a test fails.
by Petrichor Park (＠petrathekat) 27 Nov '23

27 Nov '23

Currently, if a probe fails, it will print the line number of the [test] block the probe is in, not the line number of the probe itself. This makes it somewhat difficult to debug. This commit makes it print the line number of the probe as well. CC @zfigura -- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/499

2 1

[PATCH v3 0/6] MR4507: Add coml2 and start migrating a few functions from ole32
by Fabian Maurer (＠DarkShadow44) 27 Nov '23

27 Nov '23

Split off from https://gitlab.winehq.org/wine/wine/-/merge_requests/3106 -- v3: coml2: Move WriteClassStg from ole32 coml2: Move WriteClassStm from ole32 coml2: Move ReadClassStg from ole32 coml2: Move ReadClassStm from ole32 coml2: Move GetConvertStg from ole32 https://gitlab.winehq.org/wine/wine/-/merge_requests/4507

6 15

[PATCH 0/1] MR4524: dmime: Add Release() on some codepath.
by eric pouech (＠epo) 27 Nov '23

27 Nov '23

Signed-off-by: Eric Pouech <epouech(a)codeweavers.com> -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4524

3 4

Re: [PATCH v4 0/8] MR4380: mshtml: Keep inner window's link to the outer window until it's destroyed.
by Jacek Caban (＠jacek) 27 Nov '23

27 Nov '23

On Mon Nov 27 20:35:08 2023 +0000, Gabriel Ivăncescu wrote: > Yeah. As I said below, I can easily just get rid of the tests and do the > right thing with a comment. Silently dropping events sounds like a bad > idea to me, it will make it hard to debug if something broken ever > depends on it. And it's not like it's more code, either, so better make > it correct. My guess is that you wouldn't be able to reproduce that with JS. If that's the case, then web pages can't depend on that (otherwise we'd have a way to crash web browser from JS). -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4380#note_53978

1 0

Re: [PATCH v4 0/8] MR4380: mshtml: Keep inner window's link to the outer window until it's destroyed.
by Jacek Caban (＠jacek) 27 Nov '23

27 Nov '23

> As for the "hide problems in the future", I actually think the exact opposite. Right now, we use the document's outer_window in same way, except it's completely broken and can access invalid memory if the outer window happens to die, which would be very hard to debug (especially considering most apps using mshtml are bloated and slow with millions of frameworks). Yes, it would be nice to fix that. One fix for that is to simply reset the pointer to NULL. My understanding is that the actual reason we can't do that is iframe navigation test and we already know that the test works because on native, the document interface doesn't change. So what you do is essentially working around that problem, not fixing it. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4380#note_53977

1 0

Re: [PATCH v4 0/8] MR4380: mshtml: Keep inner window's link to the outer window until it's destroyed.
by Gabriel Ivăncescu (＠insn) 27 Nov '23

27 Nov '23

On Mon Nov 27 17:34:03 2023 +0000, Jacek Caban wrote: > This should really use `!iface_cmp()` to make sure it's not one more > instance of wrappers that native uses in similar places. However, trying > to do that crashes on native, which is just one more reason to believe > that detached documents are broken there and trying too hard to mimic it > does not make sense. I think that you're misinterpreting some quirks > that are not really interested in the first place. I suggest to drop > those tests and just do the right thing: don't send any events on > detached document, maybe even fail early on an attempt to use such storage. Yeah. As I said below, I can easily just get rid of the tests and do the right thing with a comment. Silently dropping events sounds like a bad idea to me, it will make it hard to debug if something broken ever depends on it. And it's not like it's more code, either, so better make it correct. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4380#note_53976

1 0

Re: [PATCH v4 0/8] MR4380: mshtml: Keep inner window's link to the outer window until it's destroyed.
by Gabriel Ivăncescu (＠insn) 27 Nov '23

27 Nov '23

And of course the gitlab subscription reply doesn't work via email… Well that's why I wanted it before code freeze, so any possible regressions are detected now. Isn't that the point? For storage events, yeah I can easily get rid of the test and just keep the current "correct" behavior with a comment. I'd rather keep that than silently drop events (or even if it's logged, it's not that obvious), because that's 1) incorrect and 2) it's extremely hard to debug if something broken ever depends on it. Plus, it's not like sending the events is extra code than silently dropping them, most of the patch is in the tests. As for the "hide problems in the future", I actually think the exact opposite. Right now, we use the document's outer_window in same way, except it's completely broken and can access invalid memory if the outer window happens to die, which would be very hard to debug (especially considering most apps using mshtml are bloated and slow with millions of frameworks). What problem would this hide? The things that *are* different than before (e.g. parentWindow), are tested so they're fixed and correct, with the others being same as before, except not randomly crashing in some cases. Maybe it's not by itself a strong argument, but outer_window on document is now just simply broken and I'd like to fix that before the code freeze. Another reason is that such things would also be very hard to figure out if something even depends on (lack of events especially if it's corner case like this). Considering it also fixes a broken reference from outer_window that's completely arbitrary right now, I think that's reasonable enough. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4380#note_53975

1 0

[PATCH v3 0/1] MR496: vkd3d-shader: Handle 'linear centroid' modifier.
by Nikolay Sivov (＠nsivov) 27 Nov '23

27 Nov '23

-- v3: vkd3d-shader/hlsl: Handle 'linear centroid' modifier. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/496

2 1

[PATCH v3 0/3] MR4479: winegstreamer: Implement wg_muxer_finalize.
by Ziqing Hui (＠zhui) 27 Nov '23

27 Nov '23

-- v3: winegstreamer: Implement wg_muxer_finalize. winestreamer: Implement {Begin,End}Finalize for media sink. winegstreamer: Avoid media sink command leaking. https://gitlab.winehq.org/wine/wine/-/merge_requests/4479

4 5

[PATCH 0/3] MR4525: winegstreamer, amstream: Fix issues when more than one stream is present.
by Anton Baskanov (＠baskanov) 27 Nov '23

27 Nov '23

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/4525

3 4

[PATCH v2 0/1] MR496: vkd3d-shader: Handle 'linear centroid' modifier.
by Nikolay Sivov (＠nsivov) 27 Nov '23

27 Nov '23

-- v2: vkd3d-shader/hlsl: Handle 'linear centroid' modifier. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/496

3 2

[PATCH 0/1] MR4527: tools: Print the correct option in error messages.
by Matteo Bruni (＠Mystral) 27 Nov '23

27 Nov '23

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/4527

2 1

[PATCH 0/1] MR4461: include: Introduce debugstr_time and wine_dbgstr_time.
by Alex Henrie (＠alexhenrie) 27 Nov '23

27 Nov '23

This replaces Wine's 10 copies of the function. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4461

5 6

[PATCH 0/1] MR496: vkd3d-shader: Handle 'linear centroid' modifier.
by Nikolay Sivov (＠nsivov) 27 Nov '23

27 Nov '23

-- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/496

4 4

[PATCH 0/3] MR494: Remove some unnecessary local variables.
by Zebediah Figura (＠zfigura) 27 Nov '23

27 Nov '23

-- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/494

4 5

[PATCH v2 0/5] MR493: vkd3d: Clang warning fixes
by Jacek Caban (＠jacek) 27 Nov '23

27 Nov '23

This MR fixes remaining Clang warnings related to enums for vkd3d in Wine tree, both in mingw and msvc mode. -- v2: configure: Enable -Wenum-conversion warnings. gitlab: Remove no longer needed -Wno-enum-conversion from build-mac. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/493

3 7

[PATCH v2 0/1] MR492: include: D3D12_RT_FORMAT_ARRAY remove typedef to make header compatible with windows
by Alistair Leslie-Hughes (＠alesliehughes) 27 Nov '23

27 Nov '23

windows d3d12.idl doesn't have this as a typedef. -- v2: include: D3D12_RT_FORMAT_ARRAY remove typedef to make header compatible with windows https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/492

3 3

[PATCH v2 0/2] MR488: vkd3d: Improve the EnqueueMakeResident stub
by Stefan Dösinger (＠stefan) 27 Nov '23

27 Nov '23

--- I don't see a method to wait for a fence, at least not without having a command queue. A suggestion I found online goes along the lines of: if (fence->GetCompletedValue != expected) { HANDLE ev = CreateEvent(...); fence->SetEventOnCompletion(expected, ev); WaitForSingleObject(ev, INFINITE); CloseHandle(ev); } Which I could write, but would be untested dead code as long as the other method is a stub. So busy waiting and writing one fixme every time we busy wait seems like a better choice for now. -- v2: vkd3d: Forward MakeResident to EnqueueMakeResident. vkd3d: Improve the EnqueueMakeResident stub. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/488

4 5

[PATCH 0/4] MR4436: wined3d: Set d3d 1-9 textures in the state as SRVs.
by Zebediah Figura (＠zfigura) 27 Nov '23

27 Nov '23

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/4436

5 10

[PATCH 0/1] MR4494: d3dx9/tests: Fix a crash when d3d9 object can't be created.
by Nikolay Sivov (＠nsivov) 27 Nov '23

27 Nov '23

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/4494

3 2

[PATCH v9 0/3] MR4452: d2d1: Acquire lock before attempt to draw to device context
by Brendan McGrath (＠redmcg) 27 Nov '23

27 Nov '23

Fixes periodic crashes in PowerPoint 365 -- v9: d2d1: Acquire lock before attempt to draw to device context https://gitlab.winehq.org/wine/wine/-/merge_requests/4452

3 8

[PATCH 0/2] MR4526: win32u: Initialize sysparams before winstation.
by Rémi Bernon (＠rbernon) 27 Nov '23

27 Nov '23

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=55843 NtUserSetThreadDesktop, called from winstation_init may call into update_display_cache before sysparams_init, when virtual desktop mode is initialized, and so, before config_key is initialized. This end up with a failure to update the display mode cache, error messages a longer start times. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4526

3 3

[PATCH 0/1] MR4517: cabarc: Use CRT allocation functions.
by Alex Henrie (＠alexhenrie) 27 Nov '23

27 Nov '23

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/4517

3 4

[PATCH v2 0/1] MR4521: msiexec: : No longer use console/file output APIs.
by eric pouech (＠epo) 27 Nov '23

27 Nov '23

Regular GUI apps don't. Signed-off-by: Eric Pouech <epouech(a)codeweavers.com> -- v2: msiexec: : No longer use console/file output APIs. https://gitlab.winehq.org/wine/wine/-/merge_requests/4521

3 5

[PATCH 0/7] MR4522: winewayland.drv: part 10.3: Vulkan swapchain presentation
by Alexandros Frantzis (＠afrantzis) 27 Nov '23

27 Nov '23

This is the third (and last) part of the Wayland driver Vulkan subseries: 1. Implement `vkQueuePresentKHR` and support reporting `VK_ERROR_OUT_OF_DATE_KHR` and `VK_ERROR_SURFACE_LOST_KHR`. 2. Misc. enhancements/fixes to ensure the subsurface containing the vulkan rendering is displayed properly. 3. Implement a couple of remaining Vulkan functions. With this MR you can start enjoying some of your games with the Wayland driver (either directly with Vulkan or with a D3D->Vulkan translation). Please note, however, that we don't currently support what's needed for mouselook (you will currently get erratic view movement), so most first-person 3D games are not playable yet. Thanks! -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4522

6 15

Re: [PATCH v4 0/8] MR4380: mshtml: Keep inner window's link to the outer window until it's destroyed.
by Jacek Caban (＠jacek) 27 Nov '23

27 Nov '23

The more I look at it the more I'm convinced that the change to keep outer window reference is not worth it. Storage events seem just outright broken on native, so that's not a good reason. Looking at Gecko, I can see that it does what we currently do and resets outer window pointer from inner window and document when inner window changes. It means that whatever we do on Wine side, everything that depends on Gecko will still not "work". The change is also quite invasive. It changes a meaning of pointers that are used module-wide, so there is some risk associated with it and the motivation seems questionable to me. Why do you need that in the first place? This is not something you've actually seen mattering for real-world use case, right? Another thing about it is that it's likely to hide some problems in the future. Resetting outer pointer is nice to have a clear cut when inner window is no longer valid. It's not a strong argument, if we really have a reason to change it, we may, but I'd like to know the reason. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4380#note_53941

1 0

Re: [PATCH v4 0/8] MR4380: mshtml: Keep inner window's link to the outer window until it's destroyed.
by Jacek Caban (＠jacek) 27 Nov '23

27 Nov '23

Jacek Caban (@jacek) commented about dlls/mshtml/tests/events.c: > + ok(hres == S_OK, "get_documentMode failed: %08lx\n", hres); > + ok(V_VT(&var) == VT_R4, "V_VT(documentMode) = %u\n", V_VT(&var)); > + document_mode = V_R4(&var); > + } > + IHTMLDocument6_Release(doc6); > + } > + > + hres = IHTMLWindow2_QueryInterface(window, &IID_IHTMLWindow6, (void**)&window6); > + ok(hres == S_OK, "Could not get IHTMLWindow6: %08lx\n", hres); > + IHTMLWindow2_Release(window); > + window = NULL; > + > + hres = IHTMLWindow6_get_sessionStorage(window6, &tmp_session_storage); > + ok(hres == S_OK, "get_sessionStorage failed: %08lx\n", hres); > + ok(tmp_session_storage != NULL, "session_storage == NULL\n"); > + ok(tmp_session_storage != session_storage[0], "session_storage after navigation same as old session_storage\n"); This should really use `!iface_cmp()` to make sure it's not one more instance of wrappers that native uses in similar places. However, trying to do that crashes on native, which is just one more reason to believe that detached documents are broken there and trying too hard to mimic it does not make sense. I think that you're misinterpreting some quirks that are not really interested in the first place. I suggest to drop those tests and just do the right thing: don't send any events on detached document, maybe even fail early on an attempt to use such storage. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4380#note_53940

1 0

[PATCH v4 0/5] MR4488: winevulkan: Allocate create info host extensions with malloc.
by Rémi Bernon (＠rbernon) 27 Nov '23

27 Nov '23

I don't think there's any reason to use the conversion context to allocate this memory, it's briefly used to build the host extension list and released right away. -- v4: winevulkan: Fix python linter warnings. winevulkan: Drop the WINEVULKAN_QUIRK_IGNORE_EXPLICIT_LAYERS quirk. winevulkan: Use a local instance variable instead of phys_dev->instance. winevulkan: Restore utils messengers when vkCreateInstance needs more physical devices. winevulkan: Restore debug callbacks when vkCreateInstance needs more physical devices. https://gitlab.winehq.org/wine/wine/-/merge_requests/4488

3 12

Re: [PATCH v4 0/8] MR4380: mshtml: Keep inner window's link to the outer window until it's destroyed.
by Gabriel Ivăncescu (＠insn) 27 Nov '23

27 Nov '23

Anything I should do or fix here? I'd like to get a few more patches before code freeze, if possible. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4380#note_53929

1 0

[PATCH v5 0/6] MR491: vkd3d-shader/dxil: Handle control flow instructions.
by Conor McCarthy (＠cmccarthy) 27 Nov '23

27 Nov '23

Conflicts with !450 but can probably go upstream before it since backend changes here are minimal. -- v5: vkd3d-shader/dxil: Handle the DXIL SWITCH instruction. vkd3d-shader: Rename shader_instruction_array_add_icb() to shader_instruction_array_add_opaque_param(). vkd3d-shader/dxil: Handle the DXIL PHI instruction. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/491

3 9

[PATCH v3 0/7] MR4488: winevulkan: Allocate create info host extensions with malloc.
by Rémi Bernon (＠rbernon) 27 Nov '23

27 Nov '23

I don't think there's any reason to use the conversion context to allocate this memory, it's briefly used to build the host extension list and released right away. -- v3: winevulkan: Fix python linter warnings. winevulkan: Drop the WINEVULKAN_QUIRK_IGNORE_EXPLICIT_LAYERS quirk. winevulkan: Use a local instance variable instead of phys_dev->instance. winevulkan: Allocate memory for VkInstanceCreateInfo with malloc. winevulkan: Allocate memory for VkDeviceCreateInfo with malloc. winevulkan: Restore utils messengers when vkCreateInstance needs more physical devices. winevulkan: Restore debug callbacks when vkCreateInstance needs more physical devices. https://gitlab.winehq.org/wine/wine/-/merge_requests/4488

3 9

[PATCH v4 0/10] MR3171: explorer: Implement standalone systray window mode.
by Rémi Bernon (＠rbernon) 27 Nov '23

27 Nov '23

The point here is to make the default implementation similar to winex11, supporting a standalone systray window. Later, we could refactor the interface to remove the duplicated systray code from the user drivers. -- v4: explorer: Cache the balloon window position. explorer: Support standalone systray window mode. explorer: Use an explicit display constant for hidden icons. explorer: Handle balloon timer in the icons window proc. explorer: Position the balloons relative to the icon windows. explorer: Use the icon windows for their tooltips. explorer: Display the individual systray icon windows. explorer: Create individual windows for the systray icons. explorer: Split systray add/remove from show/hide_icon. explorer: Remove unnecessary displayed icon array. https://gitlab.winehq.org/wine/wine/-/merge_requests/3171

2 11

[PATCH 0/1] MR4523: ntdll: RtlFindExportedRoutine returns NULL on forwarded function.
by eric pouech (＠epo) 27 Nov '23

27 Nov '23

Signed-off-by: Eric Pouech <epouech(a)codeweavers.com> -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4523

3 3

[PATCH v2 0/2] MR4523: ntdll: RtlFindExportedRoutine returns NULL on forwarded function.
by eric pouech (＠epo) 27 Nov '23

27 Nov '23

Signed-off-by: Eric Pouech <epouech(a)codeweavers.com> -- v2: ntdll: Search for CtrlRoutine in kernelbase. ntdll: RtlFindExportedRoutine returns NULL on forwarded function. https://gitlab.winehq.org/wine/wine/-/merge_requests/4523

2 3

[PATCH 0/3] MR493: vkd3d: Clang warning fixes
by Jacek Caban (＠jacek) 27 Nov '23

27 Nov '23

This MR fixes remaining Clang warnings related to enums for vkd3d in Wine tree, both in mingw and msvc mode. -- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/493

3 4

[PATCH 0/1] MR4521: msiexec: : No longer use console/file output APIs.
by eric pouech (＠epo) 27 Nov '23

27 Nov '23

Regular GUI apps don't. Signed-off-by: Eric Pouech <epouech(a)codeweavers.com> -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4521

3 5

Re: [PATCH v5 0/6] MR4459: d3dx9: Support user data in D3DXLoadMeshHierarchyFromXInMemory().
by Matteo Bruni (＠Mystral) 27 Nov '23

27 Nov '23

On Mon Nov 27 11:00:09 2023 +0000, Matteo Bruni wrote: > Good catch, I'll send that fix in a followup (unless Paul wants to take > care of it as well). Actually Paul did this in the final (now merged) version of this MR, so we're good. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4459#note_53888

1 0

[PATCH v2 0/4] MR4378: Extend CreateProcess tests for handle inheritance.
by eric pouech (＠epo) 27 Nov '23

27 Nov '23

This serie adds a couple of test for CreateProcess around std handles inheritance, depending on several options (cui/gui, use (or no use) of STARTF_USESTDHANDLES, type of handles...). This requires revisiting the existing tests to allow for more flexibility in implementing the new tests (and potentially others if needed). -- v2: kernel32/tests: Add tests for std handles inheritance in CreateProcess. kernel32/tests: Revisit argument generation in CreateProcess tests. kernel32/tests: Detect null/invalid handles, return file type as well. kernel32/tests: Extend returned values for cui/gui tests. https://gitlab.winehq.org/wine/wine/-/merge_requests/4378

3 7

[PATCH 0/2] MR4398: Don't reset invalid std handle on msvcrt init.
by eric pouech (＠epo) 27 Nov '23

27 Nov '23

At msvcrt init, don't reset the std handle if the inherited handle is invalid. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4398

4 6

[PATCH v3 0/10] MR3171: explorer: Use individual windows for systray icons.
by Rémi Bernon (＠rbernon) 27 Nov '23

27 Nov '23

The point here is to make the default implementation close to winex11, supporting a standalone systray window, and then refactor the interface to remove the duplicated code from the user drivers. -- v3: explorer: Cache the balloon window position. explorer: Support standalone systray window mode. explorer: Use an explicit display constant for hidden icons. explorer: Handle balloon timer in the icons window proc. explorer: Position the balloons relative to the icon windows. explorer: Use the icon windows for their tooltips. explorer: Display the individual systray icon windows. explorer: Create individual windows for the systray icons. explorer: Split systray add/remove from show/hide_icon. explorer: Remove unnecessary displayed icon array. https://gitlab.winehq.org/wine/wine/-/merge_requests/3171

3 12

[PATCH 0/2] MR4504: cmd: fix for bug 55401
by Dmitry Sokolov (＠DmitrySokolov) 27 Nov '23

27 Nov '23

Visual Studio's native tool command prompt uses rare for loop variables: %%1, %%2. This test covers this case. Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=55401 -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4504

3 7

[PATCH 0/1] MR4502: wbemprox: Fix a memory leak (Coverity).
by Zhiyi Zhang (＠zhiyi) 27 Nov '23

27 Nov '23

When LsaLookupSids() fails with STATUS_NONE_MAPPED or STATUS_SOME_NOT_MAPPED, the memory returned by the domain parameter should be freed. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4502

3 2

[PATCH 0/8] MR498: Draft: vkd3d-shader/dxil: Implement the DXIL ALLOCA and STORE instructions.
by Conor McCarthy (＠cmccarthy) 27 Nov '23

27 Nov '23

Goes atop !477. The last two commits belong to this MR. -- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/498

2 8

[PATCH 0/2] MR497: vkd3d-shader/dxil: Implement DX intrinsic Unary.
by Conor McCarthy (＠cmccarthy) 27 Nov '23

27 Nov '23

-- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/497

2 2

[PATCH v2 0/1] MR4516: ntdll: Fix an out-of-bounds read (Coverity).
by Zhiyi Zhang (＠zhiyi) 27 Nov '23

27 Nov '23

class FileRenameInformationEx to FileKnownFolderInformation could cause an out-of-bounds read of info_sizes. -- v2: ntdll: Fix an out-of-bounds read (Coverity). https://gitlab.winehq.org/wine/wine/-/merge_requests/4516

2 1

[PATCH 0/1] MR4506: msi: Fix an use-after-free (Coverity).
by Zhiyi Zhang (＠zhiyi) 27 Nov '23

27 Nov '23

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/4506

3 4

Re: [PATCH v3 0/8] MR4456: winewayland.drv: part 10.2: Vulkan swapchain support (without presentation)
by Shmerl (＠shmerl) 27 Nov '23

27 Nov '23

On Mon Nov 27 00:55:26 2023 +0000, darkblaze69 wrote: > you need to modify regedit, for details see here > https://gitlab.winehq.org/wine/wine/-/merge_requests/3909#note_46166 Ah, thanks for the tip! -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4456#note_53858

1 0

Re: [PATCH v3 0/8] MR4456: winewayland.drv: part 10.2: Vulkan swapchain support (without presentation)
by darkblaze69 (＠darkblaze69) 27 Nov '23

27 Nov '23

On Mon Nov 27 00:44:27 2023 +0000, Shmerl wrote: > Sorry for slight off-topic, but is there a way to test it with current Wine? > I was trying something like this: > ``` > DISPLAY='' WAYLAND_DISPLAY='wayland-0' wine notepad.exe > ``` > But it's not working: > ``` > 009c:err:winediag:nodrv_CreateWindow Application tried to create a > window, but no driver could be loaded. > 009c:err:winediag:nodrv_CreateWindow L"The explorer process failed to start." > 009c:err:systray:initialize_systray Could not create tray window > 002c:err:winediag:nodrv_CreateWindow Application tried to create a > window, but no driver could be loaded. > 002c:err:winediag:nodrv_CreateWindow L"Make sure that your X server is > running and that $DISPLAY is set correctly." > ``` > Or it still needs more bits before it can be tested? you need to modify regedit, for details see here https://gitlab.winehq.org/wine/wine/-/merge_requests/3909#note_46166 -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4456#note_53856

1 0

[PATCH v8 0/3] MR4452: d2d1: Acquire lock before attempt to draw to device context
by Brendan McGrath (＠redmcg) 26 Nov '23

26 Nov '23

Fixes periodic crashes in PowerPoint 365 -- v8: d2d1: Acquire lock before attempt to draw to device context https://gitlab.winehq.org/wine/wine/-/merge_requests/4452

2 3

[PATCH v7 0/3] MR4452: d2d1: Acquire lock before attempt to draw to device context
by Brendan McGrath (＠redmcg) 26 Nov '23

26 Nov '23

Fixes periodic crashes in PowerPoint 365 -- v7: d2d1: Acquire lock before attempt to draw to device context d2d1: Add test for singlethreaded draw d2d1: Add test for multithreaded draw https://gitlab.winehq.org/wine/wine/-/merge_requests/4452

2 4

[PATCH 0/2] MR4515: oleaut32: VarMod() fixes
by Nikolay Sivov (＠nsivov) 26 Nov '23

26 Nov '23

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/4515

3 3

Re: [PATCH v3 0/8] MR4456: winewayland.drv: part 10.2: Vulkan swapchain support (without presentation)
by Shmerl (＠shmerl) 26 Nov '23

26 Nov '23

Sorry for slight off-topic, but is there a way to test it with current Wine? I was trying something like this: ``` DISPLAY='' WAYLAND_DISPLAY='wayland-0' wine notepad.exe ``` But it's not working: ``` 009c:err:winediag:nodrv_CreateWindow Application tried to create a window, but no driver could be loaded. 009c:err:winediag:nodrv_CreateWindow L"The explorer process failed to start." 009c:err:systray:initialize_systray Could not create tray window 002c:err:winediag:nodrv_CreateWindow Application tried to create a window, but no driver could be loaded. 002c:err:winediag:nodrv_CreateWindow L"Make sure that your X server is running and that $DISPLAY is set correctly." ``` Or it still needs more bits before it can be tested? -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4456#note_53850

1 0

[PATCH 0/1] MR4514: shell32: Add stub for SHCreateItemWithParent.
by Louis Lenders (＠xe) 26 Nov '23

26 Nov '23

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=55851 -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4514

2 1

[PATCH v4 0/4] MR487: vkd3d-shader/hlsl: Fix infinite loops when applying copy-prop to swizzles, version 3.
by Francisco Casas (＠fcasas) 26 Nov '23

26 Nov '23

Supersedes !482. Instead of only storing the value that each variable's component has at the moment of the instruction currently handled by copy-prop, we store the trace of all the historic values with their timestamps, i.e. the instruction index on which the value was stored. This allow us to query the value that the variable's component had at the time of a swizzle's load instead of the swizzle instead, which also preempts copy-prop from getting stuck in an infinite loop, as which the added tests. -- v4: vkd3d-shader/hlsl: Use values at the time of the swizzle's load in copy-propagation. vkd3d-shader/hlsl: Record trace of stored values in copy-propagation. vkd3d-shader/hlsl: Move index_instructions() up. tests: Test current failure when propagating swizzles. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/487

3 10

[PATCH 0/1] MR4499: wined3d: Fix a use after free (Coverity).
by Zhiyi Zhang (＠zhiyi) 26 Nov '23

26 Nov '23

s is freed in set_window_state_thread(). -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4499

3 2

[PATCH v12 0/1] MR4428: cfgmgr32: Add CM_Register_Notification stub.
by Etaash Mathamsetty (＠etaash.mathamsetty) 26 Nov '23

26 Nov '23

Fixes the crash before the loading screen in Farlight 84 when not running on a steam deck. -- v12: cfgmgr32: Add CM_Register_Notification stub. https://gitlab.winehq.org/wine/wine/-/merge_requests/4428

2 1

[PATCH v2 0/6] MR4507: Add coml2 and start migrating a few functions from ole32
by Fabian Maurer (＠DarkShadow44) 26 Nov '23

26 Nov '23

Split off from https://gitlab.winehq.org/wine/wine/-/merge_requests/3106 -- v2: coml2: Move WriteClassStg from ole32 coml2: Move WriteClassStm from ole32 coml2: Move ReadClassStg from ole32 coml2: Move ReadClassStm from ole32 coml2: Move GetConvertStg from ole32 https://gitlab.winehq.org/wine/wine/-/merge_requests/4507

4 10

[PATCH 0/1] MR4511: ole32: Disable other-process support in RevokeDragDrop().
by Aida Jonikienė (＠DodoGTA) 26 Nov '23

26 Nov '23

The RoShade installer crashes because of ole32 trying to release the OLE drop target from another process (which can't be accessed despite it being a valid pointer). Windows probably supports this behavior (but implementing it here would require extra work and this is enough to make this app work). Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=54912 -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4511

2 1

[PATCH v5 0/1] MR4466: win32u/winex11: Add the GPU device physical memory registry
by arilou (＠arilou) 26 Nov '23

26 Nov '23

Starcraft Remastered is looking up for the GPU physical memory size to check for minimum requirements to enable RealTime Lighting. This patch should solve the bug: https://bugs.winehq.org/show_bug.cgi?id=46624 Signed-off-by: Jon Doron <arilou(a)gmail.com> -- v5: win32u: Add registry data for GPU memory size. https://gitlab.winehq.org/wine/wine/-/merge_requests/4466

3 5

[PATCH 0/2] MR4508: user32: Add stub for GetThreadDpiHostingBehavior
by Fabian Maurer (＠DarkShadow44) 25 Nov '23

25 Nov '23

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=55892 -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4508

2 2

[PATCH 0/6] MR4507: Add coml2 and start migrating a few functions from ole32
by Fabian Maurer (＠DarkShadow44) 25 Nov '23

25 Nov '23

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/4507

3 7

[PATCH 0/1] MR4500: dplayx: Fix a memory leak (Coverity).
by Zhiyi Zhang (＠zhiyi) 25 Nov '23

25 Nov '23

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/4500

3 2

[PATCH 0/1] MR4505: oledb32: Fix a memory leak (Coverity).
by Zhiyi Zhang (＠zhiyi) 25 Nov '23

25 Nov '23

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/4505

3 2

[PATCH v5 0/2] MR4475: gdiplus: Avoid computation overflow and underflow by using hypotf
by Bartosz Kosiorek (＠gang65) 25 Nov '23

25 Nov '23

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=45123 In `gdiplus/graphicspath.c` calculating the Pythagorean addition is needed, which is defined as: a ⊕ b = sqrt(a^2+b^2) This is hypotenuse, or the length of the longest side of a right-angled triangle, that we know the other 2 sides, a and b. https://en.wikipedia.org/wiki/Pythagorean_addition By using `sqrt(a * a + b * b)`, for large (or small) `a` or `b`, there is a possibility of overflow (underflow), although the result itself is not that big (small) to cause overflow (underflow). To overcome this problem, there are implementations of hypotenuse that do not use power of 2, and use other methods to calculate the result. To calculate `a ⊕ b`, you can easily use `hypotf(a,b)`. https://en.cppreference.com/w/cpp/numeric/math/hypot -- v5: gdiplus/font: Avoid computation overflow and underflow by using hypotf gdiplus/graphicspath: Avoid computation overflow and underflow by using hypotf. https://gitlab.winehq.org/wine/wine/-/merge_requests/4475

3 3

[PATCH 0/1] MR4503: ntdll: Fix an out-of-bounds write (Coverity).
by Zhiyi Zhang (＠zhiyi) 25 Nov '23

25 Nov '23

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/4503

2 1

[PATCH v7 0/2] MR3616: cmd: added support of for loop's var names %%1, fixed expansion of outer var loop name inside inner loop
by Dmitry Sokolov (＠DmitrySokolov) 25 Nov '23

25 Nov '23

Visual Studio's native tool command prompt uses these FOR loop variables: %%1, %%2. This fix allows to use %%1 var in FOR loops.case. Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=55401 -- v7: cmd: added support of for loop's rare var names (%%1), fixed expansion of outer var loop name inside inner loop cmd: added test for rare for loop vars https://gitlab.winehq.org/wine/wine/-/merge_requests/3616

2 3

[PATCH 0/1] MR4501: ntdll: Fix a memory leak (Coverity).
by Zhiyi Zhang (＠zhiyi) 25 Nov '23

25 Nov '23

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/4501

2 1

[PATCH v13 0/2] MR4372: kernel32: impl sync barrier
by quininer (＠quininer) 25 Nov '23

25 Nov '23

This is my first time contributing wine and there are a lot of things I'm not sure about, so any comments are welcome. :) -- v13: kernel32: add sync barrier test https://gitlab.winehq.org/wine/wine/-/merge_requests/4372

3 3

[PATCH 0/3] MR4498: winex11.drv, winemac.drv, wineandroid.drv: Set PFD_SUPPORT_COMPOSITION for hardware-accelerated pixel formats.
by Torge Matthies (＠tmatthies) 25 Nov '23

25 Nov '23

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=53500 -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4498

2 4

[PATCH v12 0/2] MR4372: kernel32: impl sync barrier
by quininer (＠quininer) 25 Nov '23

25 Nov '23

This is my first time contributing wine and there are a lot of things I'm not sure about, so any comments are welcome. :) -- v12: kernel32: add sync barrier test kernel32: impl sync barrier https://gitlab.winehq.org/wine/wine/-/merge_requests/4372

3 3

[PATCH v2 0/2] MR4488: winevulkan: Allocate create info host extensions with malloc.
by Rémi Bernon (＠rbernon) 25 Nov '23

25 Nov '23

I don't think there's any reason to use the conversion context to allocate this memory, it's briefly used to build the host extension list and released right away. -- v2: winevulkan: Allocate memory for VkInstanceCreateInfo with malloc. winevulkan: Allocate memory for VkDeviceCreateInfo with malloc. https://gitlab.winehq.org/wine/wine/-/merge_requests/4488

3 6

[PATCH 0/1] MR4497: configure: use host compiler for building wine tools when cross-compiling.
by Fan WenJie (＠fanwenjie) 25 Nov '23

25 Nov '23

Signed-off-by: Fan WenJie <fanwj(a)mail.ustc.edu.cn> -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4497

3 3

[PATCH v10 0/6] MR4092: user32: Actually implement RealGetWindowClass{A/W}.
by Connor McAdams (＠cmcadams) 25 Nov '23

25 Nov '23

-- v10: user32: Pass real argument to NtUserGetClassName in RealGetWindowClass{A/W}. win32u: Add support for retrieving real window class ID across processes. user32: Set real window class ID for user32 static controls. https://gitlab.winehq.org/wine/wine/-/merge_requests/4092

4 11

[PATCH 0/2] MR4496: ws2_32: Compilation fixes for NetBSD.
by Zebediah Figura (＠zfigura) 24 Nov '23

24 Nov '23

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/4496

2 2

2025

2024

2023

2022

wine-gitlab