- wine-gitlab - winehq.org

Re: [PATCH v13 0/23] MR1088: ntdll: Avoid calling pthread_exit on thread exit. - approved
by Alexandre Julliard (＠julliard) 22 Nov '23

22 Nov '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1088

1 0

Re: [PATCH v3 0/1] MR486: tests: Introduce an OpenGL shader runner. - approved
by Alexandre Julliard (＠julliard) 22 Nov '23

22 Nov '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/486

1 0

Re: [PATCH v7 0/4] MR478: vkd3d-shader/hlsl: Parse integers with the 'u' postfix. - approved
by Alexandre Julliard (＠julliard) 22 Nov '23

22 Nov '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/478

1 0

Re: [PATCH v17 0/6] MR471: vkd3d-shader/dxil: Implement the DXIL GEP and LOAD instructions. - approved
by Alexandre Julliard (＠julliard) 22 Nov '23

22 Nov '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/471

1 0

Re: [PATCH v2 0/1] MR4476: msvcrt: Perform a base-10 logarithm using integer math. - approved
by Piotr Caban (＠piotr) 22 Nov '23

22 Nov '23

This merge request was approved by Piotr Caban. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4476

1 0

[PATCH v7 0/5] MR4450: winegstreamer: WMA DMO support
by Alfred Agrell (＠Alcaro) 22 Nov '23

22 Nov '23

Along with !4449, this fixes WMV videos in microkiri (https://bugs.winehq.org/show_bug.cgi?id=9127#c102) and Wagamama High Spec Trial Edition (https://wagahigh.com/download_trial.php#normal ; ダウンロード means download). -- v7: mf/tests: Test IMediaObject_GetOutputSizeInfo. winegstreamer: Implement DMO interface for WMA decoder. winegstreamer: Switch WMA decoder to use wg_format internally. winegstreamer: Implement WMA <-> AMT conversion. winegstreamer: Add wg_format_from_caps_audio_wma function. https://gitlab.winehq.org/wine/wine/-/merge_requests/4450

5 8

[PATCH 0/1] MR4477: user32/tests: Accept another variation in send_message_5.
by Esme Povirk (＠madewokherd) 22 Nov '23

22 Nov '23

This sometimes shows up on win1064: http://test.winehq.org/data/dfa0c9d28da8f94116b724ef84bd655af3563845/win22H… -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4477

2 1

[PATCH v2 0/3] MR487: vkd3d-shader/hlsl: Fix infinite loops when applying copy-prop to swizzles, version 3.
by Francisco Casas (＠fcasas) 22 Nov '23

22 Nov '23

Supersedes !482. Instead of only storing the value that each variable's component has at the moment of the instruction currently handled by copy-prop, we store the trace of all the historic values with their timestamps, i.e. the instruction index on which the value was stored. This allow us to query the value that the variable's component had at the time of a swizzle's load instead of the swizzle instead, which also preempts copy-prop from getting stuck in an infinite loop, as which the added tests. -- v2: vkd3d-shader/hlsl: Use values at the time of the swizzle's load in copy-propagation. vkd3d-shader/hlsl: Record trace of stored values in copy-propagation. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/487

3 12

[PATCH v6 0/5] MR4450: winegstreamer: WMA DMO support
by Alfred Agrell (＠Alcaro) 22 Nov '23

22 Nov '23

Along with !4449, this fixes WMV videos in microkiri (https://bugs.winehq.org/show_bug.cgi?id=9127#c102) and Wagamama High Spec Trial Edition (https://wagahigh.com/download_trial.php#normal ; ダウンロード means download). -- v6: winegstreamer/tests: Test IMediaObject_GetOutputSizeInfo. winegstreamer: Implement DMO interface for WMA decoder. winegstreamer: Switch WMA decoder to use wg_format internally. winegstreamer: Implement WMA <-> AMT conversion. winegstreamer: Add wg_format_from_caps_audio_wma function. https://gitlab.winehq.org/wine/wine/-/merge_requests/4450

3 13

[PATCH 0/1] MR4476: msvcrt: Perform a base-10 logarithm using integer math.
by Zebediah Figura (＠zfigura) 22 Nov '23

22 Nov '23

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/4476

2 1

[PATCH 0/1] MR4435: wineoss: Fix sound not working.
by Davide Beatrici (＠davidebeatrici) 22 Nov '23

22 Nov '23

Fixes #55886. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4435

3 2

[PATCH v2 0/1] MR4471: msvcrt: Hold _ENV_LOCK when accessing environment variables.
by Piotr Caban (＠piotr) 22 Nov '23

22 Nov '23

-- v2: msvcrt: Hold _ENV_LOCK when accessing environment variables. https://gitlab.winehq.org/wine/wine/-/merge_requests/4471

2 2

[PATCH v3 0/7] MR544: ws2_32: More TCP reset patches.
by Zebediah Figura (＠zfigura) 22 Nov '23

22 Nov '23

-- v3: ws2_32: Translate AFD_POLL_RESET to FD_CLOSE plus WSAECONNABORTED in WSAEnumNetworkEvents(). server: Translate AFD_POLL_RESET to FD_CLOSE plus WSAECONNABORTED in window messages. server: Return ERROR_CONNECTION_RESET when trying to recv() on a reset socket. ws2_32/tests: Work around a Linux bug. ws2_32/tests: Test send() after TCP reset. http.sys: Keep connection sockets open after sending a 400 response. ws2_32/tests: Test sending data to a peer which is closed. https://gitlab.winehq.org/wine/wine/-/merge_requests/544

3 9

[PATCH 0/1] MR4418: cmd: Delay variable substitution until after the if clause is parsed.
by Alex Henrie (＠alexhenrie) 22 Nov '23

22 Nov '23

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=55859 -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4418

3 6

[PATCH 0/1] MR4471: msvcrt: Hold _ENV_LOCK when accessing environment variables.
by Piotr Caban (＠piotr) 22 Nov '23

22 Nov '23

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/4471

3 4

[PATCH 0/3] MR487: vkd3d-shader/hlsl: Fix infinite loops when applying copy-prop to swizzles, version 3.
by Francisco Casas (＠fcasas) 22 Nov '23

22 Nov '23

Supersedes !482. Instead of only storing the value that each variable's component has at the moment of the instruction currently handled by copy-prop, we store the trace of all the historic values with their timestamps, i.e. the instruction index on which the value was stored. This allow us to query the value that the variable's component had at the time of a swizzle's load instead of the swizzle instead, which also preempts copy-prop from getting stuck in an infinite loop, as which the added tests. -- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/487

3 7

[PATCH 0/1] MR4469: wineusb.sys: Add support for URB_FUNCTION_VENDOR_DEVICE.
by Hans Leidekker (＠hans) 22 Nov '23

22 Nov '23

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/4469

3 2

[PATCH v3 0/1] MR498: server: Allow creating named pipes using \Device\NamedPipe\ as RootDirectory. (#52105)
by Jinoh Kang (＠iamahuman) 22 Nov '23

22 Nov '23

On Windows, \Device\NamedPipe\ is the root directory of the named pipe file system (NPFS), and can be used as RootDirectory to skip its path when accessing the NPFS namespace. --- **Note**: `if (name->str && !name->len)` may look hacky, but it's used to indicate trailing `\\`[^bks] and existing code already does it too: - `server/directory.c` checks `name->str`[^dir] to test if this is the last component. This is evident by the fact that changing it to `name->len` will lead to major regression. - `server/registry.c` has similar lookup logic.[^reg1][^reg2] [^bks]: https://gitlab.winehq.org/wine/wine/-/blob/c64aa0006e4a33d755a57a693cd81dc1… [^dir]: https://gitlab.winehq.org/wine/wine/-/blob/c64aa0006e4a33d755a57a693cd81dc1… [^reg1]: <https://gitlab.winehq.org/wine/wine/-/blob/c64aa0006e4a33d755a57a693cd81dc1…> [^reg2]: <https://gitlab.winehq.org/wine/wine/-/blob/c64aa0006e4a33d755a57a693cd81dc1…> -- v3: server: Allow creating named pipes using \Device\NamedPipe\ as RootDirectory. https://gitlab.winehq.org/wine/wine/-/merge_requests/498

3 13

[PATCH 0/1] MR4475: gdiplus: Avoid computation overflow and underflow by using hypotf
by Bartosz Kosiorek (＠gang65) 22 Nov '23

22 Nov '23

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=45123 By using sqrt(a * a + b * b), for large (or small) a or b, there is a possibility of overflow (underflow), although the result itself is not that big to cause overflow. To overcome this problem, there are implementations of hypotenuse that do not use power of 2, and use other methods to calculate the result. To calculate a ⊕ b, you can easily use hypotf(a,b). https://en.cppreference.com/w/cpp/numeric/math/hypot -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4475

2 1

Re: [PATCH v3 0/2] MR4440: regsvr32: Explicitly output of unix fd.
by Jacek Caban (＠jacek) 22 Nov '23

22 Nov '23

Jacek Caban (@jacek) commented about programs/regsvr32/regsvr32.c: > Unregister = TRUE; > break; > case 's': > + SetThreadLocale(MAKELCID(MAKELANGID(LANG_ENGLISH, SUBLANG_ENGLISH_US), SORT_DEFAULT)); We're using the same thread later to call arbitrary DLL code later, so changing locale here doesn't seem right. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4440#note_53347

1 0

[PATCH 0/1] MR4474: winhttp: Use an unsigned integer for number values in query_headers().
by Hans Leidekker (＠hans) 22 Nov '23

22 Nov '23

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/4474

2 1

[PATCH v4 0/11] MR4439: mfplat: Implement MFInitAMMediaTypeFromMFMediaType and related functions.
by Rémi Bernon (＠rbernon) 22 Nov '23

22 Nov '23

IMFMediaType_(Get|Free)Representation is called by Samurai Maiden, MFInitAMMediaTypeFromMFMediaType could be useful to simplify DMO / MFT transforms implementations. -- v4: mfplat: Implement IMFMediaType_(Get|Free)Representation. mfplat: Implement MFCreateAMMediaTypeFromMFMediaType. mfplat: Implement MFInitAMMediaTypeFromMFMediaType. mfplat: Use bits per pixel in uncompressed formats metadata. mfplat: Only convert MEDIASUBTYPE for the formats which need it. mfplat/tests: Add IMFMediaType_GetRepresentation tests. mfplat/tests: Add tests for MFCreateAMMediaTypeFromMFMediaType. mfplat/tests: Add tests for MFInitAMMediaTypeFromMFMediaType. mfplat: Add MFInitAMMediaTypeFromMFMediaType stub. mfplat: Add MFCreateAMMediaTypeFromMFMediaType stub. mfplat: Add support for internal MFVideoFormat_A2B10G10R10. https://gitlab.winehq.org/wine/wine/-/merge_requests/4439

4 13

[PATCH v3 0/10] MR4439: mfplat: Implement MFInitAMMediaTypeFromMFMediaType and related functions.
by Rémi Bernon (＠rbernon) 22 Nov '23

22 Nov '23

IMFMediaType_(Get|Free)Representation is called by Samurai Maiden, MFInitAMMediaTypeFromMFMediaType could be useful to simplify DMO / MFT transforms implementations. -- v3: mfplat: Implement IMFMediaType_(Get|Free)Representation. mfplat: Implement MFCreateAMMediaTypeFromMFMediaType. mfplat: Implement MFInitAMMediaTypeFromMFMediaType. mfplat: Use bits per pixel in uncompressed formats metadata. mfplat: Only convert MEDIASUBTYPE for the formats which need it. mfplat/tests: Add IMFMediaType_GetRepresentation tests. mfplat/tests: Add tests for MFCreateAMMediaTypeFromMFMediaType. mfplat/tests: Add tests for MFInitAMMediaTypeFromMFMediaType. mfplat: Add MFInitAMMediaTypeFromMFMediaType stub. mfplat: Add MFCreateAMMediaTypeFromMFMediaType stub. https://gitlab.winehq.org/wine/wine/-/merge_requests/4439

4 16

[PATCH 0/1] MR4473: msvcp140: Add codecvt<char16> class stub.
by Piotr Caban (＠piotr) 22 Nov '23

22 Nov '23

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/4473

2 1

[PATCH v2 0/1] MR486: tests: Introduce an OpenGL shader runner.
by Henri Verbeet (＠hverbeet) 22 Nov '23

22 Nov '23

-- v2: tests: Introduce an OpenGL shader runner. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/486

2 2

[PATCH 0/1] MR4472: user32/tests: Add a trailing linefeed to ok() and skip() calls.
by Francois Gouget (＠fgouget) 22 Nov '23

22 Nov '23

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/4472

3 2

[PATCH 0/1] MR486: tests: Introduce an OpenGL shader runner.
by Henri Verbeet (＠hverbeet) 22 Nov '23

22 Nov '23

-- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/486

3 5

[PATCH v5 0/3] MR364: vkd3d-shader/hlsl: Implement inverse trigonometry.
by Petrichor Park (＠petrathekat) 22 Nov '23

22 Nov '23

Implements asin, acos, atan, and atan2. Also includes some tests in a new test file. One possible problem here is that I'm not sure how to test what Microsoft's atan and atan2 outputs are in boundary cases like atan2(1, 0). I've made the test suites adhere with the calculator program I've been using (Qalculate, which I assume is using libc's atan2). Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=55154 -- v5: vkd3d-shader/hlsl: Implement atan2. vkd3d-shader/hlsl: Implement atan. vkd3d-shader/hlsl: Implement acos and asin trig intrinsics. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/364

4 7

[PATCH v5 0/3] MR3876: Zero-width character handling in GetTextExtentExPoint[AWI]
by Torge Matthies (＠tmatthies) 22 Nov '23

22 Nov '23

Certain characters are considered by GetTextExtentExPointA/W/I to have no width, even if they have a non-zero width and a shape in the font. This MR attempts to bring Wine's implementation of these functions closer to native behavior. One remaining difference is caused by GetGlyphIndicesA/W returning 0 instead of 0xffff for some characters, for some reason. This also affects the handling by GetTextExtentExPointA/W/I of affected characters. I have compared this with both Uniscribe and DWrite behavior and neither of them match this behavior, so it seems to be a peculiarity of these older functions. Remaining differences are probably caused by differences in the fallback fonts used when a character is missing from the selected font. Notably, on my system there doesn't seem to be a fallback font for `\t`/`\n`/`\r` that marks those characters as zero-width, and since applications are likely to depend on the metrics of those characters (I know of at least one), I have opted to explicitly make them zero-width in this MR, even though that is technically not what Windows does. -- v5: win32u: Handle glyphs that are marked by the font as zero-width in GetTextExtentExPoint[AWI]. win32u: Use maximum of (A, A+C, A+C+B) width for character fit test in GetTextExtentExPoint[AWI]. gdi32/tests: Add test for width of carriage return and line feed. https://gitlab.winehq.org/wine/wine/-/merge_requests/3876

3 4

[PATCH v6 0/4] MR478: vkd3d-shader/hlsl: Parse integers with the 'u' postfix.
by Francisco Casas (＠fcasas) 22 Nov '23

22 Nov '23

-- v6: vkd3d-shader/hlsl: Discern between signed and unsigned ints when parsing. tests: Test overloads with signed and unsigned numeric values. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/478

5 8

Re: [PATCH v3 0/1] MR3844: odbccp32: Handle memory allocation failure in SQLGetInstalledDriversW (cppcheck). - closed
by Alexandre Julliard (＠julliard) 22 Nov '23

22 Nov '23

This merge request was closed by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3844

1 0

Re: [PATCH v3 0/1] MR3844: odbccp32: Handle memory allocation failure in SQLGetInstalledDriversW (cppcheck).
by Alexandre Julliard (＠julliard) 22 Nov '23

22 Nov '23

Closing for the same reason as !3846. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3844#note_53312

1 0

Re: [PATCH v3 0/1] MR3847: winmm: Handle memory allocation failure in WINMM_OpenDevice (cppcheck).
by Alexandre Julliard (＠julliard) 22 Nov '23

22 Nov '23

Closing for the same reason as !3846. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3847#note_53310

1 0

Re: [PATCH v3 0/1] MR3847: winmm: Handle memory allocation failure in WINMM_OpenDevice (cppcheck). - closed
by Alexandre Julliard (＠julliard) 22 Nov '23

22 Nov '23

This merge request was closed by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3847

1 0

Re: [PATCH v3 0/1] MR3846: winmm: Handle memory allocation failure in MMDRV_InitPerType (cppcheck).
by Alexandre Julliard (＠julliard) 22 Nov '23

22 Nov '23

Like Huw said, this is mostly a matter of taste, so it's better not to change existing code. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3846#note_53309

1 0

Re: [PATCH v3 0/1] MR3846: winmm: Handle memory allocation failure in MMDRV_InitPerType (cppcheck). - closed
by Alexandre Julliard (＠julliard) 22 Nov '23

22 Nov '23

This merge request was closed by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3846

1 0

[PATCH 0/1] MR4470: ntoskrnl: Stub EtwRegisterClassicProvider() and EtwUnregister().
by Hans Leidekker (＠hans) 22 Nov '23

22 Nov '23

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/4470

2 1

[PATCH v2 0/10] MR4438: dmime, dmsynth: Message ordering fixes.
by Anton Baskanov (＠baskanov) 22 Nov '23

22 Nov '23

-- v2: dmsynth: Use time instead of position to order events. dmsynth: Preserve event order when positions are equal. dmime: Queue note-off one tick early. dmime: Requeue the note message instead of directly queueing MIDI note-off. dmime/tests: Test output tool note requeueing. dmime/tests: Move scale_music_time() and check_dmus_note_pmsg() up. dmime: Correctly requeue messages with changed time. dmime: Always queue messages with non-immediate delivery type. dmime: Don't queue messages with immediate delivery type. dmime: Factor out timeout computation. https://gitlab.winehq.org/wine/wine/-/merge_requests/4438

2 15

[PATCH v16 0/6] MR471: vkd3d-shader/dxil: Implement the DXIL GEP and LOAD instructions.
by Conor McCarthy (＠cmccarthy) 22 Nov '23

22 Nov '23

-- v16: vkd3d-shader/dxil: Implement the DXIL LOAD instruction. vkd3d-shader/dxil: Implement the DXIL GEP instruction. vkd3d-shader/dxil: Support global variable initialisers. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/471

3 7

Re: [PATCH v2 0/7] MR4455: winewayland: Implement support for non-US keyboard layouts.
by Rémi Bernon (＠rbernon) 22 Nov '23

22 Nov '23

On Wed Nov 22 09:54:08 2023 +0000, Rémi Bernon wrote: > changed this line in [version 2 of the diff](/wine/wine/-/merge_requests/4455/diffs?diff_id=85135&start_sha=f874b6f423bd4043b0c26c3011371f366b0f9504#61204a3bfaf089b3588b75ee6440092f482a6098_609_596) Yeah, I had it like that and then, although I agree it's unnecessary, thought that as the mutex is guarding its initialization it should guard its access for consistency. Anyway, I changed it back. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4455#note_53291

1 0

[PATCH v2 0/8] MR4456: winewayland.drv: part 10.2: Vulkan swapchain support (without presentation)
by Alexandros Frantzis (＠afrantzis) 22 Nov '23

22 Nov '23

This part introduces support for Vulkan swapchains to the Wayland driver: * Implement several Vulkan functions typically called to get info before swapchain creation. * Implement swapchain creation/destruction * Implement getting swapchain images. I stopped short of adding presentation support since the MR would grow too big (stay tuned for part 10.3). Thanks! -- v2: winewayland.drv: Implement vkGetSwapchainImagesKHR. winewayland.drv: Implement vkGetPhysicalDeviceWin32PresentationSupportKHR. winewayland.drv: Implement vkGetPhysicalDeviceSurfacePresentModesKHR winewayland.drv: Implement vkDestroySwapchainKHR. winewayland.drv: Implement vkCreateSwapchainKHR. winewayland.drv: Implement vkGetPhysicalDeviceSurfaceCapabilities(2)KHR. winewayland.drv: Implement vkGetPhysicalDeviceSurfaceFormats(2)KHR. winewayland.drv: Implement vkGetPhysicalDeviceSurfaceSupportKHR. https://gitlab.winehq.org/wine/wine/-/merge_requests/4456

3 11

Re: [PATCH v3 0/2] MR4440: regsvr32: Explicitly output of unix fd.
by eric pouech (＠epo) 22 Nov '23

22 Nov '23

On Wed Nov 22 09:15:51 2023 +0000, Zebediah Figura wrote: > I'm confused about why "scripting" is a concern here. Do any scripts > currently parse the *text* output, which is currently localized, and > redundant with the return value anyway? Would changing that to MESSAGE > actually keep compatibility in that case? > I think it probably makes sense to keep console output for the sake of > clear communication, but I don't understand why scripting. As posted above, some native apps don't return error code (eg. see comments in regedit - didn't retest it though). So scripts calling these apps want to keep output for at least let the user know (from reading the output) if something went wrong (see https://bugs.winehq.org/show_bug.cgi?id=55723). The concern of 'scripting' is more linked to keeping an output, rather than insuring that output has a given form (or defined structure to be parsed. The idea was : * keep an output (at least in case of error) to the Unix console * MESSAGE avoids reopening fd 1 as handle (at the cost of moving output from stdout to stderr), and also loses proper conversion to unix shell locale, hence the request to force English locale to have something always readable * if scripters want to parse output, they likely already force a given locale -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4440#note_53283

1 0

[PATCH 0/7] MR4455: winewayland: Implement support for non-US keyboard layouts.
by Rémi Bernon (＠rbernon) 22 Nov '23

22 Nov '23

Detecting the host layout languages from their Xkb identifiers, and introducing a new driver interface using the KBDTABLES structure to translate them to Win32. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4455

3 11

[PATCH v3 0/2] MR4399: win32u: Support key message repeat for winewayland.
by Rémi Bernon (＠rbernon) 22 Nov '23

22 Nov '23

-- v3: win32u: Implement opt-in auto-repeat for WM_(SYS)KEYDOWN messages. winewayland.drv: Configure win32u keyboard repeat delay and speed. https://gitlab.winehq.org/wine/wine/-/merge_requests/4399

4 6

[PATCH v2 0/1] MR4437: d3dcompiler_43: Use CRT allocation functions.
by Alex Henrie (＠alexhenrie) 22 Nov '23

22 Nov '23

-- v2: d3dcompiler_43: Use CRT allocation functions. https://gitlab.winehq.org/wine/wine/-/merge_requests/4437

3 3

[PATCH v3 0/1] MR4466: win32u/winex11: Add the GPU device physical memory registry
by arilou (＠arilou) 22 Nov '23

22 Nov '23

Starcraft Remastered is looking up for the GPU physical memory size to check for minimum requirements to enable RealTime Lighting. This patch should solve the bug: https://bugs.winehq.org/show_bug.cgi?id=46624 Signed-off-by: Jon Doron <arilou(a)gmail.com> -- v3: win32u/winex11: Add the GPU device physical memory registry https://gitlab.winehq.org/wine/wine/-/merge_requests/4466

2 1

[PATCH v2 0/1] MR4466: win32u/winex11: Add the GPU device physical memory registry
by arilou (＠arilou) 22 Nov '23

22 Nov '23

Starcraft Remastered is looking up for the GPU physical memory size to check for minimum requirements to enable RealTime Lighting. This patch should solve the bug: https://bugs.winehq.org/show_bug.cgi?id=46624 Signed-off-by: Jon Doron <arilou(a)gmail.com> -- v2: win32u/winex11: Add the GPU device physical memory registry https://gitlab.winehq.org/wine/wine/-/merge_requests/4466

3 2

[PATCH 0/1] MR4466: win32u/winex11: Add the GPU device physical memory registry
by arilou (＠arilou) 22 Nov '23

22 Nov '23

Starcraft Remastered is looking up for the GPU physical memory size to check for minimum requirements to enable RealTime Lighting. This patch should solve the bug: https://bugs.winehq.org/show_bug.cgi?id=46624 Signed-off-by: Jon Doron <arilou(a)gmail.com> -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4466

3 6

[PATCH v2 0/2] MR4066: win32u: Skip windows that are not activated even once in activate_other_window().
by Zhiyi Zhang (＠zhiyi) 22 Nov '23

22 Nov '23

-- v2: win32u: Skip windows that are not activated even once in activate_other_window(). user32/tests: Add window activation tests. https://gitlab.winehq.org/wine/wine/-/merge_requests/4066

3 4

[PATCH 0/2] MR4451: rpcrt4: Support for explicit handle passing
by Haoyang Chen (＠chenhaoyang) 22 Nov '23

22 Nov '23

If explicit_handle is defined in the *.idl file, c/s are uses explicit handles, then an explicit handle must be passed in to the server-side interface. And add a test for explicit_handle. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4451

4 10

[PATCH 0/1] MR4465: msdasql: ICommandText::Execute check rowset pointer before assignment
by Alistair Leslie-Hughes (＠alesliehughes) 22 Nov '23

22 Nov '23

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/4465

2 1

[PATCH 0/4] MR4457: Add tests and implementation of FILE_{RENAME,LINK}_POSIX_SEMANTICS.
by Joel Holdsworth (＠jhol) 22 Nov '23

22 Nov '23

Signed-off-by: Joel Holdsworth <joel(a)airwebreathe.org.uk> -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4457

3 5

[PATCH 0/4] MR4464: oledb32/tests: Use wide-char string literals.
by Zhiyi Zhang (＠zhiyi) 22 Nov '23

22 Nov '23

And make these strings const. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4464

2 4

[PATCH 0/3] MR4463: msdasql: Return all initialization properties if no property ID is specified...
by Zhiyi Zhang (＠zhiyi) 22 Nov '23

22 Nov '23

msdasql: Return all initialization properties if no property ID is specified in dbprops_GetProperties(). -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4463

2 3

[PATCH v4 0/12] MR477: Draft: vkd3d-shader: Finish global variable and GEP support.
by Conor McCarthy (＠cmccarthy) 22 Nov '23

22 Nov '23

Goes atop !471. The last six commits belong to this MR. -- v4: vkd3d-shader/dxil: Emit constant global arrays as immediate constant buffers. vkd3d-shader: Add a register index to struct vkd3d_shader_immediate_constant_buffer. vkd3d-shader/spirv: Support declared component type and count in immediate constant buffers. vkd3d-shader/spirv: Support constant initialisers in indexable temps. vkd3d-shader/dxil: Support null constant arrays. vkd3d-shader/spirv: Support declared component type and count in indexable temps. vkd3d-shader/dxil: Implement the DXIL LOAD instruction. vkd3d-shader/dxil: Implement the DXIL GEP instruction. vkd3d-shader/dxil: Support global variable initialisers. vkd3d-shader/dxil: Introduce a value type for immediate constant buffers. vkd3d-shader/dxil: Implement default address space global variables. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/477

2 12

[PATCH v15 0/6] MR471: vkd3d-shader/dxil: Implement the DXIL GEP and LOAD instructions.
by Conor McCarthy (＠cmccarthy) 22 Nov '23

22 Nov '23

-- v15: vkd3d-shader/dxil: Implement the DXIL LOAD instruction. vkd3d-shader/dxil: Implement the DXIL GEP instruction. vkd3d-shader/dxil: Support global variable initialisers. vkd3d-shader/dxil: Introduce a value type for immediate constant buffers. vkd3d-shader/dxil: Implement default address space global variables. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/471

2 6

[PATCH v5 0/5] MR4450: winegstreamer: WMA DMO support
by Alfred Agrell (＠Alcaro) 21 Nov '23

21 Nov '23

Along with !4449, this fixes WMV videos in microkiri (https://bugs.winehq.org/show_bug.cgi?id=9127#c102) and Wagamama High Spec Trial Edition (https://wagahigh.com/download_trial.php#normal ; ダウンロード means download). -- v5: winegstreamer/tests: Test IMediaObject_GetOutputSizeInfo. winegstreamer: Implement DMO interface for WMA decoder. winegstreamer: Switch WMA decoder to use wg_format internally. winegstreamer: Implement WMA <-> AMT conversion. winegstreamer: Add wg_format_from_caps_audio_wma function. https://gitlab.winehq.org/wine/wine/-/merge_requests/4450

4 14

[PATCH v12 0/23] MR1088: ntdll: Avoid calling pthread_exit on thread exit.
by Rémi Bernon (＠rbernon) 21 Nov '23

21 Nov '23

Using a dedicated exit jmpbuf and removing the need for assembly routines. When Wine handles an exception in unix code, we return to user mode by jumping to the last syscall frame. This can leave some pthread cancel cleanups registered, in the pthread internal linked list, and at the same time later overwrite the stack frame they were registered for. In the same way, jumping to the exit frame on thread exit or abort, can also leave some cleanup handlers registered for invalid stack frames. Depending on the implementation, calling pthread_exit will cause all the registered pthread cleanup handlers to be called, possibly jumping back to now overwritten stack frames and causing segmentation faults. Exiting a pthread normally, by returning from its procedure, or calling exit(0) for the main thread doesn't run pthread_exit and doesn't call cleanup handlers, avoiding that situation. Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=52213 ### Additional note: For robustness, we should probably try to execute these cleanup handlers when unwinding the stack frames, as we would otherwise leave pthread objects in a potential problematic state (like a mutex locked, etc). It is however hard to do so when the handlers are registered from some C code: pthread C implementation is done by calling some internal pthread functions to register the handlers, and they aren't registered as standard unwind handlers. Only pthread_cancel and pthread_exit can unwind and call / unregister the C handlers, but interrupting that procedure, for instance calling setjmp / longjmp from withing our own handler isn't supported. From C++ code, pthread cleanup handlers are registered through C++ class constructors / destructors, and it would then be possible to partially unwind and call them at the same time. -- v12: ntdll: Remove the signal_exit_thread wrapper. ntdll: Get rid of the thread exit frame on ARM. ntdll: Get rid of the thread exit frame on ARM64. ntdll: Get rid of the thread exit frame on x86-64. ntdll: Get rid of the thread exit frame on i386. ntdll: Switch to the kernel stack to abort a thread on ARM. ntdll: Switch to the kernel stack to abort a thread on ARM64. ntdll: Switch to the kernel stack to abort a thread on x86-64. ntdll: Switch to the kernel stack to abort a thread on i386. ntdll: Connect syscall frames across user callbacks on ARM. ntdll: Connect syscall frames across user callbacks on ARM64. ntdll: Connect syscall frames across user callbacks on x86-64. ntdll: Connect syscall frames across user callbacks on i386. ntdll: Add a syscall_cfa member to the ARM syscall frame. ntdll: Add a syscall_cfa member to the ARM64 syscall frame. ntdll: Add a syscall_cfa member to the x86_64 syscall frame. ntdll: Add a syscall_cfa member to the i386 syscall frame. ntdll: Remove unnecessary stack pointer CFI rules. ntdll: Add comments to stack switches in dispatchers. ntdll: Directly access the syscall table variable on ARM64. ntdll: Directly access the syscall table variable on x86-64. ntdll: Store the syscall table in the TEB on ARM. ntdll: Store the syscall table in the TEB on i386. This merge request has too many patches to be relayed via email. Please visit the URL below to see the contents of the merge request. https://gitlab.winehq.org/wine/wine/-/merge_requests/1088

1 0

[PATCH v3 0/2] MR482: vkd3d-shader/hlsl: Fix infinite loops when applying copy-prop to swizzles.
by Francisco Casas (＠fcasas) 21 Nov '23

21 Nov '23

Current copy-prop of swizzle instructions can result in infinite loops, as with the included test before this commit. Consider the following sequence of instructions where a load is stored in the same variable it loads: 1 : A 2 : A = @1 3 : @1.x In this case @3 would call copy_propagation_get_value() on A.x and would get @1, without detecting that that is indeed the same node it is already using as swizzle->value. So it would return true, keeping copy-prop spinning. To avoid this, it is check that the replacement instruction is not the same as the swizzle->load instruction. --- This was discovered when trying to compile shaders from [Bug 19499](https://www.codeweavers.com/support/bugs/browse?cmd=bug_edit;bug_id=…. -- v3: vkd3d-shader/hlsl: Avoid replacing with the same swizzle in copy-prop. vkd3d-shader/hlsl: Move index_instructions() up. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/482

4 14

Re: [PATCH v2 0/1] MR4454: winegstreamer: Store duration in the duration field. - approved
by Alexandre Julliard (＠julliard) 21 Nov '23

21 Nov '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4454

1 0

Re: [PATCH v3 0/2] MR4346: winegstreamer: Implement wg_muxer_read_data. - approved
by Alexandre Julliard (＠julliard) 21 Nov '23

21 Nov '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4346

1 0

Re: [PATCH v2 0/1] MR4413: advapi32/tests: Fix a service stop race condition. - approved
by Alexandre Julliard (＠julliard) 21 Nov '23

21 Nov '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4413

1 0

[PATCH v4 0/5] MR4450: winegstreamer: WMA DMO support
by Alfred Agrell (＠Alcaro) 21 Nov '23

21 Nov '23

Along with !4449, this fixes WMV videos in microkiri (https://bugs.winehq.org/show_bug.cgi?id=9127#c102) and Wagamama High Spec Trial Edition (https://wagahigh.com/download_trial.php#normal ; ダウンロード means download). -- v4: winegstreamer/tests: Test IMediaObject_GetOutputSizeInfo. winegstreamer: Implement DMO interface for WMA decoder. winegstreamer: Switch WMA decoder to use wg_format internally. winegstreamer: Implement WMA <-> AMT conversion. https://gitlab.winehq.org/wine/wine/-/merge_requests/4450

4 22

Re: [PATCH v6 0/7] MR4377: Reimplement msvcrt env functions to match native. - approved
by Alexandre Julliard (＠julliard) 21 Nov '23

21 Nov '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4377

1 0

Re: [PATCH v3 0/1] MR4446: msvcp110: Implement std::_Xbad_function_call(). - approved
by Alexandre Julliard (＠julliard) 21 Nov '23

21 Nov '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4446

1 0

Re: [PATCH v2 0/1] MR4447: msado15: Correct logic when setting field value. - approved
by Alexandre Julliard (＠julliard) 21 Nov '23

21 Nov '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4447

1 0

Re: [PATCH v2 0/1] MR4448: winemac.drv: Return success from query_ime_char_rect. - approved
by Alexandre Julliard (＠julliard) 21 Nov '23

21 Nov '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4448

1 0

Re: [PATCH v3 0/1] MR4434: winex11: Free correct pointer when using xf86vm - approved
by Alexandre Julliard (＠julliard) 21 Nov '23

21 Nov '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4434

1 0

Re: [PATCH v2 0/1] MR4430: d3dcompiler/tests: Do not crash on device creation. - approved
by Alexandre Julliard (＠julliard) 21 Nov '23

21 Nov '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4430

1 0

Re: [PATCH v2 0/1] MR4453: wbemprox: Add StandardCimv2 namespace. - approved
by Alexandre Julliard (＠julliard) 21 Nov '23

21 Nov '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4453

1 0

Re: [PATCH v2 0/3] MR485: vkd3d-shader/ir: Skip recording combined resource/sampler information for dynamically indexed descriptor arrays. - approved
by Alexandre Julliard (＠julliard) 21 Nov '23

21 Nov '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/485

1 0

[PATCH 0/2] MR4452: Draft: d2d1: Acquire lock before attempt draw to device context
by Brendan McGrath (＠redmcg) 21 Nov '23

21 Nov '23

CW bug 22597 -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4452

4 4

[PATCH 0/1] MR4454: winegstreamer: Store duration in the duration field.
by Alfred Agrell (＠Alcaro) 21 Nov '23

21 Nov '23

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/4454

4 3

[PATCH v2 0/2] MR4346: winegstreamer: Implement wg_muxer_read_data.
by Ziqing Hui (＠zhui) 21 Nov '23

21 Nov '23

-- v2: winegstreamer: Implement wg_muxer_read_data. winestreamer: Introduce media_sink_write_stream. https://gitlab.winehq.org/wine/wine/-/merge_requests/4346

4 4

Re: [PATCH v3 0/2] MR4440: regsvr32: Explicitly output of unix fd.
by Zebediah Figura (＠zfigura) 21 Nov '23

21 Nov '23

I'm confused about why "scripting" is a concern here. Do any scripts currently parse the *text* output, which is currently localized, and redundant with the return value anyway? Would changing that to MESSAGE actually keep compatibility in that case? I think it probably makes sense to keep console output for the sake of clear communication, but I don't understand why scripting. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4440#note_53135

1 0

[PATCH 0/1] MR4458: user32: Add SetDisplayAutoRotationPreferences stub.
by Myah Caron (＠qsniyg) 21 Nov '23

21 Nov '23

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=55920 Signed-off-by: Myah Caron <qsniyg(a)protonmail.com> -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4458

2 1

Re: [PATCH v4 0/8] MR4380: mshtml: Keep inner window's link to the outer window until it's destroyed.
by Gabriel Ivăncescu (＠insn) 21 Nov '23

21 Nov '23

Ugh, I don't know why it had 0 commits?! Anyway, forced push again. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4380#note_53134

1 0

[PATCH 0/8] MR4456: winewayland.drv: part 10.2: Vulkan swapchain support (without presentation)
by Alexandros Frantzis (＠afrantzis) 21 Nov '23

21 Nov '23

This part introduces support for Vulkan swapchains to the Wayland driver: * Implement several Vulkan functions typically called to get info before swapchain creation. * Implement swapchain creation/destruction * Implement getting swapchain images. I stopped short of adding presentation support since the MR would grow too big (stay tuned for part 10.3). Thanks! -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4456

3 10

[PATCH v2 0/2] MR4440: regsvr32: Explicitly output of unix fd.
by eric pouech (＠epo) 21 Nov '23

21 Nov '23

This program is in GUI subsystem, but expects I/O with Unix console. This is a Wine specific behavior. So explicitely use unix fd instead of the inherited standard handles. Wine-Bugs: https://bugs.winehq.org/show_bug.cgi?id=55723 Signed-off-by: Eric Pouech <epouech(a)codeweavers.com> -- v2: regedit: Use message boxes by default for output. regsvr32: Use message boxes by default for output. https://gitlab.winehq.org/wine/wine/-/merge_requests/4440

3 3

[PATCH 0/4] MR4051: Add tests and implementation of FILE_{RENAME,LINK}_POSIX_SEMANTICS.
by Joel Holdsworth (＠jhol) 21 Nov '23

21 Nov '23

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/4051

2 5

[PATCH 0/1] MR4440: regsvr32: Explicitly output of unix fd.
by eric pouech (＠epo) 21 Nov '23

21 Nov '23

This program is in GUI subsystem, but expects I/O with Unix console. This is a Wine specific behavior. So explicitely use unix fd instead of the inherited standard handles. Wine-Bugs: https://bugs.winehq.org/show_bug.cgi?id=55723 Signed-off-by: Eric Pouech <epouech(a)codeweavers.com> -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4440

5 14

[PATCH v2 0/4] MR4406: win32u: Fix reported text extent and actual text size mismatch.
by Paul Gofman (＠gofman) 21 Nov '23

21 Nov '23

Freetype's FT_Load_Glyph may return different glyph metrics (in particular, horiAdvance) depending on load target flags (FT_LOAD_TARGET_MONO, FT_LOAD_TARGET_NORMAL ...). Among the consequences of that are: - the size of, e. g, GetTextExtentPoint() doesn't match the size of actually rendered text; - DrawTextW() with DT_CALCRECT flag returns wrong bounding rectangle. In the core of that is GetGlyphOutline() returning different values for GGO_METRICS format (used in various glyph metrics query functions) and the actual format used during rendering. It probably make sense to use effective fonts rendering option for GGO_METRICS so that matches. I did some ad-hoc testing on Windows with currently problematic Tahoma font and quite expectedly GetGlyphOutline(GGO_METRICS) always returns the same metrics as other output format options. While all the options also have the same metrics between each other (which is still not the case with Wine). I guess it is not easily possible to make all the face load options match each other with freetype (nor I am sure that is always the case on Windows for all the possible fonts), but making GGO_METRICS return the metrics matching actual gdi device context setup looks more important. Fixes Idle Spiral being unable to render typed text in save / load dialogs (which is using Winforms from Unity's Mono). -- v2: win32u: Use font AA flags when querying glyph outline with GGO_METRICS. d3dx9/tests: Make test_ID3DXFont() less dependent on GetGlyphOutlineW(GGO_METRICS) behaviour. https://gitlab.winehq.org/wine/wine/-/merge_requests/4406

3 8

[PATCH v14 0/6] MR471: vkd3d-shader/dxil: Implement the DXIL GEP and LOAD instructions.
by Conor McCarthy (＠cmccarthy) 21 Nov '23

21 Nov '23

-- v14: vkd3d-shader/dxil: Implement the DXIL LOAD instruction. vkd3d-shader/dxil: Implement the DXIL GEP instruction. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/471

3 11

[PATCH 0/1] MR4430: d3dcompiler/tests: Do not crash on device creation.
by Nikolay Sivov (＠nsivov) 21 Nov '23

21 Nov '23

Fixes crashes running with a null driver. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4430

5 7

[PATCH v2 0/2] MR4399: win32u: Support key message repeat for winewayland.
by Rémi Bernon (＠rbernon) 21 Nov '23

21 Nov '23

-- v2: win32u: Implement opt-in auto-repeat for WM_(SYS)KEYDOWN messages. winewayland.drv: Configure win32u keyboard repeat delay and speed. https://gitlab.winehq.org/wine/wine/-/merge_requests/4399

4 7

[PATCH v2 0/1] MR4446: msvcp110: Implement std::_Xbad_function_call().
by Paul Gofman (＠gofman) 21 Nov '23

21 Nov '23

It looks like msvcp doesn't export anything for the std::bad_function_call exception construction and if std::bad_function_call is constructed directly from the app the corresponding class data is generated in the application binary. I am attaching an ad-hoc test program I used to test it (using MSVC 2022 community edition). [msvcp_except.cpp](/uploads/558f0911366525d05af4ac69552c4aae/msvcp_except.cpp) -- v2: msvcp110: Implement std::_Xbad_function_call(). https://gitlab.winehq.org/wine/wine/-/merge_requests/4446

3 2

Re: [PATCH v3 0/5] MR4450: winegstreamer: WMA DMO support
by Alfred Agrell (＠Alcaro) 21 Nov '23

21 Nov '23

On Tue Nov 21 15:10:16 2023 +0000, Rémi Bernon wrote: > I suspect this is actually related to the tests using WMAUDIO2 (aka > WMAudioV8), which, if I believe the headers files, where > WMAUDIO_BITS_PER_SAMPLE is used, only supports 16bps. The bps is then > automatically set and the media type doesn't need one. > Also from the headers, I suspect WMAUDIO3 may support variable bps which > maybe would require changes here and in other places where we use a > fixed value. All of which may require more tests to be sure. Which > probably could be added later. Yes, more tests always help. But GStreamer/ffmpeg don't have any WMA3/WMALossless/WMV3/WMVA/WVC1 encoders, and Windows' media APIs are _complicated_, so I couldn't produce any suitable test files. Probably not a huge deal which output format we use, we've got audioconvert elements. But there's also no point hardcoding things when there's a depth field in struct wg_format; fixed. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4450#note_53102

1 0

Re: [PATCH v3 0/5] MR4450: winegstreamer: WMA DMO support
by Alfred Agrell (＠Alcaro) 21 Nov '23

21 Nov '23

On Tue Nov 21 14:32:55 2023 +0000, Rémi Bernon wrote: > Is this needed by an application or is it just to pass the tests? In the > latter case we can just keep a todo_wine. This flags fixup looks too arbitrary. Needed by Wagamama. Without it, the sound channel gets stuck looping the same ~second over and over. I completely agree it's ugly; feels to me like some kind of GStreamer or ffmpeg bug. If you can think of a better solution, do tell. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4450#note_53101

1 0

[PATCH v2 0/5] MR4450: winegstreamer: WMA DMO support
by Alfred Agrell (＠Alcaro) 21 Nov '23

21 Nov '23

Along with !4449, this fixes WMV videos in microkiri (https://bugs.winehq.org/show_bug.cgi?id=9127#c102) and Wagamama High Spec Trial Edition (https://wagahigh.com/download_trial.php#normal ; ダウンロード means download). -- v2: winegstreamer/tests: Test IMediaObject_GetOutputSizeInfo. winegstreamer: Implement DMO interface for WMA decoder. winegstreamer: Switch WMA decoder to use wg_format internally. winegstreamer: Implement WMA <-> AMT conversion. winegstreamer: Add wg_format_from_caps_audio_wma function. https://gitlab.winehq.org/wine/wine/-/merge_requests/4450

3 6

Re: [PATCH v3 0/5] MR4450: winegstreamer: WMA DMO support
by Rémi Bernon (＠rbernon) 21 Nov '23

21 Nov '23

On Tue Nov 21 14:16:06 2023 +0000, Alfred Agrell wrote: > Should, yes. > But it isn't. gst-launch does the same; it emits multiple buffers for > the same input, and they all have the same flags (except the first one, > which is the discontinuity flag). > ``` > $ GST_DEBUG=5 GST_DEBUG_NO_COLOR=1 gst-launch-1.0 filesrc > location=/home/walrus/x/krkrwine/waga.wmv ! asfdemux ! avdec_wmalossless > ! fakesink 2>&1 | grep 'calling chain' | head -n50 > 0:00:00.191926833 728640 0x5624e1f1ac60 DEBUG GST_SCHEDULING > gstpad.c:4459:gst_pad_chain_data_unchecked:<avdec_wmalossless0:sink> > calling chainfunction &gst_audio_decoder_chain with buffer buffer: > 0x5624e1f65900, pts 0:00:00.000000000, dts 99:99:99.999999999, dur > 0:00:00.098890300, size 13375, offset none, offset_end none, flags 0x6040 > 0:00:00.192388724 728640 0x5624e1f1ac60 DEBUG GST_SCHEDULING > gstpad.c:4459:gst_pad_chain_data_unchecked:<avdec_wmalossless0:sink> > calling chainfunction &gst_audio_decoder_chain with buffer buffer: > 0x5624e1f657e0, pts 0:00:00.556000000, dts 99:99:99.999999999, dur > 0:00:00.098890300, size 13375, offset none, offset_end none, flags 0x6000 > 0:00:00.193187252 728640 0x5624e1f1ac60 DEBUG GST_SCHEDULING > gstpad.c:4459:gst_pad_chain_data_unchecked:<fakesink0:sink> calling > chainfunction &gst_base_sink_chain with buffer buffer: 0x7f9acc0475a0, > pts 0:00:00.000000000, dts 99:99:99.999999999, dur 0:00:00.046439909, > size 8192, offset none, offset_end none, flags 0x40 > 0:00:00.194288686 728640 0x5624e1f1ac60 DEBUG GST_SCHEDULING > gstpad.c:4459:gst_pad_chain_data_unchecked:<fakesink0:sink> calling > chainfunction &gst_base_sink_chain with buffer buffer: 0x7f9acc047480, > pts 0:00:00.046439909, dts 99:99:99.999999999, dur 0:00:00.046439910, > size 8192, offset none, offset_end none, flags 0x0 > 0:00:00.194525602 728640 0x5624e1f1ac60 DEBUG GST_SCHEDULING > gstpad.c:4459:gst_pad_chain_data_unchecked:<fakesink0:sink> calling > chainfunction &gst_base_sink_chain with buffer buffer: 0x7f9acc047360, > pts 0:00:00.092879819, dts 99:99:99.999999999, dur 0:00:00.046439909, > size 8192, offset none, offset_end none, flags 0x0 > 0:00:00.194901624 728640 0x5624e1f1ac60 DEBUG GST_SCHEDULING > gstpad.c:4459:gst_pad_chain_data_unchecked:<fakesink0:sink> calling > chainfunction &gst_base_sink_chain with buffer buffer: 0x7f9acc0475a0, > pts 0:00:00.139319728, dts 99:99:99.999999999, dur 0:00:00.046439909, > size 8192, offset none, offset_end none, flags 0x0 > 0:00:00.195333230 728640 0x5624e1f1ac60 DEBUG GST_SCHEDULING > gstpad.c:4459:gst_pad_chain_data_unchecked:<fakesink0:sink> calling > chainfunction &gst_base_sink_chain with buffer buffer: 0x7f9acc047a20, > pts 0:00:00.185759637, dts 99:99:99.999999999, dur 0:00:00.046439909, > size 8192, offset none, offset_end none, flags 0x0 > 0:00:00.195705815 728640 0x5624e1f1ac60 DEBUG GST_SCHEDULING > gstpad.c:4459:gst_pad_chain_data_unchecked:<fakesink0:sink> calling > chainfunction &gst_base_sink_chain with buffer buffer: 0x7f9acc047900, > pts 0:00:00.232199546, dts 99:99:99.999999999, dur 0:00:00.046439910, > size 8192, offset none, offset_end none, flags 0x0 > 0:00:00.196035104 728640 0x5624e1f1ac60 DEBUG GST_SCHEDULING > gstpad.c:4459:gst_pad_chain_data_unchecked:<fakesink0:sink> calling > chainfunction &gst_base_sink_chain with buffer buffer: 0x7f9acc0475a0, > pts 0:00:00.278639456, dts 99:99:99.999999999, dur 0:00:00.046439909, > size 8192, offset none, offset_end none, flags 0x0 > 0:00:00.196366763 728640 0x5624e1f1ac60 DEBUG GST_SCHEDULING > gstpad.c:4459:gst_pad_chain_data_unchecked:<fakesink0:sink> calling > chainfunction &gst_base_sink_chain with buffer buffer: 0x7f9acc047360, > pts 0:00:00.325079365, dts 99:99:99.999999999, dur 0:00:00.046439909, > size 8192, offset none, offset_end none, flags 0x0 > 0:00:00.196698380 728640 0x5624e1f1ac60 DEBUG GST_SCHEDULING > gstpad.c:4459:gst_pad_chain_data_unchecked:<fakesink0:sink> calling > chainfunction &gst_base_sink_chain with buffer buffer: 0x7f9acc047480, > pts 0:00:00.371519274, dts 99:99:99.999999999, dur 0:00:00.046439910, > size 8192, offset none, offset_end none, flags 0x0 > 0:00:00.197030684 728640 0x5624e1f1ac60 DEBUG GST_SCHEDULING > gstpad.c:4459:gst_pad_chain_data_unchecked:<fakesink0:sink> calling > chainfunction &gst_base_sink_chain with buffer buffer: 0x7f9acc0475a0, > pts 0:00:00.417959184, dts 99:99:99.999999999, dur 0:00:00.046439909, > size 8192, offset none, offset_end none, flags 0x0 > 0:00:00.197361794 728640 0x5624e1f1ac60 DEBUG GST_SCHEDULING > gstpad.c:4459:gst_pad_chain_data_unchecked:<fakesink0:sink> calling > chainfunction &gst_base_sink_chain with buffer buffer: 0x7f9acc047900, > pts 0:00:00.464399093, dts 99:99:99.999999999, dur 0:00:00.046439909, > size 8192, offset none, offset_end none, flags 0x0 > 0:00:00.197687886 728640 0x5624e1f1ac60 DEBUG GST_SCHEDULING > gstpad.c:4459:gst_pad_chain_data_unchecked:<fakesink0:sink> calling > chainfunction &gst_base_sink_chain with buffer buffer: 0x7f9acc047a20, > pts 0:00:00.510839002, dts 99:99:99.999999999, dur 0:00:00.046439910, > size 8192, offset none, offset_end none, flags 0x0 > 0:00:00.197938711 728640 0x5624e1f1ac60 DEBUG GST_SCHEDULING > gstpad.c:4459:gst_pad_chain_data_unchecked:<avdec_wmalossless0:sink> > calling chainfunction &gst_audio_decoder_chain with buffer buffer: > 0x5624e1f65b40, pts 0:00:00.835000000, dts 99:99:99.999999999, dur > 0:00:00.098890300, size 13375, offset none, offset_end none, flags 0x6000 > 0:00:00.198238421 728640 0x5624e1f1ac60 DEBUG GST_SCHEDULING > gstpad.c:4459:gst_pad_chain_data_unchecked:<fakesink0:sink> calling > chainfunction &gst_base_sink_chain with buffer buffer: 0x7f9acc04b120, > pts 0:00:00.556000000, dts 99:99:99.999999999, dur 0:00:00.046439909, > size 8192, offset none, offset_end none, flags 0x0 > 0:00:00.198574422 728640 0x5624e1f1ac60 DEBUG GST_SCHEDULING > gstpad.c:4459:gst_pad_chain_data_unchecked:<fakesink0:sink> calling > chainfunction &gst_base_sink_chain with buffer buffer: 0x7f9acc04b000, > pts 0:00:00.602439909, dts 99:99:99.999999999, dur 0:00:00.046439910, > size 8192, offset none, offset_end none, flags 0x0 > 0:00:00.198914383 728640 0x5624e1f1ac60 DEBUG GST_SCHEDULING > gstpad.c:4459:gst_pad_chain_data_unchecked:<fakesink0:sink> calling > chainfunction &gst_base_sink_chain with buffer buffer: 0x7f9acc047ea0, > pts 0:00:00.648879819, dts 99:99:99.999999999, dur 0:00:00.046439909, > size 8192, offset none, offset_end none, flags 0x0 > 0:00:00.199266605 728640 0x5624e1f1ac60 DEBUG GST_SCHEDULING > gstpad.c:4459:gst_pad_chain_data_unchecked:<fakesink0:sink> calling > chainfunction &gst_base_sink_chain with buffer buffer: 0x7f9acc04b120, > pts 0:00:00.695319728, dts 99:99:99.999999999, dur 0:00:00.046439909, > size 8192, offset none, offset_end none, flags 0x0 > 0:00:00.199601593 728640 0x5624e1f1ac60 DEBUG GST_SCHEDULING > gstpad.c:4459:gst_pad_chain_data_unchecked:<fakesink0:sink> calling > chainfunction &gst_base_sink_chain with buffer buffer: 0x7f9acc047a20, > pts 0:00:00.741759637, dts 99:99:99.999999999, dur 0:00:00.046439909, > size 8192, offset none, offset_end none, flags 0x0 > 0:00:00.199932884 728640 0x5624e1f1ac60 DEBUG GST_SCHEDULING > gstpad.c:4459:gst_pad_chain_data_unchecked:<fakesink0:sink> calling > chainfunction &gst_base_sink_chain with buffer buffer: 0x7f9acc04b480, > pts 0:00:00.788199546, dts 99:99:99.999999999, dur 0:00:00.046439910, > size 8192, offset none, offset_end none, flags 0x0 > 0:00:00.200119034 728640 0x5624e1f1ac60 DEBUG GST_SCHEDULING > gstpad.c:4459:gst_pad_chain_data_unchecked:<avdec_wmalossless0:sink> > calling chainfunction &gst_audio_decoder_chain with buffer buffer: > 0x5624e1f65d80, pts 0:00:01.021000000, dts 99:99:99.999999999, dur > 0:00:00.098890300, size 13375, offset none, offset_end none, flags 0x6000 > 0:00:00.200418822 728640 0x5624e1f1ac60 DEBUG GST_SCHEDULING > gstpad.c:4459:gst_pad_chain_data_unchecked:<fakesink0:sink> calling > chainfunction &gst_base_sink_chain with buffer buffer: 0x7f9acc04b5a0, > pts 0:00:00.835000000, dts 99:99:99.999999999, dur 0:00:00.046439909, > size 8192, offset none, offset_end none, flags 0x0 > 0:00:00.200751757 728640 0x5624e1f1ac60 DEBUG GST_SCHEDULING > gstpad.c:4459:gst_pad_chain_data_unchecked:<fakesink0:sink> calling > chainfunction &gst_base_sink_chain with buffer buffer: 0x5624e1f657e0, > pts 0:00:00.881439909, dts 99:99:99.999999999, dur 0:00:00.046439910, > size 8192, offset none, offset_end none, flags 0x0 > 0:00:00.201090412 728640 0x5624e1f1ac60 DEBUG GST_SCHEDULING > gstpad.c:4459:gst_pad_chain_data_unchecked:<fakesink0:sink> calling > chainfunction &gst_base_sink_chain with buffer buffer: 0x7f9acc04b480, > pts 0:00:00.927879819, dts 99:99:99.999999999, dur 0:00:00.046439909, > size 8192, offset none, offset_end none, flags 0x0 > 0:00:00.201417297 728640 0x5624e1f1ac60 DEBUG GST_SCHEDULING > gstpad.c:4459:gst_pad_chain_data_unchecked:<fakesink0:sink> calling > chainfunction &gst_base_sink_chain with buffer buffer: 0x7f9acc04ba20, > pts 0:00:00.974319728, dts 99:99:99.999999999, dur 0:00:00.046439909, > size 8192, offset none, offset_end none, flags 0x0 > 0:00:00.201568535 728640 0x5624e1f1ac60 DEBUG GST_SCHEDULING > gstpad.c:4459:gst_pad_chain_data_unchecked:<avdec_wmalossless0:sink> > calling chainfunction &gst_audio_decoder_chain with buffer buffer: > 0x7f9acc01e000, pts 0:00:01.114000000, dts 99:99:99.999999999, dur > 0:00:00.098890300, size 13375, offset none, offset_end none, flags 0x6000 > 0:00:00.201861384 728640 0x5624e1f1ac60 DEBUG GST_SCHEDULING > gstpad.c:4459:gst_pad_chain_data_unchecked:<fakesink0:sink> calling > chainfunction &gst_base_sink_chain with buffer buffer: 0x5624e1f65b40, > pts 0:00:01.021000000, dts 99:99:99.999999999, dur 0:00:00.046439909, > size 8192, offset none, offset_end none, flags 0x0 > 0:00:00.202197868 728640 0x5624e1f1ac60 DEBUG GST_SCHEDULING > gstpad.c:4459:gst_pad_chain_data_unchecked:<fakesink0:sink> calling > chainfunction &gst_base_sink_chain with buffer buffer: 0x7f9acc04b480, > pts 0:00:01.067439909, dts 99:99:99.999999999, dur 0:00:00.046439910, > size 8192, offset none, offset_end none, flags 0x0 > 0:00:00.202367224 728640 0x5624e1f1ac60 DEBUG GST_SCHEDULING > gstpad.c:4459:gst_pad_chain_data_unchecked:<avdec_wmalossless0:sink> > calling chainfunction &gst_audio_decoder_chain with buffer buffer: > 0x5624e1f65c60, pts 0:00:01.253000000, dts 99:99:99.999999999, dur > 0:00:00.098890300, size 13375, offset none, offset_end none, flags 0x6000 > 0:00:00.202662103 728640 0x5624e1f1ac60 DEBUG GST_SCHEDULING > gstpad.c:4459:gst_pad_chain_data_unchecked:<fakesink0:sink> calling > chainfunction &gst_base_sink_chain with buffer buffer: 0x7f9acc05ec60, > pts 0:00:01.114000000, dts 99:99:99.999999999, dur 0:00:00.046439909, > size 8192, offset none, offset_end none, flags 0x0 > 0:00:00.202997006 728640 0x5624e1f1ac60 DEBUG GST_SCHEDULING > gstpad.c:4459:gst_pad_chain_data_unchecked:<fakesink0:sink> calling > chainfunction &gst_base_sink_chain with buffer buffer: 0x5624e1f65d80, > pts 0:00:01.160439909, dts 99:99:99.999999999, dur 0:00:00.046439910, > size 8192, offset none, offset_end none, flags 0x0 > 0:00:00.203349696 728640 0x5624e1f1ac60 DEBUG GST_SCHEDULING > gstpad.c:4459:gst_pad_chain_data_unchecked:<fakesink0:sink> calling > chainfunction &gst_base_sink_chain with buffer buffer: 0x7f9acc04b900, > pts 0:00:01.206879819, dts 99:99:99.999999999, dur 0:00:00.046439909, > size 8192, offset none, offset_end none, flags 0x0 > 0:00:00.203502291 728640 0x5624e1f1ac60 DEBUG GST_SCHEDULING > gstpad.c:4459:gst_pad_chain_data_unchecked:<avdec_wmalossless0:sink> > calling chainfunction &gst_audio_decoder_chain with buffer buffer: > 0x5624e1f65ea0, pts 0:00:01.346000000, dts 99:99:99.999999999, dur > 0:00:00.098890300, size 13375, offset none, offset_end none, flags 0x6000 > 0:00:00.203799351 728640 0x5624e1f1ac60 DEBUG GST_SCHEDULING > gstpad.c:4459:gst_pad_chain_data_unchecked:<fakesink0:sink> calling > chainfunction &gst_base_sink_chain with buffer buffer: 0x7f9acc095480, > pts 0:00:01.253000000, dts 99:99:99.999999999, dur 0:00:00.046439909, > size 8192, offset none, offset_end none, flags 0x0 > 0:00:00.204133982 728640 0x5624e1f1ac60 DEBUG GST_SCHEDULING > gstpad.c:4459:gst_pad_chain_data_unchecked:<fakesink0:sink> calling > chainfunction &gst_base_sink_chain with buffer buffer: 0x7f9acc01e000, > pts 0:00:01.299439909, dts 99:99:99.999999999, dur 0:00:00.046439910, > size 8192, offset none, offset_end none, flags 0x0 > 0:00:00.204285788 728640 0x5624e1f1ac60 DEBUG GST_SCHEDULING > gstpad.c:4459:gst_pad_chain_data_unchecked:<avdec_wmalossless0:sink> > calling chainfunction &gst_audio_decoder_chain with buffer buffer: > 0x7f9acc01e120, pts 0:00:01.439000000, dts 99:99:99.999999999, dur > 0:00:00.098890300, size 13375, offset none, offset_end none, flags 0x6000 > 0:00:00.204578298 728640 0x5624e1f1ac60 DEBUG GST_SCHEDULING > gstpad.c:4459:gst_pad_chain_data_unchecked:<fakesink0:sink> calling > chainfunction &gst_base_sink_chain with buffer buffer: 0x7f9acc095900, > pts 0:00:01.346000000, dts 99:99:99.999999999, dur 0:00:00.046439909, > size 8192, offset none, offset_end none, flags 0x0 > 0:00:00.204912776 728640 0x5624e1f1ac60 DEBUG GST_SCHEDULING > gstpad.c:4459:gst_pad_chain_data_unchecked:<fakesink0:sink> calling > chainfunction &gst_base_sink_chain with buffer buffer: 0x7f9acc0957e0, > pts 0:00:01.392439909, dts 99:99:99.999999999, dur 0:00:00.046439910, > size 8192, offset none, offset_end none, flags 0x0 > 0:00:00.205047225 728640 0x5624e1f1ac60 DEBUG GST_SCHEDULING > gstpad.c:4459:gst_pad_chain_data_unchecked:<avdec_wmalossless0:sink> > calling chainfunction &gst_audio_decoder_chain with buffer buffer: > 0x7f9acc01e360, pts 0:00:01.532000000, dts 99:99:99.999999999, dur > 0:00:00.098890300, size 13375, offset none, offset_end none, flags 0x6000 > 0:00:00.205334301 728640 0x5624e1f1ac60 DEBUG GST_SCHEDULING > gstpad.c:4459:gst_pad_chain_data_unchecked:<fakesink0:sink> calling > chainfunction &gst_base_sink_chain with buffer buffer: 0x7f9acc095b40, > pts 0:00:01.439000000, dts 99:99:99.999999999, dur 0:00:00.046439909, > size 8192, offset none, offset_end none, flags 0x0 > 0:00:00.205668675 728640 0x5624e1f1ac60 DEBUG GST_SCHEDULING > gstpad.c:4459:gst_pad_chain_data_unchecked:<fakesink0:sink> calling > chainfunction &gst_base_sink_chain with buffer buffer: 0x5624e1f65ea0, > pts 0:00:01.485439909, dts 99:99:99.999999999, dur 0:00:00.046439910, > size 8192, offset none, offset_end none, flags 0x0 > 0:00:00.205818365 728640 0x5624e1f1ac60 DEBUG GST_SCHEDULING > gstpad.c:4459:gst_pad_chain_data_unchecked:<avdec_wmalossless0:sink> > calling chainfunction &gst_audio_decoder_chain with buffer buffer: > 0x7f9acc01e5a0, pts 0:00:01.625000000, dts 99:99:99.999999999, dur > 0:00:00.098890300, size 13375, offset none, offset_end none, flags 0x6000 > 0:00:00.206114719 728640 0x5624e1f1ac60 DEBUG GST_SCHEDULING > gstpad.c:4459:gst_pad_chain_data_unchecked:<fakesink0:sink> calling > chainfunction &gst_base_sink_chain with buffer buffer: 0x7f9acc01e120, > pts 0:00:01.532000000, dts 99:99:99.999999999, dur 0:00:00.046439909, > size 8192, offset none, offset_end none, flags 0x0 > 0:00:00.206457771 728640 0x5624e1f1ac60 DEBUG GST_SCHEDULING > gstpad.c:4459:gst_pad_chain_data_unchecked:<fakesink0:sink> calling > chainfunction &gst_base_sink_chain with buffer buffer: 0x7f9acc095b40, > pts 0:00:01.578439909, dts 99:99:99.999999999, dur 0:00:00.046439910, > size 8192, offset none, offset_end none, flags 0x0 > 0:00:00.206625265 728640 0x5624e1f1ac60 DEBUG GST_SCHEDULING > gstpad.c:4459:gst_pad_chain_data_unchecked:<avdec_wmalossless0:sink> > calling chainfunction &gst_audio_decoder_chain with buffer buffer: > 0x7f9acc01e240, pts 0:00:01.764000000, dts 99:99:99.999999999, dur > 0:00:00.098890300, size 13375, offset none, offset_end none, flags 0x6000 > 0:00:00.206919459 728640 0x5624e1f1ac60 DEBUG GST_SCHEDULING > gstpad.c:4459:gst_pad_chain_data_unchecked:<fakesink0:sink> calling > chainfunction &gst_base_sink_chain with buffer buffer: 0x7f9acc0b0360, > pts 0:00:01.625000000, dts 99:99:99.999999999, dur 0:00:00.046439909, > size 8192, offset none, offset_end none, flags 0x0 > 0:00:00.207261515 728640 0x5624e1f1ac60 DEBUG GST_SCHEDULING > gstpad.c:4459:gst_pad_chain_data_unchecked:<fakesink0:sink> calling > chainfunction &gst_base_sink_chain with buffer buffer: 0x7f9acc01e360, > pts 0:00:01.671439909, dts 99:99:99.999999999, dur 0:00:00.046439910, > size 8192, offset none, offset_end none, flags 0x0 > 0:00:00.207606699 728640 0x5624e1f1ac60 DEBUG GST_SCHEDULING > gstpad.c:4459:gst_pad_chain_data_unchecked:<fakesink0:sink> calling > chainfunction &gst_base_sink_chain with buffer buffer: 0x7f9acc095900, > pts 0:00:01.717879819, dts 99:99:99.999999999, dur 0:00:00.046439909, > size 8192, offset none, offset_end none, flags 0x0 > 0:00:00.207756829 728640 0x5624e1f1ac60 DEBUG GST_SCHEDULING > gstpad.c:4459:gst_pad_chain_data_unchecked:<avdec_wmalossless0:sink> > calling chainfunction &gst_audio_decoder_chain with buffer buffer: > 0x7f9acc01e480, pts 0:00:01.857000000, dts 99:99:99.999999999, dur > 0:00:00.098890300, size 13375, offset none, offset_end none, flags 0x6000 > ``` > I can upload the file somewhere if you want, but it's 80MB and not > freely licensed. Is this needed by an application or is it just to pass the tests? In the latter case we can just keep a todo_wine. This flags fixup looks too arbitrary. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4450#note_53091

1 0

Re: [PATCH v3 0/5] MR4450: winegstreamer: WMA DMO support
by Rémi Bernon (＠rbernon) 21 Nov '23

21 Nov '23

On Tue Nov 21 14:16:04 2023 +0000, Alfred Agrell wrote: > Something in mf:transform test_wma_decoder() needs it. > But unless we can find an actual WMA file that does that, better fix it > in the test instead. Fixed. I suspect this is actually related to the tests using WMAUDIO2 (aka WMAudioV8), which, if I believe the headers files, where WMAUDIO_BITS_PER_SAMPLE is used, only supports 16bps. The bps is then automatically set and the media type doesn't need one. Also from the headers, I suspect WMAUDIO3 may support variable bps which maybe would require changes here and in other places where we use a fixed value. All of which may require more tests to be sure. Which probably be added later. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4450#note_53090

1 0

[PATCH 0/7] MR4450: winegstreamer: WMA DMO support
by Alfred Agrell (＠Alcaro) 21 Nov '23

21 Nov '23

Along with !4449, this fixes WMV videos in microkiri (https://bugs.winehq.org/show_bug.cgi?id=9127#c102) and Wagamama High Spec Trial Edition (https://wagahigh.com/download_trial.php#normal ; ダウンロード means download). -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4450

3 23

[PATCH 0/3] MR485: vkd3d-shader/ir: Skip recording combined resource/sampler information for dynamically indexed descriptor arrays.
by Henri Verbeet (＠hverbeet) 21 Nov '23

21 Nov '23

-- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/485

2 4

[PATCH v9 0/4] MR450: vkd3d-shader/ir: Flatten structured control flow instructions.
by Conor McCarthy (＠cmccarthy) 21 Nov '23

21 Nov '23

-- v9: vkd3d-shader/ir: Store code block names in struct vkd3d_shader_desc. vkd3d-shader/ir: Flatten structured control flow instructions. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/450

3 6

[PATCH 0/1] MR4446: msvcp110: Implement std::_Xbad_function_call().
by Paul Gofman (＠gofman) 21 Nov '23

21 Nov '23

It looks like msvcp doesn't export anything for the std::bad_function_call exception construction and if std::bad_function_call is constructed directly from the app the corresponding class data is generated in the application binary. I am attaching an ad-hoc test program I used to test it (using MSVC 2022 community edition). [msvcp_except.cpp](/uploads/558f0911366525d05af4ac69552c4aae/msvcp_except.cpp) -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4446

3 7

[PATCH v5 0/7] MR4377: Reimplement msvcrt env functions to match native.
by eric pouech (＠epo) 21 Nov '23

21 Nov '23

This serie: - adds a couple of msvcrt env tests (mainly env block inheritance) - introduces env tests for ucrtbase - reimplement most of the env related functions to mimic native behavior (basically when env is modified, native crt uses a per-variable entry allocation block (instead of having pointers inside a single chunk of memory). This fixes programs which keep a pointer on returned getenv() string and expect that pointer content is not modified when other variables in env are modified. @piotr: from previous version - I dropped the synchronization of \_environ and \_wenviron hence requiring the duplication of most of the code in ansi/unicode versions - I also tested the changes with unicode crt startup code (you can find in [1] this MR extended with this test code but I don't think we want to push it upstream) - there are some init code changes because of ucrtbase tests and unicode crt startup tests [1] https://gitlab.winehq.org/epo/wine/-/tree/mr-crt-env-full?ref_type=heads -- v5: msvcrt: Fix ucrtbase environment initialization. msvcrt: Allocate environment variables in separate allocation chunks. msvcrt: Lazily initialize ___winitenv. msvcrt: Factor out wenv_get_index helper. msvcrt: Factor out env_get_index helper. ucrtbase/tests: Introduce environment tests. msvcrt/tests: Test passing environment in child process. https://gitlab.winehq.org/wine/wine/-/merge_requests/4377

4 9

[PATCH v3 0/2] MR4357: ntdll/unix: Try harder to initialize locale from Mac setting.
by Jactry Zeng (＠jactry) 21 Nov '23

21 Nov '23

This allows initializing locale from Mac locale identifiers like 'zh-Hans-US'. The current implementation recognizes it as 'zh-US' which isn't a valid locale identifier for Windows. This patch will try again with the 'lang-script' identifier after get_win_locale() fails with the 'lang-region' identifier. -- v3: ntdll/unix: Support to initialize locale from 'lang-script' format language identifier. ntdll/unix: Use different variable names for Mac locales. https://gitlab.winehq.org/wine/wine/-/merge_requests/4357

3 3

[PATCH 0/21] MR4445: ntdll: Unwind the kernel stack on thread exit.
by Alexandre Julliard (＠julliard) 21 Nov '23

21 Nov '23

Based on @rbernon's work in !1088, with additional ARM support and some cleanups. -- This merge request has too many patches to be relayed via email. Please visit the URL below to see the contents of the merge request. https://gitlab.winehq.org/wine/wine/-/merge_requests/4445

2 5

[PATCH 0/1] MR4453: wbemprox: Add StandardCimv2 namespace.
by Louis Lenders (＠xe) 21 Nov '23

21 Nov '23

I tested a program a user was asking about on the forum (https://forum.winehq.org/viewtopic.php?t=38192). The program (or in fact a file called Unity.Licensing.Client.exe) looks for namespace "root\\StandardCimv2" After adding this patch following query is done: 0024:trace:wbemprox:wbem_services_ExecQuery 00007FFB582B6660, L"WQL", L"SELECT Name,InterfaceDescription,PermanentAddress,NetworkAddresses,PNPDeviceID FROM MSFT_NetAdapter", 0x20, 0000000000000000, 00007FFFFE27DCD8 I don't know exactly what the problem is that user is experiencing, I can only tell that I'm not able to login. I provided some dummy values for the requested properties from the MSFT_NetAdapter class but that didn't help. For now I think adding the MSFT_NetAdapter class is not yet worth the trouble, but with this patch it is at least visible for what class the program is looking for. The program can be found at https://unity3d.atlassian.net/wiki/spaces/AR/pages/1571848193/New+in+ArtEng… -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4453

3 2

[PATCH 0/1] MR4437: d3dcompiler_43: Use CRT allocation functions.
by Alex Henrie (＠alexhenrie) 21 Nov '23

21 Nov '23

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/4437

3 3

2025

2024

2023

2022

wine-gitlab