- wine-gitlab - winehq.org

[PATCH v2 0/2] MR4404: Fix bug with GetStrCodePages when passing a string that contains a character with different codepages.
by Santino Mazza (＠tati1454) 15 Nov '23

15 Nov '23

-- v2: mlang: Fix GetStrCodePages for characters with different codepages. mlang/tests: Test GetStrCodePages with different codepages character. https://gitlab.winehq.org/wine/wine/-/merge_requests/4404

2 2

[PATCH v4 0/9] MR458: vkd3d-shader/hlsl: Handle register(cX) reservations.
by Francisco Casas (＠fcasas) 15 Nov '23

15 Nov '23

Currently we are not properly handling register(cX) reservations for SM1, this is one of the things required for the SNK shaders (CW Bug Bug 18092). register(cX) reservations also change the offset in the $Globals buffer in SM4, so support for this is also included. --- Patch 1/4 is required to specify: ``` [require] shader model < 4.0 ``` so that the tests that follow do not get run with the vulkan backend on SM4. I think nobody disagreed with that patch. -- v4: vkd3d-shader/hlsl: Turn register(cX) reservations into buffer offset for SM4. vkd3d-shader/hlsl: Make register(cX) reservations work for SM1. tests: Test register(cX) reservations. tests: Rename register-reservations.shader_test to register-reservations-resources.shader_test. tests/vkd3d-shader: Allow passing (sm<4) and (sm>=4) to "fail" and "todo" qualifiers. tests/shader-runner: Discern between the minimum_shader_model and the selected_shader_model. tests/shader-runner: Add missing requirement checks for backends. ci: Execute the shader runner on the correct test data on Windows. ci: Deduplicate the CI configuration for Windows. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/458

3 12

[PATCH 0/2] MR4404: Fix bug with GetStrCodePages when passing a string that contains a character with different codepages.
by Santino Mazza (＠tati1454) 15 Nov '23

15 Nov '23

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/4404

2 2

[PATCH v2 0/1] MR472: vkd3d-shader: Add a helper to check for a numeric type.
by Nikolay Sivov (＠nsivov) 15 Nov '23

15 Nov '23

-- v2: vkd3d-shader/hlsl: Add a helper to check for a numeric type. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/472

4 4

Re: [PATCH v9 0/6] MR461: vkd3d: Implement ID3D12Device2::CreatePipelineState(). - approved
by Henri Verbeet (＠hverbeet) 15 Nov '23

15 Nov '23

This merge request was approved by Henri Verbeet. -- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/461

1 0

[PATCH v13 0/6] MR459: vkd3d-shader/dxil: Implement the DXIL VSELECT instruction.
by Conor McCarthy (＠cmccarthy) 15 Nov '23

15 Nov '23

-- v13: vkd3d-shader/spirv: Avoid invalid bool-to-bool conversion in spirv_compiler_emit_movc(). vkd3d-shader/dxil: Implement the DXIL VSELECT instruction. tests/shader-runner: Add tests for 64-bit casts. vkd3d-shader/spirv: Return an error if an invalid handler is encountered. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/459

3 7

[PATCH v3 0/5] MR4375: dmsynth: Various fixes 2
by Anton Baskanov (＠baskanov) 15 Nov '23

15 Nov '23

-- v3: dmsynth: Use FLUID_MOD_KEY for CONN_SRC_KEYNUMBER. dmsynth: Fall back to the Standard drum set when there is no matching instrument or region. dmsynth: Factor out instrument and region search. dmsynth: Get rid of instrument reference counting. dmsynth: Move instrument search to synth_preset_noteon(). https://gitlab.winehq.org/wine/wine/-/merge_requests/4375

4 10

[PATCH 0/2] MR4402: msvcrt: Add implementation of more localized functions
by Bartosz Kosiorek (＠gang65) 15 Nov '23

15 Nov '23

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/4402

3 4

[PATCH v3 0/1] MR4393: gdiplus: Boost performance of GdipDrawImagePointsRect.
by Bartosz Kosiorek (＠gang65) 15 Nov '23

15 Nov '23

By not using floorf from external library ucrtbase.dll the performance of GdipDrawImagePointsRect was improved. Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=53947 After applying patch the game performance is similar to native gdiplus.dll. Result of oprofile before patch: ``` samples % image name app name symbol name 895705 33.4761 ucrtbase.dll.so wine floor 351683 13.1438 no-vmlinux wine /no-vmlinux 330995 12.3706 gdiplus.dll.so wine resample_bitmap_pixel 300093 11.2157 win32u.so wine blend_rects_8888 272645 10.1898 gdiplus.dll.so wine GdipDrawImagePointsRect 137421 5.1360 gdiplus.dll.so wine sample_bitmap_pixel 112476 4.2037 gdiplus.dll.so wine convert_32bppARGB_to_32bppPARGB 35455 1.3251 no-vmlinux wineserver /no-vmlinux 35223 1.3164 no-vmlinux wine64-preloader /no-vmlinux 30252 1.1306 libc.so.6 wine /usr/lib/i386-linux-gnu/libc.so.6 ``` and after patch: ``` samples % image name app name symbol name 248581 18.3279 no-vmlinux wine /no-vmlinux 200141 14.7564 gdiplus.dll.so wine resample_bitmap_pixel 199840 14.7342 win32u.so wine blend_rects_8888 179135 13.2076 gdiplus.dll.so wine GdipDrawImagePointsRect 105785 7.7995 no-vmlinux wine-preloader /no-vmlinux 89534 6.6013 gdiplus.dll.so wine sample_bitmap_pixel 83947 6.1894 no-vmlinux wine64-preloader /no-vmlinux 74132 5.4658 gdiplus.dll.so wine convert_32bppARGB_to_32bppPARGB 22978 1.6942 anon (tgid:374066 range:0x7bc10000-0x7bffffff) wine anon (tgid:374066 range:0x7bc10000-0x7bffffff) 19747 1.4559 libc.so.6 wine /usr/lib/i386-linux-gnu/libc.so.6 14570 1.0742 win32u.so wine solid_rects_32 ``` Can we stop using floorf and ceilf from `math.h`? -- v3: gdiplus: Boost performance of GdipDrawImagePointsRect. https://gitlab.winehq.org/wine/wine/-/merge_requests/4393

3 4

[PATCH v2 0/1] MR4401: include: Don't use dllexport attribute for PE modules.
by Jacek Caban (＠jacek) 15 Nov '23

15 Nov '23

Recent change to make unixlibs use hidden visibility made DECLSPEC_EXPORT being used in more cases. This means that it's used for PE modules as well, which is meant to be ignored since we use .spec files and winebuild-generated .edata anyway. This has some side effects: - LLD correctly ignores dllexport when it detects .edata presence, but it also issues a warning: `lld-link: warning: literal .edata sections override exports` - AFAIR (I didn't verify), GNU LD would still generate its own .edata entries, but the one provided by winebuild will be actually used by PE header - non-mingw builds will use default visibility for those symbols in PE modules -- v2: include: Don't use dllexport attribute for Wine PE modules. https://gitlab.winehq.org/wine/wine/-/merge_requests/4401

2 2

[PATCH 0/2] MR4383: Misc janitorings
by Michael Stefaniuc (＠mstefani) 15 Nov '23

15 Nov '23

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/4383

3 3

[PATCH 0/1] MR4403: winebus.sys: Fix incorrect hid_device_set index check.
by Rémi Bernon (＠rbernon) 15 Nov '23

15 Nov '23

Instead of checking it in set_report_from_joystick_event. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4403

2 1

[PATCH 0/2] MR4401: include: Don't use dllexport attribute for PE modules.
by Jacek Caban (＠jacek) 15 Nov '23

15 Nov '23

Recent change to make unixlibs use hidden visibility made DECLSPEC_EXPORT being used in more cases. This means that it's used for PE modules as well, which is meant to be ignored since we use .spec files and winebuild-generated .edata anyway. This has some side effects: - LLD correctly ignores dllexport when it detects .edata presence, but it also issues a warning: `lld-link: warning: literal .edata sections override exports` - AFAIR (I didn't verify), GNU LD would still generate its own .edata entries, but the one provided by winebuild will be actually used by PE header - non-mingw builds will use default visibility for those symbols in PE modules -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4401

3 3

[PATCH v4 0/12] MR471: Draft: vkd3d-shader/dxil: Implement the DXIL GEP and LOAD instructions.
by Conor McCarthy (＠cmccarthy) 15 Nov '23

15 Nov '23

Goes atop !459. The last five commits belong to this MR. -- v4: vkd3d-shader/dxil: Implement the DXIL LOAD instruction. vkd3d-shader/dxil: Implement the DXIL GEP instruction. vkd3d-shader/dxil: Support global variable initialisers. vkd3d-shader/dxil: Introduce a value type for immediate constant buffers. vkd3d-shader/dxil: Implement default address space global variables. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/471

2 12

[PATCH v2 0/1] MR4392: server: Don't crash when opening null path with a console handle as RootDirectory.
by Jinoh Kang (＠iamahuman) 15 Nov '23

15 Nov '23

Preparatory patch for revival of https://gitlab.winehq.org/wine/wine/-/merge_requests/498. -- v2: server: Don't crash when opening null path with a console handle as RootDirectory. https://gitlab.winehq.org/wine/wine/-/merge_requests/4392

2 1

[PATCH v8 0/6] MR461: vkd3d: Implement ID3D12Device2::CreatePipelineState().
by Conor McCarthy (＠cmccarthy) 15 Nov '23

15 Nov '23

-- v8: vkd3d: Support depth bounds test. tests: Test CreatePipelineState(). vkd3d: Implement ID3D12Device2::CreatePipelineState(). https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/461

4 9

[PATCH 0/1] MR4400: wldp: Improve the WldpGetLockdownPolicy() stub.
by Hans Leidekker (＠hans) 15 Nov '23

15 Nov '23

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/4400

2 1

[PATCH v15 0/3] MR474: Draft: Test running the shader runner on the correct test data on Windows.
by Giovanni Mascellani (＠giomasce) 15 Nov '23

15 Nov '23

So far this MR is just for experimentation, do not review it. -- v15: ci: Execute the shader runner on the correct test data on Windows. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/474

2 3

[PATCH v13 0/3] MR474: Draft: Test running the shader runner on the correct test data on Windows.
by Giovanni Mascellani (＠giomasce) 15 Nov '23

15 Nov '23

So far this MR is just for experimentation, do not review it. -- v13: ci: Execute the shader runner on the correct test data on Windows. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/474

2 3

[PATCH v11 0/3] MR474: Draft: Test running the shader runner on the correct test data on Windows.
by Giovanni Mascellani (＠giomasce) 15 Nov '23

15 Nov '23

So far this MR is just for experimentation, do not review it. -- v11: ci: Execute the shader runner on the correct test data on Windows. ci: Deduplicate the CI configuration for Windows. Test. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/474

2 3

[PATCH v10 0/2] MR474: Draft: Test running the shader runner on the correct test data on Windows.
by Giovanni Mascellani (＠giomasce) 15 Nov '23

15 Nov '23

So far this MR is just for experimentation, do not review it. -- v10: Test. Test. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/474

2 2

[PATCH v2 0/1] MR4373: user32: Add stubs for GetWindowDpiHostingBehavior and SetThreadDpiHostingBehavior
by Paweł Ulita (＠pawelulita) 15 Nov '23

15 Nov '23

Recent versions of Native Instruments Kontakt 7 introduced some additional HiDPI features. To do this, Kontakt calls 2 functions in `user32.dll` that Wine hasn't implemented yet: `GetWindowDpiHostingBehavior` and `SetThreadDpiHostingBehavior`. This patch adds stubs for these 2 functions and apparently that's enough for Kontakt. This is my first contribution to Wine, I'm not 100% sure if everything is like it should be. -- v2: user32: Add stubs for GetWindowDpiHostingBehavior and SetThreadDpiHostingBehavior https://gitlab.winehq.org/wine/wine/-/merge_requests/4373

3 4

[PATCH v9 0/3] MR474: Draft: Test running the shader runner on the correct test data on Windows.
by Giovanni Mascellani (＠giomasce) 15 Nov '23

15 Nov '23

So far this MR is just for experimentation, do not review it. -- v9: Test. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/474

2 3

[PATCH v8 0/3] MR474: Draft: Test running the shader runner on the correct test data on Windows.
by Giovanni Mascellani (＠giomasce) 15 Nov '23

15 Nov '23

So far this MR is just for experimentation, do not review it. -- v8: Test. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/474

2 3

[PATCH v7 0/3] MR474: Draft: Test running the shader runner on the correct test data on Windows.
by Giovanni Mascellani (＠giomasce) 15 Nov '23

15 Nov '23

So far this MR is just for experimentation, do not review it. -- v7: Test. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/474

2 3

[PATCH v6 0/3] MR474: Draft: Test running the shader runner on the correct test data on Windows.
by Giovanni Mascellani (＠giomasce) 15 Nov '23

15 Nov '23

So far this MR is just for experimentation, do not review it. -- v6: Test. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/474

2 3

[PATCH v5 0/3] MR474: Draft: Test running the shader runner on the correct test data on Windows.
by Giovanni Mascellani (＠giomasce) 15 Nov '23

15 Nov '23

So far this MR is just for experimentation, do not review it. -- v5: Test. Second. First. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/474

2 3

[PATCH v3 0/1] MR474: Draft: Test running the shader runner on the correct test data on Windows.
by Giovanni Mascellani (＠giomasce) 15 Nov '23

15 Nov '23

So far this MR is just for experimentation, do not review it. -- v3: Test. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/474

2 1

[PATCH 0/1] MR4391: mshtml: Fix misleading-indentation warning.
by Bartosz Kosiorek (＠gang65) 15 Nov '23

15 Nov '23

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/4391

4 4

Re: [PATCH v3 0/7] MR3909: winewayland.drv: part 7: Basic window management
by darkblaze69 (＠darkblaze69) 15 Nov '23

15 Nov '23

Hi, another bug: https://bugs.winehq.org/show_bug.cgi?id=55902 GNOME, cannot resize a window by touchpad double-tap -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3909#note_52338

1 0

[PATCH 0/1] MR4397: msvcp140: Add codecvt<char32> class stub.
by Jactry Zeng (＠jactry) 15 Nov '23

15 Nov '23

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=47609 -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4397

2 1

Re: [PATCH v3 0/12] MR471: Draft: vkd3d-shader/dxil: Implement the DXIL GEP and LOAD instructions.
by Conor McCarthy (＠cmccarthy) 15 Nov '23

15 Nov '23

On Wed Nov 15 06:54:38 2023 +0000, Henri Verbeet wrote: > > This needs spirv changes to make any tests pass, but this series is > already long enough. Not sure what to do about initialisers; we can't > use `DCL_IMMEDIATE_CONSTANT_BUFFER` because it emits a variable, > Is the issue purely that the shader may write to the variable, or are > there other reasons that can't work? If what we want is essentially a > writeable icb, we could perhaps consider adding a "data[]" field to the > vkd3d_shader_indexable_temp structure, analogous to struct vkd3d_shader_immediate_constant_buffer. What it really needed was a new value type to hold ICBs. Storing an ICB in the indexable temp declaration works well now. Constant arrays should be declared with `DCL_IMMEDIATE_CONSTANT_BUFFER`, but that must wait for the next MR. It's not broken, just ignores the constant attribute. -- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/471#note_52336

1 0

Re: [PATCH v3 0/1] MR4343: setupapi: Add stub for DriverStoreFindDriverPackageW
by Alex Henrie (＠alexhenrie) 15 Nov '23

15 Nov '23

Alex Henrie (@alexhenrie) commented about dlls/setupapi/tests/query.c: > + WCHAR buffer[500]; > + DWORD len; > + HRESULT (WINAPI *pDriverStoreFindDriverPackageW)(const WCHAR*, void*, void*, DWORD, void*, WCHAR*, DWORD*); > + > + library = LoadLibraryA("setupapi.dll"); > + ok(library != NULL, "Failed to load setupapi.dll\n"); > + if (!library) return; > + > + pDriverStoreFindDriverPackageW = (void *)GetProcAddress(library, "DriverStoreFindDriverPackageW"); > + if (!pDriverStoreFindDriverPackageW) > + { > + win_skip("Can't find DriverStoreFindDriverPackageW\n"); > + return; > + } > + > + len = 500; Rather than initializing len with a magic number here, it would be more clear declare the variable as `DWORD len = ARRAY_SIZE(buffer)` to begin with. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4343#note_52331

1 0

Re: [PATCH v3 0/1] MR4343: setupapi: Add stub for DriverStoreFindDriverPackageW
by Alex Henrie (＠alexhenrie) 15 Nov '23

15 Nov '23

Alex Henrie (@alexhenrie) commented about dlls/setupapi/tests/query.c: > + ok(result == HRESULT_FROM_WIN32(ERROR_FILE_NOT_FOUND), "Got %lx\n", result); > + else > + todo_wine > + ok(result == E_INVALIDARG, "Got %lx\n", result); /* Win64 needs flags 0x9, or it gives invalid parameter */ > + > + /* Invalid parameter tests */ > + > + result = pDriverStoreFindDriverPackageW(L"c:\\nonexistant.inf", 0, 0, 9, 0, 0, &len); > + ok(result == E_INVALIDARG, "Got %lx\n", result); > + > + result = pDriverStoreFindDriverPackageW(0, 0, 0, 9, 0, buffer, &len); > + ok(result == E_INVALIDARG, "Got %lx\n", result); > + > + result = pDriverStoreFindDriverPackageW(L"", 0, 0, 9, 0, buffer, &len); > + todo_wine > + ok(result == 0x8007007b || result == E_INVALIDARG, "Got %lx\n", result); /* Win7 and Win10 have different results */ 0x8007007b is HRESULT_FROM_WIN32(ERROR_INVALID_NAME). Let's use the macro instead of a magic number, assume that ERROR_INVALID_NAME is broken behavior, and make Wine return E_INVALIDARG in this situation. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4343#note_52330

1 0

[PATCH 0/2] MR4388: user32: Return DEFAULT_CHARSET from SPI_GETICONTITLELOGFONT and SPI_GETNONCLIENTMETRICS.
by Dmitry Timoshkov (＠dmitry) 15 Nov '23

15 Nov '23

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/4388

3 3

[PATCH v10 0/1] MR4372: kernel32: impl sync barrier
by quininer (＠quininer) 15 Nov '23

15 Nov '23

This is my first time contributing wine and there are a lot of things I'm not sure about, so any comments are welcome. :) -- v10: kernel32: impl sync barrier https://gitlab.winehq.org/wine/wine/-/merge_requests/4372

4 4

[PATCH v8 0/1] MR4372: kernel32: impl sync barrier
by quininer (＠quininer) 15 Nov '23

15 Nov '23

This is my first time contributing wine and there are a lot of things I'm not sure about, so any comments are welcome. :) -- v8: kernel32: impl sync barrier https://gitlab.winehq.org/wine/wine/-/merge_requests/4372

4 9

[PATCH v7 0/6] MR461: vkd3d: Implement ID3D12Device2::CreatePipelineState().
by Conor McCarthy (＠cmccarthy) 15 Nov '23

15 Nov '23

-- v7: vkd3d: Support depth bounds test. tests: Test CreatePipelineState(). vkd3d: Implement ID3D12Device2::CreatePipelineState(). https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/461

2 6

[PATCH v12 0/6] MR459: vkd3d-shader/dxil: Implement the DXIL VSELECT instruction.
by Conor McCarthy (＠cmccarthy) 15 Nov '23

15 Nov '23

-- v12: vkd3d-shader/spirv: Avoid invalid bool-to-bool conversion in spirv_compiler_emit_movc(). vkd3d-shader/dxil: Implement the DXIL VSELECT instruction. tests/shader-runner: Add tests for 64-bit casts. vkd3d-shader/spirv: Return an error if an invalid handler is encountered. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/459

2 7

[PATCH v2 0/1] MR4393: gdiplus: Boost performance of GdipDrawImagePointsRect.
by Bartosz Kosiorek (＠gang65) 15 Nov '23

15 Nov '23

By not using floorf from external library ucrtbase.dll the performance of GdipDrawImagePointsRect was improved. Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=53947 After applying patch the game performance is similar to native gdiplus.dll. Result of oprofile before patch: ``` samples % image name app name symbol name 895705 33.4761 ucrtbase.dll.so wine floor 351683 13.1438 no-vmlinux wine /no-vmlinux 330995 12.3706 gdiplus.dll.so wine resample_bitmap_pixel 300093 11.2157 win32u.so wine blend_rects_8888 272645 10.1898 gdiplus.dll.so wine GdipDrawImagePointsRect 137421 5.1360 gdiplus.dll.so wine sample_bitmap_pixel 112476 4.2037 gdiplus.dll.so wine convert_32bppARGB_to_32bppPARGB 35455 1.3251 no-vmlinux wineserver /no-vmlinux 35223 1.3164 no-vmlinux wine64-preloader /no-vmlinux 30252 1.1306 libc.so.6 wine /usr/lib/i386-linux-gnu/libc.so.6 ``` and after patch: ``` samples % image name app name symbol name 248581 18.3279 no-vmlinux wine /no-vmlinux 200141 14.7564 gdiplus.dll.so wine resample_bitmap_pixel 199840 14.7342 win32u.so wine blend_rects_8888 179135 13.2076 gdiplus.dll.so wine GdipDrawImagePointsRect 105785 7.7995 no-vmlinux wine-preloader /no-vmlinux 89534 6.6013 gdiplus.dll.so wine sample_bitmap_pixel 83947 6.1894 no-vmlinux wine64-preloader /no-vmlinux 74132 5.4658 gdiplus.dll.so wine convert_32bppARGB_to_32bppPARGB 22978 1.6942 anon (tgid:374066 range:0x7bc10000-0x7bffffff) wine anon (tgid:374066 range:0x7bc10000-0x7bffffff) 19747 1.4559 libc.so.6 wine /usr/lib/i386-linux-gnu/libc.so.6 14570 1.0742 win32u.so wine solid_rects_32 ``` Can we stop using floorf and ceilf from `math.h`? -- v2: gdiplus: Boost performance of GdipDrawImagePointsRect. https://gitlab.winehq.org/wine/wine/-/merge_requests/4393

4 6

Re: [PATCH v2 0/3] MR4385: Msxml add get xml - approved
by Alexandre Julliard (＠julliard) 14 Nov '23

14 Nov '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4385

1 0

Re: [PATCH v5 0/5] MR4203: winewayland.drv: part 9: Improved HiDPI support - approved
by Alexandre Julliard (＠julliard) 14 Nov '23

14 Nov '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4203

1 0

Re: [PATCH v2 0/1] MR4390: windows.gaming.input: Fix inverted start / select gamepad buttons. - approved
by Alexandre Julliard (＠julliard) 14 Nov '23

14 Nov '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4390

1 0

Re: [PATCH v2 0/1] MR4389: winebus.sys: Ignore events on unsupported axes. - approved
by Alexandre Julliard (＠julliard) 14 Nov '23

14 Nov '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4389

1 0

Re: [PATCH v2 0/2] MR4387: win32u: Misc dpi handling fixes - approved
by Alexandre Julliard (＠julliard) 14 Nov '23

14 Nov '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4387

1 0

Re: [PATCH v3 0/1] MR4350: rpcrt4: Remove DECLSPEC_HIDDEN usage. - approved
by Alexandre Julliard (＠julliard) 14 Nov '23

14 Nov '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4350

1 0

Re: [PATCH v4 0/2] MR4204: winewayland.drv: Basic handling of Wayland keyboard events. - approved
by Alexandre Julliard (＠julliard) 14 Nov '23

14 Nov '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4204

1 0

Re: [PATCH v2 0/5] MR4381: DMusic: Remove superfluous checks / casts - approved
by Alexandre Julliard (＠julliard) 14 Nov '23

14 Nov '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4381

1 0

Re: [PATCH v2 0/1] MR4384: ntdll: Don't use sysconf(_SC_PHYS_PAGES) on macOS. - approved
by Alexandre Julliard (＠julliard) 14 Nov '23

14 Nov '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4384

1 0

Re: [PATCH v2 0/1] MR4367: winmm/tests: Use calloc instead of HeapAlloc. - approved
by Alexandre Julliard (＠julliard) 14 Nov '23

14 Nov '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4367

1 0

Re: [PATCH v2 0/1] MR4368: gdi32/tests: Free what GdiConvertToDevmodeW returns with HeapFree. - approved
by Alexandre Julliard (＠julliard) 14 Nov '23

14 Nov '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4368

1 0

Re: [PATCH v2 0/1] MR470: build: Make doxygen output slightly less verbose. - approved
by Alexandre Julliard (＠julliard) 14 Nov '23

14 Nov '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/470

1 0

Re: [PATCH v3 0/2] MR469: vkd3d-shader/dxil: Handle missing flags as zero. - approved
by Alexandre Julliard (＠julliard) 14 Nov '23

14 Nov '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/469

1 0

[PATCH 0/1] MR4395: d3dx9/effect: Rename effect initialization helper.
by Nikolay Sivov (＠nsivov) 14 Nov '23

14 Nov '23

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/4395

3 2

[PATCH 0/3] MR4385: Msxml add get xml
by Daniel Lehman (＠dlehman25) 14 Nov '23

14 Nov '23

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/4385

3 4

[PATCH v2 0/1] MR4343: setupapi: Add stub for DriverStoreFindDriverPackageW
by Fabian Maurer (＠DarkShadow44) 14 Nov '23

14 Nov '23

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=45455 -- v2: setupapi: Add stub for DriverStoreFindDriverPackageW https://gitlab.winehq.org/wine/wine/-/merge_requests/4343

3 3

[PATCH v3 0/1] MR3410: advpack: Add nullcheck for parameter that can be null (Coverity)
by Fabian Maurer (＠DarkShadow44) 14 Nov '23

14 Nov '23

-- v3: advpack: Add nullchecks for parameters that can be null (Coverity) https://gitlab.winehq.org/wine/wine/-/merge_requests/3410

2 1

[PATCH 0/1] MR4343: setupapi: Add stub for DriverStoreFindDriverPackageW
by Fabian Maurer (＠DarkShadow44) 14 Nov '23

14 Nov '23

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=45455 -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4343

6 11

[PATCH v4 0/5] MR4203: winewayland.drv: part 9: Improved HiDPI support
by Alexandros Frantzis (＠afrantzis) 14 Nov '23

14 Nov '23

This MR improves driver support for scaled HiDPI displays, by respecting the application/window DPI. Since we don't support per-monitor DPI information and awareness modes yet, the user should set the Wine system DPI to match the DPI/scale of the display the app will be running on, for best results. Here is how things look with a few scenarios: 1. Screen scaled at 2x, application at 96dpi (e.g., dpi unaware apps) => the compositor automatically scales the surface: ![wine-wayland-2x-96dpi](/uploads/712bf2e64991889c91861d63dfd4fd60/wine-wayland-2x-96dpi.png) 2. Screen scaled at 2x, application at 192dpi (dpi matches compositor scale) => no compositor scaling: ![wine-wayland-2x-192dpi](/uploads/85c1201e1208f8b7e1c63804c7f83d1c/wine-wayland-2x-192dpi.png) 3. Screen scaled at 1x, application at 96dpi (dpi matches compositor scale) => no compositor scaling: ![wine-wayland-1x-96dpi](/uploads/8dfaaff1fc62defdb26f57c78cf9a427/wine-wayland-1x-96dpi.png) 4. Screen scaled at 1x, application at 192dpi, not typically used, just wanted to show what happens with such a mismatch: ![wine-wayland-1x-192dpi](/uploads/bb035140dd9c91ee3a22832c7280ab1b/wine-wayland-1x-192dpi.png) Thanks! -- v4: winewayland.drv: Ignore spurious size hints. winewayland.drv: Present cursors with the correct scale. winewayland.drv: Refactor cursor code to prepare for scaling support. winewayland.drv: Present surfaces with the correct scale. winewayland.drv: Prepare to handle different coordinate spaces. https://gitlab.winehq.org/wine/wine/-/merge_requests/4203

3 11

[PATCH 0/1] MR4393: gdiplus: Boost performance of GdipDrawImagePointsRect.
by Bartosz Kosiorek (＠gang65) 14 Nov '23

14 Nov '23

By not using floorf from external library ucrtbase.dll the performance of GdipDrawImagePointsRect was improved. Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=53947 -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4393

4 3

[PATCH v3 0/4] MR418: tests/shader-runner: finer control over model ranges and [shader] directive execution for backends, part 1.
by Francisco Casas (＠fcasas) 14 Nov '23

14 Nov '23

First part of a series that allows the shader-runner to test SM1 compilation on [shader] directives even if a backend to run these tests is not available and prepare they way for SM1-only tests. Specifically: - Compile [shader] directives separately from backend execution (on part 1). - Allow specifying more detailed shader ranges for todo(), fail() and notimpl() qualifiers (on part 2). - Always test shader compilation with SM1 profiles (on part 2). The `minimum_shader_model` and `maximum_shader_model` parameters for run_shader_tests() are interpreted in the following way: > Ask the pertaining backend to run the shader_test file so that each test is executed with the lowest profile it can support within the range of shader models specified, if any. This allows us to control how many shader models we want to test for each backend, e.g.: ``` run_shader_tests(..., SHADER_MODEL_2_0, SHADER_MODEL_3_0) run_shader_tests(..., SHADER_MODEL_4_0, SHADER_MODEL_5_1) run_shader_tests(..., SHADER_MODEL_6_0, SHADER_MODEL_6_0) ``` versus ``` for (i = SHADER_MODEL_2_0, i <= SHADER_MODEL_6_0, ++i) run_shader_tests(..., i, i); ``` Also, to allow to compile [shader] directives, which are not backend-specific, separately from the [test] directives, which are, the run_shader_tests() function is modified to skip backend specific directives if the shader_runner_ops is NULL. Following patches are on my [master6i](https://gitlab.winehq.org/fcasas/vkd3d/-/commits/master6i) branch. -- v3: tests/shader-runner: Compile [shader] directives separately from backend execution. tests/shader-runner: Execute runner for many shader model ranges if it supports it. tests/shader-runner: Discern between the minimum_shader_model and the selected_shader_model. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/418

6 16

[PATCH 0/2] MR434: tests/shader-runner: finer control over model ranges and [shader] directive execution, ver 2, part 1.
by Francisco Casas (＠fcasas) 14 Nov '23

14 Nov '23

Basically, @giomasce proposal of specifying shader models for tests individually. Supersedes !418. --- To make the shader_runner expressive enough to handle SM1 and SM6 shader models on tests, we need to intercept the shader model ranges for which we want to run the tests with the ranges that each backend is capable of running, this is complicated. So, to make it more clear, the test's shader models are specified individually, and runner->minimum_shader_model and runner->maximum_shader_model are replaced with just runner->current_shader_model. The supported ranges are removed from the backends (except for d3d12, which handles them internally) and their check_requirements functions is always assumed to exist and return either true or false for just a single shader model. Something that must be kept in mind with these changes is that if two tests with different shader models rely on the same resources, these resources must be either specified twice, or after a [require] directive that includes all the pertaining models. This was necessary for gather.shader_test and gather-offset.shader_test. --- The following patches would change: ``` run_compilation_tests(SHADER_MODEL_4_0, SHADER_MODEL_5_1, NULL); ``` to ``` run_compilation_tests(SHADER_MODEL_2_0, SHADER_MODEL_5_1, NULL); ``` for Unix and non-cross builds, so we can test SM1 compilation even if we don't have a backend available that can actually run the tests. Some improvements to the qualifiers are required before that, to mark sm1 todos properly. Once we have a proper SM1 runner, maybe we could get rid of run_compilation_tests(). -- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/434

3 13

[PATCH 0/1] MR470: build: Make doxygen output slightly less verbose.
by Henri Verbeet (＠hverbeet) 14 Nov '23

14 Nov '23

There is perhaps a bit of a trade-off involved here, but with the current state of things it's fairly hard to notice unexpected issues in the output. -- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/470

3 3

[PATCH v2 0/2] MR469: vkd3d-shader/dxil: Handle missing flags as zero.
by Conor McCarthy (＠cmccarthy) 14 Nov '23

14 Nov '23

-- v2: vkd3d-shader/dxil: Handle missing flags as zero for CMP2. vkd3d-shader/dxil: Handle missing flags as zero for BINOP. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/469

3 3

[PATCH 0/11] MR471: Draft: vkd3d-shader/dxil: Implement the DXIL GEP and LOAD instructions.
by Conor McCarthy (＠cmccarthy) 14 Nov '23

14 Nov '23

Goes atop !459. The last five commits belong to this MR. -- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/471

3 13

[PATCH v6 0/6] MR461: vkd3d: Implement ID3D12Device2::CreatePipelineState().
by Conor McCarthy (＠cmccarthy) 14 Nov '23

14 Nov '23

-- v6: vkd3d: Support depth bounds test. tests: Test CreatePipelineState(). vkd3d: Implement ID3D12Device2::CreatePipelineState(). https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/461

4 8

[PATCH v11 0/6] MR459: vkd3d-shader/dxil: Implement the DXIL VSELECT instruction.
by Conor McCarthy (＠cmccarthy) 14 Nov '23

14 Nov '23

-- v11: vkd3d-shader/spirv: Avoid invalid bool-to-bool conversion in spirv_compiler_emit_movc(). vkd3d-shader/dxil: Implement the DXIL VSELECT instruction. tests/shader-runner: Add tests for 64-bit casts. vkd3d-shader/spirv: Return an error if an invalid handler is encountered. tests/shader-runner: Add a test for float comparisons. tests/shader-runner: Run d3d11 tests with a mimimum shader model of 4.0. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/459

4 11

Re: [PATCH v2 0/1] MR466: vkd3d-shader: Implement scanning combined resource/sampler information.
by Henri Verbeet (＠hverbeet) 14 Nov '23

14 Nov '23

> I'm currently out and haven't had a chance to properly look at this, but, how does this interact with resource arrays? Resource arrays should work as long as they're not dynamically indexed. (And the ps_5_1 test exercises that path.) Dynamic indexing of resource arrays can't work with combined samplers; there's essentially no way to create the required combined samplers in either the OpenGL or Vulkan APIs, and it's not clear what that would even look like. There's perhaps an unresolved question of how to handle that if we do run into it in the scanner. The current behaviour is to return the base index for such accesses; an argument could be made for either not recording them at all, or e.g. setting some flag in the vkd3d_shader_combined_resource_sampler_info structure to indicate dynamic indexing is involved. Ultimately such shaders just aren't going to be usable with combined samplers though. -- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/466#note_52254

1 0

Re: [PATCH v2 0/1] MR466: vkd3d-shader: Implement scanning combined resource/sampler information.
by Zebediah Figura (＠zfigura) 14 Nov '23

14 Nov '23

I'm currently out and haven't had a chance to properly look at this, but, how does this interact with resource arrays? -- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/466#note_52250

1 0

[PATCH 0/1] MR4392: server: Don't crash when opening null path with a console handle as RootDirectory.
by Jinoh Kang (＠iamahuman) 14 Nov '23

14 Nov '23

Preparatory patch for revival of https://gitlab.winehq.org/wine/wine/-/merge_requests/498. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4392

3 2

[PATCH v9 0/7] MR443: tests: Add some tests for effects groups syntax.
by Nikolay Sivov (＠nsivov) 14 Nov '23

14 Nov '23

Signed-off-by: Nikolay Sivov <nsivov(a)codeweavers.com> -- v9: vkd3d-shader/tpf: Initial support for writing fx_4_0/fx_4_1 binaries. vkd3d-shader: Add separate binary target type for effects. vkd3d-shader/hlsl: Handle effect group statement. vkd3d-shader/hlsl: Add variables for techniques. vkd3d-shader/hlsl: Rename rule for top-level techniques. vkd3d-shader/hlsl: Add 'fxgroup' token. tests: Add some tests for effects groups syntax. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/443

3 19

[PATCH v3 0/7] MR458: vkd3d-shader/hlsl: Handle register(cX) reservations.
by Francisco Casas (＠fcasas) 14 Nov '23

14 Nov '23

Currently we are not properly handling register(cX) reservations for SM1, this is one of the things required for the SNK shaders (CW Bug Bug 18092). register(cX) reservations also change the offset in the $Globals buffer in SM4, so support for this is also included. --- Patch 1/4 is required to specify: ``` [require] shader model < 4.0 ``` so that the tests that follow do not get run with the vulkan backend on SM4. I think nobody disagreed with that patch. -- v3: vkd3d-shader/hlsl: Turn register(cX) reservations into buffer offset for SM4. tvkd3d-shader/hlsl: Make register(cX) reservations work for SM1. tests: Test register(cX) reservations. tests: Rename register-reservations.shader_test to register-reservations-resources.shader_test. tests/vkd3d-shader: Allow passing (sm<4) and (sm>=4) to "fail" and "todo" qualifiers. tests/shader-runner: Discern between the minimum_shader_model and the selected_shader_model. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/458

4 15

[PATCH v5 0/6] MR461: vkd3d: Implement ID3D12Device2::CreatePipelineState().
by Conor McCarthy (＠cmccarthy) 14 Nov '23

14 Nov '23

-- v5: vkd3d: Support depth bounds test. tests: Test CreatePipelineState(). https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/461

2 7

[PATCH v4 0/6] MR461: vkd3d: Implement ID3D12Device2::CreatePipelineState().
by Conor McCarthy (＠cmccarthy) 14 Nov '23

14 Nov '23

-- v4: vkd3d: Support depth bounds test. tests: Test CreatePipelineState(). https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/461

2 6

[PATCH 0/1] MR4390: windows.gaming.input: Fix inverted start / select gamepad buttons.
by Rémi Bernon (＠rbernon) 14 Nov '23

14 Nov '23

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/4390

2 1

[PATCH 0/1] MR4389: winebus.sys: Ignore events on unsupported axes.
by Rémi Bernon (＠rbernon) 14 Nov '23

14 Nov '23

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=55660 -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4389

2 1

Re: [PATCH v2 0/7] MR4375: dmsynth: Various fixes 2
by Rémi Bernon (＠rbernon) 14 Nov '23

14 Nov '23

On Tue Nov 14 11:01:46 2023 +0000, Rémi Bernon wrote: > Hmm, right but does FluidSynth support such things? I had the impression > (but haven't confirmed it in any way) that they have dedicated > generators for some often used connections and that these were not > supposed to be set through fluid_mod. So, under that assumption a custom > connection to link SRC_KEYNUMBER -> DST_EG1_DECAYTIME would not be > possible to map? Looking a bit more into FS, it seems possible that it actually supports this, with fluid_voice_modulate updating generators "mod" value (used in fluid_voice_gen_value return) and calling fluid_voice_update_param, which calls calculate_hold_decay_buffers. In this case would it be simpler for our mapping to use mods for everything instead of setting it through these special generators? Anyway, for the fixups I think we could have a list of `fluid_mod` to apply like this, using `fluid_mod_test_identity` to replace identical mod entries: ```c struct mod_entry { struct list entry; fluid_mod_t *mod; }; ``` And if we can use mods for most generators, I can even imagine having an additional `int mode` field to keep at most one `FLUID_VOICE_OVERWRITE` and one `FLUID_VOICE_ADD` mod of each, translating and de-duplicating / fixing up all articulations at once, then adding the resulting mod list to the voice in a separate step. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4375#note_52231

1 0

[PATCH 0/2] MR4387: Draft: win32u: Misc dpi handling fixes
by Alexandros Frantzis (＠afrantzis) 14 Nov '23

14 Nov '23

A couple of fixes to win32u dpi handling, discovered while developing !4203. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4387

3 3

[PATCH v3 0/6] MR461: vkd3d: Implement ID3D12Device2::CreatePipelineState().
by Conor McCarthy (＠cmccarthy) 14 Nov '23

14 Nov '23

-- v3: vkd3d: Support depth bounds test. tests: Test CreatePipelineState(). vkd3d: Implement ID3D12Device2::CreatePipelineState(). vkd3d: Use struct d3d12_pipeline_state_desc for compute pipelines. vkd3d: Introduce struct d3d12_pipeline_state_desc for graphics pipelines. include: Add a D3D12_RT_FORMAT_ARRAY typedef. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/461

3 9

Re: [PATCH v2 0/7] MR4375: dmsynth: Various fixes 2
by Rémi Bernon (＠rbernon) 14 Nov '23

14 Nov '23

On Tue Nov 14 10:43:53 2023 +0000, Anton Baskanov wrote: > DLS2 spec has a table of fixed routing connections that must be > supported, but also mentions that implementations are free to support > other connections as well. > Imagine a DLS file that has a SRC_KEYNUMBER->DST_EG1_DECAYTIME > connection with a controller. It would require a dynamic offset > adjustment based on the controller value. And there could be multiple > such connections, each with a different controller. Hmm, right but does FluidSynth support such things? I had the impression (but haven't confirmed it in any way) that they have dedicated generators for some often used connections and that these were not supposed to be set through fluid_mod. So, under that assumption a custom connection to link SRC_KEYNUMBER -> DST_EG1_DECAYTIME would not be possible to map? -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4375#note_52212

1 0

Re: [PATCH v2 0/7] MR4375: dmsynth: Various fixes 2
by Anton Baskanov (＠baskanov) 14 Nov '23

14 Nov '23

On Tue Nov 14 10:00:34 2023 +0000, Rémi Bernon wrote: > What do you mean by arbitrary connections? DLS2 spec has a table of fixed routing connections that must be supported, but also mentions that implementations are free to support other connections as well. Imagine a DLS file that has a SRC_KEYNUMBER->DST_EG1_DECAYTIME connection with a controller. It would require a dynamic offset adjustment based on the controller value. And there could be multiple such connections, each with a different controller. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4375#note_52209

1 0

[PATCH v2 0/1] MR4350: rpcrt4: Remove DECLSPEC_HIDDEN usage.
by Alistair Leslie-Hughes (＠alesliehughes) 14 Nov '23

14 Nov '23

-- v2: rpcrt4: Remove DECLSPEC_HIDDEN usage. https://gitlab.winehq.org/wine/wine/-/merge_requests/4350

3 2

Re: [PATCH v2 0/7] MR4375: dmsynth: Various fixes 2
by Rémi Bernon (＠rbernon) 14 Nov '23

14 Nov '23

On Tue Nov 14 09:21:35 2023 +0000, Anton Baskanov wrote: > > Although they look fine, 20ab5954 (and ec219ce1 even more) cut some > notes early in FF VIII intro. > Looks like note-off queuing for DMUS_PMSGT_NOTE needs to be handled > differently. I'll drop these for now. > > Haven't really looked into the details but 0ff26da7 feels a bit > complicated, I'm wondering if there's a better way to do this. > It depends on whether we need to support arbitrary connections. > > Regarding 2e226c26, is this what native does? > Yes, there is no fallback for melodic instruments for some reason, only > for drums. Though now I see that I handle missing regions incorrectly > (these should also fall back to Standard). I'll update the request. > I was also thinking about adding some tests, though I'm not sure how to > compare the output. The generated waveforms are quite different (e.g. > native produces a linear attack slope with some discrete steps, while > FluidSynth produces a smooth exponential one). > ![Screenshot_20231114_155825](/uploads/e46a2662792a0452350b8384b7eea0a6/Screenshot_20231114_155825.png) The attack time looks different but were it the same I think the shape difference can be ignored by having some leeway in the test. I added a couple of similar tests for MF audio transform output where we check that the total sample diff does not exceed a small percentage of the total, maybe reusing it here can work. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4375#note_52207

1 0

Re: [PATCH v2 0/7] MR4375: dmsynth: Various fixes 2
by Rémi Bernon (＠rbernon) 14 Nov '23

14 Nov '23

On Tue Nov 14 09:21:35 2023 +0000, Anton Baskanov wrote: > If we don't need to support arbitrary connections, then yes, your > proposed solution looks like the way to go. > I don't currently plan to add more fixups. What do you mean by arbitrary connections? -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4375#note_52206

1 0

[PATCH 0/1] MR472: vkd3d-shader: Add a helper to check for a numeric type.
by Nikolay Sivov (＠nsivov) 14 Nov '23

14 Nov '23

-- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/472

3 2

[PATCH 0/1] MR4367: winmm/tests: Use calloc instead of HeapAlloc.
by Alex Henrie (＠alexhenrie) 14 Nov '23

14 Nov '23

Fixes: bb6bcaf83e91882e0a523a4455ed7174b3ce3ad4 -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4367

3 2

Re: [PATCH v2 0/7] MR4375: dmsynth: Various fixes 2
by Anton Baskanov (＠baskanov) 14 Nov '23

14 Nov '23

> Although they look fine, 20ab5954 (and ec219ce1 even more) cut some notes early in FF VIII intro. Looks like note-off queuing for DMUS_PMSGT_NOTE needs to be handled differently. I'll drop these for now. > Haven't really looked into the details but 0ff26da7 feels a bit complicated, I'm wondering if there's a better way to do this. It depends on whether we need to support arbitrary connections. > Regarding 2e226c26, is this what native does? Yes, there is no fallback for melodic instruments for some reason, only for drums. Though now I see that I handle missing regions incorrectly (these should also fall back to Standard). I'll update the request. I was also thinking about adding some tests, though I'm not sure how to compare the output. The generated waveforms are quite different (e.g. native produces a linear attack slope with some discrete steps, while FluidSynth produces a smooth exponential one). ![Screenshot_20231114_155825](/uploads/e46a2662792a0452350b8384b7eea0a6/Screenshot_20231114_155825.png) -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4375#note_52200

1 0

Re: [PATCH v2 0/7] MR4375: dmsynth: Various fixes 2
by Anton Baskanov (＠baskanov) 14 Nov '23

14 Nov '23

On Mon Nov 13 13:16:56 2023 +0000, Rémi Bernon wrote: > Instead of a dynamic list, could we have just a simple structure like: > ```c > struct gen_increments > { > float env_hold; > float env_decay; > float vol_hold; > float vol_decay; > }; > ``` > Which we would pass around down to `add_mod_from_connection` which would > set the needed adjustments (it's actually only needed there, > `set_gen_from_connection` won't have to add increments), and then after > the loops we would call `fluid_voice_gen_incr` for each of these? > Or do we need the generic version for more fixups that are not in this MR? If we don't need to support arbitrary connections, then yes, your proposed solution looks like the way to go. I don't currently plan to add more fixups. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4375#note_52199

1 0

[PATCH 0/1] MR4368: gdi32/tests: Free what GdiConvertToDevmodeW returns with HeapFree.
by Alex Henrie (＠alexhenrie) 14 Nov '23

14 Nov '23

This partially reverts commit 0b7eed0310a2d1272a97d8a45ec37fa03a9c26c8. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4368

3 2

[PATCH v2 0/6] MR461: vkd3d: Implement ID3D12Device2::CreatePipelineState().
by Conor McCarthy (＠cmccarthy) 14 Nov '23

14 Nov '23

-- v2: vkd3d: Support depth bounds test. tests: Test CreatePipelineState(). vkd3d: Implement ID3D12Device2::CreatePipelineState(). vkd3d: Use struct d3d12_pipeline_state_desc for compute pipelines. vkd3d: Introduce struct d3d12_pipeline_state_desc for graphics pipelines. include: Add a D3D12_RT_FORMAT_ARRAY typedef. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/461

2 7

[PATCH 0/1] MR4384: ntdll: Don't use sysconf(_SC_PHYS_PAGES) on macOS.
by Brendan Shanks (＠bshanks) 14 Nov '23

14 Nov '23

`sysconf(_SC_PHYS_PAGES)` returns an error for i386 Mac binaries on any machine with more than 4 GB of RAM. From [the source code](https://github.com/apple-oss-distributions/Libc/blob/c5a3293354e22262… it's clear why--it calls `sysctlbyname()` to put the `hw.memsize` sysctl into a long, which is only 32-bits on i386. This returns an error on any Mac with more than 4GB: the value is too large for a 32-bit long. The `sysctl` man page documents that an int64 should be used for `hw.memsize`, do that and divide by the page size ourselves. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4384

2 1

[PATCH 0/1] MR4300: net: Accept yes/no switches
by Fabian Maurer (＠DarkShadow44) 14 Nov '23

14 Nov '23

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=55859 -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4300

2 2

Re: [PATCH v7 0/2] MR3259: Add environment variable to isolate WINEPREFIX at creation
by Fabian Maurer (＠DarkShadow44) 13 Nov '23

13 Nov '23

On Mon Nov 13 21:02:03 2023 +0000, Alexandre Julliard wrote: > > Well, I target the parts where the folders are created, where else > could I handle it? I currently don't see a better way to do this. Mind > pointing me into the direction of a better design? > I don't mean the code, I mean the UI design. > As you point out, this can be configured from winecfg. So why do we need > a separate mechanism, with an ad-hoc environment variable? Why is it > only usable at prefix creation? Is there a way to unify the features, or > make them easier to use? How is it different from `winetricks sandbox`? > etc. etc. Not sure this is the right place to discuss this, but the problem with winecfg is that the config is stored inside the WINEPREFIX. Every new WINEPREFIX would need to be configured again, since you (currently) can't have a global config. Similar issue with `winetricks sandbox`, you need to remember to do it in every new WINEPREFIX. I'm testing a lot of applications, and they often tend to put files into Documents and similar folders, and I want to prevent that. But since I regularly delete my WINEPREFIX, that config currently can't be permanent. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3259#note_52188

1 0

[PATCH v10 0/5] MR459: vkd3d-shader/dxil: Implement the DXIL VSELECT instruction.
by Conor McCarthy (＠cmccarthy) 13 Nov '23

13 Nov '23

-- v10: vkd3d-shader/spirv: Avoid invalid bool-to-bool conversion in spirv_compiler_emit_movc(). vkd3d-shader/dxil: Implement the DXIL VSELECT instruction. tests/shader-runner: Add tests for 64-bit casts. vkd3d-shader/spirv: Return an error if an invalid handler is encountered. tests/shader-runner: Add a test for float comparisons. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/459

2 6

[PATCH v2 0/2] MR4294: Add stubs for SetThreadDpiHostingBehavior and GetWindowDpiHostingBehavior
by Fabian Maurer (＠DarkShadow44) 13 Nov '23

13 Nov '23

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=55847 -- v2: user32: Add stub for GetWindowDpiHostingBehavior user32: Add stub for SetThreadDpiHostingBehavior https://gitlab.winehq.org/wine/wine/-/merge_requests/4294

4 5

[PATCH 0/5] MR4381: DMusic: Remove superfluous checks / casts
by Michael Stefaniuc (＠mstefani) 13 Nov '23

13 Nov '23

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/4381

3 6

Re: [PATCH v7 0/7] MR4358: dmime: Implement performance stop and segment repeat. - approved
by Alexandre Julliard (＠julliard) 13 Nov '23

13 Nov '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4358

1 0

Re: [PATCH v2 0/2] MR4376: Msdasql fixes - approved
by Alexandre Julliard (＠julliard) 13 Nov '23

13 Nov '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4376

1 0

Re: [PATCH v2 0/1] MR4371: dbghelp: Remove DECLSPEC_HIDDEN usage. - approved
by Alexandre Julliard (＠julliard) 13 Nov '23

13 Nov '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4371

1 0

Re: [PATCH v3 0/1] MR4365: opengl32: Skip filter_extensions_index() on GL contexts < 3.0. - approved
by Alexandre Julliard (＠julliard) 13 Nov '23

13 Nov '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4365

1 0

2025

2024

2023

2022

wine-gitlab