- wine-gitlab - winehq.org

Re: [PATCH v2 0/2] MR4376: Msdasql fixes - approved
by Alexandre Julliard (＠julliard) 13 Nov '23

13 Nov '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4376

1 0

Re: [PATCH v2 0/1] MR4371: dbghelp: Remove DECLSPEC_HIDDEN usage. - approved
by Alexandre Julliard (＠julliard) 13 Nov '23

13 Nov '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4371

1 0

Re: [PATCH v3 0/1] MR4365: opengl32: Skip filter_extensions_index() on GL contexts < 3.0. - approved
by Alexandre Julliard (＠julliard) 13 Nov '23

13 Nov '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4365

1 0

Re: [PATCH v2 0/1] MR4369: user32/tests: Allocate clipboard data with HeapAlloc. - approved
by Alexandre Julliard (＠julliard) 13 Nov '23

13 Nov '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4369

1 0

Re: [PATCH v2 0/1] MR466: vkd3d-shader: Implement scanning combined resource/sampler information. - approved
by Alexandre Julliard (＠julliard) 13 Nov '23

13 Nov '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/466

1 0

Re: [PATCH v2 0/1] MR465: vkd3d-shader/dxil: Fully initialize instruction data in sm6_parser_emit_extractval(). - approved
by Alexandre Julliard (＠julliard) 13 Nov '23

13 Nov '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/465

1 0

Re: [PATCH v2 0/3] MR468: vkd3d: A few spelling fixes. - approved
by Alexandre Julliard (＠julliard) 13 Nov '23

13 Nov '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/468

1 0

Re: [PATCH v2 0/1] MR467: vkd3d-shader/ir: Introduce vsir_register_is_descriptor(). - approved
by Alexandre Julliard (＠julliard) 13 Nov '23

13 Nov '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/467

1 0

[PATCH v6 0/7] MR4358: dmime: Implement performance stop and segment repeat.
by Rémi Bernon (＠rbernon) 13 Nov '23

13 Nov '23

-- v6: dmime: Implement segment state repeat and looping. dmime: Split segment_state_play_chunk helper. dmsynth: Reset synthesizer defaults on MIDI_SYSTEM_RESET. dmime: Send MIDI_SYSTEM_RESET message on performance reset. dmime: Clear all pending messages in IDirectMusicPerformance_Stop. dmime/tests: Test that IDirectMusicPerformance_Stop clears messages. dmime/tests: Avoid discarding old notifications in test. https://gitlab.winehq.org/wine/wine/-/merge_requests/4358

3 9

Re: [PATCH v7 0/2] MR3259: Add environment variable to isolate WINEPREFIX at creation
by Alexandre Julliard (＠julliard) 13 Nov '23

13 Nov '23

> Well, I target the parts where the folders are created, where else could I handle it? I currently don't see a better way to do this. Mind pointing me into the direction of a better design? I don't mean the code, I mean the UI design. As you point out, this can be configured from winecfg. So why do we need a separate mechanism, with an ad-hoc environment variable? Why is it only usable at prefix creation? Is there a way to unify the features, or make them easier to use? How is it different from `winetricks sandbox`? etc. etc. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3259#note_52155

1 0

[PATCH v6 0/3] MR4356: Draft: rawinput enhancements
by Errno Ebadf (＠EBADF) 13 Nov '23

13 Nov '23

Add plumbing to server to prevent the server from making rawinput from INPUT_MOUSE and INPUT_KEYBOARD events so a graphics driver can inject its own INPUT_HARDWARE events. This will allow a graphics driver to be fully in charge of rawinput. -- v6: https://gitlab.winehq.org/wine/wine/-/merge_requests/4356

5 9

Re: [PATCH v7 0/2] MR3259: Add environment variable to isolate WINEPREFIX at creation
by Fabian Maurer (＠DarkShadow44) 13 Nov '23

13 Nov '23

> What's the use case for configuring folders individually? TBH, I just need all of them at once. But I figured I could also just make it fully configurable just in case someone needs that. I didn't see any harm in making it fully configurable from the start, just in case. > How are we going to ensure that prefix updates to the right thing? Sorry, I don't understand what you mean. Mind elaborating? The logic only runs when the folder doesn't exist. Unless I missed something, updates shouldn't be a problem. > How can it be enabled/disabled after prefix creation? The logic I changed only runs when the folder doesn't exist, you can always link/unlink the folders using winecfg. > How is it going to handle inability to open Unix files (fonts etc.) Well, it's not different from disabling the Z:\ link in winecfg. If someone doesn't know what they're doing, they can run into problems with that as well. This MR would only add on option to disable the link automatically when creating a new WINEPREFIX. > This needs a lot more thought and a proper design. Well, I target the parts where the folders are created, where else could I handle it? I currently don't see a better way to do this. Mind pointing me into the direction of a better design? -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3259#note_52152

1 0

[PATCH 0/7] MR4380: mshtml: Keep inner window's link to the outer window until it's destroyed.
by Gabriel Ivăncescu (＠insn) 13 Nov '23

13 Nov '23

Here's a list of usages of `base.outer_window` that may be impacted by the change and my analysis/fixes. Note that I specifically did not look for `document->outer_window` since that one was already holding it forever, so it's out of scope for this MR (whether it's correct or not, the behavior is the same after this MR). I also didn't consider some cases that already **did not check** for it being NULL or not, because they would have crashed earlier before anyway (they'd still crash now if outer window gets killed, but it's out of scope of the MR as I said). For those that says "Handled" it means I've added checks so that the behavior is same as before, i.e. detached inner windows behave as if outer window is NULL. * `htmldoc.c/HTMLDocument_get_mimeType`: Changed so it doesn't rely on outer window. * `htmldoc.c/HTMLDocument7_get_defaultView`: This is actually fixed by these patches. * `htmlform.c/HTMLFormElement_submit`: Handled. * `htmlstorage.c/send_storage_event`: Fixed in a separate patch with tests, since it follows the outer window. * `htmlwindow.c/check_target_origin`: This (along with many other methods) can't have it NULL anymore or detached, since the caller must hold a ref to the outer window, and they're not called from our objects holding ref to inner window only. * `htmlwindow.c/HTMLWindowSP_QueryService`: This uses the outer window to obtain the browser and the doc obj, so it's fine. * `mutation.c/set_document_mode`: Handled. * `navigate.c/BindCallbackRedirect_Redirect`: Handled. * `navigate.c/nsAsyncVerifyRedirectCallback_OnRedirectVerifyCallback`: Handled. * `navigate.c/nsChannelBSC_init_bindinfo`: Uses the outer window to obtain the browser and doc obj to set a flag, so it's harmless and probably correct this way. * `navigate.c/handle_navigation_error`: Handled. * `navigate.c/handle_extern_mime_navigation`: Handled. * `omnavigator.c/OmHistory_get_length`: This is actually fixed by these patches. * `script.c/ActiveScriptSite_GetItemInfo`: Handled. * `script.c/ActiveScriptSiteWindow_GetWindow`: Handled. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4380

3 8

[PATCH v8 0/1] MR3931: windows.ui: Support accent colors in uisettings3_GetColorValue.
by Myah Caron (＠qsniyg) 13 Nov '23

13 Nov '23

Fixes https://bugs.winehq.org/show_bug.cgi?id=55640. -- v8: windows.ui: Support accent colors in uisettings3_GetColorValue. https://gitlab.winehq.org/wine/wine/-/merge_requests/3931

4 4

[PATCH 0/1] MR4379: Draft: mfmediaengine/tests: Test frame advancing behavior in frame server mode.
by Bernhard Kölbl (＠besentv) 13 Nov '23

13 Nov '23

The main goal here is to show that the current implementation is very sure wrong. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4379

3 2

[PATCH 0/4] MR4378: Extend CreateProcess tests for handle inheritance.
by eric pouech (＠epo) 13 Nov '23

13 Nov '23

This serie adds a couple of test for CreateProcess around std handles inheritance, depending on several options (cui/gui, use (or no use) of STARTF_USESTDHANDLES, type of handles...). This requires revisiting the existing tests to allow for more flexibility in implementing the new tests (and potentially others if needed). -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4378

2 4

Re: [PATCH v5 0/3] MR4243: rtworkq: free cancelled work items
by Yuxuan Shui (＠yshui) 13 Nov '23

13 Nov '23

On Mon Nov 13 14:56:51 2023 +0000, Yuxuan Shui wrote: > > not supported > not sure what you mean by that? I can build it fine with mingw-w64-g++ > and it runs. > > cancellation does not work > this is not true. callback could still be called after MFCancelWorkItem > returns success, the > [documentation](https://learn.microsoft.com/en-us/windows/win32/api/mfapi/nf… > says as much. > and the thing is, more than this "hit race" case, our current rtworkq > implementation triggers a assert in threadpool that says exactly what i > predicted (callback is running when you try to close it). and that's > exactly the race I am trying to avoid here. > what more proof do you want? i hope you understand the problem here. the problem is not the assert, so doesn't matter if the TP implementation handles this case. the problem is if the `scheduled_item_cancelable_callback` is running when we reaches `queue_cancel_item`, we will double release the work item. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4243#note_52137

1 0

Re: [PATCH v5 0/3] MR4243: rtworkq: free cancelled work items
by Yuxuan Shui (＠yshui) 13 Nov '23

13 Nov '23

> not supported not sure what you mean by that? I can build it fine with mingw-w64-g++ and it runs. > cancellation does not work this is not true. callback could still be called after MFCancelWorkItem returns success, the [documentation](https://learn.microsoft.com/en-us/windows/win32/api/mfapi/nf… says as much. and the thing is, more than this "hit race" case, our current rtworkq implementation triggers a assert in threadpool that says exactly what i predicted (callback is running when you try to close it). and that's exactly the race I am trying to avoid here. what more proof do you want? -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4243#note_52135

1 0

[PATCH v9 0/5] MR3572: mf: Make session_get_node_object() more robust.
by Zhiyi Zhang (＠zhiyi) 13 Nov '23

13 Nov '23

It's possible that a state object pointer not in the topology node collection gets passed to session_get_node_object(). Instead of returning the last node when the object is not found, we should return a NULL so that the state of the last node is not changed by mistake. -- v9: mf/tests: Test IMFMediaSession::Start(). mf: Support seeking while a session is running. mf/tests: Add a create_test_topology() helper. mf: Add a session_flush_nodes() helper. mf: Make session_get_node_object() more robust. https://gitlab.winehq.org/wine/wine/-/merge_requests/3572

4 9

[PATCH v9 0/6] MR459: vkd3d-shader/dxil: Implement the DXIL VSELECT instruction.
by Conor McCarthy (＠cmccarthy) 13 Nov '23

13 Nov '23

-- v9: vkd3d-shader/spirv: Avoid invalid bool-to-bool conversion in spirv_compiler_emit_movc(). vkd3d-shader/dxil: Implement the DXIL VSELECT instruction. tests/shader-runner: Add tests for 64-bit casts. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/459

3 9

[PATCH v8 0/6] MR459: vkd3d-shader/dxil: Implement the DXIL VSELECT instruction.
by Conor McCarthy (＠cmccarthy) 13 Nov '23

13 Nov '23

-- v8: vkd3d-shader/spirv: Avoid invalid bool-to-bool conversion in spirv_compiler_emit_movc(). vkd3d-shader/dxil: Implement the DXIL VSELECT instruction. tests/shader-runner: Add tests for 64-bit casts. vkd3d-shader/spirv: Return an error if an invalid handler is encountered. tests/shader-runner: Add a test for float comparisons. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/459

3 10

[PATCH 0/1] MR466: vkd3d-shader: Implement scanning combined resource/sampler information.
by Henri Verbeet (＠hverbeet) 13 Nov '23

13 Nov '23

-- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/466

3 6

Re: [PATCH v2 0/7] MR4375: dmsynth: Various fixes 2
by Rémi Bernon (＠rbernon) 13 Nov '23

13 Nov '23

Rémi Bernon (@rbernon) commented about dlls/dmsynth/synth.c: > struct wave *wave; > }; > > +struct fixup > +{ > + struct list entry; > + int dst; > + int src; > + int flags; > + > + int fixup_dst; > + float amount; > +}; > + Instead of a dynamic list, could we have just a simple structure like: ```c struct gen_increments { float env_hold; float env_decay; float vol_hold; float vol_decay; }; ``` Which we would pass around down to `add_mod_from_connection` which would set the needed adjustments (it's actually only needed there, `set_gen_from_connection` won't have to add increments), and then after the loops we would call `fluid_voice_gen_incr` for each of these? Or do we need the generic version for more fixups that are not in this MR? -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4375#note_52124

1 0

[PATCH v5 0/7] MR4358: dmime: Implement performance stop and segment repeat.
by Rémi Bernon (＠rbernon) 13 Nov '23

13 Nov '23

-- v5: dmime: Implement segment state repeat and looping. dmime: Split segment_state_play_chunk helper. dmsynth: Reset synthesizer defaults on MIDI_SYSTEM_RESET. dmime: Send MIDI_SYSTEM_RESET message on performance reset. dmime: Clear all pending messages in IDirectMusicPerformance_Stop. dmime/tests: Test that IDirectMusicPerformance_Stop clears messages. dmime/tests: Avoid discarding old notifications in test. https://gitlab.winehq.org/wine/wine/-/merge_requests/4358

3 8

Re: [PATCH v2 0/7] MR4375: dmsynth: Various fixes 2
by Rémi Bernon (＠rbernon) 13 Nov '23

13 Nov '23

Although they look fine, 20ab5954 (and ec219ce1 even more) cut some notes early in FF VIII intro. Haven't really looked into the details but 0ff26da7 feels a bit complicated, I'm wondering if there's a better way to do this. Regarding 2e226c26, is this what native does? Fwiw I'm thinking that if we want to have a much more robust SF2 / DLS2 mapping, it may be a good thing to have more dmsynth tests. I already added one that does basic sample rendering without checking the output, but maybe we should extend it to compare the rendered samples with various input. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4375#note_52119

1 0

[PATCH 0/2] MR469: vkd3d-shader/dxil: Handle missing flags as zero.
by Conor McCarthy (＠cmccarthy) 13 Nov '23

13 Nov '23

-- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/469

3 3

Re: [PATCH v5 0/3] MR4243: rtworkq: free cancelled work items
by Nikolay Sivov (＠nsivov) 13 Nov '23

13 Nov '23

On Mon Nov 13 10:09:34 2023 +0000, Yuxuan Shui wrote: > What errors are you getting? > I don't think it needs special build instructions? I link it with > mfplat, mf, ole32 and combase. First thing is that it's not supported in current mingw-w64. And I'm not sure if building cpp stuff with it will work at all on windows. The "hit race" condition is not really a race, isn't it? It means callback was called after item was cancelled. That could mean that cancellation does not work, but it's not a problem in call order I think. Regarding managing TP objects, does our rtworkq work correctly on Windows? Maybe we need to fix something on threadpool side. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4243#note_52107

1 0

[PATCH 0/1] MR465: vkd3d-shader/dxil: Fully initialize instruction data in sm6_parser_emit_extractval().
by Nikolay Sivov (＠nsivov) 13 Nov '23

13 Nov '23

Noticed after test runner started crashing when tracing is enabled. Signed-off-by: Nikolay Sivov <nsivov(a)codeweavers.com> -- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/465

5 7

[PATCH 0/3] MR468: vkd3d: A few spelling fixes.
by Nikolay Sivov (＠nsivov) 13 Nov '23

13 Nov '23

-- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/468

4 5

[PATCH 0/4] MR4377: Reimplement msvcrt env functions to match native.
by eric pouech (＠epo) 13 Nov '23

13 Nov '23

This serie: - adds a couple of msvcrt env tests (mainly env block inheritance) - introduces env tests for ucrtbase - reimplement most of the env related functions to mimic native behavior (basically when env is modified, native crt uses a per-variable entry allocation block (instead of having pointers inside a single chunk of memory). This fixes programs which keep a pointer on returned getenv() string and expect that pointer content is not modified when other variables in env are modified. @piotr: from previous version - I dropped the synchronization of \_environ and \_wenviron hence requiring the duplication of most of the code in ansi/unicode versions - I also tested the changes with unicode crt startup code (you can find in [1] this MR extended with this test code but I don't think we want to push it upstream) - there are some init code changes because of ucrtbase tests and unicode crt startup tests [1] https://gitlab.winehq.org/epo/wine/-/tree/mr-crt-env-full?ref_type=heads -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4377

2 4

[PATCH 0/1] MR467: vkd3d-shader/ir: Introduce vsir_register_is_descriptor().
by Henri Verbeet (＠hverbeet) 13 Nov '23

13 Nov '23

-- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/467

3 3

Re: [PATCH v7 0/2] MR3259: Add environment variable to isolate WINEPREFIX at creation
by Alexandre Julliard (＠julliard) 13 Nov '23

13 Nov '23

That's just an ad-hoc hack. What's the use case for configuring folders individually? How are we going to ensure that prefix updates to the right thing? How can it be enabled/disabled after prefix creation? How is it going to handle inability to open Unix files (fonts etc.)? This needs a lot more thought and a proper design. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3259#note_52102

1 0

Re: [PATCH v5 0/3] MR4243: rtworkq: free cancelled work items
by Yuxuan Shui (＠yshui) 13 Nov '23

13 Nov '23

On Sun Nov 12 17:58:00 2023 +0000, Nikolay Sivov wrote: > Thanks. How do I build this? What errors are you getting? I don't think it needs special build instructions? I link it with mfplat, mf, ole32 and combase. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4243#note_52101

1 0

[PATCH 0/1] MR3662: include: Annotate _mbsdup with __WINE_(DEALLOC|MALLOC).
by Alex Henrie (＠alexhenrie) 13 Nov '23

13 Nov '23

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/3662

4 7

Re: [PATCH v2 0/7] MR4375: dmsynth: Various fixes 2
by Anton Baskanov (＠baskanov) 13 Nov '23

13 Nov '23

v2: Fix unused function warning. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4375#note_52099

1 0

Re: [PATCH v7 0/1] MR4049: ntdll: Implement thread-ID alerts using kqueue()/kevent()
by Marc-Aurel Zent (＠marzent) 13 Nov '23

13 Nov '23

@bshanks just rebased it, if there is anything else that should be addressed, just let me know. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4049#note_52097

1 0

Re: [PATCH v3 0/1] MR4023: server: Add cross-platform get_path_from_fd function.
by Marc-Aurel Zent (＠marzent) 13 Nov '23

13 Nov '23

@julliard rebased it against current master, with the last commit this should be identical to the existing behaviour on Linux. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4023#note_52095

1 0

[PATCH 0/2] MR4376: Msdasql fixes
by Alistair Leslie-Hughes (＠alesliehughes) 13 Nov '23

13 Nov '23

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/4376

2 2

[PATCH 0/7] MR4375: dmsynth: Various fixes 2
by Anton Baskanov (＠baskanov) 13 Nov '23

13 Nov '23

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/4375

2 7

[PATCH v7 0/6] MR459: vkd3d-shader/dxil: Implement the DXIL VSELECT instruction.
by Conor McCarthy (＠cmccarthy) 13 Nov '23

13 Nov '23

-- v7: vkd3d-shader/spirv: Avoid invalid bool-to-bool conversion in spirv_compiler_emit_movc(). vkd3d-shader/dxil: Implement the DXIL VSELECT instruction. tests/shader-runner: Add tests for 64-bit casts. vkd3d-shader/spirv: Return an error if an invalid handler is encountered. tests/shader-runner: Add a test for float comparisons. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/459

2 6

[PATCH v6 0/6] MR459: Draft: vkd3d-shader/dxil: Implement the DXIL VSELECT instruction.
by Conor McCarthy (＠cmccarthy) 13 Nov '23

13 Nov '23

Goes atop !441. The last six commits belong to this MR. -- v6: vkd3d-shader/spirv: Avoid invalid bool-to-bool conversion in spirv_compiler_emit_movc(). vkd3d-shader/dxil: Implement the DXIL VSELECT instruction. tests/shader-runner: Add tests for 64-bit casts. vkd3d-shader/spirv: Return an error if an invalid handler is encountered. tests/shader-runner: Add a test for float comparisons. tests/shader-runner: Introduce an sm6 condition for test directives. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/459

2 6

[PATCH 0/1] MR4374: win32u: Find the correct dib driver in windrv_CreateDC().
by Zhiyi Zhang (＠zhiyi) 13 Nov '23

13 Nov '23

push_dc_driver() places drivers based on their priorities, so the newly created driver is not necessary on top. Thus in windrv_CreateDC(), find_dc_driver() should be used to find the dib driver instead of assuming the dib driver is the top driver, which could be the path driver because it has a higher priority. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4374

2 1

[PATCH v4 0/9] MR459: Draft: vkd3d-shader/dxil: Implement the DXIL VSELECT instruction.
by Conor McCarthy (＠cmccarthy) 13 Nov '23

13 Nov '23

Goes atop !441. The last six commits belong to this MR. -- v4: vkd3d-shader/spirv: Avoid invalid bool-to-bool conversion in spirv_compiler_emit_movc(). vkd3d-shader/dxil: Implement the DXIL VSELECT instruction. tests/shader-runner: Add tests for 64-bit casts. vkd3d-shader/spirv: Return an error if an invalid handler is encountered. tests/shader-runner: Add a test for float comparisons. tests/shader-runner: Introduce an sm6 condition for test directives. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/459

2 9

Re: [PATCH v3 0/2] MR4045: kernelbase: Rewrite ExpandEnvironmentStringsA to return ansi string size
by Fabian Maurer (＠DarkShadow44) 12 Nov '23

12 Nov '23

On Sun Nov 12 12:31:21 2023 +0000, Nikolay Sivov wrote: > This obviously has problems. Just from looking at it, I see a couple of > possible leaks. It also changes behaviour regarding error set on > insufficient buffer size. Turns out there is already big differences between Wine and Windows regrading error set. I pushed a rework, also fixed the leaks. Could you please take a look at this as well? -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4045#note_52076

1 0

Re: [PATCH v5 0/3] MR4243: rtworkq: free cancelled work items
by Nikolay Sivov (＠nsivov) 12 Nov '23

12 Nov '23

On Mon Nov 6 17:28:26 2023 +0000, Yuxuan Shui wrote: > https://gist.github.com/yshui/2f1c5c8ce9d80e9eef1db4eab51344d0 this > demonstrate the `CloseThreadpool` vs running callback race. Thanks. How do I build this? -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4243#note_52074

1 0

[PATCH 0/1] MR4373: user32: Add stubs for GetWindowDpiHostingBehavior and SetThreadDpiHostingBehavior
by Paweł Ulita (＠pawelulita) 12 Nov '23

12 Nov '23

Recent versions of Native Instruments Kontakt 7 introduced some additional HiDPI features. To do this, Kontakt calls 2 functions in `user32.dll` that Wine hasn't implemented yet: `GetWindowDpiHostingBehavior` and `SetThreadDpiHostingBehavior`. This patch adds stubs for these 2 functions and apparently that's enough for Kontakt. This is my first contribution to Wine, I'm not 100% sure if everything is like it should be. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4373

2 1

[PATCH v7 0/1] MR4372: kernel32: impl sync barrier
by quininer (＠quininer) 12 Nov '23

12 Nov '23

This is my first time contributing wine and there are a lot of things I'm not sure about, so any comments are welcome. :) -- v7: kernel32: impl sync barrier https://gitlab.winehq.org/wine/wine/-/merge_requests/4372

3 2

Re: [PATCH v3 0/1] MR4045: kernelbase: Rewrite ExpandEnvironmentStringsA to return ansi string size
by Nikolay Sivov (＠nsivov) 12 Nov '23

12 Nov '23

On Sun Nov 12 12:31:21 2023 +0000, Fabian Maurer wrote: > Any news on this? This obviously has problems. Just from looking at it, I see a couple of possible leaks. It also changes behaviour regarding error set on insufficient buffer size. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4045#note_52068

1 0

[PATCH v6 0/1] MR4372: kernel32: impl sync barrier
by quininer (＠quininer) 12 Nov '23

12 Nov '23

This is my first time contributing wine and there are a lot of things I'm not sure about, so any comments are welcome. :) -- v6: kernel32: impl sync barrier https://gitlab.winehq.org/wine/wine/-/merge_requests/4372

2 2

[PATCH v5 0/1] MR4372: kernel32: impl sync barrier
by quininer (＠quininer) 12 Nov '23

12 Nov '23

This is my first time contributing wine and there are a lot of things I'm not sure about, so any comments are welcome. :) -- v5: kernel32: impl sync barrier https://gitlab.winehq.org/wine/wine/-/merge_requests/4372

2 1

[PATCH v4 0/1] MR4372: kernel32: impl sync barrier
by quininer (＠quininer) 12 Nov '23

12 Nov '23

This is my first time contributing wine and there are a lot of things I'm not sure about, so any comments are welcome. :) -- v4: kernel32: impl sync barrier https://gitlab.winehq.org/wine/wine/-/merge_requests/4372

2 1

[PATCH v3 0/1] MR4372: kernel32: impl sync barrier
by quininer (＠quininer) 12 Nov '23

12 Nov '23

This is my first time contributing wine and there are a lot of things I'm not sure about, so any comments are welcome. :) -- v3: kernel32: impl sync barrier https://gitlab.winehq.org/wine/wine/-/merge_requests/4372

3 2

[PATCH v2 0/4] MR4372: kernel32: impl sync barrier
by quininer (＠quininer) 12 Nov '23

12 Nov '23

This is my first time contributing wine and there are a lot of things I'm not sure about, so any comments are welcome. :) -- v2: Fix lint https://gitlab.winehq.org/wine/wine/-/merge_requests/4372

2 4

[PATCH 0/3] MR4372: kernel32: impl sync barrier
by quininer (＠quininer) 12 Nov '23

12 Nov '23

This is my first time contributing wine and there are a lot of things I'm not sure about, so any comments are welcome. :) -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4372

2 3

[PATCH v5 0/2] MR3259: Add environment variable to isolate WINEPREFIX at creation
by Fabian Maurer (＠DarkShadow44) 11 Nov '23

11 Nov '23

I'm aware that winecfg allows unlinking of symlinked folders, but this is very annoying when regularly recreating WINEPREFIXES. This change makes it easy to isolate those folders from the start. -- v5: ntdll: Add environment variable to prevent symlinking dosdevices/z: shell32: Add environment variable to prevent symlinking home folders https://gitlab.winehq.org/wine/wine/-/merge_requests/3259

2 2

[PATCH 0/1] MR4241: undname: Add basic implementation
by Fabian Maurer (＠DarkShadow44) 11 Nov '23

11 Nov '23

This is just for convenience and would allow easy demangling of symbols without using windows tools or websites like demangler.com -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4241

3 8

[PATCH 0/1] MR4371: dbghelp: Remove DECLSPEC_HIDDEN usage.
by Alistair Leslie-Hughes (＠alesliehughes) 11 Nov '23

11 Nov '23

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/4371

2 1

[PATCH 0/1] MR4370: d3d8/tests: Free what Validate(Vertex|Pixel)Shader return with HeapFree.
by Alex Henrie (＠alexhenrie) 11 Nov '23

11 Nov '23

Fixes: 6db89702a3f7e7563c96f4ea3836b9cb261a8685 -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4370

2 1

[PATCH 0/1] MR4369: user32/tests: Allocate clipboard data with HeapAlloc.
by Alex Henrie (＠alexhenrie) 11 Nov '23

11 Nov '23

This partially reverts commit faae2162b89e951a94f74f65986f6a1015366cf3. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4369

2 1

[PATCH v2 0/1] MR3410: advpack: Add nullcheck for parameter that can be null (Coverity)
by Fabian Maurer (＠DarkShadow44) 11 Nov '23

11 Nov '23

-- v2: advpack: Add nullcheck for parameter that can be null (Coverity) https://gitlab.winehq.org/wine/wine/-/merge_requests/3410

2 1

[PATCH v12 0/11] MR1074: Draft: ntdll: Improve Valgrind and GDB integration.
by Rémi Bernon (＠rbernon) 11 Nov '23

11 Nov '23

Valgrind support requires a fork, which I've published to https://gitlab.winehq.org/rbernon/valgrind. The fork implements loading DWARF debug info from PE files, instead of the old and broken upstream PDB support. I've tried to upstream these changes a long time ago but didn't receive any feedback. I think we could maybe consider keeping a fork, which I'm happy to maintain, as the changes aren't too large. We may want to investigate adding 32-on-64 support, which may require a bit more changes (to VEX specifically, because its amd64 guest doesn't support segment register manipulation). The changes here are not all related to Valgrind, and I'll create separate MR for those which may make sense independently from Valgrind / GDB. Also included is a suppression file to silent some annoying false positives, many of which are coming from the cross-stack accesses during syscalls, which are confusing Valgrind's stack heuristics. One can try this out with something like: `WINELOADERNOEXEC=1 valgrind --suppressions=tools/valgrind.supp wine64/loader/wine64 wine64/programs/winecfg/winecfg.exe` -- v12: ntdll: Avoid writing to invalid memory in i386 unix dispatcher. ntdll: Fix incorrect i386 call_user_mode_callback CFI. ntdll: Avoid marking freed block header as undefined for valgrind. ntdll: Force HEAP_TAIL_CHECKING_ENABLED flag with valgrind. ntdll: Fix valgrind notifications from ntdll.so. ntdll: Import valgrind headers for PE side ntdll. loader: Implement SystemTap RTLD probes. configure.ac: Check for systemtap sys/sdt.h header. gitlab: Install systemtap-sdt-dev packages. ntdll: Maintain a PE module link map and expose it to GDB. loader: Expose a shadow copy of ld.so link map to GDB. https://gitlab.winehq.org/wine/wine/-/merge_requests/1074

2 11

Re: [PATCH v3 0/7] MR3909: winewayland.drv: part 7: Basic window management
by Alexandros Frantzis (＠afrantzis) 11 Nov '23

11 Nov '23

On Fri Nov 10 20:03:47 2023 +0000, Vixea wrote: > It's probably because it's being software rendered so it takes a second > to actually update the content of the window > Side note: you can still see it on xWayland it's just less noticeable > like I said it's noticable on wayland because of software rendering Hi! This is a known issue, see https://gitlab.winehq.org/wine/wine/-/merge_requests/3686#note_43830 for a description of why this is happening more (but not exclusively) with the Wayland driver. The aforementioned comment describes the effect with motion events, but it's the same cause for sustained resize events. Unfortunately we don't have a good solution yet. `regedit` is particularly prone to this, because it takes a surprisingly long time to render its contents. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3909#note_52024

1 0

Re: [PATCH v2 0/1] MR4253: winmm/tests: Use CRT allocation functions.
by Rémi Bernon (＠rbernon) 11 Nov '23

11 Nov '23

Fwiw tests are crashing on Windows since this was merged. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4253#note_52023

1 0

Re: [PATCH v3 0/1] MR4249: gdi32/tests: Use CRT allocation functions.
by Rémi Bernon (＠rbernon) 11 Nov '23

11 Nov '23

Fwiw tests are crashing on Windows since this was merged. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4249#note_52022

1 0

Re: [PATCH v2 0/1] MR4211: d3d8/tests: Use CRT allocation functions.
by Rémi Bernon (＠rbernon) 11 Nov '23

11 Nov '23

Fwiw tests are crashing on Windows since this was merged. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4211#note_52020

1 0

Re: [PATCH v2 0/1] MR4252: user32/tests: Use CRT allocation functions.
by Rémi Bernon (＠rbernon) 11 Nov '23

11 Nov '23

Fwiw tests are crashing on Windows since this was merged. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4252#note_52021

1 0

[PATCH v2 0/1] MR4365: opengl32: Skip filter_extensions_index() on GL contexts < 3.0.
by Matteo Bruni (＠Mystral) 11 Nov '23

11 Nov '23

glGetStringi() is not available before 3.0. We can't trust its function pointer being NULL since the GL implementation is allowed to return anything in this case (*cough* macOS's GL on Metal *cough*). This probably regressed when fd92954df8cf12c61e08c7ef7acf172efb7c44ad removed the "if (!disabled[0]) return FALSE;" exit from filter_extensions(), although that simply exposed an existing issue. -- v2: opengl32: Skip filter_extensions_index() on GL contexts < 3.0. https://gitlab.winehq.org/wine/wine/-/merge_requests/4365

2 1

[PATCH 0/4] MR4366: wined3d: More fixes related to texture binding.
by Zebediah Figura (＠zfigura) 11 Nov '23

11 Nov '23

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/4366

3 4

[PATCH 0/1] MR4292: d3dcompiler_43/tests: Use CRT allocation functions.
by Alex Henrie (＠alexhenrie) 10 Nov '23

10 Nov '23

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/4292

3 2

[PATCH 0/1] MR4365: opengl32: Skip filter_extensions_index() on GL contexts < 3.0.
by Matteo Bruni (＠Mystral) 10 Nov '23

10 Nov '23

glGetStringi() is not available before 3.0. We can't trust its function pointer being NULL since the GL implementation is allowed to return anything in this case (*cough* macOS's GL on Metal *cough*). This probably regressed when fd92954df8cf12c61e08c7ef7acf172efb7c44ad removed the "if (!disabled[0]) return FALSE;" exit from filter_extensions(), although that simply exposed an existing issue. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4365

2 1

Re: [PATCH v2 0/5] MR4359: dmime: Fix port leaks in performance channel blocks. - approved
by Alexandre Julliard (＠julliard) 10 Nov '23

10 Nov '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4359

1 0

Re: [PATCH v2 0/4] MR4361: GUI programs cleanup. - approved
by Alexandre Julliard (＠julliard) 10 Nov '23

10 Nov '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4361

1 0

Re: [PATCH v4 0/2] MR4312: mshtml: Return outer window to external callers. - approved
by Alexandre Julliard (＠julliard) 10 Nov '23

10 Nov '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4312

1 0

Re: [PATCH v7 0/6] MR4313: MSVCRT _(w)environ[] has a separate allocation chunk for each entry. - approved
by Alexandre Julliard (＠julliard) 10 Nov '23

10 Nov '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4313

1 0

Re: [PATCH v2 0/5] MR4331: wined3d: Various patches related to texture binding. - approved
by Alexandre Julliard (＠julliard) 10 Nov '23

10 Nov '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4331

1 0

Re: [PATCH v7 0/7] MR4341: msvcrt: Add implementation of more localized functions - approved
by Alexandre Julliard (＠julliard) 10 Nov '23

10 Nov '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4341

1 0

Re: [PATCH v4 0/1] MR4296: nsi: Use CRT allocation functions. - approved
by Alexandre Julliard (＠julliard) 10 Nov '23

10 Nov '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4296

1 0

Re: [PATCH v8 0/3] MR441: vkd3d-shader/dxil: Implement the DXIL CMP2 instruction. - approved
by Alexandre Julliard (＠julliard) 10 Nov '23

10 Nov '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/441

1 0

Re: [PATCH v10 0/3] MR219: vkd3d-shader: Implement tex2Dproj(). - approved
by Alexandre Julliard (＠julliard) 10 Nov '23

10 Nov '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/219

1 0

[PATCH 0/1] MR4362: gitlab: Add windows tests to MR pipeline.
by Rémi Bernon (＠rbernon) 10 Nov '23

10 Nov '23

Since we don't have the bridge anymore, and as I understand it's not coming back (?), it's becoming very easy to miss windows tests regressions. This should at least make sure we get some direct visibility of tests running on Win10. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4362

2 2

[PATCH v3 0/6] MR4358: dmime: Implement performance stop and segment repeat.
by Rémi Bernon (＠rbernon) 10 Nov '23

10 Nov '23

-- v3: dmime: Implement segment state repeat and looping. dmsynth: Reset synthesizer defaults on MIDI_SYSTEM_RESET. dmime: Send MIDI_SYSTEM_RESET message on performance reset. dmime: Clear all pending messages in IDirectMusicPerformance_Stop. dmime/tests: Test that IDirectMusicPerformance_Stop clears messages. dmime/tests: Avoid discarding old notifications in test. https://gitlab.winehq.org/wine/wine/-/merge_requests/4358

3 11

Re: [PATCH v3 0/7] MR3909: winewayland.drv: part 7: Basic window management
by Vixea (＠Vixea) 10 Nov '23

10 Nov '23

On Fri Nov 10 19:59:28 2023 +0000, darkblaze69 wrote: > @afrantzis Sorry for bumping this, are you aware that resizing some apps > windows happens with content distortion and flickering as compared to > Xwayland experience? Should I file a bug? > Here's illustration of `wine regedit`: > Wayland: > ![Screencast_from_2023-11-11_00-37-15](/uploads/6a229de153ba807de603e3903b22e978/Screencast_from_2023-11-11_00-37-15.webm) > Xwayland: > ![Screencast_from_2023-11-11_00-44-46](/uploads/366b2b5be267ff7119030410d03a2077/Screencast_from_2023-11-11_00-44-46.webm) It's probably because it's being software rendered so it takes a second to actually update the content of the window -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3909#note_51974

1 0

Re: [PATCH v3 0/7] MR3909: winewayland.drv: part 7: Basic window management
by darkblaze69 (＠darkblaze69) 10 Nov '23

10 Nov '23

@afrantzis Sorry for bumping this, are you aware that resizing some apps windows happens with content distortion and flickering as compared to Xwayland experience? Should I file a bug? Here's illustration of `wine regedit`: Wayland: ![Screencast_from_2023-11-11_00-37-15](/uploads/6a229de153ba807de603e3903b22e978/Screencast_from_2023-11-11_00-37-15.webm) Xwayland: ![Screencast_from_2023-11-11_00-44-46](/uploads/366b2b5be267ff7119030410d03a2077/Screencast_from_2023-11-11_00-44-46.webm) -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3909#note_51972

1 0

[PATCH 0/5] MR4359: dmime: Fix port leaks in performance channel blocks.
by Rémi Bernon (＠rbernon) 10 Nov '23

10 Nov '23

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/4359

3 8

[PATCH 0/5] MR4363: wined3d: Miscellaneous fixes.
by Zebediah Figura (＠zfigura) 10 Nov '23

10 Nov '23

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/4363

3 6

[PATCH v8 0/7] MR443: tests: Add some tests for effects groups syntax.
by Nikolay Sivov (＠nsivov) 10 Nov '23

10 Nov '23

Signed-off-by: Nikolay Sivov <nsivov(a)codeweavers.com> -- v8: vkd3d-shader/tpf: Initial support for writing fx_4_0/fx_4_1 binaries. vkd3d-shader: Add separate binary target type for effects. vkd3d-shader/hlsl: Handle effect group statement. vkd3d-shader/hlsl: Add variables for techniques. vkd3d-shader/hlsl: Rename rule for top-level techniques. vkd3d-shader/hlsl: Add 'fxgroup' token. tests: Add some tests for effects groups syntax. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/443

2 9

[PATCH 0/4] MR4361: GUI programs cleanup.
by eric pouech (＠epo) 10 Nov '23

10 Nov '23

This serie cleans up (partially) the builtin Wine programs/* compiled as GUI but still outputing to unix console. Starting with the low hanging fruits with cases where no one should care for the output. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4361

2 4

[PATCH 0/5] MR4360: server: allow preventing rawinput generation
by Errno Ebadf (＠EBADF) 10 Nov '23

10 Nov '23

* Major refactor for x11drv xinput2 (listen for events based on focus, use raw unaccelerated values for XI_RawMotion) * I have a version of this patch that is a minimal diff to the x11drv xinput2 handler (maybe I got carried away here...), but I think it might be better to focus on the send_hardware_message() plumbing to make sure it is good for other graphics drivers. Tested on XWayland only with MouseTester.exe (https://github.com/microe1/MouseTester/releases) and Quake Live (ported this set of patches to proton). -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4360

4 6

[PATCH v2 0/4] MR458: vkd3d-shader/hlsl: Handle register(cX) reservations.
by Francisco Casas (＠fcasas) 10 Nov '23

10 Nov '23

Currently we are not properly handling register(cX) reservations for SM1, this is one of the things required for the SNK shaders (CW Bug Bug 18092). register(cX) reservations also change the offset in the $Globals buffer in SM4, so support for this is also included. --- Patch 1/4 is required to specify: ``` [require] shader model < 4.0 ``` so that the tests that follow do not get run with the vulkan backend on SM4. I think nobody disagreed with that patch. -- v2: vkd3d-shader/hlsl: Turn register(cX) reservations into buffer offset for SM4. vkd3d-shader/hlsl: Make register(cX) reservations work for SM1. tests: Test register(cX) reservations. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/458

3 12

[PATCH v3 0/5] MR4203: winewayland.drv: part 9: Improved HiDPI support
by Alexandros Frantzis (＠afrantzis) 10 Nov '23

10 Nov '23

This MR improves driver support for scaled HiDPI displays, by respecting the application/window DPI. Since we don't support per-monitor DPI information and awareness modes yet, the user should set the Wine system DPI to match the DPI/scale of the display the app will be running on, for best results. Here is how things look with a few scenarios: 1. Screen scaled at 2x, application at 96dpi (e.g., dpi unaware apps) => the compositor automatically scales the surface: ![wine-wayland-2x-96dpi](/uploads/712bf2e64991889c91861d63dfd4fd60/wine-wayland-2x-96dpi.png) 2. Screen scaled at 2x, application at 192dpi (dpi matches compositor scale) => no compositor scaling: ![wine-wayland-2x-192dpi](/uploads/85c1201e1208f8b7e1c63804c7f83d1c/wine-wayland-2x-192dpi.png) 3. Screen scaled at 1x, application at 96dpi (dpi matches compositor scale) => no compositor scaling: ![wine-wayland-1x-96dpi](/uploads/8dfaaff1fc62defdb26f57c78cf9a427/wine-wayland-1x-96dpi.png) 4. Screen scaled at 1x, application at 192dpi, not typically used, just wanted to show what happens with such a mismatch: ![wine-wayland-1x-192dpi](/uploads/bb035140dd9c91ee3a22832c7280ab1b/wine-wayland-1x-192dpi.png) Thanks! -- v3: winewayland.drv: Ignore spurious size hints. winewayland.drv: Present cursors with the correct scale. winewayland.drv: Refactor cursor code to prepare for scaling support. winewayland.drv: Present surfaces with the correct scale. winewayland.drv: Prepare to handle different coordinate spaces. https://gitlab.winehq.org/wine/wine/-/merge_requests/4203

4 11

[PATCH v3 0/2] MR4312: mshtml: Return outer window to external callers.
by Gabriel Ivăncescu (＠insn) 10 Nov '23

10 Nov '23

This fixes some inconsistency issues when it comes to inner vs outer windows. On second patch I keep ref again to outer windows from the inner windows, and there are several reasons for this: * It fixes the existing tests to match native IE. * It simplifies the code (it's always valid now, no second-guessing or what-ifs needed) and gets rid of `outer_window` in HTMLDocumentNode. * It **fixes** the `outer_window` in HTMLDocumentNode → it was basically prone to crashes in niche cases since it didn't hold a ref before. We can't couple it to the inner `window` field either, because that one gets detached, and that will fail *existing* tests. For example: `events.c:3224: Test failed: put_URL failed: 80004005`. * Instead of having to keep outer window refs in specific objects, it's simpler to have it consistent everywhere. For now only the external caller changes are kept and a leak fix. -- v3: mshtml: Don't NULL out the doc's window when unlinking the window. mshtml: Return outer window to external callers. https://gitlab.winehq.org/wine/wine/-/merge_requests/4312

3 5

[PATCH v6 0/6] MR4313: MSVCRT _(w)environ[] has a separate allocation chunk for each entry.
by eric pouech (＠epo) 10 Nov '23

10 Nov '23

_(w)environ[] do have a distinct allocation chunk for each entry, so that _(w)environ[i] pointer and (pointed) string don't change when updating/deleting any other entry. Proposed implementation still differs from native: - allocation is done on process heap, while native uses msvcrt's heap - first ANSI allocated _environ[] doesn't have per entry allocation. This is only activated after a change (update/deletion) to _environ[] is made. -- v6: msvcrt: Fix getmainargs() family to return correct environment block. msvcrt: Use msvcrt heap for allocating envionment data. msvcrt: Test adding UNICODE env variables. msvcrt/tests: Add tests about intricating kernel32 and msvcrt env calls. msvcrt/tests: Add tests about allocation of environment entries. msvcrt: Improve environment tests (initial conditions). https://gitlab.winehq.org/wine/wine/-/merge_requests/4313

4 8

[PATCH 0/5] MR4331: wined3d: Various patches related to texture binding.
by Zebediah Figura (＠zfigura) 10 Nov '23

10 Nov '23

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/4331

3 6

[PATCH v2 0/6] MR4312: mshtml: Return outer windows to external callers and use refs to them.
by Gabriel Ivăncescu (＠insn) 10 Nov '23

10 Nov '23

This fixes some inconsistency issues when it comes to inner vs outer windows. On second patch I keep ref again to outer windows from the inner windows, and there are several reasons for this: * It fixes the existing tests to match native IE. * It simplifies the code (it's always valid now, no second-guessing or what-ifs needed) and gets rid of `outer_window` in HTMLDocumentNode. * It **fixes** the `outer_window` in HTMLDocumentNode → it was basically prone to crashes in niche cases since it didn't hold a ref before. We can't couple it to the inner `window` field either, because that one gets detached, and that will fail *existing* tests. For example: `events.c:3224: Test failed: put_URL failed: 80004005`. * Instead of having to keep outer window refs in specific objects, it's simpler to have it consistent everywhere. -- v2: mshtml: Get rid of outer_window member in HTMLDocumentNode. mshtml/tests: Improve the iframe navigation test. mshtml: Remove the inner window ref from the doc only when it is actually mshtml: Keep the inner window's outer_window pointer alive until it is mshtml: Don't NULL out the doc's window when unlinking the window. mshtml: Return outer window to external callers. https://gitlab.winehq.org/wine/wine/-/merge_requests/4312

3 10

[PATCH 0/3] MR461: vkd3d: Implement ID3D12Device2::CreatePipelineState().
by Conor McCarthy (＠cmccarthy) 10 Nov '23

10 Nov '23

-- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/461

3 4

[PATCH v5 0/6] MR4313: MSVCRT _(w)environ[] has a separate allocation chunk for each entry.
by eric pouech (＠epo) 10 Nov '23

10 Nov '23

_(w)environ[] do have a distinct allocation chunk for each entry, so that _(w)environ[i] pointer and (pointed) string don't change when updating/deleting any other entry. Proposed implementation still differs from native: - allocation is done on process heap, while native uses msvcrt's heap - first ANSI allocated _environ[] doesn't have per entry allocation. This is only activated after a change (update/deletion) to _environ[] is made. -- v5: msvcrt: Fix getmainargs() family to return correct environment block. msvcrt: Use msvcrt heap for allocating envionment data. msvcrt: Test adding UNICODE env variables. msvcrt/tests: Add tests about intricating kernel32 and msvcrt env calls. msvcrt/tests: Add tests about allocation of environment entries. msvcrt: Improve environment tests (initial conditions). https://gitlab.winehq.org/wine/wine/-/merge_requests/4313

3 8

[PATCH v3 0/9] MR459: Draft: vkd3d-shader/dxil: Implement the DXIL VSELECT instruction.
by Conor McCarthy (＠cmccarthy) 10 Nov '23

10 Nov '23

Goes atop !441. The last six commits belong to this MR. -- v3: vkd3d-shader/spirv: Avoid redundant bool-to-bool conversions in spirv_compiler_emit_movc(). vkd3d-shader/dxil: Implement the DXIL VSELECT instruction. tests/shader-runner: Introduce an sm6 condition for test directives. tests/shader-runner: Add tests for 64-bit casts. vkd3d-shader/spirv: Return an error if an invalid handler is encountered. tests/shader-runner: Add a test for float comparisons. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/459

2 9

Re: [PATCH v2 0/6] MR4358: dmime: Implement performance stop and segment repeat.
by Rémi Bernon (＠rbernon) 10 Nov '23

10 Nov '23

v2: Add a fix for the test failures (which probably started with a429a3fb4b1e8d5c04accd1e56c30f2138f03cf4), and ignore the Stop DIRTY message time which comes in slightly earlier than expected. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4358#note_51916

1 0

[PATCH 0/5] MR4358: dmime: Implement performance stop and segment repeat.
by Rémi Bernon (＠rbernon) 10 Nov '23

10 Nov '23

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/4358

3 7

[PATCH v7 0/3] MR441: vkd3d-shader/dxil: Implement the DXIL CMP2 instruction.
by Conor McCarthy (＠cmccarthy) 10 Nov '23

10 Nov '23

-- v7: vkd3d-shader/spirv: Introduce orderedness to comparison instructions. vkd3d-shader/dxil: Implement the DXIL CMP2 instruction. vkd3d-shader/spirv: Support bool dst register in spirv_compiler_emit_comparison_instruction(). https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/441

3 4

2025

2024

2023

2022