- wine-gitlab - winehq.org

Re: [PATCH v7 0/6] MR4140: uxtheme/tests: Add some tests for OpenThemeData() with various app/class names. - approved
by Alexandre Julliard (＠julliard) 08 Nov '23

08 Nov '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4140

1 0

Re: [PATCH v11 0/2] MR3988: msttsengine: Add stub dll and ISpTTSEngine stub. - approved
by Alexandre Julliard (＠julliard) 08 Nov '23

08 Nov '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3988

1 0

Re: [PATCH v2 0/1] MR4329: ntdll/unix: Replace sprintf with snprintf to avoid deprecation warnings on macOS. - approved
by Alexandre Julliard (＠julliard) 08 Nov '23

08 Nov '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4329

1 0

Re: [PATCH v3 0/3] MR3839: kernel32: Add structure size checks to CreateActCtx(). - approved
by Alexandre Julliard (＠julliard) 08 Nov '23

08 Nov '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3839

1 0

Re: [PATCH v3 0/1] MR4337: msdasql: IColumnsRowset::GetAvailableColumns return 3 meta columns to allow updating of a row. - approved
by Alexandre Julliard (＠julliard) 08 Nov '23

08 Nov '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4337

1 0

Re: [PATCH v2 0/1] MR4333: wininet: Use SecureZeroMemory() to clear magic fields. - approved
by Alexandre Julliard (＠julliard) 08 Nov '23

08 Nov '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4333

1 0

Re: [PATCH v2 0/1] MR4336: wsdapi: Use SecureZeroMemory() to clear magic fields. - approved
by Alexandre Julliard (＠julliard) 08 Nov '23

08 Nov '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4336

1 0

Re: [PATCH v2 0/1] MR4335: wintrust: Use SecureZeroMemory() to clear magic fields. - approved
by Alexandre Julliard (＠julliard) 08 Nov '23

08 Nov '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4335

1 0

Re: [PATCH v2 0/1] MR4334: winscard: Use SecureZeroMemory() to clear magic fields. - approved
by Alexandre Julliard (＠julliard) 08 Nov '23

08 Nov '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4334

1 0

Re: [PATCH v2 0/17] MR4332: Remove DECLSPEC_HIDDEN usage from various DLL's. - approved
by Alexandre Julliard (＠julliard) 08 Nov '23

08 Nov '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4332

1 0

Re: [PATCH v2 0/1] MR4330: gitlab: Enable d3d10core:d3d10core and d3d8:visual. - approved
by Alexandre Julliard (＠julliard) 08 Nov '23

08 Nov '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4330

1 0

Re: [PATCH v2 0/1] MR455: tests: Add more semantics to test_nop_tessellation_shaders(). - approved
by Alexandre Julliard (＠julliard) 08 Nov '23

08 Nov '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/455

1 0

Re: [PATCH v2 0/2] MR452: vkd3d-compiler: Minor tweaks to the usage text. - approved
by Alexandre Julliard (＠julliard) 08 Nov '23

08 Nov '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/452

1 0

Re: [PATCH v2 0/2] MR451: vkd3d: Report D3D12_FORMAT_SUPPORT2_UAV_TYPED_LOAD/STORE for UAV formats when supported. - approved
by Alexandre Julliard (＠julliard) 08 Nov '23

08 Nov '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/451

1 0

Re: [PATCH v6 0/8] MR417: vkd3d-shader/hlsl: Add ceil() function. - approved
by Alexandre Julliard (＠julliard) 08 Nov '23

08 Nov '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/417

1 0

Re: [PATCH v8 0/1] MR371: vkd3d-shader/hlsl: Implement ternary operator for SM1. - approved
by Alexandre Julliard (＠julliard) 08 Nov '23

08 Nov '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/371

1 0

Re: [PATCH v7 0/1] MR366: vkd3d-shader/hlsl: Add tex2Dlod() function. - approved
by Alexandre Julliard (＠julliard) 08 Nov '23

08 Nov '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/366

1 0

[PATCH 0/9] MR4338: dmime: Implement support for tempo in performance time computation.
by Rémi Bernon (＠rbernon) 08 Nov '23

08 Nov '23

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/4338

4 13

[PATCH v3 0/1] MR4342: mfplat/tests: Shut down the media source in test_create_from_file_handler_callback_Invoke().
by Zebediah Figura (＠zfigura) 08 Nov '23

08 Nov '23

-- v3: mfplat/tests: Shut down the media source in test_create_from_file_handler_callback_Invoke(). https://gitlab.winehq.org/wine/wine/-/merge_requests/4342

3 2

Re: [PATCH v2 0/1] MR4342: mfplat/tests: Shut down the media source in test_create_from_file_handler_callback_Invoke().
by Zebediah Figura (＠zfigura) 08 Nov '23

08 Nov '23

On Wed Nov 8 20:19:31 2023 +0000, Nikolay Sivov wrote: > Maybe check for MF_OBJECT_MEDIASOURCE instead? Sure. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4342#note_51568

1 0

[PATCH v14 0/2] MR4310: ntdll: Tweak the binary representation of SRWLOCK.
by Yuxuan Shui (＠yshui) 08 Nov '23

08 Nov '23

There are applications that uses SRWLOCK in an invalid way and then checks its binary representation. ~~Specifically they releases an unlocked SRWLOCK then check its bit pattern is all-ones.~~ Tweak the representation a bit so they are happy. -- v14: ntdll: Tweak the binary representation of SRWLOCK. https://gitlab.winehq.org/wine/wine/-/merge_requests/4310

3 4

[PATCH v2 0/2] MR4313: MSVCRT _(w)environ[] has a separate allocation chunk for each entry.
by eric pouech (＠epo) 08 Nov '23

08 Nov '23

_(w)environ[] do have a distinct allocation chunk for each entry, so that _(w)environ[i] pointer and (pointed) string don't change when updating/deleting any other entry. Proposed implementation still differs from native: - allocation is done on process heap, while native uses msvcrt's heap - first ANSI allocated _environ[] doesn't have per entry allocation. This is only activated after a change (update/deletion) to _environ[] is made. -- v2: msvcrt: Let each _environ[] entry have a distinct allocation block. msvcrt: Add test about _environ[] entries allocation. https://gitlab.winehq.org/wine/wine/-/merge_requests/4313

4 13

Re: [PATCH v2 0/1] MR4342: mfplat/tests: Shut down the media source in test_create_from_file_handler_callback_Invoke().
by Nikolay Sivov (＠nsivov) 08 Nov '23

08 Nov '23

Nikolay Sivov (@nsivov) commented about dlls/mfplat/tests/mfplat.c: > > hr = IMFSchemeHandler_EndCreateObject(handler, result, &obj_type, &object); > ok(hr == S_OK, "Failed to create an object, hr %#lx.\n", hr); > + todo_wine ok(obj_type == MF_OBJECT_BYTESTREAM, "Got object type %#x.\n", obj_type); > > - if (SUCCEEDED(hr)) > + hr = IMFAsyncResult_GetObject(result, (IUnknown **)&object2); > + ok(hr == E_POINTER, "Unexpected hr %#lx.\n", hr); > + > + if (obj_type != MF_OBJECT_BYTESTREAM) Maybe check for MF_OBJECT_MEDIASOURCE instead? -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4342#note_51565

1 0

[PATCH 0/1] MR4283: wmvcore: Use CRT allocation functions.
by Alex Henrie (＠alexhenrie) 08 Nov '23

08 Nov '23

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/4283

3 2

[PATCH 0/1] MR4264: devenum: Use CRT allocation functions.
by Alex Henrie (＠alexhenrie) 08 Nov '23

08 Nov '23

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/4264

3 2

[PATCH v2 0/1] MR4306: rpcrt4/tests: Use CRT allocation functions.
by Alex Henrie (＠alexhenrie) 08 Nov '23

08 Nov '23

-- v2: rpcrt4/tests: Use CRT allocation functions. https://gitlab.winehq.org/wine/wine/-/merge_requests/4306

4 3

[PATCH 0/1] MR4342: mfplat/tests: Shut down the media source in test_create_from_file_handler_callback_Invoke().
by Zebediah Figura (＠zfigura) 08 Nov '23

08 Nov '23

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/4342

2 1

[PATCH 0/2] MR4316: winegstreamer: Implement wg_muxer_push_sample.
by Ziqing Hui (＠zhui) 08 Nov '23

08 Nov '23

This MR is split from !3810. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4316

4 4

[PATCH 0/2] MR4328: ntdll: Don't allocate vprot entries until commit.
by Evan Tang (＠etang-cw) 08 Nov '23

08 Nov '23

Prevents applications that accidentally attempt to allocate massive amounts of memory from getting OOM killed (An example of such an application is EverQuest's DX11 beta, which has some corrupted asset files that result in it trying to allocate ~18TB of memory) BTW, is it okay to have a test that's likely to get OOM killed on a failing implementation? If not, any recommendations on how else to test this? -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4328

4 7

[PATCH v2 0/7] MR4341: msvcrt: Add implementation of more localized functions
by Bartosz Kosiorek (＠gang65) 08 Nov '23

08 Nov '23

-- v2: msvcrt: Add _mblen_l implementation. msvcrt: Add _mbsset_l implementation. msvcrt: Add _mbsrev_l implementation. msvcrt: Add _mbsncmp_l implementation. msvcrt: Add __iswcsymf implementation. msvcrt: Add __iswcsym implementation. msvcrt: Add _mbspbrk_l implementation. https://gitlab.winehq.org/wine/wine/-/merge_requests/4341

2 8

Re: [PATCH v2 0/7] MR454: hlsl: Improve function type matching a bit.
by Zebediah Figura (＠zfigura) 08 Nov '23

08 Nov '23

> I don't understand why a CI job failed. Could you please run it again? (there is a button to this end in https://gitlab.winehq.org/zfigura/vkd3d/-/jobs/36538, if your logged in GitLab) Done; looks like it passes now. -- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/454#note_51547

1 0

[PATCH v3 0/4] MR4313: MSVCRT _(w)environ[] has a separate allocation chunk for each entry.
by eric pouech (＠epo) 08 Nov '23

08 Nov '23

_(w)environ[] do have a distinct allocation chunk for each entry, so that _(w)environ[i] pointer and (pointed) string don't change when updating/deleting any other entry. Proposed implementation still differs from native: - allocation is done on process heap, while native uses msvcrt's heap - first ANSI allocated _environ[] doesn't have per entry allocation. This is only activated after a change (update/deletion) to _environ[] is made. -- v3: msvcrt: Let each _environ[] entry have a distinct allocation block. msvcrt/tests: Add tests about intricating kernel32 and msvcrt env calls. msvcrt/tests: Add tests about allocation of environment entries. msvcrt: Improve environment tests (initial conditions). https://gitlab.winehq.org/wine/wine/-/merge_requests/4313

3 12

[PATCH v3 0/1] MR333: vkd3d-shader/hlsl: Add refract() function.
by Nikolay Sivov (＠nsivov) 08 Nov '23

08 Nov '23

Signed-off-by: Nikolay Sivov <nsivov(a)codeweavers.com> -- v3: vkd3d-shader/hlsl: Add refract() function. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/333

3 3

[PATCH 0/7] MR4341: M
by Bartosz Kosiorek (＠gang65) 08 Nov '23

08 Nov '23

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/4341

3 11

[PATCH 0/1] MR455: tests: Add more semantics to test_nop_tessellation_shaders().
by Zebediah Figura (＠zfigura) 08 Nov '23

08 Nov '23

-- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/455

4 3

[PATCH 0/2] MR452: vkd3d-compiler: Minor tweaks to the usage text.
by Henri Verbeet (＠hverbeet) 08 Nov '23

08 Nov '23

-- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/452

3 4

[PATCH 0/2] MR451: vkd3d: Report D3D12_FORMAT_SUPPORT2_UAV_TYPED_LOAD/STORE for UAV formats when supported.
by Henri Verbeet (＠hverbeet) 08 Nov '23

08 Nov '23

-- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/451

3 4

[PATCH v5 0/8] MR417: vkd3d-shader/hlsl: Add ceil() function.
by Nikolay Sivov (＠nsivov) 08 Nov '23

08 Nov '23

Signed-off-by: Nikolay Sivov <nsivov(a)codeweavers.com> -- v5: vkd3d-shader: Add constant folding for 'floor'. vkd3d-shader: Add a missing entry to instruction debug print helper. vkd3d-shader: Add constant folding for 'ceil'. vkd3d-shader: Add support for floor() on SM1-3. vkd3d-shader: Add support for ceil() on SM1-3. vkd3d-shader/tpf: Add support for ceil(). vkd3d-shader/hlsl: Parse ceil() function. tests: Add some tests for ceil(). https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/417

4 10

[PATCH v7 0/1] MR371: vkd3d-shader/hlsl: Implement ternary operator for SM1.
by Nikolay Sivov (＠nsivov) 08 Nov '23

08 Nov '23

This is correct for pixel shaders, vertex shaders do not have 'cmp'. -- v7: vkd3d-shader/hlsl: Implement ternary operator for SM1. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/371

4 3

[PATCH v6 0/1] MR366: vkd3d-shader/hlsl: Add tex2Dlod() function.
by Nikolay Sivov (＠nsivov) 08 Nov '23

08 Nov '23

Signed-off-by: Nikolay Sivov <nsivov(a)codeweavers.com> -- v6: vkd3d-shader/hlsl: Add tex2Dlod() function. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/366

4 5

[PATCH 0/1] MR4333: wininet: Use SecureZeroMemory() to clear magic fields.
by eric pouech (＠epo) 08 Nov '23

08 Nov '23

Signed-off-by: Eric Pouech <epouech(a)codeweavers.com> -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4333

3 2

Re: [PATCH v2 0/7] MR454: hlsl: Improve function type matching a bit. - approved
by Giovanni Mascellani (＠giomasce) 08 Nov '23

08 Nov '23

This merge request was approved by Giovanni Mascellani. -- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/454

1 0

[PATCH v6 0/6] MR4140: uxtheme/tests: Add some tests for OpenThemeData() with various app/class names.
by Dmitry Timoshkov (＠dmitry) 08 Nov '23

08 Nov '23

Themed Delphi applications use "explorer::listview" and "explorer::treeview": https://gitlab.com/freepascal.org/lazarus/lazarus/-/blob/main/lcl/interface… -- v6: uxtheme: If the application class is already set then OpenThemeData() should fail. uxtheme: Move fall back to default class to MSSTYLES_OpenThemeClass(). uxtheme/tests: Add a test for SetWindowTheme/OpenThemeData sequence. uxtheme: Parse app/class name in OpenThemeData(). uxtheme/tests: Add a test for OpenThemeData("explorer::treeview"). uxtheme/tests: Move the IsThemePartDefined() test before hTheme handle is closed. https://gitlab.winehq.org/wine/wine/-/merge_requests/4140

4 11

Re: [PATCH v2 0/7] MR454: hlsl: Improve function type matching a bit.
by Giovanni Mascellani (＠giomasce) 08 Nov '23

08 Nov '23

I don't understand why a CI job failed. Could you please run it again? (there is a button to this end in https://gitlab.winehq.org/zfigura/vkd3d/-/jobs/36538, if your logged in GitLab) -- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/454#note_51503

1 0

[PATCH v8 0/4] MR219: vkd3d-shader: Implement tex2Dproj().
by Nikolay Sivov (＠nsivov) 08 Nov '23

08 Nov '23

-- v8: vkd3d-shader/hlsl: Implement texCUBEproj(). vkd3d-shader/hlsl: Implement tex3Dproj(). vkd3d-shader/hlsl: Implement tex1Dproj(). vkd3d-shader/hlsl: Implement tex2Dproj(). https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/219

4 6

[PATCH v4 0/4] MR450: vkd3d-shader/ir: Flatten structured control flow instructions.
by Conor McCarthy (＠cmccarthy) 08 Nov '23

08 Nov '23

-- v4: vkd3d-shader/ir: Store code block names in struct vkd3d_shader_desc. vkd3d-shader/ir: Flatten structured control flow instructions. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/450

3 9

[PATCH 0/1] MR4002: oleaut32: Fix typelib cache race condition.
by Connor McAdams (＠cmcadams) 08 Nov '23

08 Nov '23

This fixes the following issue: - Thread X holds the typelib cache list CS, and is iterating through the list. - Thread Y calls Release on the typelib interface, reference count hits 0, it's waiting for the cache list CS to remove this typelib. - Thread X finds the typelib in the cache list, returns it, exits the CS. - Thread Y enters now the CS, removes the typelib from the cache list, and proceeds to free all of the resources associated with the typelib. - Thread X tries to use the typelib, use after free. The method used here to prevent incrementing the reference count is borrowed from MR !2752. An alternative could be to decouple the actual typelib data from the `ITypeLib2` interface itself, e.g what gets stored into the typelib cache is just the data for the typelib, which would have its own private reference count locked behind the cache list CS. When the public `ITypeLib2` interface's reference count hits 0, it'd lock the typelib cache list CS, decrement the private reference count, and if the private reference count is 0 remove it from the list. The alternative method would require major restructuring of the code, which is why I'd prefer to use the one in this MR. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4002

5 6

[PATCH v3 0/7] MR4339: dmsynth, dmloader: Fix memory leaks.
by Anton Baskanov (＠baskanov) 08 Nov '23

08 Nov '23

-- v3: dmloader: Mark cached objects as loaded. dmsynth: Don't leak modulators. dmsynth: Free the allocated presets manually. https://gitlab.winehq.org/wine/wine/-/merge_requests/4339

3 13

[PATCH v2 0/1] MR333: vkd3d-shader/hlsl: Add refract() function.
by Nikolay Sivov (＠nsivov) 08 Nov '23

08 Nov '23

Signed-off-by: Nikolay Sivov <nsivov(a)codeweavers.com> -- v2: vkd3d-shader/hlsl: Add refract() function. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/333

3 5

[PATCH 0/7] MR4339: dmsynth, dmloader: Fix memory leaks.
by Anton Baskanov (＠baskanov) 08 Nov '23

08 Nov '23

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/4339

2 7

[PATCH 0/1] MR4337: msdasql: IColumnsRowset::GetAvailableColumns return 3 meta columns to allow updating of a row.
by Alistair Leslie-Hughes (＠alesliehughes) 08 Nov '23

08 Nov '23

Native returns 19 rows of all features it supports. However as a start, only these three are required to supported a row. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4337

2 1

[PATCH 0/1] MR4336: wsdapi: Use SecureZeroMemory() to clear magic fields.
by eric pouech (＠epo) 08 Nov '23

08 Nov '23

Signed-off-by: Eric Pouech <epouech(a)codeweavers.com> -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4336

2 1

[PATCH 0/1] MR4335: wintrust: Use SecureZeroMemory() to clear magic fields.
by eric pouech (＠epo) 08 Nov '23

08 Nov '23

Signed-off-by: Eric Pouech <epouech(a)codeweavers.com> -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4335

2 1

[PATCH 0/1] MR4334: winscard: Use SecureZeroMemory() to clear magic fields.
by eric pouech (＠epo) 08 Nov '23

08 Nov '23

Signed-off-by: Eric Pouech <epouech(a)codeweavers.com> -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4334

2 1

Re: [PATCH v2 0/1] MR4233: winmm: Fix pszSound allocation in PlaySound_Alloc().
by Huw Davies (＠huw) 08 Nov '23

08 Nov '23

Huw Davies (@huw) commented about dlls/winmm/playsound.c: > else > { > UNICODE_STRING usBuffer; > - RtlCreateUnicodeStringFromAsciiz(&usBuffer, pszSound); > - wps->pszSound = usBuffer.Buffer; > + if (!RtlCreateUnicodeStringFromAsciiz(&usBuffer, pszSound)) goto oom_error; > + wps->pszSound = wcsdup(usBuffer.Buffer); > + HeapFree(GetProcessHeap(), 0, usBuffer.Buffer); ```suggestion:-0+0 RtlFreeUnicodeString(&usBuffer); ``` -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4233#note_51460

1 0

[PATCH v2 0/3] MR3839: kernel32: Add structure size checks to CreateActCtx().
by Dmitry Timoshkov (＠dmitry) 08 Nov '23

08 Nov '23

Signed-off-by: Dmitry Timoshkov <dmitry(a)baikal.ru> -- v2: ntdll: Add ACTCTX field limit checks to RtlCreateActivationContext(). kernel32: Add ACTCTX field limit checks to CreateActCtxA(). kernel32/tests: Add some tests for CreateActCtx() with different structure sizes. https://gitlab.winehq.org/wine/wine/-/merge_requests/3839

3 7

[PATCH 0/17] MR4332: Remove DECLSPEC_HIDDEN usage from various DLL's.
by Alistair Leslie-Hughes (＠alesliehughes) 08 Nov '23

08 Nov '23

-- This merge request has too many patches to be relayed via email. Please visit the URL below to see the contents of the merge request. https://gitlab.winehq.org/wine/wine/-/merge_requests/4332

1 0

[PATCH v3 0/4] MR450: vkd3d-shader/ir: Flatten structured control flow instructions.
by Conor McCarthy (＠cmccarthy) 08 Nov '23

08 Nov '23

-- v3: vkd3d-shader/ir: Store code block names in struct vkd3d_shader_desc. vkd3d-shader/ir: Flatten structured control flow instructions. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/450

2 4

[PATCH v2 0/4] MR450: Draft: vkd3d-shader/ir: Flatten structured control flow instructions.
by Conor McCarthy (＠cmccarthy) 08 Nov '23

08 Nov '23

-- v2: vkd3d-shader/ir: Store code block names in struct vkd3d_shader_desc. vkd3d-shader/ir: Flatten structured control flow instructions. vkd3d-shader: Rename shader_instruction_array_add_icb() to shader_instruction_array_add_opaque_param(). vkd3d-shader/spirv: Emit descriptor offset loads in the function entry block. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/450

2 6

[PATCH 0/1] MR4330: gitlab: Enable d3d10core:d3d10core and d3d8:visual.
by Zebediah Figura (＠zfigura) 08 Nov '23

08 Nov '23

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/4330

2 1

[PATCH 0/7] MR454: hlsl: Improve function type matching a bit.
by Zebediah Figura (＠zfigura) 08 Nov '23

08 Nov '23

-- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/454

2 7

[PATCH v7 0/8] MR436: vkd3d-shader/dxil: Implement the DXIL CAST instruction.
by Conor McCarthy (＠cmccarthy) 08 Nov '23

08 Nov '23

-- v7: vkd3d-shader/dxil: Implement the DXIL CAST instruction. vkd3d-shader/spirv: Support double in spirv_compiler_emit_ftou(). vkd3d-shader/spirv: Support double in spirv_compiler_emit_ftoi(). vkd3d-shader/spirv: Handle unsigned result in spirv_compiler_emit_ftoi(). vkd3d-shader/spirv: Introduce integer width cast instructions. vkd3d-shader/spirv: Support bool cast in spirv_compiler_emit_alu_instruction(). vkd3d-shader/spirv: Support bool logic ops in spirv_compiler_emit_alu_instruction(). vkd3d-shader/spirv: Support bitcast in spirv_compiler_emit_load_ssa_reg(). https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/436

4 23

[PATCH 0/5] MR453: vkd3d-shader: Miscellaneous I/O patches.
by Zebediah Figura (＠zfigura) 08 Nov '23

08 Nov '23

More preparation for declaring I/O from the signature. -- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/453

2 5

[PATCH 0/1] MR4329: ntdll/unix: Replace sprintf with snprintf to avoid deprecation warnings on macOS.
by Brendan Shanks (＠bshanks) 07 Nov '23

07 Nov '23

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/4329

2 1

Re: [PATCH v2 0/5] MR4324: dmime: Implement segment chunked play. - approved
by Alexandre Julliard (＠julliard) 07 Nov '23

07 Nov '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4324

1 0

Re: [PATCH v3 0/1] MR4327: user32: Use SecureZeroMemory to clear magic fields. - approved
by Alexandre Julliard (＠julliard) 07 Nov '23

07 Nov '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4327

1 0

Re: [PATCH v3 0/1] MR4326: secure32: Use SecureZeroMemory to clear magic fields. - approved
by Alexandre Julliard (＠julliard) 07 Nov '23

07 Nov '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4326

1 0

Re: [PATCH v3 0/1] MR4325: dssenh: Use SecureZeroMemory to clear magic fields. - approved
by Alexandre Julliard (＠julliard) 07 Nov '23

07 Nov '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4325

1 0

Re: [PATCH v4 0/1] MR4323: pdh: Introduce memory barrier in destroy operations. - approved
by Alexandre Julliard (＠julliard) 07 Nov '23

07 Nov '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4323

1 0

Re: [PATCH v3 0/5] MR4173: wined3d/glsl: Handle out-of-bounds vlaues in ftoi/ftou. - approved
by Alexandre Julliard (＠julliard) 07 Nov '23

07 Nov '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4173

1 0

Re: [PATCH v3 0/7] MR4315: msvcrt: Add implementation of localized functions - approved
by Alexandre Julliard (＠julliard) 07 Nov '23

07 Nov '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4315

1 0

Re: [PATCH v2 0/1] MR4295: ddrawex: Use CRT allocation functions. - approved
by Alexandre Julliard (＠julliard) 07 Nov '23

07 Nov '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4295

1 0

Re: [PATCH v2 0/1] MR4303: urlmon/tests: Use CRT allocation functions. - approved
by Alexandre Julliard (＠julliard) 07 Nov '23

07 Nov '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4303

1 0

Re: [PATCH v2 0/1] MR4321: shdocvw: Use CRT allocation functions. - approved
by Alexandre Julliard (＠julliard) 07 Nov '23

07 Nov '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4321

1 0

Re: [PATCH v3 0/5] MR4057: wined3d: Translate sampler states to sampler objects in wined3d_device_apply_stateblock(). - approved
by Alexandre Julliard (＠julliard) 07 Nov '23

07 Nov '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4057

1 0

Re: [PATCH v2 0/1] MR4314: kernelbase: Don't inherit all the handles in conhost.exe. - approved
by Alexandre Julliard (＠julliard) 07 Nov '23

07 Nov '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4314

1 0

Re: [PATCH v2 0/1] MR4322: po: Update Lithuanian translation. - approved
by Alexandre Julliard (＠julliard) 07 Nov '23

07 Nov '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4322

1 0

Re: [PATCH v2 0/7] MR4194: d3d*/tests: Fix various d3d tests on AMD Windows. - approved
by Alexandre Julliard (＠julliard) 07 Nov '23

07 Nov '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4194

1 0

Re: [PATCH v2 0/1] MR4223: wined3d: Add entry info for NVidia RTX 3070. - approved
by Alexandre Julliard (＠julliard) 07 Nov '23

07 Nov '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4223

1 0

Re: [PATCH v2 0/4] MR4286: D3D: -Wenum-conversion fixes - approved
by Alexandre Julliard (＠julliard) 07 Nov '23

07 Nov '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4286

1 0

Re: [PATCH v2 0/1] MR4320: winecoreaudio: Remove unused heap.h include. - approved
by Alexandre Julliard (＠julliard) 07 Nov '23

07 Nov '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4320

1 0

Re: [PATCH v2 0/1] MR4318: windows.media.devices: Use CRT allocation functions. - approved
by Alexandre Julliard (＠julliard) 07 Nov '23

07 Nov '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4318

1 0

Re: [PATCH v2 0/1] MR4317: msiexec: Use CRT allocation functions. - approved
by Alexandre Julliard (＠julliard) 07 Nov '23

07 Nov '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4317

1 0

[PATCH 0/5] MR4324: dmime: Implement segment chunked play.
by Rémi Bernon (＠rbernon) 07 Nov '23

07 Nov '23

Will make it behave more like native for the tests, and avoid queueing every single message from every track on start (which may be large). -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4324

4 10

Re: [PATCH v2 0/1] MR446: vkd3d-shader/ir: Synthesize HS inputs with the register index and write mask of the signature element. - approved
by Alexandre Julliard (＠julliard) 07 Nov '23

07 Nov '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/446

1 0

Re: [PATCH v4 0/3] MR439: spirv: Use register sizes from the shader signature instead of the DCL instruction. - approved
by Alexandre Julliard (＠julliard) 07 Nov '23

07 Nov '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/439

1 0

Re: [PATCH v2 0/1] MR449: ci: Expect builds to always succeed, even when tests are allowed to fail. - approved
by Alexandre Julliard (＠julliard) 07 Nov '23

07 Nov '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/449

1 0

Re: [PATCH v2 0/2] MR448: hlsl: Properly handle allocation ranges that aren't aligned to a whole register. - approved
by Alexandre Julliard (＠julliard) 07 Nov '23

07 Nov '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/448

1 0

Re: [PATCH v3 0/6] MR444: vkd3d-shader/ir: Check that blocks are correctly nested. - approved
by Alexandre Julliard (＠julliard) 07 Nov '23

07 Nov '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/444

1 0

Re: [PATCH v7 0/7] MR435: vkd3d-shader/tpf: Support non-constant offset dereferences, v2, part 2. - approved
by Alexandre Julliard (＠julliard) 07 Nov '23

07 Nov '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/435

1 0

[PATCH 0/3] MR450: Draft: vkd3d-shader/ir: Flatten structured control flow instructions.
by Conor McCarthy (＠cmccarthy) 07 Nov '23

07 Nov '23

-- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/450

3 5

Re: [PATCH v9 0/5] MR409: vkd3d-shader/dxil: Implement the DXIL BINOP instruction.
by Henri Verbeet (＠hverbeet) 07 Nov '23

07 Nov '23

> > Sure. I think the main alternative would be to split the IR in two (or more) separate IRs though. I.e., you'd have a representation of the parsed TPF, then convert that to VSIR, and from there to SPIR-V. > > The alternative I was considering would rather be to have only one IR, and use it for all shader language conversions, but not for disassembling. And then, for each language for which we support disassembling, have a dedicated disassembler (which probably doesn't really need an IR: it can emit as it parses). If we supported assembling too, we'd also have a dedicated assembler. Well, we could debate at which point something gets to be called an "IR", but essentially, we'd need to have some function that would e.g. parse TPF bytecode, and return something that might be called a "struct tpf_instruction". We'd then pass that to either the disassembler, or something that translates it to vsir. The main point is that we wouldn't be able to parse directly into vsir structures, unless we'd duplicate the parsing code for the disassembler. > In my mind, assembling/disassembling and compiling (or transpiling, if we want to look more modern!) are two different beasts. For compiling it's useful to have an IR which is flexible and simple, but it doesn't need to faithfully represent precisely all the features of any other language. OTOH for assembling/disassembling you don't really care about flexibility, but it's important to represent faithfully every detail of the language. > > My feeling is that trying to shove all these features (simplicity, flexibility, faithfullness to any language) on a single language is a bit overconstraining. Write dedicated assemblers and disassemblers is some additional work too, but I'm not sure the balance is in favor of our solution. I tend to think it is, but I could certainly imagine different people striking different balances. I suppose the good news is that it's relatively easy to have a go at giving it a try. My guess is that we'd end up duplicating most of the vsir structures, duplicate most of the disassembler, introduce extra tpf->vsir and vsir->tpf passes, and then would be able to remove some fields and enum elements from the vsir data structures. It's entirely possible that I'm underestimating the benefits though. And sure, I can see the appeal of having a more restricted/pure IR, having stronger separation between d3dbc/tpf/dxil/spirv/etc.; the practical benefits aren't quite as clear to me though. > > The disassembler would operate on TPF IR, as would certain lowering passes. That's certainly a valid choice, but I think it's important to point out that while it would make some thing easier, it would also make some things harder. The most obvious is perhaps that we'd need separate disassemblers for d3dbc, tpf, dxil, and vsir. Somewhat less obvious is perhaps that we may need to duplicate certain lowering passes between e.g. d3dbc and tpf, because we'd no longer be able to express them in vsir. It may also make it slightly harder to do something like HLSL IR -> vsir -> d3dbc, because we'd have to get rid of complex texturing instructions when converting HLSL IR to vsir, and then reintroduce them when converting vsir to d3dbc. > > If VSIR features are useful for translating between languages, then I agree it's sensible to have then. The part I don't like is having features only because some of the languages we support need to faithfully represent all their features (e.g., having to keep operations like NEG and ABS as register modifiers instead of as regular operators). Note that NEG and ABS modifiers aren't only used by the disassembler though; we also use these when writing output for the HLSL compiler. And sure, there are other ways to handle that as well, but as far as I can see they'd all be variants of "introduce struct tpf_instruction". > > We may want to tweak the vkd3d_shader_instruction_array data structure somewhat, but I don't think we'll need to do anything as drastic as converting the instruction array to a linked list; gap buffers tend to handle this kind of thing fairly well, and we may even be able to improve on that in specific instances. > > I don't know much about gap buffers, but after some reading on Wikipedia I'm not convinced. It seems that a gap buffers makes sense when you have a concept of a cursor that mostly moves locally, while our passes usually scan the whole program each time. With a gap buffer you would end up copying the whole program each time, and by that token you could directly rewrite it in a new array each time. I think that's a misunderstanding; the amount of data you'd move would only be the difference between the previous insertion position and the new insertion position. I.e., if you start with a sufficiently large gap at the front of the buffer, and move through the instructions from first to last, you'll move at most a single copy of the entire program in the worst case, and likely a fair bit less in typical cases. > Also, random insertion with gap buffers seems to be comparable to arrays. Random insertion should be rare though(!); the more typical case would be to go through the instructions from first to last, or possibly from last to first. > Following some link on Wikipedia, a [rope](https://en.wikipedia.org/wiki/Rope_\(data_structure\)) might be a better match for us, being essentially a compromise between an array and a link-based structure. Yeah, I'm aware of ropes. It doesn't seem obvious to me that they'd be better suited for our purposes, but ultimately I think this is one of those things where you start with the naive implementation, and then see whether making it more complicated makes it better. -- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/409#note_51376

1 0

[PATCH 0/1] MR446: vkd3d-shader/ir: Synthesize HS inputs with the register index and write mask of the signature element.
by Zebediah Figura (＠zfigura) 07 Nov '23

07 Nov '23

-- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/446

4 5

[PATCH v3 0/3] MR439: spirv: Use register sizes from the shader signature instead of the DCL instruction.
by Zebediah Figura (＠zfigura) 07 Nov '23

07 Nov '23

More preparatory work to declare I/O variables from the signature. -- v3: vkd3d-shader/spirv: Use register counts from the signature and shader desc. vkd3d-shader: Store the control point counts in struct vkd3d_shader_desc. vkd3d-shader/spirv: Use the array sizes for shader phase builtins as well. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/439

3 4

[PATCH v6 0/7] MR443: tests: Add some tests for effects groups syntax.
by Nikolay Sivov (＠nsivov) 07 Nov '23

07 Nov '23

Signed-off-by: Nikolay Sivov <nsivov(a)codeweavers.com> -- v6: vkd3d-shader/tpf: Initial support for writing fx_4_0/fx_4_1 binaries. vkd3d-shader: Add separate binary target type for effects. vkd3d-shader/hlsl: Handle effect group statement. vkd3d-shader/hlsl: Add variables for techniques. vkd3d-shader/hlsl: Rename rule for top-level techniques. vkd3d-shader/hlsl: Add 'fxgroup' token. tests: Add some tests for effects groups syntax. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/443

2 7

[PATCH 0/1] MR333: vkd3d-shader/hlsl: Add refract() function.
by Nikolay Sivov (＠nsivov) 07 Nov '23

07 Nov '23

Signed-off-by: Nikolay Sivov <nsivov(a)codeweavers.com> -- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/333

4 10

[PATCH v2 0/1] MR234: vkd3d-shader/hlsl: Partially implement Load() for the Buffer object.
by Nikolay Sivov (＠nsivov) 07 Nov '23

07 Nov '23

-- v2: vkd3d-shader/hlsl: Partially implement Load() for the Buffer object. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/234

5 5

[PATCH 0/1] MR449: ci: Expect builds to always succeed, even when tests are allowed to fail.
by Giovanni Mascellani (＠giomasce) 07 Nov '23

07 Nov '23

If the build fail some artifact files might not exist, and we don't want the script to fail just because of that. -- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/449

3 3

[PATCH 0/2] MR448: hlsl: Properly handle allocation ranges that aren't aligned to a whole register.
by Zebediah Figura (＠zfigura) 07 Nov '23

07 Nov '23

-- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/448

4 4

[PATCH v2 0/6] MR444: vkd3d-shader/ir: Check that blocks are correctly nested.
by Giovanni Mascellani (＠giomasce) 07 Nov '23

07 Nov '23

-- v2: vkd3d-shader/ir: Check that SWITCH blocks are correctly nested. vkd3d-shader/ir: Check that REP blocks are correctly nested. vkd3d-shader/ir: Check that LOOP blocks are correctly nested. vkd3d-shader/ir: Check that IF blocks are correctly nested. vkd3d-shader/ir: Do not enfore DCL_TEMPS count for hull shaders. vkd3d-shader/ir: Emit an ERR() on validation errors. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/444

3 9

2025

2024

2023

2022

wine-gitlab