- wine-gitlab - winehq.org

[PATCH 0/1] MR4157: cmd: Reset totals after trailer output.
by Akihiro Sagawa (＠sgwaki) 23 Oct '23

23 Oct '23

Otherwise, sums are inherited between drives. For instance, dir /s z:\tmp c:\windows\system32\drivers\etc shows an incorrect summary for drive c. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4157

2 1

Re: [PATCH 0/1] MR277: cmd: Handle lines with just spaces in bracket blocks.
by userid0x0 (＠userid0x0) 23 Oct '23

23 Oct '23

Hi, I just trapped into the same `whitespace` problem. Is there a plan to solve the issue? Another question - is it a valid workaround to ensure there are no `whitespace only` lines in the bat file? -- https://gitlab.winehq.org/wine/wine/-/merge_requests/277#note_49569

1 0

[PATCH v3 0/2] MR2383: shell32: Avoid stack corruption caused by long URLs
by Stefan Rentsch (＠restet) 22 Oct '23

22 Oct '23

Previously long URI/URLs (> 1024 characters) would cause a stack corruption and crash Wine. After this MR, Wine will no longer crash but the URL is not opened either primarily due to `SHELL_Argify` limitations. -- v3: shell32: Increase timeout for long URLs https://gitlab.winehq.org/wine/wine/-/merge_requests/2383

3 5

Re: [PATCH v2 0/1] MR4143: uxtheme: Add ShouldAppsUseDarkMode.
by Louis Lenders (＠xe) 22 Oct '23

22 Oct '23

Sorry, i can't get this to work. Maybe i messed something up in between. now got: hint: Updates were rejected because the tip of your current branch is behind hint: its remote counterpart. Integrate the remote changes (e.g. hint: 'git pull ...') before pushing again. hint: See the 'Note about fast-forwards' in 'git push --help' for details. Sigh.... -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4143#note_49564

1 0

Re: [PATCH v2 0/1] MR4143: uxtheme: Add ShouldAppsUseDarkMode.
by Zhiyi Zhang (＠zhiyi) 22 Oct '23

22 Oct '23

On Sun Oct 22 10:43:26 2023 +0000, Louis Lenders wrote: > >and a Wine-Bug: link in the commit message. > How do I do that? You can do 'git commit --amend', write 'Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=55742' on the third line. Save. Then 'git push -f' on the same branch. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4143#note_49563

1 0

[PATCH 0/4] MR424: tests: Introduce a stress tester for vkd3d-shader.
by Giovanni Mascellani (＠giomasce) 21 Oct '23

21 Oct '23

-- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/424

2 5

Re: [PATCH v2 0/2] MR4108: Improve DMI tables under Linux.
by Hans Leidekker (＠hans) 21 Oct '23

21 Oct '23

> Yeah, but this isn't necessarily about not trusting Windows apps, i.e. malice or malware, but rather that they can't be designed around it (since they assume Windows environment), so they would have privacy issues without even wanting to. At the very least maybe use Of course Windows apps can be designed around it. In the Windows environment they'd retrieve a real hardware ID that should be handled with the same care. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4108#note_49556

1 0

[PATCH 0/1] MR4152: dnsapi: Handle IP address as DNS name in DnsQuery_UTF8().
by Paul Gofman (＠gofman) 21 Oct '23

21 Oct '23

Fixes Tekken 8 (early access) being unable to find other players for match. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4152

3 4

Re: [PATCH v2 0/2] MR4108: Improve DMI tables under Linux.
by Paul Gofman (＠gofman) 21 Oct '23

21 Oct '23

On Sat Oct 21 10:27:59 2023 +0000, Jinoh Kang wrote: > Okay, I've read the prior discussions regarding the rationale. > Still, I don't think you should change the System UUID for *existing* > prefixes. Perhaps we could use the registry to detect whether the > prefix is new, and use the new algorithm for new prefixes. We could > also record the UUID in the registry "permanently." Maintaining any way of backward compat on this ID doesn't look feasible. E. g., the current way with a bug reports bios hashtag in serial field on my desktop due to missing fields not being handled. This ID is already non-unique, and maintaining these algorithms backwards would take unreasonable amount of effort (with arguably no gains). Probably more important, /etc/machine-id can be changed anytime by user or system resintall, it is not true hardware id. If anything firmly relies on HW id to persist forever, it is broken already. Regarding the original discussion, I also don't really understand why we should necessarily obfuscate /etc/machine-id for uuid / serial reporting. App has access to the file anyway, and Wine neither sends the ID anywhere nor tracks the user, it is between the app and the user. On Windows fwiw it will get real motherboard serial and other information like that. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4108#note_49550

1 0

[PATCH 0/1] MR4156: ntdll/tests: Use win_skip() for missing APIs in test_query_process_debug_port_custom_dacl.
by Jinoh Kang (＠iamahuman) 21 Oct '23

21 Oct '23

A missing API is a todo in Wine. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4156

2 1

Re: [PATCH v2 0/2] MR4108: Improve DMI tables under Linux.
by Jinoh Kang (＠iamahuman) 21 Oct '23

21 Oct '23

On Sat Oct 21 10:25:18 2023 +0000, Jinoh Kang wrote: > This changes the system GUID. Some DRMs and copy protections like to > assume that things like System UUIDs are permanent and never change. > Changing this will break such apps and the user might have to > reinstall/re-purchase them again. Okay, I've read the prior discussions regarding the rationale. Still, I don't think you should change the System UUID for *existing* prefixes. Perhaps we could use the registry to detect whether the prefix is new, and use the new algorithm for new prefixes. We could also record the UUID in the registry "permanently." -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4108#note_49548

1 0

Re: [PATCH v2 0/2] MR4108: Improve DMI tables under Linux.
by Jinoh Kang (＠iamahuman) 21 Oct '23

21 Oct '23

Jinoh Kang (@iamahuman) commented about dlls/ntdll/unix/system.c: > system_args.version = system_version; > system_args.serial_len = get_smbios_string("/sys/class/dmi/id/product_serial", S(system_serial)); > system_args.serial = system_serial; > - get_system_uuid(&system_args.uuid); > + derive_machineid_to_uuid(&system_args.uuid); This changes the system GUID. Some DRMs and copy protections like to assume that things like System UUIDs are permanent and never change. Changing this will break such apps and the user might have to reinstall/re-purchase them again. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4108#note_49547

1 0

Re: [PATCH v2 0/2] MR4108: Improve DMI tables under Linux.
by Jinoh Kang (＠iamahuman) 21 Oct '23

21 Oct '23

Jinoh Kang (@iamahuman) commented about dlls/ntdll/unix/system.c: > close( fd ); > } > } > > +static void derive_machineid_to_uuid( GUID *uuid ) > +{ > + static unsigned char wine_uuid[16] = { 0xe8, 0x65, 0x52, 0x8d, 0x0a, 0xa2, 0x45, 0x27, > + 0xa8, 0x3b, 0x15, 0xed, 0x41, 0xb5, 0xd0, 0x91 }; > + GUID machine_uuid; > + unsigned char out256[32]; /* returning first 128 bits only */ > + > + read_machine_id( &machine_uuid ); > + > + hmac_sha256( wine_uuid, sizeof(wine_uuid), (const unsigned char *)&machine_uuid, sizeof(machine_uuid), out256 ); > + > + memset( &machine_uuid, 0, sizeof(machine_uuid) ); This write is unused and will be optimized out by the compiler. Are you looking for something like [`explicit_bzero(3)`](https://man7.org/linux/man-pages/man3/bzero.3.html)? In that case, why is machine UUID considered sensitive enough to warrant erasure? -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4108#note_49546

1 0

[PATCH v7 0/2] MR4054: mshtml: HTMLWindow behavior improvements.
by Gabriel Ivăncescu (＠insn) 21 Oct '23

21 Oct '23

-- v7: mshtml: Return proper errors when navigating with no browser. mshtml: Set outer window to uninitialized page when document obj is released. https://gitlab.winehq.org/wine/wine/-/merge_requests/4054

4 4

[PATCH v18 0/14] MR3938: winegstreamer: Implement CLSID_CMpegVideoCodec
by Alfred Agrell (＠Alcaro) 21 Oct '23

21 Oct '23

Resolves https://bugs.winehq.org/show_bug.cgi?id=9127 . (Some of the named programs in that issue may require additional currently-missing functionality, I didn't check; but if so, that's separate issues.) Tested with - winetest on Windows 7 - winetest on Windows 10 - winetest in Wine, of course - microkiri https://bugs.winehq.org/show_bug.cgi?id=9127#c102 - Wagamama High Spec Trial Edition https://wagahigh.com/download_trial.php#normal (ダウンロード means download) - Ninki Seiyuu no Tsukurikata Trial https://archive.org/details/sayou_trial (WMV files in microkiri and Wagamama don't work, but that's separate issues. Also, they need the LC_ALL=ja_JP env, or they throw various goofy errors.) -- v18: quartz/tests: Add tests for CLSID_CMpegVideoCodec. quartz/tests: Add tests for new CLSID_MPEG1Splitter functionality. winegstreamer: Implement CLSID_CMpegVideoCodec. winegstreamer: Add program stream and video output support to CLSID_MPEG1Splitter. winegstreamer: Add WG_MAJOR_TYPE_VIDEO_MPEG1 media type. winegstreamer: Use the new output_compressed property instead of mpegaudioparse in MPEG splitter. winegstreamer: Add output_compressed parameter to wg_parser_create(). winegstreamer: Implement parts of IAMStreamSelect::Info in CLSID_MPEG1Splitter. winegstreamer: Implement IAMStreamSelect::Count in CLSID_MPEG1Splitter. winegstreamer: Improve and clean up some debug logs. winegstreamer: Include the framerate when converting video format to GstCaps. winegstreamer: Seek to end of stream instead of to stream duration. winegstreamer: Clamp QoS events to stay inside the stream's running time. winegstreamer: Don't read format from unparsed MPEG audio. https://gitlab.winehq.org/wine/wine/-/merge_requests/3938

3 20

Re: [PATCH v2 0/1] MR4143: uxtheme: Add ShouldAppsUseDarkMode.
by Louis Lenders (＠xe) 21 Oct '23

21 Oct '23

>and a Wine-Bug: link in the commit message. How do I do that? -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4143#note_49536

1 0

[PATCH 0/1] MR4155: tests: Build tests with -Wl,--large-address-aware.
by Zebediah Figura (＠zfigura) 21 Oct '23

21 Oct '23

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/4155

3 2

[PATCH v9 0/2] MR413: ci: Run the crosstests on Windows.
by Giovanni Mascellani (＠giomasce) 21 Oct '23

21 Oct '23

This depends on !412, and might need some finishing touches before being ready. -- v9: ci: Run shader tests on Windows. ci: Run cross tests on Windows. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/413

2 2

[PATCH v8 0/2] MR413: ci: Run the crosstests on Windows.
by Giovanni Mascellani (＠giomasce) 21 Oct '23

21 Oct '23

This depends on !412, and might need some finishing touches before being ready. -- v8: ci: Run shader tests on Windows. ci: Run cross tests on Windows. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/413

2 2

[PATCH v7 0/2] MR413: ci: Run the crosstests on Windows.
by Giovanni Mascellani (＠giomasce) 21 Oct '23

21 Oct '23

This depends on !412, and might need some finishing touches before being ready. -- v7: ci: Run shader tests on Windows. ci: Run cross tests on Windows. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/413

2 3

[PATCH v6 0/2] MR413: ci: Run the crosstests on Windows.
by Giovanni Mascellani (＠giomasce) 21 Oct '23

21 Oct '23

This depends on !412, and might need some finishing touches before being ready. -- v6: ci: Run shader tests on Windows. ci: Run cross tests on Windows. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/413

4 5

[PATCH 0/6] MR4154: ws2_32/tests: Make sure that WSARecv() completes synchronously in test_WSARecv().
by Zebediah Figura (＠zfigura) 21 Oct '23

21 Oct '23

Wine-Bug: https://bugs.winehq.org//show_bug.cgi?id=54342 -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4154

2 8

[PATCH 0/1] MR4143: uxtheme: Add ShouldAppsUseDarkMode
by Louis Lenders (＠xe) 21 Oct '23

21 Oct '23

https://bugs.winehq.org/show_bug.cgi?id=55742 -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4143

3 2

[PATCH 0/2] MR4140: uxtheme/tests: Add some tests for OpenThemeData() with various app/class names.
by Dmitry Timoshkov (＠dmitry) 21 Oct '23

21 Oct '23

Themed Delphi applications use "explorer::listview" and "explorer::treeview": https://gitlab.com/freepascal.org/lazarus/lazarus/-/blob/main/lcl/interface… -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4140

3 3

[PATCH 0/2] MR4147: dsound: Dynamically allocate the global device GUID arrays.
by Alex Henrie (＠alexhenrie) 21 Oct '23

21 Oct '23

This removes the arbitrary limit on the number of renderers and capturers while satisfying applications that expect the GUIDs to remain valid after DirectSoundCaptureEnumerate returns. Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=55608 -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4147

3 3

[PATCH 0/2] MR4153: d3d{10core,11}/tests: Avoid POINT sampling exactly halfway between two mip levels.
by Zebediah Figura (＠zfigura) 21 Oct '23

21 Oct '23

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/4153

2 2

[PATCH v4 0/6] MR3810: winegstreamer: Implement add_stream and push_sample for muxer.
by Ziqing Hui (＠zhui) 21 Oct '23

21 Oct '23

-- v4: winegstreamer: Implement wg_muxer_push_sample. winegstreamer: Implement ProcessSample for media sink. winegstreamer: Implement wg_muxer_start. https://gitlab.winehq.org/wine/wine/-/merge_requests/3810

3 12

[PATCH v17 0/14] MR3938: winegstreamer: Implement CLSID_CMpegVideoCodec
by Alfred Agrell (＠Alcaro) 20 Oct '23

20 Oct '23

Resolves https://bugs.winehq.org/show_bug.cgi?id=9127 . (Some of the named programs in that issue may require additional currently-missing functionality, I didn't check; but if so, that's separate issues.) Tested with - winetest on Windows 7 - winetest on Windows 10 - winetest in Wine, of course - microkiri https://bugs.winehq.org/show_bug.cgi?id=9127#c102 - Wagamama High Spec Trial Edition https://wagahigh.com/download_trial.php#normal (ダウンロード means download) - Ninki Seiyuu no Tsukurikata Trial https://archive.org/details/sayou_trial (WMV files in microkiri and Wagamama don't work, but that's separate issues. Also, they need the LC_ALL=ja_JP env, or they throw various goofy errors.) -- v17: quartz/tests: Add tests for CLSID_CMpegVideoCodec. quartz/tests: Add tests for new CLSID_MPEG1Splitter functionality. winegstreamer: Implement CLSID_CMpegVideoCodec. winegstreamer: Add program stream and video output support to CLSID_MPEG1Splitter. winegstreamer: Add WG_MAJOR_TYPE_VIDEO_MPEG1 media type. winegstreamer: Use the new output_compressed property instead of mpegaudioparse in MPEG splitter. winegstreamer: Add output_compressed parameter to wg_parser_create(). winegstreamer: Implement parts of IAMStreamSelect::Info in CLSID_MPEG1Splitter. winegstreamer: Implement IAMStreamSelect::Count in CLSID_MPEG1Splitter. winegstreamer: Improve and clean up some debug logs. winegstreamer: Include the framerate when converting video format to GstCaps. winegstreamer: Seek to end of stream instead of to stream duration. winegstreamer: Clamp QoS events to stay inside the stream's running time. winegstreamer: Don't read format from unparsed MPEG audio. https://gitlab.winehq.org/wine/wine/-/merge_requests/3938

3 15

[PATCH v21 0/8] MR361: vkd3d-shader/hlsl: Initial support for 'switch' statement.
by Nikolay Sivov (＠nsivov) 20 Oct '23

20 Oct '23

Signed-off-by: Nikolay Sivov <nsivov(a)codeweavers.com> -- v21: vkd3d-shader/tpf: Write out 'switch' statements. vkd3d-shader/hlsl: Add a pass to normalize switch cases blocks. vkd3d-shader/hlsl: Add a pass to remove unreachable code. vkd3d-shader/hlsl: Add copy propagation logic for switches. vkd3d-shader/hlsl: Validate break/continue context. vkd3d-shader/hlsl: Check for duplicate case statements. vkd3d-shader/hlsl: Add initial support for parsing 'switch' statements. tests: Add some tests for the 'switch' statements. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/361

4 20

Re: [PATCH v2 0/1] MR4150: d3d10_1/tests: Add some more tests for fx_4_1 blend states. - approved
by Alexandre Julliard (＠julliard) 20 Oct '23

20 Oct '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4150

1 0

Re: [PATCH v2 0/4] MR4141: uiautomationcore: Miscellaneous fixes. - approved
by Alexandre Julliard (＠julliard) 20 Oct '23

20 Oct '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4141

1 0

Re: [PATCH v3 0/7] MR4139: dmime, dmusic: Miscellaneous fixes. - approved
by Alexandre Julliard (＠julliard) 20 Oct '23

20 Oct '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4139

1 0

Re: [PATCH v3 0/3] MR4135: d2d1: -Wenum-conversion warning fixes - approved
by Alexandre Julliard (＠julliard) 20 Oct '23

20 Oct '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4135

1 0

[PATCH v16 0/13] MR3938: winegstreamer: Implement CLSID_CMpegVideoCodec
by Alfred Agrell (＠Alcaro) 20 Oct '23

20 Oct '23

Resolves https://bugs.winehq.org/show_bug.cgi?id=9127 . (Some of the named programs in that issue may require additional currently-missing functionality, I didn't check; but if so, that's separate issues.) Tested with - winetest on Windows 7 - winetest on Windows 10 - winetest in Wine, of course - microkiri https://bugs.winehq.org/show_bug.cgi?id=9127#c102 - Wagamama High Spec Trial Edition https://wagahigh.com/download_trial.php#normal (ダウンロード means download) - Ninki Seiyuu no Tsukurikata Trial https://archive.org/details/sayou_trial (WMV files in microkiri and Wagamama don't work, but that's separate issues. Also, they need the LC_ALL=ja_JP env, or they throw various goofy errors.) -- v16: quartz/tests: Add tests for CLSID_CMpegVideoCodec. quartz/tests: Add tests for new CLSID_MPEG1Splitter functionality. winegstreamer: Improve and clean up some debug logs. winegstreamer: Include the framerate when converting video format to GstCaps. winegstreamer: Don't read format from unparsed MPEG audio. winegstreamer: Seek to end of stream instead of to stream duration. winegstreamer: Implement parts of IAMStreamSelect::Info in CLSID_MPEG1Splitter. winegstreamer: Implement IAMStreamSelect::Count in CLSID_MPEG1Splitter. https://gitlab.winehq.org/wine/wine/-/merge_requests/3938

4 28

[PATCH 0/1] MR4150: d3d10_1/tests: Add some more tests for fx_4_1 blend states.
by Nikolay Sivov (＠nsivov) 20 Oct '23

20 Oct '23

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/4150

3 2

[PATCH v3 0/1] MR366: vkd3d-shader/hlsl: Add tex2Dlod() function.
by Nikolay Sivov (＠nsivov) 20 Oct '23

20 Oct '23

Signed-off-by: Nikolay Sivov <nsivov(a)codeweavers.com> -- v3: vkd3d-shader/hlsl: Add tex2Dlod() function. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/366

2 2

[PATCH 0/4] MR4141: uiautomationcore: Miscellaneous fixes.
by Connor McAdams (＠cmcadams) 20 Oct '23

20 Oct '23

Fix a test failure, silence/remove some FIXMEs, and return S_OK from a stub. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4141

3 5

[PATCH 0/1] MR4138: gdiplus: Reset the installedFontCollection.count field to zero upon release.
by kingjinni (＠kingjinni) 20 Oct '23

20 Oct '23

The application crashes when attempting to load fonts internally, especially those with watermark functionalities. Reset the installedFontCollection.count field to zero upon release. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4138

4 4

[PATCH v2 0/3] MR423: vkd3d: Fix the macOS build.
by Giovanni Mascellani (＠giomasce) 20 Oct '23

20 Oct '23

A few recent changes broke the macOS build. Unfortunately nobody noticed, because the macOS CI job always fails. :-( However, we can still fix that. I'm not sure that the last commit is the best approach, would like to have comments from Henri. -- v2: include: Import vkd3d_d3dcompiler.h instead of redefining D3D_BLOB_PART. vkd3d-shader: Explicitly cast vkd3d_shader_global_flags to uint64_t. ci: Allow the artifact copy to fail. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/423

2 3

[PATCH 0/2] MR423: vkd3d: Fix the macOS build.
by Giovanni Mascellani (＠giomasce) 20 Oct '23

20 Oct '23

A few recent changes broke the macOS build. Unfortunately nobody noticed, because the macOS CI job always fails. :-( However, we can still fix that. I'm not sure that the second commit is the best approach, would like to have comments from Henri. -- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/423

2 2

[PATCH 0/1] MR4146: setupapi: Prevent certain applications from entering an endless loop during the installation process.
by kingjinni (＠kingjinni) 20 Oct '23

20 Oct '23

setupapi: Prevent certain applications from entering an endless loop during the installation process. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4146

3 3

[PATCH v6 0/2] MR4054: mshtml: HTMLWindow behavior improvements.
by Gabriel Ivăncescu (＠insn) 20 Oct '23

20 Oct '23

-- v6: mshtml: Return proper errors when navigating with no browser. mshtml: Set outer window to uninitialized page when document obj is released. https://gitlab.winehq.org/wine/wine/-/merge_requests/4054

3 3

[PATCH v2 0/12] MR4102: Draft: winewayland.drv: Implement keyboard input support.
by Rémi Bernon (＠rbernon) 20 Oct '23

20 Oct '23

@afrantzis Can't seem to be possible to add you as a reviewer, probably you need to request "Access" to the wine/wine project (near the top of the project page). What do you think of something like that? It is very different from the current winex11 code, but I believe it will match keyboard layouts in a much more accurate way, and it's also IMO much simpler. If that works well with Wayland, I think it could be a good hint that it might work as well in X11 and make a case for my other MR to use that approach there. I was a bit annoyed that it doesn't seem possible to retrieve the Xkb "layout:variant" string here, but only the layout description, so I had to use xkbregistry to match it back to the known layouts. It is mostly only there to provide a more accurate HKL value (which should match the layout langid), and scan to vk mapping table, and custom layouts should still work. The lang would be neutral then, and the scan to vk table is QWERTY by default, which is the most common case, and doesn't enforce any vkey -> unicode mapping anyway. So, if the xkbregistry dependency is an issue we could probably make it optional and dynamically loaded, and skip the langid and scan to vk specialized mappings. -- v2: winewayland.drv: Implement Xkb composition using ImeProcessKey. winewayland.drv: Translate Xkb keyboard layouts to KBDTABLES. win32u: Allow KBDTABLES conversion from CTLR + ALT to WCHAR. win32u: Force US layout in ToUnicode when CTRL is pressed. win32u: Introduce KbdLayerDescriptor user driver entry. win32u: Avoid accessing NULL key name string pointer. winewayland.drv: Enumerate Xkb layouts and create matching HKL. winewayland.drv: Handle and parse Xkb keymap events. win32u: Implement opt-in auto-repeat for WM_(SYS)KEYDOWN messages. winewayland.drv: Configure win32u keyboard repeat delay and speed. winewayland.drv: Basic handling of Wayland keyboard events. gitlab: Install libxkbcommon and libxkbregistry dependencies. https://gitlab.winehq.org/wine/wine/-/merge_requests/4102

7 18

[PATCH v5 0/2] MR4054: mshtml: HTMLWindow behavior improvements.
by Gabriel Ivăncescu (＠insn) 20 Oct '23

20 Oct '23

-- v5: mshtml: Return proper errors when navigating with no browser. mshtml: Set outer window to uninitialized page when document obj is released. https://gitlab.winehq.org/wine/wine/-/merge_requests/4054

4 6

[PATCH v4 0/4] MR3789: Improve media session handling of unexpected errors.
by Santino Mazza (＠tati1454) 20 Oct '23

20 Oct '23

-- v4: mf: Handle errors with source event generator in session. https://gitlab.winehq.org/wine/wine/-/merge_requests/3789

3 9

Re: [PATCH v2 0/2] MR4108: Improve DMI tables under Linux.
by Gabriel Ivăncescu (＠insn) 20 Oct '23

20 Oct '23

Yeah, but this isn't necessarily about not trusting Windows apps, i.e. malice or malware, but rather that they can't be designed around it (since they assume Windows environment), so they would have privacy issues without even wanting to. At the very least maybe use `sd_id128_get_machine_app_specific` with a unique app ID for Wine? Simple and still better than nothing. Otherwise, it would probably have to be done per-prefix (registry?), since two processes in the same prefix might want the same ID. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4108#note_49432

1 0

[PATCH v6 0/6] MR4092: user32: Actually implement RealGetWindowClass{A/W}.
by Connor McAdams (＠cmcadams) 20 Oct '23

20 Oct '23

-- v6: user32: Pass real argument to NtUserGetClassName in RealGetWindowClass{A/W}. win32u: Add support for retrieving real window class ID across processes. user32: Set real window class ID for user32 static controls. win32u/tests: Add a test for real window class name retrieval. comctl32/tests: Add tests for RealGetWindowClass. user32/tests: Add tests for RealGetWindowClass. https://gitlab.winehq.org/wine/wine/-/merge_requests/4092

3 8

[PATCH v2 0/7] MR4139: dmime, dmusic: Miscellaneous fixes.
by Rémi Bernon (＠rbernon) 20 Oct '23

20 Oct '23

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=55792 Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=55790 -- v2: dmime: Avoid releasing the newly created graph twice. dswave: Use the dmusic wave object implementation. dmusic: Use the IDirectMusicObject interface for waves. dmusic: Implement IDirectMusicObject interface on wave objects. dmime: Return hr from wave track SetParam GUID_DownloadToAudioPath. dmime: Return S_OK from wave track SetParam GUID_UnloadFromAudioPath. dmime: Avoid crashing when purging notification messages. https://gitlab.winehq.org/wine/wine/-/merge_requests/4139

3 9

[PATCH v4 0/2] MR4054: mshtml: HTMLWindow behavior improvements.
by Gabriel Ivăncescu (＠insn) 20 Oct '23

20 Oct '23

-- v4: mshtml: Return proper errors when navigating with no browser. mshtml: Set outer window to uninitialized page when document obj is released. https://gitlab.winehq.org/wine/wine/-/merge_requests/4054

4 7

[PATCH v6 0/7] MR3007: Draft: ntdll: Avoid requests with null pointer but invalid size.
by Bernhard Übelacker (＠bernhardu) 20 Oct '23

20 Oct '23

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=51770 - v1: - https://www.winehq.org/pipermail/wine-devel/2021-December/202913.html - https://www.winehq.org/pipermail/wine-devel/2022-April/213866.html (resend) - v2: - https://www.winehq.org/pipermail/wine-devel/2022-April/214306.html - Validate pointer before calling wine_server_add_data. - v3: (d4a7440a) - https://www.winehq.org/pipermail/wine-devel/2022-May/218285.html - Move check to DeviceIoControl. - Always use fixed values for IOCTL_STORAGE_GET_DEVICE_NUMBER. - Remove warning at expected hang. - v4: (6a69c680) - Fix typo in commit message. - Modified format strings. - v5: (47784feb) - Move test to own test function. - Move check to wine_server_add_data. - v6: (8c641d09) - Move check to NtDeviceIoControlFile - Add (at least temporary) tests to compare with NtDeviceIoControlFile and NtFsControlFile. -- v6: ntoskrnl.exe/test: Add some temporary debugging output. kernel32/tests: Add test for IOCTL_STORAGE_GET_DEVICE_NUMBER. ntdll: Add validation for input and output buffers in NtDeviceIoControlFile. ntoskrnl.exe: Allow sending a null input buffer to the driver. ntoskrnl.exe: Add todo_wine_if to test_ioctl_buffers. ntoskrnl.exe: Remove buffer assignments in test_ioctl_buffers. ntoskrnl.exe: Add test_ioctl_buffers. https://gitlab.winehq.org/wine/wine/-/merge_requests/3007

4 8

[PATCH v6 0/1] MR4049: ntdll: Implement thread-ID alerts using kqueue()/kevent()
by Marc-Aurel Zent (＠marzent) 20 Oct '23

20 Oct '23

This allows *BSDs to also have a fast path similar to futexes for thread-ID alerts. Also a kevent with `EV_CLEAR` and `NOTE_TRIGGER` maps perfectly to the thread alertable state, fixing the issue of the current mach-semaphore implementation not correctly waiting in the test case below: ``` NtAlertThreadByThreadId((HANDLE)GetCurrentThreadId()); NtAlertThreadByThreadId((HANDLE)GetCurrentThreadId()); NtWaitForAlertByThreadId(NULL, NULL); NtWaitForAlertByThreadId(NULL, NULL); ``` I took the liberty to remove this mach semaphore implementation, since all versions of OSX have supported kqueue(). -- v6: ntdll: Implement thread-ID alerts using kqueue/kevent. https://gitlab.winehq.org/wine/wine/-/merge_requests/4049

3 3

[PATCH v10 0/4] MR1088: ntdll: Avoid calling pthread_exit on thread exit.
by Rémi Bernon (＠rbernon) 20 Oct '23

20 Oct '23

Using a dedicated exit jmpbuf and removing the need for assembly routines. When Wine handles an exception in unix code, we return to user mode by jumping to the last syscall frame. This can leave some pthread cancel cleanups registered, in the pthread internal linked list, and at the same time later overwrite the stack frame they were registered for. In the same way, jumping to the exit frame on thread exit or abort, can also leave some cleanup handlers registered for invalid stack frames. Depending on the implementation, calling pthread_exit will cause all the registered pthread cleanup handlers to be called, possibly jumping back to now overwritten stack frames and causing segmentation faults. Exiting a pthread normally, by returning from its procedure, or calling exit(0) for the main thread doesn't run pthread_exit and doesn't call cleanup handlers, avoiding that situation. Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=52213 ### Additional note: For robustness, we should probably try to execute these cleanup handlers when unwinding the stack frames, as we would otherwise leave pthread objects in a potential problematic state (like a mutex locked, etc). It is however hard to do so when the handlers are registered from some C code: pthread C implementation is done by calling some internal pthread functions to register the handlers, and they aren't registered as standard unwind handlers. Only pthread_cancel and pthread_exit can unwind and call / unregister the C handlers, but interrupting that procedure, for instance calling setjmp / longjmp from withing our own handler isn't supported. From C++ code, pthread cleanup handlers are registered through C++ class constructors / destructors, and it would then be possible to partially unwind and call them at the same time. -- v10: ntdll: Remove now unnecessary arch-specific exit frame. ntdll: Avoid calling pthread_exit from abort_thread. ntdll: Avoid calling abort_thread from the signal stack. ntdll: Use is_inside_syscall more consistently. https://gitlab.winehq.org/wine/wine/-/merge_requests/1088

3 9

[PATCH v15 0/12] MR3938: winegstreamer: Implement CLSID_CMpegVideoCodec
by Alfred Agrell (＠Alcaro) 20 Oct '23

20 Oct '23

Resolves https://bugs.winehq.org/show_bug.cgi?id=9127 . (Some of the named programs in that issue may require additional currently-missing functionality, I didn't check; but if so, that's separate issues.) Tested with - winetest on Windows 7 - winetest on Windows 10 - winetest in Wine, of course - microkiri https://bugs.winehq.org/show_bug.cgi?id=9127#c102 - Wagamama High Spec Trial Edition https://wagahigh.com/download_trial.php#normal (ダウンロード means download) - Ninki Seiyuu no Tsukurikata Trial https://archive.org/details/sayou_trial (WMV files in microkiri and Wagamama don't work, but that's separate issues. Also, they need the LC_ALL=ja_JP env, or they throw various goofy errors.) -- v15: quartz/tests: Add tests for CLSID_CMpegVideoCodec. quartz/tests: Add tests for new CLSID_MPEG1Splitter functionality. winegstreamer: Improve and clean up some debug logs. winegstreamer: Include the framerate when converting video format to GstCaps. winegstreamer: Don't read format from unparsed MPEG audio. winegstreamer: Seek to end of stream instead of to stream duration. winegstreamer: Implement a little more of IAMStreamSelect in CLSID_MPEG1Splitter. winegstreamer: Implement CLSID_CMpegVideoCodec. winegstreamer: Add program stream and video output support to CLSID_MPEG1Splitter. https://gitlab.winehq.org/wine/wine/-/merge_requests/3938

3 13

[PATCH 0/1] MR4133: mfmediaengine: Don't send event notify when engine is shutdown.
by Yuxuan Shui (＠yshui) 20 Oct '23

20 Oct '23

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/4133

3 2

[PATCH 0/1] MR4149: msxml: Always increase error count when detect
by Alistair Leslie-Hughes (＠alesliehughes) 20 Oct '23

20 Oct '23

The error count wasn't be increased if tracing was disabled. eg CI. Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=55720 -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4149

3 5

[PATCH v2 0/3] MR4135: d2d1: -Wenum-conversion warning fixes
by Jacek Caban (＠jacek) 20 Oct '23

20 Oct '23

-- v2: d2d1: Don't cast D2D1_THREADING_MODE to D2D1_FACTORY_TYPE in D2D1CreateDevice. d2d1: Pass interpolation mode as D2D1_INTERPOLATION_MODE to d2d_device_context_draw_bitmap. d2d1/tests: Use D2D1_INTERPOLATION_MODE constants in DrawImage calls. https://gitlab.winehq.org/wine/wine/-/merge_requests/4135

4 5

[PATCH v14 0/13] MR3938: winegstreamer: Implement CLSID_CMpegVideoCodec
by Alfred Agrell (＠Alcaro) 20 Oct '23

20 Oct '23

Resolves https://bugs.winehq.org/show_bug.cgi?id=9127 . (Some of the named programs in that issue may require additional currently-missing functionality, I didn't check; but if so, that's separate issues.) Tested with - winetest on Windows 7 - winetest on Windows 10 - winetest in Wine, of course - microkiri https://bugs.winehq.org/show_bug.cgi?id=9127#c102 - Wagamama High Spec Trial Edition https://wagahigh.com/download_trial.php#normal (ダウンロード means download) - Ninki Seiyuu no Tsukurikata Trial https://archive.org/details/sayou_trial (WMV files in microkiri and Wagamama don't work, but that's separate issues. Also, they need the LC_ALL=ja_JP env, or they throw various goofy errors.) -- v14: quartz/tests: Add tests for CLSID_CMpegVideoCodec. quartz/tests: Add tests for new CLSID_MPEG1Splitter functionality. winegstreamer: Improve and clean up some debug logs. winegstreamer: Include the framerate when converting video format to GstCaps. winegstreamer: Don't read format from unparsed MPEG audio. winegstreamer: Seek to end of stream instead of to stream duration. winegstreamer: Implement a little more of IAMStreamSelect in CLSID_MPEG1Splitter. winegstreamer: Implement CLSID_CMpegVideoCodec. winegstreamer: Add program stream and video output support to CLSID_MPEG1Splitter. winegstreamer: Fill in video media type a bit better. winegstreamer: Add WG_MAJOR_TYPE_VIDEO_MPEG1 media type. winegstreamer: Use the new output_compressed property instead of mpegaudioparse in MPEG splitter. winegstreamer: Add output_compressed parameter to wg_parser_create(). https://gitlab.winehq.org/wine/wine/-/merge_requests/3938

2 14

[PATCH 0/3] MR4151: wined3d: Clang warning fixes.
by Jacek Caban (＠jacek) 20 Oct '23

20 Oct '23

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/4151

3 4

[PATCH v4 0/8] MR417: vkd3d-shader/hlsl: Add ceil() function.
by Nikolay Sivov (＠nsivov) 20 Oct '23

20 Oct '23

Signed-off-by: Nikolay Sivov <nsivov(a)codeweavers.com> -- v4: vkd3d-shader: Add constant folding for 'floor'. vkd3d-shader: Add a missing entry to instruction debug print helper. vkd3d-shader: Add constant folding for 'ceil'. vkd3d-shader: Add support for floor() on SM1-3. vkd3d-shader: Add support for ceil() on SM1-3. vkd3d-shader/tpf: Add support for ceil(). vkd3d-shader/hlsl: Parse ceil() function. tests: Add some tests for ceil(). https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/417

3 9

[PATCH v2 0/5] MR4142: Cleanup passing info from dbghelp to WineDbg.
by eric pouech (＠epo) 20 Oct '23

20 Oct '23

We used to have some hack for passing information (mainlyi module related ones) from dbghelp to WineDbg. This series: - reimplements properly the sharing, introducing a Wine entrypoint to dbghelp (sharing debug formats not handled by native, no longer decorating module names for sharing that module was in fact a host module...) - improves "info share" command in WineDbg with more accurate information (host module type...) - improves loading time on MacOs (some system libraries no longer have their images accessible directly on disk by standard file operation). -- v2: dbghelp: Pretend mach-o is present in case of failure. dbghelp: Expose PE native vs builtin information to winedbg. dbghelp,winedbg: No longer decorate ELF/Mach-O module names. dbghelp: Expose some internal information about modules to winedbg. dbghelp: Remove DMT_ entries for .DBG and .PDB files. https://gitlab.winehq.org/wine/wine/-/merge_requests/4142

2 6

[PATCH 0/3] MR4135: d2d1: -Wenum-conversion warning fixes
by Jacek Caban (＠jacek) 20 Oct '23

20 Oct '23

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/4135

3 4

Re: [PATCH v2 0/2] MR4108: Improve DMI tables under Linux.
by Hans Leidekker (＠hans) 20 Oct '23

20 Oct '23

It wasn't Project Kunai. I know that Office 2010 uses SMBIOS values in its activation process and I remember adding support for retrieving the disk serial number through an IOCTL for another app, which is equally sensitive BTW. Like Zeb said, there's no end of measures to be taken if we can't trust the Windows app. It's something better handled outside of Wine. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4108#note_49386

1 0

Re: [PATCH v2 0/2] MR4108: Improve DMI tables under Linux.
by eric pouech (＠epo) 20 Oct '23

20 Oct '23

On Thu Oct 19 14:52:17 2023 +0000, Hans Leidekker wrote: > sd_id128_get_machine_app_specific() requires cooperation from the app. > That's not something we can expect from Windows apps. Windows apps > should treat this information with confidentiality just like Linux apps. > The game whose name I forgot collected several more or less unique IDs > and calculated a hash over those values. I'm referring to Unix apps. was the game Project Kunai? -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4108#note_49382

1 0

[PATCH v2 0/3] MR4073: msxml3: Stop possible typelib out of bounds access (Coverity)
by Alistair Leslie-Hughes (＠alesliehughes) 20 Oct '23

20 Oct '23

typelib has an array size of 2 (eg LibXml_Last), so a lookup of IID_NULL will result in a lookup of the third index. -- v2: msxml3: Free IBindCtx on error paths (Coverity) msxml3: Move tid_NULL out of possible enum values. msxml3: Dont call qsort if we have no data (Coverity). https://gitlab.winehq.org/wine/wine/-/merge_requests/4073

2 3

[PATCH 0/1] MR4148: advapi32/tests: Add ReadEventLogW tests for direction.
by Daniel Lehman (＠dlehman25) 20 Oct '23

20 Oct '23

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/4148

2 1

[PATCH v4 0/5] MR408: vkd3d-shader/dxil: Implement constant buffer loads.
by Conor McCarthy (＠cmccarthy) 20 Oct '23

20 Oct '23

-- v4: vkd3d-shader/dxil: Implement the DXIL EXTRACTVAL instruction. vkd3d-shader/spirv: Support scalar swizzle of vector SSA registers. vkd3d-shader/dxil: Implement DX instruction CBufferLoadLegacy. vkd3d-shader/dxil: Implement DX instruction CreateHandle. vkd3d-shader/dxil: Replace register_address_init() with register_index_address_init(). https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/408

2 6

Re: [PATCH v13 0/7] MR3938: winegstreamer: Implement CLSID_CMpegVideoCodec
by Alfred Agrell (＠Alcaro) 20 Oct '23

20 Oct '23

On Mon Oct 16 23:45:47 2023 +0000, Zebediah Figura wrote: > This may be correct (although I'm curious if it actually matters here?) > but should be a separate patch. It does matter, gst_pad_push returns GST_FLOW_NOT_NEGOTIATED if I omit it. Separate commit, sure, if you say so. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3938#note_49357

1 0

Re: [PATCH v13 0/7] MR3938: winegstreamer: Implement CLSID_CMpegVideoCodec
by Alfred Agrell (＠Alcaro) 20 Oct '23

20 Oct '23

On Fri Oct 20 01:24:23 2023 +0000, Zebediah Figura wrote: > Hi, really sorry about the very late review on this one (I was out for a > while, and then spent a lot of time catching up on review while I was > out, and then trying to get some more important Wine work done...) > 2/7, seeking parts aside, is broadly doing the right thing (from my > perspective) but I would like to see it arranged differently. What I > would like to see is something like the following, in a series of > individual patches: > * Introduce a wg_parser_create option to use the encoded format; this > should end up being translated to "chain_decodebins" basically as you > have it. I would also rename that to something like "output_compressed" > (with inverted meaning). > Note that in this case autoplug-continue already does what we want, > you shouldn't need to set the "caps" property on top of that. > * Use this property, plus WG_PARSER_DECODEBIN, in the existing frontend > instead of WG_PARSER_MPEGAUDIOPARSE. Delete WG_PARSER_MPEGAUDIOPARSE. > * Ideally patch 1/7 should be moved from the beginning of the series to here. > * Add MPEG-1 system stream support to the quartz frontend. Yes, IRL stuff is always in the way (from us internet folks' perspective), and code review isn't the most exciting task. I don't understand the point of that autoplug-continue handler. It looks like it says "yep, I want this" for certain formats, then it turns around and says "no, I don't want this after all, decode it again" in the pad-added signal. I'm sure that complexity exists for some reason, otherwise someone would've deleted it long ago, but... But I don't need to understand it, as long as someone does. This took me longer to implement than I expected, didn't expect you to be this thorough. Sure helps to have a pair of fresh eyes on it. Worth the wait (though it would've helped to have known how long it'd take). I think I fixed everything (except those with follow-up questions), but some changes are pretty big and/or not exactly what you were thinking of, so I suspect you'll have another set of remarks. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3938#note_49356

1 0

Re: [PATCH v13 0/7] MR3938: winegstreamer: Implement CLSID_CMpegVideoCodec
by Alfred Agrell (＠Alcaro) 20 Oct '23

20 Oct '23

On Mon Oct 16 23:45:56 2023 +0000, Zebediah Figura wrote: > This probably needs to take the filter CS. Same for Info() for that matter. You sure? There's no reference to filter_cs in dlls/quartz/ or dlls/winegstreamer/, except in VMR; it's mostly used in libs/strmbase/. Is this specific interface different? Or maybe they're all buggy? -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3938#note_49352

1 0

Re: [PATCH v13 0/7] MR3938: winegstreamer: Implement CLSID_CMpegVideoCodec
by Alfred Agrell (＠Alcaro) 20 Oct '23

20 Oct '23

On Mon Oct 16 23:45:59 2023 +0000, Zebediah Figura wrote: > If Windows never sets the sample time for video samples after the first > then we should probably make this check more restrictive to explicitly > check that. It's Complicated™ (Apologies if you know some of this already, better too much information than too little.) The MPEG video format contains two layers of framing - the program stream tells which bytes are audio and which are video, but it's just arbitrarily arranged bytes, with no relation to video frame boundaries. Windows' MPEG splitter parses the program stream, reads the first few bytes of the video stream (the codec data) to determine image size, and emits that. Determining the frame boundaries is the video codec's job. GStreamer's mpegpsdemux doesn't read the codec data because why would it. To make the splitter's media type contain image size, I needed to put the mpegvideoparse on this side. Which means that, unlike Windows, each submitted packet is exactly one frame. ``` Windows video0 hr=00000000 len=1214 audio0 hr=00000000 len=2037 audio1 hr=00000000 len=2037 audio2 hr=00000000 len=2025 audio3 hr=00000000 len=2025 audio4 hr=80040249 len=653 Wine video0 hr=00000000 len=859 audio0 hr=00000000 len=1253 video1 hr=80040249 len=195 audio1 hr=00000000 len=1254 video2 hr=80040249 len=84 audio2 hr=00000000 len=1254 video3 hr=80040249 len=76 audio3 hr=00000000 len=1254 audio4 hr=00000000 len=1254 audio5 hr=00000000 len=1254 audio6 hr=00000000 len=1254 ``` Yes, it's messy, but I don't think we can do any better unless I move the mpegvideoparse into the codec object. Which would be more accurate to native, but it would require writing my own decoder for the codec data, would require reintroducing <https://gitlab.winehq.org/wine/wine/-/merge_requests/3938#note_46588>, and would improve nothing except our test suite. That said, the VFW_S_NO_STOP_TIME check catches nothing. I'll drop it. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3938#note_49353

1 0

Re: [PATCH v13 0/7] MR3938: winegstreamer: Implement CLSID_CMpegVideoCodec
by Alfred Agrell (＠Alcaro) 20 Oct '23

20 Oct '23

On Mon Oct 16 23:46:01 2023 +0000, Zebediah Figura wrote: > Shouldn't we get an exact number of frames here? Or is that not > consistent somehow? Yes, it's inconsistent. Wine emits two frames; native only emits one, probably because the graph is paused. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3938#note_49354

1 0

Re: [PATCH v13 0/7] MR3938: winegstreamer: Implement CLSID_CMpegVideoCodec
by Alfred Agrell (＠Alcaro) 20 Oct '23

20 Oct '23

On Mon Oct 16 23:46:02 2023 +0000, Zebediah Figura wrote: > Can you please also check (at least the return value of) > IMediaSample::GetMediaType()? I'm rather curious if it's updated or not. It just returns S_FALSE every frame (which means unchanged since previous sample). Sure, let's test it, no reason not to. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3938#note_49355

1 0

Re: [PATCH v13 0/7] MR3938: winegstreamer: Implement CLSID_CMpegVideoCodec
by Alfred Agrell (＠Alcaro) 20 Oct '23

20 Oct '23

On Mon Oct 16 23:46:06 2023 +0000, Zebediah Figura wrote: > Usually enum values are capitalized; also, _t is usually reserved for > typedefs. That said, do we even want this enum? Is there any instance > where we shouldn't just iterate over the whole array? > Two of these formats are todo, but I think something like "todo_wine_if > (i == 1 || i == 8)" would be fine. Turns out that no, we don't. Every piece either should test every supported format, or uses only one format and doesn't care which, so it might as well use (or copy) the hardcoded YUY2 one. (Except the RGB8 check in init_video_mt, but I can just switch that to check something else.) -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3938#note_49351

1 0

Re: [PATCH v13 0/7] MR3938: winegstreamer: Implement CLSID_CMpegVideoCodec
by Alfred Agrell (＠Alcaro) 20 Oct '23

20 Oct '23

On Mon Oct 16 23:46:01 2023 +0000, Zebediah Figura wrote: > Wait, so is the data here generated with ffmpeg or GStreamer? Both. ffmpeg to generate a black video, then GStreamer to demux it and emit only the video elementary stream. Guess I should rewrite it to GStreamer only. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3938#note_49350

1 0

Re: [PATCH v13 0/7] MR3938: winegstreamer: Implement CLSID_CMpegVideoCodec
by Alfred Agrell (＠Alcaro) 20 Oct '23

20 Oct '23

On Mon Oct 16 23:45:48 2023 +0000, Zebediah Figura wrote: > That shouldn't be necessary. If the sink is disconnected the source > won't even be exposed. No, the output pin always exists, you just can't connect it. I checked. <https://gitlab.winehq.org/wine/wine/-/blob/427a6845e25569c161f17775fda175b8…> -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3938#note_49349

1 0

Re: [PATCH v13 0/7] MR3938: winegstreamer: Implement CLSID_CMpegVideoCodec
by Alfred Agrell (＠Alcaro) 20 Oct '23

20 Oct '23

On Mon Oct 16 23:45:52 2023 +0000, Zebediah Figura wrote: > We have amt_from_wg_format(), that should be usable here. Good point. It fills in a few fields in unexpected ways, but most are correct, so it's an improvement. And some of the incorrect fields look like omissions in that function, which are better fixed there. I tried running some tests locally, to check if something depends on the previous definition, but one failed because I compiled Wine without SChannel, another hit an assertion because I compiled without Vulkan, and several of them create windows all over which steal focus and make it hard to do anything else on the computer. I'll just leave that check for the CI. (And hope I don't miss it between the flaky tests already in master.) -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3938#note_49348

1 0

Re: [PATCH v13 0/7] MR3938: winegstreamer: Implement CLSID_CMpegVideoCodec
by Alfred Agrell (＠Alcaro) 20 Oct '23

20 Oct '23

On Mon Oct 16 23:45:45 2023 +0000, Zebediah Figura wrote: > This is correct, I think, but also orthogonal to the purpose of this > patch. Can you please split this out into a separate patch? I hope it doesn't mess with the decodebin chaining thing. But the mpegsplit and mpegvideo tests pass, so probably no big deal. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3938#note_49344

1 0

Re: [PATCH v13 0/7] MR3938: winegstreamer: Implement CLSID_CMpegVideoCodec
by Alfred Agrell (＠Alcaro) 20 Oct '23

20 Oct '23

On Mon Oct 16 23:45:46 2023 +0000, Zebediah Figura wrote: > Isn't this redundant with the same logic done in wg_parser_stream_seek()? Only if wg_parser_stream_seek has access to the duration. Which, uh, it does, so let's just force push that and pretend it didn't happen. (On a totally related note, GST_ERROR/etc shouldn't end with \n. I'll go clean that up too.) -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3938#note_49345

1 0

Re: [PATCH v13 0/7] MR3938: winegstreamer: Implement CLSID_CMpegVideoCodec
by Alfred Agrell (＠Alcaro) 20 Oct '23

20 Oct '23

On Mon Oct 16 23:45:56 2023 +0000, Zebediah Figura wrote: > Does the application actually use IAMStreamSelect::Info()? If so we > should have tests for it. Also, ideally this'd be a separate patch. > If not I'd just drop this hunk. Does "it calls the function, but doesn't really do anything with the result" count? https://github.com/krkrz/krkr2/blob/dec49af97e174d31059c3ccd7efc700ba3c6b78… It would be satisfied if IStreamSelect::Count was a semi-stub that just returns zero, but I suspect that's not the best idea. But tests, yes, absolutely. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3938#note_49346

1 0

Re: [PATCH v13 0/7] MR3938: winegstreamer: Implement CLSID_CMpegVideoCodec
by Alfred Agrell (＠Alcaro) 20 Oct '23

20 Oct '23

On Mon Oct 16 23:45:47 2023 +0000, Zebediah Figura wrote: > That doesn't seem right. What is this doing? It silences these warnings from the Wagamama demo: ``` (wine:1578450): GStreamer-CRITICAL **: 01:44:15.602: gst_event_new_qos: assertion 'diff >= 0 || -diff <= timestamp' failed 0:00:00.608062458 1578450 0x7f9190049ef0 ERROR WINE dlls/winegstreamer/wg_parser.c:486:wg_parser_stream_notify_qos: Failed to create QOS event. (wine:1578450): GStreamer-CRITICAL **: 01:44:15.602: gst_pad_push_event: assertion 'GST_IS_EVENT (event)' failed ``` But like the format change thing, it doesn't seem to do any actual harm. And I agree it is a weird solution. I guess it's safest to remove it and leave it for later. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3938#note_49347

1 0

Re: [PATCH v13 0/7] MR3938: winegstreamer: Implement CLSID_CMpegVideoCodec
by Alfred Agrell (＠Alcaro) 20 Oct '23

20 Oct '23

On Mon Oct 16 23:45:45 2023 +0000, Zebediah Figura wrote: > This is overestimation because we can't do any better, right? In that > case it probably deserves a comment just to clarify that's what's happening. Yeah, that entire function is confusing. It's supposed to return the max size of a compressed frame, but I don't think there is any real upper bound for that, you can cram in as many optional extensions as you want. So yes, it's guessing decompressed size as an upper bound. It'll break for 1x1 videos (can't fit the MPEG headers in three bytes), and videos crammed full of junk data, but let's just not care about those. But comments, sure, can do. And the Cinepak branch's comment is suspicious at best - what does biSizeImage have to do with compressed size? -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3938#note_49343

1 0

Re: [PATCH v2 0/1] MR4144: mfmediaengine: Mask some source flags returned from GetResourceCharacteristics(). - approved
by Alexandre Julliard (＠julliard) 19 Oct '23

19 Oct '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4144

1 0

Re: [PATCH v3 0/1] MR4137: commdlg: Set lCustData the same in GetSaveFileName as GetOpenFileName. - approved
by Alexandre Julliard (＠julliard) 19 Oct '23

19 Oct '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4137

1 0

Re: [PATCH v2 0/1] MR4124: wined3d: Use debugstr_fourcc instead of debugstr_an. - approved
by Alexandre Julliard (＠julliard) 19 Oct '23

19 Oct '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4124

1 0

Re: [PATCH v2 0/1] MR420: vkd3d-utils: Implement D3DStripShader(). - approved
by Alexandre Julliard (＠julliard) 19 Oct '23

19 Oct '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/420

1 0

Re: [PATCH v14 0/4] MR401: vkd3d-shader/dxil: Read CBV info. - approved
by Alexandre Julliard (＠julliard) 19 Oct '23

19 Oct '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/401

1 0

Re: [PATCH v2 0/4] MR419: vkd3d-shader/hlsl: Add support for RWTexture1DArray and RWTexture2DArray. - approved
by Alexandre Julliard (＠julliard) 19 Oct '23

19 Oct '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/419

1 0

Re: [PATCH v8 0/2] MR381: vkd3d-shader/tpf: Convert some of the semantic names to system values names when in compatibility mode. - approved
by Alexandre Julliard (＠julliard) 19 Oct '23

19 Oct '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/381

1 0

[PATCH 0/1] MR420: vkd3d-utils: Implement D3DStripShader().
by Henri Verbeet (＠hverbeet) 19 Oct '23

19 Oct '23

-- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/420

4 4

[PATCH v4 0/1] MR3988: winetts: Add stub dll.
by Shaun Ren (＠shaunren) 19 Oct '23

19 Oct '23

-- v4: msttsengine: Add stub dll. https://gitlab.winehq.org/wine/wine/-/merge_requests/3988

2 1

Re: [PATCH v2 0/1] MR4043: uxtheme: add some ordinals to spec file needed by Captvty
by Gabriel Ivăncescu (＠insn) 19 Oct '23

19 Oct '23

On Thu Oct 19 13:23:48 2023 +0000, Louis Lenders wrote: > Hi Zhiyi, I opened a new merge request here > https://gitlab.winehq.org/wine/wine/-/merge_requests/4143 as 'git push' > didn't work and don't know how to resolve it Did you force push? `git push -f origin` on your branch. This overwrites the remote branch with your local one. Normal push can only "add" commits, not overwrite prior ones. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4043#note_49317

1 0

[PATCH 0/1] MR4144: mfmediaengine: Mask some source flags returned from GetResourceCharacteristics().
by Nikolay Sivov (＠nsivov) 19 Oct '23

19 Oct '23

Signed-off-by: Nikolay Sivov <nsivov(a)codeweavers.com> -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4144

2 1

Re: [PATCH v3 0/8] MR417: vkd3d-shader/hlsl: Add ceil() function.
by Francisco Casas (＠fcasas) 19 Oct '23

19 Oct '23

On Thu Oct 19 13:43:21 2023 +0000, Francisco Casas wrote: > Oh no, you are right, compiling with the native compiler and running on > Windows we get those broken results, so it is not a problem of the > compiler itself. Repeating what we concluded via chat. The reason this test is giving broken results is that, even if `u` is `int4`, the SM1 backend expects to receive it formatted as an IEEE Standard 754 float, so the shader runner should pass it formatted that way. -- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/417#note_49315

1 0

[PATCH 0/7] MR4139: dmime, dmusic: Miscellaneous fixes.
by Rémi Bernon (＠rbernon) 19 Oct '23

19 Oct '23

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=55792 Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=55790 -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4139

3 12

[PATCH v5 0/6] MR4092: user32: Actually implement RealGetWindowClass{A/W}.
by Connor McAdams (＠cmcadams) 19 Oct '23

19 Oct '23

-- v5: user32: Pass real argument to NtUserGetClassName in RealGetWindowClass{A/W}. win32u: Add support for retrieving real window class ID across processes. user32: Set real window class ID for user32 static controls. win32u/tests: Add a test for real window class name retrieval. comctl32/tests: Add tests for RealGetWindowClass. user32/tests: Add tests for RealGetWindowClass. https://gitlab.winehq.org/wine/wine/-/merge_requests/4092

3 12

Re: [PATCH v2 0/2] MR4108: Improve DMI tables under Linux.
by Hans Leidekker (＠hans) 19 Oct '23

19 Oct '23

On Thu Oct 19 14:27:02 2023 +0000, eric pouech wrote: > should have embedded it inside **sd_id128_get_machine_app_specific** > (removing the machine-id parameter) > you mean derive by keeping readable a field explicitely marked as non > public !!! sd_id128_get_machine_app_specific() requires cooperation from the app. That's not something we can expect from Windows apps. Windows apps should treat this information with confidentiality just like Linux apps. The game whose name I forgot collected several more or less unique IDs and calculated a hash over those values. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4108#note_49305

1 0

Re: [PATCH v2 0/2] MR4108: Improve DMI tables under Linux.
by eric pouech (＠epo) 19 Oct '23

19 Oct '23

On Thu Oct 19 14:27:02 2023 +0000, Hans Leidekker wrote: > What should applications have used if /etc/machine-id wasn't readable? > I think it's fine to derive the missing fields from machine-id. should have embedded it inside **sd_id128_get_machine_app_specific** (removing the machine-id parameter) you mean derive by keeping readable a field explicitely marked as non public !!! -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4108#note_49304

1 0

Re: [PATCH v2 0/2] MR4108: Improve DMI tables under Linux.
by Hans Leidekker (＠hans) 19 Oct '23

19 Oct '23

What should applications have used if /etc/machine-id wasn't readable? I think it's fine to derive the missing fields from machine-id. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4108#note_49303

1 0

[PATCH v6 0/1] MR384: vkd3d: Replace the descriptor object cache with a thread-local implementation.
by Conor McCarthy (＠cmccarthy) 19 Oct '23

19 Oct '23

The PE build uses FlsAlloc(), which for our purposes makes no difference vs TlsAlloc(), and allows the use of a destruction callback. -- v6: vkd3d: Replace the descriptor object cache with a thread-local implementation. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/384

2 1

Re: [PATCH v3 0/8] MR417: vkd3d-shader/hlsl: Add ceil() function.
by Francisco Casas (＠fcasas) 19 Oct '23

19 Oct '23

On Thu Oct 19 13:35:46 2023 +0000, Francisco Casas wrote: > I see. So the `probe` part may be deserving of a `todo(sm<4)`. > I made patches for that on the second part of !418, but I think that for > now it is okay to leave the requirement. Oh no, you are right, compiling with the native compiler and running on Windows we get those broken results, so it is not a problem of the compiler itself. -- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/417#note_49297

1 0

2025

2024

2023

2022