- wine-gitlab - winehq.org

[PATCH v2 0/7] MR4110: dmime: Simplify message thread and use latency time to schedule messages.
by Rémi Bernon (＠rbernon) 17 Oct '23

17 Oct '23

-- v2: dmime: Use latency time to decide when to process messages. dmime: Update performance latency time with port latency. dmime: Use port latency time for messages with -1 time. dmusic: Forward IDirectMusicPort_Activate to synth and sink. dmsynth: Do nothing in IDirectMusicSynth_SetMasterClock. dmusic: Set synth sink master clock when creating port. dmime: Rewrite message thread with a condition variable. https://gitlab.winehq.org/wine/wine/-/merge_requests/4110

3 9

[PATCH 0/1] MR4103: ntdll: Support relocating the main exe
by André Zwing (＠AndreRH) 17 Oct '23

17 Oct '23

Only return when there's no relocation to do -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4103

3 6

[PATCH 0/1] MR411: vkd3d-shader/spirv: Initialise "symbol.descriptor_array" in spirv_compiler_emit_combined_sampler_declarations().
by Henri Verbeet (＠hverbeet) 17 Oct '23

17 Oct '23

-- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/411

3 3

[PATCH 0/1] MR410: tests: Specify argument types for dxcompiler_create().
by Henri Verbeet (＠hverbeet) 17 Oct '23

17 Oct '23

-- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/410

4 4

[PATCH v6 0/3] MR388: vkd3d-shader/dxil: Read some shader properties.
by Conor McCarthy (＠cmccarthy) 17 Oct '23

17 Oct '23

-- v6: vkd3d-shader/dxil: Read DXIL compute shader thread group dimensions. vkd3d-shader/dxil: Read DXIL global flags. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/388

3 4

[PATCH v2 0/10] MR413: Draft: ci: Run the crosstests on Windows.
by Giovanni Mascellani (＠giomasce) 17 Oct '23

17 Oct '23

This depends on !412, and might need some finishing touches before being ready. -- v2: ci: Run the HLSL compiler tests on Windows. ci: Run the HLSL preprocessor tests on Windows. ci: Run cross tests on Windows. tests: Skip processing resources according to [require] directives. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/413

3 11

[PATCH v3 0/6] MR4092: user32: Actually implement RealGetWindowClass{A/W}.
by Connor McAdams (＠cmcadams) 17 Oct '23

17 Oct '23

-- v3: user32: Pass real argument to NtUserGetClassName in RealGetWindowClass{A/W}. win32u: Add support for retrieving real window class ID across processes. user32: Set real window class ID for user32 standard controls. win32u/tests: Add a test for real window class name retrieval. comctl32/tests: Add tests for RealGetWindowClass. user32/tests: Add tests for RealGetWindowClass. https://gitlab.winehq.org/wine/wine/-/merge_requests/4092

3 10

[PATCH v3 0/1] MR4107: wbemprox: Use correct string id.
by eric pouech (＠epo) 17 Oct '23

17 Oct '23

Don't use hard coded string indexes as one of the expected string can be absent, hence decreasing its index; nothing ensures that the strings are placed in the order of the fields in the smbios structure. So use, smbios structures' indexes instead. Wbemprox was also expecting one string too much. Signed-off-by: Eric Pouech <epouech(a)codeweavers.com> -- v3: wbemprox: Use correct string id. https://gitlab.winehq.org/wine/wine/-/merge_requests/4107

3 3

Re: [PATCH v2 0/2] MR4108: Improve DMI tables under Linux.
by Hans Leidekker (＠hans) 17 Oct '23

17 Oct '23

On Tue Oct 17 13:58:32 2023 +0000, eric pouech wrote: > IMO there's no difference in privacy concerns between hardware ID and > software ones (some BIOS:es allow you to change the HW id, so the > boundary between HW or not is also not that clear). The point is what > they identify. > what are your concerns about following systemd recommandations? Like I said, Wine is not a regular application, it's just the middle layer between the Unix OS and Windows applications. Your proposal doesn't achieve systemd's goal because you can run multiple applications on Wine which would still get the same ID (even if run in different prefixes). -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4108#note_49001

1 0

Re: [PATCH v2 0/2] MR4108: Improve DMI tables under Linux.
by eric pouech (＠epo) 17 Oct '23

17 Oct '23

On Tue Oct 17 13:41:31 2023 +0000, Hans Leidekker wrote: > > concerning the migration phase: > > > > * do you have an idea of which applications make use of it? (asking in > case you have some idea, but likely we cannot be sure of all of it) > I remember working on a game but I forgot the name. Generally it's DRM > schemes that try to bind an account or install to a particular machine. > > * a countermeasure could be to set a flag in the Wine prefix > (dont_hash_machineid, at value 0 when not defined) to control the > activation of the hashing ; every new prefix would be created with the > flag set to 1 ; that would limit the impact, but not eradicate it (if > user reinstalls his/her app in newly created prefix) ; that could > eventually controlled in winecfg with more context on the pros&cons > I don't think we'd want such code in Wine. neither do I ;-) -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4108#note_48999

1 0

Re: [PATCH v2 0/2] MR4108: Improve DMI tables under Linux.
by eric pouech (＠epo) 17 Oct '23

17 Oct '23

On Tue Oct 17 13:41:33 2023 +0000, Hans Leidekker wrote: > > for the very same reason that /sys/class/dmi/id/board_serial, > chassis_serial, product_serial and product_uuid are not readable by user > > > > exposing directly /etc/machine-id is hence a major privacy concern > > > > Note: Windows expose these HW id:s without constraints whereas Linux > puts some limitations. > Right, and macOS also exposes a hardware ID. Windows/Mac applications > should be equally careful with that information. I don't think exposing > /etc/machine-id is at the same level though. It's not a hardware ID and > you can change it. If privacy is a concern when running Windows > applications an alternative would be to sandbox Wine and give it its own > machine ID. IMO there's no difference in privacy concerns between hardware ID and software ones (some BIOS:es allow you to change the HW id, so the boundary between HW or not is also not that clear). The point is what they identify. what are your concerns about following systemd recommandations? -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4108#note_48998

1 0

[PATCH 0/3] MR4127: dwrite: Clang warning fixes
by Jacek Caban (＠jacek) 17 Oct '23

17 Oct '23

This fixes -Wenum-conversion warnings (enabled by default on clang) and -Wpointer-sign warnings (enums are signed on MSVC target, so their pointers should not be implicitly converted to `unsigned int *`). -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4127

3 5

Re: [PATCH v2 0/2] MR4108: Improve DMI tables under Linux.
by Hans Leidekker (＠hans) 17 Oct '23

17 Oct '23

> concerning the migration phase: > > * do you have an idea of which applications make use of it? (asking in case you have some idea, but likely we cannot be sure of all of it) I remember working on a game but I forgot the name. Generally it's DRM schemes that try to bind an account or install to a particular machine. > * a countermeasure could be to set a flag in the Wine prefix (dont_hash_machineid, at value 0 when not defined) to control the activation of the hashing ; every new prefix would be created with the flag set to 1 ; that would limit the impact, but not eradicate it (if user reinstalls his/her app in newly created prefix) ; that could eventually controlled in winecfg with more context on the pros&cons I don't think we'd want such code in Wine. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4108#note_48993

1 0

Re: [PATCH v2 0/2] MR4108: Improve DMI tables under Linux.
by Hans Leidekker (＠hans) 17 Oct '23

17 Oct '23

> for the very same reason that /sys/class/dmi/id/board_serial, chassis_serial, product_serial and product_uuid are not readable by user > > exposing directly /etc/machine-id is hence a major privacy concern > > Note: Windows expose these HW id:s without constraints whereas Linux puts some limitations. Right, and macOS also exposes a hardware ID. Windows/Mac applications should be equally careful with that information. I don't think exposing /etc/machine-id is at the same level though. It's not a hardware ID and you can change it. If privacy is a concern when running Windows applications an alternative would be to sandbox Wine and give it its own machine ID. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4108#note_48991

1 0

[PATCH v9 0/7] MR401: Draft: vkd3d-shader/dxil: Read CBV info.
by Conor McCarthy (＠cmccarthy) 17 Oct '23

17 Oct '23

Goes atop MR 388 (the error codes would clash otherwise). The last four commits belong to this MR. -- v9: vkd3d-shader: Clone descriptor scan info from struct vkd3d_shader_desc. vkd3d-shader/dxil: Read CBV descriptors. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/401

3 9

[PATCH 0/2] MR4108: Improve DMI tables under Linux.
by eric pouech (＠epo) 17 Oct '23

17 Oct '23

This MR improves Wine's DMI tables by: - no longer exposing /etc/machine-id content. Current documentation of systemd strongly suggests to use a hash of it (with app dedicated key). (1) - generates DMI entries for files that are no longer user readable on Linux (like bios serial number). The values are derived from hashed value in step #1. (1) current implementation integrates into unix ntdll a bunch of sha 256 related code. It's basically a reimplementation of libsystemd's sd_id128_get_machine_app_specific(). We could alternatively dynamically link to libsystemd.so. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4108

3 6

[PATCH v5 0/2] MR381: vkd3d-shader/tpf: Convert some of the semantic names to system values names when in compatibility mode.
by Nikolay Sivov (＠nsivov) 17 Oct '23

17 Oct '23

Signed-off-by: Nikolay Sivov <nsivov(a)codeweavers.com> -- v5: programs/vkd3d-compiler: Dynamically allocate options array. vkd3d-shader/tpf: Convert some of the semantic names to system values names when in compatibility mode. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/381

4 4

[PATCH v16 0/8] MR361: vkd3d-shader/hlsl: Initial support for 'switch' statement.
by Nikolay Sivov (＠nsivov) 17 Oct '23

17 Oct '23

Signed-off-by: Nikolay Sivov <nsivov(a)codeweavers.com> -- v16: vkd3d-shader/tpf: Write out 'switch' statements. vkd3d-shader/hlsl: Add a pass to validate switch cases blocks. vkd3d-shader/hlsl: Add a pass to remove unreachable code. vkd3d-shader/hlsl: Add copy propagation logic for switches. vkd3d-shader/hlsl: Validate break/continue context. vkd3d-shader/hlsl: Check for duplicate case statements. vkd3d-shader/hlsl: Add initial support for parsing 'switch' statements. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/361

4 16

[PATCH 0/1] MR4125: gdi32: Fix leak in GdiDeleteSpoolFileHandle.
by Piotr Caban (＠piotr) 17 Oct '23

17 Oct '23

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/4125

3 2

[PATCH 0/1] MR4126: winex11.drv: Send missed KEYUP events on KeymapNotify.
by Arek Hiler (＠ivyl) 17 Oct '23

17 Oct '23

Full focus lost / focus gained events on the Windows side are not feasible for X11's FocusIn/FocusOut events generated by keyboard grabs (see XGrabKeyboard()) that are used for example for Atl+Tab handling. Using them would degrade user's experience by causing the window to minimize or flash multiple times depending on a game/window manager combo. Because of that the programs may miss on some KEYUP events that happen during the grab, and since there are no focus changes on the Windows side the state doesn't get resynced. This change attempts to improve user experience by syncing any missed key release events that happened while the window haven't had focus on the X11 side. There's no syncing of key presses as those are more problematic because of window manager quirks, e.g. on KDE it may end up syncing the Tab press portion of Alt+Tab. Luckily missing key events for keys that were pressed and not released while the WM had the keyboard grab is not nearly as confusing as stuck keys. For Warhammer: Chaosbane, theHunter: Call of the Wild, Far Cry Primal and many other games that end up with stuck Alt after Alt+Tabbing. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4126

2 1

[PATCH 0/9] MR413: Draft: ci: Run the crosstests on Windows.
by Giovanni Mascellani (＠giomasce) 17 Oct '23

17 Oct '23

This depends on !412, and might need some finishing touches before being ready. -- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/413

2 9

Re: [PATCH v2 0/1] MR4107: wbemprox: Use correct string id.
by Hans Leidekker (＠hans) 17 Oct '23

17 Oct '23

Hans Leidekker (@hans) commented about dlls/wbemprox/builtin.c: > rec->manufacturer = get_bios_manufacturer( buf, len ); > rec->name = L"Default System BIOS"; > rec->releasedate = get_bios_releasedate( buf, len ); > - rec->serialnumber = get_bios_serialnumber( buf, len ); > + rec->serialnumber = L"Serial number"; You also need to remove COL_FLAG_DYNAMIC from the column definition otherwise free() will be called on a static string. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4107#note_48966

1 0

Re: [PATCH v2 0/1] MR4107: wbemprox: Use correct string id.
by Hans Leidekker (＠hans) 17 Oct '23

17 Oct '23

Hans Leidekker (@hans) commented about dlls/wbemprox/builtin.c: > { > const struct smbios_header *hdr; > - const struct smbios_baseboard *baseboard; > UINT offset; > > - if (!(hdr = find_smbios_entry( SMBIOS_TYPE_BASEBOARD, buf, len ))) return NULL; > + if (!(hdr = find_smbios_entry( type, buf, len ))) return NULL; > > - baseboard = (const struct smbios_baseboard *)hdr; > - offset = (const char *)baseboard - buf + baseboard->hdr.length; > - return get_smbios_string( id, buf, offset, len ); > + if (field_offset + sizeof(BYTE) > hdr->length) return NULL; > + > + offset = (const char *)hdr - buf + hdr->length; > + return get_smbios_string_internal( ((const BYTE*)hdr)[field_offset], buf, offset, len ); > } Please add a space before the asterisk. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4107#note_48965

1 0

Re: [PATCH v2 0/1] MR4107: wbemprox: Use correct string id.
by Hans Leidekker (＠hans) 17 Oct '23

17 Oct '23

Hans Leidekker (@hans) commented about dlls/wbemprox/builtin.c: > return hdr; > } > > -static WCHAR *get_smbios_string( BYTE id, const char *buf, UINT offset, UINT buflen ) > +static WCHAR *get_smbios_string_internal( BYTE id, const char *buf, UINT offset, UINT buflen ) > { get_smbios_string_by_id() is a better name. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4107#note_48964

1 0

[PATCH 0/1] MR4112: mf/tests: Increase buffer to prevent stack corruption
by Fabian Maurer (＠DarkShadow44) 17 Oct '23

17 Oct '23

init_dmo_media_type_video uses head + extra bytes memory, and with MEDIASUBTYPE_RGB8 the extra bytes are already 1024. This leads to stack corruption. Note that not all of those are strictly necessary to prevent a crash, but I think it's safer in case it becomes relevant in the future. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4112

4 6

[PATCH v3 0/16] MR4046: windows.media.mediacontrol: Implement some IMusicDisplayProperties and IMusicDisplayProperties2 properties.
by Mohamad Al-Jaf (＠maljaf) 17 Oct '23

17 Oct '23

Called by Roon. -- v3: windows.media.mediacontrol: Return success in ISystemMediaTransportControlsDisplayUpdater::Update(). windows.media.mediacontrol: Implement IMusicDisplayProperties2::get/put_AlbumTitle(). windows.media.mediacontrol/tests: Add IMusicDisplayProperties2::get/put_AlbumTitle() tests. windows.media.mediacontrol: Add IMusicDisplayProperties2 stub interface. include: Add IMusicDisplayProperties2 interface definition. windows.media.mediacontrol: Implement IMusicDisplayProperties::get/put_Artist(). windows.media.mediacontrol/tests: Add IMusicDisplayProperties::get/put_Artist() tests. windows.media.mediacontrol: Implement IMusicDisplayProperties::get/put_Title(). windows.media.mediacontrol/tests: Add IMusicDisplayProperties::get/put_Title() tests. windows.media.mediacontrol: Implement ISystemMediaTransportControlsDisplayUpdater::get_MusicProperties(). include: Add IMusicDisplayProperties interface definition. windows.media.mediacontrol: Implement ISystemMediaTransportControlsDisplayUpdater::get/put_Type(). windows.media.mediacontrol/tests: Add ISystemMediaTransportControlsDisplayUpdater::get/put_Type() tests. windows.media.mediacontrol: Implement ISystemMediaTransportControls::get_DisplayUpdater(). This merge request has too many patches to be relayed via email. Please visit the URL below to see the contents of the merge request. https://gitlab.winehq.org/wine/wine/-/merge_requests/4046

2 2

Re: [PATCH v5 0/8] MR3994: include: Introduce wine_dbgstr_fourcc and debugstr_fourcc.
by Alex Henrie (＠alexhenrie) 17 Oct '23

17 Oct '23

On Tue Oct 17 05:34:53 2023 +0000, Nikolay Sivov wrote: > We have a number of debugstr_an(..., 4) used for the same purpose in > different modules. It will give different output if replaced with fourcc > helper, because of isprint(), but still might be worth considering. Thanks for pointing that out. I've started to send merge requests to clean those up. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3994#note_48952

1 0

[PATCH 0/1] MR4121: iccvid: Use debugstr_fourcc instead of debugstr_an.
by Alex Henrie (＠alexhenrie) 17 Oct '23

17 Oct '23

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/4121

2 1

[PATCH 0/2] MR4115: loader: Translate wine.desktop to Catalan.
by Alex Henrie (＠alexhenrie) 17 Oct '23

17 Oct '23

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/4115

2 2

[PATCH 0/2] MR4114: loader: Associate Wine with batch files.
by Alex Henrie (＠alexhenrie) 17 Oct '23

17 Oct '23

It is really nice to be able to double-click batch files and have them run in an interactive console window, just like on Windows. If this patch doesn't work for you, you may need a newer version of the shared-mime-info package. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4114

2 2

[PATCH v2 0/4] MR4113: ntdll: Use .seh handler in call_unwind_handler() on x64.
by Paul Gofman (＠gofman) 17 Oct '23

17 Oct '23

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=52396 -- v2: ntdll: Use .seh handler in call_unwind_handler() on x64. ntdll/tests: Add test for collided unwind. ntdll: Use .seh handler in call_handler() on x64. ntdll: Set EH_NESTED_CALL flag in call_stack_handlers() on x64. https://gitlab.winehq.org/wine/wine/-/merge_requests/4113

2 4

[PATCH 0/4] MR4113: ntdll: Use .seh handler in call_unwind_handler() on x64.
by Paul Gofman (＠gofman) 17 Oct '23

17 Oct '23

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=52396 -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4113

2 4

[PATCH v2 0/12] MR408: Draft: vkd3d-shader/dxil: Implement constant buffer loads.
by Conor McCarthy (＠cmccarthy) 17 Oct '23

17 Oct '23

Goes atop MR 388 and 401. The last five commits belong to this MR. -- v2: vkd3d-shader/dxil: Implement the DXIL EXTRACTVAL instruction. vkd3d-shader/spirv: Support scalar swizzle of vector SSA registers. vkd3d-shader/dxil: Implement DX instruction CBufferLoadLegacy. vkd3d-shader/dxil: Implement DX instruction CreateHandle. vkd3d-shader/dxil: Move the register_address_init() index parameter to position 2. vkd3d-shader: Clone descriptor scan info from struct vkd3d_shader_desc. vkd3d-shader/dxil: Read CBV descriptors. vkd3d-shader/dxil: Validate the descriptor list metadata nodes. vkd3d-shader/spirv: Align constant buffer sizes to 16 bytes. vkd3d-shader/dxil: Read DXIL compute shader thread group dimensions. vkd3d-shader/dxil: Read DXIL global flags. vkd3d-shader: Define more global flags. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/408

2 12

[PATCH v8 0/7] MR401: Draft: vkd3d-shader/dxil: Read CBV info.
by Conor McCarthy (＠cmccarthy) 17 Oct '23

17 Oct '23

Goes atop MR 388 (the error codes would clash otherwise). The last four commits belong to this MR. -- v8: vkd3d-shader: Clone descriptor scan info from struct vkd3d_shader_desc. vkd3d-shader/dxil: Read CBV descriptors. vkd3d-shader/dxil: Validate the descriptor list metadata nodes. vkd3d-shader/spirv: Align constant buffer sizes to 16 bytes. vkd3d-shader/dxil: Read DXIL compute shader thread group dimensions. vkd3d-shader/dxil: Read DXIL global flags. vkd3d-shader: Define more global flags. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/401

2 7

[PATCH v5 0/3] MR388: vkd3d-shader/dxil: Read some shader properties.
by Conor McCarthy (＠cmccarthy) 17 Oct '23

17 Oct '23

-- v5: vkd3d-shader/dxil: Read DXIL compute shader thread group dimensions. vkd3d-shader/dxil: Read DXIL global flags. vkd3d-shader: Define more global flags. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/388

2 3

Re: [PATCH v6 0/1] MR3970: quartz/tests: Improve VMR9 ChangeD3DDevice test
by Alfred Agrell (＠Alcaro) 16 Oct '23

16 Oct '23

On Mon Oct 16 22:21:57 2023 +0000, Zebediah Figura wrote: > Hrm, that's suspicious, IMemAllocator::GetBuffer() returns > VFW_E_NOT_COMMITTED. Does the VMR's IMemAllocator change by any chance > when we reconnect? I.e. is IMemInputPin::GetAllocator() actually > returning the same allocator that it was returning before? Worth checking, but the answer is they're the same. https://testbot.winehq.org/JobDetails.pl?Key=138797&f101=exe64.report (First - the one already acquired. Second - after changing and sleeping. Third - after decommitting and recommitting.) As I may have said, I have a vague suspicion this component is haunted. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3970#note_48919

1 0

Re: [PATCH v13 0/7] MR3938: winegstreamer: Implement CLSID_CMpegVideoCodec
by Zebediah Figura (＠zfigura) 16 Oct '23

16 Oct '23

On Tue Oct 3 09:21:16 2023 +0000, Rémi Bernon wrote: > I don't know whether this is correct or not, I think it'd be better to > leave this aspect aside for now as like you said this is going a bit out > of the scope of this MR. I would expect quartz to do one of three things, although others are possible: * ignore format changes entirely, * report the new format in the sample itself, via IMediaSample::GetMediaType(), * reconnect the downstream pin. In this case, as I understand, there's no real format change, it's just that GStreamer gains a bit of information more asynchronously; in that case nothing should happen. Probably we shouldn't even be reporting a format change if the translated wg_format doesn't change. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3938#note_48917

1 0

Re: [PATCH v13 0/7] MR3938: winegstreamer: Implement CLSID_CMpegVideoCodec
by Zebediah Figura (＠zfigura) 16 Oct '23

16 Oct '23

Hi, really sorry about the very late review on this one (I was out for a while, and then spent a lot of time catching up on review while I was out, and then trying to get some more important Wine work done...) 2/7, seeking parts aside, is broadly doing the right thing (from my perspective) but I would like to see it arranged differently. What I would like to see is something like the following, in a series of individual patches: * Introduce a wg_parser_create option to use the encoded format; this should end up being translated to "chain_decodebins" basically as you have it. I would also rename that to something like "output_compressed" (with inverted meaning). Note that in this case autoplug-continue already does what we want, you shouldn't need to set the "caps" property on top of that. * Use this property, plus WG_PARSER_DECODEBIN, in the existing frontend instead of WG_PARSER_MPEGAUDIOPARSE. Delete WG_PARSER_MPEGAUDIOPARSE. * Ideally patch 1/7 should be moved from the beginning of the series to here. * Add MPEG-1 system stream support to the quartz frontend. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3938#note_48918

1 0

Re: [PATCH v13 0/7] MR3938: winegstreamer: Implement CLSID_CMpegVideoCodec
by Zebediah Figura (＠zfigura) 16 Oct '23

16 Oct '23

Zebediah Figura (@zfigura) commented about dlls/quartz/tests/mpegvideo.c: > + HRESULT hr = CoCreateInstance(&CLSID_CMpegVideoCodec, NULL, CLSCTX_INPROC_SERVER, > + &IID_IBaseFilter, (void **)&filter); > + ok(hr == S_OK, "Got hr %#lx.\n", hr); > + return filter; > +} > + > +static inline BOOL compare_media_types(const AM_MEDIA_TYPE *a, const AM_MEDIA_TYPE *b) > +{ > + return !memcmp(a, b, offsetof(AM_MEDIA_TYPE, pbFormat)) > + && !memcmp(a->pbFormat, b->pbFormat, a->cbFormat); > +} > + > +enum video_type_t { > + vt_yv12, vt_y41p, vt_yuy2, vt_uyvy, > + vt_rgb24, vt_rgb32, vt_rgb565, vt_rgb555, vt_rgb8, > +}; Usually enum values are capitalized; also, _t is usually reserved for typedefs. That said, do we even want this enum? Is there any instance where we shouldn't just iterate over the whole array? Two of these formats are todo, but I think something like "todo_wine_if (i == 1 || i == 8)" would be fine. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3938#note_48916

1 0

Re: [PATCH v13 0/7] MR3938: winegstreamer: Implement CLSID_CMpegVideoCodec
by Zebediah Figura (＠zfigura) 16 Oct '23

16 Oct '23

Zebediah Figura (@zfigura) commented about dlls/quartz/tests/mpegvideo.c: > + IPin_Release(pin); > + > + ref = IBaseFilter_Release(filter); > + ok(!ref, "Got outstanding refcount %ld.\n", ref); > +} > + > +struct testfilter > +{ > + struct strmbase_filter filter; > + struct strmbase_source source; > + struct strmbase_sink sink; > + const AM_MEDIA_TYPE *mt; > + unsigned int got_sample, got_new_segment, got_eos, got_begin_flush, got_end_flush; > + REFERENCE_TIME expected_start_time; > + REFERENCE_TIME expected_stop_time; > + BOOL wine_wrong_stop_time; The usual convention for something like this would be "todo_stop_time". Same for "wine_fail" below, that would be "todo". -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3938#note_48915

1 0

Re: [PATCH v13 0/7] MR3938: winegstreamer: Implement CLSID_CMpegVideoCodec
by Zebediah Figura (＠zfigura) 16 Oct '23

16 Oct '23

Zebediah Figura (@zfigura) commented about dlls/quartz/tests/mpegvideo.c: > +static HRESULT WINAPI testsink_Receive(struct strmbase_sink *iface, IMediaSample *sample) > +{ > + struct testfilter *filter = impl_from_strmbase_filter(iface->pin.filter); > + REFERENCE_TIME start, stop; > + HRESULT hr; > + LONG size; > + > + size = IMediaSample_GetSize(sample); > + ok(size == 1536, "Got size %lu.\n", size); > + size = IMediaSample_GetActualDataLength(sample); > + ok(size == 1536, "Got actual size %lu.\n", size); > + > + start = 0xdeadbeef; > + stop = 0xdeadbeef; > + hr = IMediaSample_GetTime(sample, &start, &stop); > + ok(hr == S_OK, "Got hr %#lx.\n", hr); Can you please also check (at least the return value of) IMediaSample::GetMediaType()? I'm rather curious if it's updated or not. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3938#note_48914

1 0

Re: [PATCH v13 0/7] MR3938: winegstreamer: Implement CLSID_CMpegVideoCodec
by Zebediah Figura (＠zfigura) 16 Oct '23

16 Oct '23

Zebediah Figura (@zfigura) commented about dlls/quartz/tests/mpegvideo.c: > + > + memcpy(target_data, data, len); > + hr = IMediaSample_SetActualDataLength(sample, len); > + ok(hr == S_OK, "Got hr %#lx.\n", hr); > + > + hr = IMemInputPin_Receive(input, sample); > + todo_wine_if(wine_fail) /* 0xc00d6d61 is MF_E_TRANSFORM_STREAM_CHANGE */ > + ok(hr == S_OK, "Got hr %#lx.\n", hr); > +} > + > +static void test_send_video(IMemInputPin *input, IMediaSample *sample) > +{ > + /* ffmpeg -t 1.0 -s 32x24 -f rawvideo -pix_fmt rgb24 -r 25 -i /dev/zero -c:v mpeg1video -q:v 0 -format mpegvideo empty.mpeg */ > + /* gst-launch-1.0 filesrc location=empty.mpeg ! mpegpsdemux ! mpegvideoparse ! filesink location=empty-es.mpeg */ > + /* then truncate to taste */ > + /* each 00 00 01 b3 or 00 00 01 00 starts a new frame, except the first 00 00 01 00 after a 00 00 01 b3 */ Wait, so is the data here generated with ffmpeg or GStreamer? -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3938#note_48912

1 0

Re: [PATCH v13 0/7] MR3938: winegstreamer: Implement CLSID_CMpegVideoCodec
by Zebediah Figura (＠zfigura) 16 Oct '23

16 Oct '23

Zebediah Figura (@zfigura) commented about dlls/quartz/tests/mpegvideo.c: > + ok(hr == S_OK, "Got hr %#lx.\n", hr); > + > + size = IMediaSample_GetSize(sample); > + ok(size == 256, "Got size %ld.\n", size); > + > + hr = IMediaSample_SetTime(sample, NULL, NULL); > + ok(hr == S_OK, "Got hr %#lx.\n", hr); > + > + sink->expected_start_time = 0; > + sink->expected_stop_time = 0; > + sink->wine_wrong_stop_time = FALSE; > + hr = IMediaSample_SetTime(sample, &sink->expected_start_time, &sink->expected_stop_time); > + ok(hr == S_OK, "Got hr %#lx.\n", hr); > + > + test_send_video(input, sample); > + ok(sink->got_sample >= 1, "Got %u calls to Receive().\n", sink->got_sample); Shouldn't we get an exact number of frames here? Or is that not consistent somehow? -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3938#note_48913

1 0

Re: [PATCH v13 0/7] MR3938: winegstreamer: Implement CLSID_CMpegVideoCodec
by Zebediah Figura (＠zfigura) 16 Oct '23

16 Oct '23

Zebediah Figura (@zfigura) commented about dlls/quartz/tests/mpegsplit.c: > HRESULT hr; > > hr = IMediaSample_GetTime(sample, &start, &end); > - todo_wine_if (hr == VFW_S_NO_STOP_TIME) ok(hr == S_OK, "Got hr %#lx.\n", hr); > + todo_wine_if (hr == VFW_S_NO_STOP_TIME) { > + ok(hr == S_OK || (filter->sample_count > 0 && hr == VFW_E_SAMPLE_TIME_NOT_SET), "Got hr %#lx.\n", hr); > + } If Windows never sets the sample time for video samples after the first then we should probably make this check more restrictive to explicitly check that. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3938#note_48910

1 0

Re: [PATCH v13 0/7] MR3938: winegstreamer: Implement CLSID_CMpegVideoCodec
by Zebediah Figura (＠zfigura) 16 Oct '23

16 Oct '23

Zebediah Figura (@zfigura) commented about dlls/quartz/tests/mpegsplit.c: > ok(ret, "Failed to delete file, error %lu.\n", GetLastError()); > } > > +static void test_video_file(void) > +{ > + const WCHAR *filename = load_resource(L"test.mpg"); > + IBaseFilter *filter = create_mpeg_splitter(); > + struct testfilter testsink_video; > + struct testfilter testsink_audio; > + IPin *source_video = NULL; > + IPin *source_audio = NULL; > + IMediaControl *control; > + IFilterGraph2 *graph; > + IAMStreamSelect* sel; > + DWORD n_streams; "stream_count" is the usual naming convention for this kind of thing. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3938#note_48911

1 0

Re: [PATCH v13 0/7] MR3938: winegstreamer: Implement CLSID_CMpegVideoCodec
by Zebediah Figura (＠zfigura) 16 Oct '23

16 Oct '23

Zebediah Figura (@zfigura) commented about dlls/winegstreamer/quartz_transform.c: > +}; > + > +HRESULT mpeg_video_codec_create(IUnknown *outer, IUnknown **out) > +{ > + static const struct wg_format output_format = > + { > + .major_type = WG_MAJOR_TYPE_VIDEO, > + .u.video = { > + .format = WG_VIDEO_FORMAT_I420, > + /* size doesn't matter, this one is only used to check if the GStreamer plugin exists */ > + }, > + }; > + static const struct wg_format input_format = > + { > + .major_type = WG_MAJOR_TYPE_VIDEO_MPEG1, > + .u.video_mpeg1 = {}, You can delete this line. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3938#note_48907

1 0

Re: [PATCH v13 0/7] MR3938: winegstreamer: Implement CLSID_CMpegVideoCodec
by Zebediah Figura (＠zfigura) 16 Oct '23

16 Oct '23

Zebediah Figura (@zfigura) commented about dlls/winegstreamer/quartz_parser.c: > IUnknown **object, IUnknown **unknown) > { > - FIXME("iface %p, index %ld, mt %p, flags %p, lcid %p, group %p, name %p, object %p, unknown %p, stub!\n", > - iface, index, mt, flags, lcid, group, name, object, unknown); > - return E_NOTIMPL; > + struct parser *filter = impl_from_IAMStreamSelect(iface); > + wg_parser_stream_t stream = wg_parser_get_stream(filter->wg_parser, index); > + > + FIXME("filter %p, index %ld, mt %p, flags %p, lcid %p, group %p, name %p, object %p, unknown %p, semi-stub!\n", > + filter, index, mt, flags, lcid, group, name, object, unknown); > + > + if (!filter->sink.pin.peer) > + return VFW_E_NOT_CONNECTED; > + if (index < 0 || index >= wg_parser_get_stream_count(filter->wg_parser)) > + return S_FALSE; > + Does the application actually use IAMStreamSelect::Info()? If so we should have tests for it. Also, ideally this'd be a separate patch. If not I'd just drop this hunk. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3938#note_48908

1 0

Re: [PATCH v13 0/7] MR3938: winegstreamer: Implement CLSID_CMpegVideoCodec
by Zebediah Figura (＠zfigura) 16 Oct '23

16 Oct '23

Zebediah Figura (@zfigura) commented about dlls/winegstreamer/quartz_parser.c: > > static HRESULT WINAPI stream_select_Count(IAMStreamSelect *iface, DWORD *count) > { > - FIXME("iface %p, count %p, stub!\n", iface, count); > - return E_NOTIMPL; > + struct parser *filter = impl_from_IAMStreamSelect(iface); > + TRACE("filter %p, count %p\n", filter, count); > + if (filter->sink.pin.peer) > + *count = wg_parser_get_stream_count(filter->wg_parser); > + else > + *count = 0; > + return S_OK; This probably needs to take the filter CS. Same for Info() for that matter. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3938#note_48909

1 0

Re: [PATCH v13 0/7] MR3938: winegstreamer: Implement CLSID_CMpegVideoCodec
by Zebediah Figura (＠zfigura) 16 Oct '23

16 Oct '23

Zebediah Figura (@zfigura) commented about dlls/winegstreamer/quartz_transform.c: > + return VFW_S_NO_MORE_ITEMS; > + > + input_format = (MPEG1VIDEOINFO*)filter->sink.pin.mt.pbFormat; > + > + output_format = CoTaskMemAlloc(sizeof(*output_format)); > + if (!output_format) > + return E_OUTOFMEMORY; > + > + memcpy(output_format, &input_format->hdr, sizeof(VIDEOINFOHEADER)); > + output_format->bmiHeader.biPlanes = 1; > + output_format->bmiHeader.biBitCount = video_types[index].bits_per_pixel; > + output_format->bmiHeader.biCompression = video_types[index].compression; > + output_format->bmiHeader.biSizeImage = > + wg_format_get_bytes_for_uncompressed(video_types[index].wg_format, > + output_format->bmiHeader.biWidth, output_format->bmiHeader.biHeight); > + output_format->dwBitRate = MulDiv(output_format->bmiHeader.biSizeImage * 8, 10000000, output_format->AvgTimePerFrame); We have amt_from_wg_format(), that should be usable here. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3938#note_48906

1 0

Re: [PATCH v13 0/7] MR3938: winegstreamer: Implement CLSID_CMpegVideoCodec
by Zebediah Figura (＠zfigura) 16 Oct '23

16 Oct '23

Zebediah Figura (@zfigura) commented about dlls/winegstreamer/quartz_transform.c: > + struct { > + const GUID *subtype; > + wg_video_format wg_format; > + int bits_per_pixel; > + DWORD compression; > + } static const video_types[] = { > + { &MEDIASUBTYPE_YV12, WG_VIDEO_FORMAT_YV12, 12, MAKEFOURCC('Y','V','1','2') }, > + { &MEDIASUBTYPE_YUY2, WG_VIDEO_FORMAT_YUY2, 16, MAKEFOURCC('Y','U','Y','2') }, > + { &MEDIASUBTYPE_UYVY, WG_VIDEO_FORMAT_UYVY, 16, MAKEFOURCC('U','Y','V','Y') }, > + { &MEDIASUBTYPE_RGB24, WG_VIDEO_FORMAT_BGR, 24, BI_RGB }, > + { &MEDIASUBTYPE_RGB32, WG_VIDEO_FORMAT_BGRx, 32, BI_RGB }, > + { &MEDIASUBTYPE_RGB565, WG_VIDEO_FORMAT_RGB16, 16, BI_BITFIELDS }, > + { &MEDIASUBTYPE_RGB555, WG_VIDEO_FORMAT_RGB15, 16, BI_RGB }, > + }; > + > + MPEG1VIDEOINFO *input_format; const MPEG1VIDEOINFO * -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3938#note_48905

1 0

Re: [PATCH v13 0/7] MR3938: winegstreamer: Implement CLSID_CMpegVideoCodec
by Zebediah Figura (＠zfigura) 16 Oct '23

16 Oct '23

Zebediah Figura (@zfigura) commented about dlls/winegstreamer/quartz_transform.c: > + { &MEDIASUBTYPE_YUY2, WG_VIDEO_FORMAT_YUY2, 16, MAKEFOURCC('Y','U','Y','2') }, > + { &MEDIASUBTYPE_UYVY, WG_VIDEO_FORMAT_UYVY, 16, MAKEFOURCC('U','Y','V','Y') }, > + { &MEDIASUBTYPE_RGB24, WG_VIDEO_FORMAT_BGR, 24, BI_RGB }, > + { &MEDIASUBTYPE_RGB32, WG_VIDEO_FORMAT_BGRx, 32, BI_RGB }, > + { &MEDIASUBTYPE_RGB565, WG_VIDEO_FORMAT_RGB16, 16, BI_BITFIELDS }, > + { &MEDIASUBTYPE_RGB555, WG_VIDEO_FORMAT_RGB15, 16, BI_RGB }, > + }; > + > + MPEG1VIDEOINFO *input_format; > + VIDEOINFO *output_format; > + > + if (!filter->sink.pin.peer) > + return VFW_S_NO_MORE_ITEMS; > + > + if (index >= 7) > + return VFW_S_NO_MORE_ITEMS; ARRAY_SIZE(video_types) -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3938#note_48902

1 0

Re: [PATCH v13 0/7] MR3938: winegstreamer: Implement CLSID_CMpegVideoCodec
by Zebediah Figura (＠zfigura) 16 Oct '23

16 Oct '23

Zebediah Figura (@zfigura) commented about dlls/winegstreamer/quartz_transform.c: > + } static const video_types[] = { > + { &MEDIASUBTYPE_YV12, WG_VIDEO_FORMAT_YV12, 12, MAKEFOURCC('Y','V','1','2') }, > + { &MEDIASUBTYPE_YUY2, WG_VIDEO_FORMAT_YUY2, 16, MAKEFOURCC('Y','U','Y','2') }, > + { &MEDIASUBTYPE_UYVY, WG_VIDEO_FORMAT_UYVY, 16, MAKEFOURCC('U','Y','V','Y') }, > + { &MEDIASUBTYPE_RGB24, WG_VIDEO_FORMAT_BGR, 24, BI_RGB }, > + { &MEDIASUBTYPE_RGB32, WG_VIDEO_FORMAT_BGRx, 32, BI_RGB }, > + { &MEDIASUBTYPE_RGB565, WG_VIDEO_FORMAT_RGB16, 16, BI_BITFIELDS }, > + { &MEDIASUBTYPE_RGB555, WG_VIDEO_FORMAT_RGB15, 16, BI_RGB }, > + }; > + > + MPEG1VIDEOINFO *input_format; > + VIDEOINFO *output_format; > + > + if (!filter->sink.pin.peer) > + return VFW_S_NO_MORE_ITEMS; > + That shouldn't be necessary. If the sink is disconnected the source won't even be exposed. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3938#note_48903

1 0

Re: [PATCH v13 0/7] MR3938: winegstreamer: Implement CLSID_CMpegVideoCodec
by Zebediah Figura (＠zfigura) 16 Oct '23

16 Oct '23

Zebediah Figura (@zfigura) commented about dlls/winegstreamer/quartz_transform.c: > +static HRESULT mpeg_video_codec_source_get_media_type(struct transform *filter, unsigned int index, AM_MEDIA_TYPE *mt) > +{ > + struct { > + const GUID *subtype; > + wg_video_format wg_format; > + int bits_per_pixel; > + DWORD compression; > + } static const video_types[] = { > + { &MEDIASUBTYPE_YV12, WG_VIDEO_FORMAT_YV12, 12, MAKEFOURCC('Y','V','1','2') }, > + { &MEDIASUBTYPE_YUY2, WG_VIDEO_FORMAT_YUY2, 16, MAKEFOURCC('Y','U','Y','2') }, > + { &MEDIASUBTYPE_UYVY, WG_VIDEO_FORMAT_UYVY, 16, MAKEFOURCC('U','Y','V','Y') }, > + { &MEDIASUBTYPE_RGB24, WG_VIDEO_FORMAT_BGR, 24, BI_RGB }, > + { &MEDIASUBTYPE_RGB32, WG_VIDEO_FORMAT_BGRx, 32, BI_RGB }, > + { &MEDIASUBTYPE_RGB565, WG_VIDEO_FORMAT_RGB16, 16, BI_BITFIELDS }, > + { &MEDIASUBTYPE_RGB555, WG_VIDEO_FORMAT_RGB15, 16, BI_RGB }, > + }; Let's match the coding style used elsewhere please, regarding things like spacing and storage classifiers placement; see e.g. amt_to_wg_format_video for an example. "wg_video_format" should be "enum wg_video_format". -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3938#note_48904

1 0

Re: [PATCH v13 0/7] MR3938: winegstreamer: Implement CLSID_CMpegVideoCodec
by Zebediah Figura (＠zfigura) 16 Oct '23

16 Oct '23

Zebediah Figura (@zfigura) commented about dlls/winegstreamer/wg_parser.c: > * file (or other medium), but gst_event_new_qos() expects the timestamp in > * running time. */ > stream_time = gst_segment_to_running_time(&stream->segment, GST_FORMAT_TIME, params->timestamp * 100); > - if (stream_time == -1) > + if (stream_time == -1 || -params->diff*100 >= stream_time) That doesn't seem right. What is this doing? -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3938#note_48900

1 0

Re: [PATCH v13 0/7] MR3938: winegstreamer: Implement CLSID_CMpegVideoCodec
by Zebediah Figura (＠zfigura) 16 Oct '23

16 Oct '23

Zebediah Figura (@zfigura) commented about dlls/winegstreamer/wg_format.c: > return NULL; > > gst_video_info_set_format(&info, video_format, format->u.video.width, abs(format->u.video.height)); > + info.fps_n = format->u.video.fps_n; > + info.fps_d = format->u.video.fps_d; > + if (!format->u.video.fps_d && !format->u.video.fps_n) > + info.fps_d = 1; This may be correct (although I'm curious if it actually matters here?) but should be a separate patch. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3938#note_48901

1 0

Re: [PATCH v13 0/7] MR3938: winegstreamer: Implement CLSID_CMpegVideoCodec
by Zebediah Figura (＠zfigura) 16 Oct '23

16 Oct '23

Zebediah Figura (@zfigura) commented about dlls/winegstreamer/quartz_parser.c: > if (seeking->llStop) > stop_flags = AM_SEEKING_AbsolutePositioning; > wg_parser_stream_seek(filter->sources[0]->wg_stream, seeking->dRate, > - seeking->llCurrent, seeking->llStop, AM_SEEKING_AbsolutePositioning, stop_flags); > + seeking->llCurrent, seeking->llStop == seeking->llDuration ? -1 : seeking->llStop, > + AM_SEEKING_AbsolutePositioning, stop_flags); Isn't this redundant with the same logic done in wg_parser_stream_seek()? -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3938#note_48898

1 0

Re: [PATCH v13 0/7] MR3938: winegstreamer: Implement CLSID_CMpegVideoCodec
by Zebediah Figura (＠zfigura) 16 Oct '23

16 Oct '23

Zebediah Figura (@zfigura) commented about dlls/winegstreamer/wg_parser.c: > stop_type = GST_SEEK_TYPE_NONE; > > if (!push_event(get_stream(params->stream)->my_sink, gst_event_new_seek(params->rate, GST_FORMAT_TIME, > - flags, start_type, params->start_pos * 100, stop_type, params->stop_pos * 100))) > + flags, start_type, params->start_pos * 100, stop_type, > + params->stop_pos == -1 ? -1 : params->stop_pos * 100))) I think we want this, but this isn't relevant to this patch and should be split. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3938#note_48899

1 0

Re: [PATCH v13 0/7] MR3938: winegstreamer: Implement CLSID_CMpegVideoCodec
by Zebediah Figura (＠zfigura) 16 Oct '23

16 Oct '23

Zebediah Figura (@zfigura) commented about dlls/winegstreamer/quartz_parser.c: > * but as long as every sample fits into our allocator, we're fine. */ > return format->u.video_cinepak.width * format->u.video_cinepak.height * 3; > > + case WG_MAJOR_TYPE_VIDEO_MPEG1: > + return wg_format_get_bytes_for_uncompressed(WG_VIDEO_FORMAT_YV12, > + format->u.video_mpeg1.width, format->u.video_mpeg1.height); > + This is overestimation because we can't do any better, right? In that case it probably deserves a comment just to clarify that's what's happening. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3938#note_48896

1 0

Re: [PATCH v13 0/7] MR3938: winegstreamer: Implement CLSID_CMpegVideoCodec
by Zebediah Figura (＠zfigura) 16 Oct '23

16 Oct '23

Zebediah Figura (@zfigura) commented about dlls/winegstreamer/wg_format.c: > if (gst_video_info_from_caps(&info, caps)) > wg_format_from_video_info(format, &info); > } > - else if (!strcmp(name, "audio/mpeg")) > + else if (!strcmp(name, "audio/mpeg") && gst_structure_get_boolean(structure, "parsed", &parsed) && parsed) This is correct, I think, but also orthogonal to the purpose of this patch. Can you please split this out into a separate patch? -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3938#note_48897

1 0

Re: [PATCH v6 0/1] MR3970: quartz/tests: Improve VMR9 ChangeD3DDevice test
by Zebediah Figura (＠zfigura) 16 Oct '23

16 Oct '23

On Mon Oct 16 21:55:32 2023 +0000, Alfred Agrell wrote: > Unfortunately, we do. I had sleeps everywhere during development, then > removed every one I could, but that specific one is load-bearing. > https://testbot.winehq.org/JobDetails.pl?Key=138782&f101=exe64.report > https://testbot.winehq.org/JobDetails.pl?Key=138783&f101=exe64.report > I tried swapping it for IBaseFilter_GetState(), but that just returned > immediately then gave the same segfault. https://testbot.winehq.org/JobDetails.pl?Key=138786&f101=exe64.report > Calling GetState twice worked, but I'm pretty sure that's just because > those calls take long enough to satisfy its timing demands. A sleep is > cleaner. (Slightly. Still ugly.) > I could also move the sleep, but I don't think that would accomplish anything. Hrm, that's suspicious, IMemAllocator::GetBuffer() returns VFW_E_NOT_COMMITTED. Does the VMR's IMemAllocator change by any chance when we reconnect? I.e. is IMemInputPin::GetAllocator() actually returning the same allocator that it was returning before? -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3970#note_48893

1 0

Re: [PATCH v6 0/1] MR3970: quartz/tests: Improve VMR9 ChangeD3DDevice test
by Alfred Agrell (＠Alcaro) 16 Oct '23

16 Oct '23

On Mon Oct 16 21:25:57 2023 +0000, Zebediah Figura wrote: > Do we still need this? Unfortunately, we do. I had sleeps everywhere during development, then removed every one I could, but that specific one is load-bearing. https://testbot.winehq.org/JobDetails.pl?Key=138782&f101=exe64.report https://testbot.winehq.org/JobDetails.pl?Key=138783&f101=exe64.report I tried swapping it for IBaseFilter_GetState(), but that just returned immediately then gave the same segfault. https://testbot.winehq.org/JobDetails.pl?Key=138786&f101=exe64.report Calling GetState twice worked, but I'm pretty sure that's just because those calls take long enough to satisfy its timing demands. A sleep is cleaner. (Slightly. Still ugly.) I could also move the sleep, but I don't think that would accomplish anything. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3970#note_48883

1 0

[PATCH 0/1] MR4111: winegstreamer: Implement IWMResamplerProps
by Fabian Maurer (＠DarkShadow44) 16 Oct '23

16 Oct '23

Some programs just assume this interface exists, this fixes the resulting crash. Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=55789 -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4111

3 3

[PATCH 0/8] MR412: tests: Fix a number of tests so they pass on Windows.
by Giovanni Mascellani (＠giomasce) 16 Oct '23

16 Oct '23

This is a continuation to !406. With this MR all the tests pass on Windows. [The next step is to allow the CI to run crosstests on Windows](https://gitlab.winehq.org/giomasce/vkd3d/-/commits/ci3). -- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/412

3 9

[PATCH 0/7] MR4110: dmime: Simplify message thread and use latency time to schedule messages.
by Rémi Bernon (＠rbernon) 16 Oct '23

16 Oct '23

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/4110

3 10

Re: [PATCH v6 0/1] MR3970: quartz/tests: Improve VMR9 ChangeD3DDevice test
by Zebediah Figura (＠zfigura) 16 Oct '23

16 Oct '23

Zebediah Figura (@zfigura) commented about dlls/quartz/tests/vmr9.c: > + hr = IMemAllocator_SetProperties(allocator, &req_props, &ret_props); > + ok(hr == S_OK, "Got hr %#lx.\n", hr); > + hr = IMemAllocator_Commit(allocator); > + ok(hr == S_OK, "Got hr %#lx.\n", hr); > + > device2 = create_device(window); > ok(device2 != NULL, "Couldn't create device\n"); > > - ok(presenter.got_TerminateDevice == 0, "got %d\n", presenter.got_TerminateDevice); > - > hr = IVMRSurfaceAllocatorNotify9_ChangeD3DDevice(notify, device2, MonitorFromWindow(window, MONITOR_DEFAULTTOPRIMARY)); > ok(hr == S_OK, "Got hr %#lx.\n", hr); > - ok(presenter.got_TerminateDevice == 1, "got %d\n", presenter.got_TerminateDevice); > + presenter.device = device2; > + presenter.got_PresentImage = 0; > + Sleep(200); /* ChangeD3DDevice is partially asynchronous */ Do we still need this? -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3970#note_48875

1 0

Re: [PATCH v6 0/1] MR3970: quartz/tests: Improve VMR9 ChangeD3DDevice test
by Zebediah Figura (＠zfigura) 16 Oct '23

16 Oct '23

> Found it. Native VMR9 disconnects and reconnects the pin when changing d3d device. Unfortunately, neither party remembers the media type, so they can't reconnect. > > Fixed. Took approximately seven forevers to figure out @\_@ Ah, that makes sense, thanks. That's done in some other filters as well. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3970#note_48874

1 0

[PATCH 0/1] MR4001: Draft: winegstreamer: Add hardware H264 decoding support
by Thong Thai (＠thongthai) 16 Oct '23

16 Oct '23

Signed-off-by: Thong Thai <thong.thai(a)amd.com> -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4001

5 10

Re: [PATCH v2 0/2] MR4098: winewayland.drv: More robust handling of xdg_output information - approved
by Alexandre Julliard (＠julliard) 16 Oct '23

16 Oct '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4098

1 0

Re: [PATCH v4 0/1] MR3971: gdiplus: Opimize GDI32_GdipDrawPath - approved
by Alexandre Julliard (＠julliard) 16 Oct '23

16 Oct '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3971

1 0

Re: [PATCH v3 0/8] MR4105: advapi32: Properly implement GetSecurityInfo(SE_WINDOW_OBJECT). - approved
by Alexandre Julliard (＠julliard) 16 Oct '23

16 Oct '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4105

1 0

Re: [PATCH v2 0/1] MR4106: include: Fix debugstr_fourcc printf format to print at most 4 chars. - approved
by Alexandre Julliard (＠julliard) 16 Oct '23

16 Oct '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4106

1 0

Re: [PATCH v2 0/1] MR4094: ntdll: Use .seh handler instead of __TRY in RtlUserThreadStart() on x64. - approved
by Alexandre Julliard (＠julliard) 16 Oct '23

16 Oct '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4094

1 0

Re: [PATCH v3 0/1] MR4101: uxtheme/tests: Skip the test if the SystemUsesLightTheme value isn't found. - approved
by Alexandre Julliard (＠julliard) 16 Oct '23

16 Oct '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4101

1 0

Re: [PATCH v3 0/1] MR4104: README: Update FreeBSD information - approved
by Alexandre Julliard (＠julliard) 16 Oct '23

16 Oct '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4104

1 0

Re: [PATCH v2 0/1] MR4100: user32/tests: Reduce size demand in test_hvredraw. - approved
by Alexandre Julliard (＠julliard) 16 Oct '23

16 Oct '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4100

1 0

Re: [PATCH v3 0/5] MR4077: uiautomationcore: EVENT_OBJECT_FOCUS WinEvent translation. - approved
by Alexandre Julliard (＠julliard) 16 Oct '23

16 Oct '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4077

1 0

Re: [PATCH v2 0/4] MR4093: mfmedaengine: Use media extension object for CanPlayType(). - approved
by Alexandre Julliard (＠julliard) 16 Oct '23

16 Oct '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4093

1 0

Re: [PATCH v3 0/1] MR405: vkd3d-utils: Check for a NULL 'blob' pointer in D3DCreateBlob(). - approved
by Alexandre Julliard (＠julliard) 16 Oct '23

16 Oct '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/405

1 0

Re: [PATCH v2 0/8] MR406: tests: Mark a number of d3d12 tests as broken on WARP. - approved
by Alexandre Julliard (＠julliard) 16 Oct '23

16 Oct '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/406

1 0

Re: [PATCH v3 0/4] MR403: vkd3d-shader/dxil: Read the DXIL input and output signatures. - approved
by Alexandre Julliard (＠julliard) 16 Oct '23

16 Oct '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/403

1 0

Re: [PATCH v2 0/1] MR404: tests: Use the same viewport origin and front-face orientation in the Vulkan and D3D runners. - approved
by Alexandre Julliard (＠julliard) 16 Oct '23

16 Oct '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/404

1 0

Re: [PATCH v4 0/4] MR390: ci: Run tests using dxcompiler. - approved
by Alexandre Julliard (＠julliard) 16 Oct '23

16 Oct '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/390

1 0

[PATCH v2 0/2] MR4109: jscript: Fix Array.map and Array.reduce when last element doesn't exist.
by Gabriel Ivăncescu (＠insn) 16 Oct '23

16 Oct '23

-- v2: jscript: Fix Array.reduce when last element doesn't exist. jscript: Fix Array.map when last element doesn't exist. https://gitlab.winehq.org/wine/wine/-/merge_requests/4109

3 3

[PATCH v2 0/1] MR405: vkd3d-utils: Check for a NULL 'blob' pointer in D3DCreateBlob().
by Henri Verbeet (＠hverbeet) 16 Oct '23

16 Oct '23

-- v2: vkd3d-utils: Check for a NULL 'blob' pointer in D3DCreateBlob(). https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/405

4 4

[PATCH v4 0/2] MR381: vkd3d-shader/tpf: Convert some of the semantic names to system values names when in compatibility mode.
by Nikolay Sivov (＠nsivov) 16 Oct '23

16 Oct '23

Signed-off-by: Nikolay Sivov <nsivov(a)codeweavers.com> -- v4: programs/vkd3d-compiler: Dynamically allocate options array. vkd3d-shader/tpf: Convert some of the semantic names to system values names when in compatibility mode. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/381

3 5

[PATCH 0/1] MR4106: include: Fix debugstr_fourcc printf format to print at most 4 chars.
by Rémi Bernon (＠rbernon) 16 Oct '23

16 Oct '23

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/4106

3 4

[PATCH 0/1] MR4109: jscript: Fix Array.map and Array.reduce when last element doesn't exist.
by Gabriel Ivăncescu (＠insn) 16 Oct '23

16 Oct '23

I've fixed the `beforeunload` case, since it happens during `load_nsuri`. I added tests for both it and `unload`, but unfortunately the new tests are somewhat hackish, as we have to release the View without actually closing it to test this, because closing the view sends those events (this is already tested by existing tests), and we want to test if releasing the doc obj sends those events. As for why we have to release the View, it's because it holds a ref to the doc obj. So I placed the test last now since it doesn't close the view properly. If you think the test is too hackish I can remove it. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4109

3 3

[PATCH 0/1] MR4107: wbemprox: Use correct string id.
by eric pouech (＠epo) 16 Oct '23

16 Oct '23

Don't use hard coded string indexes as one of the expected string can be absent, hence decreasing its index; nothing ensures that the strings are placed in the order of the fields in the smbios structure. So use, smbios structures' indexes instead. Wbemprox was also expecting one string too much. Signed-off-by: Eric Pouech <epouech(a)codeweavers.com> -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4107

2 1

[PATCH v2 0/5] MR4092: user32: Actually implement RealGetWindowClass{A/W}.
by Connor McAdams (＠cmcadams) 16 Oct '23

16 Oct '23

-- v2: user32: Pass real argument to NtUserGetClassName in RealGetWindowClass. win32u: Add support for retrieving real window class ID across processes. user32: Set real window class ID for user32 standard controls. https://gitlab.winehq.org/wine/wine/-/merge_requests/4092

5 24

Re: [PATCH v3 0/1] MR3971: gdiplus: Opimize GDI32_GdipDrawPath - approved
by Esme Povirk (＠madewokherd) 16 Oct '23

16 Oct '23

This merge request was approved by Esme Povirk. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3971

1 0

Re: [PATCH v3 0/1] MR3971: gdiplus: Opimize GDI32_GdipDrawPath
by Esme Povirk (＠madewokherd) 16 Oct '23

16 Oct '23

On Sat Oct 14 22:06:36 2023 +0000, Bartosz Kosiorek wrote: > With previous implementation we have 2*4 float multiplication inside > `GdipTransformMatrixPoints` function: > ``` > pts[i].X = x * matrix->matrix[0] + y * matrix->matrix[2] + matrix->matrix[4]; > pts[i].Y = x * matrix->matrix[1] + y * matrix->matrix[3] + matrix->matrix[5]; > ``` > Here is the full source code: > ``` > GpStatus WINGDIPAPI GdipTransformMatrixPoints(GpMatrix *matrix, GpPointF *pts, > INT count) > { > REAL x, y; > INT i; > TRACE("(%s, %p, %d)\n", debugstr_matrix(matrix), pts, count); > if(!matrix || !pts || count <= 0) > return InvalidParameter; > for(i = 0; i < count; i++) > { > x = pts[i].X; > y = pts[i].Y; > pts[i].X = x * matrix->matrix[0] + y * matrix->matrix[2] + matrix->matrix[4]; > pts[i].Y = x * matrix->matrix[1] + y * matrix->matrix[3] + matrix->matrix[5]; > } > return Ok; > } > ``` > As the vector is (0,0) and (1, 1), we could replace invocation of this > function by simple assigment (no need to multiple anything): > ``` > scale_x = graphics->worldtrans.matrix[0] + graphics->worldtrans.matrix[2]; > scale_y = graphics->worldtrans.matrix[1] + graphics->worldtrans.matrix[3]; > ``` > We could also optimize it more and calculate width via `sqrt` only once > (I would like to leave it for next MR). This seems simple enough that I have no problem changing it without performance numbers. Note that we immediately turn around and do the same thing with graphics->gdi_transform (with some indirection through gdip_transform_points and get_graphics_transform that could be eliminated). -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3971#note_48812

1 0

[PATCH v7 0/11] MR401: vkd3d-shader/dxil: Read CBV info.
by Conor McCarthy (＠cmccarthy) 16 Oct '23

16 Oct '23

Goes atop MR 403 and 388. The last four commits belong to this MR. -- v7: vkd3d-shader: Clone descriptor scan info from struct vkd3d_shader_desc. vkd3d-shader/dxil: Read CBV descriptors. vkd3d-shader/dxil: Validate the descriptor list metadata nodes. vkd3d-shader/spirv: Align constant buffer sizes to 16 bytes. vkd3d-shader/dxil: Read DXIL compute shader thread group dimensions. vkd3d-shader/dxil: Read DXIL global flags. vkd3d-shader: Define more global flags. vkd3d-shader/dxil: Handle multi-row signature elements. vkd3d-shader/dxil: Handle signature element additional tag/value pairs. vkd3d-shader/dxil: Read the DXIL input and output signatures. vkd3d-shader/dxil: Validate the entry point info. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/401

3 12

[PATCH v3 0/2] MR4054: mshtml: HTMLWindow behavior improvements.
by Gabriel Ivăncescu (＠insn) 16 Oct '23

16 Oct '23

-- v3: mshtml: Return proper errors when navigating with no browser. mshtml: Set outer window to uninitialized page when document obj is released. https://gitlab.winehq.org/wine/wine/-/merge_requests/4054

3 3

[PATCH v5 0/1] MR384: vkd3d: Replace the descriptor object cache with a thread-local implementation.
by Conor McCarthy (＠cmccarthy) 16 Oct '23

16 Oct '23

The PE build uses FlsAlloc(), which for our purposes makes no difference vs TlsAlloc(), and allows the use of a destruction callback. -- v5: vkd3d: Replace the descriptor object cache with a thread-local implementation. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/384

3 12

[PATCH 0/1] MR407: Draft: vkd3d-shader/disasm: Initial support for disassembling TX binaries.
by Nikolay Sivov (＠nsivov) 16 Oct '23

16 Oct '23

-- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/407

3 5

[PATCH 0/8] MR406: tests: Mark a number of d3d12 tests as broken on WARP.
by Giovanni Mascellani (＠giomasce) 16 Oct '23

16 Oct '23

This is in view of eventually running the vkd3d cross tests in the CI. With this MR d3d12 passes all the tests ([see a test pipeline](https://gitlab.winehq.org/giomasce/vkd3d/-/jobs/32587)), but some shader runner tests are still failing. I haven't investigated in detail all these issues. Also, it is known that WARP doesn't emulate faithfully a hardware device. The idea is that having the CI able to quickly check most (even if not all) our tests on native is still better than nothing. -- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/406

3 9

[PATCH v2 0/4] MR403: vkd3d-shader/dxil: Read the DXIL input and output signatures.
by Conor McCarthy (＠cmccarthy) 16 Oct '23

16 Oct '23

-- v2: vkd3d-shader/dxil: Handle multi-row signature elements. vkd3d-shader/dxil: Handle signature element additional tag/value pairs. vkd3d-shader/dxil: Read the DXIL input and output signatures. vkd3d-shader/dxil: Validate the entry point info. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/403

4 6

[PATCH v3 0/1] MR381: vkd3d-shader/tpf: Convert some of the semantic names to system values names when in compatibility mode.
by Nikolay Sivov (＠nsivov) 16 Oct '23

16 Oct '23

Signed-off-by: Nikolay Sivov <nsivov(a)codeweavers.com> -- v3: vkd3d-shader/tpf: Convert some of the semantic names to system values names when in compatibility mode. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/381

3 2

[PATCH v15 0/8] MR361: vkd3d-shader/hlsl: Initial support for 'switch' statement.
by Nikolay Sivov (＠nsivov) 16 Oct '23

16 Oct '23

Signed-off-by: Nikolay Sivov <nsivov(a)codeweavers.com> -- v15: vkd3d-shader/tpf: Write out 'switch' statements. vkd3d-shader/hlsl: Add a pass to validate switch cases blocks. vkd3d-shader/hlsl: Add a pass to remove unreachable code. vkd3d-shader/hlsl: Add copy propagation logic for switches. vkd3d-shader/hlsl: Validate break/continue context. vkd3d-shader/hlsl: Check for duplicate case statements. vkd3d-shader/hlsl: Add initial support for parsing 'switch' statements. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/361

3 10

[PATCH 0/16] MR408: Draft: vkd3d-shader/dxil: Implement constant buffer loads.
by Conor McCarthy (＠cmccarthy) 16 Oct '23

16 Oct '23

Goes atop MR 403 and 401. The last five commits belong to this MR. -- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/408

2 16

2025

2024

2023

2022

wine-gitlab