- wine-gitlab - winehq.org

[PATCH v2 0/4] MR402: vkd3d-shader: Minor fixes to clangd warnings (clangd).
by Francisco Casas (＠fcasas) 12 Oct '23

12 Oct '23

Some fixes to valid clangd warnings, since I am using it as linter. Also, I am removing enum hlsl_error_level on 4/6, since it doesn't seem to be meant to be used anywhere after 3/6. -- v2: vkd3d-shader/d3dbc: Use D3DSIO_TEXKILL instead of VKD3D_SM1_OP_TEXKILL (clangd). vkd3d-shader/hlsl: Remove enum hlsl_error_level (clangd). vkd3d-shader/tpf: Avoid translations to D3DDECLUSAGE and back (clangd). vkd3d-shader: Remove unnecessary fallthroughs (clangd). https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/402

4 10

[PATCH v10 0/5] MR372: Draft: vkd3d-shader/dxil: Read metadata and signatures.
by Conor McCarthy (＠cmccarthy) 12 Oct '23

12 Oct '23

Goes atop MR 346 and 400, and therefore is a draft until they are upstream. -- v10: vkd3d-shader/dxil: Read DXIL metadata named nodes. vkd3d-shader/dxil: Read DXIL metadata kinds. vkd3d-shader/dxil: Read DXIL metadata values. vkd3d-shader/dxil: Read DXIL metadata nodes. vkd3d-shader/dxil: Read DXIL metadata strings. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/372

3 6

[PATCH v9 0/8] MR361: vkd3d-shader/hlsl: Initial support for 'switch' statement.
by Nikolay Sivov (＠nsivov) 12 Oct '23

12 Oct '23

Signed-off-by: Nikolay Sivov <nsivov(a)codeweavers.com> -- v9: vkd3d-shader/tpf: Write out 'switch' statements. vkd3d-shader/hlsl: Add a pass to validate switch cases blocks. vkd3d-shader/hlsl: Add a pass to remove unreachable code. vkd3d-shader/hlsl: Add copy propagation logic for switches. vkd3d-shader/hlsl: Validate break/continue context. vkd3d-shader/hlsl: Check for duplicate case statements. vkd3d-shader/hlsl: Add initial support for parsing 'switch' statements. tests: Add some tests for the 'switch' statements. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/361

3 23

[PATCH 0/6] MR4076: dmsynth: Implement some MIDI events in the synth.
by Rémi Bernon (＠rbernon) 12 Oct '23

12 Oct '23

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/4076

4 8

[PATCH v2 0/1] MR4072: advapi32/tests: Mark some ReadEventLog tests broken on Win10 200[49].
by Daniel Lehman (＠dlehman25) 12 Oct '23

12 Oct '23

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=55731 -- v2: advapi32/tests: Skip ReadEventLog on failure to open System log. https://gitlab.winehq.org/wine/wine/-/merge_requests/4072

2 1

[PATCH v3 0/1] MR384: vkd3d: Replace the descriptor object cache with a thread-local implementation.
by Conor McCarthy (＠cmccarthy) 12 Oct '23

12 Oct '23

The PE build uses FlsAlloc(), which for our purposes makes no difference vs TlsAlloc(), and allows the use of a destruction callback. -- v3: vkd3d: Replace the descriptor object cache with a thread-local implementation. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/384

2 1

[PATCH v2 0/1] MR384: Draft: vkd3d: Introduce a thread-local descriptor object cache.
by Conor McCarthy (＠cmccarthy) 12 Oct '23

12 Oct '23

A TLS index is allocated for each device object. We could use a global TLS, but that would share caches for all devices. I'm not sure if that's a problem. One index per device means freed indices must be recycled, which requires a global mutex, but a global TLS index would also need a global mutex. This currently leaks cache memory when a device is freed. To fix this, allocations must be tracked. A global cache is more difficult to free, which is not normally an issue, but it is when using valgrind. -- v2: vkd3d: Replace the descriptor object cache with a thread-local implementation. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/384

2 1

[PATCH 0/1] MR4080: cfgmgr32: Add stub for CM_Get_Device_Interface_PropertyW.
by Brendan Shanks (＠bshanks) 12 Oct '23

12 Oct '23

This fixes poor performance in Counter-Strike 2 by allowing [SDL's hidapi](https://github.com/libsdl-org/SDL/blob/1c3a0ade742af1f3626b43b9c865… to initialize successfully, rather than endlessly trying to resolve the non-existent function. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4080

2 1

[PATCH v5 0/18] MR401: Draft: vkd3d-shader/dxil: Implement constant buffer loads.
by Conor McCarthy (＠cmccarthy) 12 Oct '23

12 Oct '23

Goes atop MR 372, 403 and 388. The last six commits belong to this MR. -- v5: vkd3d-shader/dxil: Implement the DXIL EXTRACTVAL instruction. vkd3d-shader/dxil: Implement DX instruction CBufferLoadLegacy. vkd3d-shader/dxil: Implement DX instruction CreateHandle. vkd3d-shader/dxil: Read CBV descriptors. vkd3d-shader/spirv: Align constant buffer sizes to 16 bytes. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/401

2 18

[PATCH v4 0/18] MR401: Draft: vkd3d-shader/dxil: Implement constant buffer loads.
by Conor McCarthy (＠cmccarthy) 12 Oct '23

12 Oct '23

Goes atop MR 346, 400, 372, and 388. The last six commits belong to this MR. -- v4: vkd3d-shader/dxil: Implement the DXIL EXTRACTVAL instruction. vkd3d-shader/dxil: Implement DX instruction CBufferLoadLegacy. vkd3d-shader/dxil: Implement DX instruction CreateHandle. vkd3d-shader/dxil: Read CBV descriptors. vkd3d-shader/spirv: Align constant buffer sizes to 16 bytes. vkd3d-shader/spirv: Support scalar swizzle of vector SSA registers. vkd3d-shader/dxil: Read DXIL compute shader thread group dimensions. vkd3d-shader/dxil: Read DXIL global flags. vkd3d-shader: Define more global flags. vkd3d-shader/dxil: Handle multi-row signature elements. vkd3d-shader/dxil: Handle signature element additional tag/value pairs. vkd3d-shader/dxil: Read the DXIL input and output signatures. vkd3d-shader/dxil: Validate the entry point info. vkd3d-shader/dxil: Read DXIL metadata named nodes. vkd3d-shader/dxil: Read DXIL metadata kinds. vkd3d-shader/dxil: Read DXIL metadata values. vkd3d-shader/dxil: Read DXIL metadata nodes. vkd3d-shader/dxil: Read DXIL metadata strings. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/401

2 18

[PATCH v4 0/12] MR388: Draft: vkd3d-shader/dxil: Complete the signature reads and read some shader properties.
by Conor McCarthy (＠cmccarthy) 12 Oct '23

12 Oct '23

Goes atop MRs 346 and 372. The last five commits are of this MR. -- v4: vkd3d-shader/dxil: Read DXIL compute shader thread group dimensions. vkd3d-shader/dxil: Read DXIL global flags. vkd3d-shader: Define more global flags. vkd3d-shader/dxil: Handle multi-row signature elements. vkd3d-shader/dxil: Handle signature element additional tag/value pairs. vkd3d-shader/dxil: Read the DXIL input and output signatures. vkd3d-shader/dxil: Validate the entry point info. vkd3d-shader/dxil: Read DXIL metadata named nodes. vkd3d-shader/dxil: Read DXIL metadata kinds. vkd3d-shader/dxil: Read DXIL metadata values. vkd3d-shader/dxil: Read DXIL metadata nodes. vkd3d-shader/dxil: Read DXIL metadata strings. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/388

2 12

[PATCH 0/9] MR403: Draft: vkd3d-shader/dxil: Read the DXIL input and output signatures.
by Conor McCarthy (＠cmccarthy) 12 Oct '23

12 Oct '23

Goes atop MR 372. The last four commits are of this MR. -- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/403

2 9

[PATCH v2 0/7] MR4014: winewayland.drv: part 8: More window management
by Alexandros Frantzis (＠afrantzis) 11 Oct '23

11 Oct '23

This MR improves window management related behavior and adds support for more scenarios. Some highlights (please see the full commit list and messages for more info): 1. Better support for tiled states. 2. Detect and handle fullscreen windows. 3. Increased robustness against state disagreements between Wine and the Wayland compositor. 4. Move top-level windows to (0,0) (using that fixed point for now, we will later generalize this mechanism for multiple monitors), in order to: a. maximize the accessible mouse input region (which may be clipped in Windows virtual screen space, but still accessible in Wayland space). b. introduce the basic mechanism to allow windows applications to (very roughly!) track which output(s) they are really on (to be continued in the full multi-monitor form). Although (4) is not a perfect solution for the lack of absolute positioning, it has worked well in practice in its full, multi-monitor implementation (i.e., in the experimental branch). I wonder if for (4a) in particular we can do better, e.g., by being able to emit input that circumvents the normal virtual screen clipping. Is there a way to do this already? If not, do you think that such an approach would be a feasible and acceptable way forward, or is virtual screen input clipping fundamentally baked in the current core design and assumptions? Thanks! -- v2: winewayland.drv: Avoid resizing fullscreen windows. winewayland.drv: Rename wayland_surface_configure_is_compatible for consistency. winewayland.drv: Use surface geometry to satisfy state size constraints. winewayland.drv: Handle application-initiated fullscreen state. https://gitlab.winehq.org/wine/wine/-/merge_requests/4014

4 16

Re: [PATCH v2 0/6] MR4076: dmsynth: Implement some MIDI events in the synth. - approved
by Alexandre Julliard (＠julliard) 11 Oct '23

11 Oct '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4076

1 0

Re: [PATCH v5 0/7] MR4064: dmime: Load and play .wav file-based segments. - approved
by Alexandre Julliard (＠julliard) 11 Oct '23

11 Oct '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4064

1 0

Re: [PATCH v4 0/1] MR4068: server: Send WM_WINE_SETCURSOR with the thread input cursor handle. - approved
by Alexandre Julliard (＠julliard) 11 Oct '23

11 Oct '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4068

1 0

Re: [PATCH v3 0/1] MR4063: winex11.drv: Set _NET_WM_FULLSCREEN_MONITORS only when necessary. - approved
by Alexandre Julliard (＠julliard) 11 Oct '23

11 Oct '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4063

1 0

Re: [PATCH v3 0/1] MR4065: xinput1_3: Hold module reference while the hid thread is running. - approved
by Alexandre Julliard (＠julliard) 11 Oct '23

11 Oct '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4065

1 0

Re: [PATCH v4 0/6] MR4075: wineps.drv: Use first page DEVMODE to determine number of copies and collation. - approved
by Alexandre Julliard (＠julliard) 11 Oct '23

11 Oct '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4075

1 0

Re: [PATCH v2 0/2] MR4074: gdi32: Fix METADC handling in PlayMetaFile. - approved
by Alexandre Julliard (＠julliard) 11 Oct '23

11 Oct '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4074

1 0

Re: [PATCH v4 0/2] MR4047: Msxml copytests - approved
by Alexandre Julliard (＠julliard) 11 Oct '23

11 Oct '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4047

1 0

Re: [PATCH v2 0/1] MR4070: wow64cpu: Use RTL_CONSTANT_STRING. - approved
by Alexandre Julliard (＠julliard) 11 Oct '23

11 Oct '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4070

1 0

Re: [PATCH v2 0/1] MR4069: winemac.drv: Use ObjC literals. - approved
by Alexandre Julliard (＠julliard) 11 Oct '23

11 Oct '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4069

1 0

Re: [PATCH v2 0/3] MR400: vkd3d-shader/dxil: Prepare for reading metadata. - approved
by Alexandre Julliard (＠julliard) 11 Oct '23

11 Oct '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/400

1 0

Re: [PATCH v28 0/4] MR346: tests/shader-runner: Test DXIL shaders. - approved
by Alexandre Julliard (＠julliard) 11 Oct '23

11 Oct '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/346

1 0

[PATCH 0/3] MR400: vkd3d-shader/dxil: Prepare for reading metadata.
by Conor McCarthy (＠cmccarthy) 11 Oct '23

11 Oct '23

-- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/400

4 5

[PATCH v27 0/4] MR346: tests/shader-runner: Test DXIL shaders.
by Conor McCarthy (＠cmccarthy) 11 Oct '23

11 Oct '23

This goes on top of MR 345. -- v27: tests/shader-runner: Test shaders with dxcompiler. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/346

4 10

[PATCH 0/6] MR402: vkd3d-shader: Minor fixes to clangd warnings (clangd).
by Francisco Casas (＠fcasas) 11 Oct '23

11 Oct '23

Some fixes to valid clangd warnings, since I am using it as linter. Also, I am removing enum hlsl_error_level on 4/6, since it doesn't seem to be meant to be used anywhere after 3/6. -- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/402

3 7

[PATCH v4 0/7] MR4064: dmime: Load and play .wav file-based segments.
by Rémi Bernon (＠rbernon) 11 Oct '23

11 Oct '23

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=9027 Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=34751 Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=45135 Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=48220 -- v4: dmime: Play direct sound buffer from DMUS_PMSGT_WAVE message. dmime: Implement IDirectMusicTrack_Play for the wave track. dmime: Implement GUID_(Download|Unload)FromAudioPath for wave track. dmime: Create a wave track when loading a segment from a .wav. dmusic: Split wave entry points to dmusic_wave.h. dmime: Include dmobject.h in dmime_private.h. dmime: Get rid of the IDirectMusicWaveTrack typedef. https://gitlab.winehq.org/wine/wine/-/merge_requests/4064

3 8

[PATCH 0/1] MR4072: advapi32/tests: Mark some ReadEventLog tests broken on Win10 200[49].
by Daniel Lehman (＠dlehman25) 11 Oct '23

11 Oct '23

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=55731 -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4072

3 2

[PATCH 0/5] MR4077: uiautomationcore: EVENT_OBJECT_FOCUS WinEvent translation.
by Connor McAdams (＠cmcadams) 11 Oct '23

11 Oct '23

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/4077

3 8

[PATCH v2 0/3] MR364: vkd3d-shader/hlsl: Implement inverse trigonometry.
by Petrichor Park (＠petrathekat) 11 Oct '23

11 Oct '23

Implements asin, acos, atan, and atan2. Also includes some tests in a new test file. One possible problem here is that I'm not sure how to test what Microsoft's atan and atan2 outputs are in boundary cases like atan2(1, 0). I've made the test suites adhere with the calculator program I've been using (Qalculate, which I assume is using libc's atan2). Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=55154 -- v2: vkd3d-shader/hlsl: Implement atan2. vkd3d-shader/hlsl: Implement atan. vkd3d-shader/hlsl: Implement acos and asin trig intrinsics. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/364

4 6

[PATCH v3 0/1] MR3988: winetts: Add stub dll.
by Shaun Ren (＠shaunren) 11 Oct '23

11 Oct '23

-- v3: winetts: Add stub dll. https://gitlab.winehq.org/wine/wine/-/merge_requests/3988

4 10

[PATCH v3 0/6] MR4075: wineps.drv: Use first page DEVMODE to determine number of copies and collation.
by Piotr Caban (＠piotr) 11 Oct '23

11 Oct '23

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=55718 -- v3: wineps.drv: Use first page DEVMODE to determine number of copies and collation. https://gitlab.winehq.org/wine/wine/-/merge_requests/4075

3 8

Re: [PATCH v44 0/7] MR3870: mspatcha: Add support for 32-bit file patching and normalization
by Conor McCarthy (＠cmccarthy) 11 Oct '23

11 Oct '23

I remember it took quite a bit of work to generate test data, but I don't remember how I did it. I'll try to find some source code. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3870#note_48360

1 0

Re: [PATCH v44 0/7] MR3870: mspatcha: Add support for 32-bit file patching and normalization
by Aidan Khoury (＠ajkhoury) 11 Oct '23

11 Oct '23

Okay, I will revert those specific tests. Generating the PE binaries won't be such a problem, however generating patch data that works on a generated PE is a problem. This would require writing implementations for most of mspatchc in order to properly generate patch data. I'm curious how the original author of the mspatcha implementation @cmccarthy generated the patch data Any help with this would be very valuable and appreciated. I am trying to fix a 15 year old bug report with these changes so that people can finally install software without the need for manually installing the native Microsoft mspatcha binary. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3870#note_48358

1 0

[PATCH v2 0/1] MR4063: winex11.drv: Set _NET_WM_FULLSCREEN_MONITORS only when necessary.
by Zhiyi Zhang (＠zhiyi) 11 Oct '23

11 Oct '23

If _NET_WM_FULLSCREEN_MONITORS is set then the property needs to be updated because it can't be deleted by sending a _NET_WM_FULLSCREEN_MONITORS client message to the root window according to the wm-spec version 1.5. Having the window spanning more than two monitors also needs the property set. In other cases, _NET_WM_FULLSCREEN_MONITORS doesn't need to be set. What's more, setting _NET_WM_FULLSCREEN_MONITORS adds a constraint on Mutter so that such a window can't be moved to another monitor by using the Shift+Super+Up/Down/Left/Right shortcut. So the property should be added only when necessary. -- v2: winex11.drv: Set _NET_WM_FULLSCREEN_MONITORS only when necessary. https://gitlab.winehq.org/wine/wine/-/merge_requests/4063

2 1

[PATCH v2 0/6] MR4075: wineps.drv: Use first page DEVMODE to determine number of copies and collation.
by Piotr Caban (＠piotr) 11 Oct '23

11 Oct '23

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=55718 -- v2: wineps.drv: Use first page DEVMODE to determine number of copies and collation. gdi32: Add GdiGetDevmodeForPage implementation. https://gitlab.winehq.org/wine/wine/-/merge_requests/4075

3 7

[PATCH 0/6] MR4075: wineps.drv: Use first page DEVMODE to determine number of copies and collation.
by Piotr Caban (＠piotr) 11 Oct '23

11 Oct '23

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=55718 -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4075

4 8

Re: [PATCH v2 0/1] MR4065: xinput1_3: Hold module reference while the hid thread is running.
by Arek Hiler (＠ivyl) 11 Oct '23

11 Oct '23

The failed 32bit tests are the following: ``` domdoc.c:2521: Test failed: Unexpected hr 0x1. filtergraph.c:635: Test failed: Got hr 0x40242. filtergraph.c:571: Test failed: Got hr 0x80004005. speech.c:1386: Test failed: Wait for block_thread failed. ``` Unrelated to the patch + they've been failing all across different MRs here. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4065#note_48346

1 0

[PATCH 0/2] MR4074: gdi32: Fix METADC handling in PlayMetaFile.
by Piotr Caban (＠piotr) 11 Oct '23

11 Oct '23

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/4074

3 3

Re: [PATCH v2 0/1] MR4043: uxtheme: add some ordinals to spec file needed by Captvty
by Louis Lenders (＠xe) 11 Oct '23

11 Oct '23

Hi Zhiyi, thanks for the clear explanation, I'll have a look into this and try to fix something up, but that'll be in the weekend/next week. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4043#note_48343

1 0

Re: [PATCH v2 0/2] MR4058: gdi32/emf: Add SetBrushOrgEx() recording.
by Nikolay Sivov (＠nsivov) 11 Oct '23

11 Oct '23

On Wed Oct 11 11:05:32 2023 +0000, Chip Davis wrote: > According to [docs][1], `SetBrushOrgEx()` is supposed to affect the > *next* brush that is selected into the device context. It might be > interesting, then, to see what happens when a brush is selected into the > DC after calling `SetBrushOrgEx()`. > [1]: https://learn.microsoft.com/en-us/windows/win32/api/wingdi/nf-wingdi-setbru… That's not reflected by EMF recording, and will need some rendering tests. It's best to have a bug report for that so it's not forgotten. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4058#note_48338

1 0

Re: [PATCH v3 0/2] MR3915: ddraw/tests: Test WS_EX_TOPMOST restoration. - approved
by Jan Sikorski (＠jsikorski) 11 Oct '23

11 Oct '23

This merge request was approved by Jan Sikorski. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3915

1 0

[PATCH 0/8] MR396: vkd3d-shader/hlsl: Support non-constant offset dereferences, v2, part 1.
by Francisco Casas (＠fcasas) 11 Oct '23

11 Oct '23

First part of the continuation of the implementation of non-constant offset dereferences (a.k.a. relative addressing) for SM4, now that we use vsir registers in tpf.c. As a quick recap: while parsing HLSL we are expressing derefs as paths, and then we are lowering these paths into a single offset node (which is closer to the bytecode) using the replace_deref_path_with_offset() pass, right before register allocation. This first part of the series splits this offset node into 2 parts: - A constant uint, which will be called hlsl_deref.offset_const. - A non-hlsl_ir_constant offset node that will only be present when we need relative addressing, that we will end up calling hlsl_deref.offset_rel. Both these fields will be analog to the ones used in vsir register indexes, vkd3d_shader_register_index.rel_addr and vkd3d_shader_src_param.offset respectively, which is something we need for the second part of this series. The following patches are in my [nonconst-offsets-8-part](https://gitlab.winehq.org/fcasas/vkd3d/-/commits/n… branch, if something is not clear in this series, it may be worth skimming through them. Supersedes !229. -- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/396

3 17

[PATCH v3 0/2] MR4047: Msxml copytests
by Daniel Lehman (＠dlehman25) 11 Oct '23

11 Oct '23

-- v3: msxml6/tests: Copy namespaces as attributes tests. msxml4/tests: Copy namespaces as attributes tests. https://gitlab.winehq.org/wine/wine/-/merge_requests/4047

3 3

[PATCH v3 0/1] MR4068: server: Send WM_WINE_SETCURSOR with the thread input cursor handle.
by Rémi Bernon (＠rbernon) 11 Oct '23

11 Oct '23

Which may be different from the last desktop cursor handle. This makes the behavior better match the old winex11 behavior, which queried the current thread input cursor handle on every mouse move to sync it with X11, although it contradicts MSDN documentation which states that the cursor handle is global. This fixes the X11 cursor being visible in "Deus Ex: GOTY Edition". -- v3: server: Send WM_WINE_SETCURSOR with the thread input cursor handle. https://gitlab.winehq.org/wine/wine/-/merge_requests/4068

2 1

[PATCH 0/4] MR3997: Add missing CPU information for Debian architectures
by Stephen Kitt (＠skitt) 11 Oct '23

11 Oct '23

This adds support for missing architectures in widl, providing full coverage of current Debian architectures and ports. I’m aware this restores SPARC which was removed in 2017; if that’s a problem I can remove that part of the patch. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3997

6 10

[PATCH v2 0/1] MR4068: server: Send WM_WINE_SETCURSOR with the thread input cursor handle.
by Rémi Bernon (＠rbernon) 11 Oct '23

11 Oct '23

Which may be different from the last desktop cursor handle. This makes the behavior better match the old winex11 behavior, which queried the current thread input cursor handle on every mouse move to sync it with X11, although it contradicts MSDN documentation which states that the cursor handle is global. This fixes the X11 cursor being visible in "Deus Ex: GOTY Edition". -- v2: server: Send WM_WINE_SETCURSOR with the thread input cursor handle. https://gitlab.winehq.org/wine/wine/-/merge_requests/4068

3 4

[PATCH 0/1] MR4063: winex11.drv: Set _NET_WM_FULLSCREEN_MONITORS only when necessary.
by Zhiyi Zhang (＠zhiyi) 11 Oct '23

11 Oct '23

If _NET_WM_FULLSCREEN_MONITORS is set then the property needs to be updated because it can't be deleted by sending a _NET_WM_FULLSCREEN_MONITORS client message to the root window according to the wm-spec version 1.5. Having the window spanning more than two monitors also needs the property set. In other cases, _NET_WM_FULLSCREEN_MONITORS doesn't need to be set. What's more, setting _NET_WM_FULLSCREEN_MONITORS adds a constraint on Mutter so that such a window can't be moved to another monitor by using the Shift+Super+Up/Down/Left/Right shortcut. So the property should be added only when necessary. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4063

3 2

[PATCH 0/2] MR4071: msvcrt/tests: Add tests for wcsdup.
by Alex Henrie (＠alexhenrie) 11 Oct '23

11 Oct '23

These tests are to resolve the concerns about relying on the tested behaviors, that were brought up at <https://gitlab.winehq.org/wine/wine/-/merge_requests/4060#note_48218>. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4071

3 3

Re: [PATCH v44 0/7] MR3870: mspatcha: Add support for 32-bit file patching and normalization
by Alexandre Julliard (＠julliard) 11 Oct '23

11 Oct '23

On Fri Oct 6 16:29:41 2023 +0000, Aidan Khoury wrote: > I used binary resources instead of header files full of an array of > bytes: de05aea3c1a1213de90bbf433e8258753b1b60aa > I borrowed this technique from other test cases I found, specifically in mf.dll We can't ship binaries copied from some random installer. In any case this will need a lot more test cases for all the various code paths, so you'll need to be able to generate the binaries from the test. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3870#note_48313

1 0

[PATCH v7 0/2] MR361: vkd3d-shader/hlsl: Initial support for 'switch' statement.
by Nikolay Sivov (＠nsivov) 11 Oct '23

11 Oct '23

Signed-off-by: Nikolay Sivov <nsivov(a)codeweavers.com> -- v7: vkd3d-shader/tpf: Write out 'switch' statements. vkd3d-shader/hlsl: Initial support for 'switch' statement. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/361

3 4

[PATCH 0/1] MR4052: secur32/tests: Skip the tests instead of crashing if Kerberos is not supported.
by Francois Gouget (＠fgouget) 11 Oct '23

11 Oct '23

Wine-Bug: https://bugs.winehq.org//show_bug.cgi?id=55555 -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4052

4 7

[PATCH v2 0/25] MR401: Draft: vkd3d-shader/dxil: Implement constant buffer loads.
by Conor McCarthy (＠cmccarthy) 11 Oct '23

11 Oct '23

Goes atop MR 346, 400, 372, and 388. The last six commits belong to this MR. -- v2: vkd3d-shader/dxil: Implement the DXIL EXTRACTVAL instruction. vkd3d-shader/dxil: Implement DX instruction CBufferLoadLegacy. vkd3d-shader/dxil: Implement DX instruction CreateHandle. vkd3d-shader/dxil: Read CBV descriptors. vkd3d-shader/spirv: Align constant buffer sizes to 16 bytes. vkd3d-shader/spirv: Support scalar swizzle of vector SSA registers. vkd3d-shader/dxil: Read DXIL compute shader thread group dimensions. vkd3d-shader/dxil: Read DXIL global flags. vkd3d-shader: Define more global flags. vkd3d-shader/dxil: Handle multi-row signature elements. vkd3d-shader/dxil: Handle signature element additional tag/value pairs. vkd3d-shader/dxil: Read the DXIL input and output signatures. vkd3d-shader/dxil: Validate the entry point info. vkd3d-shader/dxil: Read DXIL metadata named nodes. vkd3d-shader/dxil: Read DXIL metadata kinds. vkd3d-shader/dxil: Read DXIL metadata values. vkd3d-shader/dxil: Read DXIL metadata nodes. vkd3d-shader/dxil: Read DXIL metadata strings. vkd3d-shader/dxil: Emit an error on allocation failure in dxil_record_to_string(). vkd3d-shader/dxil: Read global constants in sm6_parser_globals_init(). vkd3d-shader/dxil: Read immediate constant arrays. tests/shader-runner: Test shaders with dxcompiler. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/401

2 25

Re: [PATCH v2 0/2] MR4058: gdi32/emf: Add SetBrushOrgEx() recording.
by Chip Davis (＠cdavis5e) 11 Oct '23

11 Oct '23

According to [docs][1], `SetBrushOrgEx()` is supposed to affect the *next* brush that is selected into the device context. It might be interesting, then, to see what happens when a brush is selected into the DC after calling `SetBrushOrgEx()`. [1]: https://learn.microsoft.com/en-us/windows/win32/api/wingdi/nf-wingdi-setbru… -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4058#note_48306

1 0

[PATCH v3 0/19] MR388: Draft: vkd3d-shader/dxil: Complete the signature reads and read some shader properties.
by Conor McCarthy (＠cmccarthy) 11 Oct '23

11 Oct '23

Goes atop MRs 346 and 372. The last five commits are of this MR. -- v3: vkd3d-shader/dxil: Read DXIL compute shader thread group dimensions. vkd3d-shader/dxil: Read DXIL global flags. vkd3d-shader: Define more global flags. vkd3d-shader/dxil: Handle multi-row signature elements. vkd3d-shader/dxil: Handle signature element additional tag/value pairs. vkd3d-shader/dxil: Read the DXIL input and output signatures. vkd3d-shader/dxil: Validate the entry point info. vkd3d-shader/dxil: Read DXIL metadata named nodes. vkd3d-shader/dxil: Read DXIL metadata kinds. vkd3d-shader/dxil: Read DXIL metadata values. vkd3d-shader/dxil: Read DXIL metadata nodes. vkd3d-shader/dxil: Read DXIL metadata strings. vkd3d-shader/dxil: Emit an error on allocation failure in dxil_record_to_string(). vkd3d-shader/dxil: Read global constants in sm6_parser_globals_init(). vkd3d-shader/dxil: Read immediate constant arrays. tests/shader-runner: Test shaders with dxcompiler. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/388

2 19

[PATCH v9 0/14] MR372: Draft: vkd3d-shader/dxil: Read metadata and signatures.
by Conor McCarthy (＠cmccarthy) 11 Oct '23

11 Oct '23

Goes atop MR 346 and 400, and therefore is a draft until they are upstream. -- v9: vkd3d-shader/dxil: Read the DXIL input and output signatures. vkd3d-shader/dxil: Validate the entry point info. vkd3d-shader/dxil: Read DXIL metadata named nodes. vkd3d-shader/dxil: Read DXIL metadata kinds. vkd3d-shader/dxil: Read DXIL metadata values. vkd3d-shader/dxil: Read DXIL metadata nodes. vkd3d-shader/dxil: Read DXIL metadata strings. vkd3d-shader/dxil: Emit an error on allocation failure in dxil_record_to_string(). vkd3d-shader/dxil: Read global constants in sm6_parser_globals_init(). vkd3d-shader/dxil: Read immediate constant arrays. tests/shader-runner: Test shaders with dxcompiler. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/372

2 14

[PATCH 0/25] MR401: Draft: vkd3d-shader/dxil: Implement constant buffer loads.
by Conor McCarthy (＠cmccarthy) 11 Oct '23

11 Oct '23

Goes atop MR 346, 400, 372, and 388. The last six commits belong to this MR. -- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/401

2 25

[PATCH v2 0/19] MR388: Draft: vkd3d-shader/dxil: Complete the signature reads and read some shader properties.
by Conor McCarthy (＠cmccarthy) 11 Oct '23

11 Oct '23

Goes atop MRs 346 and 372. The last five commits are of this MR. -- v2: vkd3d-shader/dxil: Read DXIL compute shader thread group dimensions. vkd3d-shader/dxil: Read DXIL global flags. vkd3d-shader: Define more global flags. vkd3d-shader/dxil: Handle multi-row signature elements. vkd3d-shader/dxil: Handle signature element additional tag/value pairs. vkd3d-shader/dxil: Read the DXIL input and output signatures. vkd3d-shader/dxil: Validate the entry point info. vkd3d-shader/dxil: Read DXIL metadata named nodes. vkd3d-shader/dxil: Read DXIL metadata kinds. vkd3d-shader/dxil: Read DXIL metadata values. vkd3d-shader/dxil: Read DXIL metadata nodes. vkd3d-shader/dxil: Read DXIL metadata strings. vkd3d-shader/dxil: Emit an error on allocation failure in dxil_record_to_string(). vkd3d-shader/dxil: Read global constants in sm6_parser_globals_init(). vkd3d-shader/dxil: Read immediate constant arrays. tests/shader-runner: Test shaders with dxcompiler. tests/shader-runner: Replace immediate shader type strings with an enum. tests/shader-runner: Do not exit if a 'require' directive is not met. tests/shader-runner: Handle individual keywords in shader directives. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/388

2 19

[PATCH v8 0/14] MR372: Draft: vkd3d-shader/dxil: Read metadata and signatures.
by Conor McCarthy (＠cmccarthy) 11 Oct '23

11 Oct '23

Goes atop MR 346 and 400, and therefore is a draft until they are upstream. -- v8: vkd3d-shader/dxil: Read the DXIL input and output signatures. vkd3d-shader/dxil: Validate the entry point info. vkd3d-shader/dxil: Read DXIL metadata named nodes. vkd3d-shader/dxil: Read DXIL metadata kinds. vkd3d-shader/dxil: Read DXIL metadata values. vkd3d-shader/dxil: Read DXIL metadata nodes. vkd3d-shader/dxil: Read DXIL metadata strings. vkd3d-shader/dxil: Emit an error on allocation failure in dxil_record_to_string(). vkd3d-shader/dxil: Read global constants in sm6_parser_globals_init(). vkd3d-shader/dxil: Read immediate constant arrays. tests/shader-runner: Test shaders with dxcompiler. tests/shader-runner: Replace immediate shader type strings with an enum. tests/shader-runner: Do not exit if a 'require' directive is not met. tests/shader-runner: Handle individual keywords in shader directives. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/372

2 15

[PATCH v26 0/4] MR346: tests/shader-runner: Test DXIL shaders.
by Conor McCarthy (＠cmccarthy) 11 Oct '23

11 Oct '23

This goes on top of MR 345. -- v26: tests/shader-runner: Test shaders with dxcompiler. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/346

2 4

[PATCH v25 0/4] MR346: tests/shader-runner: Test DXIL shaders.
by Conor McCarthy (＠cmccarthy) 11 Oct '23

11 Oct '23

This goes on top of MR 345. -- v25: tests/shader-runner: Test shaders with dxcompiler. tests/shader-runner: Replace immediate shader type strings with an enum. tests/shader-runner: Do not exit if a 'require' directive is not met. tests/shader-runner: Handle individual keywords in shader directives. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/346

2 5

[PATCH v24 0/4] MR346: tests/shader-runner: Test DXIL shaders.
by Conor McCarthy (＠cmccarthy) 11 Oct '23

11 Oct '23

This goes on top of MR 345. -- v24: tests/shader-runner: Test shaders with dxcompiler. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/346

2 4

Re: [PATCH v2 0/1] MR4043: uxtheme: add some ordinals to spec file needed by Captvty
by Zhiyi Zhang (＠zhiyi) 11 Oct '23

11 Oct '23

On Wed Oct 11 01:44:29 2023 +0000, Zhiyi Zhang wrote: > It looks to me that AllowDarkModeForWindow() and SetPreferredAppMode() > set window-specific properties so that dark mode can be enabled/disabled > for individual windows. And ShouldAppsUseDarkMode() should consider > that. For the moment, returning the AppsUseLightTheme value for > ShouldAppsUseDarkMode() is probably enough. https://github.com/ysc3839/win32-darkmode/blob/master/win32-darkmode/DarkMo… also lists these undocumented functions. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4043#note_48282

1 0

Re: [PATCH v2 0/1] MR4043: uxtheme: add some ordinals to spec file needed by Captvty
by Zhiyi Zhang (＠zhiyi) 11 Oct '23

11 Oct '23

On Wed Oct 11 01:39:28 2023 +0000, Zhiyi Zhang wrote: > In that case, you should implement them. For ShouldAppsUseDarkMode(), > there is a recent MR at > https://gitlab.winehq.org/wine/wine/-/merge_requests/3959 that > implements ShouldSystemUseDarkMode(). I think ShouldAppsUseDarkMode() is > similar and uses the AppsUseLightTheme registry key. For > AllowDarkModeForWindow() and SetPreferredAppMode(), they can be > implemented as stubs for the moment. I also came across > https://gist.github.com/rounk-ctrl/b04e5622e30e0d62956870d5c22b7017 > which lists their usage. It looks to me that AllowDarkModeForWindow() and SetPreferredAppMode() set window-specific properties so that dark mode can be enabled/disabled for individual windows. And ShouldAppsUseDarkMode() should consider that. For the moment, returning the AppsUseLightTheme value for ShouldAppsUseDarkMode() is probably enough. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4043#note_48281

1 0

Re: [PATCH v2 0/1] MR4043: uxtheme: add some ordinals to spec file needed by Captvty
by Zhiyi Zhang (＠zhiyi) 11 Oct '23

11 Oct '23

On Wed Oct 11 01:39:28 2023 +0000, Louis Lenders wrote: > Hi Zhiyi, it seems it's all more complicated then I thought. The tests > failed and it seems i put the wrong function names at those ordinals. > The thread below at Autohotkey suggests that the ordinals belong to some > undocumented functions ShouldAppsUseDarkMode, AllowDarkModeForWindow > and SetPreferredAppMode, apparently they can only be imported by ordinal. > So should I now only test that they can be imported by ordinal > (something like > proc = GetProcAddress(uxtheme, MAKEINTRESOURCEA(func[i].ordinal)); > ok(proc, "getting function by ordinal failed"); )? > ) > autohotkey thread: https://www.autohotkey.com/boards/viewtopic.php?t=94661&start=20 In that case, you should implement them. For ShouldAppsUseDarkMode(), there is a recent MR at https://gitlab.winehq.org/wine/wine/-/merge_requests/3959 that implements ShouldSystemUseDarkMode(). I think ShouldAppsUseDarkMode() is similar and uses the AppsUseLightTheme registry key. For AllowDarkModeForWindow() and SetPreferredAppMode(), they can be implemented as stubs for the moment. I also came across https://gist.github.com/rounk-ctrl/b04e5622e30e0d62956870d5c22b7017 which lists their usage. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4043#note_48279

1 0

[PATCH 0/1] MR4069: winemac.drv: Use ObjC literals.
by Brendan Shanks (＠bshanks) 11 Oct '23

11 Oct '23

ObjC literals provide a simpler syntax for creating `NSNumber` objects, and creating/accessing `NSArray` and `NSDictionary`. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4069

3 2

[PATCH v2 0/1] MR366: vkd3d-shader/hlsl: Add tex2Dlod() function.
by Nikolay Sivov (＠nsivov) 10 Oct '23

10 Oct '23

Signed-off-by: Nikolay Sivov <nsivov(a)codeweavers.com> -- v2: vkd3d-shader/hlsl: Add tex2Dlod() function. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/366

2 2

[PATCH 0/1] MR4070: wow64cpu: Use RTL_CONSTANT_STRING.
by Brendan Shanks (＠bshanks) 10 Oct '23

10 Oct '23

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/4070

2 1

[PATCH 0/16] MR4046: windows.media.mediacontrol: Implement some IMusicDisplayProperties and IMusicDisplayProperties2 properties.
by Mohamad Al-Jaf (＠maljaf) 10 Oct '23

10 Oct '23

Called by Roon. -- This merge request has too many patches to be relayed via email. Please visit the URL below to see the contents of the merge request. https://gitlab.winehq.org/wine/wine/-/merge_requests/4046

2 6

Re: [PATCH v4 0/1] MR3766: uninstaller: Don't overallocate in FetchFromRootKey. - approved
by Alexandre Julliard (＠julliard) 10 Oct '23

10 Oct '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3766

1 0

Re: [PATCH v6 0/4] MR4024: uiautomationcore: COM focus change event handler event advisement support. - approved
by Alexandre Julliard (＠julliard) 10 Oct '23

10 Oct '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4024

1 0

Re: [PATCH v2 0/1] MR4067: win32u: Fix NtUserIsCurrent{Process/Thread}Window enum typo. - approved
by Alexandre Julliard (＠julliard) 10 Oct '23

10 Oct '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4067

1 0

Re: [PATCH v2 0/3] MR4038: ddraw: Always create surfaces with WINED3D_BIND_SHADER_RESOURCE if possible. - approved
by Alexandre Julliard (＠julliard) 10 Oct '23

10 Oct '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4038

1 0

Re: [PATCH v2 0/2] MR4058: gdi32/emf: Add SetBrushOrgEx() recording. - approved
by Alexandre Julliard (＠julliard) 10 Oct '23

10 Oct '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4058

1 0

Re: [PATCH v4 0/5] MR4042: windows.security.credentials.ui.userconsentverifier: Implement IUserConsentVerifierStatics::CheckAvailabilityAsync(). - approved
by Alexandre Julliard (＠julliard) 10 Oct '23

10 Oct '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4042

1 0

Re: [PATCH v17 0/2] MR3959: uxtheme: Add ShouldSystemUseDarkMode. - approved
by Alexandre Julliard (＠julliard) 10 Oct '23

10 Oct '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3959

1 0

Re: [PATCH v2 0/1] MR4062: user32/tests: use correct size to LoadStringW - approved
by Alexandre Julliard (＠julliard) 10 Oct '23

10 Oct '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4062

1 0

Re: [PATCH v5 0/6] MR3996: dmsynth: Import and begin using FluidSynth. - approved
by Alexandre Julliard (＠julliard) 10 Oct '23

10 Oct '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3996

1 0

Re: [PATCH v2 0/1] MR4059: ntdll: Implement NtQueryValueKey(KeyValuePartialInformationAlign64). - approved
by Alexandre Julliard (＠julliard) 10 Oct '23

10 Oct '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4059

1 0

Re: [PATCH v3 0/3] MR4050: Fix missing linefeeds in dmsynth, nsiproxy.sys and winewayland.drv - approved
by Alexandre Julliard (＠julliard) 10 Oct '23

10 Oct '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4050

1 0

[PATCH 0/1] MR4065: xinput1_3: Hold module reference while the hid thread is running.
by Arek Hiler (＠ivyl) 10 Oct '23

10 Oct '23

We have no means of stopping the thread from DllMain on DLL_PROCESS_DETACH without having a race condition - waiting on the thread itself is not an option due to the loader lock. The best we can do is just never unload the DLL as long as the thread is active which is forever. This fixes crashes in Mighty Switch Force! Collection while controllers are unplugged - the game loads and frees xinput in a loop. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4065

4 4

Re: [PATCH v2 0/1] MR399: vkd3d: Add partial implementation for CreateCommittedResource1(). - approved
by Alexandre Julliard (＠julliard) 10 Oct '23

10 Oct '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/399

1 0

Re: [PATCH v2 0/1] MR398: include: Fix some confusingly structured documentation. - approved
by Alexandre Julliard (＠julliard) 10 Oct '23

10 Oct '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/398

1 0

[PATCH 0/1] MR4067: win32u: Fix NtUserIsCurrent{Process/Thread}Window enum typo.
by Connor McAdams (＠cmcadams) 10 Oct '23

10 Oct '23

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/4067

4 3

[PATCH v3 0/5] MR4064: dmime: Load and play .wav file-based segments.
by Rémi Bernon (＠rbernon) 10 Oct '23

10 Oct '23

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=9027 Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=34751 Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=45135 Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=48220 -- v3: dmime: Play direct sound buffer from DMUS_PMSGT_WAVE message. dmime: Implement IDirectMusicTrack_Play for the wave track. dmime: Implement GUID_(Download|Unload)FromAudioPath for wave track. dmime: Create a wave track when loading a segment from a .wav. dmime: Get rid of the IDirectMusicWaveTrack typedef. https://gitlab.winehq.org/wine/wine/-/merge_requests/4064

4 10

Re: [PATCH v2 0/1] MR4043: uxtheme: add some ordinals to spec file needed by Captvty
by Louis Lenders (＠xe) 10 Oct '23

10 Oct '23

Hi Zhiyi, it seems it's all more complicated then I thought. The tests failed and it seems i put the wrong function names at those ordinals. The thread below at Autohotkey suggests that the ordinals belong to some undocumented functions ShouldAppsUseDarkMode, AllowDarkModeForWindow and SetPreferredAppMode, apparently they can only be imported by ordinal. So should I now only test that they can be imported by ordinal (something like proc = GetProcAddress(uxtheme, MAKEINTRESOURCEA(func[i].ordinal)); ok(proc, "getting function by ordinal failed"); )? ) autohotkey thread: https://www.autohotkey.com/boards/viewtopic.php?t=94661&start=20 -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4043#note_48238

1 0

[PATCH v5 0/4] MR4024: uiautomationcore: COM focus change event handler event advisement support.
by Connor McAdams (＠cmcadams) 10 Oct '23

10 Oct '23

-- v5: uiautomationcore: Use EVENT_OBJECT_DESTROY to remove HWNDs from the COM API focus change HWND map. uiautomationcore: Use EVENT_OBJECT_FOCUS to advise HWND providers of focus change events in the COM API. uiautomationcore: Query EVENT_OBJECT_FOCUS HWND for a serverside provider if there is a registered focus change event handler. uiautomationcore/tests: Add tests for IUIAutomationFocusChangedEventHandler event advisement behavior. https://gitlab.winehq.org/wine/wine/-/merge_requests/4024

3 5

[PATCH v4 0/4] MR4024: uiautomationcore: COM focus change event handler event advisement support.
by Connor McAdams (＠cmcadams) 10 Oct '23

10 Oct '23

-- v4: uiautomationcore: Use EVENT_OBJECT_DESTROY to remove HWNDs from the COM API focus change HWND map. https://gitlab.winehq.org/wine/wine/-/merge_requests/4024

3 5

[PATCH 0/1] MR399: vkd3d: Add partial implementation for CreateCommittedResource1().
by Nikolay Sivov (＠nsivov) 10 Oct '23

10 Oct '23

-- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/399

4 5

[PATCH 0/1] MR398: include: Fix some confusingly structured documentation.
by Zebediah Figura (＠zfigura) 10 Oct '23

10 Oct '23

-- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/398

3 2

[PATCH v23 0/4] MR346: tests/shader-runner: Test DXIL shaders.
by Conor McCarthy (＠cmccarthy) 10 Oct '23

10 Oct '23

This goes on top of MR 345. -- v23: tests/shader-runner: Test shaders with dxcompiler. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/346

3 13

[PATCH v10 0/7] MR3938: winegstreamer: Implement CLSID_CMpegVideoCodec
by Alfred Agrell (＠Alcaro) 10 Oct '23

10 Oct '23

Resolves https://bugs.winehq.org/show_bug.cgi?id=9127 . (Some of the named programs in that issue may require additional currently-missing functionality, I didn't check; but if so, that's separate issues.) Tested with - winetest on Windows 7 - winetest on Windows 10 - winetest in Wine, of course - microkiri https://bugs.winehq.org/show_bug.cgi?id=9127#c102 - Wagamama High Spec Trial Edition https://wagahigh.com/download_trial.php#normal (ダウンロード means download) - Ninki Seiyuu no Tsukurikata Trial https://archive.org/details/sayou_trial (WMV files in microkiri and Wagamama don't work, but that's separate issues. Also, they need the LC_ALL=ja_JP env, or they throw various goofy errors.) -- v10: https://gitlab.winehq.org/wine/wine/-/merge_requests/3938

2 8

[PATCH 0/2] MR343: Draft: vkd3d-shader/hlsl: Make deref->data_type available for the whole deref's lifetime.
by Francisco Casas (＠fcasas) 10 Oct '23

10 Oct '23

I marked this a draft because it may be a somewhat orthogonal step, but IRRC @giomasce suggested it. While a deref's data type can be computed from the variable's data type as long as the deref is still represented as a path (as we did with hlsl_deref_get_type()), we need the deref.data_type field for when the deref is represented as an offset. While we could get rid of this deref.data_type in the future, if we manage to transform the HLSL IR instructions directly to VSIR withot requiring lowering the derefs to their offset representation, this would take a while. So, this patch makes the deref.data_type field available during the whole lifetime of the deref. Which makes deref.data_type easier to understand (since it can be used anytime now) and we no longer have to call hlsl_deref_get_type(). -- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/343

4 8

[PATCH v9 0/8] MR3938: winegstreamer: Implement CLSID_CMpegVideoCodec
by Alfred Agrell (＠Alcaro) 10 Oct '23

10 Oct '23

Resolves https://bugs.winehq.org/show_bug.cgi?id=9127 . (Some of the named programs in that issue may require additional currently-missing functionality, I didn't check; but if so, that's separate issues.) Tested with - winetest on Windows 7 - winetest on Windows 10 - winetest in Wine, of course - microkiri https://bugs.winehq.org/show_bug.cgi?id=9127#c102 - Wagamama High Spec Trial Edition https://wagahigh.com/download_trial.php#normal (ダウンロード means download) - Ninki Seiyuu no Tsukurikata Trial https://archive.org/details/sayou_trial (WMV files in microkiri and Wagamama don't work, but that's separate issues. Also, they need the LC_ALL=ja_JP env, or they throw various goofy errors.) -- v9: Revert "ntdll: Support relocating the main exe." quartz/tests: Add tests for CLSID_CMpegVideoCodec. quartz/tests: Add tests for new CLSID_MPEG1Splitter functionality. winegstreamer: Improve and clean up some debug logs. winegstreamer: Implement a little more of IAMStreamSelect in CLSID_MPEG1Splitter. winegstreamer: Implement CLSID_CMpegVideoCodec. winegstreamer: Add program stream and video output support to CLSID_MPEG1Splitter. winegstreamer: Add WG_MAJOR_TYPE_VIDEO_MPEG1 media type. https://gitlab.winehq.org/wine/wine/-/merge_requests/3938

4 10

Re: [PATCH v2 0/1] MR4043: uxtheme: add some ordinals to spec file needed by Captvty
by Zhiyi Zhang (＠zhiyi) 10 Oct '23

10 Oct '23

``` + void *proc; + int i; + HMODULE uxtheme = GetModuleHandleA("uxtheme.dll"); + static const struct + { + const char *name; + int ordinal; + } + func[] = + { + {"DrawThemeBackgroundEx", 47}, + {"IsThemeDialogTextureEnabled", 132}, + {"IsThemePartDefined", 133}, + {"SetThemeAppProperties", 135} + }; ``` Let's put the static const test data first. And let's sort the declarations, like this. ``` + HMODULE uxtheme; + void *proc; + int i; + + uxtheme= GetModuleHandleA("uxtheme.dll"); ``` ``` + for (i = 0; i < ARRAY_SIZE(func); i++) + { + proc = GetProcAddress(uxtheme, MAKEINTRESOURCEA(func->ordinal)); + ok(proc == GetProcAddress(uxtheme, func->name), "Expected %s at ordinal %u\n", func->name, func->ordinal); + } ``` You're not using i at all so you're just testing the first function. ```ok(proc == GetProcAddress(uxtheme, func->name), "Expected %s at ordinal %u\n", func->name, func->ordinal);``` "Expected %s at ordinal %u\n" -> "Expected %s at ordinal %d.\n" You can remove the ordinal tests for DrawThemeBackgroundEx() in test_DrawThemeBackgroundEx(). Thank you for working on this by the way. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4043#note_48211

1 0

Re: [PATCH v2 0/1] MR4043: uxtheme: add some ordinals to spec file needed by Captvty
by Gabriel Ivăncescu (＠insn) 10 Oct '23

10 Oct '23

On Tue Oct 10 14:26:32 2023 +0000, Louis Lenders wrote: > Well, I don't know about coders etiquette but at the organization I work > it's not rude to ask an expert to fix a problem... Anyway I fixed up a > test, and Ill reopen the bug. @zhiyi, could you have a look at patch > below? I'm attaching it as a patch for now as I don't want to go through > gitlab horror again. > diff --git a/dlls/uxtheme/tests/system.c b/dlls/uxtheme/tests/system.c > index 2e769625dab..0c1a1b28fee 100644 > --- a/dlls/uxtheme/tests/system.c > +++ b/dlls/uxtheme/tests/system.c > @@ -285,6 +285,31 @@ static LRESULT WINAPI > TestSetWindowThemeChildProcA(HWND hwnd, UINT message, WPAR > return ret; > } > > +static void test_ordinals(void) > +{ > + void *proc; > + int i; > + HMODULE uxtheme = GetModuleHandleA("uxtheme.dll"); > + static const struct > + { > + const char *name; > + int ordinal; > + } > + func[] = > + { > + {"DrawThemeBackgroundEx", 47}, > + {"IsThemeDialogTextureEnabled", 132}, > + {"IsThemePartDefined", 133}, > + {"SetThemeAppProperties", 135} > + }; > + > + for (i = 0; i < ARRAY_SIZE(func); i++) > + { > + proc = GetProcAddress(uxtheme, MAKEINTRESOURCEA(func->ordinal)); > + ok(proc == GetProcAddress(uxtheme, func->name), "Expected %s at > ordinal %u\n", func->name, func->ordinal); > + } > +} > + > static void test_IsThemed(void) > { > BOOL bThemeActive; > @@ -2605,6 +2630,7 @@ START_TEST(system) > init_funcs(); > init_msg_sequences(sequences, NUM_MSG_SEQUENCES); > > + test_ordinals(); > test_IsThemed(); > test_IsThemePartDefined(); > test_GetWindowTheme(); You don't have to go through gitlab horror again, just force push to your branch with git with updated local branch. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4043#note_48210

1 0

Re: [PATCH v2 0/1] MR4043: uxtheme: add some ordinals to spec file needed by Captvty
by Louis Lenders (＠xe) 10 Oct '23

10 Oct '23

patch is at https://testbot.winehq.org/GetFile.pl?JobKey=138590&StepKey=1 -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4043#note_48209

1 0

[PATCH 0/1] MR4043: uxtheme: add some ordinals to spec file needed by Captvty
by Louis Lenders (＠xe) 10 Oct '23

10 Oct '23

https://bugs.winehq.org/show_bug.cgi?id=55742 -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4043

4 8

2025

2024

2023

2022

wine-gitlab