- wine-gitlab - winehq.org

[PATCH 0/4] MR4054: mshtml: HTMLWindow behavior improvements.
by Gabriel Ivăncescu (＠insn) 10 Oct '23

10 Oct '23

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/4054

4 11

[PATCH 0/3] MR4038: ddraw: Always create surfaces with WINED3D_BIND_SHADER_RESOURCE if possible.
by Zebediah Figura (＠zfigura) 10 Oct '23

10 Oct '23

Surfaces without DDSCAPS_TEXTURE can still be textured when used with a software device. wined3d currently doesn't care about the bind flags for surfaces set with wined3d_stateblock_set_texture(), but we currently set the right bind flags anyway. More saliently, I plan to change this fact, and internally translate those textures to SRVs, in order to simplify some internal code and make d3d1-9 support for the Vulkan backend easier. In this case we really will need WINED3D_BIND_SHADER_RESOURCE to be set. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4038

4 7

[PATCH v3 0/4] MR4024: uiautomationcore: COM focus change event handler event advisement support.
by Connor McAdams (＠cmcadams) 10 Oct '23

10 Oct '23

-- v3: uiautomationcore: Use EVENT_OBJECT_DESTROY to remove HWNDs from the COM API focus change HWND map. uiautomationcore: Use EVENT_OBJECT_FOCUS to advise HWND providers of focus change events in the COM API. uiautomationcore: Query EVENT_OBJECT_FOCUS HWND for a serverside provider if there is a registered focus change event handler. uiautomationcore/tests: Add tests for IUIAutomationFocusChangedEventHandler event advisement behavior. https://gitlab.winehq.org/wine/wine/-/merge_requests/4024

3 7

[PATCH v2 0/5] MR4064: dmime: Load and play .wav file-based segments.
by Rémi Bernon (＠rbernon) 10 Oct '23

10 Oct '23

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=9027 Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=34751 Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=45135 Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=48220 -- v2: dmime: Play direct sound buffer from DMUS_PMSGT_WAVE message. dmime: Implement IDirectMusicTrack_Play for the wave track. dmime: Implement GUID_(Download|Unload)FromAudioPath for wave track. dmime: Create a wave track when loading a segment from a .wav. dmime: Get rid of the IDirectMusicWaveTrack typedef. https://gitlab.winehq.org/wine/wine/-/merge_requests/4064

3 7

[PATCH v2 0/2] MR4047: Msxml copytests
by Daniel Lehman (＠dlehman25) 10 Oct '23

10 Oct '23

-- v2: msxml6/tests: Copy namespaces as attributes tests. msxml4/tests: Copy namespaces as attributes tests. https://gitlab.winehq.org/wine/wine/-/merge_requests/4047

3 3

[PATCH 0/2] MR4058: gdi32/emf: Add SetBrushOrgEx() recording.
by Nikolay Sivov (＠nsivov) 10 Oct '23

10 Oct '23

Signed-off-by: Nikolay Sivov <nsivov(a)codeweavers.com> -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4058

3 3

[PATCH 0/5] MR4064: dmime: Load and play .wav file-based segments.
by Rémi Bernon (＠rbernon) 10 Oct '23

10 Oct '23

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=9027 Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=34751 Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=48220 Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=61322 -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4064

3 6

[PATCH v3 0/5] MR4042: windows.security.credentials.ui.userconsentverifier: Implement IUserConsentVerifierStatics::CheckAvailabilityAsync().
by Mohamad Al-Jaf (＠maljaf) 10 Oct '23

10 Oct '23

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=55709 There appears to be a race condition happening. When it doesn't work, it looks like the apartment is not initialized, output: ``` 01e8:fixme:combase:RoGetActivationFactory (L"Windows.Security.Credentials.UI.UserConsentVerifier", {af4f3f91-564c-4ddc-b8b5-973447627c65}, 000000000011E890): semi-stub 01e8:fixme:credentials:factory_QueryInterface {94ea2b94-e9cc-49e0-c0ff-ee64ca8f5b90} not implemented, returning E_NOINTERFACE. 0220:err:ole:CoGetContextToken apartment not initialised 0220:fixme:ole:thread_context_callback_ContextCallback 000000000347E4A8, 00007FFFFE10D510, 0000000005C7FBA0, {0a299774-3e4e-fc42-1d9d-72cee105ca57}, 5, 0000000000000000 0220:fixme:combase:RoOriginateLanguageException 0x80004001, L"", 0000000000000000: stub wine: Call from 0000000174013C17 to unimplemented function combase.dll.RoFailFastWithErrorContext, aborting wine: Unimplemented function combase.dll.RoFailFastWithErrorContext called at address 0000000174013C17 (thread 0220), starting debugger. ``` Adding in WINEDEBUG=+credentials makes it consistently work: ``` 0154:fixme:combase:RoGetActivationFactory (L"Windows.Security.Credentials.UI.UserConsentVerifier", {af4f3f91-564c-4ddc-b8b5-973447627c65}, 000000000011E890): semi-stub 0154:trace:credentials:DllGetActivationFactory class L"Windows.Security.Credentials.UI.UserConsentVerifier", factory 000000000011E6C0. 0154:trace:credentials:factory_QueryInterface iface 00000001F3B04040, iid {00000035-0000-0000-c000-000000000046}, out 000000000011E6C0. 0154:trace:credentials:factory_AddRef iface 00000001F3B04040 increasing refcount to 2. 0154:trace:credentials:factory_QueryInterface iface 00000001F3B04040, iid {af4f3f91-564c-4ddc-b8b5-973447627c65}, out 000000000011E890. 0154:trace:credentials:factory_AddRef iface 00000001F3B04040 increasing refcount to 3. 0154:trace:credentials:factory_Release iface 00000001F3B04040 decreasing refcount to 2. 0154:trace:credentials:factory_QueryInterface iface 00000001F3B04040, iid {94ea2b94-e9cc-49e0-c0ff-ee64ca8f5b90}, out 000000000011E898. 0154:fixme:credentials:factory_QueryInterface {94ea2b94-e9cc-49e0-c0ff-ee64ca8f5b90} not implemented, returning E_NOINTERFACE. 0154:trace:credentials:user_consent_verifier_statics_CheckAvailabilityAsync iface 00000001F3B04048, result 000000000011E868 0154:trace:credentials:factory_AddRef iface 00000001F3B04040 increasing refcount to 3. 0154:trace:credentials:async_impl_Start iface 0000000000791260. 0154:trace:credentials:async_UserConsentVerifierAvailability_AddRef iface 0000000003461650, ref 2. 0154:trace:credentials:async_operation_UserConsentVerifierAvailability_create created IAsyncOperation_UserConsentVerifierAvailability 0000000003461650 0154:trace:credentials:factory_Release iface 00000001F3B04040 decreasing refcount to 2. 0154:trace:credentials:async_UserConsentVerifierAvailability_AddRef iface 0000000003461650, ref 3. 0154:trace:credentials:async_UserConsentVerifierAvailability_put_Completed iface 0000000003461650, handler 00000000033E2410. 0154:trace:credentials:async_impl_put_Completed iface 0000000000791260, handler 00000000033E2410. 0154:trace:credentials:async_UserConsentVerifierAvailability_GetResults iface 0000000003461650, results 000000000011E790. 0154:trace:credentials:async_impl_get_Result iface 0000000000791260, result 000000000011E700. 018c:trace:credentials:async_UserConsentVerifierAvailability_Release iface 0000000003461650, ref 2. 0154:trace:credentials:async_UserConsentVerifierAvailability_Release iface 0000000003461650, ref 1. 0154:trace:credentials:async_UserConsentVerifierAvailability_Release iface 0000000003461650, ref 0. 0154:trace:credentials:async_impl_Release iface 0000000000791260, ref 0. 0154:trace:credentials:async_info_Close iface 0000000000791268. 0154:trace:credentials:factory_Release iface 00000001F3B04040 decreasing refcount to 1. ``` -- v3: windows.security.credentials.ui.userconsentverifier/tests: Add IUserConsentVerifierStatics::CheckAvailabilityAsync() tests. windows.security.credentials.ui.userconsentverifier: Implement IUserConsentVerifierStatics::CheckAvailabilityAsync(). windows.security.credentials.ui.userconsentverifier: Add IUserConsentVerifierStatics stub interface. windows.security.credentials.ui.userconsentverifier: Add stub DLL. include: Add windows.security.credentials.ui.idl file. https://gitlab.winehq.org/wine/wine/-/merge_requests/4042

3 7

[PATCH 0/1] MR4062: user32/tests: use correct size to LoadStringW
by Marcus Meissner (＠msmeissn) 10 Oct '23

10 Oct '23

Signed-off-by: Marcus Meissner <marcus(a)jet.franken.de> -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4062

2 1

[PATCH 0/1] MR4061: tools: test.yml - Remove duplicate winetest parameter
by Alistair Leslie-Hughes (＠alesliehughes) 10 Oct '23

10 Oct '23

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/4061

3 3

[PATCH v22 0/4] MR346: tests/shader-runner: Test DXIL shaders.
by Conor McCarthy (＠cmccarthy) 10 Oct '23

10 Oct '23

This goes on top of MR 345. -- v22: tests/shader-runner: Test shaders with dxcompiler. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/346

2 11

[PATCH v3 0/1] MR3908: wineserver: Report non-zero exit code for abnormal process termination
by Adam Rehn (＠adamrehn) 10 Oct '23

10 Oct '23

**Overview:** Wine currently reports an exit code of zero for processes that terminate due to either of the following conditions: - The Linux process that represents the Windows process receives a signal such as `SIGKILL` (e.g. due to a user manually killing the process, or the Linux OOM killer targeting the process due to memory pressure) - The process fails to start because the image is a 32-bit executable and Wine has only been built with 64-bit support Both of these scenarios represent failures, and so a non-zero exit code is appropriate. This patch ensures that an exit code of 1 is reported for these abnormal process termination edge cases. **Underlying cause:** The following logic flow occurs in the Wine server for typical process termination: 1. When a `process` object is created by the Wine server, its `exit_code` field is [set to an initial value](https://gitlab.winehq.org/wine/wine/-/blob/wine-8.16/server/process.… of `STILL_ACTIVE`, and the `exit_code` field in each of its corresponding `thread` objects is [set to a default value of zero](https://gitlab.winehq.org/wine/wine/-/blob/wine-8.16/server/thread.c?…. 2. When a client process terminates, it sends a `terminate_process` protocol request to the server, and the handler [passes the specified exit code](https://gitlab.winehq.org/wine/wine/-/blob/wine-8.16/server/process.c… to the `terminate_process()` function. This function sets the `is_terminating` field of the process object [to a value of 1](https://gitlab.winehq.org/wine/wine/-/blob/wine-8.16/server/process.c?re…, and if the exit code is non-zero then it also [copies its value to each of the thread objects](https://gitlab.winehq.org/wine/wine/-/blob/wine-8.16/server/proces… for the process. 3. The client process closes the pipe that it had been using to communicate with the server. 4. The server [detects the pipe close event](https://gitlab.winehq.org/wine/wine/-/blob/wine-8.16/server/process.… and calls the `kill_process()` function, specifying a value of zero for the `violent_death` parameter. 5. The logic in the `kill_process()` function identifies this as a [normal termination on pipe close](https://gitlab.winehq.org/wine/wine/-/blob/wine-8.16/server/process.…, and then subsequently calls the `kill_thread()` function to [kill each of the threads for the process](https://gitlab.winehq.org/wine/wine/-/blob/wine-8.16/server/proces…. 6. The `kill_thread()` function [then calls](https://gitlab.winehq.org/wine/wine/-/blob/wine-8.16/server/thread.c… `remove_process_thread()`, which [copies the exit code from the last thread object](https://gitlab.winehq.org/wine/wine/-/blob/wine-8.16/server/process… to the `exit_code` field of the process object. 7. The final value of the `exit_code` field is [reported when responding](https://gitlab.winehq.org/wine/wine/-/blob/wine-8.16/server/pro… to `get_process_info` protocol requests, [as sent by](https://gitlab.winehq.org/wine/wine/-/blob/wine-8.16/dlls/ntdll/unix/pr… `NtQueryInformationProcess()`. The abnormal process termination scenarios listed earlier will skip the `terminate_process` protocol request and immediately close the pipe. As a result, the `is_terminating` field of the process object will retain its default value of zero, and the `exit_code` field of each thread for the process will also remain at the default value of zero. Since the logic in `process_poll_event()` always treats a pipe close event as a non-violent termination, `remove_process_thread()` will simply copy the exit code value of zero from the last thread into the process object, and this will then be reported when querying the process exit code. **Fix details:** The fix modifies `process_poll_event()` to check the value of the `is_terminating` field of the process object, and to treat a pipe close event as a violent termination if the value of the field is zero. This triggers the alternative code path in `kill_process()` that calls `terminate_process()` and [specifies an exit code value of 1](https://gitlab.winehq.org/wine/wine/-/blob/wine-8.16/server/process.c?re…, which is copied to the thread objects and subsequently to the process object. In my testing, only the abnormal process termination scenarios listed above result in the value of the `is_terminating` field being zero when the pipe is closed. In all other scenarios, I have observed the value to be 1 when the pipe close event is detected. Non-abnormal scenarios tested include ordinary process completion with both zero and non-zero exit codes, crashes in Windows processes due to unhandled exceptions, and ending processes via the Wine implementation of Task Manager. -- v3: wineserver: Report non-zero exit code for abnormal process termination https://gitlab.winehq.org/wine/wine/-/merge_requests/3908

3 2

[PATCH v16 0/2] MR3959: uxtheme: Add ShouldSystemUseDarkMode.
by Helix Graziani (＠TornadoCookie) 10 Oct '23

10 Oct '23

Used in some .NET apps for theming purposes. -- v16: uxtheme: Add ShouldSystemUseDarkMode. winecfg: Change system theme alongside app theme. https://gitlab.winehq.org/wine/wine/-/merge_requests/3959

4 4

[PATCH 0/1] MR4059: ntdll: Implement NtQueryValueKey(KeyValuePartialInformationAlign64).
by Paul Gofman (＠gofman) 10 Oct '23

10 Oct '23

I also looked into supporting that in NtEnumerateValueKey() at once, but it doesn't look like Windows supports it with KeyValuePartialInformationAlign64, I was only getting STATUS_INVALID_PARAMETER in tests. I also don't see NtQueryValueKey actually enforcing 64 bit alignment requirement (this part is in the tests). -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4059

2 1

[PATCH v2 0/1] MR4031: d3dx9: D3DXLoadMeshHierarchyFromXInMemory support empty mesh.
by Alistair Leslie-Hughes (＠alesliehughes) 09 Oct '23

09 Oct '23

-- v2: d3dx9: D3DXLoadMeshHierarchyFromXInMemory support empty mesh. https://gitlab.winehq.org/wine/wine/-/merge_requests/4031

2 3

[PATCH v2 0/3] MR4050: Fix missing linefeeds in dmsynth, nsiproxy.sys and winewayland.drv
by Francois Gouget (＠fgouget) 09 Oct '23

09 Oct '23

-- v2: nsiproxy.sys: Add a trailing linefeed to a TRACE() message. https://gitlab.winehq.org/wine/wine/-/merge_requests/4050

3 6

[PATCH v21 0/4] MR346: tests/shader-runner: Test DXIL shaders.
by Conor McCarthy (＠cmccarthy) 09 Oct '23

09 Oct '23

This goes on top of MR 345. -- v21: tests/shader-runner: Test shaders with dxcompiler. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/346

3 27

[PATCH v4 0/6] MR3996: dmsynth: Import and begin using FluidSynth.
by Rémi Bernon (＠rbernon) 09 Oct '23

09 Oct '23

-- v4: dmsynth: Create and register a fluid_sfont instance. dmsynth: Create a fluid_synth instance on Open. dmsynth: Simplify IDirectMusicSynth8_Open checks. fluidsynth: Use Wine debugging facility for traces. dmsynth: Import and use FluidSynth 2.3.3. dmime/tests: Queue the message before calling SendPMsg twice. https://gitlab.winehq.org/wine/wine/-/merge_requests/3996

3 8

Re: [PATCH v2 0/1] MR4056: shell32: Fix parsing empty arguments in parse_dde_command(). - approved
by Alexandre Julliard (＠julliard) 09 Oct '23

09 Oct '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4056

1 0

Re: [PATCH v2 0/2] MR4048: Fix reading debuggee environment. - approved
by Alexandre Julliard (＠julliard) 09 Oct '23

09 Oct '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4048

1 0

Re: [PATCH v2 0/1] MR4053: include: Avoid narrowing warning in wine_dbgstr_fourcc. - approved
by Alexandre Julliard (＠julliard) 09 Oct '23

09 Oct '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4053

1 0

Re: [PATCH v2 0/2] MR4055: d3dx9: Support empty mesh. - approved
by Alexandre Julliard (＠julliard) 09 Oct '23

09 Oct '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4055

1 0

Re: [PATCH v3 0/1] MR3955: mf: Avoid a double free of presentation clock timers. - approved
by Alexandre Julliard (＠julliard) 09 Oct '23

09 Oct '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3955

1 0

Re: [PATCH v2 0/1] MR3748: cmd: Reset ignoreBracket to FALSE when moving to the next line. - approved
by Alexandre Julliard (＠julliard) 09 Oct '23

09 Oct '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3748

1 0

Re: [PATCH v3 0/3] MR4026: Add ResetPrinter support and use it in ResetDC. - approved
by Alexandre Julliard (＠julliard) 09 Oct '23

09 Oct '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4026

1 0

Re: [PATCH v3 0/5] MR4041: gdi32: A few fixes for EMF recording - approved
by Alexandre Julliard (＠julliard) 09 Oct '23

09 Oct '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4041

1 0

Re: [PATCH v11 0/1] MR3777: gdi32: Add stub for D3DKMTQueryAdapterInfo. - approved
by Alexandre Julliard (＠julliard) 09 Oct '23

09 Oct '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3777

1 0

Re: [PATCH v3 0/7] MR4036: dmime: Implement segment state and tracks InitPlay / Play / EndPlay. - approved
by Alexandre Julliard (＠julliard) 09 Oct '23

09 Oct '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4036

1 0

Re: [PATCH v2 0/1] MR4040: advapi32/tests: Add ReadEventLogA tests for EventlogStarted. - approved
by Alexandre Julliard (＠julliard) 09 Oct '23

09 Oct '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4040

1 0

Re: [PATCH v2 0/1] MR4039: imagehlp: Import functions instead of forwarding. - approved
by Alexandre Julliard (＠julliard) 09 Oct '23

09 Oct '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4039

1 0

Re: [PATCH v2 0/1] MR4034: d3d10/tests: Add a test for log2/log10/exp2 functions in expressions. - approved
by Alexandre Julliard (＠julliard) 09 Oct '23

09 Oct '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4034

1 0

Re: [PATCH v3 0/4] MR394: vkd3d-shader: sm1 texture interface. - approved
by Alexandre Julliard (＠julliard) 09 Oct '23

09 Oct '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/394

1 0

[PATCH v5 0/5] MR358: vkd3d-shader/hlsl: Parse 'centroid' and 'noperspective' modifiers.
by Nikolay Sivov (＠nsivov) 09 Oct '23

09 Oct '23

Signed-off-by: Nikolay Sivov <nsivov(a)codeweavers.com> -- v5: vkd3d-shader/tpf: Output interpolation modifiers for input declarations. vkd3d-shader/hlsl: Propagate structure fields modifiers when copying shader inputs. vkd3d-shader/hlsl: Allow interpolation modifiers on structure fields. vkd3d-shader/hlsl: Parse 'centroid' and 'noperspective' modifiers. tests: Add a test for interpolation modifiers specified on structure fields. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/358

3 6

Re: [PATCH v8 0/4] MR245: vkd3d-shader/hlsl: Add support for 'break' and 'continue' jumps in loops. - approved
by Alexandre Julliard (＠julliard) 09 Oct '23

09 Oct '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/245

1 0

Re: [PATCH v2 0/1] MR397: vkd3d: Add partial implementation for CreateHeap1(). - approved
by Alexandre Julliard (＠julliard) 09 Oct '23

09 Oct '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/397

1 0

Re: [PATCH v2 0/1] MR395: vkd3d-shader/spirv: When declaring a CBV initialise the register with the register index range. - approved
by Alexandre Julliard (＠julliard) 09 Oct '23

09 Oct '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/395

1 0

Re: [PATCH v2 0/1] MR393: vkd3d-shader/spirv: Add a debug name for the push constant buffer. - approved
by Alexandre Julliard (＠julliard) 09 Oct '23

09 Oct '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/393

1 0

Re: [PATCH v2 0/1] MR392: vkd3d-shader/tpf: Get rid of the output map. - approved
by Alexandre Julliard (＠julliard) 09 Oct '23

09 Oct '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/392

1 0

Re: [PATCH v2 0/1] MR391: vkd3d-shader/hlsl: Get rid of the vkd3d_sm4_* forward declarations in hlsl.h. - approved
by Alexandre Julliard (＠julliard) 09 Oct '23

09 Oct '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/391

1 0

[PATCH 0/1] MR4053: include: Avoid narrowing warning in wine_dbgstr_fourcc.
by Rémi Bernon (＠rbernon) 09 Oct '23

09 Oct '23

This otherwise causes a warning when compiling C++ with "wine/debug.h" included. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4053

3 2

[PATCH v2 0/6] MR4042: windows.security.credentials.ui.userconsentverifier: Implement IUserConsentVerifierStatics::CheckAvailabilityAsync().
by Mohamad Al-Jaf (＠maljaf) 09 Oct '23

09 Oct '23

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=55709 There appears to be a race condition happening. When it doesn't work, it looks like the apartment is not initialized, output: ``` 01e8:fixme:combase:RoGetActivationFactory (L"Windows.Security.Credentials.UI.UserConsentVerifier", {af4f3f91-564c-4ddc-b8b5-973447627c65}, 000000000011E890): semi-stub 01e8:fixme:credentials:factory_QueryInterface {94ea2b94-e9cc-49e0-c0ff-ee64ca8f5b90} not implemented, returning E_NOINTERFACE. 0220:err:ole:CoGetContextToken apartment not initialised 0220:fixme:ole:thread_context_callback_ContextCallback 000000000347E4A8, 00007FFFFE10D510, 0000000005C7FBA0, {0a299774-3e4e-fc42-1d9d-72cee105ca57}, 5, 0000000000000000 0220:fixme:combase:RoOriginateLanguageException 0x80004001, L"", 0000000000000000: stub wine: Call from 0000000174013C17 to unimplemented function combase.dll.RoFailFastWithErrorContext, aborting wine: Unimplemented function combase.dll.RoFailFastWithErrorContext called at address 0000000174013C17 (thread 0220), starting debugger. ``` Adding in WINEDEBUG=+credentials makes it consistently work: ``` 0154:fixme:combase:RoGetActivationFactory (L"Windows.Security.Credentials.UI.UserConsentVerifier", {af4f3f91-564c-4ddc-b8b5-973447627c65}, 000000000011E890): semi-stub 0154:trace:credentials:DllGetActivationFactory class L"Windows.Security.Credentials.UI.UserConsentVerifier", factory 000000000011E6C0. 0154:trace:credentials:factory_QueryInterface iface 00000001F3B04040, iid {00000035-0000-0000-c000-000000000046}, out 000000000011E6C0. 0154:trace:credentials:factory_AddRef iface 00000001F3B04040 increasing refcount to 2. 0154:trace:credentials:factory_QueryInterface iface 00000001F3B04040, iid {af4f3f91-564c-4ddc-b8b5-973447627c65}, out 000000000011E890. 0154:trace:credentials:factory_AddRef iface 00000001F3B04040 increasing refcount to 3. 0154:trace:credentials:factory_Release iface 00000001F3B04040 decreasing refcount to 2. 0154:trace:credentials:factory_QueryInterface iface 00000001F3B04040, iid {94ea2b94-e9cc-49e0-c0ff-ee64ca8f5b90}, out 000000000011E898. 0154:fixme:credentials:factory_QueryInterface {94ea2b94-e9cc-49e0-c0ff-ee64ca8f5b90} not implemented, returning E_NOINTERFACE. 0154:trace:credentials:user_consent_verifier_statics_CheckAvailabilityAsync iface 00000001F3B04048, result 000000000011E868 0154:trace:credentials:factory_AddRef iface 00000001F3B04040 increasing refcount to 3. 0154:trace:credentials:async_impl_Start iface 0000000000791260. 0154:trace:credentials:async_UserConsentVerifierAvailability_AddRef iface 0000000003461650, ref 2. 0154:trace:credentials:async_operation_UserConsentVerifierAvailability_create created IAsyncOperation_UserConsentVerifierAvailability 0000000003461650 0154:trace:credentials:factory_Release iface 00000001F3B04040 decreasing refcount to 2. 0154:trace:credentials:async_UserConsentVerifierAvailability_AddRef iface 0000000003461650, ref 3. 0154:trace:credentials:async_UserConsentVerifierAvailability_put_Completed iface 0000000003461650, handler 00000000033E2410. 0154:trace:credentials:async_impl_put_Completed iface 0000000000791260, handler 00000000033E2410. 0154:trace:credentials:async_UserConsentVerifierAvailability_GetResults iface 0000000003461650, results 000000000011E790. 0154:trace:credentials:async_impl_get_Result iface 0000000000791260, result 000000000011E700. 018c:trace:credentials:async_UserConsentVerifierAvailability_Release iface 0000000003461650, ref 2. 0154:trace:credentials:async_UserConsentVerifierAvailability_Release iface 0000000003461650, ref 1. 0154:trace:credentials:async_UserConsentVerifierAvailability_Release iface 0000000003461650, ref 0. 0154:trace:credentials:async_impl_Release iface 0000000000791260, ref 0. 0154:trace:credentials:async_info_Close iface 0000000000791268. 0154:trace:credentials:factory_Release iface 00000001F3B04040 decreasing refcount to 1. ``` -- v2: windows.security.credentials.ui.userconsentverifier/tests: Add IUserConsentVerifierStatics::CheckAvailabilityAsync() tests. windows.security.credentials.ui.userconsentverifier: Implement IUserConsentVerifierStatics::CheckAvailabilityAsync(). windows.security.credentials.ui.userconsentverifier: Import and modify IAsyncOperation from windows.gaming.input. https://gitlab.winehq.org/wine/wine/-/merge_requests/4042

4 8

[PATCH v2 0/4] MR394: vkd3d-shader: sm1 texture interface.
by Zebediah Figura (＠zfigura) 09 Oct '23

09 Oct '23

This defines (and, broadly, implements) the API for mapping sm1 combined samplers to the target environment. This is possibly the simplest bit of API for sm1 support thus far. It does not actually involve any API changes. Rather, each combined sampler is split into two descriptors, one for the sampler and one for the texture, both with the same binding index as the original combined sampler. -- I feel rather positive about this bit of API. it required very little design concern or implementation difficulty on the vkd3d side. On the Wine side, it required quite a lot of change, but I think pretty much all of that change was positive on its own merits, and should probably be applied independently of the sm1/Vulkan work. We've talked about translating wined3d_device_set_sampler_state() and wined3d_device_set_texture() to wined3d_device_set_sampler() and wined3d_device_set_shader_resource_view() for quite some time now, and that was pretty much exactly what was required to make this work—that and choosing the obvious mapping of "same index for both state objects". The most obvious alternative to this design, to me, would be to reroll struct vkd3d_shader_interface_info (or extend it without rerolling), adding a new array for mapping a combined sampler in the *source* environment to two separate descriptors in the *target* environment, i.e. struct vkd3d_shader_resource_binding in reverse. We would probably also want to design a way to map a combined sampler to a combined sampler (a sixth array? Or reuse struct vkd3d_shader_descriptor_binding with a new descriptor type?) I suppose the advantage of such an alternative design would be that it reports "one" descriptor as "one", not "two", but the associated complexity seems far greater, and accordingly I don't really want to give it the time of day. (Note also that this patch set handles combined -> combined mapping without any extra effort). I will of course yield to maintainer preference, though. -- As before, I've prepared proof-of-concept code for Wine. The branches are here: https://gitlab.winehq.org/zfigura/vkd3d/-/commits/himavant5 https://gitlab.winehq.org/zfigura/wine/-/commits/himavant6 The relevant test can be run with: make tests/shader_runner.exe && WINE_D3D_CONFIG=renderer=vulkan wine tests/shader_runner.exe ../vkd3d/tests/hlsl/tex2D.shader_test These branches are rather larger than the previous ones. By way of summary, the vkd3d branch contains these patches, plus about two dozen patches to hook up sm1 tests and to fix various corner cases surrounding semantic translation (much of which should be rewritten with a VSIR-based "lowering" approach in mind). The Wine branch contains: * Wine merge request 4027, * the patches for sm1 constant buffers, * a set of patches to transform individual sampler states into sampler objects (of which [1] is the most interesting), and * a set of patches to transform textures into SRVs (of which [2] is the most interesting). As described above, there is not actually any part of the Wine side that touches the vkd3d-shader interface. [1] https://gitlab.winehq.org/zfigura/wine/-/commit/984e478763c99157a6ec49388fe… [2] https://gitlab.winehq.org/zfigura/wine/-/commit/722c1bf1f6a7691c9ed431bd433… ``` What are the roots that clutch, what branches grow Out of this stony rubbish? Son of man, You cannot say, or guess, for you know only A heap of broken images, where the sun beats, And the dead tree gives no shelter, the cricket no relief, And the dry stone no sound of water. ``` -- v2: vkd3d-shader/ir: Translate TEX instructions to SAMPLE. vkd3d-shader: Scan combined sampler declarations. include: Define an API for mapping sm1 samplers to the target environment. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/394

3 5

[PATCH v4 0/5] MR358: vkd3d-shader/hlsl: Parse 'centroid' and 'noperspective' modifiers.
by Nikolay Sivov (＠nsivov) 09 Oct '23

09 Oct '23

Signed-off-by: Nikolay Sivov <nsivov(a)codeweavers.com> -- v4: vkd3d-shader/tpf: Output interpolation modifiers for input declarations. vkd3d-shader/hlsl: Propagate structure fields modifiers when copying shader inputs. vkd3d-shader/hlsl: Allow interpolation modifiers on structure fields. vkd3d-shader/hlsl: Parse 'centroid' and 'noperspective' modifiers. tests: Add a test for interpolation modifiers specified on structure fields. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/358

4 9

[PATCH v7 0/4] MR245: vkd3d-shader/hlsl: Add support for 'break' and 'continue' jumps in loops.
by Nikolay Sivov (＠nsivov) 09 Oct '23

09 Oct '23

Signed-off-by: Nikolay Sivov <nsivov(a)codeweavers.com> -- v7: vkd3d-shader/tpf: Write 'continue' instruction. vkd3d-shader/hlsl: Handle 'continue' statements. vkd3d-shader/hlsl: Allow 'break' instructions in loops. tests: Add some tests for 'break'/'continue' in loops. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/245

4 7

[PATCH v3 0/4] MR3789: Improve media session handling of unexpected errors.
by Santino Mazza (＠tati1454) 09 Oct '23

09 Oct '23

-- v3: mf: Handle errors with source event generator in session. mf/test: Test error case when session is streaming. mf/test: Move stream sink stub above media sink stub. mf/test: Test error cases in media sesssion. https://gitlab.winehq.org/wine/wine/-/merge_requests/3789

3 6

[PATCH 0/4] MR394: vkd3d-shader: sm1 texture interface.
by Zebediah Figura (＠zfigura) 09 Oct '23

09 Oct '23

This defines (and, broadly, implements) the API for mapping sm1 combined samplers to the target environment. This is possibly the simplest bit of API for sm1 support thus far. It does not actually involve any API changes. Rather, each combined sampler is split into two descriptors, one for the sampler and one for the texture, both with the same binding index as the original combined sampler. -- I feel rather positive about this bit of API. it required very little design concern or implementation difficulty on the vkd3d side. On the Wine side, it required quite a lot of change, but I think pretty much all of that change was positive on its own merits, and should probably be applied independently of the sm1/Vulkan work. We've talked about translating wined3d_device_set_sampler_state() and wined3d_device_set_texture() to wined3d_device_set_sampler() and wined3d_device_set_shader_resource_view() for quite some time now, and that was pretty much exactly what was required to make this work—that and choosing the obvious mapping of "same index for both state objects". The most obvious alternative to this design, to me, would be to reroll struct vkd3d_shader_interface_info (or extend it without rerolling), adding a new array for mapping a combined sampler in the *source* environment to two separate descriptors in the *target* environment, i.e. struct vkd3d_shader_resource_binding in reverse. We would probably also want to design a way to map a combined sampler to a combined sampler (a sixth array? Or reuse struct vkd3d_shader_descriptor_binding with a new descriptor type?) I suppose the advantage of such an alternative design would be that it reports "one" descriptor as "one", not "two", but the associated complexity seems far greater, and accordingly I don't really want to give it the time of day. (Note also that this patch set handles combined -> combined mapping without any extra effort). I will of course yield to maintainer preference, though. -- As before, I've prepared proof-of-concept code for Wine. The branches are here: https://gitlab.winehq.org/zfigura/vkd3d/-/commits/himavant5 https://gitlab.winehq.org/zfigura/wine/-/commits/himavant6 The relevant test can be run with: make tests/shader_runner.exe && WINE_D3D_CONFIG=renderer=vulkan wine tests/shader_runner.exe ../vkd3d/tests/hlsl/tex2D.shader_test These branches are rather larger than the previous ones. By way of summary, the vkd3d branch contains these patches, plus about two dozen patches to hook up sm1 tests and to fix various corner cases surrounding semantic translation (much of which should be rewritten with a VSIR-based "lowering" approach in mind). The Wine branch contains: * Wine merge request 4027, * the patches for sm1 constant buffers, * a set of patches to transform individual sampler states into sampler objects (of which [1] is the most interesting), and * a set of patches to transform textures into SRVs (of which [2] is the most interesting). As described above, there is not actually any part of the Wine side that touches the vkd3d-shader interface. [1] https://gitlab.winehq.org/zfigura/wine/-/commit/984e478763c99157a6ec49388fe… [2] https://gitlab.winehq.org/zfigura/wine/-/commit/722c1bf1f6a7691c9ed431bd433… -- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/394

3 6

[PATCH v2 0/3] MR3789: Improve media session handling of unexpected errors.
by Santino Mazza (＠tati1454) 09 Oct '23

09 Oct '23

-- v2: mf: Handle errors with source event generator in session. mf/test: Test error case when session is streaming. https://gitlab.winehq.org/wine/wine/-/merge_requests/3789

4 7

[PATCH 0/1] MR4056: shell32: Fix parsing empty arguments in parse_dde_command().
by Zebediah Figura (＠zfigura) 09 Oct '23

09 Oct '23

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/4056

3 2

Re: [PATCH v4 0/2] MR3718: dwrite: Fix incorrect position of glyph when using BitmapRenderTarget in HiDPI
by Nikolay Sivov (＠nsivov) 09 Oct '23

09 Oct '23

We already have wine_test.sfd, you can add this test glyph there. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3718#note_48044

1 0

Re: [PATCH v4 0/2] MR3718: dwrite: Fix incorrect position of glyph when using BitmapRenderTarget in HiDPI
by Nikolay Sivov (＠nsivov) 09 Oct '23

09 Oct '23

Nikolay Sivov (@nsivov) commented about dlls/dwrite/gdiinterop.c: > return hr; > } > > - scaled_run = *run; > - scaled_run.fontEmSize *= target->ppdip; > - hr = IDWriteFactory7_CreateGlyphRunAnalysis(target->factory, &scaled_run, &target->m, rendermode, measuring_mode, > + scaled_matrix = target->m; > + scaled_matrix.m11 *= target->ppdip; > + scaled_matrix.m22 *= target->ppdip; > + hr = IDWriteFactory7_CreateGlyphRunAnalysis(target->factory, run, &scaled_matrix, rendermode, measuring_mode, > gridfitmode, target->antialiasmode, originX, originY, &analysis); > if (FAILED(hr)) The reason we currently modify font size is to produce better quality output. If you keep original size, then scale 10 times, it won't necessarily be looking good. Regarding matrix modification, how does that work for other components, for e.g. rotation? Maybe we should multiply by diagonal matrix instead? -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3718#note_48043

1 0

[PATCH v2 0/6] MR3810: winegstreamer: Implement add_stream and push_sample for muxer.
by Ziqing Hui (＠zhui) 09 Oct '23

09 Oct '23

-- v2: winegstreamer: Implement wg_muxer_push_sample. winegstreamer: Implement ProcessSample for media sink. winegstreamer: Implement wg_muxer_start. winegstreamer: Implement wg_muxer_add_stream. winegstreamer: Introduce link_src_to_sink. winegstreamer: Use NTSTATUS value in wg_muxer_create. https://gitlab.winehq.org/wine/wine/-/merge_requests/3810

3 19

[PATCH v2 0/3] MR4024: uiautomationcore: COM focus change event handler event advisement support.
by Connor McAdams (＠cmcadams) 09 Oct '23

09 Oct '23

-- v2: uiautomationcore: Use EVENT_OBJECT_FOCUS to advise HWND providers of focus change events in the COM API. uiautomationcore: Query EVENT_OBJECT_FOCUS HWND for a serverside provider if there is a registered focus change event handler. uiautomationcore/tests: Add tests for IUIAutomationFocusChangedEventHandler event advisement behavior. https://gitlab.winehq.org/wine/wine/-/merge_requests/4024

3 8

[PATCH 0/2] MR4055: d3dx9: Support empty mesh.
by Matteo Bruni (＠Mystral) 09 Oct '23

09 Oct '23

None -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4055

3 3

[PATCH v3 0/1] MR4049: ntdll: Implement thread-ID alerts using kqueue()/kevent()
by Marc-Aurel Zent (＠marzent) 09 Oct '23

09 Oct '23

This allows *BSDs to also have a fast path similar to futexes for thread-ID alerts. Also a kevent with `EV_CLEAR` and `NOTE_TRIGGER` maps perfectly to the thread alertable state, fixing the issue of the current mach-semaphore implementation not correctly waiting in the test case below: ``` NtAlertThreadByThreadId((HANDLE)GetCurrentThreadId()); NtAlertThreadByThreadId((HANDLE)GetCurrentThreadId()); NtWaitForAlertByThreadId(NULL, NULL); NtWaitForAlertByThreadId(NULL, NULL); ``` I took the liberty to remove this mach semaphore implementation, since all versions of OSX have supported kqueue(). -- v3: ntdll: Implement thread-ID alerts using kqueue/kevent. https://gitlab.winehq.org/wine/wine/-/merge_requests/4049

2 2

[PATCH v2 0/1] MR3955: mf: Avoid a double free of presentation clock timers.
by Zhiyi Zhang (＠zhiyi) 09 Oct '23

09 Oct '23

In clock_change_state() when a clock is running, a timer is removed from clock->timers. The same timer is then used to create an async result, which will eventually calls present_clock_timer_callback_Invoke() and removes the same timer. -- v2: mf: Avoid a double free of presentation clock timers. https://gitlab.winehq.org/wine/wine/-/merge_requests/3955

3 4

[PATCH 0/2] MR4047: Msxml copytests
by Daniel Lehman (＠dlehman25) 09 Oct '23

09 Oct '23

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/4047

3 3

[PATCH 0/1] MR397: vkd3d: Add partial implementation for CreateHeap1().
by Nikolay Sivov (＠nsivov) 09 Oct '23

09 Oct '23

Signed-off-by: Nikolay Sivov <nsivov(a)codeweavers.com> -- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/397

3 2

[PATCH 0/1] MR395: vkd3d-shader/spirv: When declaring a CBV initialise the register with the register index range.
by Conor McCarthy (＠cmccarthy) 09 Oct '23

09 Oct '23

It makes sense to use the {id}_{range_first} naming scheme for SRVs, UAVs and samplers too because their registers contain the same info, but just fixing this for now. -- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/395

3 2

[PATCH 0/1] MR393: vkd3d-shader/spirv: Add a debug name for the push constant buffer.
by Zebediah Figura (＠zfigura) 09 Oct '23

09 Oct '23

-- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/393

4 3

[PATCH 0/1] MR392: vkd3d-shader/tpf: Get rid of the output map.
by Henri Verbeet (＠hverbeet) 09 Oct '23

09 Oct '23

-- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/392

2 2

[PATCH 0/1] MR391: vkd3d-shader/hlsl: Get rid of the vkd3d_sm4_* forward declarations in hlsl.h.
by Henri Verbeet (＠hverbeet) 09 Oct '23

09 Oct '23

-- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/391

3 3

[PATCH 0/19] MR388: Draft: vkd3d-shader/dxil: Complete the signature reads and read some shader properties.
by Conor McCarthy (＠cmccarthy) 09 Oct '23

09 Oct '23

Goes atop MRs 346 and 372. The last five commits are of this MR. -- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/388

4 24

[PATCH v4 0/2] MR3806: combase: Create implicit MTA in STA apartment in RoGetActivationFactory().
by Paul Gofman (＠gofman) 09 Oct '23

09 Oct '23

Fixes Starfield not being able to take photos in photo mode (due to failing to creating windowscodecs' image factory due to COM apartment being initialized). Turns out on Windows RoGetActivationFactory() initializes implicit MTA apartment when called from STA thread, and so after that called once COM is implicitly uninitialized for any (new) thread until COM is uninitialized in the thread which called RoGetActivationFactory (or that thread exited). This is not the case on Win8 (where the function was first introduced) but looks consistent after that. -- v4: combase: Ensure MTA existence in RoGetActivationFactory(). combase/tests: Add tests for implicit MTA with RoGetActivationFactory(). https://gitlab.winehq.org/wine/wine/-/merge_requests/3806

3 4

[PATCH 0/2] MR4048: Fix reading debuggee environment.
by eric pouech (＠epo) 09 Oct '23

09 Oct '23

Since a81c53504ae32715e6e91bd020fdebd5bef20d48, reading the debuggee environment could fail. Depending on context, it could end up with no longer being able to find ELF/Mach-O modules (as some codepaths get the path to Wine's loader from debuggee environment). Code was aligning read on allocation granularity, but this can fail when not all the pages within that range are committed. So align on page instead. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4048

2 3

[PATCH v3 0/6] MR3996: dmsynth: Import and begin using FluidSynth.
by Rémi Bernon (＠rbernon) 09 Oct '23

09 Oct '23

-- v3: dmsynth: Create and register a fluid_sfont instance. dmsynth: Create a fluid_synth instance on Open. dmsynth: Simplify IDirectMusicSynth8_Open checks. fluidsynth: Use Wine debugging facility for traces. dmsynth: Import and use FluidSynth 2.3.3. dmime/tests: Queue the message before calling SendPMsg twice. https://gitlab.winehq.org/wine/wine/-/merge_requests/3996

5 10

[PATCH 0/1] MR3416: ieframe: Forward WM_PAINT messages to the document host and all its child windows.
by Torge Matthies (＠tmatthies) 09 Oct '23

09 Oct '23

Windows gives this content special protection from being painted over, by some means that I have not investigated yet. Emulate this protection for the trivial case of an InvalidateRect(...); call on the parent window. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3416

4 9

[PATCH 0/2] MR4050: Fix missing linefeeds in dmsynth and winewayland.drv
by Francois Gouget (＠fgouget) 09 Oct '23

09 Oct '23

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/4050

2 2

[PATCH 0/1] MR4049: ntdll: Implement thread-ID alerts using kqueue()/kevent()
by Marc-Aurel Zent (＠marzent) 09 Oct '23

09 Oct '23

This allows *BSDs to also have a fast path similar to futexes for thread-ID alerts. Also a kevent with `EV_CLEAR` and `NOTE_TRIGGER` maps perfectly to the thread alertable state, fixing the issue of the current mach-semaphore implementation not correctly waiting in the test case below: ``` NtAlertThreadByThreadId((HANDLE)GetCurrentThreadId()); NtAlertThreadByThreadId((HANDLE)GetCurrentThreadId()); NtWaitForAlertByThreadId(NULL, NULL); NtWaitForAlertByThreadId(NULL, NULL); ``` I took the liberty to remove this mach semaphore implementation, since all versions of OSX have supported kqueue(). -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4049

2 1

[PATCH v2 0/3] MR4026: Add ResetPrinter support and use it in ResetDC.
by Piotr Caban (＠piotr) 09 Oct '23

09 Oct '23

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=55718 -- v2: gdi32: Update printer DEVMODE in ResetDCW. winspool.drv: Add ResetPrinterW implementation. localspl: Add ResetPrinter implementation. https://gitlab.winehq.org/wine/wine/-/merge_requests/4026

3 4

[PATCH v2 0/5] MR4041: gdi32: A few fixes for EMF recording
by Nikolay Sivov (＠nsivov) 09 Oct '23

09 Oct '23

-- v2: winedump/emf: Add EMR_SETMITERLIMIT record dumping. https://gitlab.winehq.org/wine/wine/-/merge_requests/4041

3 6

Re: [PATCH v10 0/1] MR3777: gdi32: Add stub for D3DKMTQueryAdapterInfo. - approved
by Huw Davies (＠huw) 09 Oct '23

09 Oct '23

This merge request was approved by Huw Davies. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3777

1 0

[PATCH v2 0/2] MR3915: ddraw/tests: Test WS_EX_TOPMOST restoration.
by Zhiyi Zhang (＠zhiyi) 09 Oct '23

09 Oct '23

Test that there is a ~1.5s timer after entering fullscreen mode and restores WS_EX_TOPMOST if it's missing when the timer times out. -- v2: ddraw: Restore WS_EX_TOPMOST in exclusive fullscreen mode if it got removed. ddraw/tests: Test WS_EX_TOPMOST restoration. https://gitlab.winehq.org/wine/wine/-/merge_requests/3915

3 3

[PATCH v15 0/2] MR3959: uxtheme: Add ShouldSystemUseDarkMode.
by Helix Graziani (＠TornadoCookie) 09 Oct '23

09 Oct '23

Used in some .NET apps for theming purposes. -- v15: winecfg: Change system theme alongside app theme. uxtheme: Add ShouldSystemUseDarkMode. https://gitlab.winehq.org/wine/wine/-/merge_requests/3959

4 4

[PATCH v6 0/3] MR361: vkd3d-shader/hlsl: Initial support for 'switch' statement.
by Nikolay Sivov (＠nsivov) 08 Oct '23

08 Oct '23

Signed-off-by: Nikolay Sivov <nsivov(a)codeweavers.com> -- v6: vkd3d-shader/tpf: Write out 'switch' statements. vkd3d-shader/hlsl: Initial support for 'switch' statement. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/361

2 4

[PATCH 0/1] MR4045: kernelbase: Rewrite ExpandEnvironmentStringsA to return ansi string size
by Fabian Maurer (＠DarkShadow44) 08 Oct '23

08 Oct '23

We can't return the unicode string size, this returns sizes to small for multi-byte characters. Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=54295 -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4045

3 2

[PATCH v2 0/1] MR4044: propsys: Implement PropVariantToUInt32WithDefault
by Fabian Maurer (＠DarkShadow44) 08 Oct '23

08 Oct '23

-- v2: propsys: Implement PropVariantToUInt32WithDefault https://gitlab.winehq.org/wine/wine/-/merge_requests/4044

2 1

[PATCH v65 0/6] MR2786: Add support for AF_UNIX sockets
by Ally Sommers (＠dropbear) 08 Oct '23

08 Oct '23

Windows 10 [received support](https://devblogs.microsoft.com/commandline/af_unix-comes-to-window… for AF_UNIX sockets in Insider Build 17063. This merge request adds basic support for AF_UNIX sockets to ws2_32 and wineserver. Of particular note is the difficulty in handling `sun_path`. Most of the functions that allow for translating Windows paths to Unix paths are not accessible from ws2_32. I considered the following options: * Pass the Windows path to wineserver and do the conversion there. * This is, as far as I can tell, not possible without major rearchitecting. wineserver does not have functions to translate Windows paths to Unix paths, for obvious reasons. * Obtain the current working directory of the requesting process and temporarily change directories to there. * This only handles relative paths and fails for absolute paths, UNC paths, etc. * Conditionally change directories based on whether the path is relative or not. * This is error-prone and wineserver does not have the requisite functions to do this cleanly. I ultimately decided to pass the translated Unix path to wineserver, which changes directories to `dirname(path)`. It then provides `bind` and `connect` with `basename(path)`. This is not threadsafe, but wineserver is not (currently) multithreaded. Abstract sockets are not fully supported by this patch, matching the behavior of Windows. -- v65: ws2_32/tests: Add test for AF_UNIX sockets. server: Fix getsockname() and accept() on AF_UNIX sockets. server: Introduce error when attempting to create a SOCK_DGRAM AF_UNIX socket. server: Allow for deletion of socket files. ws2_32: Add support for AF_UNIX sockets. ws2_32: Add afunix.h header. https://gitlab.winehq.org/wine/wine/-/merge_requests/2786

3 7

[PATCH v2 0/1] MR3970: quartz/tests: Improve VMR9 ChangeD3DDevice test
by Alfred Agrell (＠Alcaro) 08 Oct '23

08 Oct '23

- Make it present some frames - Make it check that the frames are from the new device, instead of checking TerminateDevice count; fixes https://bugs.winehq.org/show_bug.cgi?id=55649 - ~~Make it check for and avoid some absurd crash on Windows~~ ~~I tried everything I could think of, but Windows absolutely refuses to present a frame after changing the D3D device, instead choosing to return various absurd errors (segfaults, deadlocks, out of memory, etc). I suspect the VMR9 is haunted.~~ edit: Works on Windows now -- v2: quartz/tests: Improve VMR9 ChangeD3DDevice test. https://gitlab.winehq.org/wine/wine/-/merge_requests/3970

2 2

[PATCH 0/6] MR4042: windows.security.credentials.ui.userconsentverifier: Implement IUserConsentVerifierStatics::CheckAvailabilityAsync().
by Mohamad Al-Jaf (＠maljaf) 08 Oct '23

08 Oct '23

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=55709 There appears to be a race condition happening. When it doesn't work, it looks like the apartment is not initialized, output: ``` 01e8:fixme:combase:RoGetActivationFactory (L"Windows.Security.Credentials.UI.UserConsentVerifier", {af4f3f91-564c-4ddc-b8b5-973447627c65}, 000000000011E890): semi-stub 01e8:fixme:credentials:factory_QueryInterface {94ea2b94-e9cc-49e0-c0ff-ee64ca8f5b90} not implemented, returning E_NOINTERFACE. 0220:err:ole:CoGetContextToken apartment not initialised 0220:fixme:ole:thread_context_callback_ContextCallback 000000000347E4A8, 00007FFFFE10D510, 0000000005C7FBA0, {0a299774-3e4e-fc42-1d9d-72cee105ca57}, 5, 0000000000000000 0220:fixme:combase:RoOriginateLanguageException 0x80004001, L"", 0000000000000000: stub wine: Call from 0000000174013C17 to unimplemented function combase.dll.RoFailFastWithErrorContext, aborting wine: Unimplemented function combase.dll.RoFailFastWithErrorContext called at address 0000000174013C17 (thread 0220), starting debugger. ``` Adding in WINEDEBUG=+credentials makes it consistently work: ``` 0154:fixme:combase:RoGetActivationFactory (L"Windows.Security.Credentials.UI.UserConsentVerifier", {af4f3f91-564c-4ddc-b8b5-973447627c65}, 000000000011E890): semi-stub 0154:trace:credentials:DllGetActivationFactory class L"Windows.Security.Credentials.UI.UserConsentVerifier", factory 000000000011E6C0. 0154:trace:credentials:factory_QueryInterface iface 00000001F3B04040, iid {00000035-0000-0000-c000-000000000046}, out 000000000011E6C0. 0154:trace:credentials:factory_AddRef iface 00000001F3B04040 increasing refcount to 2. 0154:trace:credentials:factory_QueryInterface iface 00000001F3B04040, iid {af4f3f91-564c-4ddc-b8b5-973447627c65}, out 000000000011E890. 0154:trace:credentials:factory_AddRef iface 00000001F3B04040 increasing refcount to 3. 0154:trace:credentials:factory_Release iface 00000001F3B04040 decreasing refcount to 2. 0154:trace:credentials:factory_QueryInterface iface 00000001F3B04040, iid {94ea2b94-e9cc-49e0-c0ff-ee64ca8f5b90}, out 000000000011E898. 0154:fixme:credentials:factory_QueryInterface {94ea2b94-e9cc-49e0-c0ff-ee64ca8f5b90} not implemented, returning E_NOINTERFACE. 0154:trace:credentials:user_consent_verifier_statics_CheckAvailabilityAsync iface 00000001F3B04048, result 000000000011E868 0154:trace:credentials:factory_AddRef iface 00000001F3B04040 increasing refcount to 3. 0154:trace:credentials:async_impl_Start iface 0000000000791260. 0154:trace:credentials:async_UserConsentVerifierAvailability_AddRef iface 0000000003461650, ref 2. 0154:trace:credentials:async_operation_UserConsentVerifierAvailability_create created IAsyncOperation_UserConsentVerifierAvailability 0000000003461650 0154:trace:credentials:factory_Release iface 00000001F3B04040 decreasing refcount to 2. 0154:trace:credentials:async_UserConsentVerifierAvailability_AddRef iface 0000000003461650, ref 3. 0154:trace:credentials:async_UserConsentVerifierAvailability_put_Completed iface 0000000003461650, handler 00000000033E2410. 0154:trace:credentials:async_impl_put_Completed iface 0000000000791260, handler 00000000033E2410. 0154:trace:credentials:async_UserConsentVerifierAvailability_GetResults iface 0000000003461650, results 000000000011E790. 0154:trace:credentials:async_impl_get_Result iface 0000000000791260, result 000000000011E700. 018c:trace:credentials:async_UserConsentVerifierAvailability_Release iface 0000000003461650, ref 2. 0154:trace:credentials:async_UserConsentVerifierAvailability_Release iface 0000000003461650, ref 1. 0154:trace:credentials:async_UserConsentVerifierAvailability_Release iface 0000000003461650, ref 0. 0154:trace:credentials:async_impl_Release iface 0000000000791260, ref 0. 0154:trace:credentials:async_info_Close iface 0000000000791268. 0154:trace:credentials:factory_Release iface 00000001F3B04040 decreasing refcount to 1. ``` -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4042

2 6

[PATCH v14 0/2] MR3959: uxtheme: Add ShouldSystemUseDarkMode.
by Helix Graziani (＠TornadoCookie) 07 Oct '23

07 Oct '23

Used in some .NET apps for theming purposes. -- v14: winecfg: Change system theme alongside app theme. uxtheme: Add ShouldSystemUseDarkMode. https://gitlab.winehq.org/wine/wine/-/merge_requests/3959

4 4

[PATCH v5 0/3] MR361: vkd3d-shader/hlsl: Initial support for 'switch' statement.
by Nikolay Sivov (＠nsivov) 07 Oct '23

07 Oct '23

Signed-off-by: Nikolay Sivov <nsivov(a)codeweavers.com> -- v5: vkd3d-shader/tpf: Write out 'switch' statements. vkd3d-shader/hlsl: Initial support for 'switch' statement. vkd3d-shader/hlsl: Parse 'break' statement. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/361

2 3

[PATCH v4 0/2] MR361: vkd3d-shader/hlsl: Initial support for 'switch' statement.
by Nikolay Sivov (＠nsivov) 07 Oct '23

07 Oct '23

Signed-off-by: Nikolay Sivov <nsivov(a)codeweavers.com> -- v4: vkd3d-shader/hlsl: Initial support for 'switch' statement. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/361

2 2

[PATCH v3 0/2] MR361: vkd3d-shader/hlsl: Initial support for 'switch' statement.
by Nikolay Sivov (＠nsivov) 07 Oct '23

07 Oct '23

Signed-off-by: Nikolay Sivov <nsivov(a)codeweavers.com> -- v3: vkd3d-shader/hlsl: Initial support for 'switch' statement. vkd3d-shader/hlsl: Parse 'break' statement. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/361

2 2

[PATCH 0/5] MR4041: gdi32: A few fixes for EMF recording
by Nikolay Sivov (＠nsivov) 07 Oct '23

07 Oct '23

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/4041

2 5

Re: [PATCH v2 0/7] MR4036: dmime: Implement segment state and tracks InitPlay / Play / EndPlay. - approved
by Michael Stefaniuc (＠mstefani) 07 Oct '23

07 Oct '23

This merge request was approved by Michael Stefaniuc. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4036

1 0

Re: [PATCH v2 0/7] MR4036: dmime: Implement segment state and tracks InitPlay / Play / EndPlay.
by Michael Stefaniuc (＠mstefani) 07 Oct '23

07 Oct '23

On Sat Oct 7 15:18:48 2023 +0000, Rémi Bernon wrote: > Oof oof, I was sure I tried every change but then probably changed more > things last minute. Thanks for catching it. Looks good now. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4036#note_47938

1 0

[PATCH 0/1] MR4040: advapi32/tests: Add ReadEventLogA tests for EventlogStarted.
by Daniel Lehman (＠dlehman25) 07 Oct '23

07 Oct '23

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/4040

2 1

[PATCH 0/1] MR4039: imagehlp: Import functions instead of forwarding.
by Paul Gofman (＠gofman) 07 Oct '23

07 Oct '23

I manually tested on Win10 that GetProcAddress() for both ntdll and dbghelp functions end up in imagehlp.dll module. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4039

2 1

[PATCH 0/7] MR4036: dmime: Implement segment state and tracks InitPlay / Play / EndPlay.
by Rémi Bernon (＠rbernon) 06 Oct '23

06 Oct '23

The last change adds a todo_wine for the time offset check, because we don't implement it. It wasn't necessary before becase InitPlay wasn't called yet. It also adds a todo_wine for the playing state, because we don't implement start_time yet, and the segment start should be delayed instead of starting right away. Same, it wasn't necessary before because we were not calling Play. We use notification messages to carry segment state and extend its lifetime for the entire play time, even though notifications might not be actually enabled. When notifications aren't enabled, we don't stamp the messages, so they are directly delivered to the performance output tool, and we then won't queue them to the notification message list. I don't think it matters very much, though we could alternatively use some internal message types instead. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4036

3 9

[PATCH 0/1] MR3970: quartz/tests: Improve VMR9 ChangeD3DDevice test
by Alfred Agrell (＠Alcaro) 06 Oct '23

06 Oct '23

- Make it present some frames - Make it check that the frames are from the new device, instead of checking TerminateDevice count; fixes https://bugs.winehq.org/show_bug.cgi?id=55649 - Make it check for and avoid some absurd crash on Windows I tried everything I could think of, but Windows absolutely refuses to present a frame after changing the D3D device, instead choosing to return various absurd errors (segfaults, deadlocks, out of memory, etc). I suspect the VMR9 is haunted. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3970

3 7

[PATCH 0/1] MR4034: d3d10/tests: Add a test for log2/log10/exp2 functions in expressions.
by Nikolay Sivov (＠nsivov) 06 Oct '23

06 Oct '23

Signed-off-by: Nikolay Sivov <nsivov(a)codeweavers.com> -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4034

3 3

[PATCH 0/1] MR4031: d3dx9: D3DXLoadMeshHierarchyFromXInMemory support empty mesh.
by Alistair Leslie-Hughes (＠alesliehughes) 06 Oct '23

06 Oct '23

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/4031

3 6

Re: [PATCH v5 0/8] MR3994: include: Introduce wine_dbgstr_fourcc and debugstr_fourcc. - approved
by Alexandre Julliard (＠julliard) 06 Oct '23

06 Oct '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3994

1 0

Re: [PATCH v2 0/1] MR4037: winevulkan: Update to VK spec version 1.3.267. - approved
by Alexandre Julliard (＠julliard) 06 Oct '23

06 Oct '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4037

1 0

Re: [PATCH v2 0/6] MR4027: wined3d: Store a fragment_caps structure in struct wined3d_d3d_info. - approved
by Alexandre Julliard (＠julliard) 06 Oct '23

06 Oct '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4027

1 0

Re: [PATCH v3 0/1] MR4025: user32: Add more builtin string resources. - approved
by Alexandre Julliard (＠julliard) 06 Oct '23

06 Oct '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4025

1 0

Re: [PATCH v2 0/1] MR4033: ntdll/test: Fix FILE_RENAME_INFORMATION_EX test failures on Windows 10 1607 & 1709. - approved
by Alexandre Julliard (＠julliard) 06 Oct '23

06 Oct '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4033

1 0

Re: [PATCH v3 0/8] MR4016: ieframe: Implement error page on navigation error. - approved
by Alexandre Julliard (＠julliard) 06 Oct '23

06 Oct '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4016

1 0

Re: [PATCH v11 0/1] MR3784: nsiproxy.sys: Implement ipv6_forward_enumerate_all. - approved
by Alexandre Julliard (＠julliard) 06 Oct '23

06 Oct '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3784

1 0

Re: [PATCH v2 0/5] MR4028: objsel: Various cleanups. - approved
by Alexandre Julliard (＠julliard) 06 Oct '23

06 Oct '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4028

1 0

2025

2024

2023

2022

wine-gitlab