- wine-gitlab - winehq.org

Re: [PATCH v4 0/4] MR4005: uiautomationcore: COM event handler event advisement support. - approved
by Alexandre Julliard (＠julliard) 04 Oct '23

04 Oct '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4005

1 0

Re: [PATCH v4 0/1] MR4008: secur32: Fix schannel handles. - approved
by Alexandre Julliard (＠julliard) 04 Oct '23

04 Oct '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4008

1 0

Re: [PATCH v3 0/8] MR4007: d3d10/effect: Add support for 'imul' instruction. - approved
by Alexandre Julliard (＠julliard) 04 Oct '23

04 Oct '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4007

1 0

Re: [PATCH v2 0/1] MR4012: propsys: Handle VT_I4 type in VariantToString(). - approved
by Alexandre Julliard (＠julliard) 04 Oct '23

04 Oct '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4012

1 0

Re: [PATCH v2 0/1] MR4013: configure: Fix restoring CFLAGS after the test for -Wl,-z,defs. - approved
by Alexandre Julliard (＠julliard) 04 Oct '23

04 Oct '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4013

1 0

Re: [PATCH v2 0/1] MR4011: wpcap: get_broadcast return NULL on error - approved
by Alexandre Julliard (＠julliard) 04 Oct '23

04 Oct '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4011

1 0

Re: [PATCH v4 0/5] MR3995: dmime: Preparatory cleanup of segment state. - approved
by Alexandre Julliard (＠julliard) 04 Oct '23

04 Oct '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3995

1 0

Re: [PATCH v2 0/1] MR3979: wined3d: Reference the push constant buffers. - approved
by Alexandre Julliard (＠julliard) 04 Oct '23

04 Oct '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3979

1 0

[PATCH 0/2] MR3999: Msdasql header
by Alistair Leslie-Hughes (＠alesliehughes) 04 Oct '23

04 Oct '23

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/3999

3 3

[PATCH v4 0/1] MR246: Allow renaming a file/directory to a different case of itself
by Gabriel Ivăncescu (＠insn) 04 Oct '23

04 Oct '23

-- v4: ntdll: Allow renaming a file/directory to a different case of itself. https://gitlab.winehq.org/wine/wine/-/merge_requests/246

2 1

[PATCH v3 0/4] MR4005: uiautomationcore: COM event handler event advisement support.
by Connor McAdams (＠cmcadams) 04 Oct '23

04 Oct '23

-- v3: uiautomationcore: Use EVENT_OBJECT_SHOW to advise providers of events being listened for in the COM API. uiautomationcore: Separate checking if a node is within the scope of a registered event from event invocation. uiautomationcore: Add support for passing WinEvents to the COM API. uiautomationcore/tests: Add tests for COM event handler event advisement. https://gitlab.winehq.org/wine/wine/-/merge_requests/4005

4 9

[PATCH v2 0/8] MR4007: d3d10/effect: Add support for 'imul' instruction.
by Nikolay Sivov (＠nsivov) 04 Oct '23

04 Oct '23

Signed-off-by: Nikolay Sivov <nsivov(a)codeweavers.com> -- v2: d3d10/effect: Add support for 'or' instruction. d3d10/effect: Add support for 'not' instruction. d3d10/effect: Add support for 'exp' instruction. d3d10/effect: Add support for 'log' instruction. https://gitlab.winehq.org/wine/wine/-/merge_requests/4007

2 9

[PATCH v7 0/14] MR372: vkd3d-shader/dxil: Read metadata and signatures.
by Conor McCarthy (＠cmccarthy) 04 Oct '23

04 Oct '23

-- v7: vkd3d-shader/dxil: Read the DXIL input and output signatures. vkd3d-shader/dxil: Validate the entry point info. vkd3d-shader/dxil: Read DXIL metadata named nodes. vkd3d-shader/dxil: Read DXIL metadata kinds. vkd3d-shader/dxil: Read DXIL metadata values. vkd3d-shader/dxil: Read DXIL metadata nodes. vkd3d-shader/dxil: Read DXIL metadata strings. vkd3d-shader/dxil: Emit an error on allocation failure in dxil_record_to_string(). vkd3d-shader/dxil: Read global constants in sm6_parser_globals_init(). vkd3d-shader/dxil: Read immediate constant arrays. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/372

3 18

[PATCH v3 0/1] MR4008: secur32: Fix schannel handles.
by Paul Gofman (＠gofman) 04 Oct '23

04 Oct '23

Access to handle table is actually concurrent (and races / corrupts memory / crashes in practice when apps use different security contexts from different threads). Then, unrelated to races, schan_handle_table can be reallocated and then schan_free_handles chain points to old memory location. Alternatively to patch 2, that could be fixed up on reallocating schan_handle_table, but it seems to me we can as well just scan the handle table for free slots. -- v3: https://gitlab.winehq.org/wine/wine/-/merge_requests/4008

2 2

[PATCH 0/8] MR4007: d3d10/effect: Add support for 'imul' instruction.
by Nikolay Sivov (＠nsivov) 04 Oct '23

04 Oct '23

Signed-off-by: Nikolay Sivov <nsivov(a)codeweavers.com> -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4007

4 13

[PATCH 0/1] MR4013: configure: Fix restoring CFLAGS after the test for -Wl,-z,defs.
by Martin Storsjö (＠mstorsjo) 04 Oct '23

04 Oct '23

This fixes a regression from 450c358881dbc6dcfb2692b8f4debb7db8fdc54b; after testing for -Wl,-z,defs, CFLAGS was restored from an incorrect variable, leaving CFLAGS essentially empty. This would break builds for e.g. arm with Clang, where -mthumb would be essential for being able to build some inline assembly snippets correctly. This also had the effect of dropping the default "-g -O2" arguments from CFLAGS. Signed-off-by: Martin Storsjö <martin(a)martin.st> -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4013

3 4

[PATCH 0/1] MR4012: propsys: Handle VT_I4 type in VariantToString().
by Nikolay Sivov (＠nsivov) 04 Oct '23

04 Oct '23

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=55708 Signed-off-by: Nikolay Sivov <nsivov(a)codeweavers.com> -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4012

2 1

[PATCH v6 0/14] MR372: vkd3d-shader/dxil: Read metadata and signatures.
by Conor McCarthy (＠cmccarthy) 04 Oct '23

04 Oct '23

-- v6: vkd3d-shader/dxil: Read the DXIL input and output signatures. vkd3d-shader/dxil: Validate the entry point info. vkd3d-shader/dxil: Read DXIL metadata named nodes. vkd3d-shader/dxil: Read DXIL metadata kinds. vkd3d-shader/dxil: Read DXIL metadata values. vkd3d-shader/dxil: Read DXIL metadata nodes. vkd3d-shader/dxil: Read DXIL metadata strings. vkd3d-shader/dxil: Emit an error on allocation failure in dxil_record_to_string(). vkd3d-shader/dxil: Read global constants in sm6_parser_globals_init(). vkd3d-shader/dxil: Read immediate constant arrays. tests/shader-runner: Test shaders with dxcompiler. tests/shader-runner: Replace immediate shader type strings with an enum. tests/shader-runner: Do not exit if a 'require' directive is not met. tests/shader-runner: Handle individual keywords in shader directives. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/372

3 22

[PATCH v2 0/2] MR4008: secur32: Fix schannel handles.
by Paul Gofman (＠gofman) 04 Oct '23

04 Oct '23

Access to handle table is actually concurrent (and races / corrupts memory / crashes in practice when apps use different security contexts from different threads). Then, unrelated to races, schan_handle_table can be reallocated and then schan_free_handles chain points to old memory location. Alternatively to patch 2, that could be fixed up on reallocating schan_handle_table, but it seems to me we can as well just scan the handle table for free slots. -- v2: secur32: Get rid of schannel free handle list. https://gitlab.winehq.org/wine/wine/-/merge_requests/4008

4 4

[PATCH 0/1] MR4011: wpcap: get_broadcast return NULL on error
by Alistair Leslie-Hughes (＠alesliehughes) 04 Oct '23

04 Oct '23

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/4011

4 3

[PATCH 0/2] MR4010: msado15: _Recordset::AddNew - Move to newly created row.
by Alistair Leslie-Hughes (＠alesliehughes) 04 Oct '23

04 Oct '23

Its valid to have a recordset with existing rowss. Addnew needs to move to newly created row, so existing wont be used. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4010

2 2

[PATCH 0/1] MR4009: advapi32/tests: Add ReadEventLogW tests for EventLogStarted.
by Daniel Lehman (＠dlehman25) 04 Oct '23

04 Oct '23

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/4009

2 1

[PATCH 0/3] MR364: vkd3d-shader/hlsl: Implement inverse trigonometry.
by Petrichor Park (＠petrathekat) 03 Oct '23

03 Oct '23

Implements asin, acos, atan, and atan2. Also includes some tests in a new test file. One possible problem here is that I'm not sure how to test what Microsoft's atan and atan2 outputs are in boundary cases like atan2(1, 0). I've made the test suites adhere with the calculator program I've been using (Qalculate, which I assume is using libc's atan2). Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=55154 -- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/364

6 14

[PATCH 0/2] MR4008: secur32: Fix schannel handles.
by Paul Gofman (＠gofman) 03 Oct '23

03 Oct '23

Access to handle table is actually concurrent (and races / corrupts memory / crashes in practice when apps use different security contexts from different threads). Then, unrelated to races, schan_handle_table can be reallocated and then schan_free_handles chain points to old memory location. Alternatively to patch 2, that could be fixed up on reallocating schan_handle_table, but it seems to me we can as well just scan the handle table for free slots. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4008

2 2

Re: [PATCH v3 0/5] MR3995: dmime: Preparatory cleanup of segment state. - approved
by Michael Stefaniuc (＠mstefani) 03 Oct '23

03 Oct '23

This merge request was approved by Michael Stefaniuc. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3995

1 0

[PATCH 0/1] MR3979: wined3d: Reference the push constant buffers.
by Stefan Dösinger (＠stefan) 03 Oct '23

03 Oct '23

--- I came across this in my attempts to implement nooverwrite maps based on sysmem staging buffers when buffer storage is not available. My debug modifications broke the fast path for update_sub_resource and the wined3d_resource_wait() didn't do its job for the push constant buffers. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3979

4 5

Re: [PATCH v2 0/1] MR3899: http: Use the strdup function instead of reimplementing it. - approved
by Alexandre Julliard (＠julliard) 03 Oct '23

03 Oct '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3899

1 0

Re: [PATCH v2 0/1] MR4006: propsys: Partially implement VariantToString(). - approved
by Alexandre Julliard (＠julliard) 03 Oct '23

03 Oct '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4006

1 0

Re: [PATCH v3 0/1] MR4004: msxml3: IXMLDOMElement::selectSingleNode always assign a value to the output parameter - approved
by Alexandre Julliard (＠julliard) 03 Oct '23

03 Oct '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4004

1 0

Re: [PATCH v3 0/2] MR3992: ntdll: Initial implementation of File{Rename,Link}InformationEx - approved
by Alexandre Julliard (＠julliard) 03 Oct '23

03 Oct '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3992

1 0

Re: [PATCH v5 0/5] MR3987: d3d10/effect: Add support for 'buge'/'bult' instructions. - approved
by Alexandre Julliard (＠julliard) 03 Oct '23

03 Oct '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3987

1 0

Re: [PATCH v2 0/3] MR4003: mshtml: mshtml: Call handle_event on the proper dispex object & misc. - approved
by Alexandre Julliard (＠julliard) 03 Oct '23

03 Oct '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4003

1 0

Re: [PATCH v3 0/3] MR382: vkd3d-shader/tpf: Replace sm4 register structs with vkd3d-shader register structs, part 4. - approved
by Alexandre Julliard (＠julliard) 03 Oct '23

03 Oct '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/382

1 0

Re: [PATCH v2 0/1] MR386: vkd3d: Add ID3D12GraphicsCommandList4 interface stub. - approved
by Alexandre Julliard (＠julliard) 03 Oct '23

03 Oct '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/386

1 0

[PATCH v2 0/4] MR4005: uiautomationcore: COM event handler event advisement support.
by Connor McAdams (＠cmcadams) 03 Oct '23

03 Oct '23

-- v2: uiautomationcore: Use EVENT_OBJECT_SHOW to advise providers of events being listened for in the COM API. uiautomationcore: Separate checking if a node is within the scope of a registered event from event invocation. uiautomationcore: Add support for passing WinEvents to a custom callback function. uiautomationcore/tests: Add tests for COM event handler event advisement. https://gitlab.winehq.org/wine/wine/-/merge_requests/4005

3 7

Re: [PATCH 0/1] MR3899: http: Use the strdup function instead of reimplementing it. - approved
by Zebediah Figura (＠zfigura) 03 Oct '23

03 Oct '23

This merge request was approved by Zebediah Figura. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3899

1 0

[PATCH 0/1] MR4006: propsys: Partially implement VariantToString().
by Nikolay Sivov (＠nsivov) 03 Oct '23

03 Oct '23

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=55708 Signed-off-by: Nikolay Sivov <nsivov(a)codeweavers.com> -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4006

2 1

Re: [PATCH v36 0/6] MR3870: mspatcha: Add support for 32-bit file patching and normalization
by Zebediah Figura (＠zfigura) 03 Oct '23

03 Oct '23

> Oh! Okay, I will use `RtlImageNtHeader` and then do the bounds checks afterwards :) I suppose it's a matter of taste, but personally I don't find this an improvement... -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3870#note_47491

1 0

Re: [PATCH v2 0/1] MR4004: msxml3: IXMLDOMElement::selectSingleNode always assign a value to the output parameter - approved
by Nikolay Sivov (＠nsivov) 03 Oct '23

03 Oct '23

This merge request was approved by Nikolay Sivov. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4004

1 0

[PATCH v2 0/6] MR3994: include: Introduce wine_dbgstr_fourcc and debugstr_fourcc.
by Alex Henrie (＠alexhenrie) 03 Oct '23

03 Oct '23

-- v2: msvfw32: Use the debugstr_fourcc function instead of reimplementing it. mscms: Use the debugstr_fourcc function instead of reimplementing it. mciavi32: Use the debugstr_fourcc function instead of reimplementing it. ddraw: Use the debugstr_fourcc function instead of reimplementing it. comctl32: Use the debugstr_fourcc function instead of reimplementing it. include: Introduce wine_dbgstr_fourcc and debugstr_fourcc. https://gitlab.winehq.org/wine/wine/-/merge_requests/3994

3 8

[PATCH v2 0/2] MR3992: ntdll: Initial implementation of File{Rename,Link}InformationEx
by Joel Holdsworth (＠jhol) 03 Oct '23

03 Oct '23

-- v2: ntdll: Initial implementation of FileLinkInformationEx. ntdll: Initial implementation of FileRenameInformationEx. https://gitlab.winehq.org/wine/wine/-/merge_requests/3992

2 3

[PATCH v2 0/3] MR382: vkd3d-shader/tpf: Replace sm4 register structs with vkd3d-shader register structs, part 4.
by Francisco Casas (＠fcasas) 03 Oct '23

03 Oct '23

-- v2: vkd3d-shader/tpf: Replace sm4_src_register with vkd3d_shader_src_param. vkd3d-shader/tpf: Remove sm4_src_register.swizzle_type. vkd3d-shader/tpf: Make sm4_src_register.mod a vkd3d_shader_src_modifier enum. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/382

3 7

[PATCH 0/2] MR3992: ntdll: Initial implementation of File{Rename,Link}InformationEx
by Joel Holdsworth (＠jhol) 03 Oct '23

03 Oct '23

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/3992

4 5

[PATCH 0/1] MR386: vkd3d: Add ID3D12GraphicsCommandList4 interface stub.
by Andrey Gusev (＠agusev) 03 Oct '23

03 Oct '23

-- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/386

3 2

[PATCH v3 0/1] MR385: vkd3d-shader: Fix compiler warning.
by Alistair Leslie-Hughes (＠alesliehughes) 03 Oct '23

03 Oct '23

vkd3d-shader/tpf.c:3810:39: warning: passing argument 2 of ‘sm4_register_from_node’ from incompatible pointer type [-Wincompatible-pointer-types] vkd3d-shader/tpf.c:4750:59: warning: passing argument 3 of ‘sm4_register_from_deref’ from incompatible pointer type [-Wincompatible-pointer-types] The other option is to change the parameter to a DWORD but this is a larger change. -- v3: vkd3d-shader: Fix compiler warning. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/385

4 3

[PATCH v19 0/4] MR346: tests/shader-runner: Test DXIL shaders.
by Conor McCarthy (＠cmccarthy) 03 Oct '23

03 Oct '23

This goes on top of MR 345. -- v19: tests/shader-runner: Test shaders with dxcompiler. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/346

4 9

[PATCH 0/4] MR4005: uiautomationcore: COM event handler event advisement support.
by Connor McAdams (＠cmcadams) 03 Oct '23

03 Oct '23

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/4005

3 5

Re: [PATCH v7 0/7] MR3938: winegstreamer: Implement CLSID_CMpegVideoCodec
by Rémi Bernon (＠rbernon) 03 Oct '23

03 Oct '23

On Tue Sep 26 23:38:34 2023 +0000, Alfred Agrell wrote: > I don't know how many emails/etc gitlab sends, so I'm not sure if you > saw it, but I implemented the entire thing; I think it's correct, but > there's a fixme for the lack of tests (adding that is too far out of > scope to belong in this MR). > I could remove it if you don't want untested code floating around; now > that I know what exactly it's trying to do, and what it's actually > doing, it's not hard to work around it in the test instead. I don't know whether this is correct or not, I think it'd be better to leave this aspect aside for now as like you said this is going a bit out of the scope of this MR. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3938#note_47467

1 0

[PATCH 0/1] MR4004: msxml3: IXMLDOMElement::selectSingleNode always assign a value to the output parameter
by Alistair Leslie-Hughes (＠alesliehughes) 03 Oct '23

03 Oct '23

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/4004

2 1

Re: [PATCH v7 0/7] MR3938: winegstreamer: Implement CLSID_CMpegVideoCodec
by YuriK7 (＠riyu12383) 02 Oct '23

02 Oct '23

On Mon Oct 2 19:48:25 2023 +0000, Alfred Agrell wrote: > mpegpsdemux is part of libgstmpegpsdemux.so. It's unrelated to ffmpeg, > and it's present in Glorious-Eggroll already, nothing to do here. > (However, it's absent from upstream Proton.) > mpegvideoparse is in libgstvideoparsersbad.so. Likewise, this is part of > GE but not Proton, and is not part of ffmpeg. > avdec_mpeg2video is in libgstlibav.so, which is part of Proton - but the > exact set of decoders it offers depends on which ffmpeg you have > installed, and how it's configured. > Did you rebuild ffmpeg and copy that into an existing Wine or Proton > installation, without changing anything else? If yes, GStreamer probably > didn't notice the update. `touch` libgstlibav.so, or delete your > GStreamer plugin cache (probably at > ~/.cache/gstreamer-1.0/registry.x86_64.bin or > ~/steam/steamapps/compatdata/1234560/gstreamer-1.0/registry.x86_64.bin). > You can also grep that registry file for avdec_mpeg2video: if that > string is absent, then there's something wrong with your GStreamer or > your ffmpeg, but if it does exist, the problem is on Wine's side > (probably in this MR). (The cache is binary, but grep telling you > whether the binary file matches is good enough.) > Alternatively, I may simply be wrong; I've never compiled Proton, GE, or > ffmpeg. Good call on trying mpeg2video; if it exists, it's probably > better than plain mpegvideo. We built proton-ge entirely, with as you can see in the previous link, the makefile where the gst and ffmpeg build parameters are set. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3938#note_47447

1 0

[PATCH v4 0/5] MR3987: d3d10/effect: Add support for 'buge'/'bult' instructions.
by Nikolay Sivov (＠nsivov) 02 Oct '23

02 Oct '23

Signed-off-by: Nikolay Sivov <nsivov(a)codeweavers.com> -- v4: d3d10/effect: Add support for 'dot' instruction. d3d10/effect: Add support for 'floor' instruction. d3d10/effect: Add support for 'ceil' instruction. d3d10/tests: Compact returned arrays checks. https://gitlab.winehq.org/wine/wine/-/merge_requests/3987

3 9

[PATCH v2 0/1] MR385: vkd3d-shader: Fix compiler warning.
by Alistair Leslie-Hughes (＠alesliehughes) 02 Oct '23

02 Oct '23

vkd3d-shader/tpf.c:3810:39: warning: passing argument 2 of ‘sm4_register_from_node’ from incompatible pointer type [-Wincompatible-pointer-types] vkd3d-shader/tpf.c:4750:59: warning: passing argument 3 of ‘sm4_register_from_deref’ from incompatible pointer type [-Wincompatible-pointer-types] The other option is to change the parameter to a DWORD but this is a larger change. -- v2: vkd3d-shader: Fix compiler warning. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/385

3 3

Re: [PATCH v2 0/1] MR3998: d3dxof: Remove DECLSPEC_HIDDEN usage. - approved
by Alexandre Julliard (＠julliard) 02 Oct '23

02 Oct '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3998

1 0

Re: [PATCH v4 0/4] MR3983: windows.storage.applicationdata: Implement IApplicationDataStatics::get_Current(). - approved
by Alexandre Julliard (＠julliard) 02 Oct '23

02 Oct '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3983

1 0

Re: [PATCH v4 0/8] MR3956: uiautomationcore: Add support for raising events using the IProxyProviderWinEventHandler interface. - approved
by Alexandre Julliard (＠julliard) 02 Oct '23

02 Oct '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3956

1 0

Re: [PATCH v2 0/1] MR4000: msvfw32: Correctly store internal pointer. - approved
by Alexandre Julliard (＠julliard) 02 Oct '23

02 Oct '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4000

1 0

Re: [PATCH v4 0/1] MR3974: winemac.drv: Ensure user-land callback can access app_icon results. - approved
by Alexandre Julliard (＠julliard) 02 Oct '23

02 Oct '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3974

1 0

Re: [PATCH v2 0/1] MR3991: gdi32: Pass default DEVMODE to winspool in CreateDC." - approved
by Alexandre Julliard (＠julliard) 02 Oct '23

02 Oct '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3991

1 0

Re: [PATCH v2 0/1] MR3989: user32/tests: Print regions in test_hvredraw failure case. - approved
by Alexandre Julliard (＠julliard) 02 Oct '23

02 Oct '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3989

1 0

Re: [PATCH v2 0/1] MR3990: msvcr110: Reset chore task_collection earlier to prevent occasional test failure. - approved
by Alexandre Julliard (＠julliard) 02 Oct '23

02 Oct '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3990

1 0

Re: [PATCH v4 0/1] MR3984: configure: Don't link with -Wl,-z,defs on FreeBSD. - approved
by Alexandre Julliard (＠julliard) 02 Oct '23

02 Oct '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3984

1 0

Re: [PATCH v8 0/5] MR377: ci: Compile with -Werror. - approved
by Alexandre Julliard (＠julliard) 02 Oct '23

02 Oct '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/377

1 0

Re: [PATCH v2 0/1] MR383: tests: Destroy the test context in test_readback_map_stability(). - approved
by Alexandre Julliard (＠julliard) 02 Oct '23

02 Oct '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/383

1 0

Re: [PATCH v4 0/1] MR380: vkd3d-dxbc: Print section offsets. - approved
by Alexandre Julliard (＠julliard) 02 Oct '23

02 Oct '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/380

1 0

[PATCH 0/3] MR4003: mshtml: mshtml: Call handle_event on the proper dispex object & misc.
by Gabriel Ivăncescu (＠insn) 02 Oct '23

02 Oct '23

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/4003

3 4

[PATCH 0/1] MR3998: d3dxof: Remove DECLSPEC_HIDDEN usage.
by Alistair Leslie-Hughes (＠alesliehughes) 02 Oct '23

02 Oct '23

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/3998

3 2

[PATCH v3 0/5] MR3987: d3d10/effect: Add support for 'buge'/'bult' instructions.
by Nikolay Sivov (＠nsivov) 02 Oct '23

02 Oct '23

Signed-off-by: Nikolay Sivov <nsivov(a)codeweavers.com> -- v3: d3d10/effect: Add support for 'dot' instruction. d3d10/effect: Add support for 'floor' instruction. d3d10/effect: Add support for 'ceil' instruction. d3d10/tests: Compact returned arrays checks. d3d10/effect: Add support for 'buge'/'bult' instructions. https://gitlab.winehq.org/wine/wine/-/merge_requests/3987

3 9

Re: [PATCH v7 0/7] MR3938: winegstreamer: Implement CLSID_CMpegVideoCodec
by Alfred Agrell (＠Alcaro) 02 Oct '23

02 Oct '23

On Mon Oct 2 19:06:41 2023 +0000, YuriK7 wrote: > We tried to add the codec by adding > --enable-decoder=mpegvideo,--enable-decoder=mpeg1video,--enable-decoder=mpeg2video > and it still show the color bars... does it also need flags for the > demuxer and parser in order to work ? > In your gstkrkr code you say that "in GStreamer, decoding a mpeg video > requires three elements: mpegpsdemux ! mpegvideoparse ! > avdec_mpeg2video" are those enabled by default if the ffmpeg flags are > good ? We should enable them inside the GST_BAD_MESON_ARGS ? > avdec_mpeg2video seems to be in the libav plugin. > We made those changes to https://github.com/GloriousEggroll/proton-ge-custom/blob/master/Makefile.in mpegpsdemux is part of libgstmpegpsdemux.so. It's unrelated to ffmpeg, and it's present in Glorious-Eggroll already, nothing to do here. (However, it's absent from upstream Proton.) mpegvideoparse is in libgstvideoparsersbad.so. Likewise, this is part of GE but not Proton, and is not part of ffmpeg. avdec_mpeg2video is in libgstlibav.so, which is part of Proton - but the exact set of decoders it offers depends on which ffmpeg you have installed, and how it's configured. Did you rebuild ffmpeg and copy that into an existing Wine or Proton installation, without changing anything else? If yes, GStreamer probably didn't notice the update. `touch` libgstlibav.so, or delete your GStreamer plugin cache (probably at ~/.cache/gstreamer-1.0/registry.x86_64.bin or ~/steam/steamapps/compatdata/1234560/gstreamer-1.0/registry.x86_64.bin). You can also grep that registry file for avdec_mpeg2video: if that string is absent, then there's something wrong with your GStreamer or your ffmpeg, but if it does exist, the problem is on Wine's side (probably in this MR). (The cache is binary, but grep telling you whether the binary file matches is good enough.) Alternatively, I may simply be wrong; I've never compiled Proton, GE, or ffmpeg. Good call on trying mpeg2video; if it exists, it's probably better than plain mpegvideo. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3938#note_47409

1 0

[PATCH 0/5] MR3996: dmsynth: Import and begin using FluidSynth.
by Rémi Bernon (＠rbernon) 02 Oct '23

02 Oct '23

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/3996

3 10

Re: [PATCH v7 0/7] MR3938: winegstreamer: Implement CLSID_CMpegVideoCodec
by YuriK7 (＠riyu12383) 02 Oct '23

02 Oct '23

On Sun Oct 1 23:56:05 2023 +0000, Alfred Agrell wrote: > Yes, that is consistent with my experience. I tried Azumanga (everything > looks good to me with this patch) and Touhou (crashes on Wine 8.17, Wine > 8.17 with this patch, and Debian's Wine 8.0; different output before the > crash, but they all segfault in > SampleGrabber_ISampleGrabber_GetCurrentBuffer). Sounds like a different > bug to me. > The color bars are not a Wine bug; they're protonmediaconverter. It does > that if it can't find a converted version of the media, which it can't > if you're running it outside Steam. gstkrkr fills that exact hole. > (gstkrkr also does a little trick to ensure ffmpeg's WMA audio decoder > is selected instead of mediaconverter.) We tried to add the codec by adding --enable-decoder=mpegvideo,--enable-decoder=mpeg1video,--enable-decoder=mpeg2video and it still show the color bars... does it also need flags for the demuxer and parser in order to work ? In your gstkrkr code you say that "in GStreamer, decoding a mpeg video requires three elements: mpegpsdemux ! mpegvideoparse ! avdec_mpeg2video" are those enabled by default if the ffmpeg flags are good ? We should enable them inside the GST_BAD_MESON_ARGS ? avdec_mpeg2video seems to be in the libav plugin. We made those changes to https://github.com/GloriousEggroll/proton-ge-custom/blob/master/Makefile.in -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3938#note_47406

1 0

Re: [PATCH v11 0/4] MR3554: mmdevapi: fixes for Yousician
by David McFarland (＠corngood) 02 Oct '23

02 Oct '23

I've rebased again. I'm not really sure what to do with this. There seem to be outstanding test failures in mmdevapi. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3554#note_47403

1 0

[PATCH v2 0/5] MR3995: dmime: Preparatory cleanup of segment state.
by Rémi Bernon (＠rbernon) 02 Oct '23

02 Oct '23

-- v2: dmime: Introduce a new segment_state_create constructor. dmime: Redirect IDirectMusicPerformance_PlaySegment to PlaySegmentEx. dmime: Implement some segment state default values. dmime: Get rid of the IDirectMusicSegmentState8Impl typedef. dmime: Rename DirectMusicSegmentState8 method prefix to segment_state. https://gitlab.winehq.org/wine/wine/-/merge_requests/3995

3 8

Re: [PATCH v11 0/4] MR3554: mmdevapi: fixes for Yousician
by David McFarland (＠corngood) 02 Oct '23

02 Oct '23

On Mon Oct 2 18:16:53 2023 +0000, David McFarland wrote: > comment fixed. > > It would be nice if at least the lower bound could be read from the > native audio system, though I don't know how to do that > I like this idea, but I'm not sure how to pull it off either. I guess > the biggest downside to this implementation would be unnecessarily high latency? > My preference would be to leave that for a separate MR. I'm going to resolve this. Feel free to reopen if it's blocking. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3554#note_47399

1 0

[PATCH v2 0/8] MR3993: windows.media.mediacontrol: Implement some ISystemMediaTransportControls properties.
by Mohamad Al-Jaf (＠maljaf) 02 Oct '23

02 Oct '23

Called by Roon. I have more patches for this, but I split them up for easier review. -- v2: windows.media.mediacontrol: Implement some ISystemMediaTransportControls properties. windows.media.mediacontrol/tests: Add some ISystemMediaTransportControls properties tests. windows.media.mediacontrol: Implement ISystemMediaTransportControlsInterop::GetForWindow(). windows.media.mediacontrol/tests: Add ISystemMediaTransportControlsInterop::GetForWindow() tests. https://gitlab.winehq.org/wine/wine/-/merge_requests/3993

3 11

[PATCH 0/5] MR3994: include: Introduce wine_dbgstr_fourcc and debugstr_fourcc.
by Alex Henrie (＠alexhenrie) 02 Oct '23

02 Oct '23

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/3994

3 6

[PATCH v3 0/4] MR3983: windows.storage.applicationdata: Implement IApplicationDataStatics::get_Current().
by Mohamad Al-Jaf (＠maljaf) 02 Oct '23

02 Oct '23

Needed for Minecraft Windows 10. -- v3: windows.storage.applicationdata: Implement IApplicationDataStatics::get_Current(). windows.storage.applicationdata/tests: Add IApplicationDataStatics::get_Current() tests. https://gitlab.winehq.org/wine/wine/-/merge_requests/3983

4 8

[PATCH v3 0/8] MR3956: uiautomationcore: Add support for raising events using the IProxyProviderWinEventHandler interface.
by Connor McAdams (＠cmcadams) 02 Oct '23

02 Oct '23

-- v3: uiautomationcore: Add support for raising events passed to our IProxyProviderWinEventSink interface. uiautomationcore: Pass WinEvent data to IProxyProviderWinEventHandler::RespondToWinEvent. uiautomationcore: Add support for marking the root IAccessible as known on non-root IAccessibles upon proxy provider creation. uiautomationcore: Add support for ignoring ProviderOptions_UseComThreading when creating an HUIANODE. uiautomationcore: Create HUIANODE for WinEvents that should invoke IProxyProviderWinEventHandler::RespondToWinEvent. uiautomationcore: Check if we should try to invoke IProxyProviderWinEventHandler::RespondToWinEvent for registered UIA events. uiautomationcore: Introduce uia_event_for_each function for iterating through registered events. uiautomationcore/tests: Add another test for IProxyProviderWinEventHandler child HWND scope checking. https://gitlab.winehq.org/wine/wine/-/merge_requests/3956

3 10

[PATCH v7 0/5] MR377: ci: Compile with -Werror.
by Giovanni Mascellani (＠giomasce) 02 Oct '23

02 Oct '23

Manually disable some warnings that are currently emitted. Eventually the warnings should be solved and -Werror should remain alone. -- v7: ci: Update the README with some recent changes. demos: Do not trigger -Wmissing-prototypes for wmain(). vkd3d: Use CONST_VTABLE. ci: Store config.log as a build artifact. ci: Compile with -Werror. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/377

2 5

[PATCH v18 0/4] MR346: tests/shader-runner: Test DXIL shaders.
by Conor McCarthy (＠cmccarthy) 02 Oct '23

02 Oct '23

This goes on top of MR 345. -- v18: tests/shader-runner: Test shaders with dxcompiler. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/346

3 11

[PATCH 0/1] MR3025: include: Add missing interfaces in wia_lh.idl
by Biswapriyo Nath (＠Biswa96) 02 Oct '23

02 Oct '23

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/3025

3 5

[PATCH 0/1] MR383: tests: Destroy the test context in test_readback_map_stability().
by Conor McCarthy (＠cmccarthy) 02 Oct '23

02 Oct '23

-- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/383

4 3

[PATCH v3 0/1] MR380: vkd3d-dxbc: Print section offsets.
by Giovanni Mascellani (＠giomasce) 02 Oct '23

02 Oct '23

-- v3: vkd3d-dxbc: Print section offsets. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/380

3 2

[PATCH v5 0/5] MR377: ci: Compile with -Werror.
by Giovanni Mascellani (＠giomasce) 02 Oct '23

02 Oct '23

Manually disable some warnings that are currently emitted. Eventually the warnings should be solved and -Werror should remain alone. -- v5: ci: Update the README with some recent changes. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/377

3 6

[PATCH 0/1] MR385: vkd3d-shader: Fix compiler warning.
by Alistair Leslie-Hughes (＠alesliehughes) 02 Oct '23

02 Oct '23

vkd3d-shader/tpf.c:3810:39: warning: passing argument 2 of ‘sm4_register_from_node’ from incompatible pointer type [-Wincompatible-pointer-types] vkd3d-shader/tpf.c:4750:59: warning: passing argument 3 of ‘sm4_register_from_deref’ from incompatible pointer type [-Wincompatible-pointer-types] The other option is to change the parameter to a DWORD but this is a larger change. -- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/385

4 4

[PATCH 0/3] MR382: vkd3d-shader/tpf: Replace sm4 register structs with vkd3d-shader register structs, part 4.
by Francisco Casas (＠fcasas) 02 Oct '23

02 Oct '23

-- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/382

4 5

[PATCH 0/1] MR4000: msvfw32: Correctly store internal pointer.
by eric pouech (＠epo) 02 Oct '23

02 Oct '23

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=55696 Signed-off-by: Eric Pouech <epouech(a)codeweavers.com> -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4000

2 1

[PATCH v3 0/1] MR3974: winemac.drv: Ensure user-land callback can access app_icon results.
by eric pouech (＠epo) 02 Oct '23

02 Oct '23

Wine-Bugs: https://bugs.winehq.org/show_bug.cgi?id=55658 Signed-off-by: Eric Pouech <epouech(a)codeweavers.com> -- v3: winemac.drv: Use NtCallbackReturn to send back app's icons to unixlib. https://gitlab.winehq.org/wine/wine/-/merge_requests/3974

3 2

Re: [PATCH v2 0/1] MR3854: winmm: Avoid use of hardcoded return values.
by Alistair Leslie-Hughes (＠alesliehughes) 02 Oct '23

02 Oct '23

Yes, currently MCI_MapMsgAtoW returns a tri-state. -1 = Memory allocation error 0 = No unmap required 1 = Unmap required. Since MCI_UnmapMsgAtoW handles all the cases where MCI_MapMsgAtoW allocates memory. Why not just call MCI_UnmapMsgAtoW to do its thing in all cases? -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3854#note_47342

1 0

[PATCH 0/1] MR3991: gdi32: Pass default DEVMODE to winspool in CreateDC."
by Piotr Caban (＠piotr) 02 Oct '23

02 Oct '23

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=55670 -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3991

3 2

[PATCH 0/5] MR3995: dmime: Preparatory cleanup of segment state.
by Rémi Bernon (＠rbernon) 02 Oct '23

02 Oct '23

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/3995

3 6

[PATCH v2 0/4] MR3983: windows.storage.applicationdata: Implement IApplicationDataStatics::get_Current().
by Mohamad Al-Jaf (＠maljaf) 02 Oct '23

02 Oct '23

Needed for Minecraft Windows 10. -- v2: windows.storage.applicationdata: Implement IApplicationDataStatics::get_Current(). windows.storage.applicationdata/tests: Add IApplicationDataStatics::get_Current() tests. https://gitlab.winehq.org/wine/wine/-/merge_requests/3983

4 7

Re: [PATCH v7 0/7] MR3938: winegstreamer: Implement CLSID_CMpegVideoCodec
by Alfred Agrell (＠Alcaro) 01 Oct '23

01 Oct '23

On Sun Oct 1 23:30:07 2023 +0000, YuriK7 wrote: > Thanks ! > The game I mentioned (touhou sky fight) is a weird case. It already > hangs (actually it just errors out and closes) without your patch on > vanilla wine whit the gstreamer shipped with wine-ge 8-16 where they > updated it to 1.22. With the old gstreamer it used to be a skippable > black screen, however adding gstkrkr makes it crash. This merge doesn't > seem to change anything on that so be reassured, I guess I should open > either a wine issue or a gstreamer issue... > But Azumanga Fighter, Higurashi Daybreak Kai and HaruToma 2 works > perfectly well with the new gstreamer + gstkrkr (the new version show a > color bars screen when the codec is missing, instead of playing the sound). Yes, that is consistent with my experience. I tried Azumanga (everything looks good to me with this patch) and Touhou (crashes on Wine 8.17, Wine 8.17 with this patch, and Debian's Wine 8.0; different output before the crash, but they all segfault in SampleGrabber_ISampleGrabber_GetCurrentBuffer). Sounds like a different bug to me. The color bars are not a Wine bug; they're protonmediaconverter. It does that if it can't find a converted version of the media, which it can't if you're running it outside Steam. gstkrkr fills that exact hole. (gstkrkr also does a little trick to ensure ffmpeg's WMA audio decoder is selected instead of mediaconverter.) -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3938#note_47318

1 0

Re: [PATCH v7 0/7] MR3938: winegstreamer: Implement CLSID_CMpegVideoCodec
by YuriK7 (＠riyu12383) 01 Oct '23

01 Oct '23

On Sun Oct 1 14:18:55 2023 +0000, Alfred Agrell wrote: > Glorious-Eggroll has a MPEG demuxer, which Proton's GStreamer lacks, but > neither of them have any MPEG-1 video decoder. > From what I can google, the correct incantation is adding > --enable-decoder=mpegvideo to GE's ffmpeg configure line; if successful, > it should show up in GStreamer as avdec_mpeg2video. > If adding gstkrkr works even without this MR, my guess is that those > programs tell DirectShow to automatically pick the appropriate decoders, > which ends up using CLSID_decodebin_parser instead of > CLSID_CMpegVideoCodec; you were missing the codec, but nothing else. > If adding this MR makes it hang or otherwise screw up, that's definitely > something I should look into... Thanks ! The game I mentioned (touhou sky fight) is a weird case. It already hangs (actually it just errors out and closes) without your patch on vanilla wine whit the gstreamer shipped with wine-ge 8-16 where they updated it to 1.22. With the old gstreamer it used to be a skippable black screen, however adding gstkrkr makes it crash. This merge doesn't seem to change anything on that so be reassured, I guess I should open either a wine issue or a gstreamer issue... But Azumanga Fighter, Higurashi Daybreak Kai and HaruToma 2 works perfectly well with the new gstreamer + gstkrkr (the new version show a color bars screen when the codec is missing, instead of playing the sound). -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3938#note_47317

1 0

[PATCH v10 0/1] MR3959: uxtheme: Add ShouldSystemUseDarkMode.
by Helix Graziani (＠TornadoCookie) 01 Oct '23

01 Oct '23

Used in some .NET apps for theming purposes. -- v10: uxtheme: Add ShouldSystemUseDarkMode. https://gitlab.winehq.org/wine/wine/-/merge_requests/3959

3 2

[PATCH v3 0/11] MR3907: ntdll: Initial implementation of File{Rename,Link}InformationEx
by Joel Holdsworth (＠jhol) 01 Oct '23

01 Oct '23

-- v3: ntdll: Add support for FILE_{RENAME,LINK}_POSIX_SEMANTICS. ntdll: Factored out get_inode_open_sharing. ntdll/test: Add tests for FILE_LINK_POSIX_SEMANTICS. ntdll/test: Add tests for FILE_RENAME_POSIX_SEMANTICS. ntdll: Add support for FILE_{RENAME,LINK}_IGNORE_READONLY_ATTRIBUTE. server: Don't allow read-only files to be replaced by File{Rename,Link}Information{,Ex}. ntdll/test: Add tests for FILE_LINK_IGNORE_READONLY_ATTRIBUTE. ntdll/test: Add tests for FILE_RENAME_IGNORE_READONLY_ATTRIBUTE. ntdll/test: Use FileDispositionInformationEx to delete files and directories. ntdll: Initial implementation of FileLinkInformationEx. ntdll: Initial implementation of FileRenameInformationEx. https://gitlab.winehq.org/wine/wine/-/merge_requests/3907

4 19

Re: [PATCH v7 0/7] MR3938: winegstreamer: Implement CLSID_CMpegVideoCodec
by Alfred Agrell (＠Alcaro) 01 Oct '23

01 Oct '23

On Sun Oct 1 13:54:50 2023 +0000, YuriK7 wrote: > Adding the gstkrkr .so files does indeed fix the issue even without this > merge an azumanga fighter and HaruToma 2. It didn't worked with touhou > sky fight but I couldn't test with your merge as it hangs with vanilla wine. > I thought wine-ge had all the plugins, as I used their libs to get rid > of the missing MPEG1 decoder issue. Do you know exactly which > plugin/part/flag they have to add ? Glorious-Eggroll has a MPEG demuxer, which Proton's GStreamer lacks, but neither of them have any MPEG-1 video decoder. From what I can google, the correct incantation is adding --enable-decoder=mpegvideo to GE's ffmpeg configure line; if successful, it should show up in GStreamer as avdec_mpeg2video. If adding gstkrkr works even without this MR, my guess is that those programs tell DirectShow to automatically pick the appropriate decoders, which ends up using CLSID_decodebin_parser instead of CLSID_CMpegVideoCodec; you were missing the codec, but nothing else. If adding this MR makes it hang or otherwise screw up, that's definitely something I should look into... -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3938#note_47297

1 0

Re: [PATCH v7 0/7] MR3938: winegstreamer: Implement CLSID_CMpegVideoCodec
by YuriK7 (＠riyu12383) 01 Oct '23

01 Oct '23

On Sun Oct 1 13:54:50 2023 +0000, Alfred Agrell wrote: > Yep, that one looks like a close relative of > https://bugs.winehq.org/show_bug.cgi?id=9127 (possibly even duplicate). > Last time I checked, Proton-GE didn't include any MPEG video decoder. > Probably because it's unnecessary - without Wine-side support, there's > no way to access that codec, so there's no point wasting space on it. > Once this thing is merged, that will become a bug on their end. Feel > free to report it. > If you want a faster solution, you can take the GStreamer plugin from > https://github.com/Alcaro/krkrwine/releases/tag/v1.0.0 and place it in > the GST_PLUGIN_SYSTEM_PATH. (I wouldn't recommend installing the rest of > that program, it's tested with Proton 8.0 only and may interact weirdly > with this MR.) Adding the gstkrkr .so files does indeed fix the issue even without this merge an azumanga fighter and HaruToma 2. It didn't worked with touhou sky fight but I couldn't test with your merge as it hangs with vanilla wine. I thought wine-ge had all the plugins, as I used their libs to get rid of the missing MPEG1 decoder issue. Do you know exactly which plugin/part/flag they have to add ? -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3938#note_47296

1 0

[PATCH v6 0/7] MR3938: winegstreamer: Implement CLSID_CMpegVideoCodec
by Alfred Agrell (＠Alcaro) 01 Oct '23

01 Oct '23

Resolves https://bugs.winehq.org/show_bug.cgi?id=9127 . (Some of the named programs in that issue may require additional currently-missing functionality, I didn't check; but if so, that's separate issues.) Tested with - winetest on Windows 7 - winetest on Windows 10 - winetest in Wine, of course - microkiri https://bugs.winehq.org/show_bug.cgi?id=9127#c102 - Wagamama High Spec Trial Edition https://wagahigh.com/download_trial.php#normal (ダウンロード means download) - Ninki Seiyuu no Tsukurikata Trial https://archive.org/details/sayou_trial (WMV files in microkiri and Wagamama don't work, but that's separate issues. Also, they need the LC_ALL=ja_JP env, or they throw various goofy errors.) -- v6: quartz/tests: Add tests for CLSID_CMpegVideoCodec. quartz/tests: Add tests for new CLSID_MPEG1Splitter functionality. winegstreamer: Improve and clean up some debug logs. winegstreamer: Implement a little more of IAMStreamSelect in CLSID_MPEG1Splitter. winegstreamer: Handle format changes better in Quartz. winegstreamer: Implement CLSID_CMpegVideoCodec. https://gitlab.winehq.org/wine/wine/-/merge_requests/3938

5 13

[PATCH 0/1] MR3990: msvcr110: Reset chore task_collection earlier to prevent occasional test failure.
by Piotr Caban (＠piotr) 01 Oct '23

01 Oct '23

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=55686 -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3990

2 1

[PATCH v9 0/1] MR3959: uxtheme: Add ShouldSystemUseDarkMode.
by Helix Graziani (＠TornadoCookie) 01 Oct '23

01 Oct '23

Used in some .NET apps for theming purposes. -- v9: uxtheme: Add ShouldSystemUseDarkMode. https://gitlab.winehq.org/wine/wine/-/merge_requests/3959

4 8

2025

2024

2023

2022

wine-gitlab