- wine-gitlab - winehq.org

[PATCH v2 0/1] MR3988: winetts: Add stub dll.
by Shaun Ren (＠shaunren) 30 Sep '23

30 Sep '23

-- v2: winetts: Add stub dll. https://gitlab.winehq.org/wine/wine/-/merge_requests/3988

4 3

[PATCH 0/1] MR3989: user32/tests: Print regions in test_hvredraw failure case.
by Esme Povirk (＠madewokherd) 30 Sep '23

30 Sep '23

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/3989

2 1

Re: [PATCH v8 0/1] MR3959: uxtheme: Add ShouldSystemUseDarkMode.
by Zhiyi Zhang (＠zhiyi) 30 Sep '23

30 Sep '23

Zhiyi Zhang (@zhiyi) commented about dlls/uxtheme/tests/system.c: > + /* Call ShouldSystemUseDarkMode() and check for errors */ > + SetLastError(ERROR_SUCCESS); /* Clear error buffer so that we can detect if an error occurred. */ > + function_result = pShouldSystemUseDarkMode(); > + last_error = GetLastError(); > + ok(last_error == ERROR_SUCCESS, "ShouldSystemUseDarkMode failed (?) with error %ld.\n", > + last_error); > + > + /* Expect same value as key */ > + ok(function_result == !system_uses_light_theme, "Expected value %d, got %d.\n", > + !system_uses_light_theme, function_result); > + > + ls = RegDeleteValueA(hk, "AppsUseLightTheme"); > + ok(ls == 0, "RegDeleteValueA failed: %ld.\n", ls); > + > + /* Call ShouldSystemUseDarkMode() and check for errors with deleted value */ > + SetLastError(ERROR_SUCCESS); /* Clear error buffer so that we can detect if an error occurred. */ For the last error code. You can SetLastError(0xdeadbeef) before the call and check that the last error is set to ERROR_SUCCESS after the call. And then you set the last error code in the ShouldSystemUseDarkMode() implementation. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3959#note_47274

1 0

Re: [PATCH v8 0/1] MR3959: uxtheme: Add ShouldSystemUseDarkMode.
by Zhiyi Zhang (＠zhiyi) 30 Sep '23

30 Sep '23

Zhiyi Zhang (@zhiyi) commented about dlls/uxtheme/tests/system.c: > DestroyWindow(hwnd); > } > > +static void test_ShouldSystemUseDarkMode(void) I think these tests might be a bit too much. I like the initial version that uses RegGetValueA() and confirms the registry value is the opposite of the ShouldSystemUseDarkMode. With some checks for the last error code and I think that's enough. These newly added tests confirm caching for ShouldSystemUseDarkMode() and that's good. However, ShouldSystemUseDarkMode() still need to query the registry key so it's not that useful. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3959#note_47270

1 0

Re: [PATCH v8 0/1] MR3959: uxtheme: Add ShouldSystemUseDarkMode.
by Zhiyi Zhang (＠zhiyi) 30 Sep '23

30 Sep '23

Zhiyi Zhang (@zhiyi) commented about dlls/uxtheme/system.c: > +/********************************************************************** > + * ShouldSystemUseDarkMode (UXTHEME.138) > + * > + * RETURNS > + * Whether or not the system/app should use dark mode. > + */ > +BOOL WINAPI ShouldSystemUseDarkMode(void) > +{ > + DWORD system_uses_light_theme_size = sizeof(DWORD); > + /* Persists between calls, in windows it might look up some internal table. */ > + static DWORD system_uses_light_theme = TRUE; > + > + /* We don't necessarily care that this might fail because it doesn't affect > + * system_uses_light_theme if it does. > + */ > + RegGetValueA(HKEY_CURRENT_USER, Please use RegGetValueW() instead so that we don't have to do ASCII/Unicode conversion every time this gets called. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3959#note_47271

1 0

Re: [PATCH v8 0/1] MR3959: uxtheme: Add ShouldSystemUseDarkMode.
by Zhiyi Zhang (＠zhiyi) 30 Sep '23

30 Sep '23

Zhiyi Zhang (@zhiyi) commented about dlls/uxtheme/system.c: > UnregisterUserApiHook(); > return TRUE; > } > + > +/********************************************************************** > + * ShouldSystemUseDarkMode (UXTHEME.138) > + * > + * RETURNS > + * Whether or not the system/app should use dark mode. > + */ > +BOOL WINAPI ShouldSystemUseDarkMode(void) > +{ > + DWORD system_uses_light_theme_size = sizeof(DWORD); You can remove the system_uses_ prefix. These codes are in ShouldSystemUseDarkMode() so it's already known that it's for querying system settings. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3959#note_47272

1 0

Re: [PATCH v8 0/1] MR3959: uxtheme: Add ShouldSystemUseDarkMode.
by Zhiyi Zhang (＠zhiyi) 30 Sep '23

30 Sep '23

Zhiyi Zhang (@zhiyi) commented about dlls/uxtheme/system.c: > UnregisterUserApiHook(); > return TRUE; > } > + > +/********************************************************************** > + * ShouldSystemUseDarkMode (UXTHEME.138) > + * > + * RETURNS > + * Whether or not the system/app should use dark mode. Shouldn't `system/app` be `system`? because there is a ShouldAppsUseDarkMode() as you said previously. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3959#note_47273

1 0

Re: [PATCH v8 0/1] MR3959: uxtheme: Add ShouldSystemUseDarkMode.
by Zhiyi Zhang (＠zhiyi) 30 Sep '23

30 Sep '23

Zhiyi Zhang (@zhiyi) commented about dlls/uxtheme/system.c: > + > +/********************************************************************** > + * ShouldSystemUseDarkMode (UXTHEME.138) > + * > + * RETURNS > + * Whether or not the system/app should use dark mode. > + */ > +BOOL WINAPI ShouldSystemUseDarkMode(void) > +{ > + DWORD system_uses_light_theme_size = sizeof(DWORD); > + /* Persists between calls, in windows it might look up some internal table. */ > + static DWORD system_uses_light_theme = TRUE; > + > + /* We don't necessarily care that this might fail because it doesn't affect > + * system_uses_light_theme if it does. > + */ While comments are nice to have, these are pretty obvious so I think you can ignore it. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3959#note_47269

1 0

Re: [PATCH v8 0/1] MR3959: uxtheme: Add ShouldSystemUseDarkMode.
by Zhiyi Zhang (＠zhiyi) 30 Sep '23

30 Sep '23

Zhiyi Zhang (@zhiyi) commented about dlls/uxtheme/system.c: > UnregisterUserApiHook(); > return TRUE; > } > + > +/********************************************************************** > + * ShouldSystemUseDarkMode (UXTHEME.138) > + * > + * RETURNS > + * Whether or not the system/app should use dark mode. > + */ > +BOOL WINAPI ShouldSystemUseDarkMode(void) > +{ > + DWORD system_uses_light_theme_size = sizeof(DWORD); > + /* Persists between calls, in windows it might look up some internal table. */ > + static DWORD system_uses_light_theme = TRUE; You can remove the static keyword and always initialize system_uses_light_theme to TRUE. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3959#note_47268

1 0

[PATCH v3 0/1] MR3984: configure: Don't link with -Wl,-z,defs on FreeBSD.
by Brendan Shanks (＠bshanks) 29 Sep '23

29 Sep '23

On FreeBSD, using `environ` in a shared library linked with `-Wl,-z,defs` causes an undefined reference error: ``` gcc -m64 -o dlls/msv1_0/msv1_0.so -shared -Wl,-Bsymbolic -Wl,-soname,msv1_0.so -Wl,-z,defs dlls/msv1_0/unixlib.o dlls/ntdll/ntdll.so /usr/local/bin/ld: dlls/msv1_0/unixlib.o: in function `ntlm_fork': /usr/home/pip/wine/build64/../dlls/msv1_0/unixlib.c:206: undefined reference to `environ' collect2: error: ld returned 1 exit status *** Error code 1 ``` This is unfortunately a common issue on FreeBSD, see: - https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=263265 - https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=265008 - https://reviews.freebsd.org/D30842 Reported by Gerald Pfeifer. -- v3: configure: Don't use -Wl,-z,defs if causes link errors with 'environ'. https://gitlab.winehq.org/wine/wine/-/merge_requests/3984

3 2

[PATCH v7 0/1] MR3959: uxtheme: Add ShouldSystemUseDarkMode.
by Helix Graziani (＠TornadoCookie) 29 Sep '23

29 Sep '23

Used in some .NET apps for theming purposes. -- v7: uxtheme: Add ShouldSystemUseDarkMode. https://gitlab.winehq.org/wine/wine/-/merge_requests/3959

3 8

Re: [PATCH v2 0/9] MR3985: dmime, dmband: Implement GUID_ConnectToDLSCollection and band download. - approved
by Alexandre Julliard (＠julliard) 29 Sep '23

29 Sep '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3985

1 0

Re: [PATCH v2 0/2] MR3981: shell32: Better handle long URLs. - approved
by Alexandre Julliard (＠julliard) 29 Sep '23

29 Sep '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3981

1 0

Re: [PATCH v2 0/1] MR3980: windows.applicationmodel/tests: Use PathRemoveFileSpecW() instead of PathCchRemoveFileSpec(). - approved
by Alexandre Julliard (＠julliard) 29 Sep '23

29 Sep '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3980

1 0

Re: [PATCH v6 0/3] MR3424: msxml3: Add ValidateOnParse property support. - approved
by Alexandre Julliard (＠julliard) 29 Sep '23

29 Sep '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3424

1 0

Re: [PATCH v3 0/3] MR3986: include: Initial ARM64EC target support. - approved
by Alexandre Julliard (＠julliard) 29 Sep '23

29 Sep '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3986

1 0

Re: [PATCH v7 0/9] MR3953: dmusic: Implement SF2 collection parsing and load unix default-GM.sf2 for system gm.dls. - approved
by Alexandre Julliard (＠julliard) 29 Sep '23

29 Sep '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3953

1 0

[PATCH v2 0/1] MR3984: configure: Don't link with -Wl,-z,defs on FreeBSD.
by Brendan Shanks (＠bshanks) 29 Sep '23

29 Sep '23

On FreeBSD, using `environ` in a shared library linked with `-Wl,-z,defs` causes an undefined reference error: ``` gcc -m64 -o dlls/msv1_0/msv1_0.so -shared -Wl,-Bsymbolic -Wl,-soname,msv1_0.so -Wl,-z,defs dlls/msv1_0/unixlib.o dlls/ntdll/ntdll.so /usr/local/bin/ld: dlls/msv1_0/unixlib.o: in function `ntlm_fork': /usr/home/pip/wine/build64/../dlls/msv1_0/unixlib.c:206: undefined reference to `environ' collect2: error: ld returned 1 exit status *** Error code 1 ``` This is unfortunately a common issue on FreeBSD, see: - https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=263265 - https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=265008 - https://reviews.freebsd.org/D30842 Reported by Gerald Pfeifer. -- v2: configure: Don't link with -Wl,-z,defs on FreeBSD. https://gitlab.winehq.org/wine/wine/-/merge_requests/3984

3 2

[PATCH 0/9] MR3985: dmime, dmband: Implement GUID_ConnectToDLSCollection and band download.
by Rémi Bernon (＠rbernon) 29 Sep '23

29 Sep '23

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/3985

3 10

[PATCH 0/1] MR2684: mf: Request more samples for transforms when needed.
by Shaun Ren (＠shaunren) 29 Sep '23

29 Sep '23

This avoids stalling the pipeline when upstream nodes have not given enough samples for processing. If there are multiple upstream nodes, request samples in a round-robin fashion. This fixes an issue where the intro audio of the game Airborne Kingdom stops playing after a few seconds. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2684

3 3

[PATCH 0/1] MR3988: winetts: Add stub dll.
by Shaun Ren (＠shaunren) 29 Sep '23

29 Sep '23

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/3988

2 1

[PATCH v2 0/8] MR3956: uiautomationcore: Add support for raising events using the IProxyProviderWinEventHandler interface.
by Connor McAdams (＠cmcadams) 29 Sep '23

29 Sep '23

-- v2: uiautomationcore/tests: Add another test for IProxyProviderWinEventHandler child HWND scope checking. uiautomationcore: Add support for raising events passed to our IProxyProviderWinEventSink interface. uiautomationcore: Pass WinEvent data to IProxyProviderWinEventHandler::RespondToWinEvent. uiautomationcore: Add support for marking the root IAccessible as known on non-root IAccessibles upon proxy provider creation. uiautomationcore: Add support for ignoring ProviderOptions_UseComThreading when creating an HUIANODE. uiautomationcore: Create HUIANODE for WinEvents that should invoke IProxyProviderWinEventHandler::RespondToWinEvent. uiautomationcore: Check if we should try to invoke IProxyProviderWinEventHandler::RespondToWinEvent for registered UIA events. uiautomationcore: Introduce uia_event_for_each function for iterating through registered events. https://gitlab.winehq.org/wine/wine/-/merge_requests/3956

3 16

[PATCH 0/1] MR3980: windows.applicationmodel/tests: Use PathRemoveFileSpecW() instead of PathCchRemoveFileSpec().
by Mohamad Al-Jaf (＠maljaf) 29 Sep '23

29 Sep '23

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=55652 -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3980

4 3

[PATCH v5 0/3] MR3424: msxml3: Add ValidateOnParse property support.
by Jactry Zeng (＠jactry) 29 Sep '23

29 Sep '23

-- v5: msxml3/tests: Add tests of ValidateOnParse property. https://gitlab.winehq.org/wine/wine/-/merge_requests/3424

3 4

[PATCH v2 0/3] MR3986: include: Initial ARM64EC target support.
by Jacek Caban (＠jacek) 29 Sep '23

29 Sep '23

ARM64EC target defines x86_64 macros to ensure that x86_64-specific code paths are used, but for code that really needs to use aarch64 branch there is an additional _M_ARM64EC macro that needs to be used. See https://techcommunity.microsoft.com/t5/windows-os-platform-blog/getting-to-… for details. -- v2: include: Support ARM64EC target in winnt.h. include: Move __getReg intrinsic to intrin.h. include: Support ARM64EC target in intrin.h. https://gitlab.winehq.org/wine/wine/-/merge_requests/3986

2 3

[PATCH 0/3] MR3986: include: Initial ARM64EC target support.
by Jacek Caban (＠jacek) 29 Sep '23

29 Sep '23

ARM64EC target defines x86_64 macros to ensure that x86_64-specific code paths are used, but for code that really needs to use aarch64 branch there is an additional _M_ARM64EC macro that needs to be used. See https://techcommunity.microsoft.com/t5/windows-os-platform-blog/getting-to-… for details. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3986

4 11

[PATCH v4 0/1] MR371: vkd3d-shader/hlsl: Implement ternary operator for SM1.
by Nikolay Sivov (＠nsivov) 29 Sep '23

29 Sep '23

This is correct for pixel shaders, vertex shaders do not have 'cmp'. -- v4: vkd3d-shader/hlsl: Implement ternary operator for SM1. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/371

2 2

[PATCH 0/1] MR3984: msv1_0: Fix 'environ' undefined reference link error on FreeBSD.
by Brendan Shanks (＠bshanks) 29 Sep '23

29 Sep '23

On FreeBSD, using `environ` in a shared library linked with `-Wl,-z,defs` causes an undefined reference error: ``` gcc -m64 -o dlls/msv1_0/msv1_0.so -shared -Wl,-Bsymbolic -Wl,-soname,msv1_0.so -Wl,-z,defs dlls/msv1_0/unixlib.o dlls/ntdll/ntdll.so /usr/local/bin/ld: dlls/msv1_0/unixlib.o: in function `ntlm_fork': /usr/home/pip/wine/build64/../dlls/msv1_0/unixlib.c:206: undefined reference to `environ' collect2: error: ld returned 1 exit status *** Error code 1 ``` This is unfortunately a common issue on FreeBSD, see: - https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=263265 - https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=265008 - https://reviews.freebsd.org/D30842 Reported by Gerald Pfeifer. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3984

4 3

[PATCH v3 0/1] MR371: vkd3d-shader/hlsl: Implement ternary operator for SM1.
by Nikolay Sivov (＠nsivov) 29 Sep '23

29 Sep '23

This is correct for pixel shaders, vertex shaders do not have 'cmp'. -- v3: vkd3d-shader/hlsl: Implement ternary operator for SM1. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/371

5 7

[PATCH v7 0/1] MR329: vkd3d-shader/hlsl: Add determinant() function.
by Nikolay Sivov (＠nsivov) 29 Sep '23

29 Sep '23

I wanted to use ._xy element access to make it shorter, but that attempt was crushed by the reality - such indexing apparently compiles but does not produce correct element access loads. I'm going to update once this is fixed. -- v7: vkd3d-shader/hlsl: Add determinant() function. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/329

2 2

[PATCH 0/3] MR3987: d3d10/effect: Add support for 'buge'/'bult' instructions.
by Nikolay Sivov (＠nsivov) 29 Sep '23

29 Sep '23

Signed-off-by: Nikolay Sivov <nsivov(a)codeweavers.com> -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3987

2 3

[PATCH v6 0/1] MR3959: uxtheme: Add ShouldSystemUseDarkMode.
by Helix Graziani (＠TornadoCookie) 29 Sep '23

29 Sep '23

Used in some .NET apps for theming purposes. -- v6: uxtheme: Add ShouldSystemUseDarkMode. https://gitlab.winehq.org/wine/wine/-/merge_requests/3959

4 10

[PATCH 0/4] MR3983: windows.storage.applicationdata: Implement IApplicationDataStatics::get_Current().
by Mohamad Al-Jaf (＠maljaf) 29 Sep '23

29 Sep '23

Needed for Minecraft Windows 10. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3983

4 7

[PATCH 0/2] MR3982: include: Move RTL functions that belong in ntifs.h from winternl.h to ntifs.h.
by Alex Henrie (＠alexhenrie) 29 Sep '23

29 Sep '23

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/3982

3 3

Re: [PATCH v10 0/6] MR3548: windows.applicationmodel: Implement some functions.
by Mohamad Al-Jaf (＠maljaf) 29 Sep '23

29 Sep '23

On Mon Sep 25 07:27:07 2023 +0000, Rémi Bernon wrote: > Fwiw this is not always the location of the executable, especially if it > is located in a subfolder of the package, but the package root folder > path instead. Anyway, this should be good enough for now. Yeah, you're right. Minecraft calls `IApplicationData::get_LocalFolder()`, which is supposed to return the packages directory when `IStorageItem::get_Path()` is called, i.e. `AppData\\Local\\Packages\\Microsoft.MinecraftUWP\\LocalState`. The IApplicationData::get_ methods correspond to folders within the relative package folder. There doesn't seem to be a simple way of retrieving these directories. Each package has a number as a suffix. What I'm doing right now is loading the appxmanifest.xml file, using the identity name, and traversing the packages directory to find the right package. This doesn't account for duplicate names, which is unlikely to happen, but a concern nonetheless. Still, this seems best done using package APIs. Also, since Wine does not yet support installing packages, retrieving the directory this way won't work. Or rather, it doesn't create the package folder that IApplicationData::get_ points to, I don't know if simply adding in package folders would be enough for some applications to work. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3548#note_47174

1 0

[PATCH v5 0/10] MR372: vkd3d-shader/dxil: Read metadata and signatures.
by Conor McCarthy (＠cmccarthy) 29 Sep '23

29 Sep '23

-- v5: vkd3d-shader/dxil: Read the DXIL input and output signatures. vkd3d-shader/dxil: Validate the entry point info. vkd3d-shader/dxil: Read DXIL metadata named nodes. vkd3d-shader/dxil: Read DXIL metadata kinds. vkd3d-shader/dxil: Read DXIL metadata values. vkd3d-shader/dxil: Read DXIL metadata nodes. vkd3d-shader/dxil: Read DXIL metadata strings. vkd3d-shader/dxil: Emit an error on allocation failure in dxil_record_to_string(). vkd3d-shader/dxil: Read global constants in sm6_parser_globals_init(). vkd3d-shader/dxil: Read immediate constant arrays. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/372

2 13

[PATCH v4 0/3] MR3424: msxml3: Add ValidateOnParse property support.
by Jactry Zeng (＠jactry) 29 Sep '23

29 Sep '23

-- v4: msxml3/tests: Add tests of ValidateOnParse property. https://gitlab.winehq.org/wine/wine/-/merge_requests/3424

3 4

[PATCH 0/2] MR3981: shell32: Better handle long URLs.
by Paul Gofman (＠gofman) 29 Sep '23

29 Sep '23

Currently ShellExecuteA() doesn't work for opening very long (>1024 chars) URLs. Commit fbf9cf6ebadc7d50c8fb7a130851c3658607b343 ("shell32: Make sure wcmd has enough space to hold the string.") started fixing it, but that is not enough. This MR fixes two other issues on the way and lets ShellExecuteA() actually started winebrowser (with default registry) with the URL correctly relayed. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3981

2 2

[PATCH v6 0/1] MR329: vkd3d-shader/hlsl: Add determinant() function.
by Nikolay Sivov (＠nsivov) 28 Sep '23

28 Sep '23

I wanted to use ._xy element access to make it shorter, but that attempt was crushed by the reality - such indexing apparently compiles but does not produce correct element access loads. I'm going to update once this is fixed. -- v6: vkd3d-shader/hlsl: Add determinant() function. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/329

2 1

[PATCH v4 0/1] MR3959: uxtheme: Add ShouldSystemUseDarkMode.
by Helix Graziani (＠TornadoCookie) 28 Sep '23

28 Sep '23

Used in some .NET apps for theming purposes. -- v4: uxtheme: Add ShouldSystemUseDarkMode. https://gitlab.winehq.org/wine/wine/-/merge_requests/3959

3 3

[PATCH v3 0/1] MR3959: uxtheme: Add ShouldSystemUseDarkMode.
by Helix Graziani (＠TornadoCookie) 28 Sep '23

28 Sep '23

Used in some .NET apps for theming purposes. -- v3: uxtheme: Add ShouldSystemUseDarkMode. https://gitlab.winehq.org/wine/wine/-/merge_requests/3959

3 2

[PATCH v6 0/9] MR3953: dmusic: Implement SF2 collection parsing and load unix default-GM.sf2 for system gm.dls.
by Rémi Bernon (＠rbernon) 28 Sep '23

28 Sep '23

-- v6: dmusic: Implement SoundFont2 instrument parsing. dmusic: Implement SoundFont2 wave sample parsing. dmusic: Implement SoundFont2 collection parsing. dmusic: Avoid crashing in traces if wave doesn't have a WSMPL. dmusic: Avoid leaking articulations when freeing regions. dmloader: Add fallbacks if the configured GMFilePath doesn't exist. dmloader: Remove invalid default DLS collection check. dmusic/tests: Test default gm.dls sound font instruments. dmloader: Use a simpler file stream implementation. https://gitlab.winehq.org/wine/wine/-/merge_requests/3953

4 12

[PATCH v3 0/3] MR3424: msxml3: Add ValidateOnParse property support.
by Jactry Zeng (＠jactry) 28 Sep '23

28 Sep '23

-- v3: msxml3/tests: Add tests of ValidateOnParse property. msxml3: Add ValidateOnParse support for IXMLDOMDocument3_{get,set}Property(). msxml3: Store ValidateOnParse property in domdoc_properties instead. https://gitlab.winehq.org/wine/wine/-/merge_requests/3424

3 5

Re: [PATCH v3 0/7] MR3952: dmime: Test and fix performance initialization. - approved
by Alexandre Julliard (＠julliard) 28 Sep '23

28 Sep '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3952

1 0

Re: [PATCH v3 0/2] MR3972: include: Correct conflicting definitions of PSID and PSECURITY_DESCRIPTOR. - approved
by Alexandre Julliard (＠julliard) 28 Sep '23

28 Sep '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3972

1 0

Re: [PATCH v2 0/1] MR3978: tests: Update the documentation. - approved
by Alexandre Julliard (＠julliard) 28 Sep '23

28 Sep '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3978

1 0

Re: [PATCH v2 0/1] MR3977: secur32: Only return success from initialize_package() when initialization fully succeeds. - approved
by Alexandre Julliard (＠julliard) 28 Sep '23

28 Sep '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3977

1 0

Re: [PATCH v2 0/1] MR3976: include: Update the d3d12 header from vkd3d. - approved
by Alexandre Julliard (＠julliard) 28 Sep '23

28 Sep '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3976

1 0

Re: [PATCH v3 0/1] MR379: vkd3d: Add ID3D12Device5 interface stub. - approved
by Alexandre Julliard (＠julliard) 28 Sep '23

28 Sep '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/379

1 0

Re: [PATCH v2 0/3] MR378: vkd3d-shader/tpf: Replace sm4 register structs with vkd3d-shader register structs, part 3. - approved
by Alexandre Julliard (＠julliard) 28 Sep '23

28 Sep '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/378

1 0

Re: [PATCH v2 0/1] MR376: tests: Add some missing vkd3d_test_pop_context() calls to test_shader_instructions(). - approved
by Alexandre Julliard (＠julliard) 28 Sep '23

28 Sep '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/376

1 0

[PATCH v3 0/2] MR3806: combase: Create implicit MTA in STA apartment in RoGetActivationFactory().
by Paul Gofman (＠gofman) 28 Sep '23

28 Sep '23

Fixes Starfield not being able to take photos in photo mode (due to failing to creating windowscodecs' image factory due to COM apartment being initialized). Turns out on Windows RoGetActivationFactory() initializes implicit MTA apartment when called from STA thread, and so after that called once COM is implicitly uninitialized for any (new) thread until COM is uninitialized in the thread which called RoGetActivationFactory (or that thread exited). This is not the case on Win8 (where the function was first introduced) but looks consistent after that. -- v3: combase: Create implicit MTA in STA apartment in RoGetActivationFactory(). https://gitlab.winehq.org/wine/wine/-/merge_requests/3806

3 4

[PATCH v2 0/7] MR3952: dmime: Test and fix performance initialization.
by Rémi Bernon (＠rbernon) 28 Sep '23

28 Sep '23

Final Fantasy VIII does this, more or less, and needs Init to succeed. -- v2: dmime: Return DMUS_E_AUDIOPATH_INACTIVE when audio paths are not enabled. dmime: Return DMUS_E_AUDIOPATHS_IN_USE when audio paths are in use. dmime: Initialize performance in Init rather than InitAudio. dmime: Set the port direct sound before activating it. dmime/tests: Test performance Init with a created port. dmime/tests: Move performance tests into dmime.c. dmime/tests: Remove some duplicated tests. https://gitlab.winehq.org/wine/wine/-/merge_requests/3952

4 11

[PATCH v2 0/1] MR380: vkd3d-dxbc: Print section offsets.
by Giovanni Mascellani (＠giomasce) 28 Sep '23

28 Sep '23

-- v2: vkd3d-dxbc: Print section offsets. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/380

2 2

[PATCH v4 0/4] MR377: ci: Compile with -Werror.
by Giovanni Mascellani (＠giomasce) 28 Sep '23

28 Sep '23

Manually disable some warnings that are currently emitted. Eventually the warnings should be solved and -Werror should remain alone. -- v4: demos: Do not trigger -Wmissing-prototypes for wmain(). vkd3d: Use CONST_VTABLE. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/377

2 5

[PATCH v2 0/1] MR379: vkd3d: Add ID3D12Device5 interface stub.
by Andrey Gusev (＠agusev) 28 Sep '23

28 Sep '23

-- v2: vkd3d: Add ID3D12Device5 interface stub. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/379

3 2

[PATCH v4 0/8] MR372: vkd3d-shader/dxil: Read metadata and signatures.
by Conor McCarthy (＠cmccarthy) 28 Sep '23

28 Sep '23

-- v4: vkd3d-shader/dxil: Read the DXIL input and output signatures. vkd3d-shader/dxil: Validate the entry point info. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/372

4 16

[PATCH 0/3] MR378: vkd3d-shader/tpf: Replace sm4 register structs with vkd3d-shader register structs, part 3.
by Francisco Casas (＠fcasas) 28 Sep '23

28 Sep '23

-- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/378

4 7

[PATCH 0/1] MR376: tests: Add some missing vkd3d_test_pop_context() calls to test_shader_instructions().
by Henri Verbeet (＠hverbeet) 28 Sep '23

28 Sep '23

-- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/376

3 3

[PATCH 0/1] MR380: vkd3d-dxbc: Print section offsets.
by Giovanni Mascellani (＠giomasce) 28 Sep '23

28 Sep '23

-- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/380

3 2

[PATCH 0/1] MR379: vkd3d: Add ID3D12Device5 interface stub.
by Andrey Gusev (＠agusev) 28 Sep '23

28 Sep '23

-- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/379

3 2

[PATCH v3 0/4] MR377: ci: Compile with -Werror.
by Giovanni Mascellani (＠giomasce) 28 Sep '23

28 Sep '23

Manually disable some warnings that are currently emitted. Eventually the warnings should be solved and -Werror should remain alone. -- v3: demos: Do not trigger -Wmissing-prototypes for wmain(). https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/377

3 5

[PATCH v5 0/1] MR3966: mpr: WNetAddConnection*() and WNetCancelConnection*() always return success
by Alexey Alyaev (＠aalyaev) 28 Sep '23

28 Sep '23

- Changes to allow WNetAddConnection*() and WNetCancelConnection*() to succeed regardless of available providers (where none have been implemented yet). Allowing for manual configuration outside of wine. -- v5: mpr: WNetAddConnection*() and WNetCancelConnection*() always return success https://gitlab.winehq.org/wine/wine/-/merge_requests/3966

2 1

[PATCH 0/1] MR3971: gdiplus: Optimize GdipDrawImagePointsRect and GDI32_GdipDrawPath
by Bartosz Kosiorek (＠gang65) 28 Sep '23

28 Sep '23

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/3971

4 4

[PATCH v2 0/1] MR3974: winemac.drv: Ensure user-land callback can access app_icon results.
by eric pouech (＠epo) 28 Sep '23

28 Sep '23

Wine-Bugs: https://bugs.winehq.org/show_bug.cgi?id=55658 Signed-off-by: Eric Pouech <epouech(a)codeweavers.com> -- v2: winemac.drv: Ensure user-land callback can access app_icon results. https://gitlab.winehq.org/wine/wine/-/merge_requests/3974

3 5

[PATCH 0/1] MR3978: tests: Update the documentation.
by Francois Gouget (＠fgouget) 28 Sep '23

28 Sep '23

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/3978

2 2

[PATCH v64 0/6] MR2786: Add support for AF_UNIX sockets
by Ally Sommers (＠dropbear) 28 Sep '23

28 Sep '23

Windows 10 [received support](https://devblogs.microsoft.com/commandline/af_unix-comes-to-window… for AF_UNIX sockets in Insider Build 17063. This merge request adds basic support for AF_UNIX sockets to ws2_32 and wineserver. Of particular note is the difficulty in handling `sun_path`. Most of the functions that allow for translating Windows paths to Unix paths are not accessible from ws2_32. I considered the following options: * Pass the Windows path to wineserver and do the conversion there. * This is, as far as I can tell, not possible without major rearchitecting. wineserver does not have functions to translate Windows paths to Unix paths, for obvious reasons. * Obtain the current working directory of the requesting process and temporarily change directories to there. * This only handles relative paths and fails for absolute paths, UNC paths, etc. * Conditionally change directories based on whether the path is relative or not. * This is error-prone and wineserver does not have the requisite functions to do this cleanly. I ultimately decided to pass the translated Unix path to wineserver, which changes directories to `dirname(path)`. It then provides `bind` and `connect` with `basename(path)`. This is not threadsafe, but wineserver is not (currently) multithreaded. Abstract sockets are not fully supported by this patch, matching the behavior of Windows. -- v64: ws2_32/tests: Add test for AF_UNIX sockets. server: Fix getsockname() and accept() on AF_UNIX sockets. server: Introduce error when attempting to create a SOCK_DGRAM AF_UNIX socket. server: Allow for deletion of socket files. ws2_32: Add support for AF_UNIX sockets. https://gitlab.winehq.org/wine/wine/-/merge_requests/2786

3 7

[PATCH v63 0/6] MR2786: Add support for AF_UNIX sockets
by Ally Sommers (＠dropbear) 28 Sep '23

28 Sep '23

Windows 10 [received support](https://devblogs.microsoft.com/commandline/af_unix-comes-to-window… for AF_UNIX sockets in Insider Build 17063. This merge request adds basic support for AF_UNIX sockets to ws2_32 and wineserver. Of particular note is the difficulty in handling `sun_path`. Most of the functions that allow for translating Windows paths to Unix paths are not accessible from ws2_32. I considered the following options: * Pass the Windows path to wineserver and do the conversion there. * This is, as far as I can tell, not possible without major rearchitecting. wineserver does not have functions to translate Windows paths to Unix paths, for obvious reasons. * Obtain the current working directory of the requesting process and temporarily change directories to there. * This only handles relative paths and fails for absolute paths, UNC paths, etc. * Conditionally change directories based on whether the path is relative or not. * This is error-prone and wineserver does not have the requisite functions to do this cleanly. I ultimately decided to pass the translated Unix path to wineserver, which changes directories to `dirname(path)`. It then provides `bind` and `connect` with `basename(path)`. This is not threadsafe, but wineserver is not (currently) multithreaded. Abstract sockets are not fully supported by this patch, matching the behavior of Windows. -- v63: ws2_32/tests: Add test for AF_UNIX sockets. server: Fix getsockname() and accept() on AF_UNIX sockets. server: Introduce error when attempting to create a SOCK_DGRAM AF_UNIX socket. server: Allow for deletion of socket files. ws2_32: Add support for AF_UNIX sockets. ws2_32: Add afunix.h header. https://gitlab.winehq.org/wine/wine/-/merge_requests/2786

4 9

[PATCH 0/1] MR3977: secur32: Only return success from initialize_package() when initialization fully succeeds.
by Hans Leidekker (＠hans) 28 Sep '23

28 Sep '23

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=55522 -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3977

3 2

[PATCH v3 0/1] MR3966: mpr: WNetAddConnection*() and WNetCancelConnection*() always return success
by Alexey Alyaev (＠aalyaev) 28 Sep '23

28 Sep '23

- Changes to allow WNetAddConnection*() and WNetCancelConnection*() to succeed regardless of available providers (where none have been implemented yet). Allowing for manual configuration outside of wine. -- v3: mpr: WNetAddConnection*() and WNetCancelConnection*() always return success https://gitlab.winehq.org/wine/wine/-/merge_requests/3966

3 2

[PATCH v2 0/29] MR3966: mpr: WNetAddConnection*() and WNetCancelConnection*() always return success
by Alexey Alyaev (＠aalyaev) 28 Sep '23

28 Sep '23

- Changes to allow WNetAddConnection*() and WNetCancelConnection*() to succeed regardless of available providers (where none have been implemented yet). Allowing for manual configuration outside of wine. -- v2: winegstreamer: Also return output with 2 channels for multichannel inputs from AAC decoder. winegstreamer: Validate maximum channel count in _SetInputType in AAC decoder. winegstreamer: Correct output available types attrs in AAC decoder for channel count > 2. winegstreamer: Handle missing or zero channel count in _GetOutputAvailableType in AAC decoder. mf/tests: Add tests for AAC decoder with different input number of channels. winewayland.drv: Fix removal of wl_seat globals. winewayland.drv: Handle client-initiated user-driven window resize. winewayland.drv: Handle client-initiated user-driven window move. winewayland.drv: Handle xdg_toplevel maximized state. winewayland.drv: Handle xdg_toplevel configure event size hint. winewayland.drv: Handle xdg_toplevel close event. winewayland.drv: Remove wayland_surface destruction double locking. msado15: Update editMode in AddNew/Cancel/Update functions. msado15: _Recordset::Open store active connection parameter. msado15: Implement _Recordset::get_ActiveConnection. ntdll/tests: Skip FileLinkInformationEx tests on older Windows versions. ntdll/tests: Skip FileRenameInformationEx tests on older Windows versions. user32/tests: Use open_clipboard helper in msg tests. user32: Enable IsDialogMessageA() ASCII to Unicode mapping only when the user default lang ID is CJK. user32/tests: Fix test failures in Hindi UTF-8 and mixed locales. systeminfo: Add an implementation on top of WMI. wbemprox: Implement Win32_OperatingSystem.InstallDate. wbemprox: Fix Win32_OperatingSystem.TotalVirtual/VisibleMemorySize. wbemprox: Get Win32_OperatingSystem.BuildType from the registry. d3d10/tests: Test for correct return value. d3dx9: Trace pointer value in D3DXValidMesh(). include: Move RTL functions that belong in ntddk.h from winternl.h to ntddk.h. include: Add some structures in d3d12video.idl. This merge request has too many patches to be relayed via email. Please visit the URL below to see the contents of the merge request. https://gitlab.winehq.org/wine/wine/-/merge_requests/3966

1 0

[PATCH 0/1] MR3976: include: Update the d3d12 header from vkd3d.
by Martin Storsjö (＠mstorsjo) 28 Sep '23

28 Sep '23

This corresponds to vkd3d as of commit acd3ed97dc8e1ac192b2ec6fc19596831a6b61c6. The cpp_quoted #include directive is fixed up to match the file naming outside of vkd3d, renaming the reference to vkd3d_d3d12sdklayers.h back to d3d12sdklayers.h. This matches other renamings that are done at the start of the file for vkd3d renamed idl files as well. Signed-off-by: Martin Storsjö <martin(a)martin.st> -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3976

2 1

[PATCH v2 0/3] MR377: Draft: ci: Compile with -Werror.
by Giovanni Mascellani (＠giomasce) 28 Sep '23

28 Sep '23

Manually disable some warnings that are currently emitted. Eventually the warnings should be solved and -Werror should remain alone. -- v2: vkd3d: Always use CONST_VTABLE when including windows.h. ci: Store config.log as a build artifact. ci: Compile with -Werror. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/377

2 3

[PATCH 0/1] MR3974: winemac.drv: Ensure user-land callback can access app_icon results.
by eric pouech (＠epo) 28 Sep '23

28 Sep '23

Wine-Bugs: https://bugs.winehq.org/show_bug.cgi?id=55658 Signed-off-by: Eric Pouech <epouech(a)codeweavers.com> -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3974

3 3

[PATCH v2 0/1] MR371: vkd3d-shader/hlsl: Implement ternary operator for SM1.
by Nikolay Sivov (＠nsivov) 28 Sep '23

28 Sep '23

This is correct for pixel shaders, vertex shaders do not have 'cmp'. -- v2: vkd3d-shader/hlsl: Implement ternary operator for SM1. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/371

3 2

[PATCH v5 0/10] MR3953: dmusic: Implement SF2 collection parsing and load unix default-GM.sf2 for system gm.dls.
by Rémi Bernon (＠rbernon) 28 Sep '23

28 Sep '23

-- v5: dmusic: Implement SoundFont2 instrument parsing. dmusic: Implement SoundFont2 wave sample parsing. dmusic: Implement SoundFont2 collection parsing. dmusic: Avoid crashing in traces if wave doesn't have a WSMPL. dmusic: Avoid leaking articulations when freeing regions. dmloader: Add fallbacks if the configured GMFilePath doesn't exist. dmloader: Remove invalid default DLS collection check. dmusic/tests: Test default gm.dls sound font instruments. dmloader: Use a simpler file stream implementation. dmime/tests: Remove unnecessary SetObject call. https://gitlab.winehq.org/wine/wine/-/merge_requests/3953

3 11

[PATCH v17 0/4] MR346: tests/shader-runner: Test DXIL shaders.
by Conor McCarthy (＠cmccarthy) 28 Sep '23

28 Sep '23

This goes on top of MR 345. -- v17: tests/shader-runner: Test shaders with dxcompiler. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/346

2 4

[PATCH v2 0/2] MR3972: include: Correct conflicting definitions of PSID and PSECURITY_DESCRIPTOR.
by Alex Henrie (＠alexhenrie) 28 Sep '23

28 Sep '23

-- v2: include: Correct conflicting definition of PSECURITY_DESCRIPTOR. https://gitlab.winehq.org/wine/wine/-/merge_requests/3972

2 2

[PATCH 0/1] MR3972: include: Correct conflicting definition of PSID.
by Alex Henrie (＠alexhenrie) 28 Sep '23

28 Sep '23

In the Windows SDK, PSID is void* and PISID is SID*. Both types are defined in both winnt.h and wtypesbase.idl. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3972

2 1

[PATCH 0/1] MR3968: winegstreamer: Add hardware H264 decoding support
by Thong Thai (＠thongthai) 27 Sep '23

27 Sep '23

Signed-off-by: Thong Thai <thong.thai(a)amd.com> -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3968

3 3

[PATCH v3 0/1] MR3937: d3dx9_36: Trace pointer not the object
by Alistair Leslie-Hughes (＠alesliehughes) 27 Sep '23

27 Sep '23

-- v3: d3dx9: D3DXValidMesh - Trace pointer not the object https://gitlab.winehq.org/wine/wine/-/merge_requests/3937

2 2

[PATCH 0/1] MR377: Draft: ci: Compile with -Werror.
by Giovanni Mascellani (＠giomasce) 27 Sep '23

27 Sep '23

Manually disable some warnings that are currently emitted. Eventually the warnings should be solved and -Werror should remain alone. -- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/377

2 1

[PATCH v2 0/11] MR3907: ntdll: Initial implementation of File{Rename,Link}InformationEx
by Joel Holdsworth (＠jhol) 27 Sep '23

27 Sep '23

-- v2: ntdll: Add support for FILE_{RENAME,LINK}_POSIX_SEMANTICS. ntdll: Factored out get_inode_open_sharing ntdll/test: Add tests for FILE_LINK_POSIX_SEMANTICS. ntdll/test: Add tests for FILE_RENAME_POSIX_SEMANTICS. ntdll: Add support for FILE_{RENAME,LINK}_IGNORE_READONLY_ATTRIBUTE. server: Don't allow read-only files to be replaced by File{Rename,Link}Information{,Ex}. ntdll/test: Add tests for FILE_LINK_IGNORE_READONLY_ATTRIBUTE. ntdll/test: Add tests for FILE_RENAME_IGNORE_READONLY_ATTRIBUTE. ntdll/test: Use FileDispositionInformationEx to delete files and directories. ntdll: Initial implementation of FileLinkInformationEx. ntdll: Initial implementation of FileRenameInformationEx. https://gitlab.winehq.org/wine/wine/-/merge_requests/3907

3 12

Re: [PATCH v3 0/5] MR3884: winegstreamer/aac decoder: Correctly handle various number of channels in transform_GetOutputAvailableType(). - approved
by Alexandre Julliard (＠julliard) 27 Sep '23

27 Sep '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3884

1 0

Re: [PATCH v3 0/7] MR3909: winewayland.drv: part 7: Basic window management - approved
by Alexandre Julliard (＠julliard) 27 Sep '23

27 Sep '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3909

1 0

Re: [PATCH v2 0/3] MR3961: Msado15 Active connection - approved
by Alexandre Julliard (＠julliard) 27 Sep '23

27 Sep '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3961

1 0

Re: [PATCH v4 0/2] MR3926: Fix FileLinkInformationEx and FileRenameInformationEx test failures on older Windows versions. - approved
by Alexandre Julliard (＠julliard) 27 Sep '23

27 Sep '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3926

1 0

Re: [PATCH v2 0/1] MR3969: user32/tests: Use open_clipboard helper in msg tests. - approved
by Alexandre Julliard (＠julliard) 27 Sep '23

27 Sep '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3969

1 0

Re: [PATCH v2 0/2] MR3965: user32/tests: Fix test failures in Hindi UTF-8 and mixed locales. - approved
by Alexandre Julliard (＠julliard) 27 Sep '23

27 Sep '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3965

1 0

Re: [PATCH v2 0/4] MR3964: systeminfo: Add an implementation on top of WMI. - approved
by Alexandre Julliard (＠julliard) 27 Sep '23

27 Sep '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3964

1 0

Re: [PATCH v2 0/1] MR3962: d3d10/tests: Test for correct return value. - approved
by Alexandre Julliard (＠julliard) 27 Sep '23

27 Sep '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3962

1 0

Re: [PATCH v2 0/1] MR3963: d3dx9: Trace pointer value in D3DXValidMesh(). - approved
by Alexandre Julliard (＠julliard) 27 Sep '23

27 Sep '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3963

1 0

Re: [PATCH v3 0/1] MR3940: include: Move RTL functions that belong in ntddk.h from winternl.h to ntddk.h. - approved
by Alexandre Julliard (＠julliard) 27 Sep '23

27 Sep '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3940

1 0

Re: [PATCH v2 0/1] MR3960: include: Add some structures in d3d12video.idl. - approved
by Alexandre Julliard (＠julliard) 27 Sep '23

27 Sep '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3960

1 0

Re: [PATCH v3 0/1] MR374: vkd3d: Add ID3D12Device4 interface stub. - approved
by Alexandre Julliard (＠julliard) 27 Sep '23

27 Sep '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/374

1 0

Re: [PATCH v2 0/3] MR369: vkd3d-shader/d3d-asm: Minor disassembler fixes. - approved
by Alexandre Julliard (＠julliard) 27 Sep '23

27 Sep '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/369

1 0

Re: [PATCH v3 0/1] MR373: include: Add an #include of d3d12sdklayers.h in vkd3d_d3d12.idl - approved
by Alexandre Julliard (＠julliard) 27 Sep '23

27 Sep '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/373

1 0

Re: [PATCH v2 0/4] MR370: vkd3d-shader/tpf: Replace sm4 register structs with vkd3d-shader register structs, part 2. - approved
by Alexandre Julliard (＠julliard) 27 Sep '23

27 Sep '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/370

1 0

Re: [PATCH v8 0/2] MR362: ci: Build vkd3d with MinGW too. - approved
by Alexandre Julliard (＠julliard) 27 Sep '23

27 Sep '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/362

1 0

[PATCH 0/1] MR371: vkd3d-shader/hlsl: Implement ternary operator for SM1.
by Nikolay Sivov (＠nsivov) 27 Sep '23

27 Sep '23

This is correct for pixel shaders, vertex shaders do not have 'cmp'. -- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/371

3 4

2025

2024

2023

2022

wine-gitlab