- wine-gitlab - winehq.org

Re: [PATCH v4 0/3] MR3870: mspatcha: Add support for 32-bit file patching and normalization
by Zebediah Figura (＠zfigura) 18 Sep '23

18 Sep '23

Zebediah Figura (@zfigura) commented about dlls/mspatcha/pa19.c: > + return (WORD)(HIWORD(sum) + LOWORD(sum)); > +} > + > +/* Normalizes a given 32-bit PE image to render a stream that is common. */ > +int normalize_old_file_image( > + BYTE *old_file_buffer, ULONG old_file_size, > + ULONG option_flags, PATCH_OPTION_DATA *option_data, > + ULONG new_image_base, ULONG new_image_time, > + const PATCH_IGNORE_RANGE *ignore_range_array, ULONG ignore_range_count, > + const PATCH_RETAIN_RANGE *retain_range_array, ULONG retain_range_count) > +{ > + int result = 0; > + ULONG i; > + IMAGE_NT_HEADERS32 UNALIGNED *nt_headers; > + > + UNREFERENCED_PARAMETER(option_data); We don't need this. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3870#note_45761

1 0

Re: [PATCH v4 0/3] MR3870: mspatcha: Add support for 32-bit file patching and normalization
by Zebediah Figura (＠zfigura) 18 Sep '23

18 Sep '23

Zebediah Figura (@zfigura) commented about dlls/mspatcha/pa19.c: > + if (size_in_bytes & 1) { > + sum += *buffer; > + } > + > + return (WORD)(HIWORD(sum) + LOWORD(sum)); > +} > + > +/* Normalizes a given 32-bit PE image to render a stream that is common. */ > +int normalize_old_file_image( > + BYTE *old_file_buffer, ULONG old_file_size, > + ULONG option_flags, PATCH_OPTION_DATA *option_data, > + ULONG new_image_base, ULONG new_image_time, > + const PATCH_IGNORE_RANGE *ignore_range_array, ULONG ignore_range_count, > + const PATCH_RETAIN_RANGE *retain_range_array, ULONG retain_range_count) > +{ > + int result = 0; You defined symbolic constants; why not use them here? -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3870#note_45762

1 0

Re: [PATCH v4 0/3] MR3870: mspatcha: Add support for 32-bit file patching and normalization
by Zebediah Figura (＠zfigura) 18 Sep '23

18 Sep '23

Zebediah Figura (@zfigura) commented about dlls/mspatcha/pa19.c: > + ++import_desc; > + } > + } > + > + /* Mark the .idata section as writable */ > + section_table = IMAGE_FIRST_SECTION(nt_headers); > + section_count = nt_headers->FileHeader.NumberOfSections; > + for (ULONG i = 0; i < section_count; i++) > + { > + if ((PUCHAR)&section_table[i] < mapped_image > + || (PUCHAR)&section_table[i] > (mapped_image_end - sizeof(IMAGE_SECTION_HEADER))) { > + throw_pe_fmt_exception(); > + } > + > + /* tolower hack check for ".idata " */ > + if ((*((ULONGLONG UNALIGNED *)&section_table[i].Name) | 0x2020202020202020) == 0x202061746164692E) { Why is this a hack? (Why are we not doing a string comparison?) -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3870#note_45760

1 0

Re: [PATCH v4 0/3] MR3870: mspatcha: Add support for 32-bit file patching and normalization
by Zebediah Figura (＠zfigura) 18 Sep '23

18 Sep '23

Zebediah Figura (@zfigura) commented about dlls/mspatcha/pa19.c: > + } > + > + nt_headers->OptionalHeader.ImageBase = (DWORD)new_image_base; > + result = TRUE; > + > + reloc_dir_remaining = (LONG)reloc_dir_size; > + while (reloc_dir_remaining > 0) { > + > + if (reloc_block->SizeOfBlock <= (ULONG)reloc_dir_remaining > + && reloc_block->SizeOfBlock > sizeof(IMAGE_BASE_RELOCATION)) > + { > + reloc_block_base = (IMAGE_BASE_RELOCATION UNALIGNED *)(mapped_image_base + > + image_rva_to_file_offset(nt_headers, reloc_block->VirtualAddress, mapped_image_base, mapped_image_size)); > + if (reloc_block_base) > + { > + reloc = (USHORT UNALIGNED *)((PUCHAR)reloc_block + sizeof(IMAGE_BASE_RELOCATION)); I don't think we want UNALIGNED, not least because it doesn't do anything on non-MSVC compilers. If any of these actually can be unaligned (can they?) then I think we should just use memcpy. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3870#note_45759

1 0

Re: [PATCH v4 0/3] MR3870: mspatcha: Add support for 32-bit file patching and normalization
by Zebediah Figura (＠zfigura) 18 Sep '23

18 Sep '23

Zebediah Figura (@zfigura) commented about dlls/mspatcha/mspatcha_main.c: > { > - FIXME("stub - %p, %lu, %lx, %p, %lu, %lu, %lu, %p, %lu, %p\n", file_buffer, file_size, flags, options, new_coff_base, > - new_coff_time, ignore_range_count, ignore_range, retain_range_count, retain_range); > - SetLastError(ERROR_CALL_NOT_IMPLEMENTED); > - return 0; > + int result; > + > + result = normalize_old_file_image( > + file_buffer, file_size, > + option_flags, option_data, > + new_coff_base, new_coff_time, > + ignore_range_array, ignore_range_count, > + retain_range_array, retain_range_count); > + > + return result; > } The column limit is larger than 50 characters. No need to reflow to make it shorter. I'd advocate for keeping a trace in any API entry point. The 'result' variable is useless. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3870#note_45758

1 0

[PATCH v4 0/2] MR3259: Add environment variable to isolate WINEPREFIX at creation
by Fabian Maurer (＠DarkShadow44) 18 Sep '23

18 Sep '23

I'm aware that winecfg allows unlinking of symlinked folders, but this is very annoying when regularly recreating WINEPREFIXES. This change makes it easy to isolate those folders from the start. -- v4: ntdll: Add environment variable to prevent symlinking dosdevices/z: shell32: Add environment variable to prevent symlinking home folders https://gitlab.winehq.org/wine/wine/-/merge_requests/3259

2 2

[PATCH v5 0/2] MR3151: widl: Prevent infinite loop when structure contains array of itself
by Fabian Maurer (＠DarkShadow44) 18 Sep '23

18 Sep '23

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=55115 -- v5: widl: In type_has_full_pointer recurse for pointer types as well widl: Prevent infinite loop when structure contains array of itself https://gitlab.winehq.org/wine/wine/-/merge_requests/3151

2 3

[PATCH 0/11] MR3881: mshtml: Preparatory work for converting more node vtbl methods to dispex.
by Gabriel Ivăncescu (＠insn) 18 Sep '23

18 Sep '23

This is mostly just no-ops moving stuff around except for last patch, so they're in a consistent ordering for when we'll replace them to dispex vtbl methods, keeping those patches smaller and more obvious what they change. Next MR will convert query_interface (and maybe destructor, QI will need a bit more prep work first). -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3881

3 12

[PATCH v4 0/2] MR3151: widl: Prevent infinite loop when structure contains array of itself
by Fabian Maurer (＠DarkShadow44) 18 Sep '23

18 Sep '23

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=55115 -- v4: widl: In type_has_full_pointer recurse for pointer types as well widl: Prevent infinite loop when structure contains array of itself https://gitlab.winehq.org/wine/wine/-/merge_requests/3151

3 7

[PATCH 0/1] MR3875: msvcp110: Add _Winerror_map implementation.
by Piotr Caban (＠piotr) 18 Sep '23

18 Sep '23

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/3875

3 2

[PATCH v3 0/7] MR3851: dmime: Better implement DMUS_PMSG message processing.
by Rémi Bernon (＠rbernon) 18 Sep '23

18 Sep '23

-- v3: dmime: Pass the DMUS_PMSG through the performance graph. dmime: Rename DMUS_PMSGToItem to message_from_DMUS_PMSG. dmime: Remove unnecessary struct message members. dmime: Use a struct list to keep performance messages. dmime: Get rid of the DMUS_PMSGItem typedef. dmime: Convert DMUS_PMSG music and reference times in SendPMsg. dmime/tests: Test that SendPMsg also converts reference time. https://gitlab.winehq.org/wine/wine/-/merge_requests/3851

3 9

[PATCH 0/2] MR3882: msvcr110: Use Context blocking functions in _StructuredTaskCollection class.
by Piotr Caban (＠piotr) 18 Sep '23

18 Sep '23

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/3882

2 2

[PATCH v3 0/3] MR3870: mspatcha: Add support for 32-bit file patching and normalization
by Aidan Khoury (＠ajkhoury) 18 Sep '23

18 Sep '23

This clears up much of the todo list for mspatcha. GetFilePatchSignature* and NormalizeFileForPatchSignature have now been implemented in these changes. These changes bring better support for things like the Adobe Acrobat installer without the need for things like the winetricks mspatcha.dll native dll override. Still needed is support for interleaved streams in the LZXD decompression logic, however this is a great start to better supporting software installers that use the Windows interface for creating and applying patches to files. -- v3: Add vscode workspace setup https://gitlab.winehq.org/wine/wine/-/merge_requests/3870

3 4

[PATCH v5 0/1] MR3367: server: Ignore EADDRINUSE from listen() unless the provided socket is wildcarded.
by Ally Sommers (＠dropbear) 18 Sep '23

18 Sep '23

This fixes a `todo_wine` in ws2_32's socket tests. -- v5: server: Defer listens on addresses currently bound first by another socket. https://gitlab.winehq.org/wine/wine/-/merge_requests/3367

3 2

[PATCH v2 0/4] MR3836: Added definitions and initial tests for FileRenameInformationEx and FileLinkInformationEx
by Joel Holdsworth (＠jhol) 18 Sep '23

18 Sep '23

This patch-set adds the definitions and struct modifications required to eventually implement `FileRenameInformationEx` and `FileLinkInformationEx`. The initial tests are copies of the tests for `FileRenameInformation` and `FileLinkInformation`, but with the `ReplaceIfExists` field replaced with the equivalient `Flag` value: `FILE_RENAME_REPLACE_IF_EXISTS` or `FILE_LINK_REPLACE_IF_EXISTS` respectively. -- v2: ntdll/tests: Test both FileLinkInformation and FileLinkInformationEx in test_file_link_information. include: Add flags to FILE_LINK_INFORMATION used by FileLinkInformationEx. ntdll/tests: Test both FileRenameInformation and FileRenameInformationEx in test_file_rename_information. include: Add flags to FILE_RENAME_INFORMATION used by FileRenameInformationEx. https://gitlab.winehq.org/wine/wine/-/merge_requests/3836

4 8

[PATCH v3 0/2] MR3877: gdiplus: implement PixelOffsetMode Half and HighQuality for GdipDrawImagePointsRect
by Bartosz Kosiorek (＠gang65) 18 Sep '23

18 Sep '23

-- v3: gdiplus/tests: add tests of InterpolationMode Bilinear for GdipDrawImagePointsRect gdiplus: implement PixelOffsetMode Half and HighQuality for GdipDrawImagePointsRect https://gitlab.winehq.org/wine/wine/-/merge_requests/3877

3 3

[PATCH v2 0/1] MR3873: tools/winebuild: Force CIE content on x86_64.
by eric pouech (＠epo) 18 Sep '23

18 Sep '23

Force as to emit expected CIE/FDE information for x86_64 CPU in .debug_frame section. This has been unveiled by 425bd55b02e375b9ac8f79b254ce3ca5c9e72719 (before this commit, the .cfi directives where not emitted by winebuild). x86_64-w64-mingw32-as on x86_64 emits "strange" unwinding information (from winebuild). 00000000 0000000000000014 ffffffff CIE Version: 1 Augmentation: "" Code alignment factor: 1 Data alignment factor: -8 Return address column: 32 DW_CFA_def_cfa: r7 (rsp) ofs 8 DW_CFA_offset: r32 (xmm15) at cfa-8 DW_CFA_nop DW_CFA_nop DW_CFA_nop DW_CFA_nop DW_CFA_nop DW_CFA_nop Consequence: in unwinding, xmm15 gets updated, but rip isn't, causing an infinite loop in dbghelp. Wine-Bug-Id: https://bugs.winehq.org/show_bug.cgi?id=55560 Signed-off-by: Eric Pouech <epouech(a)codeweavers.com> -- v2: tools/winebuild: Emit SEH unwind information instead of dwarf. https://gitlab.winehq.org/wine/wine/-/merge_requests/3873

2 1

[PATCH v5 0/3] MR347: Fill in more missing details in d3d12.idl
by Martin Storsjö (＠mstorsjo) 18 Sep '23

18 Sep '23

-- v5: include: Add UUIDs for use with D3D12EnableExperimentalFeatures. include: Add the ID3D12GraphicsCommandList{5,6,7} interfaces. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/347

3 5

[PATCH 0/1] MR350: vkd3d-shader: Hide support for DXIL sources.
by Henri Verbeet (＠hverbeet) 18 Sep '23

18 Sep '23

-- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/350

2 2

[PATCH 0/1] MR3879: include: Add missing WinEvent definitions.
by Connor McAdams (＠cmcadams) 18 Sep '23

18 Sep '23

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/3879

2 1

[PATCH 0/1] MR3878: server: Return WSAEOPNOTSUPP on listen() if the socket's type is SOCK_DGRAM
by Ally Sommers (＠dropbear) 18 Sep '23

18 Sep '23

On Windows, `listen()` throws `WSAEOPNOTSUPP` when provided with a `SOCK_DGRAM` socket. Wine currently only throws `WSAEOPNOTSUPP` if the socket is bound; otherwise it throws `WSAEINVAL`. This patch modifies the `IOCTL_AFD_LISTEN` case in wineserver's `sock_ioctl()` throw `WSAEOPNOTSUPP` if it's passed an unbound `SOCK_DGRAM` socket. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3878

3 2

[PATCH v2 0/1] MR3877: gdiplus: implement PixelOffsetMode Half and HighQuality for GdipDrawImagePointsRect
by Bartosz Kosiorek (＠gang65) 18 Sep '23

18 Sep '23

-- v2: gdiplus: implement PixelOffsetMode Half and HighQuality for GdipDrawImagePointsRect https://gitlab.winehq.org/wine/wine/-/merge_requests/3877

3 2

[PATCH v4 0/1] MR3871: gdiplus: implement PixelOffsetMode Half and HighQuality for GdipDrawImagePointsRect
by Bartosz Kosiorek (＠gang65) 18 Sep '23

18 Sep '23

-- v4: gdiplus: implement PixelOffsetMode Half and HighQuality for GdipDrawImagePointsRect https://gitlab.winehq.org/wine/wine/-/merge_requests/3871

3 3

[PATCH 0/1] MR348: tests: Relax the precision of some tests so that they pass on MoltenVK.
by Giovanni Mascellani (＠giomasce) 18 Sep '23

18 Sep '23

-- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/348

3 2

[PATCH 0/1] MR3877: gdiplus: implement PixelOffsetMode Half and HighQuality for GdipDrawImagePointsRect
by Bartosz Kosiorek (＠gang65) 18 Sep '23

18 Sep '23

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/3877

3 2

[PATCH v4 0/3] MR347: Fill in more missing details in d3d12.idl
by Martin Storsjö (＠mstorsjo) 18 Sep '23

18 Sep '23

-- v4: include: Add UUIDs for use with D3D12EnableExperimentalFeatures. include: Add the ID3D12GraphicsCommandList{5,6,7} interfaces. include: Add DirectX 12 Agility SDK definitions. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/347

3 4

[PATCH v4 0/2] MR3877: gdiplus: implement PixelOffsetMode Half and HighQuality for GdipDrawImagePointsRect
by Bartosz Kosiorek (＠gang65) 18 Sep '23

18 Sep '23

-- v4: gdiplus/tests: add tests of InterpolationMode Bilinear for GdipDrawImagePointsRect https://gitlab.winehq.org/wine/wine/-/merge_requests/3877

2 2

[PATCH v3 0/4] MR3517: Fixes for GDI/GDI+ newline measurements.
by Torge Matthies (＠tmatthies) 18 Sep '23

18 Sep '23

-- v3: gdiplus: Include the newline in the measurement of each line. gdiplus/tests: Add test for bounds of newline. win32u: Detect and handle characters that are considered to have no width for GetTextExtentExPoint. gdi32/tests: Add test for width of carriage return and line feed. https://gitlab.winehq.org/wine/wine/-/merge_requests/3517

4 10

[PATCH v3 0/1] MR3871: gdiplus: implement PixelOffsetMode Half and HighQuality for GdipDrawImagePointsRect
by Bartosz Kosiorek (＠gang65) 18 Sep '23

18 Sep '23

-- v3: https://gitlab.winehq.org/wine/wine/-/merge_requests/3871

2 1

[PATCH v53 0/7] MR2786: Add support for AF_UNIX sockets
by Ally Sommers (＠dropbear) 18 Sep '23

18 Sep '23

Windows 10 [received support](https://devblogs.microsoft.com/commandline/af_unix-comes-to-window… for AF_UNIX sockets in Insider Build 17063. This merge request adds basic support for AF_UNIX sockets to ws2_32 and wineserver. Of particular note is the difficulty in handling `sun_path`. Most of the functions that allow for translating Windows paths to Unix paths are not accessible from ws2_32. I considered the following options: * Pass the Windows path to wineserver and do the conversion there. * This is, as far as I can tell, not possible without major rearchitecting. wineserver does not have functions to translate Windows paths to Unix paths, for obvious reasons. * Obtain the current working directory of the requesting process and temporarily change directories to there. * This only handles relative paths and fails for absolute paths, UNC paths, etc. * Conditionally change directories based on whether the path is relative or not. * This is error-prone and wineserver does not have the requisite functions to do this cleanly. I ultimately decided to pass the translated Unix path to wineserver, which changes directories to `dirname(path)`. It then provides `bind` and `connect` with `basename(path)`. This is not threadsafe, but wineserver is not (currently) multithreaded. Abstract sockets are not fully supported by this patch, matching the behavior of Windows. -- v53: ws2_32/tests: Add test for AF_UNIX sockets fix. server: Fix getsockname() and accept() on AF_UNIX sockets. server: Introduce error when attempting to create a SOCK_DGRAM AF_UNIX socket. server: Allow for deletion of socket files. ws2_32: Add support for AF_UNIX sockets. ntdll/unix: Add support for AF_UNIX sockets to multiple functions. ws2_32: Add afunix.h header. https://gitlab.winehq.org/wine/wine/-/merge_requests/2786

2 7

[PATCH 0/1] MR3872: msvcp110: Add _Winerror_map implementation.
by Myah Caron (＠qsniyg) 18 Sep '23

18 Sep '23

This MR fixes https://bugs.winehq.org/show_bug.cgi?id=55614 -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3872

4 5

[PATCH v7 0/5] MR3572: mf: Make session_get_node_object() more robust.
by Zhiyi Zhang (＠zhiyi) 18 Sep '23

18 Sep '23

It's possible that a state object pointer not in the topology node collection gets passed to session_get_node_object(). Instead of returning the last node when the object is not found, we should return a NULL so that the state of the last node is not changed by mistake. -- v7: mf/tests: Test IMFMediaSession::Start(). mf/tests: Add a create_test_topology() helper. mf: Add seeking support for IMFMediaSession::Start(). mf: Add a session_flush_nodes() helper. mf: Make session_get_node_object() more robust. https://gitlab.winehq.org/wine/wine/-/merge_requests/3572

3 6

[PATCH 0/1] MR3874: dbghelp: Check that dwarf unwinder did actually unwind.
by eric pouech (＠epo) 18 Sep '23

18 Sep '23

Wine-Bug-Id: https://bugs.winehq.org/show_bug.cgi?id=55560 Signed-off-by: Eric Pouech <epouech(a)codeweavers.com> -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3874

2 1

[PATCH 0/1] MR3873: tools/winebuild: Force CIE content on x86_64.
by eric pouech (＠epo) 18 Sep '23

18 Sep '23

Force as to emit expected CIE/FDE information for x86_64 CPU in .debug_frame section. This has been unveiled by 425bd55b02e375b9ac8f79b254ce3ca5c9e72719 (before this commit, the .cfi directives where not emitted by winebuild). x86_64-w64-mingw32-as on x86_64 emits "strange" unwinding information (from winebuild). 00000000 0000000000000014 ffffffff CIE Version: 1 Augmentation: "" Code alignment factor: 1 Data alignment factor: -8 Return address column: 32 DW_CFA_def_cfa: r7 (rsp) ofs 8 DW_CFA_offset: r32 (xmm15) at cfa-8 DW_CFA_nop DW_CFA_nop DW_CFA_nop DW_CFA_nop DW_CFA_nop DW_CFA_nop Consequence: in unwinding, xmm15 gets updated, but rip isn't, causing an infinite loop in dbghelp. Wine-Bug-Id: https://bugs.winehq.org/show_bug.cgi?id=55560 Signed-off-by: Eric Pouech <epouech(a)codeweavers.com> -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3873

2 1

[PATCH 0/3] MR3810: winegstreamer: Implement add_stream and push_sample for muxer.
by Ziqing Hui (＠zhui) 18 Sep '23

18 Sep '23

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/3810

4 39

[PATCH v3 0/3] MR347: Fill in more missing details in d3d12.idl
by Martin Storsjö (＠mstorsjo) 17 Sep '23

17 Sep '23

-- v3: include: Add UUIDs for use with D3D12EnableExperimentalFeatures. include: Add the ID3D12GraphicsCommandList{5,6,7} interfaces. include: Add DirectX 12 Agility SDK definitions. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/347

2 3

[PATCH v2 0/2] MR347: Fill in more missing details in d3d12.idl
by Martin Storsjö (＠mstorsjo) 17 Sep '23

17 Sep '23

-- v2: include: Add the ID3D12GraphicsCommandList{5,6,7} interfaces. include: Add DirectX 12 Agility SDK definitions. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/347

2 2

[PATCH 0/2] MR347: Fill in more missing details in d3d12.idl
by Martin Storsjö (＠mstorsjo) 17 Sep '23

17 Sep '23

-- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/347

2 2

[PATCH v2 0/3] MR3870: mspatcha: Add support for 32-bit file patching and normalization
by Aidan Khoury (＠ajkhoury) 17 Sep '23

17 Sep '23

This clears up much of the todo list for mspatcha. GetFilePatchSignature* and NormalizeFileForPatchSignature have now been implemented in these changes. These changes bring better support for things like the Adobe Acrobat installer without the need for things like the winetricks mspatcha.dll native dll override. Still needed is support for interleaved streams in the LZXD decompression logic, however this is a great start to better supporting software installers that use the Windows interface for creating and applying patches to files. -- v2: mspatcha: Add support for 32-bit file image patch transforms mspatcha: Add implementations for GetFilePatchSignature* routines mspatcha: Add support for 32-bit file normalizing https://gitlab.winehq.org/wine/wine/-/merge_requests/3870

4 6

[PATCH v2 0/2] MR3871: gdiplus: implement PixelOffsetMode Half and HighQuality for GdipDrawImagePointsRect
by Bartosz Kosiorek (＠gang65) 17 Sep '23

17 Sep '23

-- v2: gdiplus: fix destination area in GdipDrawImagePointsRect function gdiplus: implement PixelOffsetMode Half and HighQuality for GdipDrawImagePointsRect https://gitlab.winehq.org/wine/wine/-/merge_requests/3871

2 3

[PATCH 0/1] MR3871: gdiplus: implement PixelOffsetMode Half and HighQuality for GdipDrawImagePointsRect
by Bartosz Kosiorek (＠gang65) 17 Sep '23

17 Sep '23

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/3871

2 3

[PATCH 0/1] MR3870: mspatcha: Add support for 32-bit file patching and normalization
by Aidan Khoury (＠ajkhoury) 17 Sep '23

17 Sep '23

This clears up much of the todo list for mspatcha. GetFilePatchSignature* and NormalizeFileForPatchSignature have now been implemented in these changes. These changes bring better support for things like the Adobe Acrobat installer without the need for things like the winetricks mspatcha.dll native dll override. Still needed is support for interleaved streams in the LZXD decompression logic, however this is a great start to better supporting software installers that use the Windows interface for creating and applying patches to files. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3870

5 11

[PATCH v7 0/1] MR3865: gdiplus: implement PixelOffsetMode Half and HighQuality for GdipDrawImagePointsRect
by Bartosz Kosiorek (＠gang65) 17 Sep '23

17 Sep '23

-- v7: gdiplus: implement PixelOffsetMode Half and HighQuality for GdipDrawImagePointsRect https://gitlab.winehq.org/wine/wine/-/merge_requests/3865

3 10

[PATCH v2 0/7] MR3851: dmime: Better implement DMUS_PMSG message processing.
by Rémi Bernon (＠rbernon) 16 Sep '23

16 Sep '23

-- v2: dmime: Pass the DMUS_PMSG through the performance graph. dmime: Rename DMUS_PMSGToItem to impl_from_DMUS_PMSG. dmime: Remove unnecessary struct message members. dmime: Use a struct list to keep performance messages. dmime: Get rid of the DMUS_PMSGItem typedef. dmime: Convert DMUS_PMSG music and reference times in SendPMsg. dmime/tests: Test that SendPMsg also converts reference time. https://gitlab.winehq.org/wine/wine/-/merge_requests/3851

3 10

[PATCH 0/2] MR3866: gdiplus: Fix GdipCreateFont character set initialization.
by Jeffrey Smith (＠whydoubt) 16 Sep '23

16 Sep '23

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=34789 -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3866

3 3

Re: [PATCH v6 0/1] MR321: vkd3d-shader/hlsl: Implement intrinsic tan.
by Petrichor Park (＠petrathekat) 16 Sep '23

16 Sep '23

Oh dear. Do I need to worry about the big scary warning at the top saying that my merge failed? I don't think I did this right. -- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/321#note_45649

1 0

[PATCH 0/1] MR3869: dsound: Use malloc and free instead of _recalloc.
by Alex Henrie (＠alexhenrie) 16 Sep '23

16 Sep '23

The memory is completely overwritten a few lines later, so there is no reason to preserve its original contents. Furthermore, _recalloc will not be available if this DLL switches from ucrtbase to msvcrt, and the code as written would leak memory if _recalloc failed. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3869

2 1

[PATCH 0/1] MR3867: mfreadwrite/reader: Update to IMFSourceReaderEx.
by Nikolay Sivov (＠nsivov) 16 Sep '23

16 Sep '23

Signed-off-by: Nikolay Sivov <nsivov(a)codeweavers.com> -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3867

3 3

[PATCH v6 0/1] MR3865: gdiplus: implement PixelOffsetMode Half and HighQuality for GdipDrawImagePointsRect
by Bartosz Kosiorek (＠gang65) 16 Sep '23

16 Sep '23

-- v6: gdiplus: implement PixelOffsetMode Half and HighQuality for GdipDrawImagePointsRect https://gitlab.winehq.org/wine/wine/-/merge_requests/3865

3 2

[PATCH v5 0/1] MR3865: gdiplus: implement PixelOffsetMode Half and HighQuality for GdipDrawImagePointsRect
by Bartosz Kosiorek (＠gang65) 16 Sep '23

16 Sep '23

-- v5: gdiplus: implement PixelOffsetMode Half and HighQuality for GdipDrawImagePointsRect https://gitlab.winehq.org/wine/wine/-/merge_requests/3865

2 1

[PATCH v3 0/1] MR1170: wbemprox: Fix out-of-bounds access caused by codepoints above U+00FF.
by Jinoh Kang (＠iamahuman) 16 Sep '23

16 Sep '23

For now, assume all Unicode codepoints in range U+0100 - U+10FFFF constitute a valid identifier. Note that we already do that for range U+0080 - U+00FF. -- v3: wbemprox: Fix out-of-bounds access caused by codepoints above U+00FF. https://gitlab.winehq.org/wine/wine/-/merge_requests/1170

3 2

[PATCH 0/1] MR3859: d3d10/effect: Implement 'mov' opcode for expressions.
by Nikolay Sivov (＠nsivov) 16 Sep '23

16 Sep '23

Demo from https://bugs.winehq.org/show_bug.cgi?id=54468 is hitting this missing bit. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3859

3 2

[PATCH v4 0/1] MR3865: gdiplus: implement PixelOffsetMode Half and HighQuality for GdipDrawImagePointsRect
by Bartosz Kosiorek (＠gang65) 16 Sep '23

16 Sep '23

-- v4: gdiplus: implement PixelOffsetMode Half and HighQuality for GdipDrawImagePointsRect https://gitlab.winehq.org/wine/wine/-/merge_requests/3865

2 2

[PATCH v3 0/1] MR3865: gdiplus: implement PixelOffsetMode Half and HighQuality for GdipDrawImagePointsRect
by Bartosz Kosiorek (＠gang65) 16 Sep '23

16 Sep '23

-- v3: gdiplus: implement PixelOffsetMode Half and HighQuality for GdipDrawImagePointsRect https://gitlab.winehq.org/wine/wine/-/merge_requests/3865

2 1

[PATCH v2 0/1] MR3865: gdiplus: implement PixelOffsetMode Half and HighQuality for GdipDrawImagePointsRect
by Bartosz Kosiorek (＠gang65) 16 Sep '23

16 Sep '23

-- v2: gdiplus: implement PixelOffsetMode Half and HighQuality for GdipDrawImagePointsRect https://gitlab.winehq.org/wine/wine/-/merge_requests/3865

3 3

[PATCH v2 0/8] MR3852: dmusic: Parse instrument waves and download them to the port.
by Rémi Bernon (＠rbernon) 15 Sep '23

15 Sep '23

-- v2: dmusic: Implement instrument articulation downloads. dmusic: Parse instrument regions articulation lists. dmusic: Implement downloading wave to port. dmusic: Keep an internal ref on the instrument's collection. dmusic: Parse collection wave lists. dmusic: Parse collection wave table. dmusic: Rewrite downloading instrument to port. dmusic: Avoid swallowing collection Load failures. https://gitlab.winehq.org/wine/wine/-/merge_requests/3852

3 10

[PATCH 0/1] MR3865: gdiplus: implement PixelOffsetMode Half and HighQuality for GdipDrawImagePointsRect
by Bartosz Kosiorek (＠gang65) 15 Sep '23

15 Sep '23

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/3865

2 3

Re: [PATCH v6 0/1] MR722: wined3d:Set desc.depth To TRUE For Unrecognized Depth Buffer Type
by Alan Abdullah (＠Alan) 15 Sep '23

15 Sep '23

well well what a mess i made Am really sorry for the mess i made but i can't really work on this mess -- https://gitlab.winehq.org/wine/wine/-/merge_requests/722#note_45612

1 0

Re: [PATCH v6 0/1] MR722: wined3d:Set desc.depth To TRUE For Unrecognized Depth Buffer Type - closed
by Alan Abdullah (＠Alan) 15 Sep '23

15 Sep '23

This merge request was closed by Alan Abdullah. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/722

1 0

[PATCH 0/1] MR3861: gdiplus: Copy the compound array in GdipClonePen().
by Huw Davies (＠huw) 15 Sep '23

15 Sep '23

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/3861

3 5

[PATCH 0/3] MR3819: uiautomationcore: Implement UiaHasServerSideProvider.
by Connor McAdams (＠cmcadams) 15 Sep '23

15 Sep '23

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/3819

3 4

Re: [PATCH v2 0/1] MR3862: user32/tests: Ignore other messages in test_broadcast. - approved
by Alexandre Julliard (＠julliard) 15 Sep '23

15 Sep '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3862

1 0

Re: [PATCH v3 0/1] MR3591: http: Use CRT allocation functions. - approved
by Alexandre Julliard (＠julliard) 15 Sep '23

15 Sep '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3591

1 0

Re: [PATCH v3 0/1] MR3593: newdev: Use CRT allocation functions. - approved
by Alexandre Julliard (＠julliard) 15 Sep '23

15 Sep '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3593

1 0

Re: [PATCH v2 0/1] MR3860: dbghelp: Don't insert dwz file map into module's file maps' chain. - approved
by Alexandre Julliard (＠julliard) 15 Sep '23

15 Sep '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3860

1 0

Re: [PATCH v2 0/8] MR3858: mshtml: Traverse and unlink elements using the dispex vtbl, part 2. - approved
by Alexandre Julliard (＠julliard) 15 Sep '23

15 Sep '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3858

1 0

Re: [PATCH v3 0/1] MR3808: sensapi: Remove unnecessary includes. - approved
by Alexandre Julliard (＠julliard) 15 Sep '23

15 Sep '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3808

1 0

Re: [PATCH v5 0/11] MR3211: wined3d: Don't force going through a texture when downloading from renderbuffers. - approved
by Alexandre Julliard (＠julliard) 15 Sep '23

15 Sep '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3211

1 0

Re: [PATCH v4 0/2] MR3833: iphlpapi/tests: Quadruple the buffer size in a GetAdaptersAddresses() test. - approved
by Alexandre Julliard (＠julliard) 15 Sep '23

15 Sep '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3833

1 0

Re: [PATCH v2 0/2] MR3843: d3dx9: Handle special adjacency index value in d3dx9_mesh_OptimizeInplace(). - approved
by Alexandre Julliard (＠julliard) 15 Sep '23

15 Sep '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3843

1 0

Re: [PATCH v2 0/1] MR3841: wineps: Fix EMRPOLYDRAW16 printing. - approved
by Alexandre Julliard (＠julliard) 15 Sep '23

15 Sep '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3841

1 0

Re: [PATCH v2 0/1] MR3840: wineps: Remove dynamic glyph list. - approved
by Alexandre Julliard (＠julliard) 15 Sep '23

15 Sep '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3840

1 0

Re: [PATCH v2 0/1] MR3845: ntdll: Fix leave_handler for FreeBSD and NetBSD - approved
by Alexandre Julliard (＠julliard) 15 Sep '23

15 Sep '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3845

1 0

Re: [PATCH v2 0/1] MR3842: dsound: Get rid of the global device GUID arrays. - approved
by Alexandre Julliard (＠julliard) 15 Sep '23

15 Sep '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3842

1 0

Re: [PATCH v3 0/4] MR3848: wine{alsa,coreaudio,oss,pulse}: Ensure unixlib function tables and enum stay in sync. - approved
by Alexandre Julliard (＠julliard) 15 Sep '23

15 Sep '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3848

1 0

Re: [PATCH v2 0/1] MR3850: capi2032: Ensure unixlib function tables and enum stay in sync. - approved
by Alexandre Julliard (＠julliard) 15 Sep '23

15 Sep '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3850

1 0

Re: [PATCH v3 0/1] MR3849: netapi32: Ensure unixlib function tables and enum stay in sync. - approved
by Alexandre Julliard (＠julliard) 15 Sep '23

15 Sep '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3849

1 0

[PATCH 0/1] MR3864: wined3d: Pass a wined3d_stateblock_state to wined3d_device_validate_device().
by Zebediah Figura (＠zfigura) 15 Sep '23

15 Sep '23

I wrote this patch some time ago, and I'm not really sure why I did. I don't think it was necessary for any refactoring. Looking at it again, though, I think it does make sense. Device validation is a high-level operation, and I think it's clearer if we're checking the d3d states directly here. This also means we're not unnecessarily applying the stateblock here. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3864

2 1

[PATCH 0/3] MR3863: wined3d: Various stateblock refactoring.
by Zebediah Figura (＠zfigura) 15 Sep '23

15 Sep '23

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/3863

2 3

Re: [PATCH v2 0/1] MR3591: http: Use CRT allocation functions. - approved
by Zebediah Figura (＠zfigura) 15 Sep '23

15 Sep '23

This merge request was approved by Zebediah Figura. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3591

1 0

Re: [PATCH v2 0/1] MR3593: newdev: Use CRT allocation functions. - approved
by Zebediah Figura (＠zfigura) 15 Sep '23

15 Sep '23

This merge request was approved by Zebediah Figura. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3593

1 0

[PATCH 0/1] MR3856: wined3d: Don't validate the frontbuffer's DRAWABLE location in wined3d_swapchain_resize_buffers() when NO3D is set.
by Henri Verbeet (＠hverbeet) 15 Sep '23

15 Sep '23

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/3856

3 2

[PATCH 0/1] MR3853: d3drm: Correctly query for the returned interface
by Alistair Leslie-Hughes (＠alesliehughes) 15 Sep '23

15 Sep '23

IDirect3DRM2::CreateTextureFromSurface is expected to return an IDirect3DRMTexture2 object. The IDirect3DRMTexture* interfaces aren't derived from each other. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3853

3 2

[PATCH v2 0/3] MR3855: Fixes for ntlea
by Yuxuan Shui (＠yshui) 15 Sep '23

15 Sep '23

Make functions ntlea needs to patch hotpatchable. And add a asm wrapper for `GetWindowLongA` to workaround an assumption ntlea made. -- v2: user32: add hotpatchable wrapper for GetWindowLongA https://gitlab.winehq.org/wine/wine/-/merge_requests/3855

4 7

[PATCH 0/1] MR3846: winmm: Handle memory allocation failure in MMDRV_InitPerType (cppcheck).
by Alex Henrie (＠alexhenrie) 15 Sep '23

15 Sep '23

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/3846

4 6

[PATCH 0/8] MR3858: mshtml: Traverse and unlink elements using the dispex vtbl, part 2.
by Gabriel Ivăncescu (＠insn) 15 Sep '23

15 Sep '23

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/3858

4 10

[PATCH 0/4] MR3836: Added definitions and initial tests for FileRenameInformationEx and FileLinkInformationEx
by Joel Holdsworth (＠jhol) 15 Sep '23

15 Sep '23

This patch-set adds the definitions and struct modifications required to eventually implement `FileRenameInformationEx` and `FileLinkInformationEx`. The initial tests are copies of the tests for `FileRenameInformation` and `FileLinkInformation`, but with the `ReplaceIfExists` field replaced with the equivalient `Flag` value: `FILE_RENAME_REPLACE_IF_EXISTS` or `FILE_LINK_REPLACE_IF_EXISTS` respectively. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3836

4 10

[PATCH 0/1] MR3860: dbghelp: Don't insert dwz file map into module's file maps' chain.
by eric pouech (＠epo) 15 Sep '23

15 Sep '23

Signed-off-by: Eric Pouech <epouech(a)codeweavers.com> -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3860

2 1

[PATCH v4 0/2] MR283: ntdll: Filter EFlags from user-supplied CONTEXT on x86 and x64.
by Jinoh Kang (＠iamahuman) 15 Sep '23

15 Sep '23

-- v4: ntdll: Filter EFlags from user-supplied CONTEXT on x86 and x64. ntdll/tests: Test for setting x86 / x64 EFLAGS register in context. https://gitlab.winehq.org/wine/wine/-/merge_requests/283

2 2

[PATCH v2 0/4] MR3729: crypt32: Avoid truncating unicode chars.
by Dmitry Timoshkov (＠dmitry) 15 Sep '23

15 Sep '23

-- v2: cryptui: Use CertNameToStr(CERT_NAME_STR_NO_QUOTING_FLAG) to disable quoting. crypt32: Add support for CERT_NAME_STR_NO_QUOTING_FLAG to CertNameToStr(). crypt32/tests: Add some tests for quoted RDN values. crypt32: Avoid truncating unicode chars. https://gitlab.winehq.org/wine/wine/-/merge_requests/3729

2 4

[PATCH 0/12] MR346: Draft: tests/shader-runner: Test DXIL shaders.
by Conor McCarthy (＠cmccarthy) 15 Sep '23

15 Sep '23

This goes on top of MR 320 and 345. -- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/346

5 20

[PATCH v4 0/11] MR3211: wined3d: Don't force going through a texture when downloading from renderbuffers.
by Matteo Bruni (＠Mystral) 15 Sep '23

15 Sep '23

It can be unnecessary at best and unsupported at worst (e.g. no ARB_texture_multisample). -- v4: wined3d: Don't skip ARB fragment program selection when fog state is dirty. wined3d: Skip acquiring a context for an offscreen resource in texture2d_read_from_framebuffer(). wined3d: Don't force going through a texture when downloading from renderbuffers. wined3d: Handle depth textures in texture2d_read_from_framebuffer(). wined3d: Rename wined3d_context_gl_apply_fbo_state_blit() function. wined3d: Don't setup FBO and draw buffers in wined3d_context_gl_apply_blit_state(). wined3d: Don't call wined3d_texture_load() from wined3d_context_gl_apply_blit_state(). wined3d: Don't bind the FBO to GL_READ_FRAMEBUFFER in wined3d_context_gl_apply_blit_state(). wined3d: Prepare/load the destination resource location in arbfp_blitter_blit(). wined3d: Prepare/load the destination resource location in ffp_blitter_blit(). wined3d: Don't call wined3d_context_gl_apply_blit_state() from texture2d_read_from_framebuffer(). https://gitlab.winehq.org/wine/wine/-/merge_requests/3211

5 14

[PATCH 0/4] MR3729: crypt32: Avoid truncating unicode chars.
by Dmitry Timoshkov (＠dmitry) 15 Sep '23

15 Sep '23

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/3729

3 9

[PATCH 0/1] MR3854: winmm: Avoid use of hardcoded return values.
by Alistair Leslie-Hughes (＠alesliehughes) 15 Sep '23

15 Sep '23

Based on patch by Michael Müller. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3854

2 1

[PATCH 0/2] MR3843: d3dx9: Handle special adjacency index value in d3dx9_mesh_OptimizeInplace().
by Paul Gofman (＠gofman) 15 Sep '23

15 Sep '23

Avoid crash in d3dx9_mesh_OptimizeInplace(). -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3843

3 4

Re: [PATCH v4 0/1] MR3784: nsiproxy.sys: Implement ipv6_forward_enumerate_all.
by Huw Davies (＠huw) 15 Sep '23

15 Sep '23

Looks good. I've pointed out a few small corrections. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3784#note_45501

1 0

Re: [PATCH v4 0/1] MR3784: nsiproxy.sys: Implement ipv6_forward_enumerate_all.
by Huw Davies (＠huw) 15 Sep '23

15 Sep '23

Huw Davies (@huw) commented about dlls/nsiproxy.sys/ip.c: > + key_data = (BYTE *)key_data + key_size; > + rw_data = (BYTE *)rw_data + rw_size; > + dynamic_data = (BYTE *)dynamic_data + dynamic_size; > + static_data = (BYTE *)static_data + static_size; > + } > + num++; > + } > + fclose(fp); > + } > +#else > FIXME( "not implemented\n" ); > - *count = 0; > - return STATUS_SUCCESS; > + return STATUS_NOT_IMPLEMENTED; > +#endif > + There are some extraneous spaces on this line. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3784#note_45500

1 0

Re: [PATCH v4 0/1] MR3784: nsiproxy.sys: Implement ipv6_forward_enumerate_all.
by Huw Davies (＠huw) 15 Sep '23

15 Sep '23

Huw Davies (@huw) commented about dlls/nsiproxy.sys/ip.c: > + struct in6_addr prefix; > + UINT prefix_len; > + struct in6_addr next_hop; > + UINT metric; > + UINT protocol; > + BYTE loopback; > +}; > + > +static void ipv6_forward_fill_entry( struct ipv6_route_data *entry, struct nsi_ipv6_forward_key *key, > + struct nsi_ip_forward_rw *rw, struct nsi_ipv6_forward_dynamic *dyn, > + struct nsi_ip_forward_static *stat ) > +{ > + if (key) > + { > + key->unk = 0; > + memcpy( key->prefix.u.Byte, entry->prefix.s6_addr, 16 ); Please use something like `sizeof(entry->prefix)` instead of `16`. Also for `next_hop` below. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3784#note_45497

1 0

Re: [PATCH v4 0/1] MR3784: nsiproxy.sys: Implement ipv6_forward_enumerate_all.
by Huw Davies (＠huw) 15 Sep '23

15 Sep '23

Huw Davies (@huw) commented about dlls/nsiproxy.sys/ip.c: > + { > + memset( dyn, 0, sizeof(*dyn) ); > + } > + > + if (stat) > + { > + stat->origin = NlroManual; > + stat->if_index = entry->if_index; > + } > +} > + > +struct in6_addr str_to_in6_addr(char *nptr, char **endptr) > +{ > + struct in6_addr ret; > + > + for (int i = 0; i < 16; i++) Again something like `sizeof(ret)` instead of `16`. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3784#note_45498

1 0

Re: [PATCH v4 0/1] MR3784: nsiproxy.sys: Implement ipv6_forward_enumerate_all.
by Huw Davies (＠huw) 15 Sep '23

15 Sep '23

Huw Davies (@huw) commented about dlls/nsiproxy.sys/ip.c: > + } > + > + if (stat) > + { > + stat->origin = NlroManual; > + stat->if_index = entry->if_index; > + } > +} > + > +struct in6_addr str_to_in6_addr(char *nptr, char **endptr) > +{ > + struct in6_addr ret; > + > + for (int i = 0; i < 16; i++) > + { > + if (!isalnum( *nptr ) || !isalnum( *nptr+1 )) `isxdigit()`? Also, please add a space either side of the `+`. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3784#note_45499

1 0

2025

2024

2023

2022

wine-gitlab