- wine-gitlab - winehq.org

[PATCH 0/1] MR3791: widl: Add initial implementation of the SLTG typelib generator.
by Dmitry Timoshkov (＠dmitry) 11 Sep '23

11 Sep '23

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/3791

4 5

[PATCH v3 0/2] MR3372: ole32: Leave the RunningObjectTable Critical Section before unmarshalling object stream
by Lorenzo Ferrillo (＠llde) 11 Sep '23

11 Sep '23

In certain circumstances unmarshalling an object stream from the RunningObjectTable can cause the unmarshalling routines to interrogate the same table (maybe to resolve a dependant object?) in a different thread causing a deadlock while getting the critical section lock. Leaving the Critical Section before unmarshalling the object stream solve this problem. Visual Studio 2019 deadlock on start without this. I'm not sure how to test this properly. Also add debug info for this critical section so it show a significant name in the log. Signed-off-by: Lorenzo Ferrillo <lorenzofersteam(a)live.it> -- v3: ole32: Add debug info to RunningObjectTable critical section https://gitlab.winehq.org/wine/wine/-/merge_requests/3372

4 5

[PATCH 0/2] MR3789: Improve media session handling of unexpected errors.
by Santino Mazza (＠tati1454) 11 Sep '23

11 Sep '23

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/3789

3 3

[PATCH 0/11] MR3786: mshtml: Implement a unified QueryInterface on the dispex, part 3.
by Gabriel Ivăncescu (＠insn) 11 Sep '23

11 Sep '23

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/3786

3 12

[PATCH 0/1] MR3768: msxml3/tests: Fix failure messages.
by Daniel Lehman (＠dlehman25) 11 Sep '23

11 Sep '23

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/3768

3 3

[PATCH v6 0/11] MR317: vkd3d-shader: Begin validating the generated IR.
by Giovanni Mascellani (＠giomasce) 11 Sep '23

11 Sep '23

The validation code is meant both as a check that the frontend is behaving properly and as a sort of the documentation to establish what is allowed and what is not in the IR. ~~Currently an assertion is thrown if validation fails. I realize this is a rather strong proposal, but it's of course up for debate. In theory asserting here is the right thing, as it is expected that the frontend is generating correct IR code. However vkd3d is already used in production for many programs, and it could very well be that some of those are working properly even if the generated IR is somewhat out of specs; allowing the assertion might cause regressions as soon as enough checks are implemented in the validator. Please let me know your opinions.~~ **Solved in favor of a softer failure, and only when validation is enabled** -- v6: vkd3d-shader/ir: Validate source parameters. vkd3d-shader/ir: Validate destination parameters. vkd3d-shader/ir: Validate register types. vkd3d-shader/ir: Validate instruction handlers. vkd3d-shader/ir: Introduce a boilerplate to validate the generated IR. vkd3d-shader: Embed the parsing location in vkd3d_shader_instruction. vkd3d-shader/dxil: Destroy the SM6 parser on parsing errors. vkd3d-shader/tpf: Destroy the SM4 parser on parsing errors. vkd3d-shader/d3dbc: Destroy the SM1 parser on parsing errors. vkd3d-shader/d3dbc: Ignore DCL source parameters. vkd3d-shader/ir: Simplify the control flow in shader_instruction_normalise_io_params(). https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/317

3 17

[PATCH v2 0/1] MR336: vkd3d-shader/hlsl: Fix float modulus for vector arguments.
by Nikolay Sivov (＠nsivov) 11 Sep '23

11 Sep '23

Signed-off-by: Nikolay Sivov <nsivov(a)codeweavers.com> -- v2: vkd3d-shader/hlsl: Fix float modulus for vector arguments. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/336

3 7

[PATCH 0/5] MR334: hlsl: Replace bare list pointers with hlsl_block, part 9/9.
by Zebediah Figura (＠zfigura) 11 Sep '23

11 Sep '23

This is the last series I have to use hlsl_block instead of list manipulation. There is still some list manipulation around, but it's a little trickier to get rid of, and questionably worthwhile. At any rate things are a lot better now than they were. -- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/334

4 7

[PATCH v26 0/1] MR3074: Move getpeername() implementation to wineserver
by Ally Sommers (＠dropbear) 11 Sep '23

11 Sep '23

`getpeername()` is currently handled in ntdll. This merge request changes ntdll to forward `getpeername()` to wineserver. The implementation utilises new `peer_addr` and `peer_addr_len` fields in wineserver's `struct sock`. This fixes multiple `todo_wine`s in `ws2_32/tests` and allows for more accurate peer names to be provided in case the address the socket is bound to on the Unix side does not match what `bind()` was called with on the Windows side. *This merge request was originally intended to be included in !2786 (Add support for AF_UNIX sockets) but was split into its own merge request because this is not an insignificant change.* -- v26: server: Move getpeername() implementation from ntdll/unix. https://gitlab.winehq.org/wine/wine/-/merge_requests/3074

3 2

[PATCH 0/1] MR3630: msi: Use CreateFileW() for handling path from cabinet_open() instead.
by Jactry Zeng (＠jactry) 11 Sep '23

11 Sep '23

This fixes an issue while the path includes non-ASCII characters. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3630

3 6

Re: [PATCH v3 0/1] MR3777: gdi32: Add stub for D3DKMTQueryAdapterInfo.
by Jacek Caban (＠jacek) 11 Sep '23

11 Sep '23

On Mon Sep 11 08:05:33 2023 +0000, Etaash Mathamsetty wrote: > might have gotten the wow64 thunk wrong, so pls tell me how to fix it if > that's the case :) wow64 needs to be added to wow64win/syscall.h. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3777#note_44868

1 0

[PATCH v3 0/1] MR3767: msvcp110: Add std::_Throw_future_error.
by Daniel Lehman (＠dlehman25) 11 Sep '23

11 Sep '23

-- v3: msvcp110: Add std::_Throw_future_error. https://gitlab.winehq.org/wine/wine/-/merge_requests/3767

3 3

[PATCH v52 0/7] MR2786: Add support for AF_UNIX sockets
by Ally Sommers (＠dropbear) 11 Sep '23

11 Sep '23

Windows 10 [received support](https://devblogs.microsoft.com/commandline/af_unix-comes-to-window… for AF_UNIX sockets in Insider Build 17063. This merge request adds basic support for AF_UNIX sockets to ws2_32 and wineserver. Of particular note is the difficulty in handling `sun_path`. Most of the functions that allow for translating Windows paths to Unix paths are not accessible from ws2_32. I considered the following options: * Pass the Windows path to wineserver and do the conversion there. * This is, as far as I can tell, not possible without major rearchitecting. wineserver does not have functions to translate Windows paths to Unix paths, for obvious reasons. * Obtain the current working directory of the requesting process and temporarily change directories to there. * This only handles relative paths and fails for absolute paths, UNC paths, etc. * Conditionally change directories based on whether the path is relative or not. * This is error-prone and wineserver does not have the requisite functions to do this cleanly. I ultimately decided to pass the translated Unix path to wineserver, which changes directories to `dirname(path)`. It then provides `bind` and `connect` with `basename(path)`. This is not threadsafe, but wineserver is not (currently) multithreaded. Abstract sockets are not fully supported by this patch, matching the behavior of Windows. -- v52: ws2_32/tests: Add test for AF_UNIX sockets fix. server: Fix getsockname() and accept() on AF_UNIX sockets. server: Introduce error when attempting to create a SOCK_DGRAM AF_UNIX socket. server: Allow for deletion of socket files. ws2_32: Add support for AF_UNIX sockets. ntdll/unix: Add support for AF_UNIX sockets to multiple functions. ws2_32: Add afunix.h header. https://gitlab.winehq.org/wine/wine/-/merge_requests/2786

2 7

[PATCH 0/9] MR3782: dmime: Stub graph and tool interfaces for the performance.
by Rémi Bernon (＠rbernon) 10 Sep '23

10 Sep '23

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/3782

3 12

[PATCH 0/9] MR3781: dmusic: Begin cleanup parsing of collection instruments.
by Rémi Bernon (＠rbernon) 10 Sep '23

10 Sep '23

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/3781

3 10

[PATCH 0/2] MR3778: d3d8/tests: Try harder to drop focus in test_window_position.
by Stefan Dösinger (＠stefan) 10 Sep '23

10 Sep '23

This MR fixes this random failure: http://test.winehq.org/data/126363ea5f9056449e8bd22cc69b51bd2d7dd9aa/linux_… It happens mostly in d3d9, but if you try hard enough you can see it on d3d8 too. There are more random failures in test_window_position that I have seen when running on an actual display but not in a dummy X server or Xephyr. One failure mode is that we lose focus in the initial create_device and minimize ourselves. This particular problem is specific to focus follows mouse. Another is that fvwm seems to place the window slightly offscreen, maybe shifted by the size of the window decoration. I am still looking into those issues. Unrelated to test_windoow_position, there is at least one more random failure in test_wndproc (Test failed: Expected message 0x46 for window 0, but didn't receive it, i=0.), so expect more fvwm3 related MRs after this one... -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3778

3 5

[PATCH v2 0/2] MR3372: ole32: Leave the RunningObjectTable Critical Section before unmarshalling object stream
by Lorenzo Ferrillo (＠llde) 10 Sep '23

10 Sep '23

In certain circumstances unmarshalling an object stream from the RunningObjectTable can cause the unmarshalling routines to interrogate the same table (maybe to resolve a dependant object?) in a different thread causing a deadlock while getting the critical section lock. Leaving the Critical Section before unmarshalling the object stream solve this problem. Visual Studio 2019 deadlock on start without this. I'm not sure how to test this properly. Also add debug info for this critical section so it show a significant name in the log. Signed-off-by: Lorenzo Ferrillo <lorenzofersteam(a)live.it> -- v2: ole32: Add debug info to RunningObjectTable critical section ole32: Leave the RunningObjectTable Critical Section before umarshalling object https://gitlab.winehq.org/wine/wine/-/merge_requests/3372

2 2

[PATCH 0/2] MR3372: ole32: Leave the RunningObjectTable Critical Section before unmarshalling object stream
by Lorenzo Ferrillo (＠llde) 10 Sep '23

10 Sep '23

In certain circumstances unmarshalling an object stream from the RunningObjectTable can cause the unmarshalling routines to interrogate the same table (maybe to resolve a dependant object?) in a different thread causing a deadlock while getting the critical section lock. Leaving the Critical Section before unmarshalling the object stream solve this problem. Visual Studio 2019 deadlock on start without this. I'm not sure how to test this properly. Signed-off-by: Lorenzo Ferrillo <lorenzofersteam(a)live.it> -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3372

4 6

[PATCH v2 0/1] MR3767: msvcp110: Add std::_Throw_future_error.
by Daniel Lehman (＠dlehman25) 10 Sep '23

10 Sep '23

-- v2: msvcp110: Add std::_Throw_future_error. https://gitlab.winehq.org/wine/wine/-/merge_requests/3767

3 5

Re: [PATCH v3 0/2] MR3259: Add environment variable to isolate WINEPREFIX at creation
by Fabian Maurer (＠DarkShadow44) 09 Sep '23

09 Sep '23

Any news on this? -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3259#note_44835

1 0

[PATCH 0/1] MR3784: nsiproxy.sys: Implement ipv6_forward_enumerate_all.
by Helix Graziani (＠TornadoCookie) 09 Sep '23

09 Sep '23

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/3784

2 1

[PATCH v4 0/2] MR2740: winemenubuilder: Create .desktop files for programs that open URIs
by Alex Henrie (＠alexhenrie) 09 Sep '23

09 Sep '23

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=22904 -- v4: winecfg: Mention protocol associations. winemenubuilder: Create .desktop files for programs that open URIs. https://gitlab.winehq.org/wine/wine/-/merge_requests/2740

2 2

[PATCH 0/1] MR336: vkd3d-shader/hlsl: Fix float modulus for vector arguments.
by Nikolay Sivov (＠nsivov) 09 Sep '23

09 Sep '23

Signed-off-by: Nikolay Sivov <nsivov(a)codeweavers.com> -- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/336

2 1

[PATCH v2 0/1] MR3766: uninstaller: Don't overallocate in FetchFromRootKey.
by Alex Henrie (＠alexhenrie) 09 Sep '23

09 Sep '23

-- v2: uninstaller: Don't overallocate in FetchFromRootKey. https://gitlab.winehq.org/wine/wine/-/merge_requests/3766

2 1

[PATCH v6 0/4] MR3672: appxdeploymentclient: Add IPackageManager2 stub interface.
by Mohamad Al-Jaf (＠maljaf) 09 Sep '23

09 Sep '23

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=55403 -- v6: appxdeploymentclient: Add IPackageManager2 stub interface. include: Add Windows.Management.Deployment.IPackageManager2 interface definition. appxdeploymentclient: Implement IActivationFactory::ActivateInstance(). appxdeploymentclient: Add stub DLL. https://gitlab.winehq.org/wine/wine/-/merge_requests/3672

3 6

[PATCH v4 0/1] MR329: vkd3d-shader/hlsl: Add determinant() function.
by Nikolay Sivov (＠nsivov) 09 Sep '23

09 Sep '23

I wanted to use ._xy element access to make it shorter, but that attempt was crushed by the reality - such indexing apparently compiles but does not produce correct element access loads. I'm going to update once this is fixed. -- v4: vkd3d-shader/hlsl: Add determinant() function. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/329

2 1

[PATCH 0/1] MR3780: po: Update German translation.
by Julian Rüger (＠jrueger) 09 Sep '23

09 Sep '23

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/3780

2 1

[PATCH v2 0/2] MR3151: widl: Prevent infinite loop when structure contains array of itself
by Fabian Maurer (＠DarkShadow44) 09 Sep '23

09 Sep '23

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=55115 -- v2: widl: In type_has_full_pointer recurse for pointer types as well widl: Prevent infinite loop when structure contains array of itself https://gitlab.winehq.org/wine/wine/-/merge_requests/3151

2 2

[PATCH 0/1] MR3151: widl: Prevent infinite loop when structure contains array of itself
by Fabian Maurer (＠DarkShadow44) 09 Sep '23

09 Sep '23

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=55115 -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3151

3 6

Re: [PATCH 0/1] MR3777: gdi32: Add stub for D3DKMTQueryAdapterInfo.
by Etaash Mathamsetty (＠etaash.mathamsetty) 09 Sep '23

09 Sep '23

might have gotten the wow64 thunk wrong, so pls tell me how to fix it if that's the case :) -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3777#note_44800

1 0

[PATCH 0/1] MR3776: server: Support FileStandardInformation for pipes.
by Paul Gofman (＠gofman) 08 Sep '23

08 Sep '23

Crysis 3 Remastered (and 2 probably) in RT mode rely on GetFileSize() returning available read size (more exactly, correctly return 0 when no data is available) on pipe it uses to read the output from child dxc.exe process it creates (and hangs forever trying to read the pipe when we return INVALID_FILE_SIZE). While MSDN explicitly says that "You cannot use the GetFileSize function with a handle of a nonseeking device such as a pipe or a communications device.", if application dares GetFileSize (or NtQueryInformationFile(FileStandardInformation)) actually works for named and unnamed pipes. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3776

2 1

[PATCH 0/1] MR3766: uninstaller: Allocate space for null terminator in FetchFromRootKey.
by Alex Henrie (＠alexhenrie) 08 Sep '23

08 Sep '23

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/3766

2 2

Re: [PATCH v2 0/1] MR3775: server: Remove the fallback epoll() syscalls. - approved
by Alexandre Julliard (＠julliard) 08 Sep '23

08 Sep '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3775

1 0

Re: [PATCH v8 0/1] MR3744: dwrite: Treat null character as a C0 control character in script analyzer. - approved
by Alexandre Julliard (＠julliard) 08 Sep '23

08 Sep '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3744

1 0

Re: [PATCH v4 0/6] MR3753: dmsynth: Implement downloading of instruments and waves. - approved
by Alexandre Julliard (＠julliard) 08 Sep '23

08 Sep '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3753

1 0

Re: [PATCH v3 0/2] MR3755: win32u: Correct the packed size of WM_GETDLGCODE when lparam is NULL. - approved
by Alexandre Julliard (＠julliard) 08 Sep '23

08 Sep '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3755

1 0

Re: [PATCH v3 0/13] MR3773: mshtml: Implement a unified QueryInterface on the dispex, part 2. - approved
by Alexandre Julliard (＠julliard) 08 Sep '23

08 Sep '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3773

1 0

Re: [PATCH v2 0/1] MR3754: mshtml: Unstub some implemented event handlers in IHTMLWindow7 interface. - approved
by Alexandre Julliard (＠julliard) 08 Sep '23

08 Sep '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3754

1 0

Re: [PATCH v3 0/3] MR3771: srvsvc: Add LanmanServer stub service. - approved
by Alexandre Julliard (＠julliard) 08 Sep '23

08 Sep '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3771

1 0

Re: [PATCH v2 0/1] MR3772: ntdll: Store the codepage data addresses in both PEBs. - approved
by Alexandre Julliard (＠julliard) 08 Sep '23

08 Sep '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3772

1 0

Re: [PATCH v2 0/2] MR3769: ws2_32/tests: Call GetAdaptersAddresses() in a loop. - approved
by Alexandre Julliard (＠julliard) 08 Sep '23

08 Sep '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3769

1 0

Re: [PATCH v2 0/1] MR3770: include: Add IPackage2 definition in windows.applicationmodel.idl. - approved
by Alexandre Julliard (＠julliard) 08 Sep '23

08 Sep '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3770

1 0

Re: [PATCH v2 0/3] MR3746: test fixes for fvwm3 - approved
by Alexandre Julliard (＠julliard) 08 Sep '23

08 Sep '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3746

1 0

Re: [PATCH v2 0/1] MR3765: winemenubuilder: Use CRT allocation functions. - approved
by Alexandre Julliard (＠julliard) 08 Sep '23

08 Sep '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3765

1 0

Re: [PATCH v2 0/1] MR3764: wineboot: Use CRT allocation functions. - approved
by Alexandre Julliard (＠julliard) 08 Sep '23

08 Sep '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3764

1 0

Re: [PATCH v2 0/1] MR3763: oleview: Use CRT allocation functions. - approved
by Alexandre Julliard (＠julliard) 08 Sep '23

08 Sep '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3763

1 0

Re: [PATCH v2 0/1] MR3762: extrac32: Use CRT allocation functions. - approved
by Alexandre Julliard (＠julliard) 08 Sep '23

08 Sep '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3762

1 0

Re: [PATCH v2 0/1] MR3761: wintrust: Use CRT allocation functions. - approved
by Alexandre Julliard (＠julliard) 08 Sep '23

08 Sep '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3761

1 0

Re: [PATCH v2 0/1] MR3760: wintab32: Use CRT allocation functions. - approved
by Alexandre Julliard (＠julliard) 08 Sep '23

08 Sep '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3760

1 0

Re: [PATCH v8 0/1] MR3724: wldp: Add WldpQueryWindowsLockdownMode stub. - approved
by Alexandre Julliard (＠julliard) 08 Sep '23

08 Sep '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3724

1 0

Re: [PATCH v2 0/7] MR3751: dmime/tests: Test performance graph, tools and PMsg methods. - approved
by Alexandre Julliard (＠julliard) 08 Sep '23

08 Sep '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3751

1 0

Re: [PATCH v2 0/1] MR3719: d3d9/tests: Don't fail d3d9ex if the window manager restores focus too soon. - approved
by Alexandre Julliard (＠julliard) 08 Sep '23

08 Sep '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3719

1 0

[PATCH 0/2] MR331: vkd3d-shader/hlsl: Lower matrix swizzles.
by Francisco Casas (＠fcasas) 08 Sep '23

08 Sep '23

As @nsivov pointed out, we are currently parsing matrix swizzles (e.g. mat._m12_m32) and creating an hlsl_ir_swizzle for the matrix itself. We are currently allowing shaders that use these to compile even though they are not working. While our compilation passes don't expect hlsl_ir_swizzles with matrix values, turns out we need them as a parse-time construct because we don't know if they will be used as the lhs of an assignment during parsing, similarly to hlsl_ir_indexes. This patch adds tests and a pass to lower these matrix swizzles. Implementing assignments with matrix swizzles is still pending. -- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/331

4 6

[PATCH v3 0/1] MR3382: winebuild: Zero space between Wine signature and PE header in "builtin" files.
by Konstantin Demin (＠rockdrilla) 08 Sep '23

08 Sep '23

Signed-off-by: Konstantin Demin <rockdrilla(a)gmail.com> -- v3: winebuild: Zero space between Wine signature and PE header in "builtin" files. https://gitlab.winehq.org/wine/wine/-/merge_requests/3382

3 8

[PATCH 0/1] MR3535: ntdll: Take LARGE_ADDRESS_AWARE into account for userspace allocation limits.
by Billy Laws (＠bylaws) 08 Sep '23

08 Sep '23

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/3535

3 3

[PATCH 0/1] MR3775: server: Remove the fallback epoll() syscalls.
by Brendan Shanks (＠bshanks) 08 Sep '23

08 Sep '23

epoll was added to glibc 2.3.2, from 2003. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3775

3 2

[PATCH v7 0/1] MR3744: Draft: dwrite: Treat null character as a C0 control character in script analyzer.
by Jeffrey Smith (＠whydoubt) 08 Sep '23

08 Sep '23

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=55529 -- v7: dwrite: Treat null character as NO_VISUAL in script analyzer. https://gitlab.winehq.org/wine/wine/-/merge_requests/3744

3 3

[PATCH v3 0/3] MR3737: winegstreamer: Implement wg_muxer.
by Ziqing Hui (＠zhui) 08 Sep '23

08 Sep '23

This patch set is part of !3303 -- v3: winegstreamer: Create wg_muxer for media sink. winegstreamer: Implement seeking query for wg_muxer sink pad. winegstreamer: Introduce new wg_muxer struct. https://gitlab.winehq.org/wine/wine/-/merge_requests/3737

4 15

[PATCH v3 0/6] MR3753: dmsynth: Implement downloading of instruments and waves.
by Rémi Bernon (＠rbernon) 08 Sep '23

08 Sep '23

-- v3: dmsynth: Implement IDirectMusicSynth_Download for instrument articulations. dmsynth: Implement IDirectMusicSynth_Download for instrument regions. dmsynth: Implement IDirectMusicSynth_(Download|Unload) for waves. dmsynth: Implement IDirectMusicSynth_(Download|Unload) for instruments. dmusic: Avoid passing invalid handle to IDirectMusicSynth_Unload. dmsynth/tests: Test IDirectMusicSynth_Unload. https://gitlab.winehq.org/wine/wine/-/merge_requests/3753

3 8

[PATCH 0/1] MR3774: gdiplus/tests: extend DrawImage tests
by Bartosz Kosiorek (＠gang65) 08 Sep '23

08 Sep '23

With this commit we proof that PixelOffsetMode None and Fast is implemented correctly. By changing colour of second pixel of bitmap Source, the issues with pixel offset appear for PixelOffsetMode Half and HighQuality. Extending tests is starting point for further improvements of implementation pixel offset modes to match implementation from native gdiplus. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3774

3 4

[PATCH v2 0/2] MR3755: win32u: Correct the packed size of WM_GETDLGCODE when lparam is NULL.
by Tim Clem (＠tclem) 08 Sep '23

08 Sep '23

If lparam is null, the current code crashes when it hits the memcpy in pack_user_message. -- v2: win32u: Correct the packed size of WM_GETDLGCODE when lparam is NULL. win32u: Add a test for cross-process WM_GETDLGCODE with a NULL lparam. https://gitlab.winehq.org/wine/wine/-/merge_requests/3755

3 4

[PATCH v2 0/1] MR330: vkd3d-shader/hlsl: Add fwidth() function.
by Nikolay Sivov (＠nsivov) 08 Sep '23

08 Sep '23

Signed-off-by: Nikolay Sivov <nsivov(a)codeweavers.com> -- v2: vkd3d-shader/hlsl: Add fwidth() function. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/330

4 8

[PATCH v3 0/1] MR329: vkd3d-shader/hlsl: Add determinant() function.
by Nikolay Sivov (＠nsivov) 08 Sep '23

08 Sep '23

I wanted to use ._xy element access to make it shorter, but that attempt was crushed by the reality - such indexing apparently compiles but does not produce correct element access loads. I'm going to update once this is fixed. -- v3: vkd3d-shader/hlsl: Add determinant() function. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/329

5 12

[PATCH v2 0/13] MR3773: mshtml: Implement a unified QueryInterface on the dispex, part 2.
by Gabriel Ivăncescu (＠insn) 08 Sep '23

08 Sep '23

-- v2: mshtml: Use query_interface in the dispex vtbl for HTMLPluginsCollection. mshtml: Use query_interface in the dispex vtbl for HTMLNamespaceCollection. mshtml: Use query_interface in the dispex vtbl for HTMLMimeTypesCollection. mshtml: Use query_interface in the dispex vtbl for HTMLAttributeCollection. mshtml: Use query_interface in the dispex vtbl for HTMLFiltersCollection. mshtml: Use query_interface in the dispex vtbl for HTMLRectCollection. mshtml: Use query_interface in the dispex vtbl for HTMLElementCollection. mshtml: Use query_interface in the dispex vtbl for HTMLDOMChildrenCollection. mshtml: Use query_interface in the dispex vtbl for StyleSheetRules and mshtml: Use query_interface in the dispex vtbl for CSS Styles. mshtml: Use query_interface in the dispex vtbl for HTMLStorage. mshtml: Use query_interface in the dispex vtbl for HTMLLocation. mshtml: Use query_interface in the dispex vtbl for builtin constructors. https://gitlab.winehq.org/wine/wine/-/merge_requests/3773

3 14

[PATCH 0/16] MR3773: mshtml: Implement a unified QueryInterface on the dispex, part 2.
by Gabriel Ivăncescu (＠insn) 08 Sep '23

08 Sep '23

-- This merge request has too many patches to be relayed via email. Please visit the URL below to see the contents of the merge request. https://gitlab.winehq.org/wine/wine/-/merge_requests/3773

2 3

[PATCH 0/1] MR3772: ntdll: Store the codepage data addresses in both PEBs.
by Huw Davies (＠huw) 08 Sep '23

08 Sep '23

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/3772

2 1

[PATCH v2 0/5] MR3686: winewayland.drv: part 6: Handle wl_pointer (mouse) events.
by Alexandros Frantzis (＠afrantzis) 08 Sep '23

08 Sep '23

This MR adds support for handling `wl_pointer` devices: 1. Handle enter/leave/(absolute) motion/button/axis events to allow users to interact with applications using such devices, e.g., a mouse. 2. Update the cursor image used for Wayland surfaces based on the Windows cursor bitmap data. A few notes: 1. A single `wl_seat`/`wl_pointer` is supported for now. 2. Many of the input interactions require window management support that hasn't been implemented yet (e.g., popup positioning, resizing, max/fullscreen). 3. There is some potential for bad interactions between the input event dispatching mechanism and the `win32u` flushing logic for `window_surface` , which can lead to visual glitches. Although I don't think this is blocker for this MR, I would like to start a discussion about the problem and mitigation ideas in a [comment](https://gitlab.winehq.org/wine/wine/-/merge_requests/3686#note_438… below. Thanks! -- v2: winewayland.drv: Implement SetCursor using cursor bitmap data. winewayland.drv: Handle pointer button and scroll events. winewayland.drv: Handle pointer motion events. winewayland.drv: Handle pointer focus events. https://gitlab.winehq.org/wine/wine/-/merge_requests/3686

3 12

[PATCH 0/1] MR3754: mshtml: Unstub some implemented event handlers in IHTMLWindow7 interface.
by Gabriel Ivăncescu (＠insn) 08 Sep '23

08 Sep '23

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/3754

4 3

[PATCH v2 0/3] MR3771: srvsvc: Add LanmanServer stub service.
by Dmitry Timoshkov (＠dmitry) 08 Sep '23

08 Sep '23

-- v2: srvsvc: Add LanmanServer stub service. wevtsvc: Remove duplicate dwControlsAccepted initialization. schedsvc: Remove duplicate dwControlsAccepted initialization. https://gitlab.winehq.org/wine/wine/-/merge_requests/3771

2 3

[PATCH 0/1] MR3755: win32u: Correct the packed size of WM_GETDLGCODE when lparam is NULL.
by Tim Clem (＠tclem) 08 Sep '23

08 Sep '23

If lparam is null, the current code crashes when it hits the memcpy in pack_user_message. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3755

3 2

[PATCH 0/3] MR3771: srvsvc: Add LanmanServer stub service.
by Dmitry Timoshkov (＠dmitry) 08 Sep '23

08 Sep '23

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/3771

3 4

[PATCH 0/1] MR3770: include: Add IPackage2 definition in windows.applicationmodel.idl.
by Biswapriyo Nath (＠Biswa96) 08 Sep '23

08 Sep '23

Required for GNOME/glib project. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3770

3 2

[PATCH 0/3] MR3746: test fixes for fvwm3
by Stefan Dösinger (＠stefan) 08 Sep '23

08 Sep '23

These tests make the ddraw-d3d9 tests pass inside Xephyr with fvwm3 for me. fvwm3 still randomly fails in a lot of places if it is run on a real display. It also fails in Xephyr if I wiggle the mouse too much. Those two issues might even be related. A virtual X server should be enough for CI though. fvwm2 has a lot of random failures even inside Xephyr or xf86-video-dummy. I will not attempt to fix them. I tested the SW_SHOWMINNOACTIVE in patches 2 and 3 on Windows XP, Windows 11, the testbot, kwin, openbox. It seems to work without breaking any of those systems. With those things being flaky changes though I can never fully gurantee this though. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3746

5 8

[PATCH v2 0/3] MR3737: winegstreamer: Implement wg_muxer.
by Ziqing Hui (＠zhui) 08 Sep '23

08 Sep '23

This patch set is part of !3303 -- v2: winegstreamer: Create wg_muxer for media sink. winegstreamer: Implement seeking query for wg_muxer sink pad. winegstreamer: Introduce new wg_muxer struct. https://gitlab.winehq.org/wine/wine/-/merge_requests/3737

3 7

[PATCH 0/1] MR3767: msvcp110: Add std::_Throw_future_error.
by Daniel Lehman (＠dlehman25) 08 Sep '23

08 Sep '23

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/3767

3 2

[PATCH 0/2] MR3769: ws2_32/tests: Call GetAdaptersAddresses() in a loop.
by Hans Leidekker (＠hans) 08 Sep '23

08 Sep '23

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/3769

2 2

Re: [PATCH v5 0/4] MR3672: appxdeploymentclient: Add IPackageManager2 stub interface.
by Rémi Bernon (＠rbernon) 08 Sep '23

08 Sep '23

On Fri Sep 8 06:44:32 2023 +0000, Mohamad Al-Jaf wrote: > I've removed it, seems like it's not really necessary to test for it. > Though, I don't understand why Office queries for `IAgileObject`. It's a > Microsoft program so they should know it's not supported. Minecraft also > queries for an interface that returns `E_NOINTERFACE`, it seems bizarre. You should still remove the `broken(...)` condition, it will otherwise let every test succeed silently on Windows. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3672#note_44665

1 0

Re: [PATCH v3 0/27] MR332: include: Fill in missing enum/struct/interfaces in vkd3d_d3d12.idl
by Martin Storsjö (＠mstorsjo) 08 Sep '23

08 Sep '23

On Fri Sep 8 06:50:30 2023 +0000, Henri Verbeet wrote: > At first sight this looks fine, thanks. Unfortunately I probably won't > be able to properly review this this week, but I should be able to get > to it early next week. > Note that this currently fails the CI though. Probably because it's > intended to be applied on top of !325, so hopefully that will get > resolved once those patches actually get committed. It still fails CI after !325 was merged (and even before - as it was based on top of !325, those commits were part of this branch so testing would just have iterated over those too) - not quite sure what is wrong here... -- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/332#note_44664

1 0

Re: [PATCH v5 0/4] MR3672: appxdeploymentclient: Add IPackageManager2 stub interface.
by Mohamad Al-Jaf (＠maljaf) 08 Sep '23

08 Sep '23

On Thu Sep 7 13:49:19 2023 +0000, Rémi Bernon wrote: > I missed this before, but I think the check_interface check is a bit > pointless as it will always succeed on Windows. > Something like that would be better (using `check_interface_broken` only > where it is needed): > ```suggestion:-14+0 > #define check_interface_broken( obj, iid, supported ) check_interface_( > __LINE__, obj, iid, supported, TRUE ) > #define check_interface( obj, iid, supported ) check_interface_( > __LINE__, obj, iid, supported, FALSE ) > static void check_interface_( unsigned int line, void *obj, const IID > *iid, BOOL supported, BOOL is_broken ) > { > HRESULT hr, expected_hr, broken_hr; > IUnknown *iface = obj; > IUnknown *unk; > expected_hr = supported ? S_OK : E_NOINTERFACE; > broken_hr = supported ? E_NOINTERFACE : S_OK; > hr = IUnknown_QueryInterface( iface, iid, (void **)&unk ); > ok_(__FILE__, line)( hr == expected_hr || broken( is_broken && hr == > broken_hr ), "got hr %#lx.\n", hr ); > if (SUCCEEDED(hr)) IUnknown_Release( unk ); > } > ``` > Or, maybe even better, use the basic `check_interface`, without the > broken result and remove the broken check for IAgileObject interface > which probably doesn't really matter on the factory. I've removed it, seems like it's not really necessary to test for it. Though, I don't understand why Office queries for `IAgileObject`. It's a Microsoft program so they should know it's not supported. Minecraft also queries for an interface that returns `E_NOINTERFACE`, it seems bizarre. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3672#note_44663

1 0

[PATCH v4 0/4] MR3672: appxdeploymentclient: Add IPackageManager2 stub interface.
by Mohamad Al-Jaf (＠maljaf) 08 Sep '23

08 Sep '23

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=55403 -- v4: appxdeploymentclient: Add IPackageManager2 stub interface. include: Add Windows.Management.Deployment.IPackageManager2 interface definition. appxdeploymentclient: Implement IActivationFactory::ActivateInstance(). appxdeploymentclient: Add stub DLL. https://gitlab.winehq.org/wine/wine/-/merge_requests/3672

2 4

[PATCH 0/3] MR3737: winegstreamer: Implement wg_muxer.
by Ziqing Hui (＠zhui) 08 Sep '23

08 Sep '23

This patch set is part of !3303 -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3737

4 15

[PATCH 0/1] MR3765: winemenubuilder: Use CRT allocation functions.
by Alex Henrie (＠alexhenrie) 08 Sep '23

08 Sep '23

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/3765

2 1

[PATCH 0/1] MR3764: wineboot: Use CRT allocation functions.
by Alex Henrie (＠alexhenrie) 08 Sep '23

08 Sep '23

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/3764

2 1

[PATCH 0/1] MR3763: oleview: Use CRT allocation functions.
by Alex Henrie (＠alexhenrie) 08 Sep '23

08 Sep '23

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/3763

2 1

[PATCH 0/1] MR3762: extrac32: Use CRT allocation functions.
by Alex Henrie (＠alexhenrie) 08 Sep '23

08 Sep '23

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/3762

2 1

[PATCH 0/1] MR3761: wintrust: Use CRT allocation functions.
by Alex Henrie (＠alexhenrie) 08 Sep '23

08 Sep '23

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/3761

2 1

[PATCH 0/1] MR3760: wintab32: Use CRT allocation functions.
by Alex Henrie (＠alexhenrie) 07 Sep '23

07 Sep '23

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/3760

2 1

[PATCH v2 0/6] MR3753: dmsynth: Implement downloading of instruments and waves.
by Rémi Bernon (＠rbernon) 07 Sep '23

07 Sep '23

-- v2: dmsynth: Implement IDirectMusicSynth_Download for instrument articulations. dmsynth: Implement IDirectMusicSynth_Download for instrument regions. dmsynth: Implement IDirectMusicSynth_(Download|Unload) for waves. dmsynth: Implement IDirectMusicSynth_(Download|Unload) for instruments. dmusic: Avoid passing invalid handle to IDirectMusicSynth_Unload. dmsynth/tests: Test IDirectMusicSynth_Unload. https://gitlab.winehq.org/wine/wine/-/merge_requests/3753

3 8

[PATCH v2 0/1] MR3758: ntoskrnl/tests: Use wine/test.h in the driver tests.
by Rémi Bernon (＠rbernon) 07 Sep '23

07 Sep '23

-- v2: ntoskrnl/tests: Use wine/test.h in the driver tests. https://gitlab.winehq.org/wine/wine/-/merge_requests/3758

3 2

[PATCH 0/7] MR3751: dmime/tests: Test performance graph, tools and PMsg methods.
by Rémi Bernon (＠rbernon) 07 Sep '23

07 Sep '23

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/3751

3 8

[PATCH 0/2] MR3759: dinput/tests: Report the driver success and skipped tests counters.
by Rémi Bernon (＠rbernon) 07 Sep '23

07 Sep '23

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=55535 -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3759

3 3

[PATCH v2 0/27] MR332: include: Fill in missing enum/struct/interfaces in vkd3d_d3d12.idl
by Martin Storsjö (＠mstorsjo) 07 Sep '23

07 Sep '23

This goes on top of !325 (which was already approved). -- v2: include: Add some misc D3D12 structs/enums. include: Add some D3D12 raytracing specific structs. include: Add the D3D12_BARRIER_GROUP struct. include: Add the ID3D12Tools interface. include: Add the ID3D12VirtualizationGuestDevice interface. include: Add the ID3D12Device10 interface. include: Add the ID3D12Device9 interface. include: Add the ID3D12ShaderCacheSession interface. include: Add the ID3D12GraphicsCommandList4 interface. include: Add the ID3D12MetaCommand interface. include: Add the ID3D12Heap1 interface. include: Add the ID3D12Resource{1,2} interfaces. include: Add the ID3D12Device8 interface. include: Add the structs D3D12_FEATURE_DATA_D3D12_OPTIONS{6,7}. include: Add the ID3D12Device7 interface. include: Add the ID3D12ProtectedResourceSession1 interface. include: Add the ID3D12Device6 interface. include: Add the ID3D12DeviceRemovedExtendedData{,1,2} interfaces. include: Add the ID3D12DeviceRemovedExtendedDataSettings{,1} interfaces. include: Add the ID3D12Device5 interface. include: Add the ID3D12StateObjectProperties interface. include: Add the ID3D12StateObject interface. include: Add the ID3D12LifetimeTracker interface. include: Add the ID3D12SwapChainAssistant interface. include: Add the ID3D12LifetimeOwner interface. include: Add the ID3D12Device4 interface. include: Add the ID3D12PipelineLibrary{,1} interfaces. This merge request has too many patches to be relayed via email. Please visit the URL below to see the contents of the merge request. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/332

1 0

Re: [PATCH v3 0/1] MR3758: ntoskrnl/tests: Use wine/test.h in the driver tests. - approved
by Alexandre Julliard (＠julliard) 07 Sep '23

07 Sep '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3758

1 0

Re: [PATCH v2 0/2] MR3759: dinput/tests: Report the driver success and skipped tests counters. - approved
by Alexandre Julliard (＠julliard) 07 Sep '23

07 Sep '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3759

1 0

[PATCH 0/4] MR3757: Fix Windows XP d3d test crashes
by Stefan Dösinger (＠stefan) 07 Sep '23

07 Sep '23

This series fixes a few bugs in the d3d tests that cause them to crash on my Windows XP laptop with the r200 GPU (dx8 era). There are plenty more problems on this GPU on Windows. d3d8:visual hangs the entire system. d3d9:device has some failing tests. d3d9:visual crashes, which is probably good because otherwise it would also cause a kernel panic. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3757

4 8

Re: [PATCH v2 0/3] MR3756: wtsapi32: Improve WTSEnumerateSessions and WTSQuerySessionInformation. - approved
by Alexandre Julliard (＠julliard) 07 Sep '23

07 Sep '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3756

1 0

Re: [PATCH v4 0/6] MR3723: mshtml: Implement a unified QueryInterface on the dispex, part 1. - approved
by Alexandre Julliard (＠julliard) 07 Sep '23

07 Sep '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3723

1 0

Re: [PATCH v2 0/1] MR3730: comctl32: Use iswalnum() to filter alpha numeric characters from unicode messages. - approved
by Alexandre Julliard (＠julliard) 07 Sep '23

07 Sep '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3730

1 0

Re: [PATCH v2 0/4] MR3749: wsdapi: Call GetAdaptersAddresses() in a loop. - approved
by Alexandre Julliard (＠julliard) 07 Sep '23

07 Sep '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3749

1 0

Re: [PATCH v4 0/2] MR3733: urlmon: test using http protocol through CreateBinding - approved
by Alexandre Julliard (＠julliard) 07 Sep '23

07 Sep '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3733

1 0

2025

2024

2023

2022

wine-gitlab