- wine-gitlab - winehq.org

Re: [PATCH v3 0/5] MR3572: mf: Make session_get_node_object() more robust.
by Zhiyi Zhang (＠zhiyi) 20 Aug '23

20 Aug '23

> Actually, did you test this with a custom source? No. I will look into that. Thanks. > depending on a the player state it's either Stop->Start->Pause or Stop->Start IMFMediaSession::Start() always starts the session though. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3572#note_42793

1 0

[PATCH v2 0/1] MR3403: server: Revert "server: Avoid using SOL_IPX to detect whether IPX is supported."
by Fotios Valasiadis (＠fvalasiad) 20 Aug '23

20 Aug '23

This reverts commit 41cc117b3f37ab4b9b4ac8a815cd2a496d38fb4b. This commit broke musl support. With the changes introduced, the following code evaluates to the #else branch without checking for SO_DEFAULT_HEADERS resulting in an error. server/sock.c +1888 ``` \#ifdef HAS_IPX int ipx_type = protocol - WS_NSPROTO_IPX; \#ifdef SOL_IPX setsockopt( sockfd, SOL_IPX, IPX_TYPE, &ipx_type, sizeof(ipx_type) ); \#else struct ipx val; /* Should we retrieve val using a getsockopt call and then * set the modified one? */ val.ipx_pt = ipx_type; setsockopt( sockfd, 0, SO_DEFAULT_HEADERS, &val, sizeof(val) ); \#endif \#endif ``` I propose reverting the commit, but we could probably alter the macro in the code section provided to match the changes relevant github issue: https://github.com/void-linux/void-packages/pull/45202 Signed-off-by: Fotios Valasiadis <fvalasiad(a)gmail.com> -- v2: server: Check for SO_DEFAULT_HEADERS before using it. https://gitlab.winehq.org/wine/wine/-/merge_requests/3403

4 10

Re: [PATCH v3 0/5] MR3572: mf: Make session_get_node_object() more robust.
by Nikolay Sivov (＠nsivov) 20 Aug '23

20 Aug '23

Actually, did you test this with a custom source? What I see on Windows is that Start(new_position): * stops the source; * flushes; * starts again with new position. I noticed this extra stop when I tried mfplay API to see what SetPosition() is doing - depending on a the player state it's either Stop->Start->Pause or Stop->Start. Turns out this might be what session does internally. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3572#note_42791

1 0

[PATCH v3 0/2] MR3525: ntdll: allow NULL timeout in NtCreateNamedPipeFile.
by Etaash Mathamsetty (＠etaash.mathamsetty) 20 Aug '23

20 Aug '23

Saw that this was allowed on MSDN and checked with a windows machine -- v3: ntdll/tests: Add NULL timeout test for NtCreateNamedPipeFile. https://gitlab.winehq.org/wine/wine/-/merge_requests/3525

2 3

[PATCH v10 0/1] MR3581: gdiplus: add support for GdipPathIterNextPathType
by Bartosz Kosiorek (＠gang65) 19 Aug '23

19 Aug '23

I have covered implementation with additional test cases. -- v10: gdiplus: add support for GdipPathIterNextPathType https://gitlab.winehq.org/wine/wine/-/merge_requests/3581

3 3

[PATCH 0/1] MR3603: windowscodecs: Use CRT allocation functions.
by Alex Henrie (＠alexhenrie) 19 Aug '23

19 Aug '23

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/3603

3 2

[PATCH 0/1] MR3611: gdiplus: set Tahoma font in case MS Sans Serif is missing
by Bartosz Kosiorek (＠gang65) 18 Aug '23

18 Aug '23

It seems that Tahoma is better replacement than Arial in Wine, even if it is implemented in that way in native library. Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=55421 -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3611

2 1

Re: [PATCH v4 0/1] MR3598: ntdll: Add error and warning logs in more cases of memory exhaustion. - approved
by Alexandre Julliard (＠julliard) 18 Aug '23

18 Aug '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3598

1 0

Re: [PATCH v3 0/4] MR3538: wined3d: Move zero swapchain parameter fixup to wined3d_swapchain_state_init. - approved
by Alexandre Julliard (＠julliard) 18 Aug '23

18 Aug '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3538

1 0

Re: [PATCH v4 0/1] MR3608: mshtml: Check for non-NULL plugin host before trying to hold ref. - approved
by Alexandre Julliard (＠julliard) 18 Aug '23

18 Aug '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3608

1 0

Re: [PATCH v2 0/1] MR3609: wow64: Add BT module thread termination callback. - approved
by Alexandre Julliard (＠julliard) 18 Aug '23

18 Aug '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3609

1 0

Re: [PATCH v4 0/1] MR3583: wldap32: Map LDAP_OPT_AUTO_RECONNECT to LDAP_OPT_RESTART and add tests. - approved
by Alexandre Julliard (＠julliard) 18 Aug '23

18 Aug '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3583

1 0

Re: [PATCH v2 0/1] MR3604: find: Use CRT allocation functions. - approved
by Alexandre Julliard (＠julliard) 18 Aug '23

18 Aug '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3604

1 0

Re: [PATCH v2 0/1] MR3601: oledb32: Use CRT allocation functions. - approved
by Alexandre Julliard (＠julliard) 18 Aug '23

18 Aug '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3601

1 0

Re: [PATCH v2 0/1] MR3600: shell32: Combine the two strdupAtoW functions. - approved
by Alexandre Julliard (＠julliard) 18 Aug '23

18 Aug '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3600

1 0

[PATCH v6 0/5] MR3418: Add tryok() for tests that sometimes get outside interference.
by Francois Gouget (＠fgouget) 18 Aug '23

18 Aug '23

This is meant to simplify testing conditions that generally hold true but may occasionally fail due to interference from external factors (such as processes that start / stop, network connections being opened / closed, etc). The trick is loop a few times on the set of flaky conditions until they succeed. During the last attempt all failures are recorded as usual, while in the previous runs, tryok() failures are ignored but cause one more attempt to be run. The simplest case looks like this: LOOP_ON_FLAKY_TESTS(3) { // ok() failures are never ignored and not retried ok(..., "check 1", ...); // tryok() failures are ignored except on the last attempt tryok(..., "check 2", ...); } There is also: * attempt_retry() which indicate a new attempt is needed without counting as a failure, and returns true if a new attempt is possible. * attempt_failed() which returns true if the current attempt failed. --- This is independent from the 'flaky' mechanism which adds some naming constraints. The loop macro is still called LOOP_ON_FLAKY_TESTS() despite being unrelated to the flaky mechanism. The attempt_retry() and attempt_failed() macro names also don't make it obvious that they are related to tryok(). I think this mechanism is better than the flaky one because a flaky test can go bad without anyone noticing, whereas if a tryok() starts failing systematically it will cause a real failure. The other side of that coin is that, unlike flaky, the tryok() mechanism does not entirely eliminate the possibility of getting a failure, it just reduces it; though by adjusting the maximum number of attempts one can achieve an arbitrarily low failure rate. For instance if an ok() call fails 10% of the time and one wants a maximum of 1 in a million failure rate, use LOOP_ON_FLAKY_TESTS(6). The cost is an increased run time in the worst case. This also limits the use of this mechanism to tests that have a reasonably low failure rate to start with (otherwise one has to loop too many times). Also note that there are cases where looping essentially reduce the failure rate to zero. For instance ieframe:webbrowser fails if IE creates a net session while the test is counting them. But IE only creates the one net session on start up so trying even one more time should guarantee that the test will succeed. Other cases like scheduling delays and the creation of network connections are more probabilistic in nature. Maybe a comment in test.h should offer some guideline as to the target failure rate. Eventually this may replace the flaky mechanism but that depends on how well it works in practice and how practical it is to loop on flaky tests. It seems to be going well in the cases I looked at. I think this mechanism has value even if the two end up coexisting indefinitely. In addition to introducing the framework, this MR patches some tests to use uses the tryok() mechanism for illustration and testing purposes. There are more places where this mechanism could be used but I think it's best to see about those later to keep this MR simple and focused on the new mechanism. -- v6: advapi32/tests: Replace the custom loop with the tryok() mechanism. ntdll/tests: Use tryok() to fix a free disk space race with other processes. kernel32/tests: Use tryok() to fix a heap race with other processes. tests: Add tryok() for tests that sometimes get outside interference. tests: Update the documentation. https://gitlab.winehq.org/wine/wine/-/merge_requests/3418

2 7

[PATCH v2 0/4] MR3538: wined3d: Move zero swapchain parameter fixup to wined3d_swapchain_state_init.
by Stefan Dösinger (＠stefan) 18 Aug '23

18 Aug '23

--- Note that this code never runs in d3d10+ for a 0 pixelformat. Dxgi/tests/dxgi.c:2032 has a test that shows it results in an error. -- v2: dxgi/tests: Test swapchains with zero dimensions. wined3d: Move zero swapchain parameter fixup to wined3d_swapchain_state_init. wined3d: Make wined3d_swapchain_desc in wined3d_swapchain_create const. dxgi: Read back the swapchain size assigned by wined3d. https://gitlab.winehq.org/wine/wine/-/merge_requests/3538

4 6

[PATCH 0/2] MR3610: cmd: DIR command outputs free space for the path.
by Akihiro Sagawa (＠sgwaki) 18 Aug '23

18 Aug '23

When the path contains a mountpoint on Unix or a junction point to another drive on Windows, cmd.exe should show free space for the path instead of the root of the drive. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3610

2 2

Re: [PATCH v3 0/5] MR3572: mf: Make session_get_node_object() more robust.
by Nikolay Sivov (＠nsivov) 18 Aug '23

18 Aug '23

On Fri Aug 18 02:25:13 2023 +0000, Zhiyi Zhang wrote: > Doesn't the current MR contain only mf changes? Sure, my comment was for initial patchset. I probably finalized comment/review too late, making this confusing. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3572#note_42739

1 0

[PATCH 0/13] MR3597: mshtml: Implement Cycle Collection for all mshtml objects (dispex), part 5.
by Gabriel Ivăncescu (＠insn) 18 Aug '23

18 Aug '23

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/3597

3 20

[PATCH v3 0/1] MR3608: mshtml: Check for non-NULL plugin host before trying to hold ref.
by James Beddek (＠telans) 18 Aug '23

18 Aug '23

This fixes a regression caused by https://gitlab.winehq.org/wine/wine/-/commit/08dc691dfb410de7115db3f9c34b22… making Robot Battle 1.4 crash on startup. Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=55457 Signed-off-by: James Beddek <telans(a)posteo.de> -- v3: mshtml: Check for non-NULL plugin host before trying to hold ref. https://gitlab.winehq.org/wine/wine/-/merge_requests/3608

4 4

Re: [PATCH v2 0/1] MR3608: mshtml: check for err before trying to hold plugin host ref
by Gabriel Ivăncescu (＠insn) 18 Aug '23

18 Aug '23

Gabriel Ivăncescu (@insn) commented about dlls/mshtml/npplugin.c: > } > > instance->pdata = container->plugin_host; > - IOleClientSite_AddRef(&container->plugin_host->IOleClientSite_iface); > + if(!err) > + IOleClientSite_AddRef(&container->plugin_host->IOleClientSite_iface); I'd personally check for `container->plugin_host` being non-NULL here instead of checking for err, but it doesn't really matter, depends how Jacek feels about it. Minor nitpick: Please capitalize first word in the commit title (`check`→`Check`) and add a period at the end. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3608#note_42721

1 0

[PATCH v3 0/3] MR3563: server: Symlink CurrentControlSet to ControlSet001
by Torge Matthies (＠tmatthies) 18 Aug '23

18 Aug '23

Signed-off-by: Torge Matthies <openglfreak(a)googlemail.com> -- v3: loader: Add Default, Failed, and LastKnownGood values to HKLM\System\Select. server: Create link from HKLM\System\CurrentControlSet to ControlSet001. advapi32/tests: Add test for CurrentControlSet link. https://gitlab.winehq.org/wine/wine/-/merge_requests/3563

2 3

[PATCH 0/5] MR3607: apisetschema: Add ext-ms-win-dxcore-l1-1-0.
by Mohamad Al-Jaf (＠maljaf) 18 Aug '23

18 Aug '23

Needed by Affinity Photo. The headers are needed for MinGW. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3607

3 10

[PATCH 0/1] MR3609: wow64: Add BT module thread termination callback.
by Billy Laws (＠bylaws) 18 Aug '23

18 Aug '23

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/3609

2 1

[PATCH v3 0/1] MR3583: wldap32: Map LDAP_OPT_AUTO_RECONNECT to LDAP_OPT_RESTART and add tests.
by Alex Henrie (＠alexhenrie) 18 Aug '23

18 Aug '23

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=55450 -- v3: wldap32: Map LDAP_OPT_AUTO_RECONNECT to LDAP_OPT_RESTART and add tests. https://gitlab.winehq.org/wine/wine/-/merge_requests/3583

3 2

[PATCH 0/1] MR3608: mshtml: check for err before trying to hold plugin host ref
by James Beddek (＠telans) 18 Aug '23

18 Aug '23

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=55457 Signed-off-by: James Beddek <telans(a)posteo.de> -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3608

2 1

[PATCH v9 0/1] MR3581: gdiplus: add support for GdipPathIterNextPathType
by Bartosz Kosiorek (＠gang65) 18 Aug '23

18 Aug '23

I have covered implementation with additional test cases. -- v9: gdiplus: add support for GdipPathIterNextPathType https://gitlab.winehq.org/wine/wine/-/merge_requests/3581

2 1

[PATCH v8 0/1] MR3581: gdiplus: add support for GdipPathIterNextPathType
by Bartosz Kosiorek (＠gang65) 18 Aug '23

18 Aug '23

I have covered implementation with additional test cases. -- v8: gdiplus: add support for GdipPathIterNextPathType https://gitlab.winehq.org/wine/wine/-/merge_requests/3581

2 1

[PATCH v7 0/1] MR3581: gdiplus: add support for GdipPathIterNextPathType
by Bartosz Kosiorek (＠gang65) 18 Aug '23

18 Aug '23

I have covered implementation with additional test cases. -- v7: gdiplus: add support for GdipPathIterNextPathType https://gitlab.winehq.org/wine/wine/-/merge_requests/3581

2 1

[PATCH 0/9] MR3605: include: Add WinRT IPackageManager / IPackage3 definitions.
by Rémi Bernon (＠rbernon) 18 Aug '23

18 Aug '23

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/3605

2 9

[PATCH v3 0/1] MR3573: winex11.drv: Mark drawable as dirty when setting pixel format.
by Anton Baskanov (＠baskanov) 18 Aug '23

18 Aug '23

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=55341 -- v3: winex11.drv: Mark drawable as dirty when setting pixel format. https://gitlab.winehq.org/wine/wine/-/merge_requests/3573

2 2

[PATCH v8 0/5] MR3103: server: Create and use a desktop shared mapping for GetCursorPos.
by Rémi Bernon (＠rbernon) 18 Aug '23

18 Aug '23

First part of Proton shared memory series. The full branch can be seen at https://gitlab.winehq.org/rbernon/wine/-/commits/mr/shared-memories. -- v8: user32: Use the desktop shared data for GetCursorPos(). server: Add a sequence number to the shared data. server: Move the cursor position and last change time to the shared data. server: Use the helper to update the cursor last change time. server: Create a desktop shared mapping. https://gitlab.winehq.org/wine/wine/-/merge_requests/3103

2 6

[PATCH 0/1] MR3604: find: Use CRT allocation functions.
by Alex Henrie (＠alexhenrie) 18 Aug '23

18 Aug '23

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/3604

2 1

[PATCH 0/1] MR3601: oledb32: Use CRT allocation functions.
by Alex Henrie (＠alexhenrie) 18 Aug '23

18 Aug '23

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/3601

2 1

[PATCH 0/1] MR3600: shell32: Combine the two strdupAtoW functions.
by Alex Henrie (＠alexhenrie) 18 Aug '23

18 Aug '23

I figured it would be easier to make this change before converting the rest of the DLL to use CRT allocation functions. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3600

2 1

[PATCH v3 0/16] MR3303: Draft: winegstreamer: Implement wg_muxer
by Ziqing Hui (＠zhui) 18 Aug '23

18 Aug '23

Still working in progress. -- v3: winegstreamer: Implement finalize for media sink. winestreamer: Implement wg_muxer_finalize. winegstreamer: Introduce media_sink_write_stream. winestreamer: Implement wg_muxer_{get,copy,free}_buffer. winegstreamer: Implement ProcessSample for media sink. winegstreamer: Implement wg_muxer_push_sample. winegstreamer: Implement wg_muxer_add_stream. winegstreamer: Create wg_muxer for media sink. winegstreamer: Implement wg_muxer_create and wg_muxer_destroy. winegstreamer: Add stubs for wg_muxer. winegstreamer: Add enum wg_container_type. mf/tests: Use h264 and aac in mp4 media sink tests. winegstreamer: Add codec data to h264 format. winegstreamer: Add push_event wrapper. winegstreamer: Make append_element accpet NULL arguments. winegstreamer: Make find_element accept NULL caps. This merge request has too many patches to be relayed via email. Please visit the URL below to see the contents of the merge request. https://gitlab.winehq.org/wine/wine/-/merge_requests/3303

1 0

Re: [PATCH v3 0/5] MR3572: mf: Make session_get_node_object() more robust.
by Zhiyi Zhang (＠zhiyi) 18 Aug '23

18 Aug '23

On Fri Aug 18 01:22:20 2023 +0000, Nikolay Sivov wrote: > I think it's better to have media engine patches in a separate MR, after > making sure they work on Windows first. Doesn't current MR contain only mf changes? -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3572#note_42670

1 0

[PATCH v7 0/2] MR3431: wined3d: Fix clears of the current render target in Vulkan
by Evan Tang (＠etang-cw) 18 Aug '23

18 Aug '23

Previously, clearing the current render target would delay the clear until the render pass was ended by something else Fixes missing UI in [Moving Out](https://store.steampowered.com/app/996770/Moving_Out/) -- v7: wined3d: Restart vk render pass on RT clear. https://gitlab.winehq.org/wine/wine/-/merge_requests/3431

2 3

[PATCH v6 0/2] MR3431: wined3d: Fix clears of the current render target in Vulkan
by Evan Tang (＠etang-cw) 17 Aug '23

17 Aug '23

Previously, clearing the current render target would delay the clear until the render pass was ended by something else Fixes missing UI in [Moving Out](https://store.steampowered.com/app/996770/Moving_Out/) -- v6: wined3d: Restart vk render pass on RT clear. d3d11: Add tests for clearing RTs in the middle of a render. https://gitlab.winehq.org/wine/wine/-/merge_requests/3431

3 4

Re: [PATCH v2 0/1] MR3595: mf: Implement MFCreateSequencerSegmentOffset(). - approved
by Alexandre Julliard (＠julliard) 17 Aug '23

17 Aug '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3595

1 0

Re: [PATCH v4 0/2] MR3578: freopen() fix. - approved
by Alexandre Julliard (＠julliard) 17 Aug '23

17 Aug '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3578

1 0

Re: [PATCH v2 0/1] MR3584: joy: Remove size argument to set_config_key function. - approved
by Alexandre Julliard (＠julliard) 17 Aug '23

17 Aug '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3584

1 0

Re: [PATCH v2 0/1] MR3585: winex11.drv: Release old drawables after setting new ones in sync_context(). - approved
by Alexandre Julliard (＠julliard) 17 Aug '23

17 Aug '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3585

1 0

Re: [PATCH v3 0/7] MR3552: include: Add WinRT applicationmodel definitions. - approved
by Alexandre Julliard (＠julliard) 17 Aug '23

17 Aug '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3552

1 0

Re: [PATCH v2 0/1] MR3586: cmd: Introduce an option_equals helper for WCMD_parse_forf_options. - approved
by Alexandre Julliard (＠julliard) 17 Aug '23

17 Aug '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3586

1 0

Re: [PATCH v2 0/1] MR3594: odbccp32: Use CRT allocation functions. - approved
by Alexandre Julliard (＠julliard) 17 Aug '23

17 Aug '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3594

1 0

Re: [PATCH v2 0/1] MR3592: inetcpl: Use CRT allocation functions. - approved
by Alexandre Julliard (＠julliard) 17 Aug '23

17 Aug '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3592

1 0

Re: [PATCH v2 0/1] MR3589: adsldp: Use CRT allocation functions. - approved
by Alexandre Julliard (＠julliard) 17 Aug '23

17 Aug '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3589

1 0

Re: [PATCH v2 0/1] MR3590: advapi32: Use CRT allocation functions. - approved
by Alexandre Julliard (＠julliard) 17 Aug '23

17 Aug '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3590

1 0

[PATCH v3 0/1] MR3598: ntdll: Add error and warning logs in more cases of memory exhaustion.
by Tim Clem (＠tclem) 17 Aug '23

17 Aug '23

In my opinion we're far too quiet about mmap and allocation failures that will likely be fatal to the application. It generally takes some close inspection of +virtual or even +relay to detect running out of address space, e.g.. In my testing the added logs here shouldn't be too noisy - I've avoided them in the `try` functions and in cases where an error code is normal. I made the cross-process allocation failure a warning, because the target process itself will presumably log an error if it goes wrong. I also explicitly logged errno in a few cases where we assume its value. That can help catch some exotic error cases. -- v3: ntdll: Add error and warning logs in more cases of memory exhaustion. https://gitlab.winehq.org/wine/wine/-/merge_requests/3598

2 1

[PATCH v2 0/1] MR3598: ntdll: Add error and warning logs in more cases of memory exhaustion.
by Tim Clem (＠tclem) 17 Aug '23

17 Aug '23

In my opinion we're far too quiet about mmap and allocation failures that will likely be fatal to the application. It generally takes some close inspection of +virtual or even +relay to detect running out of address space, e.g.. In my testing the added logs here shouldn't be too noisy - I've avoided them in the `try` functions and in cases where an error code is normal. I made the cross-process allocation failure a warning, because the target process itself will presumably log an error if it goes wrong. I also explicitly logged errno in a few cases where we assume its value. That can help catch some exotic error cases. -- v2: ntdll: Add error and warning logs in more cases of memory exhaustion. https://gitlab.winehq.org/wine/wine/-/merge_requests/3598

2 1

[PATCH 0/1] MR308: vkd3d-shader/hlsl: Initialize all constant values in hlsl_fold_constant_swizzles().
by Francisco Casas (＠fcasas) 17 Aug '23

17 Aug '23

Even though the uninitialized values shouldn't be used in the output binary program, they still show up in it, and affect the checksum, so we better make them zeroes. This error was reported by valgrind: ``` libtool --mode=execute valgrind --track-origins=yes vkd3d-build/tests/shader_runner vkd3d/tests/hlsl/static-initializer.shader_test ``` ``` ==46180== Conditional jump or move depends on uninitialised value(s) ==46180== at 0x48D98C7: parse_dxbc.isra.0 (dxbc.c:182) ==46180== by 0x48DA044: vkd3d_shader_parse_dxbc (dxbc.c:308) ==46180== by 0x488D1B6: vkd3d_shader_parse_dxbc_source_type (vkd3d_shader_utils.h:37) ==46180== by 0x488D1B6: create_shader_stage.isra.0 (state.c:1988) ==46180== by 0x48926B6: d3d12_pipeline_state_init_graphics (state.c:3084) ==46180== by 0x4893A96: d3d12_pipeline_state_create_graphics (state.c:3280) ==46180== by 0x4878498: d3d12_device_CreateGraphicsPipelineState (device.c:2619) ==46180== by 0x1FFEFFECC7: ??? ==46180== by 0xE8: ??? ==46180== by 0x47: ??? ==46180== by 0x61: ??? ==46180== by 0x660066000000023: ??? ==46180== by 0x661066100000044: ??? ==46180== Uninitialised value was created by a stack allocation ==46180== at 0x48F3FF0: hlsl_fold_constant_swizzles (hlsl_constant_ops.c:1010) ``` Thank you valgrind! :smile: -- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/308

2 1

[PATCH 0/1] MR3598: ntdll: Add error and warning logs in more cases of memory exhaustion.
by Tim Clem (＠tclem) 17 Aug '23

17 Aug '23

In my opinion we're far too quiet about mmap and allocation failures that will likely be fatal to the application. It generally takes some close inspection of +virtual or even +relay to detect running out of address space, e.g.. In my testing the added logs here shouldn't be too noisy - I've avoided them in the `try` functions and in cases where an error code is normal. I made the cross-process allocation failure a warning, because the target process itself will presumably log an error if it goes wrong. I also explicitly logged errno in a few cases where we assume its value. That can help catch some exotic error cases. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3598

2 1

[PATCH v6 0/1] MR3581: gdiplus: add support for GdipPathIterNextPathType
by Bartosz Kosiorek (＠gang65) 17 Aug '23

17 Aug '23

I have covered implementation with additional test cases. -- v6: gdiplus: add support for GdipPathIterNextPathType https://gitlab.winehq.org/wine/wine/-/merge_requests/3581

4 3

Re: [PATCH v3 0/5] MR3572: mf: Make session_get_node_object() more robust.
by Nikolay Sivov (＠nsivov) 17 Aug '23

17 Aug '23

I think it's better to have media engine patches in a separate MR, after making sure they work on Windows first. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3572#note_42634

1 0

Re: [PATCH v3 0/5] MR3572: mf: Make session_get_node_object() more robust.
by Nikolay Sivov (＠nsivov) 17 Aug '23

17 Aug '23

Nikolay Sivov (@nsivov) commented about dlls/mf/session.c: > > /* fallthrough */ > case SESSION_STATE_PAUSED: > + case SESSION_STATE_STARTED: > + if (session->state == SESSION_STATE_STARTED && !(session->caps & MFSESSIONCAP_SEEK)) > + { > + WARN("Seeking is not supported for this session.\n"); > + session_command_complete(session); > + return; > + } Why does it check for STARTED state? -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3572#note_42632

1 0

Re: [PATCH v3 0/5] MR3572: mf: Make session_get_node_object() more robust.
by Nikolay Sivov (＠nsivov) 17 Aug '23

17 Aug '23

Nikolay Sivov (@nsivov) commented about dlls/mf/session.c: > } > } > > + if (session->state == SESSION_STATE_STARTED) > + { > + session_flush_transform_output_nodes(session); > + session_set_source_output_nodes_seeking(session); > + } Same here, isn't it possible to seek from paused state too? -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3572#note_42633

1 0

Re: [PATCH v3 0/5] MR3572: mf: Make session_get_node_object() more robust.
by Nikolay Sivov (＠nsivov) 17 Aug '23

17 Aug '23

Nikolay Sivov (@nsivov) commented about dlls/mf/session.c: > return hr; > } > > +static void session_flush_transform_output_nodes(struct media_session *session) This could be call session_flush_nodes(), or flush_topology/flush_pipeline, no need to make the name that specific. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3572#note_42631

1 0

[PATCH 0/1] MR3587: mshtml: Make skip_prefix static in OmNavigator_get_appVersion.
by Alex Henrie (＠alexhenrie) 17 Aug '23

17 Aug '23

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/3587

4 6

[PATCH v6 0/3] MR2168: win32u: Match second name when enum fonts.
by Keming Liang (＠Keming) 17 Aug '23

17 Aug '23

the patch can resolve the issue: https://bugs.winehq.org/show_bug.cgi?id=54483 and can also solve many crashed issue related to font(MS Shell Dlg etc.) -- v6: add a skip log when there is no simsun font in test env. https://gitlab.winehq.org/wine/wine/-/merge_requests/2168

3 5

[PATCH v2 0/1] MR3583: wldap32: Map LDAP_OPT_AUTO_RECONNECT to LDAP_OPT_RESTART and add tests.
by Alex Henrie (＠alexhenrie) 17 Aug '23

17 Aug '23

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=55450 -- v2: wldap32: Map LDAP_OPT_AUTO_RECONNECT to LDAP_OPT_RESTART and add tests. https://gitlab.winehq.org/wine/wine/-/merge_requests/3583

2 2

[PATCH v4 0/3] MR268: vkd3d-shader/hlsl: Handle vector arguments in fmod().
by Nikolay Sivov (＠nsivov) 17 Aug '23

17 Aug '23

-- v4: tests: Add a test for fmod() with vector arguments. vkd3d-shader: Use ternary operator in fmod() implementation. vkd3d-shader/tpf: Use 'movc' to implement ternary operator. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/268

3 9

[PATCH 0/5] MR3596: Win10 evolution for OutputDebugStringW.
by eric pouech (＠epo) 17 Aug '23

17 Aug '23

Win10 introduced the ability for OutputDebugStringW to send Unicode strings (instead of translating the Unicode string to ANSI and call OutputDebugStringA). This series: - add a couple of tests for covering various aspects + how exception with unicode string is constructed, + interaction with WaitForDebugEvent and WaitForDebugEventEx - implements WaitForDebugEventEx() - emit unicode string from OutputDebugStringW - introduce manifest constants to describe stages in exception testing (this let adding new stages way easier). Note this has not been tested on ARM. The tests results are not fully green because of existing issues in ntdll:exception (see https://bugs.winehq.org/show_bug.cgi?id=55111 for win8 and early win10, and all the failing ones in Win11...). -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3596

3 7

Re: [PATCH v5 0/1] MR3581: gdiplus: add support for GdipPathIterNextPathType
by Jeffrey Smith (＠whydoubt) 17 Aug '23

17 Aug '23

Jeffrey Smith (@whydoubt) commented about dlls/gdiplus/tests/pathiterator.c: > GpPath *path; > GpPathIterator *iter; > GpStatus stat; > - INT start, end, result; > + INT count, start, end, result, closed; Again, `BOOL closed;` -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3581#note_42604

1 0

Re: [PATCH v5 0/1] MR3581: gdiplus: add support for GdipPathIterNextPathType
by Jeffrey Smith (＠whydoubt) 17 Aug '23

17 Aug '23

On Wed Aug 16 21:48:02 2023 +0000, Bartosz Kosiorek wrote: > How it could be done (set \*result when you return)? I just mean set *result before you return, just like you do about 5 lines before. It appears 0 would the appropriate value, in which case you could combine the if blocks. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3581#note_42603

1 0

[PATCH v5 0/2] MR3431: wined3d: Fix clears of the current render target in Vulkan
by Evan Tang (＠etang-cw) 17 Aug '23

17 Aug '23

Previously, clearing the current render target would delay the clear until the render pass was ended by something else Fixes missing UI in [Moving Out](https://store.steampowered.com/app/996770/Moving_Out/) -- v5: wined3d: Restart vk render pass on RT clear. d3d11: Add tests for clearing RTs in the middle of a render. https://gitlab.winehq.org/wine/wine/-/merge_requests/3431

4 5

Re: [PATCH v5 0/1] MR3581: gdiplus: add support for GdipPathIterNextPathType
by Jeffrey Smith (＠whydoubt) 17 Aug '23

17 Aug '23

Jeffrey Smith (@whydoubt) commented about dlls/gdiplus/tests/pathiterator.c: > GpPath *path; > GpPathIterator *iter; > GpStatus stat; > - INT start, end, result; > - BOOL closed; > + INT start, end, result, closed; I would leave the type as BOOL, to make it match the 4th parameter of GdipPathIterNextSubpath. But since it is implemented as an integer (as opposed to an actual boolean that only accepts true/false), it can contain any value that an INT can, so the tests should still be fine. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3581#note_42601

1 0

[PATCH 0/1] MR3583: wldap32: Map LDAP_OPT_AUTO_RECONNECT to LDAP_OPT_RESTART and add tests.
by Alex Henrie (＠alexhenrie) 17 Aug '23

17 Aug '23

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=55450 -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3583

3 2

[PATCH v3 0/2] MR3578: freopen() fix.
by eric pouech (＠epo) 17 Aug '23

17 Aug '23

I stumbled onto this while using freopen() for debugging purposes. Basically, freopen() fails if the FILE has been created with an invalid handle. So, this MR contains: - basic tests for freopen (no issue there, just for coverage purposes) - tests for freopen on FILE with invalid handle - fix for freopen -- v3: msvcrt: Fix freopen() on FILE with invalid underlying fd. msvcrt/tests: Add tests for freopen(). https://gitlab.winehq.org/wine/wine/-/merge_requests/3578

3 4

[PATCH 0/1] MR3584: joy: Remove size argument to set_config_key function.
by Alex Henrie (＠alexhenrie) 17 Aug '23

17 Aug '23

Having to pass the size separately made the function unnecessarily complicated. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3584

4 3

[PATCH 0/1] MR3595: mf: Implement MFCreateSequencerSegmentOffset().
by Nikolay Sivov (＠nsivov) 17 Aug '23

17 Aug '23

Signed-off-by: Nikolay Sivov <nsivov(a)codeweavers.com> -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3595

2 1

Re: [PATCH v2 0/1] MR3577: ieframe/tests: Use less strict checks in session count tests.
by Francois Gouget (＠fgouget) 17 Aug '23

17 Aug '23

On Wed Aug 16 20:20:19 2023 +0000, Jacek Caban wrote: > One way or another, tests of a global state like that will always be > theoretically a subject to race. In essence, my patch reduces problem > probability, just like your solution. Which is why a general solution would be better than N different hacks. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3577#note_42592

1 0

[PATCH v2 0/7] MR3552: include: Add WinRT applicationmodel definitions.
by Mohamad Al-Jaf (＠maljaf) 17 Aug '23

17 Aug '23

-- v2: include: Add IStorageFolder interface definition. include: Add windows.storage.search.idl file. include: Add IStorageItem interface definition. include: Add windows.storage.fileproperties.idl file. include: Add IStorageFile interface definition. include: Add IRandomAccessStream interface definition. include: Add IPackageStatics interface definition. https://gitlab.winehq.org/wine/wine/-/merge_requests/3552

3 10

[PATCH 0/3] MR3565: d3d9/tests: Work around test_reset_fullscreen failing on gitlab CI.
by Stefan Dösinger (＠stefan) 17 Aug '23

17 Aug '23

--- See the added comment for details what is going on. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3565

3 5

Re: [PATCH v2 0/1] MR3573: winex11.drv: Mark drawable as dirty when setting pixel format.
by Anton Baskanov (＠baskanov) 17 Aug '23

17 Aug '23

v2: Rebased. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3573#note_42583

1 0

[PATCH 0/1] MR3588: windows.media.devices: Define GUID_STR_LEN without using a magic number.
by Alex Henrie (＠alexhenrie) 17 Aug '23

17 Aug '23

The exact number (38) is not very important, and using `ARRAY_SIZE` instead tells the reader that there is little chance that the number was calculated incorrectly. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3588

3 2

[PATCH 0/1] MR3594: odbccp32: Use CRT allocation functions.
by Alex Henrie (＠alexhenrie) 17 Aug '23

17 Aug '23

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/3594

2 1

[PATCH 0/1] MR3593: newdev: Use CRT allocation functions.
by Alex Henrie (＠alexhenrie) 17 Aug '23

17 Aug '23

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/3593

2 1

[PATCH 0/1] MR3592: inetcpl: Use CRT allocation functions.
by Alex Henrie (＠alexhenrie) 17 Aug '23

17 Aug '23

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/3592

2 1

[PATCH 0/1] MR3591: http: Use CRT allocation functions.
by Alex Henrie (＠alexhenrie) 17 Aug '23

17 Aug '23

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/3591

2 1

[PATCH 0/1] MR3590: advapi32: Use CRT allocation functions.
by Alex Henrie (＠alexhenrie) 17 Aug '23

17 Aug '23

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/3590

2 1

[PATCH v2 0/1] MR3505: ntdll: Implement NtCreateToken().
by Dmitry Timoshkov (＠dmitry) 17 Aug '23

17 Aug '23

-- v2: ntdll: Implement NtCreateToken(). https://gitlab.winehq.org/wine/wine/-/merge_requests/3505

5 9

Re: [PATCH v3 0/5] MR3572: mf: Make session_get_node_object() more robust.
by Zhiyi Zhang (＠zhiyi) 17 Aug '23

17 Aug '23

> mf.c:2077: Test failed: Unexpected hr 0xc00d36bb. > mf.c:7533: Test failed: MP4 media source is not supported, skipping tests. Somehow the tests fail on Gitlab CI. I will take a look. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3572#note_42570

1 0

[PATCH 0/1] MR3589: adsldp: Use CRT allocation functions.
by Alex Henrie (＠alexhenrie) 17 Aug '23

17 Aug '23

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/3589

2 1

[PATCH v3 0/1] MR3581: gdiplus: add support for GdipPathIterNextPathType
by Bartosz Kosiorek (＠gang65) 17 Aug '23

17 Aug '23

I have covered implementation with additional test cases. -- v3: gdiplus: add support for GdipPathIterNextPathType https://gitlab.winehq.org/wine/wine/-/merge_requests/3581

3 2

[PATCH 0/1] MR3586: cmd: Introduce an option_equals helper for WCMD_parse_forf_options.
by Alex Henrie (＠alexhenrie) 17 Aug '23

17 Aug '23

This makes the function a lot more readable. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3586

2 1

[PATCH 0/1] MR3585: winex11.drv: Release old drawables after setting new ones in sync_context().
by Paul Gofman (＠gofman) 17 Aug '23

17 Aug '23

Context might hold the last reference to the drawable and we want to set the new GLX drawable before the currently set one is destroyed. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3585

2 1

[PATCH v2 0/1] MR3581: gdiplus: add support for GdipPathIterNextPathType
by Bartosz Kosiorek (＠gang65) 16 Aug '23

16 Aug '23

I have covered implementation with additional test cases. -- v2: gdiplus: add support for GdipPathIterNextPathType https://gitlab.winehq.org/wine/wine/-/merge_requests/3581

5 13

Re: [PATCH v2 0/1] MR3577: ieframe/tests: Use less strict checks in session count tests.
by Jacek Caban (＠jacek) 16 Aug '23

16 Aug '23

On Wed Aug 16 13:14:42 2023 +0000, Francois Gouget wrote: > Well, I did say in bug 54866 that it looks like the extra net session is > not created after the first SESSION_INCREMENT call so I guess this patch > could work. But I as far as I can tell that's just how the timing of the > race condition works and I don't think we should rely on that. One way or another, tests of a global state like that will always be theoretically a subject to race. In essence, my patch reduces problem probability, just like your solution. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3577#note_42537

1 0

Re: [PATCH v2 0/1] MR3582: winemac.drv: Support cooperative app activation in macOS 14 Sonoma. - approved
by Alexandre Julliard (＠julliard) 16 Aug '23

16 Aug '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3582

1 0

Re: [PATCH v2 0/1] MR3580: cscript: Build as CUI application. - approved
by Alexandre Julliard (＠julliard) 16 Aug '23

16 Aug '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3580

1 0

Re: [PATCH v2 0/3] MR3570: winegstreamer: Implement GetStreamSink{Count,ByIndex,ById} for media sink. - approved
by Alexandre Julliard (＠julliard) 16 Aug '23

16 Aug '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3570

1 0

Re: [PATCH v5 0/1] MR3484: sane.ds: Fix pixel type setting. - approved
by Alexandre Julliard (＠julliard) 16 Aug '23

16 Aug '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3484

1 0

Re: [PATCH v2 0/1] MR3577: ieframe/tests: Use less strict checks in session count tests. - approved
by Alexandre Julliard (＠julliard) 16 Aug '23

16 Aug '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3577

1 0

Re: [PATCH v11 0/2] MR3301: Improve trace output - approved
by Alexandre Julliard (＠julliard) 16 Aug '23

16 Aug '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3301

1 0

Re: [PATCH v8 0/7] MR3506: Improve headers compatibility - approved
by Alexandre Julliard (＠julliard) 16 Aug '23

16 Aug '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3506

1 0

Re: [PATCH v3 0/1] MR3576: include: Add __WINE_ALLOC_SIZE to the definition of FNALLOC. - approved
by Alexandre Julliard (＠julliard) 16 Aug '23

16 Aug '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3576

1 0

Re: [PATCH v2 0/1] MR3571: sane.ds: Set monochrome DIB color table. - approved
by Alexandre Julliard (＠julliard) 16 Aug '23

16 Aug '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3571

1 0

Re: [PATCH v5 0/11] MR3542: mshtml: Implement Cycle Collection for all mshtml objects (dispex), part 4. - approved
by Alexandre Julliard (＠julliard) 16 Aug '23

16 Aug '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3542

1 0

2025

2024

2023

2022

wine-gitlab