- wine-gitlab - winehq.org

Re: [PATCH v3 0/1] MR7719: joy.cpl: Set devnotify to NULL after it got unregistered (ASan). - approved
by Alexandre Julliard (＠julliard) 02 Apr '25

02 Apr '25

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7719

1 0

Re: [PATCH v2 0/6] MR7721: win32u: Add a generic wgl(Get|Set)PixelFormat(WINE) implementation. - approved
by Alexandre Julliard (＠julliard) 02 Apr '25

02 Apr '25

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7721

1 0

Re: [PATCH v2 0/1] MR7718: imm32: Add a stub for CtfImmRestoreToolbarWnd. - approved
by Alexandre Julliard (＠julliard) 02 Apr '25

02 Apr '25

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7718

1 0

Re: [PATCH v2 0/1] MR7700: gdiplus: Avoid storing NULL in gdip_font_link_section. - approved
by Alexandre Julliard (＠julliard) 02 Apr '25

02 Apr '25

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7700

1 0

Re: [PATCH v8 0/6] MR6866: ntdll: On macOS x86_64, swap GSBASE between the TEB and macOS TSD when entering/leaving PE code. - approved
by Alexandre Julliard (＠julliard) 02 Apr '25

02 Apr '25

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6866

1 0

[PATCH 0/1] MR7725: regsvr32: Implemented stub for undocumented flag /c.
by Kostin Mikhail (＠M23SNEZ3) 02 Apr '25

02 Apr '25

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/7725

3 5

[PATCH v15 0/6] MR7610: win32u: Create a shared object for user handle entries.
by Rémi Bernon (＠rbernon) 02 Apr '25

02 Apr '25

For https://gitlab.winehq.org/wine/wine/-/merge_requests/7512 to use it to locate window shared objects. -- v15: win32u: Use the session shared object for user handle entries. win32u: Use the session shared object to implement is_window. server: Move the user object handle table to the shared memory. server: Allocate a session shared memory header structure. server: Use NTUSER_OBJ constants for user object types. include: Implement ReadAcquire64. https://gitlab.winehq.org/wine/wine/-/merge_requests/7610

3 9

[PATCH v3 0/5] MR7425: jscript: Obtain the jsdisp for host objects in other contexts.
by Gabriel Ivăncescu (＠insn) 02 Apr '25

02 Apr '25

-- v3: jscript: Get rid of the funcprot argument. mshtml: Release the node if there's no script global when handling events. mshtml: Make sure manually created document dispex info is initialized in jscript: Obtain the jsdisp for host objects in other contexts. mshtml: Keep the link from the inner window to the outer window even when https://gitlab.winehq.org/wine/wine/-/merge_requests/7425

3 6

[PATCH 0/2] MR7726: Don't test function directly when reporting GetLastError()
by André Zwing (＠AndreRH) 02 Apr '25

02 Apr '25

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/7726

2 2

Re: [PATCH v2 0/2] MR7724: regsvr32: Implemented stub for undocumented flag /c. - closed
by Kostin Mikhail (＠M23SNEZ3) 02 Apr '25

02 Apr '25

This merge request was closed by Kostin Mikhail. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7724

1 0

[PATCH 0/1] MR7724: regsvr32: Implemented stub for undocumented flag /c.
by Kostin Mikhail (＠M23SNEZ3) 02 Apr '25

02 Apr '25

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/7724

2 1

[PATCH 0/1] MR4740: ntdll: Don't hardcode pagesize when allocating handles
by Fabian Maurer (＠DarkShadow44) 02 Apr '25

02 Apr '25

Not really needed for 16k pages, but since the comment says "one page" the logic should reflect that. Not 100% sure about that since I don't know why it should use exactly one page, so please double check. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4740

2 2

[PATCH 0/1] MR7717: Initial patch for converting Wine to Rust
by André Zwing (＠AndreRH) 02 Apr '25

02 Apr '25

Now let AJ figure out the build support and we can convert the rest -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7717

8 30

Re: [PATCH v6 0/1] MR3410: advpack: Add nullcheck for parameter that can be null (Coverity)
by Fabian Maurer (＠DarkShadow44) 02 Apr '25

02 Apr '25

Anything that's missing here? To me it seems like a simple change... -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3410#note_99716

1 0

[PATCH 0/2] MR7723: bcrypt: Add support for BCRYPT_AES_WRAP_KEY_BLOB.
by Dmitry Timoshkov (＠dmitry) 02 Apr '25

02 Apr '25

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/7723

3 11

[PATCH v3 0/6] MR7708: Fix Imperiums: Greek Wars (1183470) not covering the entire screen in fullscreen mode.
by Zhiyi Zhang (＠zhiyi) 02 Apr '25

02 Apr '25

-- v3: win32u: Properly scale monitor work area when emulate_modeset is enabled. https://gitlab.winehq.org/wine/wine/-/merge_requests/7708

3 8

[PATCH v17 0/7] MR3799: kernelbase: Add implementation of PerfSetULongCounterValue and PerfSetULongLongCounterValue
by Lorenzo Ferrillo (＠llde) 02 Apr '25

02 Apr '25

These functions are used by Visual Studio 2019, when opening or converting some projects. Signed-off-by: Lorenzo Ferrillo <lorenzofersteam(a)live.it> -- v17: kernelbase: Check for PERF_SIZE_LARGE in PerfSetULongLongCounterValue and PerfSetULongCounterValue kernelbase : Check for PERF_ATTRIB_BY_REFERENCE attribute in PerfSetCounterRefValue advapi/test: Add Test For PerfSetULongLongCounterValue advapi32/tests: Create Tests for PerfSetULongCounterValue advapi32: Forward PerfSetULongCounterValue and PerfSetULongLongCounterValue to kernelbase kernelbase: Add implementation for PerfSetULongLongCounterValue kernelbase: Add implementation of PerfSetULongCounterValue https://gitlab.winehq.org/wine/wine/-/merge_requests/3799

3 10

[PATCH v4 0/4] MR7707: msvcp140: Implement codecvt<char16_t, char> conversions.
by Paul Gofman (＠gofman) 02 Apr '25

02 Apr '25

-- v4: https://gitlab.winehq.org/wine/wine/-/merge_requests/7707

3 6

[PATCH 0/5] MR7715: Implement dynamic formats in directdraw media stream.
by Santino Mazza (＠tati) 02 Apr '25

02 Apr '25

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/7715

3 18

[PATCH v2 0/1] MR7719: joy.cpl: Set devnotify to NULL after it got unregistered (ASan).
by Bernhard Übelacker (＠bernhardu) 02 Apr '25

02 Apr '25

This is to avoid a crash in UnregisterDeviceNotification when called a second time for the same handle. Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=58050 <details> <summary>ASan Details</summary> ``` ================================================================= ==control.exe==536==ERROR: AddressSanitizer: heap-use-after-free on address 0x7f07e3ae0568 at pc 0x6ffffdc6f092 bp 0x7ffffe1fdae0 sp 0x7ffffe1fdb28 READ of size 8 at 0x7f07e3ae0568 thread T0 #0 0x6ffffdc6f091 in list_remove ...\wine\include\wine\list.h:100 #1 0x6ffffdc6efcc in I_ScUnregisterDeviceNotification ...\wine\dlls\sechost\service.c:2193 #2 0x6ffffa5a16e2 in UnregisterDeviceNotification ...\wine\dlls\user32\input.c:594 #3 0x6ffffdbe3a5f in test_di_dialoHWND__ ...\wine\dlls\joy.cpl\dinput.c:809 #4 0x6ffffa5c3f6e in WINPROC_wrapper ...\wine\dlls\user32\winproc.c:86 #5 0x6ffffa5c3b6e in call_dialog_proc ...\wine\dlls\user32\winproc.c:130 #6 0x6ffffa5c3c6e in WINPROC_CallDlgProcW ...\wine\dlls\user32\winproc.c:951 #7 0x6ffffa58f8cc in USER_DefDlgProcW ...\wine\dlls\user32\defdlg.c:375 #8 0x6ffffa58f864 in USER_DefDlgProc ...\wine\dlls\user32\defdlg.c:420 #9 0x6ffffb4a39d5 in UXTHEME_DefDlgProc ...\wine\dlls\uxtheme\dialog.c:192 #10 0x6ffffa58fb8d in DialogWndProcW ...\wine\dlls\user32\defdlg.c:438 #11 0x6fffffdaffdf in NtdllDialogWndProc_W+0xf (C:\windows\system32\ntdll.dll+0x17003ffdf) #12 0x6ffffa5c3f6e in WINPROC_wrapper ...\wine\dlls\user32\winproc.c:86 #13 0x6ffffa5c2ba8 in call_window_proc ...\wine\dlls\user32\winproc.c:111 #14 0x6ffffa5c2d92 in dispatch_win_proc_params ...\wine\dlls\user32\winproc.c #15 0x6ffffa5aee20 in dispatwin_proc_params ...\wine\dlls\user32\message.c:567 #16 0x6ffffa5aeda4 in SendMessageW ...\wine\dlls\user32\message.c:586 #17 0x6ffffde75873 in PROPSHEET_Cancel ...\wine\dlls\comctl32\propsheet.c:1949 #18 0x6ffffde75b80 in PROPSHEET_DoCommand ...\wine\dlls\comctl32\propsheet.c:3359 #19 0x6ffffde7085e in PROPSHEET_DialogProc ...\wine\dlls\comctl32\propsheet.c:3694 #20 0x6ffffa5c3f6e in WINPROC_wrapper ...\wine\dlls\user32\winproc.c:86 #21 0x6ffffa5c3b6e in call_dialog_proc ...\wine\dlls\user32\winproc.c:130 #22 0x6ffffa5c3c6e in WINPROC_CallDlgProcW ...\wine\dlls\user32\winproc.c:951 #23 0x6ffffa58f8cc in USER_DefDlgProcW ...\wine\dlls\user32\defdlg.c:375 #24 0x6ffffa58f864 in USER_DefDlgProc ...\wine\dlls\user32\defdlg.c:420 #25 0x6ffffb4a39d5 in UXTHEME_DefDlgProc ...\wine\dlls\uxtheme\dialog.c:192 #26 0x6ffffa58fb8d in DialogWndProcW ...\wine\dlls\user32\defdlg.c:438 #27 0x6fffffdaffdf in NtdllDialogWndProc_W+0xf (C:\windows\system32\ntdll.dll+0x17003ffdf) #28 0x6ffffa5c3f6e in WINPROC_wrapper ...\wine\dlls\user32\winproc.c:86 #29 0x6ffffa5c2ba8 in call_window_proc ...\wine\dlls\user32\winproc.c:111 #30 0x6ffffa5c2d92 in dispatch_win_proc_params ...\wine\dlls\user32\winproc.c #31 0x6ffffa5aee20 in dispatwin_proc_params ...\wine\dlls\user32\message.c:567 #32 0x6ffffa5aeda4 in SendMessageW ...\wine\dlls\user32\message.c:586 #33 0x6ffffdd9a2fb in BUTTON_WindowProc+0x1c7b (C:\windows\winsxs\amd64_microsoft.windows.common-controls_6595b64144ccf1df_6.0.2600.2982_none_deadbeef\comctl32.dll+0x18000a2fb) #34 0x6ffffa5c3f6e in WINPROC_wrapper ...\wine\dlls\user32\winproc.c:86 #35 0x6ffffa5c2ba8 in call_window_proc ...\wine\dlls\user32\winproc.c:111 #36 0x6ffffa5c2d92 in dispatch_win_proc_params ...\wine\dlls\user32\winproc.c #37 0x6ffffa5af7db in dispatch_message ...\wine\dlls\user32\message.c:804 #38 0x6ffffa5af881 in DispatchMessageW ...\wine\dlls\user32\message.c:890 #39 0x6ffffa591e90 in IsDialogMessageW ...\wine\dlls\user32\dialog.c:1293 #40 0x6ffffde76a93 in PROPSHEET_IsDialogMessage ...\wine\dlls\comctl32\propsheet.c:2956 #41 0x6ffffde6fd45 in do_loop ...\wine\dlls\comctl32\propsheet.c:2971 #42 0x6ffffde6c938 in PROPSHEET_PropertySheet ...\wine\dlls\comctl32\propsheet.c:3013 #43 0x6ffffde6cddd in PropertySheetW ...\wine\dlls\comctl32\propsheet.c:3124 #44 0x6ffffdbe754c in display_cpl_sheets ...\wine\dlls\joy.cpl\main.c:482 #45 0x6ffffdbe6d2f in CPlApplet ...\wine\dlls\joy.cpl\main.c:570 #46 0x6ffffb98f235 in Control_DoLaunch ...\wine\dlls\shell32\control.c:822 #47 0x6ffffb98e8e4 in Control_RunDLLW ...\wine\dlls\shell32\control.c:847 #48 0x0001400011b6 in launch+0x26 (C:\windows\system32\control.exe+0x1400011b6) #49 0x000140001044 in STANCE__+0x44 (C:\windows\system32\control.exe+0x140001044) #50 0x000140001320 in wmain+0xb0 (C:\windows\system32\control.exe+0x140001320) #51 0x000140001245 in wmainCRTStartup ...\wine\dlls\msvcrt\crt_wmain.c:58 #52 0x6fffffc3565e in BaseThreadInitThunk ...\wine\dlls\kernel32\thread.c:61 #53 0x6fffffdbbb1a (C:\windows\system32\ntdll.dll+0x17004bb1a) 0x7f07e3ae0568 is located 8 bytes inside of 68-byte region [0x7f07e3ae0560,0x7f07e3ae05a4) freed by thread T0 here: #0 0x6ffffe84a381 in free+0x81 (C:\windows\system32\libclang_rt.asan_dynamic-x86_64.dll+0x18004a381) #1 0x6ffffdc6eff8 in I_ScUnregisterDeviceNotification ...\wine\dlls\sechost\service.c:2196 #2 0x6ffffa5a16e2 in UnregisterDeviceNotification ...\wine\dlls\user32\input.c:594 #3 0x6ffffdbe3a5f in test_di_dialoHWND__ ...\wine\dlls\joy.cpl\dinput.c:809 #4 0x6ffffa5c3f6e in WINPROC_wrapper ...\wine\dlls\user32\winproc.c:86 #5 0x6ffffa5c3b6e in call_dialog_proc ...\wine\dlls\user32\winproc.c:130 #6 0x6ffffa5c3c6e in WINPROC_CallDlgProcW ...\wine\dlls\user32\winproc.c:951 #7 0x6ffffa58f8cc in USER_DefDlgProcW ...\wine\dlls\user32\defdlg.c:375 #8 0x6ffffa58f864 in USER_DefDlgProc ...\wine\dlls\user32\defdlg.c:420 #9 0x6ffffb4a39d5 in UXTHEME_DefDlgProc ...\wine\dlls\uxtheme\dialog.c:192 #10 0x6ffffa58fb8d in DialogWndProcW ...\wine\dlls\user32\defdlg.c:438 #11 0x6fffffdaffdf in NtdllDialogWndProc_W+0xf (C:\windows\system32\ntdll.dll+0x17003ffdf) #12 0x6ffffa5c3f6e in WINPROC_wrapper ...\wine\dlls\user32\winproc.c:86 #13 0x6ffffa5c2ba8 in call_window_proc ...\wine\dlls\user32\winproc.c:111 #14 0x6ffffa5c2d92 in dispatch_win_proc_params ...\wine\dlls\user32\winproc.c #15 0x6ffffa5aee20 in dispatwin_proc_params ...\wine\dlls\user32\message.c:567 #16 0x6ffffa5aeda4 in SendMessageW ...\wine\dlls\user32\message.c:586 #17 0x6ffffde75df3 in PROPSHEET_CanSetCurSel ...\wine\dlls\comctl32\propsheet.c:2120 #18 0x6ffffde702ef in PROPSHEET_DialogProc ...\wine\dlls\comctl32\propsheet.c:3722 #19 0x6ffffa5c3f6e in WINPROC_wrapper ...\wine\dlls\user32\winproc.c:86 #20 0x6ffffa5c3b6e in call_dialog_proc ...\wine\dlls\user32\winproc.c:130 #21 0x6ffffa5c3c6e in WINPROC_CallDlgProcW ...\wine\dlls\user32\winproc.c:951 #22 0x6ffffa58f8cc in USER_DefDlgProcW ...\wine\dlls\user32\defdlg.c:375 #23 0x6ffffa58f864 in USER_DefDlgProc ...\wine\dlls\user32\defdlg.c:420 #24 0x6ffffb4a39d5 in UXTHEME_DefDlgProc ...\wine\dlls\uxtheme\dialog.c:192 #25 0x6ffffa58fb8d in DialogWndProcW ...\wine\dlls\user32\defdlg.c:438 #26 0x6fffffdaffdf in NtdllDialogWndProc_W+0xf (C:\windows\system32\ntdll.dll+0x17003ffdf) #27 0x6ffffa5c3f6e in WINPROC_wrapper ...\wine\dlls\user32\winproc.c:86 previously allocated by thread T0 here: #0 0x6ffffe84a5b6 in calloc+0x86 (C:\windows\system32\libclang_rt.asan_dynamic-x86_64.dll+0x18004a5b6) #1 0x6ffffdc6e50b in I_ScRegisterDeviceNotification ...\wine\dlls\sechost\service.c:2141 #2 0x6ffffa5a1377 in RegisterDeviceNotificationW ...\wine\dlls\user32\input.c #3 0x6ffffdbe398c in test_di_dialoHWND__ ...\wine\dlls\joy.cpl\dinput.c:795 #4 0x6ffffa5c3f6e in WINPROC_wrapper ...\wine\dlls\user32\winproc.c:86 #5 0x6ffffa5c3b6e in call_dialog_proc ...\wine\dlls\user32\winproc.c:130 #6 0x6ffffa5c3c6e in WINPROC_CallDlgProcW ...\wine\dlls\user32\winproc.c:951 #7 0x6ffffa58f8cc in USER_DefDlgProcW ...\wine\dlls\user32\defdlg.c:375 #8 0x6ffffa58f864 in USER_DefDlgProc ...\wine\dlls\user32\defdlg.c:420 #9 0x6ffffb4a39d5 in UXTHEME_DefDlgProc ...\wine\dlls\uxtheme\dialog.c:192 #10 0x6ffffa58fb8d in DialogWndProcW ...\wine\dlls\user32\defdlg.c:438 #11 0x6fffffdaffdf in NtdllDialogWndProc_W+0xf (C:\windows\system32\ntdll.dll+0x17003ffdf) #12 0x6ffffa5c3f6e in WINPROC_wrapper ...\wine\dlls\user32\winproc.c:86 #13 0x6ffffa5c2ba8 in call_window_proc ...\wine\dlls\user32\winproc.c:111 #14 0x6ffffa5c2d92 in dispatch_win_proc_params ...\wine\dlls\user32\winproc.c #15 0x6ffffa5aee20 in dispatwin_proc_params ...\wine\dlls\user32\message.c:567 #16 0x6ffffa5aeda4 in SendMessageW ...\wine\dlls\user32\message.c:586 #17 0x6ffffde73e49 in PROPSHEET_SetCurSel ...\wine\dlls\comctl32\propsheet.c:2199 #18 0x6ffffde702c3 in PROPSHEET_DialogProc ...\wine\dlls\comctl32\propsheet.c:3717 #19 0x6ffffa5c3f6e in WINPROC_wrapper ...\wine\dlls\user32\winproc.c:86 #20 0x6ffffa5c3b6e in call_dialog_proc ...\wine\dlls\user32\winproc.c:130 #21 0x6ffffa5c3c6e in WINPROC_CallDlgProcW ...\wine\dlls\user32\winproc.c:951 #22 0x6ffffa58f8cc in USER_DefDlgProcW ...\wine\dlls\user32\defdlg.c:375 #23 0x6ffffa58f864 in USER_DefDlgProc ...\wine\dlls\user32\defdlg.c:420 #24 0x6ffffb4a39d5 in UXTHEME_DefDlgProc ...\wine\dlls\uxtheme\dialog.c:192 #25 0x6ffffa58fb8d in DialogWndProcW ...\wine\dlls\user32\defdlg.c:438 #26 0x6fffffdaffdf in NtdllDialogWndProc_W+0xf (C:\windows\system32\ntdll.dll+0x17003ffdf) #27 0x6ffffa5c3f6e in WINPROC_wrapper ...\wine\dlls\user32\winproc.c:86 SUMMARY: AddressSanitizer: heap-use-after-free ...\wine\include\wine\list.h:100 in list_remove Shadow bytes around the buggy address: 0x7f07e3ae0280: fd fd fd fa fa fa fa fa 00 00 00 00 00 00 00 00 0x7f07e3ae0300: 06 fa fa fa fa fa fd fd fd fd fd fd fd fd fd fd 0x7f07e3ae0380: fa fa fa fa fd fd fd fd fd fd fd fd fd fa fa fa 0x7f07e3ae0400: fa fa 00 00 00 00 00 00 00 00 06 fa fa fa fa fa 0x7f07e3ae0480: fd fd fd fd fd fd fd fd fd fd fa fa fa fa 00 00 =>0x7f07e3ae0500: 00 00 00 00 00 00 04 fa fa fa fa fa fd[fd]fd fd 0x7f07e3ae0580: fd fd fd fd fd fa fa fa fa fa fd fd fd fd fd fd 0x7f07e3ae0600: fd fd fd fa fa fa fa fa fd fd fd fd fd fd fd fd 0x7f07e3ae0680: fd fa fa fa fa fa fd fd fd fd fd fd fd fd fd fa 0x7f07e3ae0700: fa fa fa fa fd fd fd fd fd fd fd fd fd fa fa fa 0x7f07e3ae0780: fa fa fd fd fd fd fd fd fd fd fd fd fa fa fa fa Shadow byte legend (one shadow byte represents 8 application bytes): Addressable: 00 Partially addressable: 01 02 03 04 05 06 07 Heap left redzone: fa Freed heap region: fd Stack left redzone: f1 Stack mid redzone: f2 Stack right redzone: f3 Stack after return: f5 Stack use after scope: f8 Global redzone: f9 Global init order: f6 Poisoned by user: f7 Container overflow: fc Array cookie: ac Intra object redzone: bb ASan internal: fe Left alloca redzone: ca Right alloca redzone: cb ==control.exe==536==ABORTING ``` </details> -- v2: joy.cpl: Set devnotify to NULL after it got unregistered (ASan). https://gitlab.winehq.org/wine/wine/-/merge_requests/7719

3 4

[PATCH 0/2] MR7722: shell32/tests: Introduce check_file_operation helper.
by Ziqing Hui (＠zhui) 02 Apr '25

02 Apr '25

Split into 2 patches to reduce patch size. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7722

2 2

[PATCH v21 0/1] MR6938: winewayland.drv: Implement support for xdg-toplevel-icon.
by Etaash Mathamsetty (＠etaash.mathamsetty) 02 Apr '25

02 Apr '25

-- v21: winewayland.drv: Implement support for xdg-toplevel-icon. https://gitlab.winehq.org/wine/wine/-/merge_requests/6938

3 11

[PATCH v14 0/6] MR7610: win32u: Create a shared object for user handle entries.
by Rémi Bernon (＠rbernon) 02 Apr '25

02 Apr '25

For https://gitlab.winehq.org/wine/wine/-/merge_requests/7512 to use it to locate window shared objects. -- v14: win32u: Use the session shared object for user handle entries. win32u: Use the session shared object to implement is_window. server: Move the user object handle table to the shared memory. server: Allocate a session shared memory header structure. server: Use NTUSER_OBJ constants for user object types. include: Implement ReadAcquire64. https://gitlab.winehq.org/wine/wine/-/merge_requests/7610

2 7

[PATCH 0/6] MR7721: win32u: Add a generic wgl(Get|Set)PixelFormat(WINE) implementation.
by Rémi Bernon (＠rbernon) 02 Apr '25

02 Apr '25

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/7721

2 6

[PATCH 0/1] MR7718: imm32: Add a stub for CtfImmRestoreToolbarWnd.
by Tim Clem (＠tclem) 02 Apr '25

02 Apr '25

And adjust the return type of CtfImmHideToolbarWnd. --- As with !7572, the Guild Wars 2 installer wants this (but only sometimes, which is why it wasn't included in that MR). Testing shows that CtfImmRestoreToolbarWnd consumes one pointer-sized argument and (in my surely broken test calls) returns 0. Examining the app, it calls CtfImmRestoreToolbarWnd with the return value of CtfImmHideToolbarWnd. That implies to me that the return of CtfImmHideToolbarWnd might be more interesting than a BOOL. I adjusted its return to a DWORD, both for that reason and because a BOOL implies that we know more about this function than we do. Let me know if you'd like me to split that into its own commit, or skip the change entirely. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7718

3 2

[PATCH 0/1] MR7719: joy.cpl: Set devnotify to NULL after it got unregistered (ASan).
by Bernhard Übelacker (＠bernhardu) 02 Apr '25

02 Apr '25

This is to avoid a crash in UnregisterDeviceNotification when called a second time for the same handle. Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=58050 <details> <summary>ASan Details</summary> ``` ================================================================= ==control.exe==536==ERROR: AddressSanitizer: heap-use-after-free on address 0x7f07e3ae0568 at pc 0x6ffffdc6f092 bp 0x7ffffe1fdae0 sp 0x7ffffe1fdb28 READ of size 8 at 0x7f07e3ae0568 thread T0 #0 0x6ffffdc6f091 in list_remove ...\wine\include\wine\list.h:100 #1 0x6ffffdc6efcc in I_ScUnregisterDeviceNotification ...\wine\dlls\sechost\service.c:2193 #2 0x6ffffa5a16e2 in UnregisterDeviceNotification ...\wine\dlls\user32\input.c:594 #3 0x6ffffdbe3a5f in test_di_dialoHWND__ ...\wine\dlls\joy.cpl\dinput.c:809 #4 0x6ffffa5c3f6e in WINPROC_wrapper ...\wine\dlls\user32\winproc.c:86 #5 0x6ffffa5c3b6e in call_dialog_proc ...\wine\dlls\user32\winproc.c:130 #6 0x6ffffa5c3c6e in WINPROC_CallDlgProcW ...\wine\dlls\user32\winproc.c:951 #7 0x6ffffa58f8cc in USER_DefDlgProcW ...\wine\dlls\user32\defdlg.c:375 #8 0x6ffffa58f864 in USER_DefDlgProc ...\wine\dlls\user32\defdlg.c:420 #9 0x6ffffb4a39d5 in UXTHEME_DefDlgProc ...\wine\dlls\uxtheme\dialog.c:192 #10 0x6ffffa58fb8d in DialogWndProcW ...\wine\dlls\user32\defdlg.c:438 #11 0x6fffffdaffdf in NtdllDialogWndProc_W+0xf (C:\windows\system32\ntdll.dll+0x17003ffdf) #12 0x6ffffa5c3f6e in WINPROC_wrapper ...\wine\dlls\user32\winproc.c:86 #13 0x6ffffa5c2ba8 in call_window_proc ...\wine\dlls\user32\winproc.c:111 #14 0x6ffffa5c2d92 in dispatch_win_proc_params ...\wine\dlls\user32\winproc.c #15 0x6ffffa5aee20 in dispatwin_proc_params ...\wine\dlls\user32\message.c:567 #16 0x6ffffa5aeda4 in SendMessageW ...\wine\dlls\user32\message.c:586 #17 0x6ffffde75873 in PROPSHEET_Cancel ...\wine\dlls\comctl32\propsheet.c:1949 #18 0x6ffffde75b80 in PROPSHEET_DoCommand ...\wine\dlls\comctl32\propsheet.c:3359 #19 0x6ffffde7085e in PROPSHEET_DialogProc ...\wine\dlls\comctl32\propsheet.c:3694 #20 0x6ffffa5c3f6e in WINPROC_wrapper ...\wine\dlls\user32\winproc.c:86 #21 0x6ffffa5c3b6e in call_dialog_proc ...\wine\dlls\user32\winproc.c:130 #22 0x6ffffa5c3c6e in WINPROC_CallDlgProcW ...\wine\dlls\user32\winproc.c:951 #23 0x6ffffa58f8cc in USER_DefDlgProcW ...\wine\dlls\user32\defdlg.c:375 #24 0x6ffffa58f864 in USER_DefDlgProc ...\wine\dlls\user32\defdlg.c:420 #25 0x6ffffb4a39d5 in UXTHEME_DefDlgProc ...\wine\dlls\uxtheme\dialog.c:192 #26 0x6ffffa58fb8d in DialogWndProcW ...\wine\dlls\user32\defdlg.c:438 #27 0x6fffffdaffdf in NtdllDialogWndProc_W+0xf (C:\windows\system32\ntdll.dll+0x17003ffdf) #28 0x6ffffa5c3f6e in WINPROC_wrapper ...\wine\dlls\user32\winproc.c:86 #29 0x6ffffa5c2ba8 in call_window_proc ...\wine\dlls\user32\winproc.c:111 #30 0x6ffffa5c2d92 in dispatch_win_proc_params ...\wine\dlls\user32\winproc.c #31 0x6ffffa5aee20 in dispatwin_proc_params ...\wine\dlls\user32\message.c:567 #32 0x6ffffa5aeda4 in SendMessageW ...\wine\dlls\user32\message.c:586 #33 0x6ffffdd9a2fb in BUTTON_WindowProc+0x1c7b (C:\windows\winsxs\amd64_microsoft.windows.common-controls_6595b64144ccf1df_6.0.2600.2982_none_deadbeef\comctl32.dll+0x18000a2fb) #34 0x6ffffa5c3f6e in WINPROC_wrapper ...\wine\dlls\user32\winproc.c:86 #35 0x6ffffa5c2ba8 in call_window_proc ...\wine\dlls\user32\winproc.c:111 #36 0x6ffffa5c2d92 in dispatch_win_proc_params ...\wine\dlls\user32\winproc.c #37 0x6ffffa5af7db in dispatch_message ...\wine\dlls\user32\message.c:804 #38 0x6ffffa5af881 in DispatchMessageW ...\wine\dlls\user32\message.c:890 #39 0x6ffffa591e90 in IsDialogMessageW ...\wine\dlls\user32\dialog.c:1293 #40 0x6ffffde76a93 in PROPSHEET_IsDialogMessage ...\wine\dlls\comctl32\propsheet.c:2956 #41 0x6ffffde6fd45 in do_loop ...\wine\dlls\comctl32\propsheet.c:2971 #42 0x6ffffde6c938 in PROPSHEET_PropertySheet ...\wine\dlls\comctl32\propsheet.c:3013 #43 0x6ffffde6cddd in PropertySheetW ...\wine\dlls\comctl32\propsheet.c:3124 #44 0x6ffffdbe754c in display_cpl_sheets ...\wine\dlls\joy.cpl\main.c:482 #45 0x6ffffdbe6d2f in CPlApplet ...\wine\dlls\joy.cpl\main.c:570 #46 0x6ffffb98f235 in Control_DoLaunch ...\wine\dlls\shell32\control.c:822 #47 0x6ffffb98e8e4 in Control_RunDLLW ...\wine\dlls\shell32\control.c:847 #48 0x0001400011b6 in launch+0x26 (C:\windows\system32\control.exe+0x1400011b6) #49 0x000140001044 in STANCE__+0x44 (C:\windows\system32\control.exe+0x140001044) #50 0x000140001320 in wmain+0xb0 (C:\windows\system32\control.exe+0x140001320) #51 0x000140001245 in wmainCRTStartup ...\wine\dlls\msvcrt\crt_wmain.c:58 #52 0x6fffffc3565e in BaseThreadInitThunk ...\wine\dlls\kernel32\thread.c:61 #53 0x6fffffdbbb1a (C:\windows\system32\ntdll.dll+0x17004bb1a) 0x7f07e3ae0568 is located 8 bytes inside of 68-byte region [0x7f07e3ae0560,0x7f07e3ae05a4) freed by thread T0 here: #0 0x6ffffe84a381 in free+0x81 (C:\windows\system32\libclang_rt.asan_dynamic-x86_64.dll+0x18004a381) #1 0x6ffffdc6eff8 in I_ScUnregisterDeviceNotification ...\wine\dlls\sechost\service.c:2196 #2 0x6ffffa5a16e2 in UnregisterDeviceNotification ...\wine\dlls\user32\input.c:594 #3 0x6ffffdbe3a5f in test_di_dialoHWND__ ...\wine\dlls\joy.cpl\dinput.c:809 #4 0x6ffffa5c3f6e in WINPROC_wrapper ...\wine\dlls\user32\winproc.c:86 #5 0x6ffffa5c3b6e in call_dialog_proc ...\wine\dlls\user32\winproc.c:130 #6 0x6ffffa5c3c6e in WINPROC_CallDlgProcW ...\wine\dlls\user32\winproc.c:951 #7 0x6ffffa58f8cc in USER_DefDlgProcW ...\wine\dlls\user32\defdlg.c:375 #8 0x6ffffa58f864 in USER_DefDlgProc ...\wine\dlls\user32\defdlg.c:420 #9 0x6ffffb4a39d5 in UXTHEME_DefDlgProc ...\wine\dlls\uxtheme\dialog.c:192 #10 0x6ffffa58fb8d in DialogWndProcW ...\wine\dlls\user32\defdlg.c:438 #11 0x6fffffdaffdf in NtdllDialogWndProc_W+0xf (C:\windows\system32\ntdll.dll+0x17003ffdf) #12 0x6ffffa5c3f6e in WINPROC_wrapper ...\wine\dlls\user32\winproc.c:86 #13 0x6ffffa5c2ba8 in call_window_proc ...\wine\dlls\user32\winproc.c:111 #14 0x6ffffa5c2d92 in dispatch_win_proc_params ...\wine\dlls\user32\winproc.c #15 0x6ffffa5aee20 in dispatwin_proc_params ...\wine\dlls\user32\message.c:567 #16 0x6ffffa5aeda4 in SendMessageW ...\wine\dlls\user32\message.c:586 #17 0x6ffffde75df3 in PROPSHEET_CanSetCurSel ...\wine\dlls\comctl32\propsheet.c:2120 #18 0x6ffffde702ef in PROPSHEET_DialogProc ...\wine\dlls\comctl32\propsheet.c:3722 #19 0x6ffffa5c3f6e in WINPROC_wrapper ...\wine\dlls\user32\winproc.c:86 #20 0x6ffffa5c3b6e in call_dialog_proc ...\wine\dlls\user32\winproc.c:130 #21 0x6ffffa5c3c6e in WINPROC_CallDlgProcW ...\wine\dlls\user32\winproc.c:951 #22 0x6ffffa58f8cc in USER_DefDlgProcW ...\wine\dlls\user32\defdlg.c:375 #23 0x6ffffa58f864 in USER_DefDlgProc ...\wine\dlls\user32\defdlg.c:420 #24 0x6ffffb4a39d5 in UXTHEME_DefDlgProc ...\wine\dlls\uxtheme\dialog.c:192 #25 0x6ffffa58fb8d in DialogWndProcW ...\wine\dlls\user32\defdlg.c:438 #26 0x6fffffdaffdf in NtdllDialogWndProc_W+0xf (C:\windows\system32\ntdll.dll+0x17003ffdf) #27 0x6ffffa5c3f6e in WINPROC_wrapper ...\wine\dlls\user32\winproc.c:86 previously allocated by thread T0 here: #0 0x6ffffe84a5b6 in calloc+0x86 (C:\windows\system32\libclang_rt.asan_dynamic-x86_64.dll+0x18004a5b6) #1 0x6ffffdc6e50b in I_ScRegisterDeviceNotification ...\wine\dlls\sechost\service.c:2141 #2 0x6ffffa5a1377 in RegisterDeviceNotificationW ...\wine\dlls\user32\input.c #3 0x6ffffdbe398c in test_di_dialoHWND__ ...\wine\dlls\joy.cpl\dinput.c:795 #4 0x6ffffa5c3f6e in WINPROC_wrapper ...\wine\dlls\user32\winproc.c:86 #5 0x6ffffa5c3b6e in call_dialog_proc ...\wine\dlls\user32\winproc.c:130 #6 0x6ffffa5c3c6e in WINPROC_CallDlgProcW ...\wine\dlls\user32\winproc.c:951 #7 0x6ffffa58f8cc in USER_DefDlgProcW ...\wine\dlls\user32\defdlg.c:375 #8 0x6ffffa58f864 in USER_DefDlgProc ...\wine\dlls\user32\defdlg.c:420 #9 0x6ffffb4a39d5 in UXTHEME_DefDlgProc ...\wine\dlls\uxtheme\dialog.c:192 #10 0x6ffffa58fb8d in DialogWndProcW ...\wine\dlls\user32\defdlg.c:438 #11 0x6fffffdaffdf in NtdllDialogWndProc_W+0xf (C:\windows\system32\ntdll.dll+0x17003ffdf) #12 0x6ffffa5c3f6e in WINPROC_wrapper ...\wine\dlls\user32\winproc.c:86 #13 0x6ffffa5c2ba8 in call_window_proc ...\wine\dlls\user32\winproc.c:111 #14 0x6ffffa5c2d92 in dispatch_win_proc_params ...\wine\dlls\user32\winproc.c #15 0x6ffffa5aee20 in dispatwin_proc_params ...\wine\dlls\user32\message.c:567 #16 0x6ffffa5aeda4 in SendMessageW ...\wine\dlls\user32\message.c:586 #17 0x6ffffde73e49 in PROPSHEET_SetCurSel ...\wine\dlls\comctl32\propsheet.c:2199 #18 0x6ffffde702c3 in PROPSHEET_DialogProc ...\wine\dlls\comctl32\propsheet.c:3717 #19 0x6ffffa5c3f6e in WINPROC_wrapper ...\wine\dlls\user32\winproc.c:86 #20 0x6ffffa5c3b6e in call_dialog_proc ...\wine\dlls\user32\winproc.c:130 #21 0x6ffffa5c3c6e in WINPROC_CallDlgProcW ...\wine\dlls\user32\winproc.c:951 #22 0x6ffffa58f8cc in USER_DefDlgProcW ...\wine\dlls\user32\defdlg.c:375 #23 0x6ffffa58f864 in USER_DefDlgProc ...\wine\dlls\user32\defdlg.c:420 #24 0x6ffffb4a39d5 in UXTHEME_DefDlgProc ...\wine\dlls\uxtheme\dialog.c:192 #25 0x6ffffa58fb8d in DialogWndProcW ...\wine\dlls\user32\defdlg.c:438 #26 0x6fffffdaffdf in NtdllDialogWndProc_W+0xf (C:\windows\system32\ntdll.dll+0x17003ffdf) #27 0x6ffffa5c3f6e in WINPROC_wrapper ...\wine\dlls\user32\winproc.c:86 SUMMARY: AddressSanitizer: heap-use-after-free ...\wine\include\wine\list.h:100 in list_remove Shadow bytes around the buggy address: 0x7f07e3ae0280: fd fd fd fa fa fa fa fa 00 00 00 00 00 00 00 00 0x7f07e3ae0300: 06 fa fa fa fa fa fd fd fd fd fd fd fd fd fd fd 0x7f07e3ae0380: fa fa fa fa fd fd fd fd fd fd fd fd fd fa fa fa 0x7f07e3ae0400: fa fa 00 00 00 00 00 00 00 00 06 fa fa fa fa fa 0x7f07e3ae0480: fd fd fd fd fd fd fd fd fd fd fa fa fa fa 00 00 =>0x7f07e3ae0500: 00 00 00 00 00 00 04 fa fa fa fa fa fd[fd]fd fd 0x7f07e3ae0580: fd fd fd fd fd fa fa fa fa fa fd fd fd fd fd fd 0x7f07e3ae0600: fd fd fd fa fa fa fa fa fd fd fd fd fd fd fd fd 0x7f07e3ae0680: fd fa fa fa fa fa fd fd fd fd fd fd fd fd fd fa 0x7f07e3ae0700: fa fa fa fa fd fd fd fd fd fd fd fd fd fa fa fa 0x7f07e3ae0780: fa fa fd fd fd fd fd fd fd fd fd fd fa fa fa fa Shadow byte legend (one shadow byte represents 8 application bytes): Addressable: 00 Partially addressable: 01 02 03 04 05 06 07 Heap left redzone: fa Freed heap region: fd Stack left redzone: f1 Stack mid redzone: f2 Stack right redzone: f3 Stack after return: f5 Stack use after scope: f8 Global redzone: f9 Global init order: f6 Poisoned by user: f7 Container overflow: fc Array cookie: ac Intra object redzone: bb ASan internal: fe Left alloca redzone: ca Right alloca redzone: cb ==control.exe==536==ABORTING ``` </details> -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7719

3 2

[PATCH v2 0/6] MR7708: Fix Imperiums: Greek Wars (1183470) not covering the entire screen in fullscreen mode.
by Zhiyi Zhang (＠zhiyi) 02 Apr '25

02 Apr '25

-- v2: win32u: Properly scale monitor work area when emulate_modeset is enabled. https://gitlab.winehq.org/wine/wine/-/merge_requests/7708

3 8

Re: [PATCH v3 0/1] MR7633: win32u: Fixed the sign error in the conversion from FIXED to FT_Fixed
by Huw Davies (＠huw) 02 Apr '25

02 Apr '25

On Wed Apr 2 01:09:11 2025 +0000, Yeshun Ye wrote: > Subjectively, I do believe it is indeed an issue with FreeType, as its > documentation does not explicitly specify how to handle the high 32 > bits. I submitted the patch to Wine simply because I am more familiar > with Wine. Since you think this approach is inappropriate, I will try > submitting the patch to FreeType instead. Should I close this merge > request now? Yes, let's close this MR. If the freetype folks push back, we can reopen it. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7633#note_99643

1 0

Re: [PATCH v3 0/1] MR7633: win32u: Fixed the sign error in the conversion from FIXED to FT_Fixed - closed
by Huw Davies (＠huw) 02 Apr '25

02 Apr '25

This merge request was closed by Huw Davies. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7633

1 0

[PATCH v7 0/6] MR6866: ntdll: On macOS x86_64, swap GSBASE between the TEB and macOS TSD when entering/leaving PE code.
by Brendan Shanks (＠bshanks) 02 Apr '25

02 Apr '25

x86_64 Windows and macOS both use `%gs` to access thread-specific data (Windows TEB, macOS TSD). To date, Wine has worked around this conflict by filling the most important TEB fields (`0x30`/`Self`, `0x58`/`ThreadLocalStorage`) in the macOS TSD structure (Apple reserved the fields for our use). This was sufficient for most Windows apps. CrossOver's Wine had an additional hack to handle `0x60`/`ProcessEnvironmentBlock`, and binary patches for certain CEF binaries which directly accessed `0x8`/`StackBase`. Additionally, Apple's libd3dshared could activate a special mode in Rosetta 2 where code executing in certain regions would use the Windows TEB when accessing `%gs`. Now that the PE separation is complete, GSBASE can be swapped when entering/exiting PE code. This is done in the syscall dispatcher, unix-call dispatcher, and for user-mode callbacks. GSBASE also needs to be set to the macOS TSD when entering signal handlers (in `init_handler()`), and then restored to the Windows TEB when exiting (in `leave_handler()`). Some changes to the syscall dispatcher were needed to ensure that the TEB is not accessed through `%gs` while on the kernel stack (since a SIGUSR1 while on the kernel stack will result in GSBASE being set to the TSD). --- I've tested this successfully on macOS 15 (Apple Silicon and Intel) and macOS 10.13 with several apps and games, including the `cefclient.exe` CEF sample. Encouragingly, in some simple tests I didn't see a noticeable performance regression from this MR. There are drawbacks though: - libraries which jump directly from PE code into Unix code (expecting that %gs is always pointing to the macOS TSD) will crash. Notable examples are D3DMetal and DXMT. These will need to be changed to use Unix calls. - If Windows code uses the `syscall` instruction directly, the stack pointer likely needs to be valid (which is probably not true on Windows). This is due to the syscall dispatcher saving registers onto the user stack and having to call `_thread_set_tsd_base`. I can't say I've ever seen direct syscalls done with an invalid `%rsp`, but it seems like something anticheat code might do. --- macOS does not have a public API for setting GSBASE, but the private `_thread_set_tsd_base()` works and was added in macOS 10.12. `_thread_set_tsd_base()` is a small thunk that sets `%esi`, `%eax`, and does the `syscall`: https://github.com/apple-oss-distributions/xnu/blob/8d741a5de7ff4191bf97d57…. The syscall instruction itself clobbers `%rcx` and `%r11`. I've tried to save as few registers as possible when calling `_thread_set_tsd_base()`, but there may be room for improvement there. --- I also tested an alternate implementation strategy for this which took advantage of the expanded "full" thread state which is passed to signal handlers when a process has set a user LDT. The full thread state includes GSBASE, so GSBASE is set back to whatever is in the sigcontext on return (like every other field in the context). This would avoid needing to explicitly reset GSBASE in `leave_handler()`. This strategy was simpler, but I'm not using it for 2 reasons: - the "full" thread state is only available starting with macOS 10.15, and we still support 10.13. - more crucially, Rosetta 2 doesn't seem to correctly implement the GS.base field of the full thread state. It's set to 0 on entry, and isn't read on exit. -- v7: ntdll: Remove x86_64 Mac-specific TEB access workarounds that are no longer needed. ntdll: On macOS x86_64, swap GSBASE between the TEB and macOS TSD when entering/leaving PE code. ntdll: Set %rsp to be inside syscall_frame before accessing %gs in x86_64 syscall dispatcher. ntdll: Don't access the TEB through %gs when using the kernel stack in x86_64 syscall dispatcher. ntdll: Ensure init_handler runs in signal handlers before any compiler-generated memset calls. ntdll: Remove ugly fallback method for getting a thread's GSBASE on macOS. https://gitlab.winehq.org/wine/wine/-/merge_requests/6866

2 7

[PATCH 0/1] MR7700: gdiplus: Avoid storing NULL in gdip_font_link_section.
by Eric Tian (＠thdaemon) 02 Apr '25

02 Apr '25

In `generate_font_link_info`, because the return value of `GdipCreateFontFromDC` is not checked, section->font might be set to NULL. `GdipMeasureString` calls `gdip_format_string`, which then calls `generate_font_link_info` and `font_link_get_text_extent_point`. In `font_link_get_text_extent_point`, the font from `gdip_font_link_section` is also not checked for NULL, which may cause a crash. Therefore, in `generate_font_link_info`, when `GdipCreateFontFromDC` fails, store `(GpFont *)base_font` (as with `IMLangFontLink_MapFont` failure) to ensure the font in `gdip_font_link_section` is valid. --- This issue was reproduced while using the [QQ Music](https://y.qq.com/download/index.html). Below is the original winedbg log (on Wine 10.4 + wine-staging + DXVK, with some native libraries used. If needed and permitted by WineHQ, I will list them.) (PS: This issue should also be reproduced using generic wine master without third parties) ``` Wine-dbg>frame 1 Wine-dbg>bt Backtrace: 0 0x00000078ed4d58 get_font_hfont+0x30(graphics=<couldn't compute location>, font=<couldn't compute location>, format=<couldn't compute location>, hfont=<couldn't compute location>, lfw_return=<couldn't compute location>, matrix=<couldn't compute location>) [/home/up/wine/build32/../wine/dlls/gdiplus/graphics.c:2476] in gdiplus (0x0000000073f700) =>1 0x00000078ed21bd font_link_get_text_extent_point+0xb9(info=000000000073F774, index=0, length=0xb, max_ext=0x7fffff83, fit=000000000073F7CC, size=000000000073F7B0) [/home/up/wine/build32/../wine/dlls/gdiplus/g raphics.c:5537] in gdiplus (0x0000000073f74c) 2 0x00000078ed340d gdip_format_string+0x2f9(graphics=0000000003665DD0, hdc=0000000034010075, string=L"Q音听我想听的歌???", length=0xb, font=0000000003672700, rect=000000000073F864, format=0000000009FEB508, ignore_empt y_clip=0x1, callback=0000000078EDADC8, user_data=000000000073F878) [/home/up/wine/build32/../wine/dlls/gdiplus/graphics.c:5663] in gdiplus (0x0000000073f81c) 3 0x00000078ea8283 GdipMeasureString+0x3cb(graphics=<couldn't compute location>, string=<couldn't compute location>, length=<couldn't compute location>, font=<couldn't compute location>, rect=<couldn't compute location>, format=<couldn't compute location>, bounds=<couldn't compute location>, codepointsfitted=<couldn't compute location>, linesfilled=<couldn't compute location>) [/home/up/wine/build32/../wine/dlls/gdiplu s/graphics.c:6050] in gdiplus (0x0000000073f8c0) 4 0x00000077d41fd2 in qqmusic (+0x31fd2) (0x0000000073f908) 5 0x00000077d3e1c6 in qqmusic (+0x2e1c6) (0x0000000073f96c) 6 0x00000077d3dd11 in qqmusic (+0x2dd11) (0x0000000073f9f8) 7 0x00000077f29bd4 in qqmusic (+0x219bd4) (0x0000000073fa70) 8 0x00000077f29a63 in qqmusic (+0x219a63) (0x0000000073faa0) 9 0x00000077f28760 in qqmusic (+0x218760) (0x0000000073fb08) 10 0x00000077b059d7 in common (+0x1059d7) (0x0000000073fb94) 11 0x00000077b06c35 in common (+0x106c35) (0x0000000073fbc8) 12 0x0000007a038b48 in user32 (+0x8b48) (0x0000000073fbf8) 13 0x0000007a093e43 call_window_proc+0xa7(hwnd=0000000000060138, msg=0x113, wp=0x400, lp=0, result=000000000073FC68, arg=0000000077B06B90) [/home/up/wine/build32/../wine/dlls/user32/winproc.c:111] in user32 (0x 0000000073fc40) 14 0x0000007a09c066 dispatch_win_proc_params+0xce(params=000000000073FCA0) [/home/up/wine/build32/../wine/dlls/user32/winproc.c:710] in user32 (0x0000000073fc7c) 15 0x0000007a09be4a dispatch_message+0x9e(msg=000000000073FDCC, ansi=0) [/home/up/wine/build32/../wine/dlls/user32/message.c:804] in user32 (0x0000000073fcd8) 16 0x0000007a04f530 DispatchMessageW+0xff(msg=000000000073FDCC) [/home/up/wine/build32/../wine/dlls/user32/message.c:890] in user32 (0x0000000073fd60) 17 0x000000780c001d in qqmusic (+0x3b001d) (0x0000000073fe38) 18 0x000000780c0ce6 in qqmusic (+0x3b0ce6) (0x0000000073fea8) 19 0x00000000403af4 in qqmusic (+0x3af4) (0x0000000073fefc) 20 0x00000000403bd6 in qqmusic (+0x3bd6) (0x0000000073ff50) 21 0x0000007bcdeb10 in kernel32 (+0xeb10) (0x0000000073ff68) 22 0x0000007be0d083 in ntdll (+0xd083) (0x0000000073ff78) 23 0x0000007be435b2 call_thread_func+0x2e(entry=000000000040678E, arg=00000000003F1000) [/home/up/wine/build32/../wine/dlls/ntdll/signal_i386.c:526] in ntdll (0x0000000073ffec) Wine-dbg>info locals 0x00000078ed21bd font_link_get_text_extent_point+0xb9: (0073f74c) struct gdip_format_string_info* info=000000000073F774 (parameter [EBP+8]) INT index=0 (parameter [EBP+12]) int length=0xb (parameter [EBP+16]) int max_ext=0x7fffff83 (parameter [EBP+20]) LPINT fit=000000000073F7CC (parameter [EBP+24]) SIZE* size=000000000073F7B0 (parameter [EBP+28]) DWORD to_measure_length=0x3 (local [EBP-16]) HFONT hfont=000000000D0A00AE (local [EBP-24]) HFONT oldhfont=000000004C0A00B0 (local [EBP-20]) SIZE sizeaux={cx=0x7c, cy=0x13} (local [EBP-32]) int i=0x8 (local [EBP-8]) int fitaux=0x8 (local [EBP-36]) struct gdip_font_link_section* section=00000000037E31A8 (local [EBP-12]) Wine-dbg>p *section Exception c0000005 Wine-dbg>x/10x 0x00000000037E31A8 0x000000037e31a8: 0073f78c 037e3188 00000008 0000000b 0x000000037e31b8: 00000000 00000000 00000004 8146001b 0x000000037e31c8: 78e0c030 78e0c030 ``` -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7700

4 5

Re: [PATCH v3 0/1] MR7633: win32u: Fixed the sign error in the conversion from FIXED to FT_Fixed
by Yeshun Ye (＠yeyeshun) 02 Apr '25

02 Apr '25

On Wed Apr 2 01:09:11 2025 +0000, Huw Davies wrote: > Could you explain why we need this? Why does it matter how freetype is > compiled; isn't that an ABI breakage on their side? Subjectively, I do believe it is indeed an issue with FreeType, as its documentation does not explicitly specify how to handle the high 32 bits. I submitted the patch to Wine simply because I am more familiar with Wine. Since you think this approach is inappropriate, I will try submitting the patch to FreeType instead. Should I close this merge request now? -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7633#note_99632

1 0

Re: [PATCH v2 0/1] MR7720: dwmapi: Do not prefer native dll. - approved
by Alexandre Julliard (＠julliard) 01 Apr '25

01 Apr '25

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7720

1 0

Re: [PATCH v3 0/1] MR7245: ntdll: Implement querying StorageDeviceProperty for optical discs. - approved
by Alexandre Julliard (＠julliard) 01 Apr '25

01 Apr '25

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7245

1 0

Re: [PATCH v2 0/1] MR7716: ntdll/tests: Fix a test failure on Windows wow64. - approved
by Alexandre Julliard (＠julliard) 01 Apr '25

01 Apr '25

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7716

1 0

Re: [PATCH v2 0/2] MR7714: winemac: Use the default wglGetPixelFormatAttribivARB implementation. - approved
by Alexandre Julliard (＠julliard) 01 Apr '25

01 Apr '25

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7714

1 0

Re: [PATCH v2 0/1] MR7712: cfgmgr32/tests: Load some functions dynamically. - approved
by Alexandre Julliard (＠julliard) 01 Apr '25

01 Apr '25

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7712

1 0

Re: [PATCH v2 0/2] MR7709: wbemprox: Get rid of the per-table lock. - approved
by Alexandre Julliard (＠julliard) 01 Apr '25

01 Apr '25

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7709

1 0

Re: [PATCH v2 0/1] MR7704: win32u: Implement EVENT_OBJECT_NAMECHANGE. - approved
by Alexandre Julliard (＠julliard) 01 Apr '25

01 Apr '25

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7704

1 0

Re: [PATCH v13 0/5] MR7569: mfplat/tests: Various fixes in preparation for tests against Byte Stream Timestamps. - approved
by Alexandre Julliard (＠julliard) 01 Apr '25

01 Apr '25

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7569

1 0

[PATCH 0/1] MR7720: dwmapi: Do not prefer native dll.
by Louis Lenders (＠xe) 01 Apr '25

01 Apr '25

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=58052 -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7720

2 1

[PATCH v3 0/5] MR7707: msvcp140: Implement codecvt<char16_t, char> conversions.
by Paul Gofman (＠gofman) 01 Apr '25

01 Apr '25

-- v3: wineboot: Initialize proxy settings registry key. msvcp: Fix output size check in codecvt_wchar_do_out(). msvcp140: Implement codecvt_char16_do_in(). msvcp140: Implement codecvt_char16_do_out(). msvcp140: Implement codecvt_char16 ctors and dtor. https://gitlab.winehq.org/wine/wine/-/merge_requests/7707

3 6

[PATCH v2 0/4] MR7425: jscript: Obtain the jsdisp for host objects in other contexts.
by Gabriel Ivăncescu (＠insn) 01 Apr '25

01 Apr '25

-- v2: jscript: Get rid of the funcprot argument. mshtml: Release the node if there's no script global when handling events. jscript: Obtain the jsdisp for host objects in other contexts. mshtml: Keep the link from the inner window to the outer window even when https://gitlab.winehq.org/wine/wine/-/merge_requests/7425

3 9

Re: [PATCH v20 0/1] MR6938: winewayland.drv: Implement support for xdg-toplevel-icon.
by Etaash Mathamsetty (＠etaash.mathamsetty) 01 Apr '25

01 Apr '25

v3: applied more suggestions -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6938#note_99569

1 0

[PATCH v19 0/1] MR6938: winewayland.drv: Implement support for xdg-toplevel-icon.
by Etaash Mathamsetty (＠etaash.mathamsetty) 01 Apr '25

01 Apr '25

-- v19: winewayland.drv: Implement support for xdg-toplevel-icon. https://gitlab.winehq.org/wine/wine/-/merge_requests/6938

2 1

[PATCH v17 0/1] MR6938: winewayland.drv: Implement support for xdg-toplevel-icon.
by Etaash Mathamsetty (＠etaash.mathamsetty) 01 Apr '25

01 Apr '25

-- v17: winewayland.drv: Implement support for xdg-toplevel-icon. https://gitlab.winehq.org/wine/wine/-/merge_requests/6938

2 1

[PATCH v16 0/1] MR6938: winewayland.drv: Implement support for xdg-toplevel-icon.
by Etaash Mathamsetty (＠etaash.mathamsetty) 01 Apr '25

01 Apr '25

-- v16: winewayland.drv: Implement support for xdg-toplevel-icon. https://gitlab.winehq.org/wine/wine/-/merge_requests/6938

2 1

[PATCH v2 0/4] MR7707: msvcp140: Implement codecvt<char16_t, char> conversions.
by Paul Gofman (＠gofman) 01 Apr '25

01 Apr '25

-- v2: msvcp: Fix output size check in codecvt_wchar_do_out(). msvcp140: Implement codecvt_char16_do_in(). msvcp140: Implement codecvt_char16_do_out(). msvcp140: Implement codecvt_char16 ctors and dtor. https://gitlab.winehq.org/wine/wine/-/merge_requests/7707

3 7

[PATCH v14 0/1] MR6938: winewayland.drv: Implement support for xdg-toplevel-icon.
by Etaash Mathamsetty (＠etaash.mathamsetty) 01 Apr '25

01 Apr '25

-- v14: winewayland.drv: Implement support for xdg-toplevel-icon. https://gitlab.winehq.org/wine/wine/-/merge_requests/6938

2 1

[PATCH v13 0/1] MR6938: winewayland.drv: Implement support for xdg-toplevel-icon.
by Etaash Mathamsetty (＠etaash.mathamsetty) 01 Apr '25

01 Apr '25

-- v13: winewayland.drv: Implement support for xdg-toplevel-icon. https://gitlab.winehq.org/wine/wine/-/merge_requests/6938

2 1

[PATCH v13 0/6] MR7610: win32u: Create a shared object for user handle entries.
by Rémi Bernon (＠rbernon) 01 Apr '25

01 Apr '25

For https://gitlab.winehq.org/wine/wine/-/merge_requests/7512 to use it to locate window shared objects. -- v13: win32u: Use the session shared object for user handle entries. win32u: Use the session shared object to implement is_window. server: Move the user object handle table to the shared memory. server: Allocate a session shared memory header structure. server: Use NTUSER_OBJ constants for user object types. include: Implement ReadAcquire64. https://gitlab.winehq.org/wine/wine/-/merge_requests/7610

3 10

Re: [PATCH v3 0/1] MR7633: win32u: Fixed the sign error in the conversion from FIXED to FT_Fixed
by Huw Davies (＠huw) 01 Apr '25

01 Apr '25

Could you explain why we need this? Why does it matter how freetype is compiled; isn't that an ABI breakage on their side? -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7633#note_99532

1 0

[PATCH 0/4] MR7707: msvcp140: Implement codecvt<char16_t, char> conversions.
by Paul Gofman (＠gofman) 01 Apr '25

01 Apr '25

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/7707

3 14

Re: [PATCH v4 0/2] MR7517: ntdll: Do not fail NtCreateUserProcess() if requested access doesn't have PROCESS_CREATE_THREAD.
by Paul Gofman (＠gofman) 01 Apr '25

01 Apr '25

Thanks, no idea how did that happen as I should've been testing it on my Windows including wow64 and it probably passed the testbot. Anyway, I could reproduce it on my Windows 11 and sent a patch: https://gitlab.winehq.org/wine/wine/-/merge_requests/7716 -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7517#note_99519

1 0

[PATCH 0/1] MR7716: ntdll/tests: Fix a test failure on Windows wow64.
by Paul Gofman (＠gofman) 01 Apr '25

01 Apr '25

Fix a failing test on Windows. The original patch introducing the test and related Wine change was concerned about the success with missing PROCESS_CREATE_THREAD access which is still tested. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7716

2 1

[PATCH 0/3] MR7713: ntdll/tests, kernel32/tests: Use the PROCESS_BASIC_INFORMATION struct.
by Rémi Bernon (＠rbernon) 01 Apr '25

01 Apr '25

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/7713

3 5

[PATCH 0/6] MR7708: Fix Imperiums: Greek Wars (1183470) not covering the entire screen in fullscreen mode.
by Zhiyi Zhang (＠zhiyi) 01 Apr '25

01 Apr '25

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/7708

3 7

[PATCH 0/2] MR7714: winemac: Use the default wglGetPixelFormatAttribivARB implementation.
by Rémi Bernon (＠rbernon) 01 Apr '25

01 Apr '25

Like other drivers are now doing. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7714

2 2

[PATCH 0/1] MR7712: cfgmgr32/tests: Load some functions dynamically.
by Rémi Bernon (＠rbernon) 01 Apr '25

01 Apr '25

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/7712

2 1

Re: [PATCH v4 0/2] MR7517: ntdll: Do not fail NtCreateUserProcess() if requested access doesn't have PROCESS_CREATE_THREAD.
by Rémi Bernon (＠rbernon) 01 Apr '25

01 Apr '25

Fwiw on Windows WOW64 the test fails with: ``` thread.c:238: Test failed: Got unexpected status 0xc0000022. thread.c:240: Test failed: Got unexpected status 0xc0000008. ``` -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7517#note_99503

1 0

[PATCH v12 0/1] MR6938: winewayland.drv: Implement support for xdg-toplevel-icon.
by Etaash Mathamsetty (＠etaash.mathamsetty) 01 Apr '25

01 Apr '25

-- v12: winewayland.drv: Implement support for xdg-toplevel-icon. https://gitlab.winehq.org/wine/wine/-/merge_requests/6938

3 10

[PATCH 0/1] MR7702: comctl32: Implement MSAA events for header controls.
by Esme Povirk (＠madewokherd) 01 Apr '25

01 Apr '25

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/7702

3 2

[PATCH 0/2] MR7709: wbemprox: Get rid of the per-table lock.
by Hans Leidekker (＠hans) 01 Apr '25

01 Apr '25

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=56859 -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7709

2 2

[PATCH v12 0/5] MR7569: mfplat/tests: Add tests for Byte Stream Timestamps.
by Brendan McGrath (＠redmcg) 01 Apr '25

01 Apr '25

This MR adds tests to `mfplat` to illustrate the timestamp values output on the samples for the respective Byte Stream handlers. I have also included a fix for a bug in `winegstreamer` (and copied to `mfsrcsnk`) where a `NULL` value for the `pguidTimeFormat` parameter in `IMFMediaSource::Start` causes a segmentation fault. On Windows this is allowed. It is included in this MR as the `mfplat` tests pass NULL (so without this fix, the tests crash). -- v12: mfsrcsnk: Allow NULL for time_format. winegstreamer: Allow NULL for time_format. mfplat/tests: Fix leak of media source. mfplat/tests: Fix leak of media events. mfplat/tests: Fix crash in MFShutdown on Windows. https://gitlab.winehq.org/wine/wine/-/merge_requests/7569

3 11

[PATCH v3 0/7] MR7672: Draft: mfplat/tests: Add tests for Byte Stream Output.
by Brendan McGrath (＠redmcg) 01 Apr '25

01 Apr '25

This MR adds tests that examine the values of the samples output by the byte stream handlers. It is marked as draft as it is dependent on the fixes included within MR !7569. I've also renamed the tests as they previously exclusively tested the sample output timestamps. The tests now also look at the number of buffers included in a sample and total size of the buffers within a sample. -- v3: mfplat/tests: Add tests for MP3 Byte Stream Output. mfplat/tests: Add tests for Byte Stream Output. mfsrcsnk: Allow NULL for time_format. winegstreamer: Allow NULL for time_format. mfplat/tests: Fix leak of media source. mfplat/tests: Fix leak of media events. mfplat/tests: Fix crash in MFShutdown on Windows. https://gitlab.winehq.org/wine/wine/-/merge_requests/7672

2 7

[PATCH 0/4] MR7570: mfreadwrite: Implement encoder creation. (Part 1)
by Ziqing Hui (＠zhui) 01 Apr '25

01 Apr '25

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/7570

3 9

[PATCH 0/1] MR7706: powrprof.dll: Partially implement PowerGetActiveScheme for SteamVR
by Robert Lippmann (＠rlippmann) 01 Apr '25

01 Apr '25

This function is supposed to allocate memory for a GUID on success. Applications should check the return status before trying to access this pointer, but apparently vrmonitor.exe in SteamVR isn't. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7706

2 1

Re: [PATCH v2 0/1] MR7685: powrprof.dll: Partially implement PowerGetActiveScheme for SteamVR - closed
by Robert Lippmann (＠rlippmann) 01 Apr '25

01 Apr '25

This merge request was closed by Robert Lippmann. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7685

1 0

[PATCH v12 0/6] MR7610: Draft: win32u: Create a shared object for user handle entries.
by Rémi Bernon (＠rbernon) 31 Mar '25

31 Mar '25

For https://gitlab.winehq.org/wine/wine/-/merge_requests/7512 to use it to locate window shared objects. -- v12: win32u: Use the session shared object for user handle entries. win32u: Use the session shared object to implement is_window. server: Move the user object handle table to the shared memory. server: Allocate a session shared memory header structure. server: Use NTUSER_OBJ constants for user object types. include: Implement ReadAcquire64. https://gitlab.winehq.org/wine/wine/-/merge_requests/7610

4 11

[PATCH 0/1] MR7704: win32u: Implement EVENT_OBJECT_NAMECHANGE.
by Esme Povirk (＠madewokherd) 31 Mar '25

31 Mar '25

Yak-shaving for https://gitlab.winehq.org/wine/wine/-/merge_requests/7618. I added a test to show that DefWindowProc, specifically, sends this event. The timing is slightly off compared to WM_CTLCOLOR* sometimes, but I think that's fine. There's no reason to expect accessibility tools, specifically, to be sensitive to that. The spurious events with MDI children changing state may be less fine. The MDI code (in user32) uses DefWindowProc internally to change the window text. Somehow, Windows must accomplish this without sending the event, so presumably there's some backdoor or internal interface in win32u that allows for it. There's a possibility that a screen reader responds to the NAMECHANGE by speaking the window title (I have no idea if any screen reader actually does this), which could be annoying to a user. Still, given that I don't know whether it's a problem, and it's extra complexity that we may not even need, I thought it'd be better to send the MR first with that known issue and see what people think. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7704

2 1

Re: [PATCH v4 0/1] MR7697: powrprof: Add stub for PowerRegisterForEffectivePowerModeNotifications. - approved
by Alexandre Julliard (＠julliard) 31 Mar '25

31 Mar '25

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7697

1 0

Re: [PATCH v2 0/7] MR7666: win32u: Introduce a new opengl_driver_funcs structure. - approved
by Alexandre Julliard (＠julliard) 31 Mar '25

31 Mar '25

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7666

1 0

Re: [PATCH v20 0/2] MR6130: shell32: Added stubs for the EnumerableObjectCollection COM class. - approved
by Alexandre Julliard (＠julliard) 31 Mar '25

31 Mar '25

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6130

1 0

Re: [PATCH v2 0/1] MR7690: winewayland: Don't use a destroyed surface in text input. - approved
by Alexandre Julliard (＠julliard) 31 Mar '25

31 Mar '25

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7690

1 0

Re: [PATCH v2 0/1] MR7695: ntdll: Correct NtAllocateReserveObject arguments in specfile. - approved
by Alexandre Julliard (＠julliard) 31 Mar '25

31 Mar '25

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7695

1 0

Re: [PATCH v2 0/1] MR7691: wmphoto: Use CRT allocation functions. - approved
by Alexandre Julliard (＠julliard) 31 Mar '25

31 Mar '25

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7691

1 0

Re: [PATCH v2 0/3] MR7694: adslap: Fix some memory leaks. - approved
by Alexandre Julliard (＠julliard) 31 Mar '25

31 Mar '25

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7694

1 0

Re: [PATCH v2 0/1] MR7693: bcrypt/tests: Add some tests for export/import of BCRYPT_AES_WRAP_KEY_BLOB. - approved
by Alexandre Julliard (＠julliard) 31 Mar '25

31 Mar '25

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7693

1 0

Re: [PATCH v2 0/1] MR7692: adsldp/tests: Fix test failures. - approved
by Alexandre Julliard (＠julliard) 31 Mar '25

31 Mar '25

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7692

1 0

Re: [PATCH v5 0/2] MR7647: gdiplus: Add single point support for GdipGetPathWorldBounds - approved
by Alexandre Julliard (＠julliard) 31 Mar '25

31 Mar '25

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7647

1 0

Re: [PATCH v2 0/1] MR7688: Setupapi: Don't add backslash on absolute dirid - approved
by Alexandre Julliard (＠julliard) 31 Mar '25

31 Mar '25

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7688

1 0

Re: [PATCH v2 0/1] MR7689: mscoree: Update Wine Mono to 10.0.0. - approved
by Alexandre Julliard (＠julliard) 31 Mar '25

31 Mar '25

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7689

1 0

Re: [PATCH v4 0/2] MR7670: windowscodecs/converter: Implement BW -> 24BGR conversion. - approved
by Alexandre Julliard (＠julliard) 31 Mar '25

31 Mar '25

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7670

1 0

[PATCH 0/2] MR4738: ntdll/unix: Don't hardcode page_size, page_shift and page_mask
by Fabian Maurer (＠DarkShadow44) 31 Mar '25

31 Mar '25

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=52715 -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4738

3 4

[PATCH v2 0/1] MR4739: ntdll: Don't hardcode page size
by Fabian Maurer (＠DarkShadow44) 31 Mar '25

31 Mar '25

While this is not needed for 16k pages to work, it does seem sensible. -- v2: ntdll: Don't hardcode page size https://gitlab.winehq.org/wine/wine/-/merge_requests/4739

3 3

[PATCH v11 0/1] MR6938: winewayland.drv: Implement support for xdg-toplevel-icon.
by Etaash Mathamsetty (＠etaash.mathamsetty) 31 Mar '25

31 Mar '25

-- v11: winewayland.drv: Implement support for xdg-toplevel-icon. https://gitlab.winehq.org/wine/wine/-/merge_requests/6938

2 2

[PATCH 0/7] MR7367: winex11: Use _NET_ACTIVE_WINDOW to request/track foreground window.
by Rémi Bernon (＠rbernon) 31 Mar '25

31 Mar '25

This should at least fix foreground window inconsistencies between Wine and X11, when _NET_ACTIVE_WINDOW is supported by the WM, allowing us to then better implement focus tracking (to avoid changing focus when not desired), as well as SWP_NOACTIVATE. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7367

3 10

[PATCH v9 0/1] MR6938: winewayland.drv: Implement support for xdg-toplevel-icon.
by Etaash Mathamsetty (＠etaash.mathamsetty) 31 Mar '25

31 Mar '25

-- v9: winewayland.drv: Implement support for xdg-toplevel-icon. https://gitlab.winehq.org/wine/wine/-/merge_requests/6938

2 1

[PATCH 0/1] MR7695: ntdll: Correct NtAllocateReserveObject arguments in specfile.
by Alex Henrie (＠alexhenrie) 31 Mar '25

31 Mar '25

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/7695

4 4

[PATCH v8 0/1] MR6938: winewayland.drv: Implement support for xdg-toplevel-icon.
by Etaash Mathamsetty (＠etaash.mathamsetty) 31 Mar '25

31 Mar '25

-- v8: winewayland.drv: Implement support for xdg-toplevel-icon. https://gitlab.winehq.org/wine/wine/-/merge_requests/6938

2 1

[PATCH 0/7] MR7666: win32u: Introduce a new opengl_driver_funcs structure.
by Rémi Bernon (＠rbernon) 31 Mar '25

31 Mar '25

And use it to move wglGetExtensionsString(ARB|EXT) to win32u. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7666

3 8

[PATCH v2 0/6] MR7699: winex11: Use _NET_ACTIVE_WINDOW to request/track window activation.
by Rémi Bernon (＠rbernon) 31 Mar '25

31 Mar '25

This implements better active window synchronization between Wine and X11 by requesting _NET_ACTIVE_WINDOW change whenever the Win32 active window changes, using source = 2 (pager) which is more often obeyed than other source values by the window managers. This also implements SWP_NOACTIVATE properly by setting _NET_WM_USER_TIME time to 0 before mapping a window, which has the correct semantics, while later sending _NET_ACTIVE_WINDOW to activate it if it ends up being necessary to match the Win32 logic. -- v2: winex11: Use _NET_ACTIVE_WINDOW to request/track window activation. win32u: Call ActivateWindow callback when foreground window changes. win32u: Return foreground window changes from GetWindowStateUpdates. winex11: Refactor X11DRV_GetWindowStateUpdates control flow. winex11: Keep track of whether mapped window needs activation. winex11: Only set focus_time_prop for managed windows. https://gitlab.winehq.org/wine/wine/-/merge_requests/7699

2 7

Re: [PATCH v2 0/4] MR7562: wined3d: Move FFP extra states away from STATE_RENDER, part 1/4.
by Rémi Bernon (＠rbernon) 31 Mar '25

31 Mar '25

Fwiw f35c563a0589e38253d386b13b0068e3a06f5802 broke d3d8:visual and ddraw:ddraw7 tests. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7562#note_99376

1 0

[PATCH 0/6] MR7699: winex11: Use _NET_ACTIVE_WINDOW to request/track window activation.
by Rémi Bernon (＠rbernon) 31 Mar '25

31 Mar '25

This implements better active window synchronization between Wine and X11 by requesting _NET_ACTIVE_WINDOW change whenever the Win32 active window changes, using source = 2 (pager) which is more often obeyed than other source values by the window managers. This also implements SWP_NOACTIVATE properly by setting _NET_WM_USER_TIME time to 0 before mapping a window, which has the correct semantics, while later sending _NET_ACTIVE_WINDOW to activate it if it ends up being necessary to match the Win32 logic. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7699

2 6

[PATCH v3 0/1] MR7697: powrprof: Add stub for PowerRegisterForEffectivePowerModeNotifications.
by Louis Lenders (＠xe) 31 Mar '25

31 Mar '25

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=56377 This patch makes msedge work in win10 mode, albeit I still have to add "--no-sandbox". Without "--no-sandbox" it doesn't crash anymore with this patch,but I cannot browse webpages, it just looks as if it is unconnected. -- v3: powrprof: Add stub for PowerRegisterForEffectivePowerModeNotifications. https://gitlab.winehq.org/wine/wine/-/merge_requests/7697

2 1

[PATCH 0/1] MR7690: winewayland: Don't use a destroyed surface in text input.
by Attila Fidan (＠atticf) 31 Mar '25

31 Mar '25

Don't assert or get the user data of null surface arguments. When the callbacks are run with a null surface it means the surface was destroyed client-side but the compositor has yet to process the destroy request and has sent events referencing the surface which no longer exists on the client. The wl_surface pointer also needs to be removed during wayland_surface_destroy to prevent it from becoming a dangling pointer which may be used if text_input_done or text_input_leave is run after the surface is destroyed. While doing so, track the hwnd instead to be consistent with keyboard and pointer. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7690

3 4

[PATCH 0/1] MR7697: powrprof: Add stub for PowerRegisterForEffectivePowerModeNotifications.
by Louis Lenders (＠xe) 31 Mar '25

31 Mar '25

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=56377 This patch makes msedge work in win10 mode, albeit I still have to add "--no-sandbox". Without "--no-sandbox" it doesn't crash anymore with this patch,but I cannot browse webpages, it just looks as if it is unconnected. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7697

2 1

Re: [PATCH v7 0/2] MR6294: mlang: Fix bug when multibyte string truncation in ConvertINetMultiByteToUnicode - closed
by Yeshun Ye (＠yeyeshun) 31 Mar '25

31 Mar '25

This merge request was closed by Yeshun Ye. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6294

1 0

[PATCH v11 0/6] MR7650: Add support for AF_UNIX sockets (followup)
by Ralf Habacker (＠rhabacker) 30 Mar '25

30 Mar '25

Follow-up of !2786, which appears to have been abandoned. -- v11: ws2_32/tests: Add test for AF_UNIX sockets. server: Fix getsockname() and accept() on AF_UNIX sockets. server: Introduce error when attempting to create a SOCK_DGRAM AF_UNIX socket. https://gitlab.winehq.org/wine/wine/-/merge_requests/7650

3 7

[PATCH 0/1] MR7691: wmphoto: Use CRT allocation functions.
by Nikolay Sivov (＠nsivov) 30 Mar '25

30 Mar '25

It's important because of the code sharing with windowscodecs. Signed-off-by: Nikolay Sivov <nsivov(a)codeweavers.com> -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7691

3 2

2025

2024

2023

2022

wine-gitlab