- wine-gitlab - winehq.org

[PATCH v5 0/3] MR265: vkd3d-shader/hlsl: Add some more constant folding operations.
by Nikolay Sivov (＠nsivov) 14 Aug '23

14 Aug '23

-- v5: vkd3d-shader/hlsl: Use type width in fold_rcp(). vkd3d-shader/hlsl: Add constant folding for 'log2'. vkd3d-shader/hlsl: Add constant folding for 'sqrt'. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/265

3 4

Re: [PATCH v6 0/2] MR240: vkd3d-shader: Add constant folding for the 'dot' operation. - approved
by Alexandre Julliard (＠julliard) 14 Aug '23

14 Aug '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/240

1 0

Re: [PATCH v4 0/5] MR295: vkd3d-shader: Extend vkd3d_shader_scan_descriptor_info, part 1/2. - approved
by Alexandre Julliard (＠julliard) 14 Aug '23

14 Aug '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/295

1 0

Re: [PATCH v9 0/7] MR281: vkd3d-shader/tpf: Replace sm4 register structs with vkd3d-shader register structs, part 1. - approved
by Alexandre Julliard (＠julliard) 14 Aug '23

14 Aug '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/281

1 0

[PATCH v2 0/1] MR3567: jscript: handle Array.prototype.splice with omitted deleteCount
by Yuxuan Shui (＠yshui) 14 Aug '23

14 Aug '23

Current code handles omitted deleteCount but assumes it to be zero in that case. Instead an omitted deleteCount means delete everything from `start`. This prevents Adobe sign-in page from loading. -- v2: jscript: fix Array.prototype.splice with omitted deleteCount in html mode https://gitlab.winehq.org/wine/wine/-/merge_requests/3567

2 1

[PATCH v4 0/1] MR3546: gdiplus: move pointer calculation outside inner loop for alpha_blend_bmp_pixels
by Bartosz Kosiorek (＠gang65) 14 Aug '23

14 Aug '23

-- v4: gdiplus: move pointer calculation outside inner loop to improve performance https://gitlab.winehq.org/wine/wine/-/merge_requests/3546

5 10

[PATCH 0/1] MR3553: opengl32: Skip debug callback messages called from native thread.
by Paul Gofman (＠gofman) 14 Aug '23

14 Aug '23

Mesa sometimes calls debug message callback from its own Unix native thread. Then it inevitably crashes in KeUserModeCallback(). So far I spotted only harmless notification messages called this way: ``` Shader Stats: SGPRS: 24 VGPRS: 12 Code Size: 124 LDS: 0 Scratch: 0 Max Waves: 10 Spilled SGPRs: 0 Spilled VGPRs: 0 PrivMem VGPRs: 0 Outputs: 1 PatchOutputs: 0 DivergentLoop: 0 InlineUniforms: 0 (PS, W64) ``` So I guess the best is just to ignore the callbacks called from native threads. The only other solution I see in the current architecture is to spin a PE thread from opengl and poll for debug messages, but that looks less than ideal and probably doesn't worth it. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3553

3 3

Re: [PATCH v2 0/1] MR3447: ntdll/unix: NtTerminateThread should accept NULL handle
by Alexandre Julliard (＠julliard) 14 Aug '23

14 Aug '23

> There's no special logic for NULL handles in the client side of NtTerminateProcess() Actually there is some logic, and NULL handle has a special meaning in NtTerminateProcess. This would need tests to determine if the special meaning also applies to NtTerminateThread. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3447#note_42184

1 0

[PATCH v5 0/1] MR3436: include: Add xamlom.idl file.
by Paul Jackson (＠mailnew4ster) 14 Aug '23

14 Aug '23

Continuation of https://gitlab.winehq.org/wine/wine/-/merge_requests/2773 I tried to address all comments. @zfigura please take a look. cc @Biswa96 -- v5: include: Add xamlom.idl file. https://gitlab.winehq.org/wine/wine/-/merge_requests/3436

2 2

[PATCH v4 0/1] MR3437: include: Add windows.ui.xaml.hosting.desktopwindowxamlsource.idl file.
by Paul Jackson (＠mailnew4ster) 14 Aug '23

14 Aug '23

Continuation of https://gitlab.winehq.org/wine/wine/-/merge_requests/2959 No changes were made. @zfigura please take a look. cc @Biswa96 -- v4: include: Add windows.ui.xaml.hosting.desktopwindowxamlsource.idl file. https://gitlab.winehq.org/wine/wine/-/merge_requests/3437

2 1

[PATCH v4 0/1] MR3436: include: Add xamlom.idl file.
by Paul Jackson (＠mailnew4ster) 14 Aug '23

14 Aug '23

Continuation of https://gitlab.winehq.org/wine/wine/-/merge_requests/2773 I tried to address all comments. @zfigura please take a look. cc @Biswa96 -- v4: include: Add xamlom.idl file. https://gitlab.winehq.org/wine/wine/-/merge_requests/3436

4 3

Re: [PATCH v4 0/3] MR265: vkd3d-shader/hlsl: Add some more constant folding operations. - approved
by Henri Verbeet (＠hverbeet) 14 Aug '23

14 Aug '23

This merge request was approved by Henri Verbeet. -- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/265

1 0

Re: [PATCH v5 0/2] MR240: vkd3d-shader: Add constant folding for the 'dot' operation. - approved
by Henri Verbeet (＠hverbeet) 14 Aug '23

14 Aug '23

This merge request was approved by Henri Verbeet. -- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/240

1 0

[PATCH v3 0/4] MR3554: mmdevapi: fixes for Yousician
by David McFarland (＠corngood) 14 Aug '23

14 Aug '23

Since Yousician's last update, it was throwing an error when initialising audio output. Unfortunately I don't have access to the old version, but they seem to have dropped win<10 support, and are using only IAudioClient3_InitializeSharedAudioStream. They also use IDeviceTopology to get the type of the first output connector. This is the bare minimum I needed to get it working. -- v3: mmdevapi: add stub for IDeviceTopology mmdevapi/tests: add test for IDeviceTopology https://gitlab.winehq.org/wine/wine/-/merge_requests/3554

4 15

[PATCH v3 0/12] MR3542: mshtml: Implement Cycle Collection for all mshtml objects (dispex), part 4.
by Gabriel Ivăncescu (＠insn) 14 Aug '23

14 Aug '23

The first few patches will introduce temporary leaks or cyclic refs, but that's because we'll handle them properly with the dispex CC, and the last patch should fix this. Other objects' traversal will follow in another MR. -- v3: mshtml: Traverse inner windows. mshtml: Traverse variants using a helper function. mshtml: Implement Cycle Collection for dispex without traversal. mshtml: Implement Cycle Collection for outer windows. mshtml: Split IUnknown methods for outer windows into separate vtable. mshtml: Use unlink and destructor in the vtbl for HTMLLocation. mshtml: Separate the HTMLLocation from the outer window. mshtml: Use unlink and destructor in the vtbl for PerformanceTiming. mshtml: Move PerformanceTiming related fields to the window. mshtml: Move PerformanceNavigation related fields to the window. mshtml: Move console to the inner window. mshtml: Use ASCII strings for dispex object names. https://gitlab.winehq.org/wine/wine/-/merge_requests/3542

3 16

[PATCH v3 0/3] MR268: vkd3d-shader/hlsl: Handle vector arguments in fmod().
by Nikolay Sivov (＠nsivov) 14 Aug '23

14 Aug '23

-- v3: tests: Add a test for fmod() with vector arguments. vkd3d-shader: Use ternary operator in fmod() implementation. vkd3d-shader/tpf: Use 'movc' to implement ternary operator. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/268

2 3

[PATCH 0/1] MR3564: configure: fix caching of PCSCLITE_LIBS on mac
by David McFarland (＠corngood) 14 Aug '23

14 Aug '23

ac_cv_lib_pcsclite_SCardEstablishContext=yes would be cached, causing AC_CHECK_LIB to use -lpcsclite on the second run. Fixes: f74c4af257e0856e6607d2823e4f03109111a4b6 This was failing when more than one commit was being built with a `cache.config`. Example of a build with this failure: https://gitlab.winehq.org/corngood/wine/-/jobs/25354 Example of a successful build with multiple changes on top of this one: https://gitlab.winehq.org/corngood/wine/-/jobs/25406 -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3564

3 3

[PATCH v2 0/3] MR3531: mfplat: Use the io queue for bytestream requests.
by Rémi Bernon (＠rbernon) 14 Aug '23

14 Aug '23

Avoid blocking the default callback queue with file I/O. -- v2: mfplat: Use MFASYNC_CALLBACK_QUEUE_IO for byte stream async requests. mfplat/tests: Test that BeginRead doesn't use MFASYNC_CALLBACK_QUEUE_STANDARD. mfplat/tests: Create the test_callback event in the constructor. https://gitlab.winehq.org/wine/wine/-/merge_requests/3531

3 4

[PATCH v5 0/1] MR3559: gdiplus: add new test cases to GdipCreateCustomLineCap
by Bartosz Kosiorek (＠gang65) 14 Aug '23

14 Aug '23

-- v5: gdiplus: add new test cases to GdipCreateCustomLineCap https://gitlab.winehq.org/wine/wine/-/merge_requests/3559

3 4

[PATCH 0/2] MR303: vkd3d-shader/hlsl: Parse "if" statement attributes.
by Nikolay Sivov (＠nsivov) 14 Aug '23

14 Aug '23

Signed-off-by: Nikolay Sivov <nsivov(a)codeweavers.com> -- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/303

3 5

[PATCH v4 0/1] MR3559: gdiplus: add new test cases to GdipCreateCustomLineCap
by Bartosz Kosiorek (＠gang65) 14 Aug '23

14 Aug '23

-- v4: gdiplus: add new test cases to GdipCreateCustomLineCap https://gitlab.winehq.org/wine/wine/-/merge_requests/3559

3 2

[PATCH 0/1] MR3557: server: Fix 100% CPU usage when a process is suspended (debugged) in WSAPoll
by Torge Matthies (＠tmatthies) 13 Aug '23

13 Aug '23

This has been annoying me for at least 3 years now. I have no idea why the later check for `async_queued( &sock->read_q )` and `async_waiting( &sock->read_q )` doesn't catch this case, but this commit fixes it so idc too much. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3557

3 4

[PATCH 0/1] MR3562: opengl32: Preserve the remainder of the version string when limiting the version to 4.3.
by Zebediah Figura (＠zfigura) 13 Aug '23

13 Aug '23

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/3562

2 1

Re: [PATCH v6 0/3] MR200: vkd3d-shader: Signature reflection API. - approved
by Zebediah Figura (＠zfigura) 13 Aug '23

13 Aug '23

This merge request was approved by Zebediah Figura. -- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/200

1 0

[PATCH v2 0/3] MR268: vkd3d-shader/hlsl: Handle vector arguments in fmod().
by Nikolay Sivov (＠nsivov) 13 Aug '23

13 Aug '23

-- v2: tests: Add a test for fmod() with vector arguments. vkd3d-shader: Use ternary operator in fmod() implementation. vkd3d-shader/tpf: Use 'movc' to implement ternary operator. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/268

3 13

Re: [PATCH v4 0/3] MR265: vkd3d-shader/hlsl: Add some more constant folding operations. - approved
by Zebediah Figura (＠zfigura) 13 Aug '23

13 Aug '23

This merge request was approved by Zebediah Figura. -- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/265

1 0

Re: [PATCH v5 0/2] MR240: vkd3d-shader: Add constant folding for the 'dot' operation.
by Zebediah Figura (＠zfigura) 13 Aug '23

13 Aug '23

Sorry about this, I lost track of this one for a while. -- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/240#note_42108

1 0

Re: [PATCH v5 0/2] MR240: vkd3d-shader: Add constant folding for the 'dot' operation. - approved
by Zebediah Figura (＠zfigura) 13 Aug '23

13 Aug '23

This merge request was approved by Zebediah Figura. -- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/240

1 0

[PATCH v10 0/4] MR3319: evr: Leave critical section before waiting for streaming thread.
by Santino Mazza (＠tati1454) 13 Aug '23

13 Aug '23

I'm not sure how could I test this behavior, right now the test I wrote works but there are times where it doesn't enter into the deadlock. -- v10: evr: Remove process input handling from streaming thread. evr: Don't lock presenter allocator when calling NotifyRelease. https://gitlab.winehq.org/wine/wine/-/merge_requests/3319

3 6

[PATCH v2 0/11] MR3561: wine{alsa,coreaudio,oss,pulse}: Move GetEndpointIDs into mmdevapi.
by Davide Beatrici (＠davidebeatrici) 13 Aug '23

13 Aug '23

-- v2: wineoss: Remove GetEndpointIDs. winecoreaudio: Remove GetEndpointIDs. winealsa: Remove GetEndpointIDs. winepulse: Move GetEndpointIDs into mmdevapi. mmdevapi: Import get_device_guid() from driver. winepulse: Export get_device_guid(). wineoss: Export get_device_guid(). winecoreaudio: Export get_device_guid(). winealsa: Export get_device_guid(). winepulse: Open/create driver registry key in get_device_guid(). wineoss: Update device cache in get_device_guid(). https://gitlab.winehq.org/wine/wine/-/merge_requests/3561

2 12

[PATCH v2 0/10] MR3542: mshtml: Implement Cycle Collection for all mshtml objects (dispex), part 4.
by Gabriel Ivăncescu (＠insn) 13 Aug '23

13 Aug '23

The first few patches will introduce temporary leaks or cyclic refs, but that's because we'll handle them properly with the dispex CC, and the last patch should fix this. Other objects' traversal will follow in another MR. -- v2: mshtml: Traverse inner windows. mshtml: Traverse variants using a helper function. mshtml: Implement Cycle Collection for dispex without traversal. mshtml: Implement Cycle Collection for outer windows. mshtml: Use unlink and destructor in the vtbl for HTMLLocation. mshtml: Separate the HTMLLocation from the outer window. mshtml: Use unlink and destructor in the vtbl for PerformanceTiming. mshtml: Move PerformanceTiming related fields to the window. mshtml: Move PerformanceNavigation related fields to the window. mshtml: Use ASCII strings for dispex object names. https://gitlab.winehq.org/wine/wine/-/merge_requests/3542

3 14

[PATCH 0/9] MR3561: wine{alsa,coreaudio,oss,pulse}: Move GetEndpointIDs into mmdevapi.
by Davide Beatrici (＠davidebeatrici) 13 Aug '23

13 Aug '23

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/3561

3 12

[PATCH v3 0/1] MR3559: Draft: gdiplus: add new test cases to GdipCreateCustomLineCap
by Bartosz Kosiorek (＠gang65) 13 Aug '23

13 Aug '23

-- v3: gdiplus: add new test cases to GdipCreateCustomLineCap https://gitlab.winehq.org/wine/wine/-/merge_requests/3559

3 5

[PATCH 0/1] MR3560: configure: Fail if --enable-archs is used and any cross-compiler is missing.
by Zebediah Figura (＠zfigura) 12 Aug '23

12 Aug '23

For example, currently, if --enable-archs=i386,x86_64 is used, and there is an x86_64 cross compiler present but no i386 cross compiler, Wine will silently remove i386 from the list of cross-compiled architechtures, and only compile PE code for x86_64. This seems quite undesirable. I am not aware of any practical reason for this to happen. Debian does ship i686 and x86_64 MinGW compilers in separate packages, though, so it is possible in theory. -- I noticed this while looking into a different, related issue. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3560

2 1

[PATCH v2 0/5] MR3514: sapi: CoInitializeEx fix and other misc improvements.
by Shaun Ren (＠shaunren) 12 Aug '23

12 Aug '23

This MR fixes a bug in Far Cry 6 where the necessary objects cannot be initialized in its speech synthesis thread. -- v2: sapi/tests: Increase timeout in tts test_spvoice. https://gitlab.winehq.org/wine/wine/-/merge_requests/3514

3 6

[PATCH 0/1] MR3556: Draft: gdiplus: initial support for GdipPathIterNextPathType
by Bartosz Kosiorek (＠gang65) 12 Aug '23

12 Aug '23

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/3556

3 3

[PATCH v2 0/1] MR3559: Draft: gdiplus: add new test cases to GdipCreateCustomLineCap
by Bartosz Kosiorek (＠gang65) 12 Aug '23

12 Aug '23

-- v2: gdiplus: add new test cases to GdipCreateCustomLineCap https://gitlab.winehq.org/wine/wine/-/merge_requests/3559

3 2

[PATCH 0/1] MR3559: Draft: gdiplus: add new test cases to GdipCreateCustomLineCap
by Bartosz Kosiorek (＠gang65) 12 Aug '23

12 Aug '23

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/3559

4 4

[PATCH v3 0/1] MR3550: Draft: gdiplus: fillPath and strokePath parameters cannot be used at the same time...
by Bartosz Kosiorek (＠gang65) 12 Aug '23

12 Aug '23

gdiplus: fillPath and strokePath parameters cannot be used at the same time for GdipCreateCustomLineCap -- v3: gdiplus: add new test cases to GdipCreateCustomLineCap https://gitlab.winehq.org/wine/wine/-/merge_requests/3550

3 3

[PATCH v6 0/5] MR3103: server: Create and use a desktop shared mapping for GetCursorPos.
by Rémi Bernon (＠rbernon) 12 Aug '23

12 Aug '23

First part of Proton shared memory series. The full branch can be seen at https://gitlab.winehq.org/rbernon/wine/-/commits/mr/shared-memories. -- v6: user32: Use the desktop shared data for GetCursorPos(). server: Add a sequence number to the shared data. server: Move the cursor position and last change time to the shared data. server: Use the helper to update the cursor last change time. server: Create a desktop shared mapping. https://gitlab.winehq.org/wine/wine/-/merge_requests/3103

4 11

[PATCH v2 0/1] MR3550: Draft: gdiplus: fillPath and strokePath parameters cannot be used at the same time...
by Bartosz Kosiorek (＠gang65) 12 Aug '23

12 Aug '23

gdiplus: fillPath and strokePath parameters cannot be used at the same time for GdipCreateCustomLineCap -- v2: gdiplus: fillPath and strokePath parameters cannot be used at the same time for GdipCreateCustomLineCap https://gitlab.winehq.org/wine/wine/-/merge_requests/3550

3 2

[PATCH v2 0/1] MR3551: Draft: gdiplus: initial support for GdipPathIterNextPathType
by Bartosz Kosiorek (＠gang65) 12 Aug '23

12 Aug '23

-- v2: gdiplus: initial support for GdipPathIterNextPathType https://gitlab.winehq.org/wine/wine/-/merge_requests/3551

3 3

[PATCH 0/8] MR3555: include: Annotate allocation function typedefs with __WINE_ALLOC_SIZE.
by Alex Henrie (＠alexhenrie) 12 Aug '23

12 Aug '23

This gets us better warnings when compiling with `-fanalyzer` on GCC 14. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3555

2 8

[PATCH 0/4] MR3554: mmdevapi: fixes for Yousician
by David McFarland (＠corngood) 12 Aug '23

12 Aug '23

Since Yousician's last update, it was throwing an error when initialising audio output. Unfortunately I don't have access to the old version, but they seem to have dropped win<10 support, and are using only IAudioClient3_InitializeSharedAudioStream. They also use IDeviceTopology to get the type of the first output connector. This is the bare minimum I needed to get it working. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3554

3 5

[PATCH v9 0/3] MR414: fltmgr.sys: Implement FltBuildDefaultSecurityDescriptor
by Alistair Leslie-Hughes (＠alesliehughes) 12 Aug '23

12 Aug '23

Signed-off-by: Alistair Leslie-Hughes <leslie_alistair(a)hotmail.com> -- v9: ntoskrnl.exe: Add FltBuildDefaultSecurityDescriptor test fltmgr.sys: Create import library fltmgr.sys: Implement FltBuildDefaultSecurityDescriptor https://gitlab.winehq.org/wine/wine/-/merge_requests/414

2 4

[PATCH v3 0/14] MR3548: windows.applicationmodel: Implement some functions.
by Mohamad Al-Jaf (＠maljaf) 11 Aug '23

11 Aug '23

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=52665 I'm unsure how to add tests for this given it requires an app to be installed via MSIX to get a package ID in Windows otherwise `IPackageStatics::get_Current()` returns `0x80073d54`. -- v3: windows.applicationmodel: Implement IStorageItem::get_Path(). windows.applicationmodel/tests: Add IStorageItem::get_Path() tests. windows.applicationmodel: Add IStorageItem stub interface. windows.applicationmodel: Implement IPackage::get_InstalledLocation(). include: Add IStorageFolder interface definition. include: Add windows.storage.search.idl file. include: Add IStorageItem interface definition. include: Add windows.storage.fileproperties.idl file. include: Add IStorageFile interface definition. include: Add IRandomAccessStream interface definition. windows.applicationmodel: Implement IPackageStatics::get_Current(). windows.applicationmodel: Add IPackageStatics stub interface. include: Add IPackageStatics interface definition. windows.applicationmodel: Add stub DLL. https://gitlab.winehq.org/wine/wine/-/merge_requests/3548

3 16

[PATCH 0/1] MR3550: Draft: gdiplus: fillPath and strokePath parameters cannot be used at the same time...
by Bartosz Kosiorek (＠gang65) 11 Aug '23

11 Aug '23

gdiplus: fillPath and strokePath parameters cannot be used at the same time for GdipCreateCustomLineCap -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3550

4 3

[PATCH 0/1] MR3551: Draft: gdiplus: initial support for GdipPathIterNextPathType
by Bartosz Kosiorek (＠gang65) 11 Aug '23

11 Aug '23

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/3551

3 2

[PATCH v2 0/2] MR3547: Common Controls: Fix balloon tooltips
by Carl Bialorucki (＠cbialorucki) 11 Aug '23

11 Aug '23

Fixes balloon tooltips so that they can be drawn outside of the work area (required for system tray icons) and improves the shape of the tooltips so that they resemble their shape on Windows. -- v2: Fix balloon without breaking GDI https://gitlab.winehq.org/wine/wine/-/merge_requests/3547

2 2

[PATCH v4 0/1] MR3549: Draft: gdiplus: add more test to GdipCreateCustomLineCap
by Bartosz Kosiorek (＠gang65) 11 Aug '23

11 Aug '23

-- v4: gdiplus: fillPath and strokePath parameters cannot be used at the same time for GdipCreateCustomLineCap https://gitlab.winehq.org/wine/wine/-/merge_requests/3549

3 3

[PATCH 0/2] MR3453: DECLSPEC_HIDDEN usage setupapi/wmp
by Alistair Leslie-Hughes (＠alesliehughes) 11 Aug '23

11 Aug '23

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/3453

3 3

Re: [PATCH v2 0/1] MR3539: gdiplus: add support support for 1, 4 and 8 bpp Indexed pixel format conversion
by Esme Povirk (＠madewokherd) 11 Aug '23

11 Aug '23

On Fri Aug 11 19:51:08 2023 +0000, Bartosz Kosiorek wrote: > @madewokherd > What needs to be done to be able to modify the bug reports available at: > https://bugs.winehq.org/ > ? Looking at https://wiki.winehq.org/Bugs#Bugzilla_Policies I think you should email bugs-admin(a)winehq.org -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3539#note_42036

1 0

[PATCH v5 0/1] MR3407: gdiplus: Fix StringFormatFlagsLineLimit handling
by David Kahurani (＠kahurani) 11 Aug '23

11 Aug '23

Builtin gdiplus behaves as documented but tests are indicating that Windows behaviour sometimes differs from the documentation. I believe this issue is at least one of the contributing issues to bug https://bugs.winehq.org/show_bug.cgi?id=46947, if not the sole issue. I propose that this flag be disabled until it is well understood. I noticed as issue with DrawString seeming to ignore the flag sometimes(sometimes the text fits without any noticeable defects which I believe is the case with the program in the bug) and sometimes even drawing clipped text with the flag on. Other times it works as expected. I can't seem to find a pattern to identify that could be used to predict its behaviour. Signed-off-by: David Kahurani k.kahurani(a)gmail.com -- v5: gdiplus: fix StringFormatFlagsLineLimit handling https://gitlab.winehq.org/wine/wine/-/merge_requests/3407

3 4

[PATCH v2 0/1] MR3533: sane.ds: Use BGR order to store 24 bit color DIB pixels.
by Ilia Docin (＠IDocin) 11 Aug '23

11 Aug '23

-- v2: sane.ds: Use BGR order to store 24 bit color DIB pixels. https://gitlab.winehq.org/wine/wine/-/merge_requests/3533

3 4

[PATCH v2 0/5] MR3492: clean up user32:msg tests
by Esme Povirk (＠madewokherd) 11 Aug '23

11 Aug '23

This is mostly an attempt to consolidate all the duplicated logic for matching the expected message sequence with the actual message sequence. Other improvements: * It seems that winevent_hook_todo wasn't previously reporting cases where Wine correctly sends the event. * More clarity about which type of message was received when there's a mismatch. * If a message doesn't match, and does not exist in the expected sequence, only the actual message will be skipped. Otherwise, only the expected message will be skipped. This isn't perfect, but I think it will help make the output from failures more readable. * Fixed dump_sequence not printing anything for WM_NCCALCSIZE with wParam == FALSE. Unfortunately, this is going to change the test output, so it will probably break the patterns for testbot detecting known failures. Sorry, Francois. -- v2: user32/tests: Always generate a description for WM_NCCALCSIZE. user32/tests: Distinguish between extra and missing messages. user32/tests: Share code between ok_sequence and dump_sequence. user32: Remove some todo's for working tests. user32/tests: Use winetest context in ok_sequence. https://gitlab.winehq.org/wine/wine/-/merge_requests/3492

2 5

[PATCH 0/5] MR3492: clean up user32:msg tests
by Esme Povirk (＠madewokherd) 11 Aug '23

11 Aug '23

This is mostly an attempt to consolidate all the duplicated logic for matching the expected message sequence with the actual message sequence. Other improvements: * It seems that winevent_hook_todo wasn't previously reporting cases where Wine correctly sends the event. * More clarity about which type of message was received when there's a mismatch. * If a message doesn't match, and does not exist in the expected sequence, only the actual message will be skipped. Otherwise, only the expected message will be skipped. This isn't perfect, but I think it will help make the output from failures more readable. * Fixed dump_sequence not printing anything for WM_NCCALCSIZE with wParam == FALSE. Unfortunately, this is going to change the test output, so it will probably break the patterns for testbot detecting known failures. Sorry, Francois. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3492

5 26

[PATCH v9 0/4] MR3319: evr: Leave critical section before waiting for streaming thread.
by Santino Mazza (＠tati1454) 11 Aug '23

11 Aug '23

I'm not sure how could I test this behavior, right now the test I wrote works but there are times where it doesn't enter into the deadlock. -- v9: evr: Remove process input handling from streaming thread. evr: Don't lock presenter allocator when calling NotifyRelease https://gitlab.winehq.org/wine/wine/-/merge_requests/3319

3 7

[PATCH v3 0/2] MR3549: Draft: gdiplus: add more test to GdipCreateCustomLineCap
by Bartosz Kosiorek (＠gang65) 11 Aug '23

11 Aug '23

-- v3: gdiplus: initial support for GdipPathIterNextPathType gdiplus: add more test to GdipCreateCustomLineCap https://gitlab.winehq.org/wine/wine/-/merge_requests/3549

3 3

[PATCH v4 0/3] MR3536: mfmediaengine: Implement media_engine_GetSeekable().
by Zhiyi Zhang (＠zhiyi) 11 Aug '23

11 Aug '23

Needed by Underworld Island (Steam ID: 2150830) to skip videos properly. -- v4: mfmediaengine: Implement media_engine_GetSeekable(). mfmediaengine/tests: Test IMFMediaEngine::GetSeekable(). https://gitlab.winehq.org/wine/wine/-/merge_requests/3536

3 5

[PATCH v2 0/1] MR3549: Draft: gdiplus: add more test to GdipCreateCustomLineCap
by Bartosz Kosiorek (＠gang65) 11 Aug '23

11 Aug '23

-- v2: gdiplus: add more test to GdipCreateCustomLineCap https://gitlab.winehq.org/wine/wine/-/merge_requests/3549

3 2

[PATCH 0/1] MR3549: Draft: gdiplus: add more test to GdipCreateCustomLineCap
by Bartosz Kosiorek (＠gang65) 11 Aug '23

11 Aug '23

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/3549

3 2

[PATCH v3 0/1] MR3546: gdiplus: move pointer calculation outside inner loop for alpha_blend_bmp_pixels
by Bartosz Kosiorek (＠gang65) 11 Aug '23

11 Aug '23

-- v3: gdiplus: move pointer calculation outside inner loop to improve performance https://gitlab.winehq.org/wine/wine/-/merge_requests/3546

3 3

[PATCH v2 0/1] MR3546: gdiplus: move pointer calculation outside inner loop for alpha_blend_bmp_pixels
by Bartosz Kosiorek (＠gang65) 11 Aug '23

11 Aug '23

-- v2: gdiplus: move pointer calculation outside inner loop to improve performance https://gitlab.winehq.org/wine/wine/-/merge_requests/3546

4 4

[PATCH 0/1] MR3546: gdiplus: move pointer calculation outside inner loop for alpha_blend_bmp_pixels
by Bartosz Kosiorek (＠gang65) 11 Aug '23

11 Aug '23

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/3546

4 5

[PATCH 0/1] MR3545: gdiplus: reduce number of calculations for matrix rotation
by Bartosz Kosiorek (＠gang65) 11 Aug '23

11 Aug '23

Instead of making many multiplication, we could directly assign exact values of rotated matrix. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3545

2 2

[PATCH v2 0/14] MR3548: windows.applicationmodel: Implement some functions.
by Mohamad Al-Jaf (＠maljaf) 11 Aug '23

11 Aug '23

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=52665 I'm unsure how to add tests for this given it requires an app to be installed via MSIX to get a package ID in Windows otherwise `IPackageStatics::get_Current()` returns `0x80073d54`. -- v2: windows.applicationmodel: Implement IStorageItem::get_Path(). windows.applicationmodel/tests: Add IStorageItem::get_Path() tests. windows.applicationmodel: Add IStorageItem stub interface. windows.applicationmodel: Implement IPackage::get_InstalledLocation(). include: Add IStorageFolder interface definition. include: Add windows.storage.search.idl file. include: Add IStorageItem interface definition. include: Add windows.storage.fileproperties.idl file. include: Add IStorageFile interface definition. include: Add IRandomAccessStream interface definition. windows.applicationmodel: Implement IPackageStatics::get_Current(). windows.applicationmodel: Add IPackageStatics stub interface. include: Add IPackageStatics interface definition. windows.applicationmodel: Add stub DLL. https://gitlab.winehq.org/wine/wine/-/merge_requests/3548

3 15

[PATCH 0/14] MR3548: windows.applicationmodel: Implement some functions.
by Mohamad Al-Jaf (＠maljaf) 11 Aug '23

11 Aug '23

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=52665 I'm unsure how to add tests for this given it requires an app to be installed via MSIX to get a package ID in Windows otherwise `IPackageStatics::get_Current()` returns `0x80073d54`. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3548

3 15

[PATCH v2 0/1] MR3513: include: Add IXAudio2Extension in xaudio2.idl.
by Biswapriyo Nath (＠Biswa96) 11 Aug '23

11 Aug '23

Required for rpcs3 project. -- v2: include: Add IXAudio2Extension in xaudio2.idl. https://gitlab.winehq.org/wine/wine/-/merge_requests/3513

2 2

[PATCH v25 0/1] MR3074: Move getpeername() implementation to wineserver
by Ally Sommers (＠dropbear) 11 Aug '23

11 Aug '23

`getpeername()` is currently handled in ntdll. This merge request changes ntdll to forward `getpeername()` to wineserver. The implementation utilises new `peer_addr` and `peer_addr_len` fields in wineserver's `struct sock`. This fixes multiple `todo_wine`s in `ws2_32/tests` and allows for more accurate peer names to be provided in case the address the socket is bound to on the Unix side does not match what `bind()` was called with on the Windows side. *This merge request was originally intended to be included in !2786 (Add support for AF_UNIX sockets) but was split into its own merge request because this is not an insignificant change.* -- v25: server: Move getpeername() implementation from ntdll/unix. https://gitlab.winehq.org/wine/wine/-/merge_requests/3074

2 1

[PATCH 0/1] MR3547: GDI, Common Controls: Fix balloon tooltips
by Carl Bialorucki (＠cbialorucki) 10 Aug '23

10 Aug '23

Fixes balloon tooltips so that they can be drawn outside of the work area (required for system tray icons) and improves the shape of the tooltips so that they resemble their shape on Windows. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3547

3 2

[PATCH v3 0/5] MR295: vkd3d-shader: Extend vkd3d_shader_scan_descriptor_info, part 1/2.
by Zebediah Figura (＠zfigura) 10 Aug '23

10 Aug '23

There are two motivations for this: * First, the structure *almost* corresponds to D3D12_SHADER_INPUT_BIND_DESC, and if more elements were included, it could be used as-is for shader reflection. There is the quirk that currently we return scan information based on the shader instructions, whereas d3dcompiler shader reflection expects to get it from the shader reflection data (i.e. the RDEF chunk), which is particularly relevant in the case that the RDEF chunk is stripped. That said, even if we have to introduce an extra scan API to account for this difference, being able to reuse the same structure seems like a benefit. In order to reuse this structure, we need to add the following elements: - Register ID (added in part 1 of this series) - Sample count (added in part 2 of this series) - Flags or resource types to distinguish between typed, raw, and structured buffers. I have not decided which representation makes the most sense; opinions are welcome. * Second, I think it makes sense to use this reflection information internally in spirv.c (and potentially other compiler backends) to declare resources in the target environment, instead of parsing DCL instructions. The idea here is that this allows backends to be more agnostic as to how resources are declared (or inferred) in the frontend, while avoiding the need to synthesize those DCL instructions in the frontend either [especially since epenthesizing instructions is more expensive than converting them to NOPs.] In order to do that, we will need vkd3d_shader_scan_descriptor_info1 to cover everything that is currently covered by DCL instructions. This needs the same elements as above (register ID and sample count), but also: - Structure stride (added in part 2 of this series) - Constant buffer used width (added in part 2 of this series) I don't currently have a proof-of-concept using these new elements. On the other hand, since it's just an extension of an existing API, I figured that seemed less critical. This does conflict trivially with 280; I'm submitting it now since 280 is accepted, but due to Alexandre's vacation may not be committed soon, and since this is new API I'd rather get comments early anyway. -- v3: vkd3d-shader: Get rid of the uav_ranges array. vkd3d-shader: Add register ID to struct vkd3d_shader_descriptor_info1. vkd3d-shader: Introduce struct vkd3d_shader_scan_descriptor_info1. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/295

3 8

[PATCH v8 0/7] MR281: vkd3d-shader/tpf: Replace sm4 register structs with vkd3d-shader register structs, part 1.
by Francisco Casas (＠fcasas) 10 Aug '23

10 Aug '23

Recap: I implemented relative addressing in !229, but I was suggested to handle register indexes by moving all the registers to the heap, which I did in my [nonconst-offsets-6](https://gitlab.winehq.org/fcasas/vkd3d/-/commits/noncon… branch. A part of this implementation required !269, but I was asked to try to turn the sm4 register structs into the vkd3d-shader register structs instead, to get closer to a common low level IR. This is the first part of that transformation. The whole thing is in my [use_vkd3d_reg_4](https://gitlab.winehq.org/fcasas/vkd3d/-/commits/use_vkd3d… branch. ~~This is built on top of !225 (the first two patches), so it may be good to get that upstream first.~~ --- This patch series aims to do the following replacements: ``` struct sm4_register -> struct vkd3d_shader_register struct sm4_dst_register -> struct vkd3d_shader_dst_param struct sm4_src_register -> struct vkd3d_shader_src_param ``` to get us closer to a common level IR and simplify the implementation of relative-addressing. To achieve this, the fields in the sm4 register structs are replaced with fields in the vkd3d-shader structs or removed altogether, one at the time. As can be seen when looking at the whole branch, it is possible to do this transformation without having to add additional fields to `struct vkd3d_shader_register`, by restricting each register type to a single `enum vkd3d_sm4_dimension` (and its src registers to a single `enum vkd3d_sm4_swizzle_type`) by default. The only exception we need so far is for sampler registers: They always have dimension NONE, except when used as arguments of gather instructions, in which case they have dimension VEC4 and SCALAR swizzle. This, and similar exceptions we may find in the future, can be handled using the opcode_info, as in 7/8 [81e17506](https://gitlab.winehq.org/fcasas/vkd3d/-/commit/81e17506ba2cb1fbf…. -- v8: https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/281

4 10

[PATCH 0/1] MR3544: po: Update Dutch translation.
by Floris Renaud (＠jkfloris) 10 Aug '23

10 Aug '23

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/3544

2 1

[PATCH v8 0/4] MR3319: evr: Leave critical section before waiting for streaming thread.
by Santino Mazza (＠tati1454) 10 Aug '23

10 Aug '23

I'm not sure how could I test this behavior, right now the test I wrote works but there are times where it doesn't enter into the deadlock. -- v8: evr: Remove process input handling from streaming thread. evr: Don't lock presenter allocator when calling NotifyRelease evr: Create critical section for sample queue. https://gitlab.winehq.org/wine/wine/-/merge_requests/3319

3 5

[PATCH v3 0/1] MR3437: include: Add windows.ui.xaml.hosting.desktopwindowxamlsource.idl file.
by Paul Jackson (＠mailnew4ster) 10 Aug '23

10 Aug '23

Continuation of https://gitlab.winehq.org/wine/wine/-/merge_requests/2959 No changes were made. @zfigura please take a look. cc @Biswa96 -- v3: include: Add windows.ui.xaml.hosting.desktopwindowxamlsource.idl file. https://gitlab.winehq.org/wine/wine/-/merge_requests/3437

4 4

[PATCH 0/1] MR3543: mshtml: Skip windows with no URI when deciding whether to send storage events.
by Gabriel Ivăncescu (＠insn) 10 Aug '23

10 Aug '23

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/3543

3 2

[PATCH 0/9] MR3542: mshtml: Implement Cycle Collection for all mshtml objects (dispex), part 4.
by Gabriel Ivăncescu (＠insn) 10 Aug '23

10 Aug '23

The first few patches will introduce temporary leaks or cyclic refs, but that's because we'll handle them properly with the dispex CC, and the last patch should fix this. Other objects' traversal will follow in another MR. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3542

3 13

[PATCH v2 0/1] MR3437: include: Add windows.ui.xaml.hosting.desktopwindowxamlsource.idl file.
by Paul Jackson (＠mailnew4ster) 10 Aug '23

10 Aug '23

Continuation of https://gitlab.winehq.org/wine/wine/-/merge_requests/2959 No changes were made. @zfigura please take a look. cc @Biswa96 -- v2: include: Add windows.ui.xaml.hosting.desktopwindowxamlsource.idl file. https://gitlab.winehq.org/wine/wine/-/merge_requests/3437

3 3

[PATCH v7 0/4] MR3319: evr: Leave critical section before waiting for streaming thread.
by Santino Mazza (＠tati1454) 10 Aug '23

10 Aug '23

I'm not sure how could I test this behavior, right now the test I wrote works but there are times where it doesn't enter into the deadlock. -- v7: evr: Remove process input handling from streaming thread. https://gitlab.winehq.org/wine/wine/-/merge_requests/3319

3 6

[PATCH v3 0/1] MR3436: include: Add xamlom.idl file.
by Paul Jackson (＠mailnew4ster) 10 Aug '23

10 Aug '23

Continuation of https://gitlab.winehq.org/wine/wine/-/merge_requests/2773 I tried to address all comments. @zfigura please take a look. cc @Biswa96 -- v3: include: Add xamlom.idl file. https://gitlab.winehq.org/wine/wine/-/merge_requests/3436

3 2

[PATCH v3 0/3] MR3536: mfmediaengine: Implement media_engine_GetSeekable().
by Zhiyi Zhang (＠zhiyi) 10 Aug '23

10 Aug '23

Needed by Underworld Island (Steam ID: 2150830) to skip videos properly. -- v3: mfmediaengine: Implement media_engine_GetSeekable(). mfmediaengine/tests: Test IMFMediaEngine::GetSeekable(). https://gitlab.winehq.org/wine/wine/-/merge_requests/3536

3 8

[PATCH v12 0/2] MR3504: ntdll: An implementation of SRWLOCK that closer matches Windows'.
by Yuxuan Shui (＠yshui) 10 Aug '23

10 Aug '23

This comes from behavioral study of Windows, which doesn't seem to check if the lock is actually exclusively held, and just simply decrement the value stored in the lock. This fixes a dead lock which prevents WeCom from starting up. -- v12: ntdll: An implementation of SRWLOCK that closer matches Windows'. include: add atomic read/write of pointers https://gitlab.winehq.org/wine/wine/-/merge_requests/3504

3 4

[PATCH 0/3] MR3538: wined3d: Move zero swapchain parameter fixup to wined3d_swapchain_state_init.
by Stefan Dösinger (＠stefan) 10 Aug '23

10 Aug '23

--- Note that this code never runs in d3d10+ for a 0 pixelformat. Dxgi/tests/dxgi.c:2032 has a test that shows it results in an error. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3538

4 7

Re: [PATCH v2 0/1] MR3540: server: Avoid a mach port leak on Apple Silicon. - approved
by Alexandre Julliard (＠julliard) 10 Aug '23

10 Aug '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3540

1 0

Re: [PATCH v3 0/1] MR3541: gdiplus: fix returned value of GdipDrawImagePointsRect according to native lib - approved
by Alexandre Julliard (＠julliard) 10 Aug '23

10 Aug '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3541

1 0

Re: [PATCH v2 0/1] MR3539: gdiplus: add support support for 1, 4 and 8 bpp Indexed pixel format conversion - approved
by Alexandre Julliard (＠julliard) 10 Aug '23

10 Aug '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3539

1 0

Re: [PATCH v4 0/4] MR3537: bcrypt: BCRYPT_KEY_STRENGTH and LEGACY_RSAPRIVATE_BLOB support. - approved
by Alexandre Julliard (＠julliard) 10 Aug '23

10 Aug '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3537

1 0

Re: [PATCH v3 0/1] MR3314: wow64win: Skip WM_CREATE/WM_NCCREATE lParam conversion if NULL - approved
by Alexandre Julliard (＠julliard) 10 Aug '23

10 Aug '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3314

1 0

Re: [PATCH v4 0/2] MR3468: D3DX11 load texture from texture - approved
by Alexandre Julliard (＠julliard) 10 Aug '23

10 Aug '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3468

1 0

Re: [PATCH v2 0/1] MR3532: sane.ds: Add maximum scanning dimensions setting support. - approved
by Alexandre Julliard (＠julliard) 10 Aug '23

10 Aug '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3532

1 0

Re: [PATCH v4 0/1] MR2029: dmime: Store WAVE data when Loading. - approved
by Alexandre Julliard (＠julliard) 10 Aug '23

10 Aug '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2029

1 0

Re: [PATCH v4 0/5] MR3524: gdiplus: Add missing PNG metadata properties - approved
by Alexandre Julliard (＠julliard) 10 Aug '23

10 Aug '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3524

1 0

Re: [PATCH v9 0/1] MR3458: ddraw/tests: Fix overflow bugs in compare_float. - approved
by Alexandre Julliard (＠julliard) 10 Aug '23

10 Aug '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3458

1 0

Re: [PATCH v2 0/5] MR3489: wined3d: Implement a copy-on-write scheme for whole buffer uploads. - approved
by Alexandre Julliard (＠julliard) 10 Aug '23

10 Aug '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3489

1 0

Re: [PATCH v3 0/1] MR3490: d3d11/tests: Fix typos in a test cleanup (Coverity). - approved
by Alexandre Julliard (＠julliard) 10 Aug '23

10 Aug '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3490

1 0

Re: [PATCH v5 0/5] MR3498: d3d tests: Use compare_uint() in compare_float() instead of abs(). - approved
by Alexandre Julliard (＠julliard) 10 Aug '23

10 Aug '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3498

1 0

Re: [PATCH v2 0/1] MR3515: wined3d: Release push constant buffers in wined3d_device_uninit_3d(). - approved
by Alexandre Julliard (＠julliard) 10 Aug '23

10 Aug '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3515

1 0

Re: [PATCH v2 0/1] MR3516: wined3d: Update reported driver versions - approved
by Alexandre Julliard (＠julliard) 10 Aug '23

10 Aug '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3516

1 0

[PATCH 0/1] MR3539: gdiplus: add support support for 1, 4 and 8 bpp Indexed pixel format conversion
by Bartosz Kosiorek (＠gang65) 10 Aug '23

10 Aug '23

Wine-bug: https://bugs.winehq.org/show_bug.cgi?id=20694 The conversion was tested with Mozart 11, by exporting to GIF image format: ![Mozart_Duet_1](/uploads/749ee278a43f7234f422471f819027f1/Mozart_Duet_1.gif) -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3539

3 3

[PATCH v11 0/2] MR3504: Draft: ntdll: An implementation of SRWLOCK that closer matches Windows'.
by Yuxuan Shui (＠yshui) 10 Aug '23

10 Aug '23

This comes from behavioral study of Windows, which doesn't seem to check if the lock is actually exclusively held, and just simply decrement the value stored in the lock. This fixes a dead lock which prevents WeCom from starting up. -- v11: ntdll: An implementation of SRWLOCK that closer matches Windows'. include: add atomic read/write of pointers https://gitlab.winehq.org/wine/wine/-/merge_requests/3504

2 3

2025

2024

2023

2022

wine-gitlab