- wine-gitlab - winehq.org

Re: [PATCH v8 0/1] MR477: d3drm/tests: Show Clear sets background color - approved
by Alexandre Julliard (＠julliard) 19 Jul '23

19 Jul '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/477

1 0

Re: [PATCH v2 0/3] MR3350: webservices/tests: Use WS_STRING_VALUE and WS_XML_STRING_VALUE. - approved
by Alexandre Julliard (＠julliard) 19 Jul '23

19 Jul '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3350

1 0

Re: [PATCH v2 0/4] MR3349: loader: Make the preloader a correct macOS 10.7 binary, and use a zerofill section to reserve the low 8GB of memory. - approved
by Alexandre Julliard (＠julliard) 18 Jul '23

18 Jul '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3349

1 0

[PATCH v9 0/1] MR3347: klist: Add a program that lists Kerberos tickets.
by Maxim Karasev (＠mxkrsv) 18 Jul '23

18 Jul '23

It's a clean-room reimplementation that mimics Windows 10 program's output format. It prints all the information that is available via KerbQueryTicketCacheMessage. Also tested to work on Windows if dynamically linked + built with winegcc. For further extension of the functonality, implementing KerbQueryTicketCacheEx{,2,3}Message is required. -- v9: klist: Add a program that lists Kerberos tickets. https://gitlab.winehq.org/wine/wine/-/merge_requests/3347

2 2

[PATCH v3 0/2] MR3344: windowscodecs: support GIF with no color table
by Jeffrey Smith (＠whydoubt) 18 Jul '23

18 Jul '23

Decoding a GIF with no color table currently crashes on Wine. Windows supports such files, and the GIF spec explicitly allows it. -- v3: windowscodecs: Allow GIF with no color table. windowscodecs: Factor out common GIF palette copying logic. https://gitlab.winehq.org/wine/wine/-/merge_requests/3344

4 4

[PATCH v2 0/4] MR3297: uiautomationcore: Initial COM event handler support.
by Connor McAdams (＠cmcadams) 18 Jul '23

18 Jul '23

-- v2: uiautomationcore: Implement IUIAutomation::RemoveAutomationEventHandler. uiautomationcore: Implement IUIAutomation::RemoveAllEventHandlers. uiautomationcore: Partially implement IUIAutomation::AddAutomationEventHandler. uiautomationcore/tests: Add IUIAutomationEventHandler tests. https://gitlab.winehq.org/wine/wine/-/merge_requests/3297

3 8

[PATCH v5 0/6] MR3302: Draft: gdiplus: Fix GdipGetPropertySize and GdipGetAllPropertyItems return values when no properties exist.
by Jeffrey Smith (＠whydoubt) 18 Jul '23

18 Jul '23

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=54748 -- v5: gdiplus: Fix GdipGetAllPropertyItems return value when no properties exist. gdiplus: Fix GdipGetPropertySize return value when no properties exist. gdiplus/tests: Pare down image property tests that are not run for Wine. gdiplus/tests: Use test context for test ran in a loop. gdiplus/tests: Add GIF to image properties tests. gdiplus/tests: Use consistent no-alternate value for image properties. https://gitlab.winehq.org/wine/wine/-/merge_requests/3302

2 7

[PATCH v6 0/1] MR3353: Make Notepad properly get the DPI value.
by Petrichor Park (＠petrathekat) 18 Jul '23

18 Jul '23

Instead of querying the registry, just calls `GetDpiForWindow`. Winecfg's DPI slider sets `Control Panel\\Desktop\\LogPixels`. See `programs/winecfg/x11drvdlg.c` Notepad queries `Software\\Fonts\\LogPixels`, and so doesn't pick up on the change. I don't believe this changes how Notepad looks to the user, but it is necessary for a further MR I'm working on that adds more information to the status bar. -- v6: notepad: Use GetDpiForWindow() https://gitlab.winehq.org/wine/wine/-/merge_requests/3353

2 1

[PATCH v5 0/1] MR3353: Make Notepad properly get the DPI value.
by Petrichor Park (＠petrathekat) 18 Jul '23

18 Jul '23

Instead of querying the registry, just calls `GetDpiForWindow`. Winecfg's DPI slider sets `Control Panel\\Desktop\\LogPixels`. See `programs/winecfg/x11drvdlg.c` Notepad queries `Software\\Fonts\\LogPixels`, and so doesn't pick up on the change. I don't believe this changes how Notepad looks to the user, but it is necessary for a further MR I'm working on that adds more information to the status bar. -- v5: notepad: Use GetDpiForWindow() https://gitlab.winehq.org/wine/wine/-/merge_requests/3353

3 3

[PATCH 0/4] MR260: vkd3d: Prepare for buffering of command list commands.
by Conor McCarthy (＠cmccarthy) 18 Jul '23

18 Jul '23

-- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/260

4 8

Re: [PATCH v4 0/1] MR3353: Make Notepad properly get the DPI value.
by Jeffrey Smith (＠whydoubt) 18 Jul '23

18 Jul '23

On Tue Jul 18 18:38:06 2023 +0000, Brendan Shanks wrote: > Also, the commit title should start with `notepad:`, something like > `notepad: Use GetDpiForWindow()`. While changing the commit title, it might be worth-while to pare down the rest of the commit message. Specifically, while the last paragraph is relevant to the MR, I don't think it will serve any lasting value in the commit history. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3353#note_39330

1 0

Re: [PATCH v4 0/1] MR3353: Make Notepad properly get the DPI value.
by Brendan Shanks (＠bshanks) 18 Jul '23

18 Jul '23

Also, the commit title should start with `notepad:`, something like `notepad: Use GetDpiForWindow()`. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3353#note_39329

1 0

Re: [PATCH v4 0/1] MR3353: Make Notepad properly get the DPI value.
by David Kahurani (＠kahurani) 18 Jul '23

18 Jul '23

With these changes, it doesn't look like `get_dpi` serves any purpose anymore. You might as well refactor it all out. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3353#note_39327

1 0

Re: [PATCH v4 0/1] MR3353: Make Notepad properly get the DPI value.
by Petrichor Park (＠petrathekat) 18 Jul '23

18 Jul '23

Sorry for all the hullabaloo; I've `git rebased` it to be under my Gitlab account now. (Previously it was inheriting my personal Github account information). -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3353#note_39321

1 0

[PATCH 0/1] MR3353: Make Notepad properly get the DPI value.
by Petrichor Park (＠petrathekat) 18 Jul '23

18 Jul '23

Instead of querying the registry, just calls `GetDpiForWindow`. Winecfg's DPI slider sets `Control Panel\\Desktop\\LogPixels`. See `programs/winecfg/x11drvdlg.c` Notepad queries `Software\\Fonts\\LogPixels`, and so doesn't pick up on the change. I don't believe this changes how Notepad looks to the user, but it is necessary for a further MR I'm working on that adds more information to the status bar. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3353

4 4

[PATCH 0/2] MR3242: comctl32/tests: Add Korean IME specific test sequences.
by Zhiyi Zhang (＠zhiyi) 18 Jul '23

18 Jul '23

Windows with Korean locale has a different IME message sequence. Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=53890 -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3242

3 3

[PATCH v6 0/1] MR3347: klist: Add a program that lists Kerberos tickets.
by Maxim Karasev (＠mxkrsv) 18 Jul '23

18 Jul '23

It's a clean-room reimplementation that mimics Windows 10 program's output format. It prints all the information that is available via KerbQueryTicketCacheMessage. Also tested to work on Windows if dynamically linked + built with winegcc. For further extension of the functonality, implementing KerbQueryTicketCacheEx{,2,3}Message is required. -- v6: klist: Add a program that lists Kerberos tickets. https://gitlab.winehq.org/wine/wine/-/merge_requests/3347

4 10

[PATCH v4 0/2] MR271: Introduce a GitLab pipeline for vkd3d
by Giovanni Mascellani (＠giomasce) 18 Jul '23

18 Jul '23

With this pipeline vkd3d automatically gets built on Linux (in an image based on Debian unstable), both in 32 and 64 bit mode. Both builds are tested with radv and llvmpipe. A number of caveats apply, though: * A number of tests currently fail in llvmpipe, so the llvmpipe jobs are marked as allowed to fail. Ideally we'll eventually fix our bugs and mark the llvmpipe ones in the tests, so that the CI tests completely pass and possible problems in the Vulkan driver are recorded at a better granularity (this is the reason why GitLab says that the pipeline is passed with warnings: the warnings are that there are jobs that failed, even if they were allowed to fail). * ~~The runners provided by the GitLab instance don't have a GPU available, so I configured my own computer (equipped with an AMD Radeon RX 5700 RX) to provide a runner with access to the GPU. This setup is not currently satisfying: for me, because I use that computer for other things and I don't like having random code submitted to it (it is theoretically sandboxed, but sandboxes are not always bullet-proof, especially if they have access to a GPU); for the users, because my computer might be unavailable at any time. I'll work on a better solution. For the time being I intend the runner to only accept jobs from the master branch; once a better solution is implemented I'd like to run the pipeline for MRs too.~~ **Fixed**, now there is a shared worker with an AMD GPU available. * While the `Dockerfile` and related assets do not necessarily need to be available in this repository, given that the CI accesses the binary image from the Docker hub anyway, I think it's still valuable to have them, so others can improve them (and for sure improvement opportunities are nowhere near missing). However, other ways to make them available can be found, if for some reason it is not liked to have them in this repository (they are not pretty!). * ~~One of the reason they are not pretty is that I have a custom hack to compile `widl` from the Wine sources without compiling (or installing from the distribution) the whole of Wine, in the interest of keeping the Docker image small (well, small-ish: Vulkan drivers, compilers and X libraries are not small anyway).~~ **A better solution was implemented** * Again on the subject of the Docker image, I am currently putting the binary image in my own namespace on the Docker hub. Using the GitLab container registry in the namespace of the Wine project would probably be better, so that I am not a bottleneck in the future. * ~~Even if we discount all the points above, this MR cannot be merged yet, because my runner is currently configured for my namespace only. I guess I need the intervention of a GitLab admin to fix that. However, I think there's already material enough for valuable feedback.~~ **Fixed too** -- v4: ci: Introduce a CI pipeline for GitLab. configure: Require widl >= 3.21. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/271

2 2

[PATCH v3 0/9] MR3300: jscript: WeakMap implementation.
by Gabriel Ivăncescu (＠insn) 18 Jul '23

18 Jul '23

-- v3: jscript: Properly set JS_E_WRONG_THIS as a TypeError. mshtml/tests: Add tests for WeakMap. jscript: Implement WeakMap.has(). jscript: Implement WeakMap.clear(). jscript: Implement WeakMap.delete(). jscript: Implement WeakMap.get(). jscript: Implement WeakMap.set(). jscript: Implement WeakMap instance stub and constructor. jscript: Convert unlink_props to a helper that unlinks the entire object. https://gitlab.winehq.org/wine/wine/-/merge_requests/3300

3 16

Re: [PATCH v7 0/1] MR477: d3drm/tests: Show Clear sets background color
by Jeffrey Smith (＠whydoubt) 18 Jul '23

18 Jul '23

@stefan It is possible the purpose of this MR morphed a bit along the way. IIRC, there was a thought that maybe Render was doing its own clear. It is not, so code using the API would be expected to explicitly call a Clear before Render. At this point, I guess this is essentially a way to retain that knowledge as a test. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/477#note_39301

1 0

[PATCH 0/5] MR279: vkd3d: Support higher ID3D12Device versions.
by Conor McCarthy (＠cmccarthy) 18 Jul '23

18 Jul '23

-- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/279

3 6

[PATCH v2 0/6] MR278: vkd3d-shader/dxil: Emit the shader instructions.
by Conor McCarthy (＠cmccarthy) 18 Jul '23

18 Jul '23

Sufficient for compiling a no-op pixel shader. This should probably be rebased on top of !263 because it introduces vkd3d_spirv_get_type_id_for_data_type(), which 263 renders unnecessary. !263 is not essential, but I think using two different type systems in the backend is not ideal. -- v2: vkd3d-shader/dxil: Emit undefined constants. vkd3d-shader/spirv: Introduce an undefined register type. vkd3d-shader/dxbc: Allow DXBC containers to have a zero checksum. vkd3d-shader/dxil: Emit the shader instructions. vkd3d-shader/spirv: Do not normalise Shader Model 6 shaders. vkd3d-shader/dxil: Return an error from sm6_parser_globals_init() on invalid operand count. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/278

3 7

[PATCH 0/4] MR272: vkd3d: Fix handling of non-shader-visible descriptor heaps.
by Conor McCarthy (＠cmccarthy) 18 Jul '23

18 Jul '23

Shader visibility is currently ignored, but we don't want to create Vulkan descriptor sets for CPU heaps. -- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/272

3 5

[PATCH 0/2] MR3351: mfmediaengine: Implement RemoveAllEffects().
by Bernhard Kölbl (＠besentv) 18 Jul '23

18 Jul '23

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/3351

4 4

[PATCH v2 0/2] MR3260: wine{alsa,coreaudio,oss,pulse}: Move get_audio_session into mmdevapi.
by Davide Beatrici (＠davidebeatrici) 18 Jul '23

18 Jul '23

-- v2: winepulse: Move get_audio_session into mmdevapi. mmdevapi: Don't link to uuid. https://gitlab.winehq.org/wine/wine/-/merge_requests/3260

3 10

[PATCH 0/1] MR3352: ntdll/tests: Test that NtContinue restores all register state on arm64
by Billy Laws (＠bylaws) 18 Jul '23

18 Jul '23

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/3352

2 1

Re: [PATCH v7 0/1] MR477: d3drm/tests: Show Clear sets background color - approved
by Stefan Dösinger (＠stefan) 18 Jul '23

18 Jul '23

This merge request was approved by Stefan Dösinger. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/477

1 0

Re: [PATCH v7 0/1] MR477: d3drm/tests: Show Clear sets background color
by Stefan Dösinger (＠stefan) 18 Jul '23

18 Jul '23

My memory is a bit rusty on the merge request, but the test changes look good and I like the description now. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/477#note_39277

1 0

[PATCH v5 0/3] MR261: vkd3d-shader: Add compiler option to specify matrix majority.
by Nikolay Sivov (＠nsivov) 18 Jul '23

18 Jul '23

Signed-off-by: Nikolay Sivov <nsivov(a)codeweavers.com> -- v5: tests: Add some tests for matrix packing compiler options. tests: Add test file syntax to specify compiler options. vkd3d-shader: Add compiler option to specify matrix majority. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/261

3 4

[PATCH 0/3] MR3350: webservices/tests: Use WS_STRING_VALUE and WS_XML_STRING_VALUE.
by Alex Henrie (＠alexhenrie) 18 Jul '23

18 Jul '23

This makes the tests more clear and harder to mess up. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3350

3 4

[PATCH v3 0/6] MR3328: sapi: Implement more functionality for SpVoice.
by Shaun Ren (＠shaunren) 18 Jul '23

18 Jul '23

This MR allows existing some existing Windows TTS Engines, such as Amazon Polly, to be used in Far Cry 6, and possibly in other games/applications. -- v3: sapi: Implement ISpVoice::WaitUntilDone. sapi: Implement ISpTTSEngineSite::GetActions/Rate/Volume. sapi: Implement ISpTTSEngineSite::Write. sapi: Finish implementing ISpVoice::Speak. sapi: Partially implement ISpVoice::Speak. include: Fix ISpTTSEngineSite::GetActions return type. https://gitlab.winehq.org/wine/wine/-/merge_requests/3328

3 7

[PATCH 0/1] MR3333: wow64win: Copy the name and class that come after the CREATESTRUCT.
by Sven Baars (＠sbaars) 18 Jul '23

18 Jul '23

This fixes the msvfw32:mciwnd tests. On a side note: I'd expect there to be a `NtCallbackReturn()` for this case as well, but it's not there. That issue can probably wait until after the fix for [bug 55152](https://bugs.winehq.org/show_bug.cgi?id=55152) though. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3333

3 4

[PATCH v3 0/2] MR2968: include: Annotate SHAlloc with __WINE_(DEALLOC|MALLOC).
by Alex Henrie (＠alexhenrie) 18 Jul '23

18 Jul '23

-- v3: include: Annotate SHAlloc with __WINE_(DEALLOC|MALLOC). shell32: Free item lists with ILFree. https://gitlab.winehq.org/wine/wine/-/merge_requests/2968

2 2

Re: [PATCH v2 0/1] MR3348: include: Add more CLSIDs in d2d1effects.idl. - approved
by Alexandre Julliard (＠julliard) 17 Jul '23

17 Jul '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3348

1 0

Re: [PATCH v4 0/1] MR3313: gdiplus/tests: Fix mangled test output when dumping data in hex format. - approved
by Alexandre Julliard (＠julliard) 17 Jul '23

17 Jul '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3313

1 0

Re: [PATCH v4 0/6] MR3346: win32u/wow64win: Client callback interface improvements. - approved
by Alexandre Julliard (＠julliard) 17 Jul '23

17 Jul '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3346

1 0

Re: [PATCH v14 0/2] MR3114: comctl32/syslink: Check item type before increasing link ID in SYSLINK_LinkAtPt(). - approved
by Alexandre Julliard (＠julliard) 17 Jul '23

17 Jul '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3114

1 0

Re: [PATCH v6 0/4] MR3336: sapi: Miscellaneous fixes. - approved
by Alexandre Julliard (＠julliard) 17 Jul '23

17 Jul '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3336

1 0

Re: [PATCH v5 0/1] MR3230: comdlg32: Add parent folder button to IFileDialog - approved
by Alexandre Julliard (＠julliard) 17 Jul '23

17 Jul '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3230

1 0

Re: [PATCH v2 0/1] MR3337: user32: Add hotpatch prologue to RegisterRawInputDevices - approved
by Alexandre Julliard (＠julliard) 17 Jul '23

17 Jul '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3337

1 0

Re: [PATCH v2 0/1] MR3340: winegcc: Enable SafeSEH only on i386. - approved
by Alexandre Julliard (＠julliard) 17 Jul '23

17 Jul '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3340

1 0

Re: [PATCH v3 0/1] MR3341: ntdll: Fix restoring X16 and X17 in ARM64 syscall dispatcher. - approved
by Alexandre Julliard (＠julliard) 17 Jul '23

17 Jul '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3341

1 0

Re: [PATCH v2 0/1] MR3317: d3dcompiler/tests: Add another test for matrix majority flags. - approved
by Alexandre Julliard (＠julliard) 17 Jul '23

17 Jul '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3317

1 0

Re: [PATCH v3 0/2] MR3308: Remove DECLSPEC_HIDDEN gdiplus and twain_32 - approved
by Alexandre Julliard (＠julliard) 17 Jul '23

17 Jul '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3308

1 0

Re: [PATCH v3 0/2] MR3311: mfmediaengine: Audio effect support. - approved
by Alexandre Julliard (＠julliard) 17 Jul '23

17 Jul '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3311

1 0

Re: [PATCH v5 0/5] MR273: vkd3d-shader: sm1 constants. - approved
by Alexandre Julliard (＠julliard) 17 Jul '23

17 Jul '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/273

1 0

Re: [PATCH v2 0/1] MR277: tests: Add a test for side effects of ternary operator. - approved
by Alexandre Julliard (＠julliard) 17 Jul '23

17 Jul '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/277

1 0

Re: [PATCH v2 0/1] MR276: vkd3d-shader/hlsl: Free the constant defs array in hlsl_ctx_cleanup(). - approved
by Alexandre Julliard (＠julliard) 17 Jul '23

17 Jul '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/276

1 0

Re: [PATCH v3 0/1] MR274: vkd3d-shader/tpf: Support some of the UAV types when writing RDEF records. - approved
by Alexandre Julliard (＠julliard) 17 Jul '23

17 Jul '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/274

1 0

Re: [PATCH v7 0/10] MR209: vkd3d-shader/hlsl: Broaden resources support v2, part 3. - approved
by Alexandre Julliard (＠julliard) 17 Jul '23

17 Jul '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/209

1 0

[PATCH 0/4] MR3349: loader: Make the preloader a correct macOS 10.7 binary, and use a zerofill section to reserve the low 8GB of memory.
by Brendan Shanks (＠bshanks) 17 Jul '23

17 Jul '23

Add a '__program_vars' section to the preloader, to make it a correct macOS 10.7 binary. This fixes Wine crashing on macOS Sonoma, and GStreamer crashing when initialized by Wine (on macOS Monterey and later). However this causes dyld to initialize libSystem before the preloader runs, resulting in system allocations throughout the ranges that need to be reserved. To prevent this, use a zerofill section to reserve the entire low 8GB of address space for use by Wine. This also has the benefit of reserving as much address space as possible for Wow64. Additionally, this MR is a step towards not using the preloader entirely on 64-bit macOS (it relies on very unsupported APIs and methods). -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3349

2 4

[PATCH v6 0/1] MR477: d3drm/tests: Show Clear sets background color
by Alistair Leslie-Hughes (＠alesliehughes) 17 Jul '23

17 Jul '23

Signed-off-by: Alistair Leslie-Hughes <leslie_alistair(a)hotmail.com> -- v6: d3drm/tests: Show that viewport::render does not clear the background. https://gitlab.winehq.org/wine/wine/-/merge_requests/477

2 1

Re: [PATCH v2 0/3] MR3344: windowscodecs: support GIF with no color table
by Jeffrey Smith (＠whydoubt) 17 Jul '23

17 Jul '23

On Mon Jul 17 20:07:36 2023 +0000, Esme Povirk wrote: > If the IWICPalette has only 4 colors in it, it can be assumed to only > return 4 colors. If for some reason we need a test for palettes writing > out of bounds (which I don't think we do), that should go in palette.c. Since 256 was hard-coded in `GifDecoder_CopyPalette` for the no-GCT-present case (256 was correct for the test case), I had thought it might be worth-while to expand the testing. However, I suppose the `IWICPalette_GetColorCount` check should be sufficient. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3344#note_39204

1 0

Re: [PATCH v2 0/3] MR3344: windowscodecs: support GIF with no color table
by Esme Povirk (＠madewokherd) 17 Jul '23

17 Jul '23

Esme Povirk (@madewokherd) commented about dlls/windowscodecs/tests/gifformat.c: > ok(color[1] == 0x00040506, "expected 0x00040506, got %#x\n", color[1]); > ok(color[2] == 0xff070809, "expected 0xff070809, got %#x\n", color[2]); > ok(color[3] == 0xff0a0b0c, "expected 0xff0a0b0c, got %#x\n", color[3]); > + for (i = 4; i < 256; i++) > + ok(color[i] == 0xdeadbeef, "expected 0xdeadbeef, got %#x\n", color[i]); If the IWICPalette has only 4 colors in it, it can be assumed to only return 4 colors. If for some reason we need a test for palettes writing out of bounds (which I don't think we do), that should go in palette.c. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3344#note_39201

1 0

[PATCH v4 0/6] MR3302: Draft: gdiplus: Fix GdipGetPropertySize and GdipGetAllPropertyItems return values when no properties exist.
by Jeffrey Smith (＠whydoubt) 17 Jul '23

17 Jul '23

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=54748 -- v4: gdiplus: Fix GdipGetAllPropertyItems return value when no properties exist. gdiplus: Fix GdipGetPropertySize return value when no properties exist. gdiplus/tests: Pare down image property tests that are not run for Wine. gdiplus/tests: Use test context for test ran in a loop. gdiplus/tests: Add GIF to image properties tests. gdiplus/tests: Use consistent no-alternate value for image properties. https://gitlab.winehq.org/wine/wine/-/merge_requests/3302

3 8

[PATCH v3 0/1] MR3313: gdiplus/tests: Fix mangled test output when dumping data in hex format.
by Jeffrey Smith (＠whydoubt) 17 Jul '23

17 Jul '23

Some tests in gdiplus output hex-formatted data chunks, but it is very hard to read EXAMPLE BEFORE FIX: ``` image.c:4831: Test marked todo: 16: data should match image.c:4837: 40image.c:4837: 40image.c:4837: 40image.c:4837: 40image.c:4837: 40image.c:4837: 40image.c:4837: 80i mage.c:4837: 80image.c:4837: 80image.c:4837: 80image.c:4837: 80image.c:4837: 80image.c:4837: 40image.c:4837: 40im age.c:4837: 40image.c:4837: 40image.c:4837: 40image.c:4837: 40image.c:4837: 40image.c:4837: 40image.c:4837: 40ima ge.c:4837: 40image.c:4837: 40image.c:4837: 40image.c:4838: ``` EXAMPLE AFTER FIX: ``` image.c:4802: Test marked todo: 16: data should match image.c:4804: 40 40 40 40 40 40 80 80 80 80 80 80 40 40 40 40 40 40 40 40 40 40 40 40 ``` -- v3: gdiplus/tests: Fix mangled test output when dumping data in hex format. https://gitlab.winehq.org/wine/wine/-/merge_requests/3313

3 3

[PATCH v2 0/10] MR3300: jscript: WeakMap implementation.
by Gabriel Ivăncescu (＠insn) 17 Jul '23

17 Jul '23

-- v2: jscript: Properly set JS_E_WRONG_THIS as a TypeError. mshtml/tests: Add tests for WeakMap. jscript: Implement WeakMap.has(). jscript: Implement WeakMap.clear(). jscript: Implement WeakMap.delete(). jscript: Implement WeakMap.get(). jscript: Implement WeakMap.set(). jscript: Implement WeakMap instance stub and constructor. jscript: Move the GC traversal for unmarking alive objects into a helper jscript: Convert unlink_props to a helper that unlinks the entire object. https://gitlab.winehq.org/wine/wine/-/merge_requests/3300

3 22

[PATCH v5 0/1] MR477: d3drm/tests: Show Clear sets background color
by Alistair Leslie-Hughes (＠alesliehughes) 17 Jul '23

17 Jul '23

Signed-off-by: Alistair Leslie-Hughes <leslie_alistair(a)hotmail.com> -- v5: d3drm/tests: Show Clear sets background color https://gitlab.winehq.org/wine/wine/-/merge_requests/477

4 4

[PATCH 0/1] MR3348: include: Add more CLSIDs in d2d1effects.idl.
by Biswapriyo Nath (＠Biswa96) 17 Jul '23

17 Jul '23

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/3348

2 1

[PATCH v3 0/75] MR3168: Draft: Release 8.0.2.
by Michael Stefaniuc (＠mstefani) 17 Jul '23

17 Jul '23

-- v3: Release 8.0.2. localspl: Don't pass original document name to cupsStartDocument. wininet/tests: Update expected WineHQ certificate. winhttp/tests: Fix a test failure. This merge request has too many patches to be relayed via email. Please visit the URL below to see the contents of the merge request. https://gitlab.winehq.org/wine/wine/-/merge_requests/3168

5 13

[PATCH v4 0/5] MR273: vkd3d-shader: sm1 constants.
by Zebediah Figura (＠zfigura) 17 Jul '23

17 Jul '23

Most of the interesting part is the API (first patch); the rest is implementation. The basic idea is that we have predefined fixed numbers for the float, integer, and boolean constant arrays, and treat each of the three like a constant buffer. Implementation-wise, we lower sm1-style constant registers to sm4-style constant buffers and immediate constants, which are capable of expressing a strict superset of the same functionality. Note that use of immediate constants is *not* the way that wined3d currently handles DEF instructions, but rather those are uploaded via uniforms. Is there a reason for this? Relative addressing is not yet implemented. In theory it should be simple enough to either translate it directly, for external constants, or use sm4-style immediate constant buffers, for internal constants. There may be a snag if an application depends on relative addressing to cover a range of both internal and external constants; this surely would require manual assembly or an application bug, but we could implement it by copying to a temporary array using a private TEMP-like register type. -- Because API is easiest to review when there's a concrete user, I have functional patches hooking this up to wined3d, in the following branches: https://gitlab.winehq.org/zfigura/vkd3d/-/commits/himavant5 https://gitlab.winehq.org/zfigura/wine/-/commits/himavant_cb The vkd3d branch contains some extra commits necessary to compile basic shaders; I intend to submit these as soon as possible after the important API parts have been reviewed. I tested this patch series by building a mingw vkd3d tree with that branch, and running the shader runner through Wine, with a test that uses both internal and external constants: make tests/shader_runner.exe && WINE_D3D_CONFIG=renderer=vulkan wine tests/shader_runner.exe ../vkd3d/tests/hlsl/writemask-assignop-0.shader_test I actually originally wrote the API without a user in mind, and later hooked up the implementation in Wine, and was surprised to find how straightforward it ended up being, so I think that speaks quite strongly in favour of this API. Granted, I had already written "wined3d: Store push constants in wined3d_buffers in struct wined3d_state." by that point, but that was something I anticipated needing for Wine anyway, without thinking of vkd3d. -- I actually originally did the implementation all in spirv.c, mostly because this was before we had infrastructure in place to do passes on the middle IR. I much prefer this version, it's quite centralized in one place and I think ends up being simpler than the spirv.c version anyway, but I can retrieve the spirv.c version if anyone wants to see it. That said, we may not want to lower to VKD3DSPR_CONSTBUFFER for GLSL without UBOs (but then again, we could also just emit VKD3DSPR_CONSTBUFFER registers as plain GLSL arrays). The actual declaration of flat constants is kept in spirv. I suppose the alternative here is to instead declare buffers from the reflection information and simply ignore dcl_constantbuffer. I submitted the patch as-is since it seemed simple enough and I didn't want to block this work further on rewriting that part, but we may want to rewrite it in the future regardless. ``` After the torchlight red on sweaty faces After the frosty silence in the gardens After the agony in stony places The shouting and the crying Prison and palace and reverberation Of thunder of spring over distant mountains ``` -- v4: vkd3d-shader/spirv: Emit variables for flat constant buffers. vkd3d-shader/ir: Normalise sm1-style constants. vkd3d-shader/ir: Move normalization code from spirv.c to ir.c. vkd3d-shader/d3dbc: Scan descriptors for constant register sets. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/273

3 6

[PATCH v2 0/1] MR2969: include: Annotate IoAllocate functions with __WINE_(ALLOC_SIZE|DEALLOC|MALLOC).
by Alex Henrie (＠alexhenrie) 17 Jul '23

17 Jul '23

-- v2: include: Annotate IoAllocate functions with __WINE_(ALLOC_SIZE|DEALLOC|MALLOC). https://gitlab.winehq.org/wine/wine/-/merge_requests/2969

2 1

Re: [PATCH v2 0/1] MR3331: ntdll/tests: Add more reparse/junction point tests.
by Alex Henrie (＠alexhenrie) 17 Jul '23

17 Jul '23

On Mon Jul 17 16:08:54 2023 +0000, Erich Hoover wrote: > What I have in staging has a lot more tests than this, were you only > interested in these ones for some reason or are you just sending in the > first bit so that rebasing is easier? In this commit, I only took the tests from [the first patch](https://gitlab.winehq.org/wine/wine-staging/-/blob/4482bd34937ec6ab0…. Essentially, I'm trying to make it easier to upstream the junction point patches by splitting off small pieces of them, cleaning them up, and upstreaming them one at a time. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3331#note_39170

1 0

Re: [PATCH v2 0/1] MR3331: ntdll/tests: Add more reparse/junction point tests.
by Erich Hoover (＠ehoover) 17 Jul '23

17 Jul '23

What I have in staging has a lot more tests than this, were you only interested in these ones for some reason or are you just sending in the first bit so that rebasing is easier? -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3331#note_39168

1 0

Re: [PATCH v2 0/1] MR3331: ntdll/tests: Add more reparse/junction point tests.
by Alex Henrie (＠alexhenrie) 17 Jul '23

17 Jul '23

On Fri Jul 14 06:21:02 2023 +0000, **** wrote: > Marvin replied on the mailing list: > ``` > Hi, > It looks like your patch introduced the new failures shown below. > Please investigate and fix them before resubmitting your patch. > If they are not new, fixing them anyway would help a lot. Otherwise > please ask for the known failures list to be updated. > The tests also ran into some preexisting test failures. If you know how > to fix them that would be helpful. See the TestBot job for the details: > The full results can be found at: > https://testbot.winehq.org/JobDetails.pl?Key=134856 > Your paranoid android. > === w7pro64 (64 bit report) === > ntdll: > file.c:5702: Test failed: Unexpected error (0x0) > ``` I honestly don't know why this test failed. I have not been able to reproduce the failure a second time. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3331#note_39167

1 0

Re: [PATCH v2 0/1] MR3331: ntdll/tests: Add more reparse/junction point tests. - approved
by Erich Hoover (＠ehoover) 17 Jul '23

17 Jul '23

This merge request was approved by Erich Hoover. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3331

1 0

[PATCH v5 0/1] MR3347: klist: Add a program that lists Kerberos tickets.
by Maxim Karasev (＠mxkrsv) 17 Jul '23

17 Jul '23

It's a clean-room reimplementation that mimics Windows 10 program's output format. It prints all the information that is available via KerbQueryTicketCacheMessage. Also tested to work on Windows if dynamically linked + built with winegcc. For further extension of the functonality, implementing KerbQueryTicketCacheEx{,2,3}Message is required. -- v5: klist: Add a program that lists Kerberos tickets. https://gitlab.winehq.org/wine/wine/-/merge_requests/3347

2 1

Re: [PATCH v3 0/6] MR3346: win32u/wow64win: Client callback interface improvements. - approved
by Huw Davies (＠huw) 17 Jul '23

17 Jul '23

This merge request was approved by Huw Davies. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3346

1 0

[PATCH v4 0/1] MR3347: klist: Add a program that lists Kerberos tickets.
by Maxim Karasev (＠mxkrsv) 17 Jul '23

17 Jul '23

It's a clean-room reimplementation that mimics Windows 10 program's output format. It prints all the information that is available via KerbQueryTicketCacheMessage. Also tested to work on Windows if dynamically linked + built with winegcc. For further extension of the functonality, implementing KerbQueryTicketCacheEx{,2,3}Message is required. -- v4: klist: Add a program that lists Kerberos tickets. https://gitlab.winehq.org/wine/wine/-/merge_requests/3347

2 1

[PATCH v3 0/1] MR3347: klist: Add a program that lists Kerberos tickets.
by Maxim Karasev (＠mxkrsv) 17 Jul '23

17 Jul '23

It's a clean-room reimplementation that mimics Windows 10 program's output format. It prints all the information that is available via KerbQueryTicketCacheMessage. Also tested to work on Windows if dynamically linked + built with winegcc. For further extension of the functonality, implementing KerbQueryTicketCacheEx{,2,3}Message is required. -- v3: klist: Add a program that lists Kerberos tickets. https://gitlab.winehq.org/wine/wine/-/merge_requests/3347

3 2

[PATCH v2 0/1] MR3347: klist: Add a program that lists Kerberos tickets.
by Maxim Karasev (＠mxkrsv) 17 Jul '23

17 Jul '23

It's a clean-room reimplementation that mimics Windows 10 program's output format. It prints all the information that is available via KerbQueryTicketCacheMessage. Also tested to work on Windows if dynamically linked + built with winegcc. For further extension of the functonality, implementing KerbQueryTicketCacheEx{,2,3}Message is required. -- v2: klist: Add a program that lists Kerberos tickets. https://gitlab.winehq.org/wine/wine/-/merge_requests/3347

3 2

[PATCH 0/1] MR277: tests: Add a test for side effects of ternary operator.
by Nikolay Sivov (＠nsivov) 17 Jul '23

17 Jul '23

Signed-off-by: Nikolay Sivov <nsivov(a)codeweavers.com> -- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/277

5 4

[PATCH 0/1] MR276: vkd3d-shader/hlsl: Free the constant defs array in hlsl_ctx_cleanup().
by Zebediah Figura (＠zfigura) 17 Jul '23

17 Jul '23

Spotted by Francisco Casas. -- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/276

4 3

[PATCH v2 0/1] MR274: vkd3d-shader/tpf: Support some of the UAV types when writing RDEF records.
by Nikolay Sivov (＠nsivov) 17 Jul '23

17 Jul '23

Signed-off-by: Nikolay Sivov <nsivov(a)codeweavers.com> -- v2: vkd3d-shader/tpf: Support some of the UAV types when writing RDEF records. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/274

5 5

[PATCH v6 0/10] MR209: vkd3d-shader/hlsl: Broaden resources support v2, part 3.
by Francisco Casas (＠fcasas) 17 Jul '23

17 Jul '23

Mainly promoting single object components to variables for SM 5.0's RDEF block and lowering combined samplers to separate sampler+texture objects for SM 4. Following patches (including prepending uniform copies resource components within struct parameters) in: https://gitlab.winehq.org/fcasas/vkd3d/-/commits/master6c -- v6: vkd3d-shader/hlsl: Don't allocate all texture registers for synthetic separated samplers. vkd3d-shader/hlsl: Lower combined samplers to separate sampler and texture objects for SM4. vkd3d-shader/hlsl: Separate tracking of sampler_dim and usage for object components. vkd3d-shader/hlsl: Introduce hlsl_new_synthetic_var_named(). vkd3d-shader/hlsl: Check is_uniform instead of HLSL_STORAGE_UNIFORM when validating object refs. tests: Add lowering combined samplers tests. tests: Pass D3DCOMPILE_ENABLE_BACKWARDS_COMPATIBILITY when compiling with the shader-runner. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/209

5 14

Re: [PATCH v3 0/6] MR3346: win32u/wow64win: Client callback interface improvements.
by Huw Davies (＠huw) 17 Jul '23

17 Jul '23

Fixed a typo in a commit msg. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3346#note_39134

1 0

[PATCH v13 0/2] MR3114: comctl32/syslink: Check item type before increasing link ID in SYSLINK_LinkAtPt().
by Zhao Yi (＠Zhaoyi) 17 Jul '23

17 Jul '23

Fix the issue of incorrect linkid calculation due to a lack of judgment on the current type. Signed-off-by: Zhaoyi <zhaoyi(a)uniontech.com> -- v13: comctl32/syslink: Check item type before increasing link ID in SYSLINK_LinkAtPt(). https://gitlab.winehq.org/wine/wine/-/merge_requests/3114

4 7

[PATCH v5 0/4] MR3336: sapi: Miscellaneous fixes.
by Shaun Ren (＠shaunren) 17 Jul '23

17 Jul '23

-- v5: https://gitlab.winehq.org/wine/wine/-/merge_requests/3336

3 5

[PATCH v2 0/6] MR3346: win32u/wow64win: Client callback interface improvements.
by Jacek Caban (＠jacek) 17 Jul '23

17 Jul '23

This is a preparation for better handling of message packing between win32u and user32. It also removes some hacks that were needed before syscall separation completion. -- v2: win32u: Pass module name before packed lparam in win_hook_params. user32: Always use NtCallbackReturn to pass result from User32CallWindowsHook. wow64win: Convert parameters in place in wow64_NtUserCallWindowsHook. wow64win: Conver parameters in place in wow64_NtUserCallWinProc. https://gitlab.winehq.org/wine/wine/-/merge_requests/3346

2 6

[PATCH 0/4] MR3297: uiautomationcore: Initial COM event handler support.
by Connor McAdams (＠cmcadams) 17 Jul '23

17 Jul '23

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/3297

3 7

[PATCH 0/6] MR3346: win32u/wow64win: Client callback interface improvements.
by Jacek Caban (＠jacek) 17 Jul '23

17 Jul '23

This is a preparation for better handling of message packing between win32u and user32. It also removes some hacks that were needed before syscall separation completion. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3346

2 6

[PATCH 0/6] MR3260: wine{alsa,coreaudio,oss,pulse}: Move get_audio_session, get_audio_session_wrapper into mmdevapi.
by Davide Beatrici (＠davidebeatrici) 17 Jul '23

17 Jul '23

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/3260

5 14

[PATCH 0/3] MR3344: windowscodecs: support GIF with no color table
by Jeffrey Smith (＠whydoubt) 16 Jul '23

16 Jul '23

Decoding a GIF with no color table currently crashes on Wine. Windows supports such files, and the GIF spec explicitly allows it. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3344

2 3

[PATCH v3 0/6] MR3302: gdiplus: Fix GdipGetPropertySize and GdipGetAllPropertyItems return values when no properties exist.
by Jeffrey Smith (＠whydoubt) 16 Jul '23

16 Jul '23

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=54748 -- v3: gdiplus: Fix GdipGetAllPropertyItems return value when no properties exist. gdiplus: Fix GdipGetPropertySize return value when no properties exist. gdiplus/tests: Pare down image property tests that are not run for Wine. gdiplus/tests: Use test context for test ran in a loop. gdiplus/tests: Add GIF to image properties tests. gdiplus/tests: Use consistent no-alternate value for image properties. https://gitlab.winehq.org/wine/wine/-/merge_requests/3302

3 10

[PATCH 0/1] MR3343: d3d11/tests: Mark test failures specific to the Vulkan or GL renderers.
by Zebediah Figura (＠zfigura) 16 Jul '23

16 Jul '23

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/3343

3 2

[PATCH v4 0/1] MR3288: gdiplus: Clip polygons before drawing them
by David Kahurani (＠kahurani) 15 Jul '23

15 Jul '23

Validate user data before passing it to PolyDraw. The program in the bug requests to draw figures outrageously outside the DC's region after presumably, some uninitialized values happen as a result of a missing font. Native gdiplus seems to handle this gracefully so we probably also should. Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=41617 Signed-off-by: David Kahurani <k.kahurani(a)gmail.com> -- v4: gdiplus: Clip polygons before drawing them https://gitlab.winehq.org/wine/wine/-/merge_requests/3288

4 4

Re: [PATCH v2 0/2] MR3308: Remove DECLSPEC_HIDDEN gdiplus and twain_32 - approved
by Esme Povirk (＠madewokherd) 15 Jul '23

15 Jul '23

This merge request was approved by Esme Povirk. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3308

1 0

[PATCH v2 0/1] MR3313: gdiplus/tests: Fix mangled test output when dumping data in hex format.
by Jeffrey Smith (＠whydoubt) 15 Jul '23

15 Jul '23

Some tests in gdiplus output hex-formatted data chunks, but it is very hard to read EXAMPLE BEFORE FIX: ``` image.c:4831: Test marked todo: 16: data should match image.c:4837: 40image.c:4837: 40image.c:4837: 40image.c:4837: 40image.c:4837: 40image.c:4837: 40image.c:4837: 80i mage.c:4837: 80image.c:4837: 80image.c:4837: 80image.c:4837: 80image.c:4837: 80image.c:4837: 40image.c:4837: 40im age.c:4837: 40image.c:4837: 40image.c:4837: 40image.c:4837: 40image.c:4837: 40image.c:4837: 40image.c:4837: 40ima ge.c:4837: 40image.c:4837: 40image.c:4837: 40image.c:4838: ``` EXAMPLE AFTER FIX: ``` image.c:4802: Test marked todo: 16: data should match image.c:4804: 40 40 40 40 40 40 80 80 80 80 80 80 40 40 40 40 40 40 40 40 40 40 40 40 ``` -- v2: gdiplus/tests: Fix mangled test output when dumping data in hex format. https://gitlab.winehq.org/wine/wine/-/merge_requests/3313

3 2

[PATCH v4 0/1] MR3230: comdlg32: Add parent folder button to IFileDialog
by Jacob Czekalla (＠Maaka00524) 15 Jul '23

15 Jul '23

Fixes bug: https://bugs.winehq.org/show_bug.cgi?id=54812 -- v4: comdlg32: Add parent folder button to IFileDialog https://gitlab.winehq.org/wine/wine/-/merge_requests/3230

3 2

[PATCH v2 0/2] MR3311: mfmediaengine: Audio effect support.
by Bernhard Kölbl (＠besentv) 15 Jul '23

15 Jul '23

Notes: - One test VM doesn't have sound output, that's why I added the check for SAR availability. -- v2: mfmediaengine: Add support for inserting audio effects. mfmediaengine/tests: Add tests for audio effects. https://gitlab.winehq.org/wine/wine/-/merge_requests/3311

3 4

[PATCH v2 0/1] MR3341: ntdll: Fix restoring X16 and X17 in ARM64 syscall dispatcher.
by Jinoh Kang (＠iamahuman) 15 Jul '23

15 Jul '23

Today, NtContinue() on ARM64 does not restore X16 and X17 from the context. This is because the values for X16 and X17 are overwritten when the current thread returns to the "user mode" (PE side) via __wine_syscall_dispatcher, which in turn uses them as scratch registers for restoring SP and PC respectively. We cannot avoid using scratch registers when restoring SP and PC. This is because ARMv8 does not have an unprivileged (EL0) instruction that loads SP and PC from memory or non-GPR architectural state. Fix this by making ARM64 __wine_syscall_dispatcher perform a full context restore via raise(SIGUSR2) when NtContinue() is used. Since raising a signal is quite expensive, it should be done only when necessary. To achieve this, split the ARM64 syscall dispatcher's returning behaviour into a fast path (that does not involve signals) and a slow path (that involves signals): - If CONTEXT_INTEGER is not set, the dispatcher takes the fast path: the X16 and X17 registers are clobbered as usual. - If X16 == PC and X17 == SP, the dispatcher also takes the fast path: it can safely use X16 and X17 without corrupting the register values, since those two registers already have the desired values. This fast path is used in call_user_apc_dispatcher(), call_user_exception_dispatcher(), and call_init_thunk(). - Otherwise, the dispatcher takes the slow path: it raises SIGUSR2 and does full context restore in the signal handler. -- v2: ntdll: Fix restoring X16 and X17 in ARM64 syscall dispatcher. https://gitlab.winehq.org/wine/wine/-/merge_requests/3341

2 2

[PATCH 0/1] MR3341: ntdll: Fix restoring X16 and X17 in ARM64 syscall dispatcher.
by Jinoh Kang (＠iamahuman) 15 Jul '23

15 Jul '23

Today, NtContinue() on ARM64 does not restore X16 and X17 from the context. This is because X16 and X17 are used as scratch registers for restoring SP and PC respectively in __wine_syscall_dispatcher. Scratch registers are required because ARMv8 does not have an unprivileged (EL0) instruction that loads SP and PC from memory or non-GPR architectural state. Fix this by making ARM64 __wine_syscall_dispatcher perform a full context restore via raise(SIGUSR2) when NtContinue() is used. Since raising a signal is quite expensive, it should be done only when necessary. To achieve this, split the ARM64 syscall dispatcher's returning behaviour into a fast path (that does not involve signals) and a slow path (that involves signals): - If CONTEXT_INTEGER is not set, the dispatcher takes the fast path: the X16 and X17 registers are clobbered as usual. - If X16 == PC and X17 == SP, the dispatcher also takes the fast path: it can safely use X16 and X17 without corrupting the register values, since those two registers already have the desired values. This fast path is used in call_user_apc_dispatcher(), call_user_exception_dispatcher(), and call_init_thunk(). - Otherwise, the dispatcher takes the slow path: it raises SIGUSR2 and does full context restore in the signal handler. Fixes: 88e336214db94318b6657d641919fcce6be4a328 -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3341

2 1

[PATCH 0/1] MR3340: winegcc: Enable SafeSEH only on i386.
by Jinoh Kang (＠iamahuman) 15 Jul '23

15 Jul '23

SafeSEH is not applicable to architectures other than i386. This fixes compiling with the clang ARM assembler, which cannot parse ".def @feat.00" since "@" is parsed as the start of a line comment. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3340

2 1

[PATCH 0/3] MR3339: server: Cancel asyncs when the last handle in process is closed.
by Paul Gofman (＠gofman) 15 Jul '23

15 Jul '23

Supersedes !3329. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3339

3 4

[PATCH 0/4] MR3329: winsock: Better cancel asyncs when socket handle is closed.
by Paul Gofman (＠gofman) 15 Jul '23

15 Jul '23

It turns out that Windows have a special behaviour WRT cancelling asyncs for terminating thread (or already terminated thread when socket handle is closed) when there is no more open handles in the process for the socket (while there might be handles to it in another processes). We currently have a logic on cancelling async in server/async.c:cancel_terminating_thread_asyncs() called before thread termination. It has a special case ("async->completion && async->data.apc_context && !async->event") when async is not canceled (covered by the tests). It turns out that on Windows, if there are no more handles to the socket in the async's process, async is cancelled even in this case. Then, if thread is terminated while there are open handles in the same process, but those handles are closed after that, it turns out the asyncs should be canceled the same way, even if there are handles for the socket in another process. Why this is important (and, actually, makes some sense to me), is that it is very easy to duplicate all the open handles to the child process. Just e. g., Qt doesn't seem to have any way to create a process through QtProcess without inheriting handles. Programs might expect that once they close socket handle the async operations will be aborted and they receive completions on port. But that doesn't happen if they didn't use an event for overlapped operation and happened to create any child process with inherited handles after creating the socket. Windows behaviour looks to me as a workaround for this. Besides the present test, I also tested the same with AcceptEx and IOCTL_AFD_RECV which behaves the same. Just to note, closing the handle before thread termination when there are no other open handles is quite a different case. In its heart it behaves *somewhat* similar on Windows and Wine but not quite, hitting various issues. But that looks unrelated to the special case concerned in this patchset. Fixes Battle.net hanging on exit during "update and restart" (not to confuse with update itself not finishing which is an unrelated issue related to file DACLs). -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3329

3 25

[PATCH v4 0/5] MR3336: sapi: Miscellaneous fixes.
by Shaun Ren (＠shaunren) 15 Jul '23

15 Jul '23

-- v4: sapi/tests: Use SHDeleteKeyA instead of RegDeleteTreeA in token tests. sapi/tests: Fix ISpObjectToken::CreateInstance E_ACCESSDENIED error. sapi/tests: Fix intermittent duration test failure in mmaudio. https://gitlab.winehq.org/wine/wine/-/merge_requests/3336

2 5

Re: [PATCH v2 0/7] MR3305: Remove DECLSPEC_HIDDEN DirectX - approved
by Nikolay Sivov (＠nsivov) 14 Jul '23

14 Jul '23

This merge request was approved by Nikolay Sivov. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3305

1 0

[PATCH 0/1] MR3317: d3dcompiler/tests: Add another test for matrix majority flags.
by Nikolay Sivov (＠nsivov) 14 Jul '23

14 Jul '23

Signed-off-by: Nikolay Sivov <nsivov(a)codeweavers.com> -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3317

3 4

Re: [PATCH v2 0/2] MR3326: wmp: Two crash fixes - approved
by Alexandre Julliard (＠julliard) 14 Jul '23

14 Jul '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3326

1 0

Re: [PATCH v2 0/1] MR3325: shell32: Don't fall back to $HOME for missing user special folders. - approved
by Alexandre Julliard (＠julliard) 14 Jul '23

14 Jul '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3325

1 0

2025

2024

2023

2022

wine-gitlab